Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features

From: Chanwoo Choi <chanwoo@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Linux PM list <linux-pm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	lukasz.luba@arm.com,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Lin Huang <hl@rock-chips.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	jonathanh@nvidia.com, Abel Vesa <abel.vesa@nxp.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features
Date: Sat, 4 Jul 2020 05:34:11 +0900	[thread overview]
Message-ID: <CAGTfZH1uWaSHW5+URTj3SjvxRRZqF9WtMfofe+8X7BHCrk3R0g@mail.gmail.com> (raw)
In-Reply-To: <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com>

Hi Dmitry,

On Fri, Jul 3, 2020 at 7:46 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 03.07.2020 13:08, Chanwoo Choi пишет:
> > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> > index e94a27804c20..620ecd250d7c 100644
> > --- a/drivers/devfreq/tegra30-devfreq.c
> > +++ b/drivers/devfreq/tegra30-devfreq.c
> > @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
> >
> >  static struct devfreq_governor tegra_devfreq_governor = {
> >       .name = "tegra_actmon",
> > +     .flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> > +             | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,
>
> Hello, Chanwoo!
>
> There is a typo here, it should be ".attr = ".

Ah. Sorry. After changed the name, I didn't test COMPILE_TEST.

>
> > +     .flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> > +             | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,
>
> There is a typo here too FLAG_FLAG ^

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics