From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: jacopo mondi <jacopo@jmondi.org> Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 03/16] dt-bindings: display: renesas: lvds: Add EXTAL and DU_DOTCLKIN clocks Date: Fri, 14 Sep 2018 11:24:32 +0300 [thread overview] Message-ID: <6030546.koD4IuRgeG@avalon> (raw) In-Reply-To: <20180914080046.GK11509@w540> Hi Jacopo, On Friday, 14 September 2018 11:00:46 EEST jacopo mondi wrote: > On Tue, Sep 04, 2018 at 03:10:14PM +0300, Laurent Pinchart wrote: > > On the D3 and E3 SoCs, the LVDS encoder can derive its internal pixel > > clock from an externally supplied clock, either through the EXTAL pin or > > through one of the DU_DOTCLKINx pins. Add corresponding clocks to the DT > > bindings. > > > > To retain backward compatibility with DT that don't specify the > > clock-names property, the functional clock must always be specified > > first, and the clock-names property is optional when only the functional > > clock is specified. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 12 ++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt index > > 13af7e2ac7e8..9e3913f6a643 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > @@ -19,7 +19,17 @@ Required properties: > > - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS > > encoders > > > > - reg: Base address and length for the memory-mapped registers > > > > -- clocks: A phandle + clock-specifier pair for the functional clock > > +- clocks: A list of phandles + clock-specifier pairs, one for each entry > > in > > + the clock-names property. > > +- clock-names: Name of the clocks. This property is model-dependent. > > + - The functional clock is mandatory for all models, shall be listed > > first, > > I would write > > The functional clock, which is mandatory for all models, shall be listed > first and shall be named "fck". I'll change that. > > + and shall be named "fck". > > + - On R8A77990 and R8A77995, the LVDS encoder can use the EXTAL or > > + DU_DOTCLKINx clocks. Those clocks are optional. When supplied they > > must be > > + named "extal" and "dclkin.x" respectively, with "x" being the > > DU_DOTCLKIN > > + numerical index. > > Is it valid to list other clocks here for the other SoCs? No, those clocks only exist for D3 and E3, as stated (R8A77990 and R8A77995). Do you think the text isn't clear enough ? > > + - When the clocks property only contains the functional clock, the > > + clock-names property may be omitted. > > > > - resets: A phandle + reset specifier for the module reset > > Thanks > j > > > Required nodes: -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: jacopo mondi <jacopo@jmondi.org> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 03/16] dt-bindings: display: renesas: lvds: Add EXTAL and DU_DOTCLKIN clocks Date: Fri, 14 Sep 2018 11:24:32 +0300 [thread overview] Message-ID: <6030546.koD4IuRgeG@avalon> (raw) In-Reply-To: <20180914080046.GK11509@w540> Hi Jacopo, On Friday, 14 September 2018 11:00:46 EEST jacopo mondi wrote: > On Tue, Sep 04, 2018 at 03:10:14PM +0300, Laurent Pinchart wrote: > > On the D3 and E3 SoCs, the LVDS encoder can derive its internal pixel > > clock from an externally supplied clock, either through the EXTAL pin or > > through one of the DU_DOTCLKINx pins. Add corresponding clocks to the DT > > bindings. > > > > To retain backward compatibility with DT that don't specify the > > clock-names property, the functional clock must always be specified > > first, and the clock-names property is optional when only the functional > > clock is specified. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 12 ++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt index > > 13af7e2ac7e8..9e3913f6a643 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > @@ -19,7 +19,17 @@ Required properties: > > - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS > > encoders > > > > - reg: Base address and length for the memory-mapped registers > > > > -- clocks: A phandle + clock-specifier pair for the functional clock > > +- clocks: A list of phandles + clock-specifier pairs, one for each entry > > in > > + the clock-names property. > > +- clock-names: Name of the clocks. This property is model-dependent. > > + - The functional clock is mandatory for all models, shall be listed > > first, > > I would write > > The functional clock, which is mandatory for all models, shall be listed > first and shall be named "fck". I'll change that. > > + and shall be named "fck". > > + - On R8A77990 and R8A77995, the LVDS encoder can use the EXTAL or > > + DU_DOTCLKINx clocks. Those clocks are optional. When supplied they > > must be > > + named "extal" and "dclkin.x" respectively, with "x" being the > > DU_DOTCLKIN > > + numerical index. > > Is it valid to list other clocks here for the other SoCs? No, those clocks only exist for D3 and E3, as stated (R8A77990 and R8A77995). Do you think the text isn't clear enough ? > > + - When the clocks property only contains the functional clock, the > > + clock-names property may be omitted. > > > > - resets: A phandle + reset specifier for the module reset > > Thanks > j > > > Required nodes: -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2018-09-14 8:24 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-04 12:10 [PATCH 00/16] R-Car D3/E3 display support (with LVDS PLL) Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 01/16] dt-bindings: display: renesas: du: Document r8a77990 bindings Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-14 7:56 ` jacopo mondi 2018-09-14 7:56 ` jacopo mondi 2018-09-17 5:44 ` Rob Herring 2018-09-04 12:10 ` [PATCH 02/16] dt-bindings: display: renesas: lvds: " Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-14 7:57 ` jacopo mondi 2018-09-14 7:57 ` jacopo mondi 2018-09-17 5:44 ` Rob Herring 2018-09-04 12:10 ` [PATCH 03/16] dt-bindings: display: renesas: lvds: Add EXTAL and DU_DOTCLKIN clocks Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-14 8:00 ` jacopo mondi 2018-09-14 8:00 ` jacopo mondi 2018-09-14 8:24 ` Laurent Pinchart [this message] 2018-09-14 8:24 ` Laurent Pinchart 2018-09-14 8:35 ` jacopo mondi 2018-09-14 8:35 ` jacopo mondi 2018-09-04 12:10 ` [PATCH 04/16] drm: bridge: thc63: Restrict modes based on hardware operating frequency Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-11 13:31 ` jacopo mondi 2018-09-11 13:31 ` jacopo mondi 2018-09-13 21:08 ` Laurent Pinchart 2018-09-13 21:08 ` Laurent Pinchart 2018-09-13 12:36 ` Andrzej Hajda 2018-09-13 12:36 ` Andrzej Hajda 2018-09-04 12:10 ` [PATCH 05/16] drm: rcar-du: lvds: D3/E3 support Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 14:29 ` Geert Uytterhoeven 2018-09-04 14:29 ` Geert Uytterhoeven 2018-09-05 14:01 ` Laurent Pinchart 2018-09-05 14:01 ` Laurent Pinchart 2018-09-11 13:23 ` jacopo mondi 2018-09-11 13:23 ` jacopo mondi 2018-09-13 21:14 ` Laurent Pinchart 2018-09-13 21:14 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 06/16] drm: rcar-du: Perform the initial CRTC setup from rcar_du_crtc_get() Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-07 18:19 ` jacopo mondi 2018-09-07 18:19 ` jacopo mondi 2018-09-09 16:44 ` Laurent Pinchart 2018-09-09 16:44 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 07/16] drm: rcar-du: Use LVDS PLL clock as dot clock when possible Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-11 14:59 ` jacopo mondi 2018-09-11 14:59 ` jacopo mondi 2018-09-13 21:17 ` Laurent Pinchart 2018-09-13 21:17 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 08/16] drm: rcar-du: Enable configurable DPAD0 routing on Gen3 Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-11 15:46 ` jacopo mondi 2018-09-11 15:46 ` jacopo mondi 2018-09-13 21:25 ` Laurent Pinchart 2018-09-13 21:25 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 09/16] drm: rcar-du: Cache DSYSR value to ensure known initial value Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 10/16] drm: rcar-du: Don't use TV sync mode when not supported by the hardware Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 11/16] drm: rcar-du: Add r8a77990 and r8a77995 device support Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 12/16] arm64: dts: renesas: r8a77990: Add I2C device nodes Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 14:32 ` Geert Uytterhoeven 2018-09-04 14:32 ` Geert Uytterhoeven 2018-09-04 14:49 ` jacopo mondi 2018-09-04 14:49 ` jacopo mondi 2018-09-05 13:53 ` Laurent Pinchart 2018-09-05 13:53 ` Laurent Pinchart 2018-09-06 9:26 ` Simon Horman 2018-09-06 9:26 ` Simon Horman 2018-09-06 9:48 ` Laurent Pinchart 2018-09-06 9:48 ` Laurent Pinchart 2018-09-05 13:52 ` Laurent Pinchart 2018-09-05 13:52 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 13/16] arm64: dts: renesas: r8a77990: Add display output support Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 14/16] arm64: dts: renesas: r8a77995: Add LVDS support Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 15/16] arm64: dts: renesas: r8a77990: ebisu: Enable VGA and HDMI outputs Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-04 12:10 ` [PATCH 16/16] arm64: dts: renesas: r8a77995: draak: Enable HDMI display output Laurent Pinchart 2018-09-04 12:10 ` Laurent Pinchart 2018-09-05 16:22 ` [PATCH 00/16] R-Car D3/E3 display support (with LVDS PLL) jacopo mondi 2018-09-05 16:22 ` jacopo mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6030546.koD4IuRgeG@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacopo@jmondi.org \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.