All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	bgoswami@codeaurora.org, lgirdwood@gmail.com, tiwai@suse.de,
	plai@codeaurora.org
Subject: Re: [PATCH v8 00/22] ASoC: qcom: Add AudioReach support
Date: Mon, 27 Sep 2021 11:32:26 -0500	[thread overview]
Message-ID: <603b8650-d6cb-74e0-b6bd-3b650c6bd194@linux.intel.com> (raw)
In-Reply-To: <20210927135559.738-1-srinivas.kandagatla@linaro.org>




> Srinivas Kandagatla (22):
>   soc: dt-bindings: qcom: apr: convert to yaml
>   soc: dt-bindings: qcom: apr: deprecate qcom,apr-domain property
>   soc: qcom: apr: make code more reuseable
>   soc: dt-bindings: qcom: add gpr bindings
>   soc: qcom: apr: Add GPR support
>   ASoC: dt-bindings: move LPASS dai related bindings out of q6afe
>   ASoC: dt-bindings: move LPASS clocks related bindings out of q6afe
>   ASoC: dt-bindings: rename q6afe.h to q6dsp-lpass-ports.h
>   ASoC: qdsp6: q6afe-dai: move lpass audio ports to common file
>   ASoC: qdsp6: q6afe-clocks: move audio-clocks to common file
>   ASoC: dt-bindings: q6dsp: add q6apm-lpass-dai compatible
>   ASoC: dt-bindings: lpass-clocks: add q6prm clocks compatible
>   ASoC: dt-bindings: add q6apm digital audio stream bindings
>   ASoC: qdsp6: audioreach: add basic pkt alloc support
>   ASoC: qdsp6: audioreach: add q6apm support
>   ASoC: qdsp6: audioreach: add module configuration command helpers
>   ASoC: qdsp6: audioreach: add Kconfig and Makefile
>   ASoC: qdsp6: audioreach: add topology support
>   ASoC: qdsp6: audioreach: add q6apm-dai support
>   ASoC: qdsp6: audioreach: add q6apm lpass dai support
>   ASoC: qdsp6: audioreach: add q6prm support
>   ASoC: qdsp6: audioreach: add support for q6prm-clocks

I added a couple of minor comments, at this point other reviewers should
start looking at this patchset.

For patches 5, 9, 10, 14..22 (everything except dt-bindings which I
didn't even look at):

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>



WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org,
	lgirdwood@gmail.com
Subject: Re: [PATCH v8 00/22] ASoC: qcom: Add AudioReach support
Date: Mon, 27 Sep 2021 11:32:26 -0500	[thread overview]
Message-ID: <603b8650-d6cb-74e0-b6bd-3b650c6bd194@linux.intel.com> (raw)
In-Reply-To: <20210927135559.738-1-srinivas.kandagatla@linaro.org>




> Srinivas Kandagatla (22):
>   soc: dt-bindings: qcom: apr: convert to yaml
>   soc: dt-bindings: qcom: apr: deprecate qcom,apr-domain property
>   soc: qcom: apr: make code more reuseable
>   soc: dt-bindings: qcom: add gpr bindings
>   soc: qcom: apr: Add GPR support
>   ASoC: dt-bindings: move LPASS dai related bindings out of q6afe
>   ASoC: dt-bindings: move LPASS clocks related bindings out of q6afe
>   ASoC: dt-bindings: rename q6afe.h to q6dsp-lpass-ports.h
>   ASoC: qdsp6: q6afe-dai: move lpass audio ports to common file
>   ASoC: qdsp6: q6afe-clocks: move audio-clocks to common file
>   ASoC: dt-bindings: q6dsp: add q6apm-lpass-dai compatible
>   ASoC: dt-bindings: lpass-clocks: add q6prm clocks compatible
>   ASoC: dt-bindings: add q6apm digital audio stream bindings
>   ASoC: qdsp6: audioreach: add basic pkt alloc support
>   ASoC: qdsp6: audioreach: add q6apm support
>   ASoC: qdsp6: audioreach: add module configuration command helpers
>   ASoC: qdsp6: audioreach: add Kconfig and Makefile
>   ASoC: qdsp6: audioreach: add topology support
>   ASoC: qdsp6: audioreach: add q6apm-dai support
>   ASoC: qdsp6: audioreach: add q6apm lpass dai support
>   ASoC: qdsp6: audioreach: add q6prm support
>   ASoC: qdsp6: audioreach: add support for q6prm-clocks

I added a couple of minor comments, at this point other reviewers should
start looking at this patchset.

For patches 5, 9, 10, 14..22 (everything except dt-bindings which I
didn't even look at):

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>



  parent reply	other threads:[~2021-09-27 19:53 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 13:55 [PATCH v8 00/22] ASoC: qcom: Add AudioReach support Srinivas Kandagatla
2021-09-27 13:55 ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 01/22] soc: dt-bindings: qcom: apr: convert to yaml Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 02/22] soc: dt-bindings: qcom: apr: deprecate qcom,apr-domain property Srinivas Kandagatla
2021-09-27 13:55   ` [PATCH v8 02/22] soc: dt-bindings: qcom: apr: deprecate qcom, apr-domain property Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 03/22] soc: qcom: apr: make code more reuseable Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 04/22] soc: dt-bindings: qcom: add gpr bindings Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 05/22] soc: qcom: apr: Add GPR support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 06/22] ASoC: dt-bindings: move LPASS dai related bindings out of q6afe Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 07/22] ASoC: dt-bindings: move LPASS clocks " Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 08/22] ASoC: dt-bindings: rename q6afe.h to q6dsp-lpass-ports.h Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 09/22] ASoC: qdsp6: q6afe-dai: move lpass audio ports to common file Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 10/22] ASoC: qdsp6: q6afe-clocks: move audio-clocks " Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 11/22] ASoC: dt-bindings: q6dsp: add q6apm-lpass-dai compatible Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 12/22] ASoC: dt-bindings: lpass-clocks: add q6prm clocks compatible Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 13/22] ASoC: dt-bindings: add q6apm digital audio stream bindings Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 14/22] ASoC: qdsp6: audioreach: add basic pkt alloc support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 16:08   ` Pierre-Louis Bossart
2021-09-27 16:08     ` Pierre-Louis Bossart
2021-09-28 10:10     ` Srinivas Kandagatla
2021-09-28 10:10       ` Srinivas Kandagatla
2021-09-28  8:00   ` Amadeusz Sławiński
2021-09-28  8:00     ` Amadeusz Sławiński
2021-09-28  9:31     ` Srinivas Kandagatla
2021-09-28  9:31       ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 15/22] ASoC: qdsp6: audioreach: add q6apm support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-28  8:23   ` Amadeusz Sławiński
2021-09-28  8:23     ` Amadeusz Sławiński
2021-09-28  9:31     ` Srinivas Kandagatla
2021-09-28  9:31       ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 16/22] ASoC: qdsp6: audioreach: add module configuration command helpers Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 16:16   ` Pierre-Louis Bossart
2021-09-27 16:16     ` Pierre-Louis Bossart
2021-09-28 10:21     ` Srinivas Kandagatla
2021-09-28 10:21       ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 17/22] ASoC: qdsp6: audioreach: add Kconfig and Makefile Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 18/22] ASoC: qdsp6: audioreach: add topology support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 16:21   ` Pierre-Louis Bossart
2021-09-27 16:21     ` Pierre-Louis Bossart
2021-09-28  9:34     ` Srinivas Kandagatla
2021-09-28  9:34       ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 19/22] ASoC: qdsp6: audioreach: add q6apm-dai support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 16:25   ` Pierre-Louis Bossart
2021-09-27 16:25     ` Pierre-Louis Bossart
2021-09-28  9:33     ` Srinivas Kandagatla
2021-09-28  9:33       ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 20/22] ASoC: qdsp6: audioreach: add q6apm lpass dai support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 21/22] ASoC: qdsp6: audioreach: add q6prm support Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 13:55 ` [PATCH v8 22/22] ASoC: qdsp6: audioreach: add support for q6prm-clocks Srinivas Kandagatla
2021-09-27 13:55   ` Srinivas Kandagatla
2021-09-27 16:32 ` Pierre-Louis Bossart [this message]
2021-09-27 16:32   ` [PATCH v8 00/22] ASoC: qcom: Add AudioReach support Pierre-Louis Bossart
2021-09-28  3:19 ` Bjorn Andersson
2021-09-28  3:19   ` Bjorn Andersson
2021-09-28  3:20 ` (subset) " Bjorn Andersson
2021-09-28  3:20   ` Bjorn Andersson
2021-09-28  8:47   ` Srinivas Kandagatla
2021-09-28  8:47     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=603b8650-d6cb-74e0-b6bd-3b650c6bd194@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=plai@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.