From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: devi priya <quic_devipriy@quicinc.com>, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, tdas@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com Subject: Re: [PATCH 1/7] dt-bindings: arm64: ipq9574: Add binding descriptions for clock and reset Date: Wed, 11 Jan 2023 10:36:12 +0100 [thread overview] Message-ID: <603f9c39-3e36-bb44-2305-1d37fe033dd5@linaro.org> (raw) In-Reply-To: <20230110121316.24892-2-quic_devipriy@quicinc.com> On 10/01/2023 13:13, devi priya wrote: > Adding support for the global clock controller found on > IPQ9574 based devices Subject: drop second/last, redundant "bindings descriptions for". The "dt-bindings" prefix is already stating that these are bindings. > > Co-developed-by: Anusha Rao <quic_anusha@quicinc.com> > Signed-off-by: Anusha Rao <quic_anusha@quicinc.com> > Signed-off-by: devi priya <quic_devipriy@quicinc.com> > --- > .../bindings/clock/qcom,gcc-other.yaml | 4 + > .../devicetree/bindings/clock/qcom,gcc.yaml | 9 +- > include/dt-bindings/clock/qcom,gcc-ipq9574.h | 226 ++++++++++++++++++ > include/dt-bindings/reset/qcom,gcc-ipq9574.h | 164 +++++++++++++ > 4 files changed, 402 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq9574.h > create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq9574.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > index 2e8acca64af1..cc563d640336 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > @@ -18,6 +18,8 @@ description: | > include/dt-bindings/clock/qcom,gcc-ipq4019.h > include/dt-bindings/clock/qcom,gcc-ipq6018.h > include/dt-bindings/reset/qcom,gcc-ipq6018.h > + include/dt-bindings/clock/qcom,gcc-ipq9574.h > + include/dt-bindings/reset/qcom,gcc-ipq9574.h > include/dt-bindings/clock/qcom,gcc-msm8953.h > include/dt-bindings/clock/qcom,gcc-mdm9607.h > include/dt-bindings/clock/qcom,gcc-mdm9615.h > @@ -34,6 +36,8 @@ properties: > - qcom,gcc-mdm9607 > - qcom,gcc-msm8953 > - qcom,gcc-mdm9615 > + - qcom,gcc-ipq9574 Incorrect order but anyway let's switch to new naming style just like SM8550 and SA8775p. > + Not related change. > > required: > - compatible > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > index 7129fbcf2b6c..5a71268538e6 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > @@ -24,6 +24,14 @@ properties: > '#power-domain-cells': > const: 1 > > + clocks: > + minItems: 1 > + maxItems: 8 > + > + clock-names: > + minItems: 1 > + maxItems: 8 This does not look correct, neither related. > + > reg: > maxItems: 1 > > @@ -35,7 +43,6 @@ required: > - reg > - '#clock-cells' > - '#reset-cells' > - - '#power-domain-cells' Eee? Why? What's this? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: devi priya <quic_devipriy@quicinc.com>, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, tdas@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com Subject: Re: [PATCH 1/7] dt-bindings: arm64: ipq9574: Add binding descriptions for clock and reset Date: Wed, 11 Jan 2023 10:36:12 +0100 [thread overview] Message-ID: <603f9c39-3e36-bb44-2305-1d37fe033dd5@linaro.org> (raw) In-Reply-To: <20230110121316.24892-2-quic_devipriy@quicinc.com> On 10/01/2023 13:13, devi priya wrote: > Adding support for the global clock controller found on > IPQ9574 based devices Subject: drop second/last, redundant "bindings descriptions for". The "dt-bindings" prefix is already stating that these are bindings. > > Co-developed-by: Anusha Rao <quic_anusha@quicinc.com> > Signed-off-by: Anusha Rao <quic_anusha@quicinc.com> > Signed-off-by: devi priya <quic_devipriy@quicinc.com> > --- > .../bindings/clock/qcom,gcc-other.yaml | 4 + > .../devicetree/bindings/clock/qcom,gcc.yaml | 9 +- > include/dt-bindings/clock/qcom,gcc-ipq9574.h | 226 ++++++++++++++++++ > include/dt-bindings/reset/qcom,gcc-ipq9574.h | 164 +++++++++++++ > 4 files changed, 402 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq9574.h > create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq9574.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > index 2e8acca64af1..cc563d640336 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > @@ -18,6 +18,8 @@ description: | > include/dt-bindings/clock/qcom,gcc-ipq4019.h > include/dt-bindings/clock/qcom,gcc-ipq6018.h > include/dt-bindings/reset/qcom,gcc-ipq6018.h > + include/dt-bindings/clock/qcom,gcc-ipq9574.h > + include/dt-bindings/reset/qcom,gcc-ipq9574.h > include/dt-bindings/clock/qcom,gcc-msm8953.h > include/dt-bindings/clock/qcom,gcc-mdm9607.h > include/dt-bindings/clock/qcom,gcc-mdm9615.h > @@ -34,6 +36,8 @@ properties: > - qcom,gcc-mdm9607 > - qcom,gcc-msm8953 > - qcom,gcc-mdm9615 > + - qcom,gcc-ipq9574 Incorrect order but anyway let's switch to new naming style just like SM8550 and SA8775p. > + Not related change. > > required: > - compatible > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > index 7129fbcf2b6c..5a71268538e6 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > @@ -24,6 +24,14 @@ properties: > '#power-domain-cells': > const: 1 > > + clocks: > + minItems: 1 > + maxItems: 8 > + > + clock-names: > + minItems: 1 > + maxItems: 8 This does not look correct, neither related. > + > reg: > maxItems: 1 > > @@ -35,7 +43,6 @@ required: > - reg > - '#clock-cells' > - '#reset-cells' > - - '#power-domain-cells' Eee? Why? What's this? Best regards, Krzysztof
next prev parent reply other threads:[~2023-01-11 9:37 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-10 12:13 [PATCH 0/7] Add minimal boot support for IPQ9574 devi priya 2023-01-10 12:13 ` devi priya 2023-01-10 12:13 ` [PATCH 1/7] dt-bindings: arm64: ipq9574: Add binding descriptions for clock and reset devi priya 2023-01-10 12:13 ` devi priya 2023-01-10 13:29 ` Rob Herring 2023-01-10 13:29 ` Rob Herring 2023-01-13 12:24 ` Devi Priya 2023-01-13 12:24 ` Devi Priya 2023-01-11 9:36 ` Krzysztof Kozlowski [this message] 2023-01-11 9:36 ` Krzysztof Kozlowski 2023-01-13 13:08 ` Devi Priya 2023-01-13 13:08 ` Devi Priya 2023-01-11 9:46 ` Krzysztof Kozlowski 2023-01-11 9:46 ` Krzysztof Kozlowski 2023-01-13 13:10 ` Devi Priya 2023-01-13 13:10 ` Devi Priya 2023-01-10 12:13 ` [PATCH 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 devi priya 2023-01-10 12:37 ` Konrad Dybcio 2023-01-10 12:37 ` Konrad Dybcio 2023-01-13 13:21 ` Devi Priya 2023-01-13 13:21 ` Devi Priya 2023-01-13 14:09 ` Konrad Dybcio 2023-01-13 14:09 ` Konrad Dybcio 2023-01-24 7:27 ` Devi Priya 2023-01-24 7:27 ` Devi Priya 2023-01-24 9:53 ` Konrad Dybcio 2023-01-24 9:53 ` Konrad Dybcio 2023-01-24 13:50 ` Devi Priya 2023-01-24 13:50 ` Devi Priya 2023-01-10 12:13 ` [PATCH 3/7] dt-bindings: pinctrl: qcom: Add ipq9574 pinctrl bindings devi priya 2023-01-10 12:13 ` devi priya 2023-01-11 9:39 ` Krzysztof Kozlowski 2023-01-11 9:39 ` Krzysztof Kozlowski 2023-01-13 13:24 ` Devi Priya 2023-01-13 13:24 ` Devi Priya 2023-01-13 14:16 ` Krzysztof Kozlowski 2023-01-13 14:16 ` Krzysztof Kozlowski 2023-01-13 14:30 ` Devi Priya 2023-01-13 14:30 ` Devi Priya 2023-01-10 12:13 ` [PATCH 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver devi priya 2023-01-10 12:13 ` devi priya 2023-01-11 9:46 ` Krzysztof Kozlowski 2023-01-11 9:46 ` Krzysztof Kozlowski 2023-01-13 13:25 ` Devi Priya 2023-01-13 13:25 ` Devi Priya 2023-01-12 11:50 ` Kathiravan Thirumoorthy 2023-01-12 11:50 ` Kathiravan Thirumoorthy 2023-01-10 12:13 ` [PATCH 5/7] dt-bindings: qcom: Add ipq9574 bindings devi priya 2023-01-10 12:13 ` devi priya 2023-01-11 9:39 ` Krzysztof Kozlowski 2023-01-11 9:39 ` Krzysztof Kozlowski 2023-01-13 13:26 ` Devi Priya 2023-01-13 13:26 ` Devi Priya 2023-01-10 12:13 ` [PATCH 6/7] arm64: dts: Add ipq9574 SoC and AL02 board support devi priya 2023-01-10 12:13 ` devi priya 2023-01-10 12:50 ` Konrad Dybcio 2023-01-10 12:50 ` Konrad Dybcio 2023-01-24 6:16 ` Devi Priya 2023-01-24 6:16 ` Devi Priya 2023-01-11 9:44 ` Krzysztof Kozlowski 2023-01-11 9:44 ` Krzysztof Kozlowski 2023-01-11 9:48 ` Krzysztof Kozlowski 2023-01-11 9:48 ` Krzysztof Kozlowski 2023-01-13 13:31 ` Devi Priya 2023-01-13 13:31 ` Devi Priya 2023-01-11 14:52 ` Kathiravan Thirumoorthy 2023-01-11 14:52 ` Kathiravan Thirumoorthy 2023-01-13 13:34 ` Devi Priya 2023-01-13 13:34 ` Devi Priya 2023-01-13 13:29 ` Devi Priya 2023-01-13 13:29 ` Devi Priya 2023-01-13 14:20 ` Krzysztof Kozlowski 2023-01-13 14:20 ` Krzysztof Kozlowski 2023-01-24 7:19 ` Devi Priya 2023-01-24 7:19 ` Devi Priya 2023-01-24 8:36 ` Krzysztof Kozlowski 2023-01-24 8:36 ` Krzysztof Kozlowski 2023-01-24 9:46 ` Konrad Dybcio 2023-01-24 9:46 ` Konrad Dybcio 2023-01-24 13:22 ` Devi Priya 2023-01-24 13:22 ` Devi Priya 2023-01-11 9:45 ` Krzysztof Kozlowski 2023-01-11 9:45 ` Krzysztof Kozlowski 2023-01-13 13:36 ` Devi Priya 2023-01-13 13:36 ` Devi Priya 2023-01-13 13:49 ` Marc Zyngier 2023-01-13 13:49 ` Marc Zyngier 2023-01-13 13:52 ` Devi Priya 2023-01-13 13:52 ` Devi Priya 2023-01-10 12:13 ` [PATCH 7/7] arm64: defconfig: Enable IPQ9574 SoC base configs devi priya 2023-01-10 12:13 ` devi priya 2023-01-11 14:48 ` Kathiravan Thirumoorthy 2023-01-11 14:48 ` Kathiravan Thirumoorthy 2023-01-11 15:03 ` Krzysztof Kozlowski 2023-01-11 15:03 ` Krzysztof Kozlowski 2023-01-13 13:27 ` Devi Priya 2023-01-13 13:27 ` Devi Priya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=603f9c39-3e36-bb44-2305-1d37fe033dd5@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcel.ziswiler@toradex.com \ --cc=mturquette@baylibre.com \ --cc=nfraprado@collabora.com \ --cc=p.zabel@pengutronix.de \ --cc=quic_anusha@quicinc.com \ --cc=quic_arajkuma@quicinc.com \ --cc=quic_devipriy@quicinc.com \ --cc=quic_gokulsri@quicinc.com \ --cc=quic_kathirav@quicinc.com \ --cc=quic_poovendh@quicinc.com \ --cc=quic_sjaganat@quicinc.com \ --cc=quic_srichara@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tdas@codeaurora.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.