snd-hda-intel and MSI

snd-hda-intel and MSI

[Elimar Riesebieter]

[-- Attachment #1.1: Type: text/plain, Size: 1044 bytes --]

Hi folks,

are there any contradictions to enable-msi=1 by default? There are
users with chips like an

00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)
        Subsystem: Hewlett-Packard Company Device 30f7
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin B routed to IRQ 33
        Region 0: Memory at dc500000 (64-bit, non-prefetchable) [size=16K]
        Capabilities: <access denied>
        Kernel driver in use: HDA Intel

which only works with MSI. And it is somewhat hard to find the appropriate
Documantation in HD-Audio.txt. 2nd it will be very hard for Distributers to
maintain modul options by chip ID's.

Thanks for cooperation.

Elimar
(one of Debian's alsa maintainers)

-- 
  Do you smell something burning or ist it me?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: snd-hda-intel and MSI

[Takashi Iwai]

At Wed, 23 Sep 2009 16:33:06 +0200,
Elimar Riesebieter wrote:
> 
> Hi folks,
> 
> are there any contradictions to enable-msi=1 by default?

MSI is broken on some platforms.  IIRC, almost all non-Intel platforms
didn't work until the recent ones.  So, it can't be enabled blindly as
default, unfortunately.

> There are
> users with chips like an
> 
> 00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)
>         Subsystem: Hewlett-Packard Company Device 30f7
>         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0, Cache Line Size: 64 bytes
>         Interrupt: pin B routed to IRQ 33
>         Region 0: Memory at dc500000 (64-bit, non-prefetchable) [size=16K]
>         Capabilities: <access denied>
>         Kernel driver in use: HDA Intel
> 
> which only works with MSI. And it is somewhat hard to find the appropriate
> Documantation in HD-Audio.txt.

A patch is always welcome.

> 2nd it will be very hard for Distributers to
> maintain modul options by chip ID's.

It's not a question for distributors but the upstream maintainers 
to maintain the quirk table :)


thanks,

Takashi

Re: snd-hda-intel and MSI

[Tony Vroon]

[-- Attachment #1.1: Type: text/plain, Size: 534 bytes --]

On Wed, 2009-09-23 at 17:43 +0200, Takashi Iwai wrote:
> MSI is broken on some platforms.  IIRC, almost all non-Intel platforms
> didn't work until the recent ones.  So, it can't be enabled blindly as
> default, unfortunately.

Most of the "broken" platforms were AMD with integrated northbridges
where the required HyperTransport MSI mappings weren't enabled.
This is now handled correctly. I've seen graceful reverts where MSI
wasn't possible. (I recently submitted a patch for sata_nv to enable
MSI)

Regards,
Tony V.

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: snd-hda-intel and MSI

[Takashi Iwai]

At Wed, 23 Sep 2009 16:52:43 +0100,
Tony Vroon wrote:
> 
> On Wed, 2009-09-23 at 17:43 +0200, Takashi Iwai wrote:
> > MSI is broken on some platforms.  IIRC, almost all non-Intel platforms
> > didn't work until the recent ones.  So, it can't be enabled blindly as
> > default, unfortunately.
> 
> Most of the "broken" platforms were AMD with integrated northbridges
> where the required HyperTransport MSI mappings weren't enabled.
> This is now handled correctly. I've seen graceful reverts where MSI
> wasn't possible. (I recently submitted a patch for sata_nv to enable
> MSI)

Hm, a good point.  Maybe we can start running toward the wall again in
order to check whether it's thin enough to break through.   But, this
change is unlikely for 2.6.32.


Takashi

Re: snd-hda-intel and MSI

[Tony Vroon]

[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]

On Wed, 2009-09-23 at 17:58 +0200, Takashi Iwai wrote:
> But, this change is unlikely for 2.6.32.

I would be in favour of a 2.6.33 experiment though.
(Especially to invert behaviour, and make "MSI *will* enable but break"
an exception controlled through PCI IDs)

> Takashi

Regards,
Tony V.

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: snd-hda-intel and MSI

[Takashi Iwai]

At Wed, 23 Sep 2009 17:00:54 +0100,
Tony Vroon wrote:
> 
> On Wed, 2009-09-23 at 17:58 +0200, Takashi Iwai wrote:
> > But, this change is unlikely for 2.6.32.
> 
> I would be in favour of a 2.6.33 experiment though.
> (Especially to invert behaviour, and make "MSI *will* enable but break"
> an exception controlled through PCI IDs)

Yeah, that's what I meant implicitly :)


Takashi

Re: snd-hda-intel and MSI

[Takashi Iwai]

At Wed, 23 Sep 2009 18:03:14 +0200,
I wrote:
> 
> At Wed, 23 Sep 2009 17:00:54 +0100,
> Tony Vroon wrote:
> > 
> > On Wed, 2009-09-23 at 17:58 +0200, Takashi Iwai wrote:
> > > But, this change is unlikely for 2.6.32.
> > 
> > I would be in favour of a 2.6.33 experiment though.
> > (Especially to invert behaviour, and make "MSI *will* enable but break"
> > an exception controlled through PCI IDs)
> 
> Yeah, that's what I meant implicitly :)

Meanwhile, MSI still doesn't work with the older kernel, so we need
a black-list for the recent kernel in the upstream code and a
white-list for the older kernel as hda_intel.patch in alsa-driver
tree.  Sigh.


Takashi

Re: snd-hda-intel and MSI

[Elimar Riesebieter]

[-- Attachment #1.1: Type: text/plain, Size: 1438 bytes --]

* Takashi Iwai [090923 17:43 +0200]
> At Wed, 23 Sep 2009 16:33:06 +0200,
> Elimar Riesebieter wrote:
> > 
> > Hi folks,
> > 
> > are there any contradictions to enable-msi=1 by default?
> 
> MSI is broken on some platforms.  IIRC, almost all non-Intel platforms
> didn't work until the recent ones.  So, it can't be enabled blindly as
> default, unfortunately.
> 
> > There are
> > users with chips like an
> > 
> > 00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)
> >         Subsystem: Hewlett-Packard Company Device 30f7
> >         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
> >         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> >         Latency: 0, Cache Line Size: 64 bytes
> >         Interrupt: pin B routed to IRQ 33
> >         Region 0: Memory at dc500000 (64-bit, non-prefetchable) [size=16K]
> >         Capabilities: <access denied>
> >         Kernel driver in use: HDA Intel
> > 
> > which only works with MSI. And it is somewhat hard to find the appropriate
> > Documantation in HD-Audio.txt.
> 
> A patch is always welcome.

Which QUIRK Table. What informations from the soundcard ist needed
and how to get it?

Elimar


-- 
  Planung:
  Ersatz des Zufalls durch den Irrtum.
                                -unknown-

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: snd-hda-intel and MSI

[Daniel Chen]

On Wed, Sep 23, 2009 at 1:06 PM, Elimar Riesebieter <riesebie@lxtec.de> wrote:
>> > There are
>> > users with chips like an
>> >
>> > 00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)
>> >         Subsystem: Hewlett-Packard Company Device 30f7
...
> Which QUIRK Table. What informations from the soundcard ist needed
> and how to get it?

Elimar,

See http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=sound/pci/hda/hda_intel.c;h=20a66f85f0a4247b317d8bbd9e68dafe107e892e;hb=HEAD#l2305

Use the SSID for an entry, e.g.,

SND_PCI_QUIRK(0x103c, 0x30f7, "HP", 1),
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [Pkg-alsa-devel] Bug#547994: snd-hda-intel and MSI

[Elimar Riesebieter]

* Daniel Chen [090923 13:11 -0400]
> On Wed, Sep 23, 2009 at 1:06 PM, Elimar Riesebieter <riesebie@lxtec.de> wrote:
> >> > There are
> >> > users with chips like an
> >> >
> >> > 00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)
> >> >         Subsystem: Hewlett-Packard Company Device 30f7
> ...
> > Which QUIRK Table. What informations from the soundcard ist needed
> > and how to get it?
> 
> Elimar,
> 
> See http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=blob;f=sound/pci/hda/hda_intel.c;h=20a66f85f0a4247b317d8bbd9e68dafe107e892e;hb=HEAD#l2305
> 
> Use the SSID for an entry, e.g.,
> 
> SND_PCI_QUIRK(0x103c, 0x30f7, "HP", 1),

Does an easy QUIRK entry enables msi?

Elimar


-- 
  We all know Linux is great... it does infinite loops in 5 seconds.
        -- Linus Torvalds

Re: [Pkg-alsa-devel] Bug#547994: snd-hda-intel and MSI

[Daniel Chen]

On Wed, Sep 23, 2009 at 2:08 PM, Elimar Riesebieter <riesebie@lxtec.de> wrote:
>> SND_PCI_QUIRK(0x103c, 0x30f7, "HP", 1),
>
> Does an easy QUIRK entry enables msi?

Yes.

Re: [Pkg-alsa-devel] Bug#547994: snd-hda-intel and MSI

[Dan Chen]

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

Attached, please find a patch against current sound-2.6.git HEAD resolving this issue.

-Dan



      

[-- Attachment #2: 0001-Add-HP-Pavilion-dv4t-1300-to-MSI-whitelist.patch --]
[-- Type: application/octet-stream, Size: 953 bytes --]

From 409fdb7b75c21b031199069606c885d0ac918707 Mon Sep 17 00:00:00 2001
From: Daniel T Chen <seven.steps@gmail.com>
Date: Wed, 23 Sep 2009 20:23:27 -0400
Subject: [PATCH] Add HP Pavilion dv4t-1300 to MSI whitelist

BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=547994

Enable MSI by default for this Pavilion model.

Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/hda_intel.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 20a66f8..c9ad182 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2303,6 +2303,7 @@ static void __devinit check_probe_mask(struct azx *chip, int dev)
  * white-list for enable_msi
  */
 static struct snd_pci_quirk msi_white_list[] __devinitdata = {
+	SND_PCI_QUIRK(0x103c, 0x30f7, "HP Pavilion dv4t-1300", 1),
 	SND_PCI_QUIRK(0x103c, 0x3607, "HP Compa CQ40", 1),
 	{}
 };
-- 
1.6.3.3


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [Pkg-alsa-devel] Bug#547994: snd-hda-intel and MSI

[Takashi Iwai]

At Wed, 23 Sep 2009 17:28:38 -0700 (PDT),
Dan Chen wrote:
> 
> Attached, please find a patch against current sound-2.6.git HEAD resolving this issue.

Dan, your from-address and sign-off address are different in the patch.
Could you unify?


thanks,

Takashi

Re: [Pkg-alsa-devel] Bug#547994: snd-hda-intel and MSI

[Dan Chen]

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

> Dan, your from-address and sign-off address are different in the patch.
> Could you unify?

Indeed, here's a new patch.



      

[-- Attachment #2: 0001-Add-HP-Pavilion-dv4t-1300-to-MSI-whitelist.patch --]
[-- Type: application/octet-stream, Size: 950 bytes --]

From 409fdb7b75c21b031199069606c885d0ac918707 Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Wed, 23 Sep 2009 20:23:27 -0400
Subject: [PATCH] Add HP Pavilion dv4t-1300 to MSI whitelist

BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=547994

Enable MSI by default for this Pavilion model.

Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/hda_intel.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 20a66f8..c9ad182 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2303,6 +2303,7 @@ static void __devinit check_probe_mask(struct azx *chip, int dev)
  * white-list for enable_msi
  */
 static struct snd_pci_quirk msi_white_list[] __devinitdata = {
+	SND_PCI_QUIRK(0x103c, 0x30f7, "HP Pavilion dv4t-1300", 1),
 	SND_PCI_QUIRK(0x103c, 0x3607, "HP Compa CQ40", 1),
 	{}
 };
-- 
1.6.3.3


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [Pkg-alsa-devel] Bug#547994: snd-hda-intel and MSI

[Takashi Iwai]

At Thu, 24 Sep 2009 03:04:51 -0700 (PDT),
Dan Chen wrote:
> 
> > Dan, your from-address and sign-off address are different in the patch.
> > Could you unify?
> 
> Indeed, here's a new patch.

Thanks, applied now.


Takashi

Re: snd-hda-intel and MSI

[Takashi Iwai]

At Wed, 23 Sep 2009 18:11:33 +0200,
I wrote:
> 
> At Wed, 23 Sep 2009 18:03:14 +0200,
> I wrote:
> > 
> > At Wed, 23 Sep 2009 17:00:54 +0100,
> > Tony Vroon wrote:
> > > 
> > > On Wed, 2009-09-23 at 17:58 +0200, Takashi Iwai wrote:
> > > > But, this change is unlikely for 2.6.32.
> > > 
> > > I would be in favour of a 2.6.33 experiment though.
> > > (Especially to invert behaviour, and make "MSI *will* enable but break"
> > > an exception controlled through PCI IDs)
> > 
> > Yeah, that's what I meant implicitly :)
> 
> Meanwhile, MSI still doesn't work with the older kernel, so we need
> a black-list for the recent kernel in the upstream code and a
> white-list for the older kernel as hda_intel.patch in alsa-driver
> tree.  Sigh.

JFYI, now I changed the sound git tree to enable MSI as default.
alsa-driver-snapshot tarball is updated as well.
Let's see whether the things get settled down with this.


thanks,

Takashi

snd-hda-intel and MSI

[Takashi Iwai]

Hi,

since it turned out that there are so many boards/laptops with a
broken MSI support, the MSI feature is now disabled as default for
snd-hda-intel driver on the latest ALSA HG tree.
The module option to turn on/off MSI was renamed from disable_msi to
enable_msi, too.  For enabling the MSI again, pass enable_msi=1
manually.

If you have set disable_msi=1 in your modproble config files, please
remove it after updating the driver.  Otherwise modprobe would refuse
to load the module due to unsupported module option.


thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642