All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Wu <david.wu@rock-chips.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org
Cc: Jose Abreu <joabreu@synopsys.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Peter Geis <pgwipeout@gmail.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	Johan Jonker <jbx6244@gmail.com>,
	kernel@collabora.com
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi
Date: Mon, 26 Apr 2021 17:43:49 +0800	[thread overview]
Message-ID: <6051db67-d662-77f5-2fd9-2460c6abbe51@rock-chips.com> (raw)
In-Reply-To: <20210426024118.18717-1-ezequiel@collabora.com>

Hi Ezequiel,

在 2021/4/26 上午10:41, Ezequiel Garcia 写道:
> Rockchip DWMAC glue driver uses the phy node (phy-handle)
> reset specifier, and not a "mac-phy" reset specifier.
> 
> Remove it.
> 

Well done, the "mac-phy" reset is not part of the controller. So

Reviewed-by: David Wu <david.wu@rock-chips.com>

> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 5bab61784735..3ed69ecbcf3c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -916,8 +916,8 @@ gmac2phy: ethernet@ff550000 {
>   			      "mac_clk_tx", "clk_mac_ref",
>   			      "aclk_mac", "pclk_mac",
>   			      "clk_macphy";
> -		resets = <&cru SRST_GMAC2PHY_A>, <&cru SRST_MACPHY>;
> -		reset-names = "stmmaceth", "mac-phy";
> +		resets = <&cru SRST_GMAC2PHY_A>;
> +		reset-names = "stmmaceth";
>   		phy-mode = "rmii";
>   		phy-handle = <&phy>;
>   		snps,txpbl = <0x4>;
> 



WARNING: multiple messages have this Message-ID (diff)
From: David Wu <david.wu@rock-chips.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org
Cc: Jose Abreu <joabreu@synopsys.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Peter Geis <pgwipeout@gmail.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	Johan Jonker <jbx6244@gmail.com>,
	kernel@collabora.com
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi
Date: Mon, 26 Apr 2021 17:43:49 +0800	[thread overview]
Message-ID: <6051db67-d662-77f5-2fd9-2460c6abbe51@rock-chips.com> (raw)
In-Reply-To: <20210426024118.18717-1-ezequiel@collabora.com>

Hi Ezequiel,

在 2021/4/26 上午10:41, Ezequiel Garcia 写道:
> Rockchip DWMAC glue driver uses the phy node (phy-handle)
> reset specifier, and not a "mac-phy" reset specifier.
> 
> Remove it.
> 

Well done, the "mac-phy" reset is not part of the controller. So

Reviewed-by: David Wu <david.wu@rock-chips.com>

> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 5bab61784735..3ed69ecbcf3c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -916,8 +916,8 @@ gmac2phy: ethernet@ff550000 {
>   			      "mac_clk_tx", "clk_mac_ref",
>   			      "aclk_mac", "pclk_mac",
>   			      "clk_macphy";
> -		resets = <&cru SRST_GMAC2PHY_A>, <&cru SRST_MACPHY>;
> -		reset-names = "stmmaceth", "mac-phy";
> +		resets = <&cru SRST_GMAC2PHY_A>;
> +		reset-names = "stmmaceth";
>   		phy-mode = "rmii";
>   		phy-handle = <&phy>;
>   		snps,txpbl = <0x4>;
> 



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2021-04-26  9:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  2:41 [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi Ezequiel Garcia
2021-04-26  2:41 ` Ezequiel Garcia
2021-04-26  2:41 ` [PATCH 2/3] dt-bindings: net: dwmac: Add Rockchip DWMAC support Ezequiel Garcia
2021-04-26  2:41   ` Ezequiel Garcia
2021-04-26  9:49   ` David Wu
2021-04-26  9:49     ` David Wu
2021-04-29 21:39   ` Rob Herring
2021-04-29 21:39     ` Rob Herring
2021-04-26  2:41 ` [PATCH 3/3] dt-bindings: net: convert rockchip-dwmac to json-schema Ezequiel Garcia
2021-04-26  2:41   ` Ezequiel Garcia
2021-04-26  9:50   ` David Wu
2021-04-26  9:50     ` David Wu
2021-04-27 14:48   ` kernel test robot
2021-04-29 21:36   ` Rob Herring
2021-04-29 21:36     ` Rob Herring
2021-04-26  9:43 ` David Wu [this message]
2021-04-26  9:43   ` [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi David Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6051db67-d662-77f5-2fd9-2460c6abbe51@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=joabreu@synopsys.com \
    --cc=kernel@collabora.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kuba@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.