* [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
@ 2019-04-04 12:38 Oleksandr Andrushchenko
2019-04-04 12:42 ` [PATCH] " Juergen Gross
2019-04-04 12:42 ` [Xen-devel][PATCH] " Juergen Gross
0 siblings, 2 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2019-04-04 12:38 UTC (permalink / raw)
To: xen-devel, linux-kernel, alsa-devel, jgross, boris.ostrovsky,
konrad.wilk, perex, tiwai
Cc: andr2000, Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
This fixes the regression introduced while moving to Xen shared
buffer implementation.
Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
sound/xen/xen_snd_front_alsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index a7f413cb704d..b14ab512c2ce 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -441,7 +441,7 @@ static int shbuf_setup_backstore(struct xen_snd_front_pcm_stream_info *stream,
{
int i;
- stream->buffer = alloc_pages_exact(stream->buffer_sz, GFP_KERNEL);
+ stream->buffer = alloc_pages_exact(buffer_sz, GFP_KERNEL);
if (!stream->buffer)
return -ENOMEM;
--
2.21.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
2019-04-04 12:38 [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set Oleksandr Andrushchenko
2019-04-04 12:42 ` [PATCH] " Juergen Gross
@ 2019-04-04 12:42 ` Juergen Gross
2019-04-04 12:45 ` Takashi Iwai
2019-04-04 12:45 ` Takashi Iwai
1 sibling, 2 replies; 9+ messages in thread
From: Juergen Gross @ 2019-04-04 12:42 UTC (permalink / raw)
To: Oleksandr Andrushchenko, xen-devel, linux-kernel, alsa-devel,
boris.ostrovsky, konrad.wilk, perex, tiwai
Cc: Oleksandr Andrushchenko
On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> This fixes the regression introduced while moving to Xen shared
> buffer implementation.
>
> Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
2019-04-04 12:38 [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set Oleksandr Andrushchenko
@ 2019-04-04 12:42 ` Juergen Gross
2019-04-04 12:42 ` [Xen-devel][PATCH] " Juergen Gross
1 sibling, 0 replies; 9+ messages in thread
From: Juergen Gross @ 2019-04-04 12:42 UTC (permalink / raw)
To: Oleksandr Andrushchenko, xen-devel, linux-kernel, alsa-devel,
boris.ostrovsky, konrad.wilk, perex, tiwai
Cc: Oleksandr Andrushchenko
On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> This fixes the regression introduced while moving to Xen shared
> buffer implementation.
>
> Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
2019-04-04 12:42 ` [Xen-devel][PATCH] " Juergen Gross
@ 2019-04-04 12:45 ` Takashi Iwai
2019-04-04 12:45 ` Takashi Iwai
1 sibling, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2019-04-04 12:45 UTC (permalink / raw)
To: Juergen Gross
Cc: alsa-devel, Oleksandr Andrushchenko, xen-devel, boris.ostrovsky,
konrad.wilk, perex, linux-kernel, Oleksandr Andrushchenko
On Thu, 04 Apr 2019 14:42:44 +0200,
Juergen Gross wrote:
>
> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >
> > This fixes the regression introduced while moving to Xen shared
> > buffer implementation.
> >
> > Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
> >
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
@ 2019-04-04 12:45 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2019-04-04 12:45 UTC (permalink / raw)
To: Juergen Gross
Cc: alsa-devel, Oleksandr Andrushchenko, xen-devel, boris.ostrovsky,
konrad.wilk, perex, linux-kernel, Oleksandr Andrushchenko
On Thu, 04 Apr 2019 14:42:44 +0200,
Juergen Gross wrote:
>
> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >
> > This fixes the regression introduced while moving to Xen shared
> > buffer implementation.
> >
> > Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
> >
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
2019-04-04 12:42 ` [Xen-devel][PATCH] " Juergen Gross
2019-04-04 12:45 ` Takashi Iwai
@ 2019-04-04 12:45 ` Takashi Iwai
1 sibling, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2019-04-04 12:45 UTC (permalink / raw)
To: Juergen Gross
Cc: alsa-devel, konrad.wilk, Oleksandr Andrushchenko,
Oleksandr Andrushchenko, linux-kernel, perex, xen-devel,
boris.ostrovsky
On Thu, 04 Apr 2019 14:42:44 +0200,
Juergen Gross wrote:
>
> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >
> > This fixes the regression introduced while moving to Xen shared
> > buffer implementation.
> >
> > Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
> >
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.
Takashi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
2019-04-04 12:45 ` Takashi Iwai
(?)
@ 2019-04-04 12:46 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2019-04-04 12:46 UTC (permalink / raw)
To: Takashi Iwai, Juergen Gross
Cc: alsa-devel, xen-devel, boris.ostrovsky, konrad.wilk, perex,
linux-kernel, Oleksandr Andrushchenko
On 4/4/19 3:45 PM, Takashi Iwai wrote:
> On Thu, 04 Apr 2019 14:42:44 +0200,
> Juergen Gross wrote:
>> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> This fixes the regression introduced while moving to Xen shared
>>> buffer implementation.
>>>
>>> Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
> Applied now, thanks.
> I put Cc to stable since the bug was already in 5.0.
>
>
> Takashi
Thank you,
Oleksandr
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
2019-04-04 12:45 ` Takashi Iwai
(?)
(?)
@ 2019-04-04 12:46 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2019-04-04 12:46 UTC (permalink / raw)
To: Takashi Iwai, Juergen Gross
Cc: alsa-devel, konrad.wilk, Oleksandr Andrushchenko, linux-kernel,
perex, xen-devel, boris.ostrovsky
On 4/4/19 3:45 PM, Takashi Iwai wrote:
> On Thu, 04 Apr 2019 14:42:44 +0200,
> Juergen Gross wrote:
>> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> This fixes the regression introduced while moving to Xen shared
>>> buffer implementation.
>>>
>>> Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
> Applied now, thanks.
> I put Cc to stable since the bug was already in 5.0.
>
>
> Takashi
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
@ 2019-04-04 12:38 Oleksandr Andrushchenko
0 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2019-04-04 12:38 UTC (permalink / raw)
To: xen-devel, linux-kernel, alsa-devel, jgross, boris.ostrovsky,
konrad.wilk, perex, tiwai
Cc: andr2000, Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
This fixes the regression introduced while moving to Xen shared
buffer implementation.
Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
sound/xen/xen_snd_front_alsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index a7f413cb704d..b14ab512c2ce 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -441,7 +441,7 @@ static int shbuf_setup_backstore(struct xen_snd_front_pcm_stream_info *stream,
{
int i;
- stream->buffer = alloc_pages_exact(stream->buffer_sz, GFP_KERNEL);
+ stream->buffer = alloc_pages_exact(buffer_sz, GFP_KERNEL);
if (!stream->buffer)
return -ENOMEM;
--
2.21.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-04 12:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 12:38 [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set Oleksandr Andrushchenko
2019-04-04 12:42 ` [PATCH] " Juergen Gross
2019-04-04 12:42 ` [Xen-devel][PATCH] " Juergen Gross
2019-04-04 12:45 ` Takashi Iwai
2019-04-04 12:45 ` Takashi Iwai
2019-04-04 12:46 ` Oleksandr Andrushchenko
2019-04-04 12:46 ` [PATCH] " Oleksandr Andrushchenko
2019-04-04 12:45 ` Takashi Iwai
2019-04-04 12:38 Oleksandr Andrushchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.