[RFC PATCH v4] doc/mgmt-api - Return connection direction in Device Connected Event

[RFC PATCH v4] doc/mgmt-api - Return connection direction in Device Connected Event

[Yu Liu]

When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
space we will set the flags to tell if the established connection is
outbound or not. This is useful for the user space to log better metrics
and error messages.

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Alain Michaud <alainm@chromium.org>
---

Changes in v4:
- Removed Signed-off by line

Changes in v3:
- Reserve it in Device Found event

Changes in v2:
- Use next free bit

Changes in v1:
- Initial change

 doc/mgmt-api.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index cab1fffc5..5355fedb0 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -4088,6 +4088,7 @@ Device Connected Event
 		0	Reserved (not in use)
 		1	Legacy Pairing
 		2	Reserved (not in use)
+		3	Initiated Connection
 
 
 Device Disconnected Event
@@ -4261,6 +4262,7 @@ Device Found Event
 		0	Confirm name
 		1	Legacy Pairing
 		2	Not Connectable
+		3	Reserved (not in use)
 
 	For the RSSI field a value of 127 indicates that the RSSI is
 	not available. That can happen with Bluetooth 1.1 and earlier
-- 
2.31.0.208.g409f899ff0-goog

Re: [RFC PATCH v4] doc/mgmt-api - Return connection direction in Device Connected Event

[Luiz Augusto von Dentz]

Hi Yu,

On Fri, Apr 2, 2021 at 10:03 AM Yu Liu <yudiliu@google.com> wrote:
>
> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
> space we will set the flags to tell if the established connection is
> outbound or not. This is useful for the user space to log better metrics
> and error messages.
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Reviewed-by: Alain Michaud <alainm@chromium.org>
> ---
>
> Changes in v4:
> - Removed Signed-off by line

I suppose the v4 shouldn't be considered as RFC anymore, or does it?

> Changes in v3:
> - Reserve it in Device Found event
>
> Changes in v2:
> - Use next free bit
>
> Changes in v1:
> - Initial change
>
>  doc/mgmt-api.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index cab1fffc5..5355fedb0 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4088,6 +4088,7 @@ Device Connected Event
>                 0       Reserved (not in use)
>                 1       Legacy Pairing
>                 2       Reserved (not in use)
> +               3       Initiated Connection
>
>
>  Device Disconnected Event
> @@ -4261,6 +4262,7 @@ Device Found Event
>                 0       Confirm name
>                 1       Legacy Pairing
>                 2       Not Connectable
> +               3       Reserved (not in use)
>
>         For the RSSI field a value of 127 indicates that the RSSI is
>         not available. That can happen with Bluetooth 1.1 and earlier
> --
> 2.31.0.208.g409f899ff0-goog
>


-- 
Luiz Augusto von Dentz

RE: [RFC,v4] doc/mgmt-api - Return connection direction in Device Connected Event

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=460317

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild: Setup ELL - PASS

##############################
Test: CheckBuild: Setup - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS

##############################
Test: CheckBuild w/external ell - PASS



---
Regards,
Linux Bluetooth