[meta-cgl][PATCH] heartbeat: fix license issue

[meta-cgl][PATCH] heartbeat: fix license issue

[Armin Kuster]

From: Armin Kuster <akuster@mvista.com>

WARNING: heartbeat: LICENSE value "GPLv2 LGPLv2+" has an invalid format - license names must be separated by the following characters to indicate the license selection: &|()

Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb b/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb
index a866f0f..7ec7c5d 100644
--- a/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb
+++ b/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb
@@ -22,7 +22,7 @@ It implements the following kinds of heartbeats: \
 "
 HOMEPAGE = "http://linux-ha.org/"
 SECTION = "System Environment/Daemons"
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"
 LIC_FILES_CHKSUM = " \
     file://doc/COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b \
     file://doc/COPYING.LGPL;md5=d8045f3b8f929c1cb29a1e3fd737b499 \
-- 
1.9.1

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[Alexandru Vaduva]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Thank you for the patch.Applied and merged it upstream.
 

     On Saturday, February 14, 2015 7:00 AM, Armin Kuster <akuster808@gmail.com> wrote:
   

 From: Armin Kuster <akuster@mvista.com>

WARNING: heartbeat: LICENSE value "GPLv2 LGPLv2+" has an invalid format - license names must be separated by the following characters to indicate the license selection: &|()

Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb b/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb
index a866f0f..7ec7c5d 100644
--- a/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb
+++ b/meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb
@@ -22,7 +22,7 @@ It implements the following kinds of heartbeats: \
 "
 HOMEPAGE = "http://linux-ha.org/"
 SECTION = "System Environment/Daemons"
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"
 LIC_FILES_CHKSUM = " \
    file://doc/COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b \
    file://doc/COPYING.LGPL;md5=d8045f3b8f929c1cb29a1e3fd737b499 \
-- 
1.9.1

-- 
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto




[-- Attachment #2: Type: text/html, Size: 2641 bytes --]

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <akuster808@gmail.com> wrote:

> -LICENSE = "GPLv2 LGPLv2+"
> +LICENSE = "GPLv2 | LGPLv2+"
>

Are you sure this is correct? Afaict this is wrong, as there are parts of
the source tree under the GPL, and parts under LGPL, which means it's an
AND relationship -- both apply, not an OR relationship, where you can
choose which to use.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 963 bytes --]

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[Alexandru Vaduva]

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]

Hello Christopher,

Your observation is very accurate.
After a quick inspection I observed the following:

                    Inside heartbeat-suse.spec the next information: License:        GPL v2 only; LGPL v2.1 or later
Link here: http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-suse.spec

                    Inside heartbeat-fedora.spec the next information: License:          GPLv2 and LGPLv2+
Link here: http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fedora.spec

I added Lars Ellenberg one of the authors behind heartbeat or drbd to the discussion.
Hello Lars, sorry for disturbing you but maybe you could help us with our little problem.

If anyone from the Yocto Project community has any input on this matter please help.
For me at least this problem is not clear. Should the “|” sign remain or should it be replaced with the “&” one between the licenses.


Thanks guys,
Alex Vaduva



From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org] On Behalf Of Christopher Larson
Sent: Sunday, February 15, 2015 4:01 PM
To: Armin Kuster
Cc: yocto
Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue


On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <akuster808@gmail.com<mailto:akuster808@gmail.com>> wrote:
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 9007 bytes --]

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[Paul Eggleton]

On Monday 16 February 2015 09:18:29 Alexandru Vaduva wrote:
> After a quick inspection I observed the following:
> 
>                     Inside heartbeat-suse.spec the next information:
> License:        GPL v2 only; LGPL v2.1 or later Link here:
> http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-sus
> e.spec 
>                     Inside heartbeat-fedora.spec the next information:
> License:          GPLv2 and LGPLv2+  
> Link here:
> http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fed
> ora.spec 
> I added Lars Ellenberg one of the authors behind heartbeat or drbd to the
> discussion.
> Hello Lars, sorry for disturbing you but maybe you could help
> us with our little problem. 
> If anyone from the Yocto Project community has any input on this matter
> please help.
> For me at least this problem is not clear. Should the “|”
> sign remain or should it be replaced with the “&” one between the licenses.

What you have found above correlates with what Chris was saying - both 
licenses apply, therefore you must use &.
 
Cheers,
Paul
 

> From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org]
> On Behalf Of Christopher Larson
> Sent: Sunday, February 15, 2015 4:01 PM
> To: Armin Kuster
> Cc: yocto
> Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue
> 
> 
> On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster
> <akuster808@gmail.com<mailto:akuster808@gmail.com>> wrote:
> -LICENSE = "GPLv2 LGPLv2+"
> +LICENSE = "GPLv2 | LGPLv2+"
> 
> Are you sure this is correct? Afaict this is wrong, as there are parts of
> the source tree under the GPL, and parts under LGPL, which means it's an
> AND relationship -- both apply, not an OR relationship, where you can
> choose which to use.

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[Alexandru Vaduva]

[-- Attachment #1: Type: text/plain, Size: 2344 bytes --]

Ok,
Thanks,I will try to do the change accordingly.I spotted a new mistake, this time in one of my patches and I will try to send them both tomorrow for review.
 

     On Monday, February 16, 2015 6:31 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
   

 On Monday 16 February 2015 09:18:29 Alexandru Vaduva wrote:
> After a quick inspection I observed the following:
> 
>                    Inside heartbeat-suse.spec the next information:
> License:        GPL v2 only; LGPL v2.1 or later Link here:
> http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-sus
> e.spec 
>                    Inside heartbeat-fedora.spec the next information:
> License:          GPLv2 and LGPLv2+  
> Link here:
> http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fed
> ora.spec 
> I added Lars Ellenberg one of the authors behind heartbeat or drbd to the
> discussion.
> Hello Lars, sorry for disturbing you but maybe you could help
> us with our little problem. 
> If anyone from the Yocto Project community has any input on this matter
> please help.
> For me at least this problem is not clear. Should the “|”
> sign remain or should it be replaced with the “&” one between the licenses.

What you have found above correlates with what Chris was saying - both 
licenses apply, therefore you must use &.
 
Cheers,
Paul
 

> From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org]
> On Behalf Of Christopher Larson
> Sent: Sunday, February 15, 2015 4:01 PM
> To: Armin Kuster
> Cc: yocto
> Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue
> 
> 
> On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster
> <akuster808@gmail.com<mailto:akuster808@gmail.com>> wrote:
> -LICENSE = "GPLv2 LGPLv2+"
> +LICENSE = "GPLv2 | LGPLv2+"
> 
> Are you sure this is correct? Afaict this is wrong, as there are parts of
> the source tree under the GPL, and parts under LGPL, which means it's an
> AND relationship -- both apply, not an OR relationship, where you can
> choose which to use.

-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto




[-- Attachment #2: Type: text/html, Size: 5290 bytes --]

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[Lars Ellenberg]

[-- Attachment #1: Type: text/plain, Size: 2193 bytes --]

Am 16. Februar 2015 10:18:29 MEZ, schrieb Alexandru Vaduva <Alexandru.Vaduva@enea.com>:
>Hello Christopher,
>
>Your observation is very accurate.
>After a quick inspection I observed the following:
>
>Inside heartbeat-suse.spec the next information: License:        GPL v2
>only; LGPL v2.1 or later
>Link here:
>http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-suse.spec
>
>Inside heartbeat-fedora.spec the next information: License:         
>GPLv2 and LGPLv2+
>Link here:
>http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fedora.spec
>
>I added Lars Ellenberg one of the authors behind heartbeat or drbd to
>the discussion.
>Hello Lars, sorry for disturbing you but maybe you could help us with
>our little problem.
>
>If anyone from the Yocto Project community has any input on this matter
>please help.
>For me at least this problem is not clear. Should the “|” sign remain
>or should it be replaced with the “&” one between the licenses.
>
>
>Thanks guys,
>Alex Vaduva
>
>
>
>From: yocto-bounces@yoctoproject.org
>[mailto:yocto-bounces@yoctoproject.org] On Behalf Of Christopher Larson
>Sent: Sunday, February 15, 2015 4:01 PM
>To: Armin Kuster
>Cc: yocto
>Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue
>
>
>On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster
><akuster808@gmail.com<mailto:akuster808@gmail.com>> wrote:
>-LICENSE = "GPLv2 LGPLv2+"
>+LICENSE = "GPLv2 | LGPLv2+"
>
>Are you sure this is correct? Afaict this is wrong, as there are parts
>of the source tree under the GPL, and parts under LGPL, which means
>it's an AND relationship -- both apply, not an OR relationship, where
>you can choose which to use.
>--
>Christopher Larson
>clarson at kergoth dot com
>Founder - BitBake, OpenEmbedded, OpenZaurus
>Maintainer - Tslib
>Senior Software Engineer, Mentor Graphics

It is an "and".
Some parts have been taken from LGPL or dual license whatever/LGPL origin. Some GPL. So it is both, not an option or choice. Which parts are what however I do not know from the top of my head, I'd have to check, if it is relevant to you.

Thanks,
     Lars

[-- Attachment #2: Type: text/html, Size: 9449 bytes --]

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[akuster808]

It should be an ""&" (and).  I will send a updated patch soon.

- armin

On 02/16/2015 09:24 AM, Lars Ellenberg wrote:
> Am 16. Februar 2015 10:18:29 MEZ, schrieb Alexandru Vaduva
> <Alexandru.Vaduva@enea.com>:
>
>     Hello Christopher,
>
>     Your observation is very accurate.
>
>     After a quick inspection I observed the following:
>
>                          Inside heartbeat-suse.spec the next information:License:        GPL v2 only; LGPL v2.1 or later
>
>     Link here:
>     http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-suse.spec
>
>                          Inside heartbeat-fedora.spec the next information:License:          GPLv2 and LGPLv2+
>
>     Link here:
>     http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fedora.spec
>
>     I added Lars Ellenberg one of the authors behind heartbeat or drbd
>     to the discussion.
>
>     Hello Lars, sorry for disturbing you but maybe you could help us
>     with our little problem.
>
>     If anyone from the Yocto Project community has any input on this
>     matter please help.
>
>     For me at least this problem is not clear. Should the “|”sign remain
>     or should it be replaced with the “&”one between the licenses.
>
>     Thanks guys,
>
>     Alex Vaduva
>
>     *From:*yocto-bounces@yoctoproject.org
>     [mailto:yocto-bounces@yoctoproject.org] *On Behalf Of *Christopher
>     Larson
>     *Sent:* Sunday, February 15, 2015 4:01 PM
>     *To:* Armin Kuster
>     *Cc:* yocto
>     *Subject:* Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue
>
>     On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <akuster808@gmail.com
>     <mailto:akuster808@gmail.com>> wrote:
>
>     -LICENSE = "GPLv2 LGPLv2+"
>     +LICENSE = "GPLv2 | LGPLv2+"
>
>
>     Are you sure this is correct? Afaict this is wrong, as there are
>     parts of the source tree under the GPL, and parts under LGPL, which
>     means it's an AND relationship -- both apply, not an OR
>     relationship, where you can choose which to use.
>     --
>
>     Christopher Larson
>     clarson at kergoth dot com
>     Founder - BitBake, OpenEmbedded, OpenZaurus
>     Maintainer - Tslib
>     Senior Software Engineer, Mentor Graphics
>
>
> It is an "and".
> Some parts have been taken from LGPL or dual license whatever/LGPL
> origin. Some GPL. So it is both, not an option or choice. Which parts
> are what however I do not know from the top of my head, I'd have to
> check, if it is relevant to you.
>
> Thanks,
> Lars

Re: [meta-cgl][PATCH] heartbeat: fix license issue

[akuster]

Chris,

Thanks for catching this. I want to make sure I get these right.

Mahalo,
Armin

On 02/15/2015 06:01 AM, Christopher Larson wrote:
>
> On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <akuster808@gmail.com
> <mailto:akuster808@gmail.com>> wrote:
>
>     -LICENSE = "GPLv2 LGPLv2+"
>     +LICENSE = "GPLv2 | LGPLv2+"
>
>
> Are you sure this is correct? Afaict this is wrong, as there are parts
> of the source tree under the GPL, and parts under LGPL, which means it's
> an AND relationship -- both apply, not an OR relationship, where you can
> choose which to use.
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>
>