* [PATCH] serial: fsl_lpuart: Change DMA failure messages to debug level
@ 2020-04-16 15:15 Fabio Estevam
2020-04-16 15:28 ` Michael Walle
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2020-04-16 15:15 UTC (permalink / raw)
To: gregkh; +Cc: michael, linux-serial, Fabio Estevam
Since commit 159381df1442 ("tty: serial: fsl_lpuart: fix DMA operation when
using IOMMU") commit the following messages are seen when booting i.MX8QXP:
fsl-lpuart 5a060000.serial: DMA tx channel request failed, operating without tx DMA (-19)
fsl-lpuart 5a060000.serial: DMA rx channel request failed, operating without rx DMA (-19)
It is not really useful to have such messages on every boot, so change
them to debug level instead.
Fixes: 159381df1442 ("tty: serial: fsl_lpuart: fix DMA operation when using IOMMU")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 5d41075964f2..11131cd6cb30 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1514,17 +1514,17 @@ static void lpuart_request_dma(struct lpuart_port *sport)
{
sport->dma_tx_chan = dma_request_chan(sport->port.dev, "tx");
if (IS_ERR(sport->dma_tx_chan)) {
- dev_info_once(sport->port.dev,
- "DMA tx channel request failed, operating without tx DMA (%ld)\n",
- PTR_ERR(sport->dma_tx_chan));
+ dev_dbg_once(sport->port.dev,
+ "DMA tx channel request failed, operating without tx DMA (%ld)\n",
+ PTR_ERR(sport->dma_tx_chan));
sport->dma_tx_chan = NULL;
}
sport->dma_rx_chan = dma_request_chan(sport->port.dev, "rx");
if (IS_ERR(sport->dma_rx_chan)) {
- dev_info_once(sport->port.dev,
- "DMA rx channel request failed, operating without rx DMA (%ld)\n",
- PTR_ERR(sport->dma_rx_chan));
+ dev_dbg_once(sport->port.dev,
+ "DMA rx channel request failed, operating without rx DMA (%ld)\n",
+ PTR_ERR(sport->dma_rx_chan));
sport->dma_rx_chan = NULL;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: fsl_lpuart: Change DMA failure messages to debug level
2020-04-16 15:15 [PATCH] serial: fsl_lpuart: Change DMA failure messages to debug level Fabio Estevam
@ 2020-04-16 15:28 ` Michael Walle
2020-04-16 15:33 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Michael Walle @ 2020-04-16 15:28 UTC (permalink / raw)
To: Fabio Estevam; +Cc: gregkh, linux-serial
Am 2020-04-16 17:15, schrieb Fabio Estevam:
> Since commit 159381df1442 ("tty: serial: fsl_lpuart: fix DMA operation
> when
> using IOMMU") commit the following messages are seen when booting
> i.MX8QXP:
Are you sure, they weren't seen before? Because before the commit there
were
the same just in _probe() (as dev_info()).
I'm fine with changing it to debug messages, though.
-michael
> fsl-lpuart 5a060000.serial: DMA tx channel request failed, operating
> without tx DMA (-19)
> fsl-lpuart 5a060000.serial: DMA rx channel request failed, operating
> without rx DMA (-19)
>
> It is not really useful to have such messages on every boot, so change
> them to debug level instead.
>
> Fixes: 159381df1442 ("tty: serial: fsl_lpuart: fix DMA operation when
> using IOMMU")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c
> b/drivers/tty/serial/fsl_lpuart.c
> index 5d41075964f2..11131cd6cb30 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1514,17 +1514,17 @@ static void lpuart_request_dma(struct
> lpuart_port *sport)
> {
> sport->dma_tx_chan = dma_request_chan(sport->port.dev, "tx");
> if (IS_ERR(sport->dma_tx_chan)) {
> - dev_info_once(sport->port.dev,
> - "DMA tx channel request failed, operating without tx DMA
> (%ld)\n",
> - PTR_ERR(sport->dma_tx_chan));
> + dev_dbg_once(sport->port.dev,
> + "DMA tx channel request failed, operating without tx DMA
> (%ld)\n",
> + PTR_ERR(sport->dma_tx_chan));
> sport->dma_tx_chan = NULL;
> }
>
> sport->dma_rx_chan = dma_request_chan(sport->port.dev, "rx");
> if (IS_ERR(sport->dma_rx_chan)) {
> - dev_info_once(sport->port.dev,
> - "DMA rx channel request failed, operating without rx DMA
> (%ld)\n",
> - PTR_ERR(sport->dma_rx_chan));
> + dev_dbg_once(sport->port.dev,
> + "DMA rx channel request failed, operating without rx DMA
> (%ld)\n",
> + PTR_ERR(sport->dma_rx_chan));
> sport->dma_rx_chan = NULL;
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: fsl_lpuart: Change DMA failure messages to debug level
2020-04-16 15:28 ` Michael Walle
@ 2020-04-16 15:33 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-04-16 15:33 UTC (permalink / raw)
To: Michael Walle; +Cc: Greg Kroah-Hartman, linux-serial
On Thu, Apr 16, 2020 at 12:28 PM Michael Walle <michael@walle.cc> wrote:
> Are you sure, they weren't seen before? Because before the commit there
> were
> the same just in _probe() (as dev_info()).
Good point. Maybe I will just drop the commit reference and Fixes tag then.
I will submit a v2, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 15:15 [PATCH] serial: fsl_lpuart: Change DMA failure messages to debug level Fabio Estevam
2020-04-16 15:28 ` Michael Walle
2020-04-16 15:33 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.