* [PATCH for v5.8] vicodec: add missing v4l2_ctrl_request_hdl_put()
@ 2020-08-12 10:30 Hans Verkuil
2020-08-12 19:53 ` Ezequiel Garcia
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2020-08-12 10:30 UTC (permalink / raw)
To: Linux Media Mailing List
The check for a required control in the request was missing a call to
v4l2_ctrl_request_hdl_put(), so the control request object was never
released.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 997deb811bf5 ("media: vicodec: Add support for stateless decoder.")
---
diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c
index 8941d73f6611..71928e30dae8 100644
--- a/drivers/media/test-drivers/vicodec/vicodec-core.c
+++ b/drivers/media/test-drivers/vicodec/vicodec-core.c
@@ -1994,6 +1994,7 @@ static int vicodec_request_validate(struct media_request *req)
}
ctrl = v4l2_ctrl_request_hdl_ctrl_find(hdl,
vicodec_ctrl_stateless_state.id);
+ v4l2_ctrl_request_hdl_put(hdl);
if (!ctrl) {
v4l2_info(&ctx->dev->v4l2_dev,
"Missing required codec control\n");
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for v5.8] vicodec: add missing v4l2_ctrl_request_hdl_put()
2020-08-12 10:30 [PATCH for v5.8] vicodec: add missing v4l2_ctrl_request_hdl_put() Hans Verkuil
@ 2020-08-12 19:53 ` Ezequiel Garcia
2020-08-13 7:07 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Ezequiel Garcia @ 2020-08-12 19:53 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
On Wed, 12 Aug 2020 at 07:30, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> The check for a required control in the request was missing a call to
> v4l2_ctrl_request_hdl_put(), so the control request object was never
> released.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Fixes: 997deb811bf5 ("media: vicodec: Add support for stateless decoder.")
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Seems there's a similar leak in cedrus_request_validate error path,
when v4l2_ctrl_request_hdl_ctrl_find fails.
Cheers,
Ezequiel
> ---
> diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c
> index 8941d73f6611..71928e30dae8 100644
> --- a/drivers/media/test-drivers/vicodec/vicodec-core.c
> +++ b/drivers/media/test-drivers/vicodec/vicodec-core.c
> @@ -1994,6 +1994,7 @@ static int vicodec_request_validate(struct media_request *req)
> }
> ctrl = v4l2_ctrl_request_hdl_ctrl_find(hdl,
> vicodec_ctrl_stateless_state.id);
> + v4l2_ctrl_request_hdl_put(hdl);
> if (!ctrl) {
> v4l2_info(&ctx->dev->v4l2_dev,
> "Missing required codec control\n");
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for v5.8] vicodec: add missing v4l2_ctrl_request_hdl_put()
2020-08-12 19:53 ` Ezequiel Garcia
@ 2020-08-13 7:07 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2020-08-13 7:07 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: Linux Media Mailing List
On 12/08/2020 21:53, Ezequiel Garcia wrote:
> On Wed, 12 Aug 2020 at 07:30, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>
>> The check for a required control in the request was missing a call to
>> v4l2_ctrl_request_hdl_put(), so the control request object was never
>> released.
>>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> Fixes: 997deb811bf5 ("media: vicodec: Add support for stateless decoder.")
>
> Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
>
> Seems there's a similar leak in cedrus_request_validate error path,
> when v4l2_ctrl_request_hdl_ctrl_find fails.
Correct. Will you make a patch for that?
Regards,
Hans
>
> Cheers,
> Ezequiel
>
>> ---
>> diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c
>> index 8941d73f6611..71928e30dae8 100644
>> --- a/drivers/media/test-drivers/vicodec/vicodec-core.c
>> +++ b/drivers/media/test-drivers/vicodec/vicodec-core.c
>> @@ -1994,6 +1994,7 @@ static int vicodec_request_validate(struct media_request *req)
>> }
>> ctrl = v4l2_ctrl_request_hdl_ctrl_find(hdl,
>> vicodec_ctrl_stateless_state.id);
>> + v4l2_ctrl_request_hdl_put(hdl);
>> if (!ctrl) {
>> v4l2_info(&ctx->dev->v4l2_dev,
>> "Missing required codec control\n");
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-13 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 10:30 [PATCH for v5.8] vicodec: add missing v4l2_ctrl_request_hdl_put() Hans Verkuil
2020-08-12 19:53 ` Ezequiel Garcia
2020-08-13 7:07 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.