From: Neil Armstrong <narmstrong@baylibre.com>
To: u-boot@lists.denx.de
Subject: [PATCH] usb: dwc3-meson-g12a: skip phy on -ENODATA aswell
Date: Fri, 7 May 2021 16:55:13 +0200 [thread overview]
Message-ID: <60e0e17e-1d81-df5f-3e5e-71bd18ab7e90@baylibre.com> (raw)
In-Reply-To: <71f9ffcc-58bf-9e74-fe15-ffab5d4fe248@denx.de>
On 05/05/2021 12:06, Marek Vasut wrote:
> On 5/5/21 10:41 AM, Neil Armstrong wrote:
>> If the PHY isn't specified in the DT, -ENODATA means it should be skipped,
>> handle it like -ENOENT.
>>
>> With that, devices without USB3 supported can have USB working (Odroid-HC4).
>
> Shouldn't you rather specify NOP PHY in the DT ?
Who NOP I would have no idea if the port is disabled or used.
The PHY control is mixed between the actual PHY driver and the DWC3/DWC2 glue, so the bindings were designed
to make some PHYs phandle optionals if unused.
Neil
next prev parent reply other threads:[~2021-05-07 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 8:41 [PATCH] usb: dwc3-meson-g12a: skip phy on -ENODATA aswell Neil Armstrong
2021-05-05 8:41 ` Neil Armstrong
2021-05-05 10:06 ` Marek Vasut
2021-05-07 14:55 ` Neil Armstrong [this message]
2021-05-14 15:42 ` Neil Armstrong
2021-05-14 15:42 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e0e17e-1d81-df5f-3e5e-71bd18ab7e90@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.