* [PATCH RESEND v2 1/3] usb: xhci-mtk: add generic compatible string
@ 2017-08-29 9:20 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: linux-arm-kernel
The xhci-mtk driver is a generic driver for MediaTek xHCI IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 67d5dc7..8fb6065 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -795,6 +795,7 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev)
#ifdef CONFIG_OF
static const struct of_device_id mtk_xhci_of_match[] = {
{ .compatible = "mediatek,mt8173-xhci"},
+ { .compatible = "mediatek,mtk-xhci"},
{ },
};
MODULE_DEVICE_TABLE(of, mtk_xhci_of_match);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH RESEND v2 1/3] usb: xhci-mtk: add generic compatible string
@ 2017-08-29 9:20 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring
Cc: Matthias Brugger, Mark Rutland, Ian Campbell, Chunfeng Yun,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
The xhci-mtk driver is a generic driver for MediaTek xHCI IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".
Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
drivers/usb/host/xhci-mtk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 67d5dc7..8fb6065 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -795,6 +795,7 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev)
#ifdef CONFIG_OF
static const struct of_device_id mtk_xhci_of_match[] = {
{ .compatible = "mediatek,mt8173-xhci"},
+ { .compatible = "mediatek,mtk-xhci"},
{ },
};
MODULE_DEVICE_TABLE(of, mtk_xhci_of_match);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH RESEND v2 2/3] dt-bindings: mt8173-xhci: add generic compatible and rename file
2017-08-29 9:20 ` Chunfeng Yun
(?)
@ 2017-08-29 9:20 ` Chunfeng Yun
-1 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring
Cc: Matthias Brugger, Mark Rutland, Ian Campbell, Chunfeng Yun,
linux-kernel, linux-arm-kernel, linux-usb, linux-mediatek,
devicetree
The mt8173-xhci.txt actually holds the bindings for all mediatek
SoCs with xHCI controller, so add a generic compatible and change
the name to mediatek,mtk-xhci.txt to reflect that.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
.../usb/{mt8173-xhci.txt => mediatek,mtk-xhci.txt} | 14 +++++++++++---
.../devicetree/bindings/usb/mt8173-mtu3.txt | 2 +-
2 files changed, 12 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => mediatek,mtk-xhci.txt} (85%)
diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
similarity index 85%
rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
rename to Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
index 0acfc8a..ff21135 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
@@ -11,7 +11,11 @@ into two parts.
------------------------------------------------------------------------
Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be "mediatek,soc-model-xhci", "mediatek,mtk-xhci",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc, when using
+ "mediatek,mtk-xhci" compatible string, you need SoC specific ones in
+ addition, one of:
+ - "mediatek,mt8173-xhci"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
- interrupts : interrupt used by the controller
@@ -68,10 +72,14 @@ usb30: usb@11270000 {
In the case, xhci is added as subnode to mtu3. An example and the DT binding
details of mtu3 can be found in:
-Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be "mediatek,soc-model-xhci", "mediatek,mtk-xhci",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc, when using
+ "mediatek,mtk-xhci" compatible string, you need SoC specific ones in
+ addition, one of:
+ - "mediatek,mt8173-xhci"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for xHCI MAC
- interrupts : interrupt used by the host controller
diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
index 1d7c3bc..b8ea394 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
@@ -44,7 +44,7 @@ Optional properties:
Sub-nodes:
The xhci should be added as subnode to mtu3 as shown in the following example
if host mode is enabled. The DT binding details of xhci can be found in:
-Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
Example:
ssusb: usb@11271000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH RESEND v2 2/3] dt-bindings: mt8173-xhci: add generic compatible and rename file
@ 2017-08-29 9:20 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: linux-arm-kernel
The mt8173-xhci.txt actually holds the bindings for all mediatek
SoCs with xHCI controller, so add a generic compatible and change
the name to mediatek,mtk-xhci.txt to reflect that.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
.../usb/{mt8173-xhci.txt => mediatek,mtk-xhci.txt} | 14 +++++++++++---
.../devicetree/bindings/usb/mt8173-mtu3.txt | 2 +-
2 files changed, 12 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => mediatek,mtk-xhci.txt} (85%)
diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
similarity index 85%
rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
rename to Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
index 0acfc8a..ff21135 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
@@ -11,7 +11,11 @@ into two parts.
------------------------------------------------------------------------
Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be "mediatek,soc-model-xhci", "mediatek,mtk-xhci",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc, when using
+ "mediatek,mtk-xhci" compatible string, you need SoC specific ones in
+ addition, one of:
+ - "mediatek,mt8173-xhci"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
- interrupts : interrupt used by the controller
@@ -68,10 +72,14 @@ usb30: usb at 11270000 {
In the case, xhci is added as subnode to mtu3. An example and the DT binding
details of mtu3 can be found in:
-Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be "mediatek,soc-model-xhci", "mediatek,mtk-xhci",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc, when using
+ "mediatek,mtk-xhci" compatible string, you need SoC specific ones in
+ addition, one of:
+ - "mediatek,mt8173-xhci"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for xHCI MAC
- interrupts : interrupt used by the host controller
diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
index 1d7c3bc..b8ea394 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
@@ -44,7 +44,7 @@ Optional properties:
Sub-nodes:
The xhci should be added as subnode to mtu3 as shown in the following example
if host mode is enabled. The DT binding details of xhci can be found in:
-Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
Example:
ssusb: usb at 11271000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH RESEND v2 2/3] dt-bindings: mt8173-xhci: add generic compatible and rename file
@ 2017-08-29 9:20 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring
Cc: Matthias Brugger, Mark Rutland, Ian Campbell, Chunfeng Yun,
linux-kernel, linux-arm-kernel, linux-usb, linux-mediatek,
devicetree
The mt8173-xhci.txt actually holds the bindings for all mediatek
SoCs with xHCI controller, so add a generic compatible and change
the name to mediatek,mtk-xhci.txt to reflect that.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
.../usb/{mt8173-xhci.txt => mediatek,mtk-xhci.txt} | 14 +++++++++++---
.../devicetree/bindings/usb/mt8173-mtu3.txt | 2 +-
2 files changed, 12 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => mediatek,mtk-xhci.txt} (85%)
diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
similarity index 85%
rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
rename to Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
index 0acfc8a..ff21135 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
@@ -11,7 +11,11 @@ into two parts.
------------------------------------------------------------------------
Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be "mediatek,soc-model-xhci", "mediatek,mtk-xhci",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc, when using
+ "mediatek,mtk-xhci" compatible string, you need SoC specific ones in
+ addition, one of:
+ - "mediatek,mt8173-xhci"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
- interrupts : interrupt used by the controller
@@ -68,10 +72,14 @@ usb30: usb@11270000 {
In the case, xhci is added as subnode to mtu3. An example and the DT binding
details of mtu3 can be found in:
-Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be "mediatek,soc-model-xhci", "mediatek,mtk-xhci",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc, when using
+ "mediatek,mtk-xhci" compatible string, you need SoC specific ones in
+ addition, one of:
+ - "mediatek,mt8173-xhci"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for xHCI MAC
- interrupts : interrupt used by the host controller
diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
index 1d7c3bc..b8ea394 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
@@ -44,7 +44,7 @@ Optional properties:
Sub-nodes:
The xhci should be added as subnode to mtu3 as shown in the following example
if host mode is enabled. The DT binding details of xhci can be found in:
-Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
Example:
ssusb: usb@11271000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
2017-08-29 9:20 ` Chunfeng Yun
(?)
@ 2017-08-29 9:20 ` Chunfeng Yun
-1 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring
Cc: Matthias Brugger, Mark Rutland, Ian Campbell, Chunfeng Yun,
linux-kernel, linux-arm-kernel, linux-usb, linux-mediatek,
devicetree
The mt8173-mtu3.txt actually holds the bindings for all mediatek
SoCs with usb3 DRD IP, so add a generic compatible and change the
name to mediatek,mtu3.txt.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
similarity index 92%
rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
index b8ea394..722a029 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
@@ -1,7 +1,11 @@
The device node for Mediatek USB3.0 DRD controller
Required properties:
- - compatible : should be "mediatek,mt8173-mtu3"
+ - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc,
+ when using "mediatek,mtu3" compatible string, you need SoC specific
+ ones in addition, one of:
+ - "mediatek,mt8173-mtu3"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for device IP and "ippc" for IP port control
- interrupts : interrupt used by the device IP
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
@ 2017-08-29 9:20 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: linux-arm-kernel
The mt8173-mtu3.txt actually holds the bindings for all mediatek
SoCs with usb3 DRD IP, so add a generic compatible and change the
name to mediatek,mtu3.txt.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
similarity index 92%
rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
index b8ea394..722a029 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
@@ -1,7 +1,11 @@
The device node for Mediatek USB3.0 DRD controller
Required properties:
- - compatible : should be "mediatek,mt8173-mtu3"
+ - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc,
+ when using "mediatek,mtu3" compatible string, you need SoC specific
+ ones in addition, one of:
+ - "mediatek,mt8173-mtu3"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for device IP and "ippc" for IP port control
- interrupts : interrupt used by the device IP
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
@ 2017-08-29 9:20 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-29 9:20 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring
Cc: Matthias Brugger, Mark Rutland, Ian Campbell, Chunfeng Yun,
linux-kernel, linux-arm-kernel, linux-usb, linux-mediatek,
devicetree
The mt8173-mtu3.txt actually holds the bindings for all mediatek
SoCs with usb3 DRD IP, so add a generic compatible and change the
name to mediatek,mtu3.txt.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
similarity index 92%
rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
index b8ea394..722a029 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
@@ -1,7 +1,11 @@
The device node for Mediatek USB3.0 DRD controller
Required properties:
- - compatible : should be "mediatek,mt8173-mtu3"
+ - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
+ soc-model is the name of SoC, such as mt8173, mt2712 etc,
+ when using "mediatek,mtu3" compatible string, you need SoC specific
+ ones in addition, one of:
+ - "mediatek,mt8173-mtu3"
- reg : specifies physical base address and size of the registers
- reg-names: should be "mac" for device IP and "ippc" for IP port control
- interrupts : interrupt used by the device IP
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
2017-08-29 9:20 ` Chunfeng Yun
@ 2017-08-29 10:08 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2017-08-29 10:08 UTC (permalink / raw)
To: Chunfeng Yun, Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi,
Rob Herring
Cc: Matthias Brugger, Mark Rutland, Ian Campbell, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, devicetree
Hello!
On 8/29/2017 12:20 PM, Chunfeng Yun wrote:
> The mt8173-mtu3.txt actually holds the bindings for all mediatek
> SoCs with usb3 DRD IP, so add a generic compatible and change the
> name to mediatek,mtu3.txt.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
>
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> similarity index 92%
> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> index b8ea394..722a029 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> @@ -1,7 +1,11 @@
> The device node for Mediatek USB3.0 DRD controller
>
> Required properties:
> - - compatible : should be "mediatek,mt8173-mtu3"
> + - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
Worth enclosing soc-model in <>.
> + soc-model is the name of SoC, such as mt8173, mt2712 etc,
> + when using "mediatek,mtu3" compatible string, you need SoC specific
> + ones in addition, one of:
> + - "mediatek,mt8173-mtu3"
> - reg : specifies physical base address and size of the registers
> - reg-names: should be "mac" for device IP and "ippc" for IP port control
> - interrupts : interrupt used by the device IP
MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
@ 2017-08-29 10:08 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2017-08-29 10:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 8/29/2017 12:20 PM, Chunfeng Yun wrote:
> The mt8173-mtu3.txt actually holds the bindings for all mediatek
> SoCs with usb3 DRD IP, so add a generic compatible and change the
> name to mediatek,mtu3.txt.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
>
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> similarity index 92%
> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> index b8ea394..722a029 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> @@ -1,7 +1,11 @@
> The device node for Mediatek USB3.0 DRD controller
>
> Required properties:
> - - compatible : should be "mediatek,mt8173-mtu3"
> + - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
Worth enclosing soc-model in <>.
> + soc-model is the name of SoC, such as mt8173, mt2712 etc,
> + when using "mediatek,mtu3" compatible string, you need SoC specific
> + ones in addition, one of:
> + - "mediatek,mt8173-mtu3"
> - reg : specifies physical base address and size of the registers
> - reg-names: should be "mac" for device IP and "ippc" for IP port control
> - interrupts : interrupt used by the device IP
MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
2017-08-29 10:08 ` Sergei Shtylyov
(?)
@ 2017-08-30 3:38 ` Chunfeng Yun
-1 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-30 3:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
Matthias Brugger, Mark Rutland, Ian Campbell, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, devicetree
On Tue, 2017-08-29 at 13:08 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 8/29/2017 12:20 PM, Chunfeng Yun wrote:
>
> > The mt8173-mtu3.txt actually holds the bindings for all mediatek
> > SoCs with usb3 DRD IP, so add a generic compatible and change the
> > name to mediatek,mtu3.txt.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> > rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > similarity index 92%
> > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > index b8ea394..722a029 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > @@ -1,7 +1,11 @@
> > The device node for Mediatek USB3.0 DRD controller
> >
> > Required properties:
> > - - compatible : should be "mediatek,mt8173-mtu3"
> > + - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
>
> Worth enclosing soc-model in <>.
Ok, I'll modify it, thanks
>
> > + soc-model is the name of SoC, such as mt8173, mt2712 etc,
> > + when using "mediatek,mtu3" compatible string, you need SoC specific
> > + ones in addition, one of:
> > + - "mediatek,mt8173-mtu3"
> > - reg : specifies physical base address and size of the registers
> > - reg-names: should be "mac" for device IP and "ippc" for IP port control
> > - interrupts : interrupt used by the device IP
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
@ 2017-08-30 3:38 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-30 3:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-08-29 at 13:08 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 8/29/2017 12:20 PM, Chunfeng Yun wrote:
>
> > The mt8173-mtu3.txt actually holds the bindings for all mediatek
> > SoCs with usb3 DRD IP, so add a generic compatible and change the
> > name to mediatek,mtu3.txt.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> > rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > similarity index 92%
> > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > index b8ea394..722a029 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > @@ -1,7 +1,11 @@
> > The device node for Mediatek USB3.0 DRD controller
> >
> > Required properties:
> > - - compatible : should be "mediatek,mt8173-mtu3"
> > + - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
>
> Worth enclosing soc-model in <>.
Ok, I'll modify it, thanks
>
> > + soc-model is the name of SoC, such as mt8173, mt2712 etc,
> > + when using "mediatek,mtu3" compatible string, you need SoC specific
> > + ones in addition, one of:
> > + - "mediatek,mt8173-mtu3"
> > - reg : specifies physical base address and size of the registers
> > - reg-names: should be "mac" for device IP and "ippc" for IP port control
> > - interrupts : interrupt used by the device IP
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file
@ 2017-08-30 3:38 ` Chunfeng Yun
0 siblings, 0 replies; 14+ messages in thread
From: Chunfeng Yun @ 2017-08-30 3:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mathias Nyman, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
Matthias Brugger, Mark Rutland, Ian Campbell, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, devicetree
On Tue, 2017-08-29 at 13:08 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 8/29/2017 12:20 PM, Chunfeng Yun wrote:
>
> > The mt8173-mtu3.txt actually holds the bindings for all mediatek
> > SoCs with usb3 DRD IP, so add a generic compatible and change the
> > name to mediatek,mtu3.txt.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> > rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > similarity index 92%
> > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > index b8ea394..722a029 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> > @@ -1,7 +1,11 @@
> > The device node for Mediatek USB3.0 DRD controller
> >
> > Required properties:
> > - - compatible : should be "mediatek,mt8173-mtu3"
> > + - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",
>
> Worth enclosing soc-model in <>.
Ok, I'll modify it, thanks
>
> > + soc-model is the name of SoC, such as mt8173, mt2712 etc,
> > + when using "mediatek,mtu3" compatible string, you need SoC specific
> > + ones in addition, one of:
> > + - "mediatek,mt8173-mtu3"
> > - reg : specifies physical base address and size of the registers
> > - reg-names: should be "mac" for device IP and "ippc" for IP port control
> > - interrupts : interrupt used by the device IP
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread