[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Leon Anavi]

Increase the filesystem size for raspberrypi3 by setting
BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
raspberrypi3_64 has the same size.

Fixes:
Copying files into the device: __populate_fs: Could not allocate block in ext2 filesystem while writing file "services"
mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
---
 configs/raspberrypi3_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
index 856f321..0ef9afe 100644
--- a/configs/raspberrypi3_defconfig
+++ b/configs/raspberrypi3_defconfig
@@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
 # Filesystem / image
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
 # BR2_TARGET_ROOTFS_TAR is not set
 BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
-- 
2.7.4

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Yann E. MORIN]

Leon, All,

On 2018-06-29 12:23 +0300, Leon Anavi spake thusly:
> Increase the filesystem size for raspberrypi3 by setting
> BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
> raspberrypi3_64 has the same size.
> 
> Fixes:
> Copying files into the device: __populate_fs: Could not allocate block in ext2 filesystem while writing file "services"
> mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system

I don't have this issue here:

    $ make raspberrypi3_defconfig
    $ make
    $ du -hs output/target/
    57M     output/target/
    $ ls -lsh output/images/
    total 159M
     24K -rw-r--r-- 1 ymorin ymorin  24K Jun 30 19:35 bcm2710-rpi-3-b.dtb
     28K -rw-r--r-- 1 ymorin ymorin  25K Jun 30 19:35 bcm2710-rpi-3-b-plus.dtb
     24K -rw-r--r-- 1 ymorin ymorin  23K Jun 30 19:35 bcm2710-rpi-cm3.dtb
    8.0M -rw-r--r-- 1 ymorin ymorin  32M Jun 30 19:35 boot.vfat
     54M -rw-r--r-- 1 ymorin ymorin  60M Jun 30 19:35 rootfs.ext2
       0 lrwxrwxrwx 1 ymorin ymorin   11 Jun 30 19:35 rootfs.ext4 -> rootfs.ext2
    4.0K drwxr-xr-x 3 ymorin ymorin 4.0K Jun 30 19:24 rpi-firmware
     93M -rw-r--r-- 1 ymorin ymorin  93M Jun 30 19:35 sdcard.img
    4.7M -rw-r--r-- 1 ymorin ymorin 4.7M Jun 30 19:35 zImage

Regards,
Yann E. MORIN.

> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> ---
>  configs/raspberrypi3_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> index 856f321..0ef9afe 100644
> --- a/configs/raspberrypi3_defconfig
> +++ b/configs/raspberrypi3_defconfig
> @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
>  # Filesystem / image
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>  # BR2_TARGET_ROOTFS_TAR is not set
>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Leon Anavi]

Hi Yann,

On 30.06.2018 20:43, Yann E. MORIN wrote:
> Leon, All,
>
> On 2018-06-29 12:23 +0300, Leon Anavi spake thusly:
>> Increase the filesystem size for raspberrypi3 by setting
>> BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
>> raspberrypi3_64 has the same size.
>>
>> Fixes:
>> Copying files into the device: __populate_fs: Could not allocate block in ext2 filesystem while writing file "services"
>> mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system
> I don't have this issue here:

Thank you for the feedback. I have experienced this issue while building
branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
the same issue has been reproduced in the CI, Job #78257653 triggered by
Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653

I have noticed that the same fix has been already applied to
raspberrypi3_64_defconfig. I hope my patch will be merged to prevent
this issue in future for raspberrypi3_defconfig.

Thanks,
Leon

>
>     $ make raspberrypi3_defconfig
>     $ make
>     $ du -hs output/target/
>     57M     output/target/
>     $ ls -lsh output/images/
>     total 159M
>      24K -rw-r--r-- 1 ymorin ymorin  24K Jun 30 19:35 bcm2710-rpi-3-b.dtb
>      28K -rw-r--r-- 1 ymorin ymorin  25K Jun 30 19:35 bcm2710-rpi-3-b-plus.dtb
>      24K -rw-r--r-- 1 ymorin ymorin  23K Jun 30 19:35 bcm2710-rpi-cm3.dtb
>     8.0M -rw-r--r-- 1 ymorin ymorin  32M Jun 30 19:35 boot.vfat
>      54M -rw-r--r-- 1 ymorin ymorin  60M Jun 30 19:35 rootfs.ext2
>        0 lrwxrwxrwx 1 ymorin ymorin   11 Jun 30 19:35 rootfs.ext4 -> rootfs.ext2
>     4.0K drwxr-xr-x 3 ymorin ymorin 4.0K Jun 30 19:24 rpi-firmware
>      93M -rw-r--r-- 1 ymorin ymorin  93M Jun 30 19:35 sdcard.img
>     4.7M -rw-r--r-- 1 ymorin ymorin 4.7M Jun 30 19:35 zImage
>
> Regards,
> Yann E. MORIN.
>
>> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
>> ---
>>  configs/raspberrypi3_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
>> index 856f321..0ef9afe 100644
>> --- a/configs/raspberrypi3_defconfig
>> +++ b/configs/raspberrypi3_defconfig
>> @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
>>  # Filesystem / image
>>  BR2_TARGET_ROOTFS_EXT2=y
>>  BR2_TARGET_ROOTFS_EXT2_4=y
>> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>>  # BR2_TARGET_ROOTFS_TAR is not set
>>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
>>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Leon Anavi
Software Engineer
konsulko.com

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Yann E. MORIN]

Leon, All,

On 2018-06-30 21:03 +0300, Leon Anavi spake thusly:
> On 30.06.2018 20:43, Yann E. MORIN wrote:
> > Leon, All,
> >
> > On 2018-06-29 12:23 +0300, Leon Anavi spake thusly:
> >> Increase the filesystem size for raspberrypi3 by setting
> >> BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
> >> raspberrypi3_64 has the same size.
> >>
> >> Fixes:
> >> Copying files into the device: __populate_fs: Could not allocate block in ext2 filesystem while writing file "services"
> >> mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system
> > I don't have this issue here:
> 
> Thank you for the feedback. I have experienced this issue while building
> branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
> the same issue has been reproduced in the CI, Job #78257653 triggered by
> Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
> 
> I have noticed that the same fix has been already applied to
> raspberrypi3_64_defconfig. I hope my patch will be merged to prevent
> this issue in future for raspberrypi3_defconfig.

The raspberrypi3_64_defconfig has always had the size set to 120MiB from
the onset, because it builds more kernel modules and thus takes more
place (at least, according to the commit log (commit 9bbea36e3e).

I am not opposed to the change, BTW.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> Thanks,
> Leon
> 
> >
> >     $ make raspberrypi3_defconfig
> >     $ make
> >     $ du -hs output/target/
> >     57M     output/target/
> >     $ ls -lsh output/images/
> >     total 159M
> >      24K -rw-r--r-- 1 ymorin ymorin  24K Jun 30 19:35 bcm2710-rpi-3-b.dtb
> >      28K -rw-r--r-- 1 ymorin ymorin  25K Jun 30 19:35 bcm2710-rpi-3-b-plus.dtb
> >      24K -rw-r--r-- 1 ymorin ymorin  23K Jun 30 19:35 bcm2710-rpi-cm3.dtb
> >     8.0M -rw-r--r-- 1 ymorin ymorin  32M Jun 30 19:35 boot.vfat
> >      54M -rw-r--r-- 1 ymorin ymorin  60M Jun 30 19:35 rootfs.ext2
> >        0 lrwxrwxrwx 1 ymorin ymorin   11 Jun 30 19:35 rootfs.ext4 -> rootfs.ext2
> >     4.0K drwxr-xr-x 3 ymorin ymorin 4.0K Jun 30 19:24 rpi-firmware
> >      93M -rw-r--r-- 1 ymorin ymorin  93M Jun 30 19:35 sdcard.img
> >     4.7M -rw-r--r-- 1 ymorin ymorin 4.7M Jun 30 19:35 zImage
> >
> > Regards,
> > Yann E. MORIN.
> >
> >> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> >> ---
> >>  configs/raspberrypi3_defconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> >> index 856f321..0ef9afe 100644
> >> --- a/configs/raspberrypi3_defconfig
> >> +++ b/configs/raspberrypi3_defconfig
> >> @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
> >>  # Filesystem / image
> >>  BR2_TARGET_ROOTFS_EXT2=y
> >>  BR2_TARGET_ROOTFS_EXT2_4=y
> >> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> >>  # BR2_TARGET_ROOTFS_TAR is not set
> >>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
> >>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> >> -- 
> >> 2.7.4
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> Leon Anavi
> Software Engineer
> konsulko.com
> 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Yann E. MORIN]

Leon, All,

On 2018-06-30 21:11 +0200, Yann E. MORIN spake thusly:
> On 2018-06-30 21:03 +0300, Leon Anavi spake thusly:
[--SNIP--]
> > Thank you for the feedback. I have experienced this issue while building
> > branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
> > the same issue has been reproduced in the CI, Job #78257653 triggered by
> > Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653

Could you please provide a bit more details on your buildsystem: what is
the filesystem you use to build?

In the past, we had issues when the build was done on zfs for example,
because it reports nvalid (POSIX-wise) results about the size for small
files, which zfs entirely stores in the inode, thus reporting sero used
blocks.

I'm afraid something similar may be happening here...

Regards,
Yann E. MORIN.

> > I have noticed that the same fix has been already applied to
> > raspberrypi3_64_defconfig. I hope my patch will be merged to prevent
> > this issue in future for raspberrypi3_defconfig.
> 
> The raspberrypi3_64_defconfig has always had the size set to 120MiB from
> the onset, because it builds more kernel modules and thus takes more
> place (at least, according to the commit log (commit 9bbea36e3e).
> 
> I am not opposed to the change, BTW.
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Regards,
> Yann E. MORIN.
> 
> > Thanks,
> > Leon
> > 
> > >
> > >     $ make raspberrypi3_defconfig
> > >     $ make
> > >     $ du -hs output/target/
> > >     57M     output/target/
> > >     $ ls -lsh output/images/
> > >     total 159M
> > >      24K -rw-r--r-- 1 ymorin ymorin  24K Jun 30 19:35 bcm2710-rpi-3-b.dtb
> > >      28K -rw-r--r-- 1 ymorin ymorin  25K Jun 30 19:35 bcm2710-rpi-3-b-plus.dtb
> > >      24K -rw-r--r-- 1 ymorin ymorin  23K Jun 30 19:35 bcm2710-rpi-cm3.dtb
> > >     8.0M -rw-r--r-- 1 ymorin ymorin  32M Jun 30 19:35 boot.vfat
> > >      54M -rw-r--r-- 1 ymorin ymorin  60M Jun 30 19:35 rootfs.ext2
> > >        0 lrwxrwxrwx 1 ymorin ymorin   11 Jun 30 19:35 rootfs.ext4 -> rootfs.ext2
> > >     4.0K drwxr-xr-x 3 ymorin ymorin 4.0K Jun 30 19:24 rpi-firmware
> > >      93M -rw-r--r-- 1 ymorin ymorin  93M Jun 30 19:35 sdcard.img
> > >     4.7M -rw-r--r-- 1 ymorin ymorin 4.7M Jun 30 19:35 zImage
> > >
> > > Regards,
> > > Yann E. MORIN.
> > >
> > >> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> > >> ---
> > >>  configs/raspberrypi3_defconfig | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> > >> index 856f321..0ef9afe 100644
> > >> --- a/configs/raspberrypi3_defconfig
> > >> +++ b/configs/raspberrypi3_defconfig
> > >> @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
> > >>  # Filesystem / image
> > >>  BR2_TARGET_ROOTFS_EXT2=y
> > >>  BR2_TARGET_ROOTFS_EXT2_4=y
> > >> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> > >>  # BR2_TARGET_ROOTFS_TAR is not set
> > >>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
> > >>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> > >> -- 
> > >> 2.7.4
> > >>
> > >> _______________________________________________
> > >> buildroot mailing list
> > >> buildroot at busybox.net
> > >> http://lists.busybox.net/mailman/listinfo/buildroot
> > 
> > -- 
> > Leon Anavi
> > Software Engineer
> > konsulko.com
> > 
> > 
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Leon Anavi]

Hi Yann, All,

On 1.07.2018 12:22, Yann E. MORIN wrote:
> Leon, All,
>
> On 2018-06-30 21:11 +0200, Yann E. MORIN spake thusly:
>> On 2018-06-30 21:03 +0300, Leon Anavi spake thusly:
> [--SNIP--]
>>> Thank you for the feedback. I have experienced this issue while building
>>> branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
>>> the same issue has been reproduced in the CI, Job #78257653 triggered by
>>> Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
> Could you please provide a bit more details on your buildsystem: what is
> the filesystem you use to build?

The filesystem of my build machine is ext4. More details about the
Ubuntu version:

Distributor ID:??? Ubuntu
Description:??? Ubuntu 16.04.4 LTS
Release:??? 16.04
Codename:??? xenial

Best regards,
Leon


>
> In the past, we had issues when the build was done on zfs for example,
> because it reports nvalid (POSIX-wise) results about the size for small
> files, which zfs entirely stores in the inode, thus reporting sero used
> blocks.
>
> I'm afraid something similar may be happening here...
>
> Regards,
> Yann E. MORIN.
>
>>> I have noticed that the same fix has been already applied to
>>> raspberrypi3_64_defconfig. I hope my patch will be merged to prevent
>>> this issue in future for raspberrypi3_defconfig.
>> The raspberrypi3_64_defconfig has always had the size set to 120MiB from
>> the onset, because it builds more kernel modules and thus takes more
>> place (at least, according to the commit log (commit 9bbea36e3e).
>>
>> I am not opposed to the change, BTW.
>>
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>
>> Regards,
>> Yann E. MORIN.
>>
>>> Thanks,
>>> Leon
>>>
>>>>     $ make raspberrypi3_defconfig
>>>>     $ make
>>>>     $ du -hs output/target/
>>>>     57M     output/target/
>>>>     $ ls -lsh output/images/
>>>>     total 159M
>>>>      24K -rw-r--r-- 1 ymorin ymorin  24K Jun 30 19:35 bcm2710-rpi-3-b.dtb
>>>>      28K -rw-r--r-- 1 ymorin ymorin  25K Jun 30 19:35 bcm2710-rpi-3-b-plus.dtb
>>>>      24K -rw-r--r-- 1 ymorin ymorin  23K Jun 30 19:35 bcm2710-rpi-cm3.dtb
>>>>     8.0M -rw-r--r-- 1 ymorin ymorin  32M Jun 30 19:35 boot.vfat
>>>>      54M -rw-r--r-- 1 ymorin ymorin  60M Jun 30 19:35 rootfs.ext2
>>>>        0 lrwxrwxrwx 1 ymorin ymorin   11 Jun 30 19:35 rootfs.ext4 -> rootfs.ext2
>>>>     4.0K drwxr-xr-x 3 ymorin ymorin 4.0K Jun 30 19:24 rpi-firmware
>>>>      93M -rw-r--r-- 1 ymorin ymorin  93M Jun 30 19:35 sdcard.img
>>>>     4.7M -rw-r--r-- 1 ymorin ymorin 4.7M Jun 30 19:35 zImage
>>>>
>>>> Regards,
>>>> Yann E. MORIN.
>>>>
>>>>> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
>>>>> ---
>>>>>  configs/raspberrypi3_defconfig | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
>>>>> index 856f321..0ef9afe 100644
>>>>> --- a/configs/raspberrypi3_defconfig
>>>>> +++ b/configs/raspberrypi3_defconfig
>>>>> @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
>>>>>  # Filesystem / image
>>>>>  BR2_TARGET_ROOTFS_EXT2=y
>>>>>  BR2_TARGET_ROOTFS_EXT2_4=y
>>>>> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>>>>>  # BR2_TARGET_ROOTFS_TAR is not set
>>>>>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
>>>>>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
>>>>> -- 
>>>>> 2.7.4
>>>>>
>>>>> _______________________________________________
>>>>> buildroot mailing list
>>>>> buildroot at busybox.net
>>>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>> -- 
>>> Leon Anavi
>>> Software Engineer
>>> konsulko.com
>>>
>>>
>> -- 
>> .-----------------.--------------------.------------------.--------------------.
>> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
>> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
>> '------------------------------^-------^------------------^--------------------'
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Leon Anavi
Software Engineer
konsulko.com

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Ricardo Martincoski]

Hello,

On Sun, Jul 01, 2018 at 06:28 AM, Leon Anavi wrote:

> On 1.07.2018 12:22, Yann E. MORIN wrote:
>> On 2018-06-30 21:11 +0200, Yann E. MORIN spake thusly:
>>> On 2018-06-30 21:03 +0300, Leon Anavi spake thusly:
>> [--SNIP--]
>>>> Thank you for the feedback. I have experienced this issue while building
>>>> branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
>>>> the same issue has been reproduced in the CI, Job #78257653 triggered by
>>>> Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
>> Could you please provide a bit more details on your buildsystem: what is
>> the filesystem you use to build?
> 
> The filesystem of my build machine is ext4. More details about the
> Ubuntu version:
> 
> Distributor ID:??? Ubuntu
> Description:??? Ubuntu 16.04.4 LTS
> Release:??? 16.04
> Codename:??? xenial

I reproduced the error here:
system: Ubuntu 18.04 LTS
filesystem: ext4
commit: 78af2a6362 (the same from the CI build mentioned above)
wrapped error message:
Copying files into the device: __populate_fs: Could not allocate block in ext2
filesystem while writing file "busybox"


From the CI url mentioned above it seems the same occurs also in the GitLab
runners, so I started a few builds. Note: please trust the log and ignore the
job status, all jobs failed when uploading artifacts, probably my mistake in the
hacked .gitlab-ci.yml.

2018.05                 [1] ok
2018.05                 [2] ok
2018.05-140-g8b0fd3cb49 [3] fail
2018.05-240-g43ebb35e9b [4] fail
2018.05-340-g9f26e91cc5 [5] fail
2018.05-440-gc0d19a2083 [6] fail
2018.05-505-g78af2a6362 [7] fail
2018.05-559-g855295b658 [8] fail

[1] https://gitlab.com/buildroot.org/buildroot/-/jobs/71910855
[2] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670469
[3] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670740
[4] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671047
[5] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671078
[6] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671235
[7] https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
[8] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670542


Regards,
Ricardo

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Yann E. MORIN]

Ricardo, All,

On 2018-07-02 00:50 -0300, Ricardo Martincoski spake thusly:
> On Sun, Jul 01, 2018 at 06:28 AM, Leon Anavi wrote:
> > On 1.07.2018 12:22, Yann E. MORIN wrote:
> >> On 2018-06-30 21:11 +0200, Yann E. MORIN spake thusly:
> >>> On 2018-06-30 21:03 +0300, Leon Anavi spake thusly:
> >> [--SNIP--]
> >>>> Thank you for the feedback. I have experienced this issue while building
> >>>> branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
> >>>> the same issue has been reproduced in the CI, Job #78257653 triggered by
> >>>> Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
> >> Could you please provide a bit more details on your buildsystem: what is
> >> the filesystem you use to build?
> > 
> > The filesystem of my build machine is ext4. More details about the
> > Ubuntu version:
> > 
> > Distributor ID:??? Ubuntu
> > Description:??? Ubuntu 16.04.4 LTS
> > Release:??? 16.04
> > Codename:??? xenial
> 
> I reproduced the error here:
> system: Ubuntu 18.04 LTS
> filesystem: ext4
> commit: 78af2a6362 (the same from the CI build mentioned above)
> wrapped error message:
> Copying files into the device: __populate_fs: Could not allocate block in ext2
> filesystem while writing file "busybox"

I also was ultimately able toreproduce on my machine.

What pwuzzles me is that a did a build that was successful. Then I
cleaned and did a rebuilt form scratch and it failed. And the failing
file is never the same, which leads me to think it depends a lot of the
order of files as returned by readdir()...

And in any way, the size is already approaching the limit, so it does
make sense to increase it.

> From the CI url mentioned above it seems the same occurs also in the GitLab
> runners, so I started a few builds. Note: please trust the log and ignore the
> job status, all jobs failed when uploading artifacts, probably my mistake in the
> hacked .gitlab-ci.yml.
> 
> 2018.05                 [1] ok
> 2018.05                 [2] ok
> 2018.05-140-g8b0fd3cb49 [3] fail
> 2018.05-240-g43ebb35e9b [4] fail
> 2018.05-340-g9f26e91cc5 [5] fail
> 2018.05-440-gc0d19a2083 [6] fail
> 2018.05-505-g78af2a6362 [7] fail
> 2018.05-559-g855295b658 [8] fail
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/71910855
> [2] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670469
> [3] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670740
> [4] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671047
> [5] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671078
> [6] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671235
> [7] https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
> [8] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670542

OK, so what is weird is that we all noticed different failing files or
directories (busybox for Ricardo, shm for me, others for Leon), while
the Gitlab-CI runners all failed on nfs_check, whether on Ricardo's or
the main Buildroot jobs...

Anyway, as I said; let's increase the size.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Leon Anavi]

Hi Yann,


On 2.07.2018 19:17, Yann E. MORIN wrote:
> Ricardo, All,
>
> On 2018-07-02 00:50 -0300, Ricardo Martincoski spake thusly:
>> On Sun, Jul 01, 2018 at 06:28 AM, Leon Anavi wrote:
>>> On 1.07.2018 12:22, Yann E. MORIN wrote:
>>>> On 2018-06-30 21:11 +0200, Yann E. MORIN spake thusly:
>>>>> On 2018-06-30 21:03 +0300, Leon Anavi spake thusly:
>>>> [--SNIP--]
>>>>>> Thank you for the feedback. I have experienced this issue while building
>>>>>> branch master on Ubuntu 16.04. As discussed in the IRC channel on Friday
>>>>>> the same issue has been reproduced in the CI, Job #78257653 triggered by
>>>>>> Thomas Petazzoni: https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
>>>> Could you please provide a bit more details on your buildsystem: what is
>>>> the filesystem you use to build?
>>> The filesystem of my build machine is ext4. More details about the
>>> Ubuntu version:
>>>
>>> Distributor ID:??? Ubuntu
>>> Description:??? Ubuntu 16.04.4 LTS
>>> Release:??? 16.04
>>> Codename:??? xenial
>> I reproduced the error here:
>> system: Ubuntu 18.04 LTS
>> filesystem: ext4
>> commit: 78af2a6362 (the same from the CI build mentioned above)
>> wrapped error message:
>> Copying files into the device: __populate_fs: Could not allocate block in ext2
>> filesystem while writing file "busybox"
> I also was ultimately able toreproduce on my machine.
>
> What pwuzzles me is that a did a build that was successful. Then I
> cleaned and did a rebuilt form scratch and it failed. And the failing
> file is never the same, which leads me to think it depends a lot of the
> order of files as returned by readdir()...
>
> And in any way, the size is already approaching the limit, so it does
> make sense to increase it.
>
>> From the CI url mentioned above it seems the same occurs also in the GitLab
>> runners, so I started a few builds. Note: please trust the log and ignore the
>> job status, all jobs failed when uploading artifacts, probably my mistake in the
>> hacked .gitlab-ci.yml.
>>
>> 2018.05                 [1] ok
>> 2018.05                 [2] ok
>> 2018.05-140-g8b0fd3cb49 [3] fail
>> 2018.05-240-g43ebb35e9b [4] fail
>> 2018.05-340-g9f26e91cc5 [5] fail
>> 2018.05-440-gc0d19a2083 [6] fail
>> 2018.05-505-g78af2a6362 [7] fail
>> 2018.05-559-g855295b658 [8] fail
>>
>> [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/71910855
>> [2] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670469
>> [3] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670740
>> [4] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671047
>> [5] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671078
>> [6] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78671235
>> [7] https://gitlab.com/buildroot.org/buildroot/-/jobs/78257653
>> [8] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/78670542
> OK, so what is weird is that we all noticed different failing files or
> directories (busybox for Ricardo, shm for me, others for Leon), while
> the Gitlab-CI runners all failed on nfs_check, whether on Ricardo's or
> the main Buildroot jobs...
>
> Anyway, as I said; let's increase the size.

Thank you very much for the deep investigation and for sharing the
results. I hope that by merging my patch for increasing the size this
issue will not affect anyone in future.

Thanks,
Leon

>
> Regards,
> Yann E. MORIN.
>

-- 
Leon Anavi
Software Engineer
konsulko.com

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Ricardo Martincoski]

Hello,

On Mon, Jul 02, 2018 at 01:35 PM, Leon Anavi wrote:
> On 2.07.2018 19:17, Yann E. MORIN wrote:
[snip]
>> Anyway, as I said; let's increase the size.
> 
> Thank you very much for the deep investigation and for sharing the
> results. I hope that by merging my patch for increasing the size this
> issue will not affect anyone in future.

Sure. I agree with you both. Let's increase the size.

Regards,
Ricardo

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Arnout Vandecappelle]

On 29-06-18 11:23, Leon Anavi wrote:
> Increase the filesystem size for raspberrypi3 by setting
> BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
> raspberrypi3_64 has the same size.
> 
> Fixes:
> Copying files into the device: __populate_fs: Could not allocate block in ext2 filesystem while writing file "services"
> mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system
> 
> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

 Applied to master, thanks.

 It's a pity we didn't get to the bottom of why this error was not happening
every time, or why it didn't happen before. But, as mentioned, the fix is simple
and we were close to the limit.

 I've extended the commit log a little bit.

 Regards,
 Arnout

> ---
>  configs/raspberrypi3_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> index 856f321..0ef9afe 100644
> --- a/configs/raspberrypi3_defconfig
> +++ b/configs/raspberrypi3_defconfig
> @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
>  # Filesystem / image
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
>  # BR2_TARGET_ROOTFS_TAR is not set
>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Yann E. MORIN]

Arnout, All,

On 2018-07-08 00:35 +0200, Arnout Vandecappelle spake thusly:
> On 29-06-18 11:23, Leon Anavi wrote:
> > Increase the filesystem size for raspberrypi3 by setting
> > BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
> > raspberrypi3_64 has the same size.
> > 
> > Fixes:
> > Copying files into the device: __populate_fs: Could not allocate block in ext2 filesystem while writing file "services"
> > mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system
> > 
> > Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> 
>  Applied to master, thanks.

Not really, I'm afraid...

>  It's a pity we didn't get to the bottom of why this error was not happening
> every time, or why it didn't happen before. But, as mentioned, the fix is simple
> and we were close to the limit.

I did two tests on the same, the first was successfull, the second
failed. The only difference being that the machine was unloaded for
the first one, while I was doing something else for the second one...
Yeah, not very conclusive... :-(

Regards,
Yann E. MORIN.

>  I've extended the commit log a little bit.
> 
>  Regards,
>  Arnout
> 
> > ---
> >  configs/raspberrypi3_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> > index 856f321..0ef9afe 100644
> > --- a/configs/raspberrypi3_defconfig
> > +++ b/configs/raspberrypi3_defconfig
> > @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
> >  # Filesystem / image
> >  BR2_TARGET_ROOTFS_EXT2=y
> >  BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> >  # BR2_TARGET_ROOTFS_TAR is not set
> >  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
> >  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> > 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Leon Anavi]

Hi Arnout, Yann, All,

On Sun, Jul 8, 2018, 12:16 Yann E. MORIN <yann.morin.1998@free.fr> wrote:

> Arnout, All,
>
> On 2018-07-08 00:35 +0200, Arnout Vandecappelle spake thusly:
> > On 29-06-18 11:23, Leon Anavi wrote:
> > > Increase the filesystem size for raspberrypi3 by setting
> > > BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
> > > raspberrypi3_64 has the same size.
> > >
> > > Fixes:
> > > Copying files into the device: __populate_fs: Could not allocate block
> in ext2 filesystem while writing file "services"
> > > mkfs.ext4: Could not allocate block in ext2 filesystem while
> populating file system
> > >
> > > Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> >
> >  Applied to master, thanks.
>
> Not really, I'm afraid...
>

I am also afraid that I still don't see it in master.

Best regards, Leon


> >  It's a pity we didn't get to the bottom of why this error was not
> happening
> > every time, or why it didn't happen before. But, as mentioned, the fix
> is simple
> > and we were close to the limit.
>
> I did two tests on the same, the first was successfull, the second
> failed. The only difference being that the machine was unloaded for
> the first one, while I was doing something else for the second one...
> Yeah, not very conclusive... :-(
>
> Regards,
> Yann E. MORIN.
>
> >  I've extended the commit log a little bit.
> >
> >  Regards,
> >  Arnout
> >
> > > ---
> > >  configs/raspberrypi3_defconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/configs/raspberrypi3_defconfig
> b/configs/raspberrypi3_defconfig
> > > index 856f321..0ef9afe 100644
> > > --- a/configs/raspberrypi3_defconfig
> > > +++ b/configs/raspberrypi3_defconfig
> > > @@ -28,6 +28,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
> > >  # Filesystem / image
> > >  BR2_TARGET_ROOTFS_EXT2=y
> > >  BR2_TARGET_ROOTFS_EXT2_4=y
> > > +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> > >  # BR2_TARGET_ROOTFS_TAR is not set
> > >  BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
> > >  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> > >
> >
> > --
> > Arnout Vandecappelle                          arnout at mind be
> > Senior Embedded Software Architect            +32-16-286500
> > Essensium/Mind                                http://www.mind.be
> > G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> > GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180708/d14583ab/attachment.html>

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Arnout Vandecappelle]

On 08-07-18 11:32, Leon Anavi wrote:
> Hi Arnout, Yann, All,
> 
> On Sun, Jul 8, 2018, 12:16 Yann E. MORIN <yann.morin.1998@free.fr
> <mailto:yann.morin.1998@free.fr>> wrote:
> 
>     Arnout, All,
> 
>     On 2018-07-08 00:35 +0200, Arnout Vandecappelle spake thusly:
>     > On 29-06-18 11:23, Leon Anavi wrote:
>     > > Increase the filesystem size for raspberrypi3 by setting
>     > > BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
>     > > raspberrypi3_64 has the same size.
>     > >
>     > > Fixes:
>     > > Copying files into the device: __populate_fs: Could not allocate block
>     in ext2 filesystem while writing file "services"
>     > > mkfs.ext4: Could not allocate block in ext2 filesystem while populating
>     file system
>     > >
>     > > Signed-off-by: Leon Anavi <leon.anavi@konsulko.com
>     <mailto:leon.anavi@konsulko.com>>
>     >
>     >? Applied to master, thanks.
> 
>     Not really, I'm afraid...
> 
> 
> I am also afraid that I still don't see it in master.
 I pushed now, thanks for the heads-up.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] configs/raspberrypi3_defconfig: fix filesystem size

[Peter Korsgaard]

>>>>> "Leon" == Leon Anavi <leon.anavi@konsulko.com> writes:

 > Increase the filesystem size for raspberrypi3 by setting
 > BR2_TARGET_ROOTFS_EXT2_SIZE to "120M". The filesystem for
 > raspberrypi3_64 has the same size.

 > Fixes:
 > Copying files into the device: __populate_fs: Could not allocate block
 > in ext2 filesystem while writing file "services"
 > mkfs.ext4: Could not allocate block in ext2 filesystem while populating file system

 > Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Committed to 2018.02.x and 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard