* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
@ 2018-05-17 9:03 Chris Packham
2018-05-17 9:08 ` Stefan Roese
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Chris Packham @ 2018-05-17 9:03 UTC (permalink / raw)
To: u-boot
Not all users of MVGBE need PHYLIB and it increases the size of the
openrd images too much.
Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Signed-off-by: Chris Packham <judge.packham@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Stefan Roese <sr@denx.de>
---
drivers/net/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index c962d7a72c0c..f2cc75f494e8 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -181,7 +181,6 @@ config FTMAC100
config MVGBE
bool "Marvell Orion5x/Kirkwood network interface support"
depends on KIRKWOOD || ORION5X
- select PHYLIB
help
This driver supports the network interface units in the
Marvell Orion5x and Kirkwood SoCs
--
2.17.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 9:03 [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB Chris Packham
@ 2018-05-17 9:08 ` Stefan Roese
2018-05-17 10:31 ` Stefan Roese
2018-05-17 11:09 ` Tom Rini
2 siblings, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2018-05-17 9:08 UTC (permalink / raw)
To: u-boot
On 17.05.2018 11:03, Chris Packham wrote:
> Not all users of MVGBE need PHYLIB and it increases the size of the
> openrd images too much.
>
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Stefan Roese <sr@denx.de>
> ---
>
> drivers/net/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index c962d7a72c0c..f2cc75f494e8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -181,7 +181,6 @@ config FTMAC100
> config MVGBE
> bool "Marvell Orion5x/Kirkwood network interface support"
> depends on KIRKWOOD || ORION5X
> - select PHYLIB
> help
> This driver supports the network interface units in the
> Marvell Orion5x and Kirkwood SoCs
>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 9:03 [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB Chris Packham
2018-05-17 9:08 ` Stefan Roese
@ 2018-05-17 10:31 ` Stefan Roese
2018-05-17 11:09 ` Tom Rini
2 siblings, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2018-05-17 10:31 UTC (permalink / raw)
To: u-boot
Hi Joe,
On 17.05.2018 11:03, Chris Packham wrote:
> Not all users of MVGBE need PHYLIB and it increases the size of the
> openrd images too much.
>
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Stefan Roese <sr@denx.de>
> ---
>
> drivers/net/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index c962d7a72c0c..f2cc75f494e8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -181,7 +181,6 @@ config FTMAC100
> config MVGBE
> bool "Marvell Orion5x/Kirkwood network interface support"
> depends on KIRKWOOD || ORION5X
> - select PHYLIB
> help
> This driver supports the network interface units in the
> Marvell Orion5x and Kirkwood SoCs
>
Joe, are you okay with me pulling this patch via the Marvell
repository? As it fixes a size limitation error on some of the
Kirkwood board, where I have some device-tree patches queued.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 9:03 [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB Chris Packham
2018-05-17 9:08 ` Stefan Roese
2018-05-17 10:31 ` Stefan Roese
@ 2018-05-17 11:09 ` Tom Rini
2018-05-17 11:53 ` Chris Packham
2 siblings, 1 reply; 8+ messages in thread
From: Tom Rini @ 2018-05-17 11:09 UTC (permalink / raw)
To: u-boot
On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> Not all users of MVGBE need PHYLIB and it increases the size of the
> openrd images too much.
>
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Stefan Roese <sr@denx.de>
> ---
>
> drivers/net/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index c962d7a72c0c..f2cc75f494e8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -181,7 +181,6 @@ config FTMAC100
> config MVGBE
> bool "Marvell Orion5x/Kirkwood network interface support"
> depends on KIRKWOOD || ORION5X
> - select PHYLIB
> help
> This driver supports the network interface units in the
> Marvell Orion5x and Kirkwood SoCs
This results in phylib never being set now as the configs were getting
it implicitly. Do any of the boards need it? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/91861414/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 11:09 ` Tom Rini
@ 2018-05-17 11:53 ` Chris Packham
2018-05-17 11:59 ` Stefan Roese
0 siblings, 1 reply; 8+ messages in thread
From: Chris Packham @ 2018-05-17 11:53 UTC (permalink / raw)
To: u-boot
On Thu, 17 May 2018, 11:09 PM Tom Rini, <trini@konsulko.com> wrote:
> On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> > Not all users of MVGBE need PHYLIB and it increases the size of the
> > openrd images too much.
> >
> > Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> > Cc: Tom Rini <trini@konsulko.com>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> >
> > drivers/net/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index c962d7a72c0c..f2cc75f494e8 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -181,7 +181,6 @@ config FTMAC100
> > config MVGBE
> > bool "Marvell Orion5x/Kirkwood network interface support"
> > depends on KIRKWOOD || ORION5X
> > - select PHYLIB
> > help
> > This driver supports the network interface units in the
> > Marvell Orion5x and Kirkwood SoCs
>
> This results in phylib never being set now as the configs were getting
> it implicitly. Do any of the boards need it?
>
I compile tested the affected boards and they all build. I've fired this at
github and should have some travis results soon.
My mistake was to copy the mvneta kconfig which had the select. Commit
ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB
lines so if they need it it's already in the board.h file or selected
somewhere else.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 11:53 ` Chris Packham
@ 2018-05-17 11:59 ` Stefan Roese
2018-05-17 12:02 ` Tom Rini
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Roese @ 2018-05-17 11:59 UTC (permalink / raw)
To: u-boot
On 17.05.2018 13:53, Chris Packham wrote:
>
>
> On Thu, 17 May 2018, 11:09 PM Tom Rini, <trini@konsulko.com
> <mailto:trini@konsulko.com>> wrote:
>
> On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> > Not all users of MVGBE need PHYLIB and it increases the size of the
> > openrd images too much.
> >
> > Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> > Signed-off-by: Chris Packham <judge.packham@gmail.com
> <mailto:judge.packham@gmail.com>>
> > Cc: Tom Rini <trini at konsulko.com <mailto:trini@konsulko.com>>
> > Cc: Stefan Roese <sr at denx.de <mailto:sr@denx.de>>
> > ---
> >
> > drivers/net/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index c962d7a72c0c..f2cc75f494e8 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -181,7 +181,6 @@ config FTMAC100
> > config MVGBE
> > bool "Marvell Orion5x/Kirkwood network interface support"
> > depends on KIRKWOOD || ORION5X
> > - select PHYLIB
> > help
> > This driver supports the network interface units in the
> > Marvell Orion5x and Kirkwood SoCs
>
> This results in phylib never being set now as the configs were getting
> it implicitly. Do any of the boards need it?
>
>
> I compile tested the affected boards and they all build. I've fired this
> at github and should have some travis results soon.
>
> My mistake was to copy the mvneta kconfig which had the select. Commit
> ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any
> CONFIG_PHYLIB lines so if they need it it's already in the board.h file
> or selected somewhere else.
Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for
MVGBE") selected PHYLIB via Kconfig, which changed the configuration
for these Kirkwood boards. *If* some of them needed / selected PHYLIB
before this patch, it was most likely done in their config header.
So this patch restores the board configuration again. PHYLIB is not
needed for MVGBE - it compiles without it as well.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 11:59 ` Stefan Roese
@ 2018-05-17 12:02 ` Tom Rini
2018-05-17 12:15 ` Chris Packham
0 siblings, 1 reply; 8+ messages in thread
From: Tom Rini @ 2018-05-17 12:02 UTC (permalink / raw)
To: u-boot
On Thu, May 17, 2018 at 01:59:36PM +0200, Stefan Roese wrote:
> On 17.05.2018 13:53, Chris Packham wrote:
> >
> >
> >On Thu, 17 May 2018, 11:09 PM Tom Rini, <trini@konsulko.com
> ><mailto:trini@konsulko.com>> wrote:
> >
> > On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> > > Not all users of MVGBE need PHYLIB and it increases the size of the
> > > openrd images too much.
> > >
> > > Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> > > Signed-off-by: Chris Packham <judge.packham@gmail.com
> > <mailto:judge.packham@gmail.com>>
> > > Cc: Tom Rini <trini at konsulko.com <mailto:trini@konsulko.com>>
> > > Cc: Stefan Roese <sr at denx.de <mailto:sr@denx.de>>
> > > ---
> > >
> > > drivers/net/Kconfig | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > > index c962d7a72c0c..f2cc75f494e8 100644
> > > --- a/drivers/net/Kconfig
> > > +++ b/drivers/net/Kconfig
> > > @@ -181,7 +181,6 @@ config FTMAC100
> > > config MVGBE
> > > bool "Marvell Orion5x/Kirkwood network interface support"
> > > depends on KIRKWOOD || ORION5X
> > > - select PHYLIB
> > > help
> > > This driver supports the network interface units in the
> > > Marvell Orion5x and Kirkwood SoCs
> >
> > This results in phylib never being set now as the configs were getting
> > it implicitly. Do any of the boards need it?
> >
> >
> >I compile tested the affected boards and they all build. I've fired this
> >at github and should have some travis results soon.
> >
> >My mistake was to copy the mvneta kconfig which had the select. Commit
> >ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB
> >lines so if they need it it's already in the board.h file or selected
> >somewhere else.
>
> Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for
> MVGBE") selected PHYLIB via Kconfig, which changed the configuration
> for these Kirkwood boards. *If* some of them needed / selected PHYLIB
> before this patch, it was most likely done in their config header.
>
> So this patch restores the board configuration again. PHYLIB is not
> needed for MVGBE - it compiles without it as well.
OK, thanks. Can you please do a v2 with a commit message that reflects
this and a Fixes tag?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/1700f6f4/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB
2018-05-17 12:02 ` Tom Rini
@ 2018-05-17 12:15 ` Chris Packham
0 siblings, 0 replies; 8+ messages in thread
From: Chris Packham @ 2018-05-17 12:15 UTC (permalink / raw)
To: u-boot
On Fri, May 18, 2018 at 12:02 AM Tom Rini <trini@konsulko.com> wrote:
> On Thu, May 17, 2018 at 01:59:36PM +0200, Stefan Roese wrote:
> > On 17.05.2018 13:53, Chris Packham wrote:
> > >
> > >
> > >On Thu, 17 May 2018, 11:09 PM Tom Rini, <trini@konsulko.com
> > ><mailto:trini@konsulko.com>> wrote:
> > >
> > > On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> > > > Not all users of MVGBE need PHYLIB and it increases the size of
the
> > > > openrd images too much.
> > > >
> > > > Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> > > > Signed-off-by: Chris Packham <judge.packham@gmail.com
> > > <mailto:judge.packham@gmail.com>>
> > > > Cc: Tom Rini <trini at konsulko.com <mailto:trini@konsulko.com>>
> > > > Cc: Stefan Roese <sr at denx.de <mailto:sr@denx.de>>
> > > > ---
> > > >
> > > > drivers/net/Kconfig | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > > > index c962d7a72c0c..f2cc75f494e8 100644
> > > > --- a/drivers/net/Kconfig
> > > > +++ b/drivers/net/Kconfig
> > > > @@ -181,7 +181,6 @@ config FTMAC100
> > > > config MVGBE
> > > > bool "Marvell Orion5x/Kirkwood network interface support"
> > > > depends on KIRKWOOD || ORION5X
> > > > - select PHYLIB
> > > > help
> > > > This driver supports the network interface units in the
> > > > Marvell Orion5x and Kirkwood SoCs
> > >
> > > This results in phylib never being set now as the configs were
getting
> > > it implicitly. Do any of the boards need it?
> > >
> > >
> > >I compile tested the affected boards and they all build. I've fired
this
> > >at github and should have some travis results soon.
> > >
> > >My mistake was to copy the mvneta kconfig which had the select. Commit
> > >ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any
CONFIG_PHYLIB
> > >lines so if they need it it's already in the board.h file or selected
> > >somewhere else.
> >
> > Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for
> > MVGBE") selected PHYLIB via Kconfig, which changed the configuration
> > for these Kirkwood boards. *If* some of them needed / selected PHYLIB
> > before this patch, it was most likely done in their config header.
> >
> > So this patch restores the board configuration again. PHYLIB is not
> > needed for MVGBE - it compiles without it as well.
> OK, thanks. Can you please do a v2 with a commit message that reflects
> this and a Fixes tag?
Done http://patchwork.ozlabs.org/patch/915392/
Travis builds running now
https://travis-ci.org/cpackham/u-boot/builds/380175749
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-05-17 12:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 9:03 [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB Chris Packham
2018-05-17 9:08 ` Stefan Roese
2018-05-17 10:31 ` Stefan Roese
2018-05-17 11:09 ` Tom Rini
2018-05-17 11:53 ` Chris Packham
2018-05-17 11:59 ` Stefan Roese
2018-05-17 12:02 ` Tom Rini
2018-05-17 12:15 ` Chris Packham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.