[PATCH] extcon: max3355: kill unneeded #include's

[PATCH] extcon: max3355: kill unneeded #include's

[Sergei Shtylyov]

Some #include's weren't needed from the start, some are left overs from the
earlier driver versions... Kill 'em all! :-)

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
If possible, please fold this patch into the main MAX3355 driver patch.

 drivers/extcon/extcon-max3355.c |    5 -----
 1 file changed, 5 deletions(-)

Index: extcon/drivers/extcon/extcon-max3355.c
=================================--- extcon.orig/drivers/extcon/extcon-max3355.c
+++ extcon/drivers/extcon/extcon-max3355.c
@@ -11,14 +11,9 @@
 
 #include <linux/extcon.h>
 #include <linux/gpio.h>
-#include <linux/init.h>
 #include <linux/interrupt.h>
-#include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
-#include <linux/slab.h>
-#include <linux/workqueue.h>
 
 struct max3355_data {
 	struct extcon_dev *edev;

[PATCH] extcon: max3355: kill unneeded #include's

[Sergei Shtylyov]

Some #include's weren't needed from the start, some are left overs from the
earlier driver versions... Kill 'em all! :-)

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
If possible, please fold this patch into the main MAX3355 driver patch.

 drivers/extcon/extcon-max3355.c |    5 -----
 1 file changed, 5 deletions(-)

Index: extcon/drivers/extcon/extcon-max3355.c
===================================================================
--- extcon.orig/drivers/extcon/extcon-max3355.c
+++ extcon/drivers/extcon/extcon-max3355.c
@@ -11,14 +11,9 @@
 
 #include <linux/extcon.h>
 #include <linux/gpio.h>
-#include <linux/init.h>
 #include <linux/interrupt.h>
-#include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
-#include <linux/slab.h>
-#include <linux/workqueue.h>
 
 struct max3355_data {
 	struct extcon_dev *edev;

Re: [PATCH] extcon: max3355: kill unneeded #include's

[Chanwoo Choi]

On 2015년 12월 21일 03:31, Sergei Shtylyov wrote:
> Some #include's weren't needed from the start, some are left overs from the
> earlier driver versions... Kill 'em all! :-)

I don't prefer following expression. I think you should write the description
to maintain the formal style on the next.
- "... Kill 'em all! :-) "

> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
> If possible, please fold this patch into the main MAX3355 driver patch.
> 
>  drivers/extcon/extcon-max3355.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> Index: extcon/drivers/extcon/extcon-max3355.c
> =================================> --- extcon.orig/drivers/extcon/extcon-max3355.c
> +++ extcon/drivers/extcon/extcon-max3355.c
> @@ -11,14 +11,9 @@
>  
>  #include <linux/extcon.h>
>  #include <linux/gpio.h>
> -#include <linux/init.h>
>  #include <linux/interrupt.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
> -#include <linux/slab.h>
> -#include <linux/workqueue.h>
>  
>  struct max3355_data {
>  	struct extcon_dev *edev;
> 

I combine it on original patch.

Thanks,
Chanwoo Choi

Re: [PATCH] extcon: max3355: kill unneeded #include's

[Chanwoo Choi]

On 2015년 12월 21일 03:31, Sergei Shtylyov wrote:
> Some #include's weren't needed from the start, some are left overs from the
> earlier driver versions... Kill 'em all! :-)

I don't prefer following expression. I think you should write the description
to maintain the formal style on the next.
- "... Kill 'em all! :-) "

> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
> If possible, please fold this patch into the main MAX3355 driver patch.
> 
>  drivers/extcon/extcon-max3355.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> Index: extcon/drivers/extcon/extcon-max3355.c
> ===================================================================
> --- extcon.orig/drivers/extcon/extcon-max3355.c
> +++ extcon/drivers/extcon/extcon-max3355.c
> @@ -11,14 +11,9 @@
>  
>  #include <linux/extcon.h>
>  #include <linux/gpio.h>
> -#include <linux/init.h>
>  #include <linux/interrupt.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
> -#include <linux/slab.h>
> -#include <linux/workqueue.h>
>  
>  struct max3355_data {
>  	struct extcon_dev *edev;
> 

I combine it on original patch.

Thanks,
Chanwoo Choi