* [PATCH] samples/watch_test - fix build error
@ 2019-09-19 16:10 Valdis Klētnieks
2019-10-11 7:55 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2019-09-19 16:10 UTC (permalink / raw)
To: David Howells; +Cc: linux-kernel
We're missing a depends in the Kconfig, which can lead to trying to
build without the required headers being present..
HOSTCC samples/watch_queue/watch_test
samples/watch_queue/watch_test.c:23:10: fatal error: linux/watch_queue.h: No such file or directory
23 | #include <linux/watch_queue.h>
| ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.host:107: samples/watch_queue/watch_test] Error 1
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/samples/Kconfig b/samples/Kconfig
index 2c3e07addd38..d0761f29ccb0 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -171,6 +171,7 @@ config SAMPLE_VFS
config SAMPLE_WATCH_QUEUE
bool "Build example /dev/watch_queue notification consumer"
+ depends on HEADERS_INSTALL
help
Build example userspace program to use the new mount_notify(),
sb_notify() syscalls and the KEYCTL_WATCH_KEY keyctl() function.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] samples/watch_test - fix build error
2019-09-19 16:10 [PATCH] samples/watch_test - fix build error Valdis Klētnieks
@ 2019-10-11 7:55 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2019-10-11 7:55 UTC (permalink / raw)
To: Valdis Klētnieks; +Cc: dhowells, linux-kernel
This change is folded in, thanks (from Randy's patch).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-11 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 16:10 [PATCH] samples/watch_test - fix build error Valdis Klētnieks
2019-10-11 7:55 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.