* [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns
@ 2023-02-19 7:01 Hangbin Liu
2023-02-19 8:38 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Hangbin Liu @ 2023-02-19 7:01 UTC (permalink / raw)
To: netdev
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
Jakub Kicinski, David S . Miller, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Mykola Lysenko, Felix Maurer,
Matthieu Baerts, mptcp, Hangbin Liu
The current mptcp test is run in init netns. If the user or default
system config disabled mptcp, the test will fail. Let's run the mptcp
test in a dedicated netns to avoid none kernel default mptcp setting.
Suggested-by: Martin KaFai Lau <martin.lau@linux.dev>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
v2: remove unneed close_cgroup_fd goto label.
---
.../testing/selftests/bpf/prog_tests/mptcp.c | 27 +++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index 59f08d6d1d53..dbe2bcfd3b38 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -7,6 +7,16 @@
#include "network_helpers.h"
#include "mptcp_sock.skel.h"
+#define SYS(fmt, ...) \
+ ({ \
+ char cmd[1024]; \
+ snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \
+ if (!ASSERT_OK(system(cmd), cmd)) \
+ goto fail; \
+ })
+
+#define NS_TEST "mptcp_ns"
+
#ifndef TCP_CA_NAME_MAX
#define TCP_CA_NAME_MAX 16
#endif
@@ -138,12 +148,20 @@ static int run_test(int cgroup_fd, int server_fd, bool is_mptcp)
static void test_base(void)
{
+ struct nstoken *nstoken = NULL;
int server_fd, cgroup_fd;
cgroup_fd = test__join_cgroup("/mptcp");
if (!ASSERT_GE(cgroup_fd, 0, "test__join_cgroup"))
return;
+ SYS("ip netns add %s", NS_TEST);
+ SYS("ip -net %s link set dev lo up", NS_TEST);
+
+ nstoken = open_netns(NS_TEST);
+ if (!ASSERT_OK_PTR(nstoken, "open_netns"))
+ goto fail;
+
/* without MPTCP */
server_fd = start_server(AF_INET, SOCK_STREAM, NULL, 0, 0);
if (!ASSERT_GE(server_fd, 0, "start_server"))
@@ -157,13 +175,18 @@ static void test_base(void)
/* with MPTCP */
server_fd = start_mptcp_server(AF_INET, NULL, 0, 0);
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
- goto close_cgroup_fd;
+ goto fail;
ASSERT_OK(run_test(cgroup_fd, server_fd, true), "run_test mptcp");
close(server_fd);
-close_cgroup_fd:
+fail:
+ if (nstoken)
+ close_netns(nstoken);
+
+ system("ip netns del " NS_TEST " >& /dev/null");
+
close(cgroup_fd);
}
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: selftests/bpf: run mptcp in a dedicated netns: Tests Results
2023-02-19 7:01 [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Hangbin Liu
@ 2023-02-19 8:38 ` MPTCP CI
2023-02-20 11:16 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Matthieu Baerts
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: MPTCP CI @ 2023-02-19 8:38 UTC (permalink / raw)
To: Hangbin Liu; +Cc: mptcp
Hi Hangbin,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6016037968150528
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6016037968150528/summary/summary.txt
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6578987921571840
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6578987921571840/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/4749400572952576
- Summary: https://api.cirrus-ci.com/v1/artifact/task/4749400572952576/summary/summary.txt
- KVM Validation: normal (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5453088014729216
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5453088014729216/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/897f90e8a312
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns
2023-02-19 7:01 [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Hangbin Liu
2023-02-19 8:38 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
@ 2023-02-20 11:16 ` Matthieu Baerts
2023-02-20 12:17 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
2023-02-22 23:44 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Martin KaFai Lau
3 siblings, 0 replies; 9+ messages in thread
From: Matthieu Baerts @ 2023-02-20 11:16 UTC (permalink / raw)
To: Hangbin Liu, netdev
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
Jakub Kicinski, David S . Miller, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Mykola Lysenko, Felix Maurer, mptcp
Hi Hangbin,
On 19/02/2023 08:01, Hangbin Liu wrote:
> The current mptcp test is run in init netns. If the user or default
> system config disabled mptcp, the test will fail. Let's run the mptcp
> test in a dedicated netns to avoid none kernel default mptcp setting.
>
> Suggested-by: Martin KaFai Lau <martin.lau@linux.dev>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> v2: remove unneed close_cgroup_fd goto label.
Thank you for the update!
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: selftests/bpf: run mptcp in a dedicated netns: Tests Results
2023-02-19 7:01 [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Hangbin Liu
2023-02-19 8:38 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
2023-02-20 11:16 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Matthieu Baerts
@ 2023-02-20 12:17 ` MPTCP CI
2023-02-22 23:44 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Martin KaFai Lau
3 siblings, 0 replies; 9+ messages in thread
From: MPTCP CI @ 2023-02-20 12:17 UTC (permalink / raw)
To: Hangbin Liu; +Cc: mptcp
Hi Hangbin,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5430059792596992
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5430059792596992/summary/summary.txt
- KVM Validation: normal (only selftest_mptcp_join):
- Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
- Task: https://cirrus-ci.com/task/6211361403830272
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6211361403830272/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5852272257662976
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5852272257662976/summary/summary.txt
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/4726372350820352
- Summary: https://api.cirrus-ci.com/v1/artifact/task/4726372350820352/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/f0fe5983fd4a
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns
2023-02-19 7:01 [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Hangbin Liu
` (2 preceding siblings ...)
2023-02-20 12:17 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
@ 2023-02-22 23:44 ` Martin KaFai Lau
2023-02-23 6:40 ` Hangbin Liu
3 siblings, 1 reply; 9+ messages in thread
From: Martin KaFai Lau @ 2023-02-22 23:44 UTC (permalink / raw)
To: Hangbin Liu
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
Jakub Kicinski, David S . Miller, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Mykola Lysenko, Felix Maurer, Matthieu Baerts, mptcp, netdev
On 2/18/23 11:01 PM, Hangbin Liu wrote:
> The current mptcp test is run in init netns. If the user or default
> system config disabled mptcp, the test will fail. Let's run the mptcp
> test in a dedicated netns to avoid none kernel default mptcp setting.
>
> Suggested-by: Martin KaFai Lau <martin.lau@linux.dev>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> v2: remove unneed close_cgroup_fd goto label.
> ---
> .../testing/selftests/bpf/prog_tests/mptcp.c | 27 +++++++++++++++++--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> index 59f08d6d1d53..dbe2bcfd3b38 100644
> --- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
> +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> @@ -7,6 +7,16 @@
> #include "network_helpers.h"
> #include "mptcp_sock.skel.h"
>
> +#define SYS(fmt, ...) \
> + ({ \
> + char cmd[1024]; \
> + snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \
> + if (!ASSERT_OK(system(cmd), cmd)) \
> + goto fail; \
> + })
> +
> +#define NS_TEST "mptcp_ns"
> +
> #ifndef TCP_CA_NAME_MAX
> #define TCP_CA_NAME_MAX 16
> #endif
> @@ -138,12 +148,20 @@ static int run_test(int cgroup_fd, int server_fd, bool is_mptcp)
>
> static void test_base(void)
> {
> + struct nstoken *nstoken = NULL;
> int server_fd, cgroup_fd;
>
> cgroup_fd = test__join_cgroup("/mptcp");
> if (!ASSERT_GE(cgroup_fd, 0, "test__join_cgroup"))
> return;
>
> + SYS("ip netns add %s", NS_TEST);
> + SYS("ip -net %s link set dev lo up", NS_TEST);
> +
> + nstoken = open_netns(NS_TEST);
> + if (!ASSERT_OK_PTR(nstoken, "open_netns"))
> + goto fail;
> +
> /* without MPTCP */
> server_fd = start_server(AF_INET, SOCK_STREAM, NULL, 0, 0);
> if (!ASSERT_GE(server_fd, 0, "start_server"))
> @@ -157,13 +175,18 @@ static void test_base(void)
> /* with MPTCP */
> server_fd = start_mptcp_server(AF_INET, NULL, 0, 0);
> if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
> - goto close_cgroup_fd;
> + goto fail;
>
> ASSERT_OK(run_test(cgroup_fd, server_fd, true), "run_test mptcp");
>
> close(server_fd);
>
> -close_cgroup_fd:
> +fail:
> + if (nstoken)
> + close_netns(nstoken);
> +
> + system("ip netns del " NS_TEST " >& /dev/null");
It needs to be "&>", like the fix in commit 98e13848cf43 ("selftests/bpf: Fix
decap_sanity_ns cleanup").
Since it needs to respin, could you help and take this chance to put the above
SYS() macro into the test_progs.h. Other selftests are doing similar thing also.
If possible, it may be easier to have a configurable "goto_label" as the first arg.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns
2023-02-22 23:44 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Martin KaFai Lau
@ 2023-02-23 6:40 ` Hangbin Liu
0 siblings, 0 replies; 9+ messages in thread
From: Hangbin Liu @ 2023-02-23 6:40 UTC (permalink / raw)
To: Martin KaFai Lau
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
Jakub Kicinski, David S . Miller, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Mykola Lysenko, Felix Maurer, Matthieu Baerts, mptcp, netdev
On Wed, Feb 22, 2023 at 03:44:17PM -0800, Martin KaFai Lau wrote:
> > + system("ip netns del " NS_TEST " >& /dev/null");
>
> It needs to be "&>", like the fix in commit 98e13848cf43 ("selftests/bpf:
> Fix decap_sanity_ns cleanup").
:Shame, Didn't notice this when do copy/paste...
>
> Since it needs to respin, could you help and take this chance to put the
> above SYS() macro into the test_progs.h. Other selftests are doing similar
> thing also. If possible, it may be easier to have a configurable
> "goto_label" as the first arg.
OK, I will fix it.
Thanks
Hangbin
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCHv3 bpf-next 2/2] selftests/bpf: run mptcp in a dedicated netns
@ 2023-02-24 6:13 Hangbin Liu
2023-02-24 7:18 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Hangbin Liu @ 2023-02-24 6:13 UTC (permalink / raw)
To: netdev
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
Jakub Kicinski, David S . Miller, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Mykola Lysenko, Felix Maurer,
Matthieu Baerts, mptcp, Hangbin Liu
The current mptcp test is run in init netns. If the user or default
system config disabled mptcp, the test will fail. Let's run the mptcp
test in a dedicated netns to avoid none kernel default mptcp setting.
Suggested-by: Martin KaFai Lau <martin.lau@linux.dev>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
.../testing/selftests/bpf/prog_tests/mptcp.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index 59f08d6d1d53..cd0c42fff7c0 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -7,6 +7,8 @@
#include "network_helpers.h"
#include "mptcp_sock.skel.h"
+#define NS_TEST "mptcp_ns"
+
#ifndef TCP_CA_NAME_MAX
#define TCP_CA_NAME_MAX 16
#endif
@@ -138,12 +140,20 @@ static int run_test(int cgroup_fd, int server_fd, bool is_mptcp)
static void test_base(void)
{
+ struct nstoken *nstoken = NULL;
int server_fd, cgroup_fd;
cgroup_fd = test__join_cgroup("/mptcp");
if (!ASSERT_GE(cgroup_fd, 0, "test__join_cgroup"))
return;
+ SYS(fail, "ip netns add %s", NS_TEST);
+ SYS(fail, "ip -net %s link set dev lo up", NS_TEST);
+
+ nstoken = open_netns(NS_TEST);
+ if (!ASSERT_OK_PTR(nstoken, "open_netns"))
+ goto fail;
+
/* without MPTCP */
server_fd = start_server(AF_INET, SOCK_STREAM, NULL, 0, 0);
if (!ASSERT_GE(server_fd, 0, "start_server"))
@@ -157,13 +167,18 @@ static void test_base(void)
/* with MPTCP */
server_fd = start_mptcp_server(AF_INET, NULL, 0, 0);
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
- goto close_cgroup_fd;
+ goto fail;
ASSERT_OK(run_test(cgroup_fd, server_fd, true), "run_test mptcp");
close(server_fd);
-close_cgroup_fd:
+fail:
+ if (nstoken)
+ close_netns(nstoken);
+
+ SYS_NOFAIL("ip netns del " NS_TEST " &> /dev/null");
+
close(cgroup_fd);
}
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: selftests/bpf: run mptcp in a dedicated netns: Tests Results
2023-02-24 6:13 [PATCHv3 bpf-next 2/2] " Hangbin Liu
@ 2023-02-24 7:18 ` MPTCP CI
2023-02-24 8:14 ` MPTCP CI
2023-02-24 10:20 ` MPTCP CI
2 siblings, 0 replies; 9+ messages in thread
From: MPTCP CI @ 2023-02-24 7:18 UTC (permalink / raw)
To: Hangbin Liu; +Cc: mptcp
Hi Hangbin,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join):
- Unstable: 1 failed test(s): selftest_simult_flows 🔴:
- Task: https://cirrus-ci.com/task/5236367773401088
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5236367773401088/summary/summary.txt
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/4954892796690432
- Summary: https://api.cirrus-ci.com/v1/artifact/task/4954892796690432/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6080792703533056
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6080792703533056/summary/summary.txt
- KVM Validation: normal (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6362267680243712
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6362267680243712/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/24c50511901a
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: selftests/bpf: run mptcp in a dedicated netns: Tests Results
2023-02-24 6:13 [PATCHv3 bpf-next 2/2] " Hangbin Liu
2023-02-24 7:18 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
@ 2023-02-24 8:14 ` MPTCP CI
2023-02-24 10:20 ` MPTCP CI
2 siblings, 0 replies; 9+ messages in thread
From: MPTCP CI @ 2023-02-24 8:14 UTC (permalink / raw)
To: Hangbin Liu; +Cc: mptcp
Hi Hangbin,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6389903999631360
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6389903999631360/summary/summary.txt
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6108429022920704
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6108429022920704/summary/summary.txt
- KVM Validation: normal (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/4982529116078080
- Summary: https://api.cirrus-ci.com/v1/artifact/task/4982529116078080/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5545479069499392
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5545479069499392/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a2ffc9d05e68
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: selftests/bpf: run mptcp in a dedicated netns: Tests Results
2023-02-24 6:13 [PATCHv3 bpf-next 2/2] " Hangbin Liu
2023-02-24 7:18 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
2023-02-24 8:14 ` MPTCP CI
@ 2023-02-24 10:20 ` MPTCP CI
2 siblings, 0 replies; 9+ messages in thread
From: MPTCP CI @ 2023-02-24 10:20 UTC (permalink / raw)
To: Hangbin Liu; +Cc: mptcp
Hi Hangbin,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/4837629401759744
- Summary: https://api.cirrus-ci.com/v1/artifact/task/4837629401759744/summary/summary.txt
- KVM Validation: normal (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5139978573840384
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5139978573840384/summary/summary.txt
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5400579355181056
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5400579355181056/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/6526479262023680
- Summary: https://api.cirrus-ci.com/v1/artifact/task/6526479262023680/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/371547334aac
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-24 10:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-19 7:01 [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Hangbin Liu
2023-02-19 8:38 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
2023-02-20 11:16 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Matthieu Baerts
2023-02-20 12:17 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
2023-02-22 23:44 ` [PATCHv2 bpf-next] selftests/bpf: run mptcp in a dedicated netns Martin KaFai Lau
2023-02-23 6:40 ` Hangbin Liu
2023-02-24 6:13 [PATCHv3 bpf-next 2/2] " Hangbin Liu
2023-02-24 7:18 ` selftests/bpf: run mptcp in a dedicated netns: Tests Results MPTCP CI
2023-02-24 8:14 ` MPTCP CI
2023-02-24 10:20 ` MPTCP CI
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.