All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH v5 0/2] Adjustments in function call
@ 2019-10-30  0:48 Javier F. Arias
  2019-10-30  0:48 ` [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
  2019-10-30  0:49 ` [RESEND PATCH v5 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias
  0 siblings, 2 replies; 6+ messages in thread
From: Javier F. Arias @ 2019-10-30  0:48 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

This patchset fixes a warning and simplify a boolean expression in a
function call.

V2: Update the message of the second commit to include the updated
    patch version and to use the Suggested-By tag.
V3: Update the first commit to include the Suggested-By tag and
    the second commit to update the patch version.
V4: Correct the format of the first commit to use the Suggested-by
    tag properly.
V5: Add the version revision that wasn't included in the previous
    patchset.

Javier F. Arias (2):
  staging: rtl8723bs: Fix line over 80 characters
  staging: rtl8723bs: Simplify boolean expression

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.20.1



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters
  2019-10-30  0:48 [RESEND PATCH v5 0/2] Adjustments in function call Javier F. Arias
@ 2019-10-30  0:48 ` Javier F. Arias
  2019-10-30  9:24   ` Greg KH
  2019-10-30  0:49 ` [RESEND PATCH v5 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias
  1 sibling, 1 reply; 6+ messages in thread
From: Javier F. Arias @ 2019-10-30  0:48 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Fix line over 80 characters by wrapping arguments in function call.

Suggested-by: Julia Lawall <julia.lawall@lip6.fr>.
Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
Changes in V3:
	- Edit the commit message to properly use the Suggested-by
	  tag.
Changes in V2:
        - Edit the commit message to use the Suggested-by tag.


 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
index c514cb735afd..0c2f3b2d4326 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [RESEND PATCH v5 2/2] staging: rtl8723bs: Simplify boolean expression
  2019-10-30  0:48 [RESEND PATCH v5 0/2] Adjustments in function call Javier F. Arias
  2019-10-30  0:48 ` [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
@ 2019-10-30  0:49 ` Javier F. Arias
  1 sibling, 0 replies; 6+ messages in thread
From: Javier F. Arias @ 2019-10-30  0:49 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Simplify expression that it's inverting a boolean value.
Issue found by Coccinelle.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
Changes in V2:
        - Edit the commit message to use the Suggested-by tag.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
index 0c2f3b2d4326..6f341d52afb6 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
@@ -190,7 +190,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		ODM_CmnInfoUpdate(&pHalData->odmpriv,
 				  ODM_CMNINFO_BT_ENABLED,
-				  ((bBtDisabled == true)?false:true));
+				  !bBtDisabled);
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters
  2019-10-30  0:48 ` [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
@ 2019-10-30  9:24   ` Greg KH
  2019-10-31 23:16     ` [Outreachy kernel] " Javier F. Arias
  2019-11-01 23:47     ` Javier F. Arias
  0 siblings, 2 replies; 6+ messages in thread
From: Greg KH @ 2019-10-30  9:24 UTC (permalink / raw)
  To: outreachy-kernel

On Tue, Oct 29, 2019 at 07:48:49PM -0500, Javier F. Arias wrote:
> Fix line over 80 characters by wrapping arguments in function call.
> 
> Suggested-by: Julia Lawall <julia.lawall@lip6.fr>.
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
> Changes in V3:
> 	- Edit the commit message to properly use the Suggested-by
> 	  tag.
> Changes in V2:
>         - Edit the commit message to use the Suggested-by tag.

This is a v5 patch, but you only show what happened in v2 and v3, what
about the other 2?

Also, you don't seem to have changed this patch from my last review, why
not?  I will not take this as-is, sorry.  Please fix up and send a new
version based on that review.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters
  2019-10-30  9:24   ` Greg KH
@ 2019-10-31 23:16     ` Javier F. Arias
  2019-11-01 23:47     ` Javier F. Arias
  1 sibling, 0 replies; 6+ messages in thread
From: Javier F. Arias @ 2019-10-31 23:16 UTC (permalink / raw)
  To: Greg KH; +Cc: outreachy-kernel

On Wed, Oct 30, 2019 at 10:24:56AM +0100, Greg KH wrote:
> On Tue, Oct 29, 2019 at 07:48:49PM -0500, Javier F. Arias wrote:
> > Fix line over 80 characters by wrapping arguments in function call.
> > 
> > Suggested-by: Julia Lawall <julia.lawall@lip6.fr>.
> > Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> > ---
> > Changes in V3:
> > 	- Edit the commit message to properly use the Suggested-by
> > 	  tag.
> > Changes in V2:
> >         - Edit the commit message to use the Suggested-by tag.
> 
> This is a v5 patch, but you only show what happened in v2 and v3, what
> about the other 2?
> 
> Also, you don't seem to have changed this patch from my last review, why
> not?  I will not take this as-is, sorry.  Please fix up and send a new
> version based on that review.
> 
> thanks,
> 
> greg k-h
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030092456.GA637833%40kroah.com.

I'm resending this email because my neomutt skipped the list.

Hello Greg,

Sorry, the V4 of this patchset was wrong as I forgot to add the versions on the first patch, so I stopped before sending the second patch and created V5.

About the V5, I think I did what you suggested, as I added a blank line before the Suggested-by tag and deleted the blank line after it.

I'm trying to implement all the suggestions I receive, it's just that I made a couple of mistakes with this patchset (despite being very short), so this is
+why it got to V5. I'll correct all these issues.



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters
  2019-10-30  9:24   ` Greg KH
  2019-10-31 23:16     ` [Outreachy kernel] " Javier F. Arias
@ 2019-11-01 23:47     ` Javier F. Arias
  1 sibling, 0 replies; 6+ messages in thread
From: Javier F. Arias @ 2019-11-01 23:47 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Greg KH

Hello Greg,

I've updated the patch and decided to drop the coverletter. Now all
the changes are clearly defined. I also added your suggestion about
the argument wrapping that I didn't see the first time.

Thanks.

On Wed, Oct 30, 2019 at 10:24:56AM +0100, Greg KH wrote:
> On Tue, Oct 29, 2019 at 07:48:49PM -0500, Javier F. Arias wrote:
> > Fix line over 80 characters by wrapping arguments in function call.
> > 
> > Suggested-by: Julia Lawall <julia.lawall@lip6.fr>.
> > Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> > ---
> > Changes in V3:
> > 	- Edit the commit message to properly use the Suggested-by
> > 	  tag.
> > Changes in V2:
> >         - Edit the commit message to use the Suggested-by tag.
> 
> This is a v5 patch, but you only show what happened in v2 and v3, what
> about the other 2?
> 
> Also, you don't seem to have changed this patch from my last review, why
> not?  I will not take this as-is, sorry.  Please fix up and send a new
> version based on that review.
> 
> thanks,
> 
> greg k-h
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030092456.GA637833%40kroah.com.


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-01 23:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30  0:48 [RESEND PATCH v5 0/2] Adjustments in function call Javier F. Arias
2019-10-30  0:48 ` [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
2019-10-30  9:24   ` Greg KH
2019-10-31 23:16     ` [Outreachy kernel] " Javier F. Arias
2019-11-01 23:47     ` Javier F. Arias
2019-10-30  0:49 ` [RESEND PATCH v5 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.