* [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build
@ 2017-11-03 22:28 Peter Korsgaard
2017-11-03 22:28 ` [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl Peter Korsgaard
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-11-03 22:28 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/
Otherwise the (handwritten) configure script uses a config.guess script from
2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for
Windows or not, which is why things are working on x86(-64) build hosts
without specifying --host even though we are cross compiling - But this may
change in the future, so we better pass the correct values.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/jimtcl/jimtcl.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
index cdbf8ae477..313970d94a 100644
--- a/package/jimtcl/jimtcl.mk
+++ b/package/jimtcl/jimtcl.mk
@@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS
(cd $(@D); \
$(TARGET_CONFIGURE_OPTS) CCACHE=none \
./configure --prefix=/usr \
+ --host=$(GNU_TARGET_NAME) \
+ --build=$(GNU_HOST_NAME) \
$(JIMTCL_SHARED) \
)
endef
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl
2017-11-03 22:28 [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Peter Korsgaard
@ 2017-11-03 22:28 ` Peter Korsgaard
2017-11-04 8:46 ` Peter Korsgaard
2017-11-05 17:04 ` [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Arnout Vandecappelle
2017-11-26 20:32 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2017-11-03 22:28 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/106/106af20196089e74c35daabdae46f030981600bd/
Otherwise the (handwritten) configure script uses a config.guess script from
2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for
Windows or not, which is why things are working on x86(-64) build hosts
without specifying --host even though we are cross compiling - But this may
change in the future, so we better pass the correct values.
Passing extra jimtcl configure flags is unfortunately not forseen in the
usb_modeswitch Makefile, so add a small patch making this possible.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
| 29 ++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 package/usb_modeswitch/0001-Makefile-allow-extra-configure-flags-to-be-passed-to.patch
--git a/package/usb_modeswitch/0001-Makefile-allow-extra-configure-flags-to-be-passed-to.patch b/package/usb_modeswitch/0001-Makefile-allow-extra-configure-flags-to-be-passed-to.patch
new file mode 100644
index 0000000000..9e1e681fa5
--- /dev/null
+++ b/package/usb_modeswitch/0001-Makefile-allow-extra-configure-flags-to-be-passed-to.patch
@@ -0,0 +1,29 @@
+From 1309df373c882f27f476130b06746a6d1e1a0f85 Mon Sep 17 00:00:00 2001
+From: Peter Korsgaard <peter@korsgaard.com>
+Date: Fri, 3 Nov 2017 23:21:44 +0100
+Subject: [PATCH] Makefile: allow extra configure flags to be passed to jimtcl
+ on the make command line
+
+E.G. to pass --host / --build for cross compilation.
+
+Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index a151e2a..94dabd9 100644
+--- a/Makefile
++++ b/Makefile
+@@ -19,7 +19,7 @@ TCL ?= $(HOST_TCL)
+ else
+ TCL ?= /usr/bin/tclsh
+ endif
+-JIM_CONFIGURE_OPTS = --disable-lineedit \
++override JIM_CONFIGURE_OPTS += --disable-lineedit \
+ --with-out-jim-ext="stdlib posix load signal syslog" --prefix=/usr
+
+ .PHONY: clean install install-common uninstall \
+--
+2.11.0
+
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl
2017-11-03 22:28 ` [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl Peter Korsgaard
@ 2017-11-04 8:46 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-11-04 8:46 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Fixes:
> http://autobuild.buildroot.net/results/106/106af20196089e74c35daabdae46f030981600bd/
> Otherwise the (handwritten) configure script uses a config.guess script from
> 2010 to figure out the build host, breaking builds on ppc64le hosts.
> The result of --host / --build is only used to detect if we are building for
> Windows or not, which is why things are working on x86(-64) build hosts
> without specifying --host even though we are cross compiling - But this may
> change in the future, so we better pass the correct values.
> Passing extra jimtcl configure flags is unfortunately not forseen in the
> usb_modeswitch Makefile, so add a small patch making this possible.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> ...low-extra-configure-flags-to-be-passed-to.patch | 29 ++++++++++++++++++++++
Gaah, this is missing the usb_modeswitch.mk hunk. Will resend.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build
2017-11-03 22:28 [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Peter Korsgaard
2017-11-03 22:28 ` [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl Peter Korsgaard
@ 2017-11-05 17:04 ` Arnout Vandecappelle
2017-11-05 19:49 ` Peter Korsgaard
2017-11-26 20:32 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2017-11-05 17:04 UTC (permalink / raw)
To: buildroot
On 03-11-17 23:28, Peter Korsgaard wrote:
> Fixes:
> http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/
>
> Otherwise the (handwritten) configure script uses a config.guess script from
> 2010 to figure out the build host, breaking builds on ppc64le hosts.
>
> The result of --host / --build is only used to detect if we are building for
> Windows or not, which is why things are working on x86(-64) build hosts
> without specifying --host even though we are cross compiling - But this may
> change in the future, so we better pass the correct values.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/jimtcl/jimtcl.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
> index cdbf8ae477..313970d94a 100644
> --- a/package/jimtcl/jimtcl.mk
> +++ b/package/jimtcl/jimtcl.mk
> @@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS
> (cd $(@D); \
> $(TARGET_CONFIGURE_OPTS) CCACHE=none \
> ./configure --prefix=/usr \
> + --host=$(GNU_TARGET_NAME) \
> + --build=$(GNU_HOST_NAME) \
For consistency with pkg-autotools, perhaps you should specify --target as well?
Regards,
Arnout
> $(JIMTCL_SHARED) \
> )
> endef
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build
2017-11-05 17:04 ` [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Arnout Vandecappelle
@ 2017-11-05 19:49 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-11-05 19:49 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 03-11-17 23:28, Peter Korsgaard wrote:
>> Fixes:
>> http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/
>>
>> Otherwise the (handwritten) configure script uses a config.guess script from
>> 2010 to figure out the build host, breaking builds on ppc64le hosts.
>>
>> The result of --host / --build is only used to detect if we are building for
>> Windows or not, which is why things are working on x86(-64) build hosts
>> without specifying --host even though we are cross compiling - But this may
>> change in the future, so we better pass the correct values.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> package/jimtcl/jimtcl.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
>> index cdbf8ae477..313970d94a 100644
>> --- a/package/jimtcl/jimtcl.mk
>> +++ b/package/jimtcl/jimtcl.mk
>> @@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS
>> (cd $(@D); \
>> $(TARGET_CONFIGURE_OPTS) CCACHE=none \
>> ./configure --prefix=/usr \
>> + --host=$(GNU_TARGET_NAME) \
>> + --build=$(GNU_HOST_NAME) \
> For consistency with pkg-autotools, perhaps you should specify --target as well?
--target is only for cross compilers, and the configure script (or
rather system.tcl) doesn't accept it:
Error: Unknown option --target
Try: 'configure --help' for options
So committed as is, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build
2017-11-03 22:28 [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Peter Korsgaard
2017-11-03 22:28 ` [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl Peter Korsgaard
2017-11-05 17:04 ` [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Arnout Vandecappelle
@ 2017-11-26 20:32 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-11-26 20:32 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Fixes:
> http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/
> Otherwise the (handwritten) configure script uses a config.guess script from
> 2010 to figure out the build host, breaking builds on ppc64le hosts.
> The result of --host / --build is only used to detect if we are building for
> Windows or not, which is why things are working on x86(-64) build hosts
> without specifying --host even though we are cross compiling - But this may
> change in the future, so we better pass the correct values.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed to 2017.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-26 20:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 22:28 [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Peter Korsgaard
2017-11-03 22:28 ` [Buildroot] [PATCH 2/2] usb_modeswitch: explicitly set --host / --build for the embedded jimtcl Peter Korsgaard
2017-11-04 8:46 ` Peter Korsgaard
2017-11-05 17:04 ` [Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build Arnout Vandecappelle
2017-11-05 19:49 ` Peter Korsgaard
2017-11-26 20:32 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.