All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Timur Tabi <timur@tabi.org>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20
Date: Mon, 27 Nov 2017 00:13:39 +0100	[thread overview]
Message-ID: <618daa73-dfd4-6e88-617f-10478b45ad64@maciej.szmigiero.name> (raw)
In-Reply-To: <c9310a8f-d16d-ee8f-fe86-8316e71cf7fc@sakamocchi.jp>

Hi,

On 26.11.2017 10:27, Takashi Sakamoto wrote:
> Hi,
> 
(..)
> Before applying this patch:
> 166         /* FIXME: the following three formats are not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> 170         [SNDRV_PCM_FORMAT_GSM] = {
> 171                 .le = -1, .signd = -1,
> 172         },
> 173         [SNDRV_PCM_FORMAT_SPECIAL] = {
> 174                 .le = -1, .signd = -1,
> 175         },
> 
> After applying this patch:
> 
> 166         /* FIXME: the following three formats are not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> 170         [SNDRV_PCM_FORMAT_GSM] = {
> 171                 .le = -1, .signd = -1,
> 172         },
> 173         [SNDRV_PCM_FORMAT_S20_LE] = {
(..)> 
> I think it good to add an alternative comment for each of entry which is not defined yet, like:
> 
> -> 166         /* FIXME: this format is not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> -> 170         /* FIXME: this format is not defined properly yet */
> 171         [SNDRV_PCM_FORMAT_GSM] = {
> 172                 .le = -1, .signd = -1,
> 173         },
> 174         [SNDRV_PCM_FORMAT_S20_LE] = {
> 175                 .width = 20, .phys = 32, .le = 1, .signd = 1,
> 176                 .silence = {},
> 177         },
> 178         [SNDRV_PCM_FORMAT_S20_BE] = {
> 179                 .width = 20, .phys = 32, .le = 0, .signd = 1,
> 180                 .silence = {},
> 181         },
> 182         [SNDRV_PCM_FORMAT_U20_LE] = {
> 183                 .width = 20, .phys = 32, .le = 1, .signd = 0,
> 184                 .silence = { 0x00, 0x00, 0x08, 0x00 },
> 185         },
> 186         [SNDRV_PCM_FORMAT_U20_BE] = {
> 187                 .width = 20, .phys = 32, .le = 0, .signd = 0,
> 188                 .silence = { 0x00, 0x08, 0x00, 0x00 },
> 189         },
> -> 190         /* FIXME: this format is not defined properly yet */
> 191         [SNDRV_PCM_FORMAT_SPECIAL] = {
> 192                 .le = -1, .signd = -1,
> 193         },
> 

Thanks, fixed now in v3.

> Regards
> 
> Takashi Sakamoto

Best regards,
Maciej Szmigiero

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Takashi Iwai <tiwai@suse.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20
Date: Mon, 27 Nov 2017 00:13:39 +0100	[thread overview]
Message-ID: <618daa73-dfd4-6e88-617f-10478b45ad64@maciej.szmigiero.name> (raw)
In-Reply-To: <c9310a8f-d16d-ee8f-fe86-8316e71cf7fc@sakamocchi.jp>

Hi,

On 26.11.2017 10:27, Takashi Sakamoto wrote:
> Hi,
> 
(..)
> Before applying this patch:
> 166         /* FIXME: the following three formats are not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> 170         [SNDRV_PCM_FORMAT_GSM] = {
> 171                 .le = -1, .signd = -1,
> 172         },
> 173         [SNDRV_PCM_FORMAT_SPECIAL] = {
> 174                 .le = -1, .signd = -1,
> 175         },
> 
> After applying this patch:
> 
> 166         /* FIXME: the following three formats are not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> 170         [SNDRV_PCM_FORMAT_GSM] = {
> 171                 .le = -1, .signd = -1,
> 172         },
> 173         [SNDRV_PCM_FORMAT_S20_LE] = {
(..)> 
> I think it good to add an alternative comment for each of entry which is not defined yet, like:
> 
> -> 166         /* FIXME: this format is not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> -> 170         /* FIXME: this format is not defined properly yet */
> 171         [SNDRV_PCM_FORMAT_GSM] = {
> 172                 .le = -1, .signd = -1,
> 173         },
> 174         [SNDRV_PCM_FORMAT_S20_LE] = {
> 175                 .width = 20, .phys = 32, .le = 1, .signd = 1,
> 176                 .silence = {},
> 177         },
> 178         [SNDRV_PCM_FORMAT_S20_BE] = {
> 179                 .width = 20, .phys = 32, .le = 0, .signd = 1,
> 180                 .silence = {},
> 181         },
> 182         [SNDRV_PCM_FORMAT_U20_LE] = {
> 183                 .width = 20, .phys = 32, .le = 1, .signd = 0,
> 184                 .silence = { 0x00, 0x00, 0x08, 0x00 },
> 185         },
> 186         [SNDRV_PCM_FORMAT_U20_BE] = {
> 187                 .width = 20, .phys = 32, .le = 0, .signd = 0,
> 188                 .silence = { 0x00, 0x08, 0x00, 0x00 },
> 189         },
> -> 190         /* FIXME: this format is not defined properly yet */
> 191         [SNDRV_PCM_FORMAT_SPECIAL] = {
> 192                 .le = -1, .signd = -1,
> 193         },
> 

Thanks, fixed now in v3.

> Regards
> 
> Takashi Sakamoto

Best regards,
Maciej Szmigiero
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2017-11-26 23:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 23:31 [PATCH v2 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20 Maciej S. Szmigiero
2017-11-26  9:27 ` [PATCH v2 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20 Takashi Sakamoto
2017-11-26 23:13   ` Maciej S. Szmigiero [this message]
2017-11-26 23:13     ` Maciej S. Szmigiero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=618daa73-dfd4-6e88-617f-10478b45ad64@maciej.szmigiero.name \
    --to=mail@maciej.szmigiero.name \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=timur@tabi.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.