All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
To: Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Johan Hedberg
	<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Bluez mailing list
	<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Bjorn Andersson
	<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT property
Date: Fri, 8 Sep 2017 12:57:40 +0200	[thread overview]
Message-ID: <61944931-B998-4349-A2B1-CAF6D5DD070C@holtmann.org> (raw)
In-Reply-To: <CAMZdPi8gSnS702LadCL7gRKzYbEtOBUZTYUrN1b_1wiycpC1gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Loic,

> > +     /* The local-bd-address property is usually injected by the
> > +      * bootloader which has access to the allocated BD address.
> > +      */
> > +     if (!of_property_read_u8_array(pdev->dev.of_node, "local-bd-address",
> > +                                    (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {
> > +             BT_INFO("BD address %pMR retrieved from device-tree",
> > +                     &btq->bdaddr);
> > +     }
> 
> any reason you are not using bt_dev_info here? I think it would be important to print the device information prefix.
> 
> Yes, hdev does not have any allocated name/number before being registered.
> I can move this after hci_register_dev if you prefer.

if that is possible, then that would be good.

Regards

Marcel

WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Bluez mailing list <linux-bluetooth@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT property
Date: Fri, 8 Sep 2017 12:57:40 +0200	[thread overview]
Message-ID: <61944931-B998-4349-A2B1-CAF6D5DD070C@holtmann.org> (raw)
In-Reply-To: <CAMZdPi8gSnS702LadCL7gRKzYbEtOBUZTYUrN1b_1wiycpC1gw@mail.gmail.com>

Hi Loic,

> > +     /* The local-bd-address property is usually injected by the
> > +      * bootloader which has access to the allocated BD address.
> > +      */
> > +     if (!of_property_read_u8_array(pdev->dev.of_node, "local-bd-address",
> > +                                    (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {
> > +             BT_INFO("BD address %pMR retrieved from device-tree",
> > +                     &btq->bdaddr);
> > +     }
> 
> any reason you are not using bt_dev_info here? I think it would be important to print the device information prefix.
> 
> Yes, hdev does not have any allocated name/number before being registered.
> I can move this after hci_register_dev if you prefer.

if that is possible, then that would be good.

Regards

Marcel


  parent reply	other threads:[~2017-09-08 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 12:11 [PATCH v6 1/3] dt-bindings: net: document Bluetooth bindings in one place Loic Poulain
2017-09-06 12:11 ` [PATCH v6 2/3] dt-bindings: soc: qcom: Add local-bd-address property to WCNSS-BT Loic Poulain
2017-09-06 12:11 ` [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT property Loic Poulain
2017-09-06 17:24   ` Marcel Holtmann
2017-09-08  7:04     ` Loic Poulain
     [not found]       ` <CAMZdPi8gSnS702LadCL7gRKzYbEtOBUZTYUrN1b_1wiycpC1gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-08 10:57         ` Marcel Holtmann [this message]
2017-09-08 10:57           ` Marcel Holtmann
     [not found] ` <1504699898-28011-1-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-09-06 23:26   ` [PATCH v6 1/3] dt-bindings: net: document Bluetooth bindings in one place Bjorn Andersson
2017-09-06 23:26     ` Bjorn Andersson
2017-09-07  6:14     ` Marcel Holtmann
2017-09-07  6:14       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61944931-B998-4349-A2B1-CAF6D5DD070C@holtmann.org \
    --to=marcel-kz+m5ild9qbg9huczpvpmw@public.gmane.org \
    --cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.