All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c
@ 2021-11-27  0:17 wenyehai via ltp
  2021-12-01  1:07 ` xuyang2018.jy
  0 siblings, 1 reply; 4+ messages in thread
From: wenyehai via ltp @ 2021-11-27  0:17 UTC (permalink / raw)
  To: ltp; +Cc: wenyehai

vmsplice/vmsplice02: Remove duplicate header files fcntl.h.

Signed-off-by: Yehai Wen <wenyehai@huawei.com>
---
 testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
index 39c407c..3dc623f 100644
--- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c
+++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
@@ -20,7 +20,6 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <unistd.h>
-#include <fcntl.h>
 #include <sys/uio.h>
 #include <limits.h>
 
-- 
2.7.4


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c
  2021-11-27  0:17 [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c wenyehai via ltp
@ 2021-12-01  1:07 ` xuyang2018.jy
  2021-12-02 11:43   ` [LTP] 答复: " wenyehai via ltp
  0 siblings, 1 reply; 4+ messages in thread
From: xuyang2018.jy @ 2021-12-01  1:07 UTC (permalink / raw)
  To: wenyehai; +Cc: wenyehai via ltp

Hi wen
> vmsplice/vmsplice02: Remove duplicate header files fcntl.h.
>
> Signed-off-by: Yehai Wen<wenyehai@huawei.com>
> ---
>   testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> index 39c407c..3dc623f 100644
> --- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> +++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> @@ -20,7 +20,6 @@
>   #include<sys/stat.h>
>   #include<fcntl.h>
>   #include<unistd.h>
> -#include<fcntl.h>
>   #include<sys/uio.h>
>   #include<limits.h>
Actually, lapi/fcntl.h has included fcntl.h, so the latter fcnlt.h also 
can be removed.

It looks ltp other places also exist this duplicate header files fcntl.h 
because of lapi/fcntl.h. I think we should remove fcntl.h for these 
cases when them use lapi/fcntl.h.

You can use "git grep "fcntl.h" " cmd to search them.


Best Regards
Yang Xu
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [LTP] 答复:  [PATCH] bugfix for vmsplice/vmsplice02.c
  2021-12-01  1:07 ` xuyang2018.jy
@ 2021-12-02 11:43   ` wenyehai via ltp
  0 siblings, 0 replies; 4+ messages in thread
From: wenyehai via ltp @ 2021-12-02 11:43 UTC (permalink / raw)
  To: xuyang2018.jy; +Cc: wenyehai via ltp

Hi Yang Xu:

Thank you very much for your kind suggestions.

I had check with command "git grep "fcntl.h", the result shows that there are 1020 lines used "fcntl.h", and modified 34 testcases involved with the following patch:

0001-bugfix-for-testcases-which-with-duplicate-header-fil.patch

Subject: [LTP][PATCH v2] bugfix for testcases which with duplicate header files


Best Regards
Yehai Wen

-----邮件原件-----
发件人: xuyang2018.jy@fujitsu.com [mailto:xuyang2018.jy@fujitsu.com] 
发送时间: 2021年12月1日 9:07
收件人: wenyehai <wenyehai@huawei.com>
抄送: wenyehai via ltp <ltp@lists.linux.it>
主题: Re: [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c

Hi wen
> vmsplice/vmsplice02: Remove duplicate header files fcntl.h.
>
> Signed-off-by: Yehai Wen<wenyehai@huawei.com>
> ---
>   testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c 
> b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> index 39c407c..3dc623f 100644
> --- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> +++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> @@ -20,7 +20,6 @@
>   #include<sys/stat.h>
>   #include<fcntl.h>
>   #include<unistd.h>
> -#include<fcntl.h>
>   #include<sys/uio.h>
>   #include<limits.h>
Actually, lapi/fcntl.h has included fcntl.h, so the latter fcnlt.h also can be removed.

It looks ltp other places also exist this duplicate header files fcntl.h because of lapi/fcntl.h. I think we should remove fcntl.h for these cases when them use lapi/fcntl.h.

You can use "git grep "fcntl.h" " cmd to search them.


Best Regards
Yang Xu
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c
@ 2021-11-27  2:39 wenyehai via ltp
  0 siblings, 0 replies; 4+ messages in thread
From: wenyehai via ltp @ 2021-11-27  2:39 UTC (permalink / raw)
  To: ltp; +Cc: wenyehai

vmsplice/vmsplice02: Remove duplicate header files fcntl.h.

Signed-off-by: Yehai Wen <wenyehai@huawei.com>
---
 testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
index 39c407c..3dc623f 100644
--- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c
+++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
@@ -20,7 +20,6 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <unistd.h>
-#include <fcntl.h>
 #include <sys/uio.h>
 #include <limits.h>
2.7.4


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-02 11:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-27  0:17 [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c wenyehai via ltp
2021-12-01  1:07 ` xuyang2018.jy
2021-12-02 11:43   ` [LTP] 答复: " wenyehai via ltp
2021-11-27  2:39 [LTP] " wenyehai via ltp

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.