All of lore.kernel.org
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v5 4/4] zram/zram01.sh: replacing data stored in this disk with allocated for this disk
Date: Wed, 22 Dec 2021 09:33:52 +0000	[thread overview]
Message-ID: <61C2F10F.9000901@fujitsu.com> (raw)
In-Reply-To: <YcGTMcan0r2NOcR9@pevik>

Hi Petr

Thanks for your review, I have pushed this patchset.
Also adding some debuginfo in zram03.c like you do in zram_lib.sh.

ps: I have sent a patchset in kernel selftest to update zram case a week 
ago, but doesn't get any reponse...
https://patchwork.kernel.org/project/linux-kselftest/list/?series=595877

Best Regards
Yang Xu
> Hi Xu,
>
>> Hi Petr
>>>> Before ltp commit 4372f7a2156 ("Fix compression ratio calculation in zram01")[1], we
>>> nit: we can drop [1]
>>>> used free -m changes to calculate the compression ratio.
>
>>>> After the above patch, we used compr_data_size to calculate. kernel documentation[2] has
>>> nit: I'd add link to the doc also in this commit message.
>> I don't see the link on your ltp fork:
>> https://github.com/pevik/ltp/tree/yang_xu/zram-swap.v5.fixes
> I haven't fixed it there, I pushed it to verify there is no build failure.
>
>> I have tried this branch and these change seems fine.
> Yes, code should have my suggestions.
>
>> I guess I don't need to send a v6 patch and you can merge it directly(by
>> removing [1][2] linke and adding fixes tag ). Is it right?
> Ah, sure, go ahead and merge. I'm sorry to pick on details.
>
>> ps: I want to add a fixes tag for pointing to commit 4372f7a2156 ("Fix
>> compression ratio calculation in zram01").
> +1, thanks!
>
> Kind regards,
> Petr
>
>> Best Regards
>> Yang Xu

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-12-22  9:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  6:52 [LTP] [PATCH v5 1/4] swapping01: skip test if zram-swap is being used Yang Xu
2021-12-20  6:52 ` [LTP] [PATCH v5 2/4] zram/zram_lib.sh: adapt the situation that zram device " Yang Xu
2021-12-20 10:45   ` Petr Vorel
2021-12-21  1:33     ` xuyang2018.jy
2021-12-20  6:52 ` [LTP] [PATCH v5 3/4] zram/zram03: Convert into new api Yang Xu
2021-12-20  6:52 ` [LTP] [PATCH v5 4/4] zram/zram01.sh: replacing data stored in this disk with allocated for this disk Yang Xu
2021-12-20 10:49   ` Petr Vorel
2021-12-21  2:18     ` xuyang2018.jy
2021-12-21  8:41       ` Petr Vorel
2021-12-22  9:33         ` xuyang2018.jy [this message]
2021-12-22 14:12           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61C2F10F.9000901@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.