* [Intel-wired-lan] [PATCH S48 v3 01/14] ice: Enable flexible descriptor RXDID querying and configuration
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol support for flow filter Qi Zhang
` (13 subsequent siblings)
14 siblings, 0 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
Add support to allow VF to query flexible descriptor RXDIDs supported
by DDP package and configure Rx queues with selected RXDID for IAVF.
Signed-off-by: Xu Ting <ting.xu@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice.h | 1 +
drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 3 +
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 109 ++++++++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 3 +
include/linux/avf/virtchnl.h | 15 +++-
5 files changed, 128 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index a6e419a3f547..5fde85c70e2e 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -437,6 +437,7 @@ struct ice_pf {
u32 sw_int_count;
struct ice_dcf dcf;
+ u64 supported_rxdids; /* bitmap for supported RXDID */
};
struct ice_netdev_priv {
diff --git a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
index 1086c9f778b4..bb1cc372ee95 100644
--- a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
+++ b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
@@ -60,6 +60,9 @@
#define PRTDCB_TUP2TC 0x001D26C0 /* Reset Source: CORER */
#define GL_PREEXT_L2_PMASK0(_i) (0x0020F0FC + ((_i) * 4))
#define GL_PREEXT_L2_PMASK1(_i) (0x0020F108 + ((_i) * 4))
+#define GLFLXP_RXDID_FLAGS(_i, _j) (0x0045D000 + ((_i) * 4 + (_j) * 256))
+#define GLFLXP_RXDID_FLAGS_FLEXIFLAG_4N_S 0
+#define GLFLXP_RXDID_FLAGS_FLEXIFLAG_4N_M ICE_M(0x3F, 0)
#define GLFLXP_RXDID_FLX_WRD_0(_i) (0x0045c800 + ((_i) * 4))
#define GLFLXP_RXDID_FLX_WRD_0_PROT_MDID_S 0
#define GLFLXP_RXDID_FLX_WRD_0_PROT_MDID_M ICE_M(0xFF, 0)
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index fa1f84118456..8022300f9c8e 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -1985,6 +1985,9 @@ static int ice_vc_get_vf_res_msg(struct ice_vf *vf, u8 *msg)
vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_RSS_REG;
}
+ if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC)
+ vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC;
+
if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2)
vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2;
@@ -3059,8 +3062,51 @@ static int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)
vsi->tc_cfg.tc_info[0].qcount_tx = num_txq;
vsi->tc_cfg.tc_info[0].qcount_rx = num_rxq;
- if (ice_vsi_cfg_lan_txqs(vsi) || ice_vsi_cfg_rxqs(vsi))
+ if (ice_vsi_cfg_lan_txqs(vsi) || ice_vsi_cfg_rxqs(vsi)) {
v_ret = VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR;
+ goto error_param;
+ }
+
+ /* VF Rx queue RXDID configuration */
+ for (i = 0; i < qci->num_queue_pairs; i++) {
+ struct ice_hw *hw;
+ u16 queue_id;
+ u32 rxdid;
+ u16 pf_q;
+
+ qpi = &qci->qpair[i];
+
+ /* start queue_id with whatever is specified and update
+ * as needed
+ */
+ queue_id = qpi->rxq.queue_id;
+ if (queue_id >= vsi->alloc_rxq) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+
+ pf_q = vsi->rxq_map[queue_id];
+
+ rxdid = qpi->rxq.rxdid;
+ hw = &vsi->back->hw;
+
+ /* If Rx flex desc is supported, select RXDID for Rx queues.
+ * Otherwise, use legacy 32byte descriptor format.
+ * Legacy 16byte descriptor is not supported. If this RXDID
+ * is selected, return error.
+ */
+ if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC) {
+ if (!(BIT(rxdid) & pf->supported_rxdids)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+ } else {
+ rxdid = ICE_RXDID_LEGACY_1;
+ }
+
+ ice_write_qrxflxp_cntxt(hw, pf_q, rxdid, 0x03);
+
+ }
error_param:
/* send the response to the VF */
@@ -3679,6 +3725,64 @@ static int ice_vc_dis_vlan_stripping(struct ice_vf *vf)
}
/**
+ * ice_vc_query_rxdid - query RXDID supported by DDP package
+ * @vf: pointer to VF info
+ *
+ * Called from VF to query a bitmap of supported flexible
+ * descriptor RXDIDs of a DDP package.
+ */
+static int ice_vc_query_rxdid(struct ice_vf *vf)
+{
+ enum virtchnl_status_code v_ret = VIRTCHNL_STATUS_SUCCESS;
+ struct virtchnl_supported_rxdids *rxdid = NULL;
+ struct ice_hw *hw = &vf->pf->hw;
+ struct ice_pf *pf = vf->pf;
+ int len = 0;
+ int ret, i;
+ u32 regval;
+
+ if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto err;
+ }
+
+ if (!(vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto err;
+ }
+
+ len = sizeof(struct virtchnl_supported_rxdids);
+ rxdid = kzalloc(len, GFP_KERNEL);
+ if (!rxdid) {
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ len = 0;
+ goto err;
+ }
+
+ /* RXDIDs supported by DDP package can be read from the register
+ * to get the supported RXDID bitmap. But the legacy 32byte RXDID
+ * is not listed in DDP package, add it in the bitmap manually.
+ * Legacy 16byte descriptor is not supported.
+ */
+ rxdid->supported_rxdids |= BIT(ICE_RXDID_LEGACY_1);
+
+ for (i = ICE_RXDID_FLEX_NIC; i < ICE_FLEX_DESC_RXDID_MAX_NUM; i++) {
+ regval = rd32(hw, GLFLXP_RXDID_FLAGS(i, 0));
+ if ((regval >> GLFLXP_RXDID_FLAGS_FLEXIFLAG_4N_S)
+ & GLFLXP_RXDID_FLAGS_FLEXIFLAG_4N_M)
+ rxdid->supported_rxdids |= BIT(i);
+ }
+
+ pf->supported_rxdids = rxdid->supported_rxdids;
+
+err:
+ ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_GET_SUPPORTED_RXDIDS,
+ v_ret, (u8 *)rxdid, len);
+ kfree(rxdid);
+ return ret;
+}
+
+/**
* ice_vf_init_vlan_stripping - enable/disable VLAN stripping on initialization
* @vf: VF to enable/disable VLAN stripping for on initialization
*
@@ -4093,6 +4197,9 @@ void ice_vc_process_vf_msg(struct ice_pf *pf, struct ice_rq_event_info *event)
case VIRTCHNL_OP_DEL_VLAN:
err = ice_vc_remove_vlan_msg(vf, msg);
break;
+ case VIRTCHNL_OP_GET_SUPPORTED_RXDIDS:
+ err = ice_vc_query_rxdid(vf);
+ break;
case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING:
err = ice_vc_ena_vlan_stripping(vf);
break;
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
index 4a257415f6a5..25dcdd86d663 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
@@ -40,6 +40,9 @@
#define ice_for_each_vf(pf, i) \
for ((i) = 0; (i) < (pf)->num_alloc_vfs; (i)++)
+/* Max number of flexible descriptor rxdid */
+#define ICE_FLEX_DESC_RXDID_MAX_NUM 64
+
/* Specific VF states */
enum ice_vf_states {
ICE_VF_STATE_INIT = 0, /* PF is initializing VF */
diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
index b14ff350469b..825cdc0e9ffe 100644
--- a/include/linux/avf/virtchnl.h
+++ b/include/linux/avf/virtchnl.h
@@ -142,6 +142,7 @@ enum virtchnl_ops {
VIRTCHNL_OP_DCF_DISABLE = 41,
VIRTCHNL_OP_DCF_GET_VSI_MAP = 42,
VIRTCHNL_OP_DCF_GET_PKG_INFO = 43,
+ VIRTCHNL_OP_GET_SUPPORTED_RXDIDS = 44,
/* New major set of opcodes introduced and so leaving room for
* old misc opcodes to be added in future. Also these opcodes may only
* be used if both the PF and VF have successfully negotiated the
@@ -281,6 +282,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);
#define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM 0X00200000
#define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000
#define VIRTCHNL_VF_OFFLOAD_ADQ 0X00800000
+#define VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC 0X04000000
#define VIRTCHNL_VF_CAP_DCF 0X40000000
/* Define below the capability flags that are not offloads */
@@ -337,10 +339,12 @@ struct virtchnl_rxq_info {
u16 splithdr_enabled; /* deprecated with AVF 1.0 */
u32 databuffer_size;
u32 max_pkt_size;
- u32 pad1;
+ u8 pad1;
+ u8 rxdid;
+ u8 pad2[2];
u64 dma_ring_addr;
enum virtchnl_rx_hsplit rx_split_pos; /* deprecated with AVF 1.0 */
- u32 pad2;
+ u32 pad3;
};
VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_rxq_info);
@@ -669,6 +673,12 @@ struct virtchnl_pkg_info {
VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_pkg_info);
+struct virtchnl_supported_rxdids {
+ u64 supported_rxdids;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_supported_rxdids);
+
/* VIRTCHNL_OP_EVENT
* PF sends this message to inform the VF driver of events that may affect it.
* No direct response is expected from the VF, though it may generate other
@@ -1324,6 +1334,7 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,
case VIRTCHNL_OP_DCF_DISABLE:
case VIRTCHNL_OP_DCF_GET_VSI_MAP:
case VIRTCHNL_OP_DCF_GET_PKG_INFO:
+ case VIRTCHNL_OP_GET_SUPPORTED_RXDIDS:
break;
case VIRTCHNL_OP_GET_CAPS:
valid_len = sizeof(struct virtchnl_get_capabilities);
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol support for flow filter
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 01/14] ice: Enable flexible descriptor RXDID querying and configuration Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-03 4:45 ` Kirsher, Jeffrey T
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 03/14] ice: Support non word aligned input set field Qi Zhang
` (12 subsequent siblings)
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
Add more protocol and field support for flow filter include:
ETH, VLAN, ICAMP, ARP and TCP flag.
Signed-off-by: Kevin Scott <kevin.c.scott@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flow.c | 182 ++++++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_flow.h | 20 +++
drivers/net/ethernet/intel/ice/ice_protocol_type.h | 6 +
3 files changed, 202 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index d74e5290677f..12a579702d40 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -20,6 +20,17 @@ struct ice_flow_field_info {
/* Table containing properties of supported protocol header fields */
static const
struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
+ /* Ether */
+ /* ICE_FLOW_FIELD_IDX_ETH_DA */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, ETH_ALEN),
+ /* ICE_FLOW_FIELD_IDX_ETH_SA */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, ETH_ALEN, ETH_ALEN),
+ /* ICE_FLOW_FIELD_IDX_S_VLAN */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_VLAN, 12, sizeof(__be16)),
+ /* ICE_FLOW_FIELD_IDX_C_VLAN */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_VLAN, 14, sizeof(__be16)),
+ /* ICE_FLOW_FIELD_IDX_ETH_TYPE */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, sizeof(__be16)),
/* IPv4 / IPv6 */
/* ICE_FLOW_FIELD_IDX_IPV4_SA */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_IPV4, 12, sizeof(struct in_addr)),
@@ -42,6 +53,24 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_SCTP, 0, sizeof(__be16)),
/* ICE_FLOW_FIELD_IDX_SCTP_DST_PORT */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_SCTP, 2, sizeof(__be16)),
+ /* ICE_FLOW_FIELD_IDX_TCP_FLAGS */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_TCP, 13, 1),
+ /* ARP */
+ /* ICE_FLOW_FIELD_IDX_ARP_SIP */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 14, sizeof(struct in_addr)),
+ /* ICE_FLOW_FIELD_IDX_ARP_DIP */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 24, sizeof(struct in_addr)),
+ /* ICE_FLOW_FIELD_IDX_ARP_SHA */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 8, ETH_ALEN),
+ /* ICE_FLOW_FIELD_IDX_ARP_DHA */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 18, ETH_ALEN),
+ /* ICE_FLOW_FIELD_IDX_ARP_OP */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 6, sizeof(__be16)),
+ /* ICMP */
+ /* ICE_FLOW_FIELD_IDX_ICMP_TYPE */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ICMP, 0, 1),
+ /* ICE_FLOW_FIELD_IDX_ICMP_CODE */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ICMP, 1, 1),
/* GRE */
/* ICE_FLOW_FIELD_IDX_GRE_KEYID */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GRE, 12,
@@ -50,8 +79,32 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
/* Bitmaps indicating relevant packet types for a particular protocol header
*
- * Packet types for packets with an Outer/First/Single IPv4 header
+ * Packet types for packets with an Outer/First/Single MAC header
*/
+static const u32 ice_ptypes_mac_ofos[] = {
+ 0xFDC00846, 0xBFBF7F7E, 0xF70001DF, 0xFEFDFDFB,
+ 0x0000077E, 0x00000000, 0x00000000, 0x00000000,
+ 0x00400000, 0x03FFF000, 0x7FFFFFE0, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Innermost/Last MAC VLAN header */
+static const u32 ice_ptypes_macvlan_il[] = {
+ 0x00000000, 0xBC000000, 0x000001DF, 0xF0000000,
+ 0x0000077E, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Outer/First/Single IPv4 header */
static const u32 ice_ptypes_ipv4_ofos[] = {
0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -99,6 +152,18 @@ static const u32 ice_ptypes_ipv6_il[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
+/* Packet types for packets with an Outermost/First ARP header */
+static const u32 ice_ptypes_arp_of[] = {
+ 0x00000800, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
/* UDP Packet types for non-tunneled packets or tunneled
* packets with inner UDP.
*/
@@ -134,6 +199,29 @@ static const u32 ice_ptypes_sctp_il[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Outermost/First ICMP header */
+static const u32 ice_ptypes_icmp_of[] = {
+ 0x10000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Innermost/Last ICMP header */
+static const u32 ice_ptypes_icmp_il[] = {
+ 0x00000000, 0x02040408, 0x40000102, 0x08101020,
+ 0x00000408, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x42108000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
@@ -149,6 +237,18 @@ static const u32 ice_ptypes_gre_of[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
+/* Packet types for packets with an Innermost/Last MAC header */
+static const u32 ice_ptypes_mac_il[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
/* Manage parameters and info. used during the creation of a flow profile */
struct ice_flow_prof_params {
enum ice_block blk;
@@ -164,9 +264,11 @@ struct ice_flow_prof_params {
};
#define ICE_FLOW_SEG_HDRS_L3_MASK \
- (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6)
+ (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6 | \
+ ICE_FLOW_SEG_HDR_ARP)
#define ICE_FLOW_SEG_HDRS_L4_MASK \
- (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP | ICE_FLOW_SEG_HDR_SCTP)
+ (ICE_FLOW_SEG_HDR_ICMP | ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP | \
+ ICE_FLOW_SEG_HDR_SCTP)
/**
* ice_flow_val_hdrs - validates packet segments for valid protocol headers
@@ -195,8 +297,11 @@ ice_flow_val_hdrs(struct ice_flow_seg_info *segs, u8 segs_cnt)
/* Sizes of fixed known protocol headers without header options */
#define ICE_FLOW_PROT_HDR_SZ_MAC 14
+#define ICE_FLOW_PROT_HDR_SZ_MAC_VLAN (ICE_FLOW_PROT_HDR_SZ_MAC + 2)
#define ICE_FLOW_PROT_HDR_SZ_IPV4 20
#define ICE_FLOW_PROT_HDR_SZ_IPV6 40
+#define ICE_FLOW_PROT_HDR_SZ_ARP 28
+#define ICE_FLOW_PROT_HDR_SZ_ICMP 8
#define ICE_FLOW_PROT_HDR_SZ_TCP 20
#define ICE_FLOW_PROT_HDR_SZ_UDP 8
#define ICE_FLOW_PROT_HDR_SZ_SCTP 12
@@ -208,16 +313,27 @@ ice_flow_val_hdrs(struct ice_flow_seg_info *segs, u8 segs_cnt)
*/
static u16 ice_flow_calc_seg_sz(struct ice_flow_prof_params *params, u8 seg)
{
- u16 sz = ICE_FLOW_PROT_HDR_SZ_MAC;
+ u16 sz;
+
+ /* L2 headers */
+ sz = (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_VLAN) ?
+ ICE_FLOW_PROT_HDR_SZ_MAC_VLAN : ICE_FLOW_PROT_HDR_SZ_MAC;
/* L3 headers */
if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_IPV4)
sz += ICE_FLOW_PROT_HDR_SZ_IPV4;
else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_IPV6)
sz += ICE_FLOW_PROT_HDR_SZ_IPV6;
+ else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_ARP)
+ sz += ICE_FLOW_PROT_HDR_SZ_ARP;
+ else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDRS_L4_MASK)
+ /* A L3 header is required if L4 is specified */
+ return 0;
/* L4 headers */
- if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_TCP)
+ if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_ICMP)
+ sz += ICE_FLOW_PROT_HDR_SZ_ICMP;
+ else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_TCP)
sz += ICE_FLOW_PROT_HDR_SZ_TCP;
else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_UDP)
sz += ICE_FLOW_PROT_HDR_SZ_UDP;
@@ -250,6 +366,25 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
hdrs = prof->segs[i].hdrs;
+ if (hdrs & ICE_FLOW_SEG_HDR_ETH) {
+ src = !i ? (const unsigned long *)ice_ptypes_mac_ofos :
+ (const unsigned long *)ice_ptypes_mac_il;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ }
+
+ if (i && hdrs & ICE_FLOW_SEG_HDR_VLAN) {
+ src = (const unsigned long *)ice_ptypes_macvlan_il;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ }
+
+ if (!i && hdrs & ICE_FLOW_SEG_HDR_ARP) {
+ bitmap_and(params->ptypes, params->ptypes,
+ (const unsigned long *)ice_ptypes_arp_of,
+ ICE_FLOW_PTYPE_MAX);
+ }
+
if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
src = !i ? (const unsigned long *)ice_ptypes_ipv4_ofos :
(const unsigned long *)ice_ptypes_ipv4_il;
@@ -274,6 +409,13 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
src = (const unsigned long *)ice_ptypes_sctp_il;
bitmap_and(params->ptypes, params->ptypes, src,
ICE_FLOW_PTYPE_MAX);
+ }
+
+ if (hdrs & ICE_FLOW_SEG_HDR_ICMP) {
+ src = !i ? (const unsigned long *)ice_ptypes_icmp_of :
+ (const unsigned long *)ice_ptypes_icmp_il;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
} else if (hdrs & ICE_FLOW_SEG_HDR_GRE) {
if (!i) {
src = (const unsigned long *)ice_ptypes_gre_of;
@@ -310,6 +452,15 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
flds = params->prof->segs[seg].fields;
switch (fld) {
+ case ICE_FLOW_FIELD_IDX_ETH_DA:
+ case ICE_FLOW_FIELD_IDX_ETH_SA:
+ case ICE_FLOW_FIELD_IDX_S_VLAN:
+ case ICE_FLOW_FIELD_IDX_C_VLAN:
+ prot_id = seg == 0 ? ICE_PROT_MAC_OF_OR_S : ICE_PROT_MAC_IL;
+ break;
+ case ICE_FLOW_FIELD_IDX_ETH_TYPE:
+ prot_id = seg == 0 ? ICE_PROT_ETYPE_OL : ICE_PROT_ETYPE_IL;
+ break;
case ICE_FLOW_FIELD_IDX_IPV4_SA:
case ICE_FLOW_FIELD_IDX_IPV4_DA:
prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S : ICE_PROT_IPV4_IL;
@@ -320,6 +471,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
break;
case ICE_FLOW_FIELD_IDX_TCP_SRC_PORT:
case ICE_FLOW_FIELD_IDX_TCP_DST_PORT:
+ case ICE_FLOW_FIELD_IDX_TCP_FLAGS:
prot_id = ICE_PROT_TCP_IL;
break;
case ICE_FLOW_FIELD_IDX_UDP_SRC_PORT:
@@ -330,6 +482,20 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
case ICE_FLOW_FIELD_IDX_SCTP_DST_PORT:
prot_id = ICE_PROT_SCTP_IL;
break;
+ case ICE_FLOW_FIELD_IDX_ARP_SIP:
+ case ICE_FLOW_FIELD_IDX_ARP_DIP:
+ case ICE_FLOW_FIELD_IDX_ARP_SHA:
+ case ICE_FLOW_FIELD_IDX_ARP_DHA:
+ case ICE_FLOW_FIELD_IDX_ARP_OP:
+ prot_id = ICE_PROT_ARP_OF;
+ break;
+ case ICE_FLOW_FIELD_IDX_ICMP_TYPE:
+ case ICE_FLOW_FIELD_IDX_ICMP_CODE:
+ /* ICMP type and code share the same extraction seq. entry */
+ prot_id = (params->prof->segs[seg].hdrs &
+ ICE_FLOW_SEG_HDR_IPV4) ?
+ ICE_PROT_ICMP_IL : ICE_PROT_ICMPV6_IL;
+ break;
case ICE_FLOW_FIELD_IDX_GRE_KEYID:
prot_id = ICE_PROT_GRE_OF;
break;
@@ -1093,6 +1259,9 @@ ice_flow_add_fld_raw(struct ice_flow_seg_info *seg, u16 off, u8 len,
seg->raws_cnt++;
}
+#define ICE_FLOW_RSS_SEG_HDR_L2_MASKS \
+(ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_VLAN)
+
#define ICE_FLOW_RSS_SEG_HDR_L3_MASKS \
(ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6)
@@ -1100,7 +1269,8 @@ ice_flow_add_fld_raw(struct ice_flow_seg_info *seg, u16 off, u8 len,
(ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP | ICE_FLOW_SEG_HDR_SCTP)
#define ICE_FLOW_RSS_SEG_HDR_VAL_MASKS \
- (ICE_FLOW_RSS_SEG_HDR_L3_MASKS | \
+ (ICE_FLOW_RSS_SEG_HDR_L2_MASKS | \
+ ICE_FLOW_RSS_SEG_HDR_L3_MASKS | \
ICE_FLOW_RSS_SEG_HDR_L4_MASKS)
/**
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 3913da2116d2..234f8f5c99cf 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -38,8 +38,12 @@
*/
enum ice_flow_seg_hdr {
ICE_FLOW_SEG_HDR_NONE = 0x00000000,
+ ICE_FLOW_SEG_HDR_ETH = 0x00000001,
+ ICE_FLOW_SEG_HDR_VLAN = 0x00000002,
ICE_FLOW_SEG_HDR_IPV4 = 0x00000004,
ICE_FLOW_SEG_HDR_IPV6 = 0x00000008,
+ ICE_FLOW_SEG_HDR_ARP = 0x00000010,
+ ICE_FLOW_SEG_HDR_ICMP = 0x00000020,
ICE_FLOW_SEG_HDR_TCP = 0x00000040,
ICE_FLOW_SEG_HDR_UDP = 0x00000080,
ICE_FLOW_SEG_HDR_SCTP = 0x00000100,
@@ -47,6 +51,12 @@ enum ice_flow_seg_hdr {
};
enum ice_flow_field {
+ /* L2 */
+ ICE_FLOW_FIELD_IDX_ETH_DA,
+ ICE_FLOW_FIELD_IDX_ETH_SA,
+ ICE_FLOW_FIELD_IDX_S_VLAN,
+ ICE_FLOW_FIELD_IDX_C_VLAN,
+ ICE_FLOW_FIELD_IDX_ETH_TYPE,
/* L3 */
ICE_FLOW_FIELD_IDX_IPV4_SA,
ICE_FLOW_FIELD_IDX_IPV4_DA,
@@ -59,6 +69,16 @@ enum ice_flow_field {
ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT,
ICE_FLOW_FIELD_IDX_SCTP_DST_PORT,
+ ICE_FLOW_FIELD_IDX_TCP_FLAGS,
+ /* ARP */
+ ICE_FLOW_FIELD_IDX_ARP_SIP,
+ ICE_FLOW_FIELD_IDX_ARP_DIP,
+ ICE_FLOW_FIELD_IDX_ARP_SHA,
+ ICE_FLOW_FIELD_IDX_ARP_DHA,
+ ICE_FLOW_FIELD_IDX_ARP_OP,
+ /* ICMP */
+ ICE_FLOW_FIELD_IDX_ICMP_TYPE,
+ ICE_FLOW_FIELD_IDX_ICMP_CODE,
/* GRE */
ICE_FLOW_FIELD_IDX_GRE_KEYID,
/* The total number of enums must not exceed 64 */
diff --git a/drivers/net/ethernet/intel/ice/ice_protocol_type.h b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
index 7f4c1ec1eff2..fac5f15a692c 100644
--- a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
@@ -13,6 +13,9 @@
enum ice_prot_id {
ICE_PROT_ID_INVAL = 0,
ICE_PROT_MAC_OF_OR_S = 1,
+ ICE_PROT_MAC_IL = 4,
+ ICE_PROT_ETYPE_OL = 9,
+ ICE_PROT_ETYPE_IL = 10,
ICE_PROT_IPV4_OF_OR_S = 32,
ICE_PROT_IPV4_IL = 33,
ICE_PROT_IPV6_OF_OR_S = 40,
@@ -22,6 +25,9 @@ enum ice_prot_id {
ICE_PROT_UDP_IL_OR_S = 53,
ICE_PROT_GRE_OF = 64,
ICE_PROT_SCTP_IL = 96,
+ ICE_PROT_ICMP_IL = 98,
+ ICE_PROT_ICMPV6_IL = 100,
+ ICE_PROT_ARP_OF = 118,
ICE_PROT_META_ID = 255, /* when offset == metadata */
ICE_PROT_INVALID = 255 /* when offset == ICE_FV_OFFSET_INVAL */
};
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol support for flow filter
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol support for flow filter Qi Zhang
@ 2020-07-03 4:45 ` Kirsher, Jeffrey T
2020-07-04 1:51 ` Zhang, Qi Z
0 siblings, 1 reply; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 4:45 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol
> support for flow filter
>
> Add more protocol and field support for flow filter include:
> ETH, VLAN, ICAMP, ARP and TCP flag.
>
> Signed-off-by: Kevin Scott <kevin.c.scott@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_flow.c | 182
> ++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_flow.h | 20 +++
> drivers/net/ethernet/intel/ice/ice_protocol_type.h | 6 +
> 3 files changed, 202 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c
> b/drivers/net/ethernet/intel/ice/ice_flow.c
> index d74e5290677f..12a579702d40 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.c
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.c
> @@ -20,6 +20,17 @@ struct ice_flow_field_info {
> /* Table containing properties of supported protocol header fields */ static
> const struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> + /* Ether */
> + /* ICE_FLOW_FIELD_IDX_ETH_DA */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, ETH_ALEN),
> + /* ICE_FLOW_FIELD_IDX_ETH_SA */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, ETH_ALEN,
> ETH_ALEN),
> + /* ICE_FLOW_FIELD_IDX_S_VLAN */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_VLAN, 12, sizeof(__be16)),
> + /* ICE_FLOW_FIELD_IDX_C_VLAN */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_VLAN, 14, sizeof(__be16)),
> + /* ICE_FLOW_FIELD_IDX_ETH_TYPE */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, sizeof(__be16)),
> /* IPv4 / IPv6 */
> /* ICE_FLOW_FIELD_IDX_IPV4_SA */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_IPV4, 12, sizeof(struct
> in_addr)), @@ -42,6 +53,24 @@ struct ice_flow_field_info
> ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_SCTP, 0, sizeof(__be16)),
> /* ICE_FLOW_FIELD_IDX_SCTP_DST_PORT */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_SCTP, 2, sizeof(__be16)),
> + /* ICE_FLOW_FIELD_IDX_TCP_FLAGS */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_TCP, 13, 1),
> + /* ARP */
> + /* ICE_FLOW_FIELD_IDX_ARP_SIP */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 14, sizeof(struct
> in_addr)),
> + /* ICE_FLOW_FIELD_IDX_ARP_DIP */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 24, sizeof(struct
> in_addr)),
> + /* ICE_FLOW_FIELD_IDX_ARP_SHA */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 8, ETH_ALEN),
> + /* ICE_FLOW_FIELD_IDX_ARP_DHA */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 18, ETH_ALEN),
> + /* ICE_FLOW_FIELD_IDX_ARP_OP */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 6, sizeof(__be16)),
> + /* ICMP */
> + /* ICE_FLOW_FIELD_IDX_ICMP_TYPE */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ICMP, 0, 1),
> + /* ICE_FLOW_FIELD_IDX_ICMP_CODE */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ICMP, 1, 1),
> /* GRE */
> /* ICE_FLOW_FIELD_IDX_GRE_KEYID */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GRE, 12, @@ -50,8 +79,32
> @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
>
> /* Bitmaps indicating relevant packet types for a particular protocol header
> *
> - * Packet types for packets with an Outer/First/Single IPv4 header
> + * Packet types for packets with an Outer/First/Single MAC header
> */
> +static const u32 ice_ptypes_mac_ofos[] = {
> + 0xFDC00846, 0xBFBF7F7E, 0xF70001DF, 0xFEFDFDFB,
> + 0x0000077E, 0x00000000, 0x00000000, 0x00000000,
> + 0x00400000, 0x03FFF000, 0x7FFFFFE0, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with an Innermost/Last MAC VLAN header */
> +static const u32 ice_ptypes_macvlan_il[] = {
> + 0x00000000, 0xBC000000, 0x000001DF, 0xF0000000,
> + 0x0000077E, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with an Outer/First/Single IPv4 header */
> static const u32 ice_ptypes_ipv4_ofos[] = {
> 0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -99,6 +152,18
> @@ static const u32 ice_ptypes_ipv6_il[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> +/* Packet types for packets with an Outermost/First ARP header */
> +static const u32 ice_ptypes_arp_of[] = {
> + 0x00000800, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> /* UDP Packet types for non-tunneled packets or tunneled
> * packets with inner UDP.
> */
> @@ -134,6 +199,29 @@ static const u32 ice_ptypes_sctp_il[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> +};
> +
> +/* Packet types for packets with an Outermost/First ICMP header */
> +static const u32 ice_ptypes_icmp_of[] = {
> + 0x10000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with an Innermost/Last ICMP header */
> +static const u32 ice_ptypes_icmp_il[] = {
> + 0x00000000, 0x02040408, 0x40000102, 0x08101020,
> + 0x00000408, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x42108000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> @@ -149,6 +237,18 @@ static const u32 ice_ptypes_gre_of[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> +/* Packet types for packets with an Innermost/Last MAC header */ static
> +const u32 ice_ptypes_mac_il[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> /* Manage parameters and info. used during the creation of a flow profile */
> struct ice_flow_prof_params {
> enum ice_block blk;
> @@ -164,9 +264,11 @@ struct ice_flow_prof_params { };
>
> #define ICE_FLOW_SEG_HDRS_L3_MASK \
> - (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6)
> + (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6 | \
> + ICE_FLOW_SEG_HDR_ARP)
> #define ICE_FLOW_SEG_HDRS_L4_MASK \
> - (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP |
> ICE_FLOW_SEG_HDR_SCTP)
> + (ICE_FLOW_SEG_HDR_ICMP | ICE_FLOW_SEG_HDR_TCP |
> ICE_FLOW_SEG_HDR_UDP | \
> + ICE_FLOW_SEG_HDR_SCTP)
>
> /**
> * ice_flow_val_hdrs - validates packet segments for valid protocol headers
> @@ -195,8 +297,11 @@ ice_flow_val_hdrs(struct ice_flow_seg_info *segs, u8
> segs_cnt)
>
> /* Sizes of fixed known protocol headers without header options */
> #define ICE_FLOW_PROT_HDR_SZ_MAC 14
> +#define ICE_FLOW_PROT_HDR_SZ_MAC_VLAN
> (ICE_FLOW_PROT_HDR_SZ_MAC + 2)
> #define ICE_FLOW_PROT_HDR_SZ_IPV4 20
> #define ICE_FLOW_PROT_HDR_SZ_IPV6 40
> +#define ICE_FLOW_PROT_HDR_SZ_ARP 28
> +#define ICE_FLOW_PROT_HDR_SZ_ICMP 8
> #define ICE_FLOW_PROT_HDR_SZ_TCP 20
> #define ICE_FLOW_PROT_HDR_SZ_UDP 8
> #define ICE_FLOW_PROT_HDR_SZ_SCTP 12
> @@ -208,16 +313,27 @@ ice_flow_val_hdrs(struct ice_flow_seg_info *segs, u8
> segs_cnt)
> */
> static u16 ice_flow_calc_seg_sz(struct ice_flow_prof_params *params, u8 seg)
> {
> - u16 sz = ICE_FLOW_PROT_HDR_SZ_MAC;
> + u16 sz;
> +
> + /* L2 headers */
> + sz = (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_VLAN) ?
> + ICE_FLOW_PROT_HDR_SZ_MAC_VLAN :
> ICE_FLOW_PROT_HDR_SZ_MAC;
>
> /* L3 headers */
> if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_IPV4)
> sz += ICE_FLOW_PROT_HDR_SZ_IPV4;
> else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_IPV6)
> sz += ICE_FLOW_PROT_HDR_SZ_IPV6;
> + else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_ARP)
> + sz += ICE_FLOW_PROT_HDR_SZ_ARP;
> + else if (params->prof->segs[seg].hdrs &
> ICE_FLOW_SEG_HDRS_L4_MASK)
> + /* A L3 header is required if L4 is specified */
> + return 0;
>
> /* L4 headers */
> - if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_TCP)
> + if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_ICMP)
> + sz += ICE_FLOW_PROT_HDR_SZ_ICMP;
> + else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_TCP)
> sz += ICE_FLOW_PROT_HDR_SZ_TCP;
> else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_UDP)
> sz += ICE_FLOW_PROT_HDR_SZ_UDP;
> @@ -250,6 +366,25 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
>
> hdrs = prof->segs[i].hdrs;
>
> + if (hdrs & ICE_FLOW_SEG_HDR_ETH) {
> + src = !i ? (const unsigned long *)ice_ptypes_mac_ofos :
> + (const unsigned long *)ice_ptypes_mac_il;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + }
> +
> + if (i && hdrs & ICE_FLOW_SEG_HDR_VLAN) {
> + src = (const unsigned long *)ice_ptypes_macvlan_il;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + }
> +
> + if (!i && hdrs & ICE_FLOW_SEG_HDR_ARP) {
> + bitmap_and(params->ptypes, params->ptypes,
> + (const unsigned long *)ice_ptypes_arp_of,
> + ICE_FLOW_PTYPE_MAX);
> + }
> +
> if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
> src = !i ? (const unsigned long *)ice_ptypes_ipv4_ofos :
> (const unsigned long *)ice_ptypes_ipv4_il; @@ -
> 274,6 +409,13 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
> src = (const unsigned long *)ice_ptypes_sctp_il;
> bitmap_and(params->ptypes, params->ptypes, src,
> ICE_FLOW_PTYPE_MAX);
> + }
> +
> + if (hdrs & ICE_FLOW_SEG_HDR_ICMP) {
> + src = !i ? (const unsigned long *)ice_ptypes_icmp_of :
> + (const unsigned long *)ice_ptypes_icmp_il;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> } else if (hdrs & ICE_FLOW_SEG_HDR_GRE) {
> if (!i) {
> src = (const unsigned long *)ice_ptypes_gre_of;
> @@ -310,6 +452,15 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct
> ice_flow_prof_params *params,
> flds = params->prof->segs[seg].fields;
>
> switch (fld) {
> + case ICE_FLOW_FIELD_IDX_ETH_DA:
> + case ICE_FLOW_FIELD_IDX_ETH_SA:
> + case ICE_FLOW_FIELD_IDX_S_VLAN:
> + case ICE_FLOW_FIELD_IDX_C_VLAN:
> + prot_id = seg == 0 ? ICE_PROT_MAC_OF_OR_S :
> ICE_PROT_MAC_IL;
> + break;
> + case ICE_FLOW_FIELD_IDX_ETH_TYPE:
> + prot_id = seg == 0 ? ICE_PROT_ETYPE_OL :
> ICE_PROT_ETYPE_IL;
> + break;
> case ICE_FLOW_FIELD_IDX_IPV4_SA:
> case ICE_FLOW_FIELD_IDX_IPV4_DA:
> prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S :
> ICE_PROT_IPV4_IL; @@ -320,6 +471,7 @@ ice_flow_xtract_fld(struct ice_hw
> *hw, struct ice_flow_prof_params *params,
> break;
> case ICE_FLOW_FIELD_IDX_TCP_SRC_PORT:
> case ICE_FLOW_FIELD_IDX_TCP_DST_PORT:
> + case ICE_FLOW_FIELD_IDX_TCP_FLAGS:
> prot_id = ICE_PROT_TCP_IL;
> break;
> case ICE_FLOW_FIELD_IDX_UDP_SRC_PORT:
> @@ -330,6 +482,20 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct
> ice_flow_prof_params *params,
> case ICE_FLOW_FIELD_IDX_SCTP_DST_PORT:
> prot_id = ICE_PROT_SCTP_IL;
> break;
> + case ICE_FLOW_FIELD_IDX_ARP_SIP:
> + case ICE_FLOW_FIELD_IDX_ARP_DIP:
> + case ICE_FLOW_FIELD_IDX_ARP_SHA:
> + case ICE_FLOW_FIELD_IDX_ARP_DHA:
> + case ICE_FLOW_FIELD_IDX_ARP_OP:
> + prot_id = ICE_PROT_ARP_OF;
> + break;
> + case ICE_FLOW_FIELD_IDX_ICMP_TYPE:
> + case ICE_FLOW_FIELD_IDX_ICMP_CODE:
> + /* ICMP type and code share the same extraction seq. entry */
> + prot_id = (params->prof->segs[seg].hdrs &
> + ICE_FLOW_SEG_HDR_IPV4) ?
> + ICE_PROT_ICMP_IL : ICE_PROT_ICMPV6_IL;
The above 3 lines are not wrapped properly, and since we can have lines up to 100 chars now, this can fit on 2 lines.
> + break;
> case ICE_FLOW_FIELD_IDX_GRE_KEYID:
> prot_id = ICE_PROT_GRE_OF;
> break;
> @@ -1093,6 +1259,9 @@ ice_flow_add_fld_raw(struct ice_flow_seg_info *seg,
> u16 off, u8 len,
> seg->raws_cnt++;
> }
>
> +#define ICE_FLOW_RSS_SEG_HDR_L2_MASKS \ (ICE_FLOW_SEG_HDR_ETH |
> +ICE_FLOW_SEG_HDR_VLAN)
> +
> #define ICE_FLOW_RSS_SEG_HDR_L3_MASKS \
> (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6)
>
> @@ -1100,7 +1269,8 @@ ice_flow_add_fld_raw(struct ice_flow_seg_info *seg,
> u16 off, u8 len,
> (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP |
> ICE_FLOW_SEG_HDR_SCTP)
>
> #define ICE_FLOW_RSS_SEG_HDR_VAL_MASKS \
> - (ICE_FLOW_RSS_SEG_HDR_L3_MASKS | \
> + (ICE_FLOW_RSS_SEG_HDR_L2_MASKS | \
> + ICE_FLOW_RSS_SEG_HDR_L3_MASKS | \
> ICE_FLOW_RSS_SEG_HDR_L4_MASKS)
>
> /**
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h
> b/drivers/net/ethernet/intel/ice/ice_flow.h
> index 3913da2116d2..234f8f5c99cf 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> @@ -38,8 +38,12 @@
> */
> enum ice_flow_seg_hdr {
> ICE_FLOW_SEG_HDR_NONE = 0x00000000,
> + ICE_FLOW_SEG_HDR_ETH = 0x00000001,
> + ICE_FLOW_SEG_HDR_VLAN = 0x00000002,
> ICE_FLOW_SEG_HDR_IPV4 = 0x00000004,
> ICE_FLOW_SEG_HDR_IPV6 = 0x00000008,
> + ICE_FLOW_SEG_HDR_ARP = 0x00000010,
> + ICE_FLOW_SEG_HDR_ICMP = 0x00000020,
> ICE_FLOW_SEG_HDR_TCP = 0x00000040,
> ICE_FLOW_SEG_HDR_UDP = 0x00000080,
> ICE_FLOW_SEG_HDR_SCTP = 0x00000100,
> @@ -47,6 +51,12 @@ enum ice_flow_seg_hdr { };
>
> enum ice_flow_field {
> + /* L2 */
> + ICE_FLOW_FIELD_IDX_ETH_DA,
> + ICE_FLOW_FIELD_IDX_ETH_SA,
> + ICE_FLOW_FIELD_IDX_S_VLAN,
> + ICE_FLOW_FIELD_IDX_C_VLAN,
> + ICE_FLOW_FIELD_IDX_ETH_TYPE,
> /* L3 */
> ICE_FLOW_FIELD_IDX_IPV4_SA,
> ICE_FLOW_FIELD_IDX_IPV4_DA,
> @@ -59,6 +69,16 @@ enum ice_flow_field {
> ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_DST_PORT,
> + ICE_FLOW_FIELD_IDX_TCP_FLAGS,
> + /* ARP */
> + ICE_FLOW_FIELD_IDX_ARP_SIP,
> + ICE_FLOW_FIELD_IDX_ARP_DIP,
> + ICE_FLOW_FIELD_IDX_ARP_SHA,
> + ICE_FLOW_FIELD_IDX_ARP_DHA,
> + ICE_FLOW_FIELD_IDX_ARP_OP,
> + /* ICMP */
> + ICE_FLOW_FIELD_IDX_ICMP_TYPE,
> + ICE_FLOW_FIELD_IDX_ICMP_CODE,
> /* GRE */
> ICE_FLOW_FIELD_IDX_GRE_KEYID,
> /* The total number of enums must not exceed 64 */ diff --git
> a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> index 7f4c1ec1eff2..fac5f15a692c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> @@ -13,6 +13,9 @@
> enum ice_prot_id {
> ICE_PROT_ID_INVAL = 0,
> ICE_PROT_MAC_OF_OR_S = 1,
> + ICE_PROT_MAC_IL = 4,
> + ICE_PROT_ETYPE_OL = 9,
> + ICE_PROT_ETYPE_IL = 10,
> ICE_PROT_IPV4_OF_OR_S = 32,
> ICE_PROT_IPV4_IL = 33,
> ICE_PROT_IPV6_OF_OR_S = 40,
> @@ -22,6 +25,9 @@ enum ice_prot_id {
> ICE_PROT_UDP_IL_OR_S = 53,
> ICE_PROT_GRE_OF = 64,
> ICE_PROT_SCTP_IL = 96,
> + ICE_PROT_ICMP_IL = 98,
> + ICE_PROT_ICMPV6_IL = 100,
> + ICE_PROT_ARP_OF = 118,
> ICE_PROT_META_ID = 255, /* when offset == metadata */
> ICE_PROT_INVALID = 255 /* when offset == ICE_FV_OFFSET_INVAL
> */
> };
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol support for flow filter
2020-07-03 4:45 ` Kirsher, Jeffrey T
@ 2020-07-04 1:51 ` Zhang, Qi Z
0 siblings, 0 replies; 31+ messages in thread
From: Zhang, Qi Z @ 2020-07-04 1:51 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Sent: Friday, July 3, 2020 12:46 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic
> protocol support for flow filter
>
>
>
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> > Of Qi Zhang
> > Sent: Thursday, July 2, 2020 15:58
> > To: intel-wired-lan at lists.osuosl.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Subject: [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic
> > protocol support for flow filter
> >
> > Add more protocol and field support for flow filter include:
> > ETH, VLAN, ICAMP, ARP and TCP flag.
> >
> > Signed-off-by: Kevin Scott <kevin.c.scott@intel.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_flow.c | 182
> > ++++++++++++++++++++-
> > drivers/net/ethernet/intel/ice/ice_flow.h | 20 +++
> > drivers/net/ethernet/intel/ice/ice_protocol_type.h | 6 +
> > 3 files changed, 202 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c
> > b/drivers/net/ethernet/intel/ice/ice_flow.c
> > index d74e5290677f..12a579702d40 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_flow.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_flow.c
> > @@ -20,6 +20,17 @@ struct ice_flow_field_info {
> > /* Table containing properties of supported protocol header fields */
> > static const struct ice_flow_field_info
> > ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> > + /* Ether */
> > + /* ICE_FLOW_FIELD_IDX_ETH_DA */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, ETH_ALEN),
> > + /* ICE_FLOW_FIELD_IDX_ETH_SA */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, ETH_ALEN,
> > ETH_ALEN),
> > + /* ICE_FLOW_FIELD_IDX_S_VLAN */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_VLAN, 12, sizeof(__be16)),
> > + /* ICE_FLOW_FIELD_IDX_C_VLAN */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_VLAN, 14, sizeof(__be16)),
> > + /* ICE_FLOW_FIELD_IDX_ETH_TYPE */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, sizeof(__be16)),
> > /* IPv4 / IPv6 */
> > /* ICE_FLOW_FIELD_IDX_IPV4_SA */
> > ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_IPV4, 12, sizeof(struct
> > in_addr)), @@ -42,6 +53,24 @@ struct ice_flow_field_info
> > ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> > ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_SCTP, 0, sizeof(__be16)),
> > /* ICE_FLOW_FIELD_IDX_SCTP_DST_PORT */
> > ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_SCTP, 2, sizeof(__be16)),
> > + /* ICE_FLOW_FIELD_IDX_TCP_FLAGS */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_TCP, 13, 1),
> > + /* ARP */
> > + /* ICE_FLOW_FIELD_IDX_ARP_SIP */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 14, sizeof(struct
> > in_addr)),
> > + /* ICE_FLOW_FIELD_IDX_ARP_DIP */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 24, sizeof(struct
> > in_addr)),
> > + /* ICE_FLOW_FIELD_IDX_ARP_SHA */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 8, ETH_ALEN),
> > + /* ICE_FLOW_FIELD_IDX_ARP_DHA */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 18, ETH_ALEN),
> > + /* ICE_FLOW_FIELD_IDX_ARP_OP */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ARP, 6, sizeof(__be16)),
> > + /* ICMP */
> > + /* ICE_FLOW_FIELD_IDX_ICMP_TYPE */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ICMP, 0, 1),
> > + /* ICE_FLOW_FIELD_IDX_ICMP_CODE */
> > + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ICMP, 1, 1),
> > /* GRE */
> > /* ICE_FLOW_FIELD_IDX_GRE_KEYID */
> > ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GRE, 12, @@ -50,8 +79,32
> @@
> > struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> >
> > /* Bitmaps indicating relevant packet types for a particular protocol
> header
> > *
> > - * Packet types for packets with an Outer/First/Single IPv4 header
> > + * Packet types for packets with an Outer/First/Single MAC header
> > */
> > +static const u32 ice_ptypes_mac_ofos[] = {
> > + 0xFDC00846, 0xBFBF7F7E, 0xF70001DF, 0xFEFDFDFB,
> > + 0x0000077E, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00400000, 0x03FFF000, 0x7FFFFFE0, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> > +
> > +/* Packet types for packets with an Innermost/Last MAC VLAN header */
> > +static const u32 ice_ptypes_macvlan_il[] = {
> > + 0x00000000, 0xBC000000, 0x000001DF, 0xF0000000,
> > + 0x0000077E, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> > +
> > +/* Packet types for packets with an Outer/First/Single IPv4 header */
> > static const u32 ice_ptypes_ipv4_ofos[] = {
> > 0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -99,6
> +152,18 @@
> > static const u32 ice_ptypes_ipv6_il[] = {
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> >
> > +/* Packet types for packets with an Outermost/First ARP header */
> > +static const u32 ice_ptypes_arp_of[] = {
> > + 0x00000800, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> > +
> > /* UDP Packet types for non-tunneled packets or tunneled
> > * packets with inner UDP.
> > */
> > @@ -134,6 +199,29 @@ static const u32 ice_ptypes_sctp_il[] = {
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > +};
> > +
> > +/* Packet types for packets with an Outermost/First ICMP header */
> > +static const u32 ice_ptypes_icmp_of[] = {
> > + 0x10000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> > +
> > +/* Packet types for packets with an Innermost/Last ICMP header */
> > +static const u32 ice_ptypes_icmp_il[] = {
> > + 0x00000000, 0x02040408, 0x40000102, 0x08101020,
> > + 0x00000408, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x42108000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> >
> > @@ -149,6 +237,18 @@ static const u32 ice_ptypes_gre_of[] = {
> > 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> >
> > +/* Packet types for packets with an Innermost/Last MAC header */
> > +static const u32 ice_ptypes_mac_il[] = {
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> > + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> > +
> > /* Manage parameters and info. used during the creation of a flow
> > profile */ struct ice_flow_prof_params {
> > enum ice_block blk;
> > @@ -164,9 +264,11 @@ struct ice_flow_prof_params { };
> >
> > #define ICE_FLOW_SEG_HDRS_L3_MASK \
> > - (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6)
> > + (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6 | \
> > + ICE_FLOW_SEG_HDR_ARP)
> > #define ICE_FLOW_SEG_HDRS_L4_MASK \
> > - (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP |
> > ICE_FLOW_SEG_HDR_SCTP)
> > + (ICE_FLOW_SEG_HDR_ICMP | ICE_FLOW_SEG_HDR_TCP |
> > ICE_FLOW_SEG_HDR_UDP | \
> > + ICE_FLOW_SEG_HDR_SCTP)
> >
> > /**
> > * ice_flow_val_hdrs - validates packet segments for valid protocol
> > headers @@ -195,8 +297,11 @@ ice_flow_val_hdrs(struct
> > ice_flow_seg_info *segs, u8
> > segs_cnt)
> >
> > /* Sizes of fixed known protocol headers without header options */
> > #define ICE_FLOW_PROT_HDR_SZ_MAC 14
> > +#define ICE_FLOW_PROT_HDR_SZ_MAC_VLAN
> > (ICE_FLOW_PROT_HDR_SZ_MAC + 2)
> > #define ICE_FLOW_PROT_HDR_SZ_IPV4 20
> > #define ICE_FLOW_PROT_HDR_SZ_IPV6 40
> > +#define ICE_FLOW_PROT_HDR_SZ_ARP 28
> > +#define ICE_FLOW_PROT_HDR_SZ_ICMP 8
> > #define ICE_FLOW_PROT_HDR_SZ_TCP 20
> > #define ICE_FLOW_PROT_HDR_SZ_UDP 8
> > #define ICE_FLOW_PROT_HDR_SZ_SCTP 12
> > @@ -208,16 +313,27 @@ ice_flow_val_hdrs(struct ice_flow_seg_info
> > *segs, u8
> > segs_cnt)
> > */
> > static u16 ice_flow_calc_seg_sz(struct ice_flow_prof_params *params,
> > u8 seg) {
> > - u16 sz = ICE_FLOW_PROT_HDR_SZ_MAC;
> > + u16 sz;
> > +
> > + /* L2 headers */
> > + sz = (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_VLAN) ?
> > + ICE_FLOW_PROT_HDR_SZ_MAC_VLAN :
> > ICE_FLOW_PROT_HDR_SZ_MAC;
> >
> > /* L3 headers */
> > if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_IPV4)
> > sz += ICE_FLOW_PROT_HDR_SZ_IPV4;
> > else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_IPV6)
> > sz += ICE_FLOW_PROT_HDR_SZ_IPV6;
> > + else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_ARP)
> > + sz += ICE_FLOW_PROT_HDR_SZ_ARP;
> > + else if (params->prof->segs[seg].hdrs &
> > ICE_FLOW_SEG_HDRS_L4_MASK)
> > + /* A L3 header is required if L4 is specified */
> > + return 0;
> >
> > /* L4 headers */
> > - if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_TCP)
> > + if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_ICMP)
> > + sz += ICE_FLOW_PROT_HDR_SZ_ICMP;
> > + else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_TCP)
> > sz += ICE_FLOW_PROT_HDR_SZ_TCP;
> > else if (params->prof->segs[seg].hdrs & ICE_FLOW_SEG_HDR_UDP)
> > sz += ICE_FLOW_PROT_HDR_SZ_UDP;
> > @@ -250,6 +366,25 @@ ice_flow_proc_seg_hdrs(struct
> > ice_flow_prof_params
> > *params)
> >
> > hdrs = prof->segs[i].hdrs;
> >
> > + if (hdrs & ICE_FLOW_SEG_HDR_ETH) {
> > + src = !i ? (const unsigned long *)ice_ptypes_mac_ofos :
> > + (const unsigned long *)ice_ptypes_mac_il;
> > + bitmap_and(params->ptypes, params->ptypes, src,
> > + ICE_FLOW_PTYPE_MAX);
> > + }
> > +
> > + if (i && hdrs & ICE_FLOW_SEG_HDR_VLAN) {
> > + src = (const unsigned long *)ice_ptypes_macvlan_il;
> > + bitmap_and(params->ptypes, params->ptypes, src,
> > + ICE_FLOW_PTYPE_MAX);
> > + }
> > +
> > + if (!i && hdrs & ICE_FLOW_SEG_HDR_ARP) {
> > + bitmap_and(params->ptypes, params->ptypes,
> > + (const unsigned long *)ice_ptypes_arp_of,
> > + ICE_FLOW_PTYPE_MAX);
> > + }
> > +
> > if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
> > src = !i ? (const unsigned long *)ice_ptypes_ipv4_ofos :
> > (const unsigned long *)ice_ptypes_ipv4_il; @@ -
> > 274,6 +409,13 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> > *params)
> > src = (const unsigned long *)ice_ptypes_sctp_il;
> > bitmap_and(params->ptypes, params->ptypes, src,
> > ICE_FLOW_PTYPE_MAX);
> > + }
> > +
> > + if (hdrs & ICE_FLOW_SEG_HDR_ICMP) {
> > + src = !i ? (const unsigned long *)ice_ptypes_icmp_of :
> > + (const unsigned long *)ice_ptypes_icmp_il;
> > + bitmap_and(params->ptypes, params->ptypes, src,
> > + ICE_FLOW_PTYPE_MAX);
> > } else if (hdrs & ICE_FLOW_SEG_HDR_GRE) {
> > if (!i) {
> > src = (const unsigned long *)ice_ptypes_gre_of; @@
> -310,6 +452,15
> > @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params
> > *params,
> > flds = params->prof->segs[seg].fields;
> >
> > switch (fld) {
> > + case ICE_FLOW_FIELD_IDX_ETH_DA:
> > + case ICE_FLOW_FIELD_IDX_ETH_SA:
> > + case ICE_FLOW_FIELD_IDX_S_VLAN:
> > + case ICE_FLOW_FIELD_IDX_C_VLAN:
> > + prot_id = seg == 0 ? ICE_PROT_MAC_OF_OR_S :
> > ICE_PROT_MAC_IL;
> > + break;
> > + case ICE_FLOW_FIELD_IDX_ETH_TYPE:
> > + prot_id = seg == 0 ? ICE_PROT_ETYPE_OL :
> > ICE_PROT_ETYPE_IL;
> > + break;
> > case ICE_FLOW_FIELD_IDX_IPV4_SA:
> > case ICE_FLOW_FIELD_IDX_IPV4_DA:
> > prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S :
> > ICE_PROT_IPV4_IL; @@ -320,6 +471,7 @@ ice_flow_xtract_fld(struct
> > ice_hw *hw, struct ice_flow_prof_params *params,
> > break;
> > case ICE_FLOW_FIELD_IDX_TCP_SRC_PORT:
> > case ICE_FLOW_FIELD_IDX_TCP_DST_PORT:
> > + case ICE_FLOW_FIELD_IDX_TCP_FLAGS:
> > prot_id = ICE_PROT_TCP_IL;
> > break;
> > case ICE_FLOW_FIELD_IDX_UDP_SRC_PORT:
> > @@ -330,6 +482,20 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct
> > ice_flow_prof_params *params,
> > case ICE_FLOW_FIELD_IDX_SCTP_DST_PORT:
> > prot_id = ICE_PROT_SCTP_IL;
> > break;
> > + case ICE_FLOW_FIELD_IDX_ARP_SIP:
> > + case ICE_FLOW_FIELD_IDX_ARP_DIP:
> > + case ICE_FLOW_FIELD_IDX_ARP_SHA:
> > + case ICE_FLOW_FIELD_IDX_ARP_DHA:
> > + case ICE_FLOW_FIELD_IDX_ARP_OP:
> > + prot_id = ICE_PROT_ARP_OF;
> > + break;
> > + case ICE_FLOW_FIELD_IDX_ICMP_TYPE:
> > + case ICE_FLOW_FIELD_IDX_ICMP_CODE:
> > + /* ICMP type and code share the same extraction seq. entry */
> > + prot_id = (params->prof->segs[seg].hdrs &
> > + ICE_FLOW_SEG_HDR_IPV4) ?
> > + ICE_PROT_ICMP_IL : ICE_PROT_ICMPV6_IL;
>
> The above 3 lines are not wrapped properly, and since we can have lines up
> to 100 chars now, this can fit on 2 lines.
I like the 100 chars limitation
>
> > + break;
> > case ICE_FLOW_FIELD_IDX_GRE_KEYID:
> > prot_id = ICE_PROT_GRE_OF;
> > break;
> > @@ -1093,6 +1259,9 @@ ice_flow_add_fld_raw(struct ice_flow_seg_info
> > *seg,
> > u16 off, u8 len,
> > seg->raws_cnt++;
> > }
> >
> > +#define ICE_FLOW_RSS_SEG_HDR_L2_MASKS \
> (ICE_FLOW_SEG_HDR_ETH |
> > +ICE_FLOW_SEG_HDR_VLAN)
> > +
> > #define ICE_FLOW_RSS_SEG_HDR_L3_MASKS \
> > (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6)
> >
> > @@ -1100,7 +1269,8 @@ ice_flow_add_fld_raw(struct ice_flow_seg_info
> > *seg,
> > u16 off, u8 len,
> > (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP |
> > ICE_FLOW_SEG_HDR_SCTP)
> >
> > #define ICE_FLOW_RSS_SEG_HDR_VAL_MASKS \
> > - (ICE_FLOW_RSS_SEG_HDR_L3_MASKS | \
> > + (ICE_FLOW_RSS_SEG_HDR_L2_MASKS | \
> > + ICE_FLOW_RSS_SEG_HDR_L3_MASKS | \
> > ICE_FLOW_RSS_SEG_HDR_L4_MASKS)
> >
> > /**
> > diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h
> > b/drivers/net/ethernet/intel/ice/ice_flow.h
> > index 3913da2116d2..234f8f5c99cf 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> > +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> > @@ -38,8 +38,12 @@
> > */
> > enum ice_flow_seg_hdr {
> > ICE_FLOW_SEG_HDR_NONE = 0x00000000,
> > + ICE_FLOW_SEG_HDR_ETH = 0x00000001,
> > + ICE_FLOW_SEG_HDR_VLAN = 0x00000002,
> > ICE_FLOW_SEG_HDR_IPV4 = 0x00000004,
> > ICE_FLOW_SEG_HDR_IPV6 = 0x00000008,
> > + ICE_FLOW_SEG_HDR_ARP = 0x00000010,
> > + ICE_FLOW_SEG_HDR_ICMP = 0x00000020,
> > ICE_FLOW_SEG_HDR_TCP = 0x00000040,
> > ICE_FLOW_SEG_HDR_UDP = 0x00000080,
> > ICE_FLOW_SEG_HDR_SCTP = 0x00000100,
> > @@ -47,6 +51,12 @@ enum ice_flow_seg_hdr { };
> >
> > enum ice_flow_field {
> > + /* L2 */
> > + ICE_FLOW_FIELD_IDX_ETH_DA,
> > + ICE_FLOW_FIELD_IDX_ETH_SA,
> > + ICE_FLOW_FIELD_IDX_S_VLAN,
> > + ICE_FLOW_FIELD_IDX_C_VLAN,
> > + ICE_FLOW_FIELD_IDX_ETH_TYPE,
> > /* L3 */
> > ICE_FLOW_FIELD_IDX_IPV4_SA,
> > ICE_FLOW_FIELD_IDX_IPV4_DA,
> > @@ -59,6 +69,16 @@ enum ice_flow_field {
> > ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
> > ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT,
> > ICE_FLOW_FIELD_IDX_SCTP_DST_PORT,
> > + ICE_FLOW_FIELD_IDX_TCP_FLAGS,
> > + /* ARP */
> > + ICE_FLOW_FIELD_IDX_ARP_SIP,
> > + ICE_FLOW_FIELD_IDX_ARP_DIP,
> > + ICE_FLOW_FIELD_IDX_ARP_SHA,
> > + ICE_FLOW_FIELD_IDX_ARP_DHA,
> > + ICE_FLOW_FIELD_IDX_ARP_OP,
> > + /* ICMP */
> > + ICE_FLOW_FIELD_IDX_ICMP_TYPE,
> > + ICE_FLOW_FIELD_IDX_ICMP_CODE,
> > /* GRE */
> > ICE_FLOW_FIELD_IDX_GRE_KEYID,
> > /* The total number of enums must not exceed 64 */ diff --git
> > a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> > b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> > index 7f4c1ec1eff2..fac5f15a692c 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> > +++ b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> > @@ -13,6 +13,9 @@
> > enum ice_prot_id {
> > ICE_PROT_ID_INVAL = 0,
> > ICE_PROT_MAC_OF_OR_S = 1,
> > + ICE_PROT_MAC_IL = 4,
> > + ICE_PROT_ETYPE_OL = 9,
> > + ICE_PROT_ETYPE_IL = 10,
> > ICE_PROT_IPV4_OF_OR_S = 32,
> > ICE_PROT_IPV4_IL = 33,
> > ICE_PROT_IPV6_OF_OR_S = 40,
> > @@ -22,6 +25,9 @@ enum ice_prot_id {
> > ICE_PROT_UDP_IL_OR_S = 53,
> > ICE_PROT_GRE_OF = 64,
> > ICE_PROT_SCTP_IL = 96,
> > + ICE_PROT_ICMP_IL = 98,
> > + ICE_PROT_ICMPV6_IL = 100,
> > + ICE_PROT_ARP_OF = 118,
> > ICE_PROT_META_ID = 255, /* when offset == metadata */
> > ICE_PROT_INVALID = 255 /* when offset == ICE_FV_OFFSET_INVAL
> > */
> > };
> > --
> > 2.13.6
> >
> > _______________________________________________
> > Intel-wired-lan mailing list
> > Intel-wired-lan at osuosl.org
> > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 03/14] ice: Support non word aligned input set field
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 01/14] ice: Enable flexible descriptor RXDID querying and configuration Qi Zhang
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 02/14] ice: Add more basic protocol support for flow filter Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-03 4:55 ` Kirsher, Jeffrey T
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 04/14] ice: Add more advanced protocol support in flow filter Qi Zhang
` (11 subsequent siblings)
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
To support FDIR / RSS input set with protocol field like DSCP,
TTL, PROT, etc. which is not word aligned, we need to enable field
vector masking.
Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 422 +++++++++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_flex_pipe.h | 2 +-
drivers/net/ethernet/intel/ice/ice_flex_type.h | 17 +
drivers/net/ethernet/intel/ice/ice_flow.c | 140 ++++++--
drivers/net/ethernet/intel/ice/ice_flow.h | 7 +
drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 16 +
6 files changed, 570 insertions(+), 34 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
index 4420fc02f7e7..e2b32f67e061 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
@@ -2408,18 +2408,82 @@ ice_vsig_add_mv_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 vsig)
}
/**
- * ice_find_prof_id - find profile ID for a given field vector
+ * ice_prof_has_mask_idx - determine if profile index masking is identical
+ * @hw: pointer to the hardware structure
+ * @blk: HW block
+ * @prof: profile to check
+ * @idx: profile index to check
+ * @mask: mask to match
+ */
+static bool
+ice_prof_has_mask_idx(struct ice_hw *hw, enum ice_block blk, u8 prof, u16 idx,
+ u16 mask)
+{
+ bool expect_no_mask = false;
+ bool found = false;
+ bool match = false;
+ u16 i;
+
+ /* If mask is 0x0000 or 0xffff, then there is no masking */
+ if (mask == 0 || mask == 0xffff)
+ expect_no_mask = true;
+
+ /* Scan the enabled masks on this profile, for the specified idx */
+ for (i = hw->blk[blk].masks.first; i < hw->blk[blk].masks.first +
+ hw->blk[blk].masks.count; i++)
+ if (hw->blk[blk].es.mask_ena[prof] & BIT(i))
+ if (hw->blk[blk].masks.masks[i].in_use &&
+ hw->blk[blk].masks.masks[i].idx == idx) {
+ found = true;
+ if (hw->blk[blk].masks.masks[i].mask == mask)
+ match = true;
+ break;
+ }
+
+ if (expect_no_mask) {
+ if (found)
+ return false;
+ } else {
+ if (!match)
+ return false;
+ }
+
+ return true;
+}
+
+/**
+ * ice_prof_has_mask - determine if profile masking is identical
+ * @hw: pointer to the hardware structure
+ * @blk: HW block
+ * @prof: profile to check
+ * @masks: masks to match
+ */
+static bool
+ice_prof_has_mask(struct ice_hw *hw, enum ice_block blk, u8 prof, u16 *masks)
+{
+ u16 i;
+
+ /* es->mask_ena[prof] will have the mask */
+ for (i = 0; i < hw->blk[blk].es.fvw; i++)
+ if (!ice_prof_has_mask_idx(hw, blk, prof, i, masks[i]))
+ return false;
+
+ return true;
+}
+
+/**
+ * ice_find_prof_id_with_mask - find profile ID for a given field vector
* @hw: pointer to the hardware structure
* @blk: HW block
* @fv: field vector to search for
+ * @masks: masks for fv
* @prof_id: receives the profile ID
*/
static enum ice_status
-ice_find_prof_id(struct ice_hw *hw, enum ice_block blk,
- struct ice_fv_word *fv, u8 *prof_id)
+ice_find_prof_id_with_mask(struct ice_hw *hw, enum ice_block blk,
+ struct ice_fv_word *fv, u16 *masks, u8 *prof_id)
{
struct ice_es *es = &hw->blk[blk].es;
- u16 off;
u8 i;
/* For FD, we don't want to re-use a existed profile with the same
@@ -2429,11 +2493,15 @@ ice_find_prof_id(struct ice_hw *hw, enum ice_block blk,
return ICE_ERR_DOES_NOT_EXIST;
for (i = 0; i < (u8)es->count; i++) {
- off = i * es->fvw;
+ u16 off = i * es->fvw;
if (memcmp(&es->t[off], fv, es->fvw * sizeof(*fv)))
continue;
+ /* check if masks settings are the same for this profile */
+ if (masks && !ice_prof_has_mask(hw, blk, i, masks))
+ continue;
+
*prof_id = i;
return 0;
}
@@ -2584,6 +2652,333 @@ ice_prof_inc_ref(struct ice_hw *hw, enum ice_block blk, u8 prof_id)
}
/**
+ * ice_write_prof_mask_reg - write profile mask register
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ * @mask_idx: mask index
+ * @idx: index of the FV which will use the mask
+ * @mask: the 16-bit mask
+ */
+static void
+ice_write_prof_mask_reg(struct ice_hw *hw, enum ice_block blk, u16 mask_idx,
+ u16 idx, u16 mask)
+{
+ u32 offset;
+ u32 val;
+
+ switch (blk) {
+ case ICE_BLK_RSS:
+ offset = GLQF_HMASK(mask_idx);
+ val = (idx << GLQF_HMASK_MSK_INDEX_S) &
+ GLQF_HMASK_MSK_INDEX_M;
+ val |= (mask << GLQF_HMASK_MASK_S) & GLQF_HMASK_MASK_M;
+ break;
+ case ICE_BLK_FD:
+ offset = GLQF_FDMASK(mask_idx);
+ val = (idx << GLQF_FDMASK_MSK_INDEX_S) &
+ GLQF_FDMASK_MSK_INDEX_M;
+ val |= (mask << GLQF_FDMASK_MASK_S) &
+ GLQF_FDMASK_MASK_M;
+ break;
+ default:
+ ice_debug(hw, ICE_DBG_PKG, "No profile masks for block %d\n",
+ blk);
+ return;
+ }
+
+ wr32(hw, offset, val);
+ ice_debug(hw, ICE_DBG_PKG, "write mask, blk %d (%d): %x = %x\n",
+ blk, idx, offset, val);
+}
+
+/**
+ * ice_write_prof_mask_enable_res - write profile mask enable register
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ * @prof_id: profile ID
+ * @enable_mask: enable mask
+ */
+static void
+ice_write_prof_mask_enable_res(struct ice_hw *hw, enum ice_block blk,
+ u16 prof_id, u32 enable_mask)
+{
+ u32 offset;
+
+ switch (blk) {
+ case ICE_BLK_RSS:
+ offset = GLQF_HMASK_SEL(prof_id);
+ break;
+ case ICE_BLK_FD:
+ offset = GLQF_FDMASK_SEL(prof_id);
+ break;
+ default:
+ ice_debug(hw, ICE_DBG_PKG, "No profile masks for block %d\n",
+ blk);
+ return;
+ }
+
+ wr32(hw, offset, enable_mask);
+ ice_debug(hw, ICE_DBG_PKG, "write mask enable, blk %d (%d): %x = %x\n",
+ blk, prof_id, offset, enable_mask);
+}
+
+/**
+ * ice_init_prof_masks - initial prof masks
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ */
+static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
+{
+ u16 per_pf;
+ u16 i;
+
+ mutex_init(&hw->blk[blk].masks.lock);
+
+ per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
+
+ hw->blk[blk].masks.count = per_pf;
+ hw->blk[blk].masks.first = hw->pf_id * per_pf;
+
+ memset(hw->blk[blk].masks.masks, 0, sizeof(hw->blk[blk].masks.masks));
+
+ for (i = hw->blk[blk].masks.first;
+ i < hw->blk[blk].masks.first + hw->blk[blk].masks.count; i++)
+ ice_write_prof_mask_reg(hw, blk, i, 0, 0);
+}
+
+/**
+ * ice_init_all_prof_masks - initial all prof masks
+ * @hw: pointer to the HW struct
+ */
+static void ice_init_all_prof_masks(struct ice_hw *hw)
+{
+ ice_init_prof_masks(hw, ICE_BLK_RSS);
+ ice_init_prof_masks(hw, ICE_BLK_FD);
+}
+
+/**
+ * ice_alloc_prof_mask - allocate profile mask
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ * @idx: index of FV which will use the mask
+ * @mask: the 16-bit mask
+ * @mask_idx: variable to receive the mask index
+ */
+static enum ice_status
+ice_alloc_prof_mask(struct ice_hw *hw, enum ice_block blk, u16 idx, u16 mask,
+ u16 *mask_idx)
+{
+ bool found_unused = false, found_copy = false;
+ enum ice_status status = ICE_ERR_MAX_LIMIT;
+ u16 unused_idx = 0, copy_idx = 0;
+ u16 i;
+
+ if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
+ return ICE_ERR_PARAM;
+
+ mutex_lock(&hw->blk[blk].masks.lock);
+
+ for (i = hw->blk[blk].masks.first;
+ i < hw->blk[blk].masks.first + hw->blk[blk].masks.count; i++)
+ if (hw->blk[blk].masks.masks[i].in_use) {
+ /* if mask is in use and it exactly duplicates the
+ * desired mask and index, then in can be reused
+ */
+ if (hw->blk[blk].masks.masks[i].mask == mask &&
+ hw->blk[blk].masks.masks[i].idx == idx) {
+ found_copy = true;
+ copy_idx = i;
+ break;
+ }
+ } else {
+ /* save off unused index, but keep searching in case
+ * there is an exact match later on
+ */
+ if (!found_unused) {
+ found_unused = true;
+ unused_idx = i;
+ }
+ }
+
+ if (found_copy)
+ i = copy_idx;
+ else if (found_unused)
+ i = unused_idx;
+ else
+ goto err_ice_alloc_prof_mask;
+
+ /* update mask for a new entry */
+ if (found_unused) {
+ hw->blk[blk].masks.masks[i].in_use = true;
+ hw->blk[blk].masks.masks[i].mask = mask;
+ hw->blk[blk].masks.masks[i].idx = idx;
+ hw->blk[blk].masks.masks[i].ref = 0;
+ ice_write_prof_mask_reg(hw, blk, i, idx, mask);
+ }
+
+ hw->blk[blk].masks.masks[i].ref++;
+ *mask_idx = i;
+ status = 0;
+
+err_ice_alloc_prof_mask:
+ mutex_unlock(&hw->blk[blk].masks.lock);
+
+ return status;
+}
+
+/**
+ * ice_free_prof_mask - free profile mask
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ * @mask_idx: index of mask
+ */
+static enum ice_status
+ice_free_prof_mask(struct ice_hw *hw, enum ice_block blk, u16 mask_idx)
+{
+ if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
+ return ICE_ERR_PARAM;
+
+ if (!(mask_idx >= hw->blk[blk].masks.first &&
+ mask_idx < hw->blk[blk].masks.first + hw->blk[blk].masks.count))
+ return ICE_ERR_DOES_NOT_EXIST;
+
+ mutex_lock(&hw->blk[blk].masks.lock);
+
+ if (!hw->blk[blk].masks.masks[mask_idx].in_use)
+ goto exit_ice_free_prof_mask;
+
+ if (hw->blk[blk].masks.masks[mask_idx].ref > 1) {
+ hw->blk[blk].masks.masks[mask_idx].ref--;
+ goto exit_ice_free_prof_mask;
+ }
+
+ /* remove mask */
+ hw->blk[blk].masks.masks[mask_idx].in_use = false;
+ hw->blk[blk].masks.masks[mask_idx].mask = 0;
+ hw->blk[blk].masks.masks[mask_idx].idx = 0;
+
+ /* update mask as unused entry */
+ ice_debug(hw, ICE_DBG_PKG, "Free mask, blk %d, mask %d\n", blk,
+ mask_idx);
+ ice_write_prof_mask_reg(hw, blk, mask_idx, 0, 0);
+
+exit_ice_free_prof_mask:
+ mutex_unlock(&hw->blk[blk].masks.lock);
+
+ return 0;
+}
+
+/**
+ * ice_free_prof_masks - free all profile masks for a profile
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ * @prof_id: profile ID
+ */
+static enum ice_status
+ice_free_prof_masks(struct ice_hw *hw, enum ice_block blk, u16 prof_id)
+{
+ u32 mask_bm;
+ u16 i;
+
+ if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
+ return ICE_ERR_PARAM;
+
+ mask_bm = hw->blk[blk].es.mask_ena[prof_id];
+ for (i = 0; i < BITS_PER_BYTE * sizeof(mask_bm); i++)
+ if (mask_bm & BIT(i))
+ ice_free_prof_mask(hw, blk, i);
+
+ return 0;
+}
+
+/**
+ * ice_shutdown_prof_masks - releases lock for masking
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ *
+ * This should be called before unloading the driver
+ */
+static void ice_shutdown_prof_masks(struct ice_hw *hw, enum ice_block blk)
+{
+ u16 i;
+
+ mutex_lock(&hw->blk[blk].masks.lock);
+
+ for (i = hw->blk[blk].masks.first;
+ i < hw->blk[blk].masks.first + hw->blk[blk].masks.count; i++) {
+ ice_write_prof_mask_reg(hw, blk, i, 0, 0);
+
+ hw->blk[blk].masks.masks[i].in_use = false;
+ hw->blk[blk].masks.masks[i].idx = 0;
+ hw->blk[blk].masks.masks[i].mask = 0;
+ }
+
+ mutex_unlock(&hw->blk[blk].masks.lock);
+ mutex_destroy(&hw->blk[blk].masks.lock);
+}
+
+/**
+ * ice_shutdown_all_prof_masks - releases all locks for masking
+ * @hw: pointer to the HW struct
+ *
+ * This should be called before unloading the driver
+ */
+static void ice_shutdown_all_prof_masks(struct ice_hw *hw)
+{
+ ice_shutdown_prof_masks(hw, ICE_BLK_RSS);
+ ice_shutdown_prof_masks(hw, ICE_BLK_FD);
+}
+
+/**
+ * ice_update_prof_masking - set registers according to masking
+ * @hw: pointer to the HW struct
+ * @blk: hardware block
+ * @prof_id: profile ID
+ * @masks: masks
+ */
+static enum ice_status
+ice_update_prof_masking(struct ice_hw *hw, enum ice_block blk, u16 prof_id,
+ u16 *masks)
+{
+ bool err = false;
+ u32 ena_mask = 0;
+ u16 idx;
+ u16 i;
+
+ /* Only support FD and RSS masking, otherwise nothing to be done */
+ if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
+ return 0;
+
+ for (i = 0; i < hw->blk[blk].es.fvw; i++)
+ if (masks[i] && masks[i] != 0xFFFF) {
+ if (!ice_alloc_prof_mask(hw, blk, i, masks[i], &idx)) {
+ ena_mask |= BIT(idx);
+ } else {
+ /* not enough bitmaps */
+ err = true;
+ break;
+ }
+ }
+
+ if (err) {
+ /* free any bitmaps we have allocated */
+ for (i = 0; i < BITS_PER_BYTE * sizeof(ena_mask); i++)
+ if (ena_mask & BIT(i))
+ ice_free_prof_mask(hw, blk, i);
+
+ return ICE_ERR_OUT_OF_RANGE;
+ }
+
+ /* enable the masks for this profile */
+ ice_write_prof_mask_enable_res(hw, blk, prof_id, ena_mask);
+
+ /* store enabled masks with profile so that they can be freed later */
+ hw->blk[blk].es.mask_ena[prof_id] = ena_mask;
+
+ return 0;
+}
+
+/**
* ice_write_es - write an extraction sequence to hardware
* @hw: pointer to the HW struct
* @blk: the block in which to write the extraction sequence
@@ -2622,6 +3017,7 @@ ice_prof_dec_ref(struct ice_hw *hw, enum ice_block blk, u8 prof_id)
if (hw->blk[blk].es.ref_count[prof_id] > 0) {
if (!--hw->blk[blk].es.ref_count[prof_id]) {
ice_write_es(hw, blk, prof_id, NULL);
+ ice_free_prof_masks(hw, blk, prof_id);
return ice_free_prof_id(hw, blk, prof_id);
}
}
@@ -2982,6 +3378,7 @@ void ice_free_hw_tbls(struct ice_hw *hw)
devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.t);
devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.ref_count);
devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.written);
+ devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.mask_ena);
}
list_for_each_entry_safe(r, rt, &hw->rss_list_head, l_entry) {
@@ -2989,6 +3386,7 @@ void ice_free_hw_tbls(struct ice_hw *hw)
devm_kfree(ice_hw_to_dev(hw), r);
}
mutex_destroy(&hw->rss_locks);
+ ice_shutdown_all_prof_masks(hw);
memset(hw->blk, 0, sizeof(hw->blk));
}
@@ -3042,6 +3440,7 @@ void ice_clear_hw_tbls(struct ice_hw *hw)
memset(es->t, 0, es->count * sizeof(*es->t));
memset(es->ref_count, 0, es->count * sizeof(*es->ref_count));
memset(es->written, 0, es->count * sizeof(*es->written));
+ memset(es->mask_ena, 0, es->count * sizeof(*es->mask_ena));
}
}
@@ -3055,6 +3454,7 @@ enum ice_status ice_init_hw_tbls(struct ice_hw *hw)
mutex_init(&hw->rss_locks);
INIT_LIST_HEAD(&hw->rss_list_head);
+ ice_init_all_prof_masks(hw);
for (i = 0; i < ICE_BLK_COUNT; i++) {
struct ice_prof_redir *prof_redir = &hw->blk[i].prof_redir;
struct ice_prof_tcam *prof = &hw->blk[i].prof;
@@ -3153,6 +3553,8 @@ enum ice_status ice_init_hw_tbls(struct ice_hw *hw)
es->written = devm_kcalloc(ice_hw_to_dev(hw), es->count,
sizeof(*es->written), GFP_KERNEL);
+ es->mask_ena = devm_kcalloc(ice_hw_to_dev(hw), es->count,
+ sizeof(*es->mask_ena), GFP_KERNEL);
if (!es->ref_count)
goto err;
}
@@ -3762,15 +4164,16 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)
* @id: profile tracking ID
* @ptypes: array of bitmaps indicating ptypes (ICE_FLOW_PTYPE_MAX bits)
* @es: extraction sequence (length of array is determined by the block)
+ * @masks: mask for extraction sequence
*
- * This function registers a profile, which matches a set of PTGs with a
+ * This function registers a profile, which matches a set of PTYPES with a
* particular extraction sequence. While the hardware profile is allocated
* it will not be written until the first call to ice_add_flow that specifies
* the ID value used here.
*/
enum ice_status
ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
- struct ice_fv_word *es)
+ struct ice_fv_word *es, u16 *masks)
{
u32 bytes = DIV_ROUND_UP(ICE_FLOW_PTYPE_MAX, BITS_PER_BYTE);
DECLARE_BITMAP(ptgs_used, ICE_XLT1_CNT);
@@ -3784,7 +4187,7 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
mutex_lock(&hw->blk[blk].es.prof_map_lock);
/* search for existing profile */
- status = ice_find_prof_id(hw, blk, es, &prof_id);
+ status = ice_find_prof_id_with_mask(hw, blk, es, masks, &prof_id);
if (status) {
/* allocate profile ID */
status = ice_alloc_prof_id(hw, blk, &prof_id);
@@ -3802,6 +4205,9 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
if (status)
goto err_ice_add_prof;
}
+ status = ice_update_prof_masking(hw, blk, prof_id, masks);
+ if (status)
+ goto err_ice_add_prof;
/* and write new es */
ice_write_es(hw, blk, prof_id, es);
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.h b/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
index 568ea519af51..ea3f3ef5994a 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
@@ -28,7 +28,7 @@ bool ice_tunnel_port_in_use(struct ice_hw *hw, u16 port, u16 *index);
enum ice_status
ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
- struct ice_fv_word *es);
+ struct ice_fv_word *es, u16 *masks);
enum ice_status
ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
enum ice_status
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_type.h b/drivers/net/ethernet/intel/ice/ice_flex_type.h
index a6f391eac8ff..e08526f85d46 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_flex_type.h
@@ -335,6 +335,7 @@ struct ice_es {
u16 count;
u16 fvw;
u16 *ref_count;
+ u32 *mask_ena;
struct list_head prof_map;
struct ice_fv_word *t;
struct mutex prof_map_lock; /* protect access to profiles list */
@@ -478,6 +479,21 @@ struct ice_prof_redir {
u16 count;
};
+struct ice_mask {
+ u16 mask; /* 16-bit mask */
+ u16 idx; /* index */
+ u16 ref; /* reference count */
+ u8 in_use; /* non-zero if used */
+};
+
+struct ice_masks {
+ struct mutex lock; /* lock to protect this structure */
+ u16 first; /* first mask owned by the PF */
+ u16 count; /* number of masks owned by the PF */
+#define ICE_PROF_MASK_COUNT 32
+ struct ice_mask masks[ICE_PROF_MASK_COUNT];
+};
+
/* Tables per block */
struct ice_blk_info {
struct ice_xlt1 xlt1;
@@ -485,6 +501,7 @@ struct ice_blk_info {
struct ice_prof_tcam prof;
struct ice_prof_redir prof_redir;
struct ice_es es;
+ struct ice_masks masks;
u8 overwrite; /* set to true to allow overwrite of table entries */
u8 is_list_init;
};
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index 12a579702d40..0afe3c55eff9 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -9,12 +9,21 @@ struct ice_flow_field_info {
enum ice_flow_seg_hdr hdr;
s16 off; /* Offset from start of a protocol header, in bits */
u16 size; /* Size of fields in bits */
+ u16 mask; /* 16-bit mask for field */
};
#define ICE_FLOW_FLD_INFO(_hdr, _offset_bytes, _size_bytes) { \
.hdr = _hdr, \
.off = (_offset_bytes) * BITS_PER_BYTE, \
.size = (_size_bytes) * BITS_PER_BYTE, \
+ .mask = 0, \
+}
+
+#define ICE_FLOW_FLD_INFO_MSK(_hdr, _offset_bytes, _size_bytes, _mask) { \
+ .hdr = _hdr, \
+ .off = (_offset_bytes) * BITS_PER_BYTE, \
+ .size = (_size_bytes) * BITS_PER_BYTE, \
+ .mask = _mask, \
}
/* Table containing properties of supported protocol header fields */
@@ -32,6 +41,18 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
/* ICE_FLOW_FIELD_IDX_ETH_TYPE */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, sizeof(__be16)),
/* IPv4 / IPv6 */
+ /* ICE_FLOW_FIELD_IDX_IPV4_DSCP */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_IPV4, 0, 1, 0x00fc),
+ /* ICE_FLOW_FIELD_IDX_IPV6_DSCP */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_IPV6, 0, 1, 0x0ff0),
+ /* ICE_FLOW_FIELD_IDX_IPV4_TTL */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 8, 1, 0xff00),
+ /* ICE_FLOW_FIELD_IDX_IPV4_PROT */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 8, 1, 0x00ff),
+ /* ICE_FLOW_FIELD_IDX_IPV6_TTL */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 6, 1, 0x00ff),
+ /* ICE_FLOW_FIELD_IDX_IPV6_PROT */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 6, 1, 0xff00),
/* ICE_FLOW_FIELD_IDX_IPV4_SA */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_IPV4, 12, sizeof(struct in_addr)),
/* ICE_FLOW_FIELD_IDX_IPV4_DA */
@@ -260,6 +281,8 @@ struct ice_flow_prof_params {
* This will give us the direction flags.
*/
struct ice_fv_word es[ICE_MAX_FV_WORDS];
+
+ u16 mask[ICE_MAX_FV_WORDS];
DECLARE_BITMAP(ptypes, ICE_FLOW_PTYPE_MAX);
};
@@ -434,6 +457,7 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
* @params: information about the flow to be processed
* @seg: packet segment index of the field to be extracted
* @fld: ID of field to be extracted
+ * @match: bitfield of all fields
*
* This function determines the protocol ID, offset, and size of the given
* field. It then allocates one or more extraction sequence entries for the
@@ -441,12 +465,15 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
*/
static enum ice_status
ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
- u8 seg, enum ice_flow_field fld)
+ u8 seg, enum ice_flow_field fld, u64 match)
{
+ enum ice_flow_field sib = ICE_FLOW_FIELD_IDX_MAX;
enum ice_prot_id prot_id = ICE_PROT_ID_INVAL;
u8 fv_words = hw->blk[params->blk].es.fvw;
struct ice_flow_fld_info *flds;
u16 cnt, ese_bits, i;
+ u16 sib_mask = 0;
+ u16 mask;
u16 off;
flds = params->prof->segs[seg].fields;
@@ -461,6 +488,50 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
case ICE_FLOW_FIELD_IDX_ETH_TYPE:
prot_id = seg == 0 ? ICE_PROT_ETYPE_OL : ICE_PROT_ETYPE_IL;
break;
+ case ICE_FLOW_FIELD_IDX_IPV4_DSCP:
+ prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S : ICE_PROT_IPV4_IL;
+ break;
+ case ICE_FLOW_FIELD_IDX_IPV6_DSCP:
+ prot_id = seg == 0 ? ICE_PROT_IPV6_OF_OR_S : ICE_PROT_IPV6_IL;
+ break;
+ case ICE_FLOW_FIELD_IDX_IPV4_TTL:
+ case ICE_FLOW_FIELD_IDX_IPV4_PROT:
+ prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S : ICE_PROT_IPV4_IL;
+
+ /* TTL and PROT share the same extraction seq. entry.
+ * Each is considered a sibling to the other in terms of sharing
+ * the same extraction sequence entry.
+ */
+ if (fld == ICE_FLOW_FIELD_IDX_IPV4_TTL)
+ sib = ICE_FLOW_FIELD_IDX_IPV4_PROT;
+ else if (fld == ICE_FLOW_FIELD_IDX_IPV4_PROT)
+ sib = ICE_FLOW_FIELD_IDX_IPV4_TTL;
+
+ /* If the sibling field is also included, that field's
+ * mask needs to be included.
+ */
+ if (match & BIT(sib))
+ sib_mask = ice_flds_info[sib].mask;
+ break;
+ case ICE_FLOW_FIELD_IDX_IPV6_TTL:
+ case ICE_FLOW_FIELD_IDX_IPV6_PROT:
+ prot_id = seg == 0 ? ICE_PROT_IPV6_OF_OR_S : ICE_PROT_IPV6_IL;
+
+ /* TTL and PROT share the same extraction seq. entry.
+ * Each is considered a sibling to the other in terms of sharing
+ * the same extraction sequence entry.
+ */
+ if (fld == ICE_FLOW_FIELD_IDX_IPV6_TTL)
+ sib = ICE_FLOW_FIELD_IDX_IPV6_PROT;
+ else if (fld == ICE_FLOW_FIELD_IDX_IPV6_PROT)
+ sib = ICE_FLOW_FIELD_IDX_IPV6_TTL;
+
+ /* If the sibling field is also included, that field's
+ * mask needs to be included.
+ */
+ if (match & BIT(sib))
+ sib_mask = ice_flds_info[sib].mask;
+ break;
case ICE_FLOW_FIELD_IDX_IPV4_SA:
case ICE_FLOW_FIELD_IDX_IPV4_DA:
prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S : ICE_PROT_IPV4_IL;
@@ -495,6 +566,9 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
prot_id = (params->prof->segs[seg].hdrs &
ICE_FLOW_SEG_HDR_IPV4) ?
ICE_PROT_ICMP_IL : ICE_PROT_ICMPV6_IL;
+ sib = fld == ICE_FLOW_FIELD_IDX_ICMP_TYPE ?
+ ICE_FLOW_FIELD_IDX_ICMP_CODE :
+ ICE_FLOW_FIELD_IDX_ICMP_TYPE;
break;
case ICE_FLOW_FIELD_IDX_GRE_KEYID:
prot_id = ICE_PROT_GRE_OF;
@@ -513,6 +587,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
ICE_FLOW_FV_EXTRACT_SZ;
flds[fld].xtrct.disp = (u8)(ice_flds_info[fld].off % ese_bits);
flds[fld].xtrct.idx = params->es_cnt;
+ flds[fld].xtrct.mask = ice_flds_info[fld].mask;
/* Adjust the next field-entry index after accommodating the number of
* entries this field consumes
@@ -522,24 +597,34 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
/* Fill in the extraction sequence entries needed for this field */
off = flds[fld].xtrct.off;
+ mask = flds[fld].xtrct.mask;
for (i = 0; i < cnt; i++) {
- u8 idx;
-
- /* Make sure the number of extraction sequence required
- * does not exceed the block's capability
+ /* Only consume an extraction sequence entry if there is no
+ * sibling field associated with this field or the sibling entry
+ * already extracts the word shared with this field.
*/
- if (params->es_cnt >= fv_words)
- return ICE_ERR_MAX_LIMIT;
+ if (sib == ICE_FLOW_FIELD_IDX_MAX ||
+ flds[sib].xtrct.prot_id == ICE_PROT_ID_INVAL ||
+ flds[sib].xtrct.off != off) {
+ u8 idx;
- /* some blocks require a reversed field vector layout */
- if (hw->blk[params->blk].es.reverse)
- idx = fv_words - params->es_cnt - 1;
- else
- idx = params->es_cnt;
+ /* Make sure the number of extraction sequence required
+ * does not exceed the block's capability
+ */
+ if (params->es_cnt >= fv_words)
+ return ICE_ERR_MAX_LIMIT;
- params->es[idx].prot_id = prot_id;
- params->es[idx].off = off;
- params->es_cnt++;
+ /* some blocks require a reversed field vector layout */
+ if (hw->blk[params->blk].es.reverse)
+ idx = fv_words - params->es_cnt - 1;
+ else
+ idx = params->es_cnt;
+
+ params->es[idx].prot_id = prot_id;
+ params->es[idx].off = off;
+ params->mask[idx] = mask | sib_mask;
+ params->es_cnt++;
+ }
off += ICE_FLOW_FV_EXTRACT_SZ;
}
@@ -634,19 +719,23 @@ static enum ice_status
ice_flow_create_xtrct_seq(struct ice_hw *hw,
struct ice_flow_prof_params *params)
{
- struct ice_flow_prof *prof = params->prof;
enum ice_status status = 0;
u8 i;
- for (i = 0; i < prof->segs_cnt; i++) {
- u8 j;
+ for (i = 0; i < params->prof->segs_cnt; i++) {
+ u64 match = params->prof->segs[i].match;
+ enum ice_flow_field j;
- for_each_set_bit(j, (unsigned long *)&prof->segs[i].match,
- ICE_FLOW_FIELD_IDX_MAX) {
- status = ice_flow_xtract_fld(hw, params, i,
- (enum ice_flow_field)j);
- if (status)
- return status;
+ for (j = 0; j < ICE_FLOW_FIELD_IDX_MAX && match; j++) {
+ const u64 bit = BIT_ULL(j);
+
+ if (match & bit) {
+ status = ice_flow_xtract_fld(hw, params, i, j,
+ match);
+ if (status)
+ return status;
+ match &= ~bit;
+ }
}
/* Process raw matching bytes */
@@ -852,7 +941,8 @@ ice_flow_add_prof_sync(struct ice_hw *hw, enum ice_block blk,
}
/* Add a HW profile for this flow profile */
- status = ice_add_prof(hw, blk, prof_id, (u8 *)params.ptypes, params.es);
+ status = ice_add_prof(hw, blk, prof_id, (u8 *)params.ptypes,
+ params.es, params.mask);
if (status) {
ice_debug(hw, ICE_DBG_FLOW, "Error adding a HW flow profile\n");
goto out;
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 234f8f5c99cf..9eaafd5e50e0 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -58,6 +58,12 @@ enum ice_flow_field {
ICE_FLOW_FIELD_IDX_C_VLAN,
ICE_FLOW_FIELD_IDX_ETH_TYPE,
/* L3 */
+ ICE_FLOW_FIELD_IDX_IPV4_DSCP,
+ ICE_FLOW_FIELD_IDX_IPV6_DSCP,
+ ICE_FLOW_FIELD_IDX_IPV4_TTL,
+ ICE_FLOW_FIELD_IDX_IPV4_PROT,
+ ICE_FLOW_FIELD_IDX_IPV6_TTL,
+ ICE_FLOW_FIELD_IDX_IPV6_PROT,
ICE_FLOW_FIELD_IDX_IPV4_SA,
ICE_FLOW_FIELD_IDX_IPV4_DA,
ICE_FLOW_FIELD_IDX_IPV6_SA,
@@ -158,6 +164,7 @@ struct ice_flow_seg_xtrct {
u16 off; /* Starting offset of the field in header in bytes */
u8 idx; /* Index of FV entry used */
u8 disp; /* Displacement of field in bits fr. FV entry's start */
+ u16 mask; /* Mask for field */
};
enum ice_flow_fld_match_type {
diff --git a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
index bb1cc372ee95..07a9b70c2751 100644
--- a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
+++ b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
@@ -306,8 +306,24 @@
#define GLQF_FD_SIZE_FD_BSIZE_S 16
#define GLQF_FD_SIZE_FD_BSIZE_M ICE_M(0x7FFF, 16)
#define GLQF_FDINSET(_i, _j) (0x00412000 + ((_i) * 4 + (_j) * 512))
+#define GLQF_FDMASK(_i) (0x00410800 + ((_i) * 4))
+#define GLQF_FDMASK_MAX_INDEX 31
+#define GLQF_FDMASK_MSK_INDEX_S 0
+#define GLQF_FDMASK_MSK_INDEX_M ICE_M(0x1F, 0)
+#define GLQF_FDMASK_MASK_S 16
+#define GLQF_FDMASK_MASK_M ICE_M(0xFFFF, 16)
#define GLQF_FDMASK_SEL(_i) (0x00410400 + ((_i) * 4))
#define GLQF_FDSWAP(_i, _j) (0x00413000 + ((_i) * 4 + (_j) * 512))
+#define GLQF_HMASK(_i) (0x0040FC00 + ((_i) * 4))
+#define GLQF_HMASK_MAX_INDEX 31
+#define GLQF_HMASK_MSK_INDEX_S 0
+#define GLQF_HMASK_MSK_INDEX_M ICE_M(0x1F, 0)
+#define GLQF_HMASK_MASK_S 16
+#define GLQF_HMASK_MASK_M ICE_M(0xFFFF, 16)
+#define GLQF_HMASK_SEL(_i) (0x00410000 + ((_i) * 4))
+#define GLQF_HMASK_SEL_MAX_INDEX 127
+#define GLQF_HMASK_SEL_MASK_SEL_S 0
+#define GLQF_HMASK_SEL_MASK_SEL_M
#define PFQF_FD_ENA 0x0043A000
#define PFQF_FD_ENA_FD_ENA_M BIT(0)
#define PFQF_FD_SIZE 0x00460100
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 03/14] ice: Support non word aligned input set field
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 03/14] ice: Support non word aligned input set field Qi Zhang
@ 2020-07-03 4:55 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 4:55 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 03/14] ice: Support non word aligned
> input set field
>
> To support FDIR / RSS input set with protocol field like DSCP, TTL, PROT, etc.
> which is not word aligned, we need to enable field vector masking.
>
> Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 422
> +++++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_flex_pipe.h | 2 +-
> drivers/net/ethernet/intel/ice/ice_flex_type.h | 17 +
> drivers/net/ethernet/intel/ice/ice_flow.c | 140 ++++++--
> drivers/net/ethernet/intel/ice/ice_flow.h | 7 +
> drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 16 +
> 6 files changed, 570 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
> b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
> index 4420fc02f7e7..e2b32f67e061 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
> +++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
> @@ -2408,18 +2408,82 @@ ice_vsig_add_mv_vsi(struct ice_hw *hw, enum
> ice_block blk, u16 vsi, u16 vsig) }
>
> /**
> - * ice_find_prof_id - find profile ID for a given field vector
> + * ice_prof_has_mask_idx - determine if profile index masking is
> +identical
> + * @hw: pointer to the hardware structure
> + * @blk: HW block
> + * @prof: profile to check
> + * @idx: profile index to check
> + * @mask: mask to match
> + */
> +static bool
> +ice_prof_has_mask_idx(struct ice_hw *hw, enum ice_block blk, u8 prof, u16
> idx,
> + u16 mask)
> +{
> + bool expect_no_mask = false;
> + bool found = false;
> + bool match = false;
> + u16 i;
> +
> + /* If mask is 0x0000 or 0xffff, then there is no masking */
> + if (mask == 0 || mask == 0xffff)
> + expect_no_mask = true;
> +
> + /* Scan the enabled masks on this profile, for the specified idx */
> + for (i = hw->blk[blk].masks.first; i < hw->blk[blk].masks.first +
> + hw->blk[blk].masks.count; i++)
> + if (hw->blk[blk].es.mask_ena[prof] & BIT(i))
> + if (hw->blk[blk].masks.masks[i].in_use &&
> + hw->blk[blk].masks.masks[i].idx == idx) {
> + found = true;
> + if (hw->blk[blk].masks.masks[i].mask == mask)
> + match = true;
> + break;
> + }
> +
> + if (expect_no_mask) {
> + if (found)
> + return false;
> + } else {
> + if (!match)
> + return false;
> + }
> +
> + return true;
> +}
> +
> +/**
> + * ice_prof_has_mask - determine if profile masking is identical
> + * @hw: pointer to the hardware structure
> + * @blk: HW block
> + * @prof: profile to check
> + * @masks: masks to match
> + */
> +static bool
> +ice_prof_has_mask(struct ice_hw *hw, enum ice_block blk, u8 prof, u16
> +*masks) {
> + u16 i;
> +
> + /* es->mask_ena[prof] will have the mask */
> + for (i = 0; i < hw->blk[blk].es.fvw; i++)
> + if (!ice_prof_has_mask_idx(hw, blk, prof, i, masks[i]))
> + return false;
> +
> + return true;
> +}
> +
> +/**
> + * ice_find_prof_id_with_mask - find profile ID for a given field
> +vector
> * @hw: pointer to the hardware structure
> * @blk: HW block
> * @fv: field vector to search for
> + * @masks: masks for fv
> * @prof_id: receives the profile ID
> */
> static enum ice_status
> -ice_find_prof_id(struct ice_hw *hw, enum ice_block blk,
> - struct ice_fv_word *fv, u8 *prof_id)
> +ice_find_prof_id_with_mask(struct ice_hw *hw, enum ice_block blk,
> + struct ice_fv_word *fv, u16 *masks, u8 *prof_id)
> {
> struct ice_es *es = &hw->blk[blk].es;
> - u16 off;
> u8 i;
>
> /* For FD, we don't want to re-use a existed profile with the same @@ -
> 2429,11 +2493,15 @@ ice_find_prof_id(struct ice_hw *hw, enum ice_block blk,
> return ICE_ERR_DOES_NOT_EXIST;
>
> for (i = 0; i < (u8)es->count; i++) {
> - off = i * es->fvw;
> + u16 off = i * es->fvw;
>
> if (memcmp(&es->t[off], fv, es->fvw * sizeof(*fv)))
> continue;
>
> + /* check if masks settings are the same for this profile */
> + if (masks && !ice_prof_has_mask(hw, blk, i, masks))
> + continue;
> +
> *prof_id = i;
> return 0;
> }
> @@ -2584,6 +2652,333 @@ ice_prof_inc_ref(struct ice_hw *hw, enum
> ice_block blk, u8 prof_id) }
>
> /**
> + * ice_write_prof_mask_reg - write profile mask register
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + * @mask_idx: mask index
> + * @idx: index of the FV which will use the mask
> + * @mask: the 16-bit mask
> + */
> +static void
> +ice_write_prof_mask_reg(struct ice_hw *hw, enum ice_block blk, u16
> mask_idx,
> + u16 idx, u16 mask)
> +{
> + u32 offset;
> + u32 val;
> +
> + switch (blk) {
> + case ICE_BLK_RSS:
> + offset = GLQF_HMASK(mask_idx);
> + val = (idx << GLQF_HMASK_MSK_INDEX_S) &
> + GLQF_HMASK_MSK_INDEX_M;
Line wrapping issue
> + val |= (mask << GLQF_HMASK_MASK_S) &
> GLQF_HMASK_MASK_M;
> + break;
> + case ICE_BLK_FD:
> + offset = GLQF_FDMASK(mask_idx);
> + val = (idx << GLQF_FDMASK_MSK_INDEX_S) &
> + GLQF_FDMASK_MSK_INDEX_M;
Here as well
> + val |= (mask << GLQF_FDMASK_MASK_S) &
> + GLQF_FDMASK_MASK_M;
> + break;
> + default:
> + ice_debug(hw, ICE_DBG_PKG, "No profile masks for block
> %d\n",
> + blk);
> + return;
> + }
> +
> + wr32(hw, offset, val);
> + ice_debug(hw, ICE_DBG_PKG, "write mask, blk %d (%d): %x = %x\n",
> + blk, idx, offset, val);
> +}
> +
> +/**
> + * ice_write_prof_mask_enable_res - write profile mask enable register
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + * @prof_id: profile ID
> + * @enable_mask: enable mask
> + */
> +static void
> +ice_write_prof_mask_enable_res(struct ice_hw *hw, enum ice_block blk,
> + u16 prof_id, u32 enable_mask) {
> + u32 offset;
> +
> + switch (blk) {
> + case ICE_BLK_RSS:
> + offset = GLQF_HMASK_SEL(prof_id);
> + break;
> + case ICE_BLK_FD:
> + offset = GLQF_FDMASK_SEL(prof_id);
> + break;
> + default:
> + ice_debug(hw, ICE_DBG_PKG, "No profile masks for block
> %d\n",
> + blk);
> + return;
> + }
> +
> + wr32(hw, offset, enable_mask);
> + ice_debug(hw, ICE_DBG_PKG, "write mask enable, blk %d (%d): %x =
> %x\n",
> + blk, prof_id, offset, enable_mask); }
> +
> +/**
> + * ice_init_prof_masks - initial prof masks
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + */
> +static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
> +{
> + u16 per_pf;
> + u16 i;
> +
> + mutex_init(&hw->blk[blk].masks.lock);
> +
> + per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
> +
> + hw->blk[blk].masks.count = per_pf;
> + hw->blk[blk].masks.first = hw->pf_id * per_pf;
> +
> + memset(hw->blk[blk].masks.masks, 0, sizeof(hw-
> >blk[blk].masks.masks));
> +
> + for (i = hw->blk[blk].masks.first;
> + i < hw->blk[blk].masks.first + hw->blk[blk].masks.count; i++)
> + ice_write_prof_mask_reg(hw, blk, i, 0, 0); }
> +
> +/**
> + * ice_init_all_prof_masks - initial all prof masks
> + * @hw: pointer to the HW struct
> + */
> +static void ice_init_all_prof_masks(struct ice_hw *hw) {
> + ice_init_prof_masks(hw, ICE_BLK_RSS);
> + ice_init_prof_masks(hw, ICE_BLK_FD);
> +}
> +
> +/**
> + * ice_alloc_prof_mask - allocate profile mask
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + * @idx: index of FV which will use the mask
> + * @mask: the 16-bit mask
> + * @mask_idx: variable to receive the mask index */ static enum
> +ice_status ice_alloc_prof_mask(struct ice_hw *hw, enum ice_block blk,
> +u16 idx, u16 mask,
> + u16 *mask_idx)
> +{
> + bool found_unused = false, found_copy = false;
> + enum ice_status status = ICE_ERR_MAX_LIMIT;
> + u16 unused_idx = 0, copy_idx = 0;
> + u16 i;
> +
> + if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
> + return ICE_ERR_PARAM;
> +
> + mutex_lock(&hw->blk[blk].masks.lock);
> +
> + for (i = hw->blk[blk].masks.first;
> + i < hw->blk[blk].masks.first + hw->blk[blk].masks.count; i++)
> + if (hw->blk[blk].masks.masks[i].in_use) {
> + /* if mask is in use and it exactly duplicates the
> + * desired mask and index, then in can be reused
> + */
> + if (hw->blk[blk].masks.masks[i].mask == mask &&
> + hw->blk[blk].masks.masks[i].idx == idx) {
> + found_copy = true;
> + copy_idx = i;
> + break;
> + }
> + } else {
> + /* save off unused index, but keep searching in case
> + * there is an exact match later on
> + */
> + if (!found_unused) {
> + found_unused = true;
> + unused_idx = i;
> + }
> + }
> +
> + if (found_copy)
> + i = copy_idx;
> + else if (found_unused)
> + i = unused_idx;
> + else
> + goto err_ice_alloc_prof_mask;
> +
> + /* update mask for a new entry */
> + if (found_unused) {
> + hw->blk[blk].masks.masks[i].in_use = true;
> + hw->blk[blk].masks.masks[i].mask = mask;
> + hw->blk[blk].masks.masks[i].idx = idx;
> + hw->blk[blk].masks.masks[i].ref = 0;
> + ice_write_prof_mask_reg(hw, blk, i, idx, mask);
> + }
> +
> + hw->blk[blk].masks.masks[i].ref++;
> + *mask_idx = i;
> + status = 0;
> +
> +err_ice_alloc_prof_mask:
> + mutex_unlock(&hw->blk[blk].masks.lock);
> +
> + return status;
> +}
> +
> +/**
> + * ice_free_prof_mask - free profile mask
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + * @mask_idx: index of mask
> + */
> +static enum ice_status
> +ice_free_prof_mask(struct ice_hw *hw, enum ice_block blk, u16 mask_idx)
> +{
> + if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
> + return ICE_ERR_PARAM;
> +
> + if (!(mask_idx >= hw->blk[blk].masks.first &&
> + mask_idx < hw->blk[blk].masks.first + hw->blk[blk].masks.count))
> + return ICE_ERR_DOES_NOT_EXIST;
> +
> + mutex_lock(&hw->blk[blk].masks.lock);
> +
> + if (!hw->blk[blk].masks.masks[mask_idx].in_use)
> + goto exit_ice_free_prof_mask;
> +
> + if (hw->blk[blk].masks.masks[mask_idx].ref > 1) {
> + hw->blk[blk].masks.masks[mask_idx].ref--;
> + goto exit_ice_free_prof_mask;
> + }
> +
> + /* remove mask */
> + hw->blk[blk].masks.masks[mask_idx].in_use = false;
> + hw->blk[blk].masks.masks[mask_idx].mask = 0;
> + hw->blk[blk].masks.masks[mask_idx].idx = 0;
> +
> + /* update mask as unused entry */
> + ice_debug(hw, ICE_DBG_PKG, "Free mask, blk %d, mask %d\n", blk,
> + mask_idx);
> + ice_write_prof_mask_reg(hw, blk, mask_idx, 0, 0);
> +
> +exit_ice_free_prof_mask:
> + mutex_unlock(&hw->blk[blk].masks.lock);
> +
> + return 0;
> +}
> +
> +/**
> + * ice_free_prof_masks - free all profile masks for a profile
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + * @prof_id: profile ID
> + */
> +static enum ice_status
> +ice_free_prof_masks(struct ice_hw *hw, enum ice_block blk, u16 prof_id)
> +{
> + u32 mask_bm;
> + u16 i;
> +
> + if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
> + return ICE_ERR_PARAM;
> +
> + mask_bm = hw->blk[blk].es.mask_ena[prof_id];
> + for (i = 0; i < BITS_PER_BYTE * sizeof(mask_bm); i++)
> + if (mask_bm & BIT(i))
> + ice_free_prof_mask(hw, blk, i);
> +
> + return 0;
> +}
> +
> +/**
> + * ice_shutdown_prof_masks - releases lock for masking
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + *
> + * This should be called before unloading the driver */ static void
> +ice_shutdown_prof_masks(struct ice_hw *hw, enum ice_block blk) {
> + u16 i;
> +
> + mutex_lock(&hw->blk[blk].masks.lock);
> +
> + for (i = hw->blk[blk].masks.first;
> + i < hw->blk[blk].masks.first + hw->blk[blk].masks.count; i++) {
> + ice_write_prof_mask_reg(hw, blk, i, 0, 0);
> +
> + hw->blk[blk].masks.masks[i].in_use = false;
> + hw->blk[blk].masks.masks[i].idx = 0;
> + hw->blk[blk].masks.masks[i].mask = 0;
> + }
> +
> + mutex_unlock(&hw->blk[blk].masks.lock);
> + mutex_destroy(&hw->blk[blk].masks.lock);
> +}
> +
> +/**
> + * ice_shutdown_all_prof_masks - releases all locks for masking
> + * @hw: pointer to the HW struct
> + *
> + * This should be called before unloading the driver */ static void
> +ice_shutdown_all_prof_masks(struct ice_hw *hw) {
> + ice_shutdown_prof_masks(hw, ICE_BLK_RSS);
> + ice_shutdown_prof_masks(hw, ICE_BLK_FD); }
> +
> +/**
> + * ice_update_prof_masking - set registers according to masking
> + * @hw: pointer to the HW struct
> + * @blk: hardware block
> + * @prof_id: profile ID
> + * @masks: masks
> + */
> +static enum ice_status
> +ice_update_prof_masking(struct ice_hw *hw, enum ice_block blk, u16 prof_id,
> + u16 *masks)
> +{
> + bool err = false;
> + u32 ena_mask = 0;
> + u16 idx;
> + u16 i;
> +
> + /* Only support FD and RSS masking, otherwise nothing to be done */
> + if (blk != ICE_BLK_RSS && blk != ICE_BLK_FD)
> + return 0;
> +
> + for (i = 0; i < hw->blk[blk].es.fvw; i++)
> + if (masks[i] && masks[i] != 0xFFFF) {
> + if (!ice_alloc_prof_mask(hw, blk, i, masks[i], &idx)) {
> + ena_mask |= BIT(idx);
> + } else {
> + /* not enough bitmaps */
> + err = true;
> + break;
> + }
> + }
> +
> + if (err) {
> + /* free any bitmaps we have allocated */
> + for (i = 0; i < BITS_PER_BYTE * sizeof(ena_mask); i++)
> + if (ena_mask & BIT(i))
> + ice_free_prof_mask(hw, blk, i);
> +
> + return ICE_ERR_OUT_OF_RANGE;
> + }
> +
> + /* enable the masks for this profile */
> + ice_write_prof_mask_enable_res(hw, blk, prof_id, ena_mask);
> +
> + /* store enabled masks with profile so that they can be freed later */
> + hw->blk[blk].es.mask_ena[prof_id] = ena_mask;
> +
> + return 0;
> +}
> +
> +/**
> * ice_write_es - write an extraction sequence to hardware
> * @hw: pointer to the HW struct
> * @blk: the block in which to write the extraction sequence @@ -2622,6
> +3017,7 @@ ice_prof_dec_ref(struct ice_hw *hw, enum ice_block blk, u8
> prof_id)
> if (hw->blk[blk].es.ref_count[prof_id] > 0) {
> if (!--hw->blk[blk].es.ref_count[prof_id]) {
> ice_write_es(hw, blk, prof_id, NULL);
> + ice_free_prof_masks(hw, blk, prof_id);
> return ice_free_prof_id(hw, blk, prof_id);
> }
> }
> @@ -2982,6 +3378,7 @@ void ice_free_hw_tbls(struct ice_hw *hw)
> devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.t);
> devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.ref_count);
> devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.written);
> + devm_kfree(ice_hw_to_dev(hw), hw->blk[i].es.mask_ena);
> }
>
> list_for_each_entry_safe(r, rt, &hw->rss_list_head, l_entry) { @@ -
> 2989,6 +3386,7 @@ void ice_free_hw_tbls(struct ice_hw *hw)
> devm_kfree(ice_hw_to_dev(hw), r);
> }
> mutex_destroy(&hw->rss_locks);
> + ice_shutdown_all_prof_masks(hw);
> memset(hw->blk, 0, sizeof(hw->blk));
> }
>
> @@ -3042,6 +3440,7 @@ void ice_clear_hw_tbls(struct ice_hw *hw)
> memset(es->t, 0, es->count * sizeof(*es->t));
> memset(es->ref_count, 0, es->count * sizeof(*es->ref_count));
> memset(es->written, 0, es->count * sizeof(*es->written));
> + memset(es->mask_ena, 0, es->count * sizeof(*es-
> >mask_ena));
> }
> }
>
> @@ -3055,6 +3454,7 @@ enum ice_status ice_init_hw_tbls(struct ice_hw *hw)
>
> mutex_init(&hw->rss_locks);
> INIT_LIST_HEAD(&hw->rss_list_head);
> + ice_init_all_prof_masks(hw);
> for (i = 0; i < ICE_BLK_COUNT; i++) {
> struct ice_prof_redir *prof_redir = &hw->blk[i].prof_redir;
> struct ice_prof_tcam *prof = &hw->blk[i].prof; @@ -3153,6
> +3553,8 @@ enum ice_status ice_init_hw_tbls(struct ice_hw *hw)
>
> es->written = devm_kcalloc(ice_hw_to_dev(hw), es->count,
> sizeof(*es->written), GFP_KERNEL);
> + es->mask_ena = devm_kcalloc(ice_hw_to_dev(hw), es->count,
> + sizeof(*es->mask_ena), GFP_KERNEL);
> if (!es->ref_count)
> goto err;
> }
> @@ -3762,15 +4164,16 @@ ice_update_fd_swap(struct ice_hw *hw, u16
> prof_id, struct ice_fv_word *es)
> * @id: profile tracking ID
> * @ptypes: array of bitmaps indicating ptypes (ICE_FLOW_PTYPE_MAX bits)
> * @es: extraction sequence (length of array is determined by the block)
> + * @masks: mask for extraction sequence
> *
> - * This function registers a profile, which matches a set of PTGs with a
> + * This function registers a profile, which matches a set of PTYPES
> + with a
> * particular extraction sequence. While the hardware profile is allocated
> * it will not be written until the first call to ice_add_flow that specifies
> * the ID value used here.
> */
> enum ice_status
> ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
> - struct ice_fv_word *es)
> + struct ice_fv_word *es, u16 *masks)
> {
> u32 bytes = DIV_ROUND_UP(ICE_FLOW_PTYPE_MAX,
> BITS_PER_BYTE);
> DECLARE_BITMAP(ptgs_used, ICE_XLT1_CNT); @@ -3784,7 +4187,7
> @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
> mutex_lock(&hw->blk[blk].es.prof_map_lock);
>
> /* search for existing profile */
> - status = ice_find_prof_id(hw, blk, es, &prof_id);
> + status = ice_find_prof_id_with_mask(hw, blk, es, masks, &prof_id);
> if (status) {
> /* allocate profile ID */
> status = ice_alloc_prof_id(hw, blk, &prof_id); @@ -3802,6
> +4205,9 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8
> ptypes[],
> if (status)
> goto err_ice_add_prof;
> }
> + status = ice_update_prof_masking(hw, blk, prof_id, masks);
> + if (status)
> + goto err_ice_add_prof;
>
> /* and write new es */
> ice_write_es(hw, blk, prof_id, es);
> diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
> b/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
> index 568ea519af51..ea3f3ef5994a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
> @@ -28,7 +28,7 @@ bool ice_tunnel_port_in_use(struct ice_hw *hw, u16 port,
> u16 *index);
>
> enum ice_status
> ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
> - struct ice_fv_word *es);
> + struct ice_fv_word *es, u16 *masks);
> enum ice_status
> ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
> enum ice_status diff --git a/drivers/net/ethernet/intel/ice/ice_flex_type.h
> b/drivers/net/ethernet/intel/ice/ice_flex_type.h
> index a6f391eac8ff..e08526f85d46 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flex_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flex_type.h
> @@ -335,6 +335,7 @@ struct ice_es {
> u16 count;
> u16 fvw;
> u16 *ref_count;
> + u32 *mask_ena;
> struct list_head prof_map;
> struct ice_fv_word *t;
> struct mutex prof_map_lock; /* protect access to profiles list */
> @@ -478,6 +479,21 @@ struct ice_prof_redir {
> u16 count;
> };
>
> +struct ice_mask {
> + u16 mask; /* 16-bit mask */
> + u16 idx; /* index */
> + u16 ref; /* reference count */
> + u8 in_use; /* non-zero if used */
> +};
> +
> +struct ice_masks {
> + struct mutex lock; /* lock to protect this structure */
> + u16 first; /* first mask owned by the PF */
> + u16 count; /* number of masks owned by the PF */
> +#define ICE_PROF_MASK_COUNT 32
> + struct ice_mask masks[ICE_PROF_MASK_COUNT]; };
> +
> /* Tables per block */
> struct ice_blk_info {
> struct ice_xlt1 xlt1;
> @@ -485,6 +501,7 @@ struct ice_blk_info {
> struct ice_prof_tcam prof;
> struct ice_prof_redir prof_redir;
> struct ice_es es;
> + struct ice_masks masks;
> u8 overwrite; /* set to true to allow overwrite of table entries */
> u8 is_list_init;
> };
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c
> b/drivers/net/ethernet/intel/ice/ice_flow.c
> index 12a579702d40..0afe3c55eff9 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.c
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.c
> @@ -9,12 +9,21 @@ struct ice_flow_field_info {
> enum ice_flow_seg_hdr hdr;
> s16 off; /* Offset from start of a protocol header, in bits */
> u16 size; /* Size of fields in bits */
> + u16 mask; /* 16-bit mask for field */
> };
>
> #define ICE_FLOW_FLD_INFO(_hdr, _offset_bytes, _size_bytes) { \
> .hdr = _hdr, \
> .off = (_offset_bytes) * BITS_PER_BYTE, \
> .size = (_size_bytes) * BITS_PER_BYTE, \
> + .mask = 0, \
> +}
> +
> +#define ICE_FLOW_FLD_INFO_MSK(_hdr, _offset_bytes, _size_bytes,
> _mask) { \
> + .hdr = _hdr, \
> + .off = (_offset_bytes) * BITS_PER_BYTE, \
> + .size = (_size_bytes) * BITS_PER_BYTE, \
> + .mask = _mask, \
> }
>
> /* Table containing properties of supported protocol header fields */ @@ -
> 32,6 +41,18 @@ struct ice_flow_field_info
> ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> /* ICE_FLOW_FIELD_IDX_ETH_TYPE */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ETH, 0, sizeof(__be16)),
> /* IPv4 / IPv6 */
> + /* ICE_FLOW_FIELD_IDX_IPV4_DSCP */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_IPV4, 0, 1, 0x00fc),
> + /* ICE_FLOW_FIELD_IDX_IPV6_DSCP */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_IPV6, 0, 1, 0x0ff0),
> + /* ICE_FLOW_FIELD_IDX_IPV4_TTL */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 8, 1, 0xff00),
> + /* ICE_FLOW_FIELD_IDX_IPV4_PROT */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 8, 1, 0x00ff),
> + /* ICE_FLOW_FIELD_IDX_IPV6_TTL */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 6, 1, 0x00ff),
> + /* ICE_FLOW_FIELD_IDX_IPV6_PROT */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_NONE, 6, 1, 0xff00),
> /* ICE_FLOW_FIELD_IDX_IPV4_SA */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_IPV4, 12, sizeof(struct
> in_addr)),
> /* ICE_FLOW_FIELD_IDX_IPV4_DA */
> @@ -260,6 +281,8 @@ struct ice_flow_prof_params {
> * This will give us the direction flags.
> */
> struct ice_fv_word es[ICE_MAX_FV_WORDS];
> +
> + u16 mask[ICE_MAX_FV_WORDS];
> DECLARE_BITMAP(ptypes, ICE_FLOW_PTYPE_MAX); };
>
> @@ -434,6 +457,7 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
> * @params: information about the flow to be processed
> * @seg: packet segment index of the field to be extracted
> * @fld: ID of field to be extracted
> + * @match: bitfield of all fields
> *
> * This function determines the protocol ID, offset, and size of the given
> * field. It then allocates one or more extraction sequence entries for the @@ -
> 441,12 +465,15 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
> */
> static enum ice_status
> ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
> - u8 seg, enum ice_flow_field fld)
> + u8 seg, enum ice_flow_field fld, u64 match)
> {
> + enum ice_flow_field sib = ICE_FLOW_FIELD_IDX_MAX;
> enum ice_prot_id prot_id = ICE_PROT_ID_INVAL;
> u8 fv_words = hw->blk[params->blk].es.fvw;
> struct ice_flow_fld_info *flds;
> u16 cnt, ese_bits, i;
> + u16 sib_mask = 0;
> + u16 mask;
> u16 off;
>
> flds = params->prof->segs[seg].fields; @@ -461,6 +488,50 @@
> ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
> case ICE_FLOW_FIELD_IDX_ETH_TYPE:
> prot_id = seg == 0 ? ICE_PROT_ETYPE_OL :
> ICE_PROT_ETYPE_IL;
> break;
> + case ICE_FLOW_FIELD_IDX_IPV4_DSCP:
> + prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S :
> ICE_PROT_IPV4_IL;
> + break;
> + case ICE_FLOW_FIELD_IDX_IPV6_DSCP:
> + prot_id = seg == 0 ? ICE_PROT_IPV6_OF_OR_S :
> ICE_PROT_IPV6_IL;
> + break;
> + case ICE_FLOW_FIELD_IDX_IPV4_TTL:
> + case ICE_FLOW_FIELD_IDX_IPV4_PROT:
> + prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S :
> ICE_PROT_IPV4_IL;
> +
> + /* TTL and PROT share the same extraction seq. entry.
> + * Each is considered a sibling to the other in terms of sharing
> + * the same extraction sequence entry.
> + */
> + if (fld == ICE_FLOW_FIELD_IDX_IPV4_TTL)
> + sib = ICE_FLOW_FIELD_IDX_IPV4_PROT;
> + else if (fld == ICE_FLOW_FIELD_IDX_IPV4_PROT)
> + sib = ICE_FLOW_FIELD_IDX_IPV4_TTL;
> +
> + /* If the sibling field is also included, that field's
> + * mask needs to be included.
> + */
> + if (match & BIT(sib))
> + sib_mask = ice_flds_info[sib].mask;
> + break;
> + case ICE_FLOW_FIELD_IDX_IPV6_TTL:
> + case ICE_FLOW_FIELD_IDX_IPV6_PROT:
> + prot_id = seg == 0 ? ICE_PROT_IPV6_OF_OR_S :
> ICE_PROT_IPV6_IL;
> +
> + /* TTL and PROT share the same extraction seq. entry.
> + * Each is considered a sibling to the other in terms of sharing
> + * the same extraction sequence entry.
> + */
> + if (fld == ICE_FLOW_FIELD_IDX_IPV6_TTL)
> + sib = ICE_FLOW_FIELD_IDX_IPV6_PROT;
> + else if (fld == ICE_FLOW_FIELD_IDX_IPV6_PROT)
> + sib = ICE_FLOW_FIELD_IDX_IPV6_TTL;
> +
> + /* If the sibling field is also included, that field's
> + * mask needs to be included.
> + */
> + if (match & BIT(sib))
> + sib_mask = ice_flds_info[sib].mask;
> + break;
> case ICE_FLOW_FIELD_IDX_IPV4_SA:
> case ICE_FLOW_FIELD_IDX_IPV4_DA:
> prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S :
> ICE_PROT_IPV4_IL; @@ -495,6 +566,9 @@ ice_flow_xtract_fld(struct ice_hw
> *hw, struct ice_flow_prof_params *params,
> prot_id = (params->prof->segs[seg].hdrs &
> ICE_FLOW_SEG_HDR_IPV4) ?
> ICE_PROT_ICMP_IL : ICE_PROT_ICMPV6_IL;
> + sib = fld == ICE_FLOW_FIELD_IDX_ICMP_TYPE ?
> + ICE_FLOW_FIELD_IDX_ICMP_CODE :
> + ICE_FLOW_FIELD_IDX_ICMP_TYPE;
> break;
> case ICE_FLOW_FIELD_IDX_GRE_KEYID:
> prot_id = ICE_PROT_GRE_OF;
> @@ -513,6 +587,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct
> ice_flow_prof_params *params,
> ICE_FLOW_FV_EXTRACT_SZ;
> flds[fld].xtrct.disp = (u8)(ice_flds_info[fld].off % ese_bits);
> flds[fld].xtrct.idx = params->es_cnt;
> + flds[fld].xtrct.mask = ice_flds_info[fld].mask;
>
> /* Adjust the next field-entry index after accommodating the number of
> * entries this field consumes
> @@ -522,24 +597,34 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct
> ice_flow_prof_params *params,
>
> /* Fill in the extraction sequence entries needed for this field */
> off = flds[fld].xtrct.off;
> + mask = flds[fld].xtrct.mask;
> for (i = 0; i < cnt; i++) {
> - u8 idx;
> -
> - /* Make sure the number of extraction sequence required
> - * does not exceed the block's capability
> + /* Only consume an extraction sequence entry if there is no
> + * sibling field associated with this field or the sibling entry
> + * already extracts the word shared with this field.
> */
> - if (params->es_cnt >= fv_words)
> - return ICE_ERR_MAX_LIMIT;
> + if (sib == ICE_FLOW_FIELD_IDX_MAX ||
> + flds[sib].xtrct.prot_id == ICE_PROT_ID_INVAL ||
> + flds[sib].xtrct.off != off) {
> + u8 idx;
>
> - /* some blocks require a reversed field vector layout */
> - if (hw->blk[params->blk].es.reverse)
> - idx = fv_words - params->es_cnt - 1;
> - else
> - idx = params->es_cnt;
> + /* Make sure the number of extraction sequence required
> + * does not exceed the block's capability
> + */
> + if (params->es_cnt >= fv_words)
> + return ICE_ERR_MAX_LIMIT;
>
> - params->es[idx].prot_id = prot_id;
> - params->es[idx].off = off;
> - params->es_cnt++;
> + /* some blocks require a reversed field vector layout */
> + if (hw->blk[params->blk].es.reverse)
> + idx = fv_words - params->es_cnt - 1;
> + else
> + idx = params->es_cnt;
> +
> + params->es[idx].prot_id = prot_id;
> + params->es[idx].off = off;
> + params->mask[idx] = mask | sib_mask;
> + params->es_cnt++;
> + }
>
> off += ICE_FLOW_FV_EXTRACT_SZ;
> }
> @@ -634,19 +719,23 @@ static enum ice_status
> ice_flow_create_xtrct_seq(struct ice_hw *hw,
> struct ice_flow_prof_params *params) {
> - struct ice_flow_prof *prof = params->prof;
> enum ice_status status = 0;
> u8 i;
>
> - for (i = 0; i < prof->segs_cnt; i++) {
> - u8 j;
> + for (i = 0; i < params->prof->segs_cnt; i++) {
> + u64 match = params->prof->segs[i].match;
> + enum ice_flow_field j;
>
> - for_each_set_bit(j, (unsigned long *)&prof->segs[i].match,
> - ICE_FLOW_FIELD_IDX_MAX) {
> - status = ice_flow_xtract_fld(hw, params, i,
> - (enum ice_flow_field)j);
> - if (status)
> - return status;
> + for (j = 0; j < ICE_FLOW_FIELD_IDX_MAX && match; j++) {
> + const u64 bit = BIT_ULL(j);
> +
> + if (match & bit) {
> + status = ice_flow_xtract_fld(hw, params, i, j,
> + match);
> + if (status)
> + return status;
> + match &= ~bit;
> + }
> }
>
> /* Process raw matching bytes */
> @@ -852,7 +941,8 @@ ice_flow_add_prof_sync(struct ice_hw *hw, enum
> ice_block blk,
> }
>
> /* Add a HW profile for this flow profile */
> - status = ice_add_prof(hw, blk, prof_id, (u8 *)params.ptypes,
> params.es);
> + status = ice_add_prof(hw, blk, prof_id, (u8 *)params.ptypes,
> + params.es, params.mask);
> if (status) {
> ice_debug(hw, ICE_DBG_FLOW, "Error adding a HW flow
> profile\n");
> goto out;
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h
> b/drivers/net/ethernet/intel/ice/ice_flow.h
> index 234f8f5c99cf..9eaafd5e50e0 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> @@ -58,6 +58,12 @@ enum ice_flow_field {
> ICE_FLOW_FIELD_IDX_C_VLAN,
> ICE_FLOW_FIELD_IDX_ETH_TYPE,
> /* L3 */
> + ICE_FLOW_FIELD_IDX_IPV4_DSCP,
> + ICE_FLOW_FIELD_IDX_IPV6_DSCP,
> + ICE_FLOW_FIELD_IDX_IPV4_TTL,
> + ICE_FLOW_FIELD_IDX_IPV4_PROT,
> + ICE_FLOW_FIELD_IDX_IPV6_TTL,
> + ICE_FLOW_FIELD_IDX_IPV6_PROT,
> ICE_FLOW_FIELD_IDX_IPV4_SA,
> ICE_FLOW_FIELD_IDX_IPV4_DA,
> ICE_FLOW_FIELD_IDX_IPV6_SA,
> @@ -158,6 +164,7 @@ struct ice_flow_seg_xtrct {
> u16 off; /* Starting offset of the field in header in bytes */
> u8 idx; /* Index of FV entry used */
> u8 disp; /* Displacement of field in bits fr. FV entry's start */
> + u16 mask; /* Mask for field */
> };
>
> enum ice_flow_fld_match_type {
> diff --git a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> index bb1cc372ee95..07a9b70c2751 100644
> --- a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> +++ b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> @@ -306,8 +306,24 @@
> #define GLQF_FD_SIZE_FD_BSIZE_S 16
> #define GLQF_FD_SIZE_FD_BSIZE_M ICE_M(0x7FFF, 16)
> #define GLQF_FDINSET(_i, _j) (0x00412000 + ((_i) * 4 +
> (_j) * 512))
> +#define GLQF_FDMASK(_i) (0x00410800 + ((_i) *
> 4))
> +#define GLQF_FDMASK_MAX_INDEX 31
> +#define GLQF_FDMASK_MSK_INDEX_S 0
> +#define GLQF_FDMASK_MSK_INDEX_M ICE_M(0x1F, 0)
> +#define GLQF_FDMASK_MASK_S 16
> +#define GLQF_FDMASK_MASK_M ICE_M(0xFFFF, 16)
> #define GLQF_FDMASK_SEL(_i) (0x00410400 + ((_i) * 4))
> #define GLQF_FDSWAP(_i, _j) (0x00413000 + ((_i) * 4 +
> (_j) * 512))
> +#define GLQF_HMASK(_i) (0x0040FC00 + ((_i) * 4))
> +#define GLQF_HMASK_MAX_INDEX 31
> +#define GLQF_HMASK_MSK_INDEX_S 0
> +#define GLQF_HMASK_MSK_INDEX_M ICE_M(0x1F, 0)
> +#define GLQF_HMASK_MASK_S 16
> +#define GLQF_HMASK_MASK_M ICE_M(0xFFFF, 16)
> +#define GLQF_HMASK_SEL(_i) (0x00410000 + ((_i) * 4))
> +#define GLQF_HMASK_SEL_MAX_INDEX 127
> +#define GLQF_HMASK_SEL_MASK_SEL_S 0
> +#define GLQF_HMASK_SEL_MASK_SEL_M
> #define PFQF_FD_ENA 0x0043A000
> #define PFQF_FD_ENA_FD_ENA_M BIT(0)
> #define PFQF_FD_SIZE 0x00460100
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 04/14] ice: Add more advanced protocol support in flow filter
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (2 preceding siblings ...)
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 03/14] ice: Support non word aligned input set field Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-03 4:58 ` Kirsher, Jeffrey T
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 05/14] ice: Support to separate GTP-U uplink and downlink Qi Zhang
` (10 subsequent siblings)
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
The patch add more protocol support in flow filter, these
include PPPoE, L2TPv3, GTP, PFCP, ESP and AH.
Signed-off-by: Ting Xu <ting.xu@intel.com>
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flow.c | 272 ++++++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_flow.h | 128 +++++++++-
drivers/net/ethernet/intel/ice/ice_protocol_type.h | 4 +
3 files changed, 398 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index 0afe3c55eff9..094e1ec82cb6 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -96,6 +96,37 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
/* ICE_FLOW_FIELD_IDX_GRE_KEYID */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GRE, 12,
sizeof_field(struct gre_full_hdr, key)),
+ /* GTP */
+ /* ICE_FLOW_FIELD_IDX_GTPC_TEID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPC_TEID, 12, sizeof(__be32)),
+ /* ICE_FLOW_FIELD_IDX_GTPU_IP_TEID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_IP, 12, sizeof(__be32)),
+ /* ICE_FLOW_FIELD_IDX_GTPU_EH_TEID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12, sizeof(__be32)),
+ /* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22, sizeof(__be16), 0x3f00),
+ /* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12, sizeof(__be32)),
+ /* ICE_FLOW_FIELD_IDX_GTPU_DWN_TEID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_DWN, 12, sizeof(__be32)),
+ /* PPPOE */
+ /* ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_PPPOE, 2, sizeof(__be16)),
+ /* PFCP */
+ /* ICE_FLOW_FIELD_IDX_PFCP_SEID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_PFCP_SESSION, 12, sizeof(__be64)),
+ /* L2TPV3 */
+ /* ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_L2TPV3, 0, sizeof(__be32)),
+ /* ESP */
+ /* ICE_FLOW_FIELD_IDX_ESP_SPI */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ESP, 0, sizeof(__be32)),
+ /* AH */
+ /* ICE_FLOW_FIELD_IDX_AH_SPI */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_AH, 4, sizeof(__be32)),
+ /* NAT_T_ESP */
+ /* ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI */
+ ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_NAT_T_ESP, 8, sizeof(__be32)),
};
/* Bitmaps indicating relevant packet types for a particular protocol header
@@ -128,6 +159,8 @@ static const u32 ice_ptypes_macvlan_il[] = {
/* Packet types for packets with an Outer/First/Single IPv4 header */
static const u32 ice_ptypes_ipv4_ofos[] = {
0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000155, 0x00000000, 0x00000000,
+ 0x00000000, 0x000FC000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -141,7 +174,7 @@ static const u32 ice_ptypes_ipv4_ofos[] = {
static const u32 ice_ptypes_ipv4_il[] = {
0xE0000000, 0xB807700E, 0x80000003, 0xE01DC03B,
0x0000000E, 0x00000000, 0x00000000, 0x00000000,
- 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x001FF800, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -152,6 +185,8 @@ static const u32 ice_ptypes_ipv4_il[] = {
/* Packet types for packets with an Outer/First/Single IPv6 header */
static const u32 ice_ptypes_ipv6_ofos[] = {
0x00000000, 0x00000000, 0x77000000, 0x10002000,
+ 0x00000000, 0x000002AA, 0x00000000, 0x00000000,
+ 0x00000000, 0x03F00000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -165,7 +200,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = {
static const u32 ice_ptypes_ipv6_il[] = {
0x00000000, 0x03B80770, 0x000001DC, 0x0EE00000,
0x00000770, 0x00000000, 0x00000000, 0x00000000,
- 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x7FE00000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -191,7 +226,7 @@ static const u32 ice_ptypes_arp_of[] = {
static const u32 ice_ptypes_udp_il[] = {
0x81000000, 0x20204040, 0x04000010, 0x80810102,
0x00000040, 0x00000000, 0x00000000, 0x00000000,
- 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00410000, 0x90842000, 0x00000007,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -203,7 +238,7 @@ static const u32 ice_ptypes_udp_il[] = {
static const u32 ice_ptypes_tcp_il[] = {
0x04000000, 0x80810102, 0x10000040, 0x02040408,
0x00000102, 0x00000000, 0x00000000, 0x00000000,
- 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00820000, 0x21084000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -215,6 +250,7 @@ static const u32 ice_ptypes_tcp_il[] = {
static const u32 ice_ptypes_sctp_il[] = {
0x08000000, 0x01020204, 0x20000081, 0x04080810,
0x00000204, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x01040000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -270,6 +306,125 @@ static const u32 ice_ptypes_mac_il[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
+/* Packet types for GTPC */
+static const u32 ice_ptypes_gtpc[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000180, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for GTPC with TEID */
+static const u32 ice_ptypes_gtpc_tid[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000060, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+static const u32 ice_ptypes_gtpu[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x7FFFFE00, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for pppoe */
+static const u32 ice_ptypes_pppoe[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x03ffe000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with PFCP NODE header */
+static const u32 ice_ptypes_pfcp_node[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x80000000, 0x00000002,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with PFCP SESSION header */
+static const u32 ice_ptypes_pfcp_session[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000005,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for l2tpv3 */
+static const u32 ice_ptypes_l2tpv3[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000300,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for esp */
+static const u32 ice_ptypes_esp[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000003, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for ah */
+static const u32 ice_ptypes_ah[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x0000000C, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with NAT_T ESP header */
+static const u32 ice_ptypes_nat_t_esp[] = {
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000030, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
/* Manage parameters and info. used during the creation of a flow profile */
struct ice_flow_prof_params {
enum ice_block blk;
@@ -286,6 +441,15 @@ struct ice_flow_prof_params {
DECLARE_BITMAP(ptypes, ICE_FLOW_PTYPE_MAX);
};
+#define ICE_FLOW_RSS_HDRS_INNER_MASK \
+ (ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_GTPC | \
+ ICE_FLOW_SEG_HDR_GTPC_TEID | ICE_FLOW_SEG_HDR_GTPU | \
+ ICE_FLOW_SEG_HDR_PFCP_SESSION | ICE_FLOW_SEG_HDR_L2TPV3 | \
+ ICE_FLOW_SEG_HDR_ESP | ICE_FLOW_SEG_HDR_AH | \
+ ICE_FLOW_SEG_HDR_NAT_T_ESP)
+
+#define ICE_FLOW_SEG_HDRS_L2_MASK \
+ (ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_VLAN)
#define ICE_FLOW_SEG_HDRS_L3_MASK \
(ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6 | \
ICE_FLOW_SEG_HDR_ARP)
@@ -420,6 +584,16 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
ICE_FLOW_PTYPE_MAX);
}
+ if (hdrs & ICE_FLOW_SEG_HDR_PPPOE) {
+ src = (const unsigned long *)ice_ptypes_pppoe;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else {
+ src = (const unsigned long *)ice_ptypes_pppoe;
+ bitmap_andnot(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ }
+
if (hdrs & ICE_FLOW_SEG_HDR_UDP) {
src = (const unsigned long *)ice_ptypes_udp_il;
bitmap_and(params->ptypes, params->ptypes, src,
@@ -445,6 +619,66 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
bitmap_and(params->ptypes, params->ptypes,
src, ICE_FLOW_PTYPE_MAX);
}
+ } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC) {
+ src = (const unsigned long *)ice_ptypes_gtpc;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC_TEID) {
+ src = (const unsigned long *)ice_ptypes_gtpc_tid;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_DWN) {
+ src = (const unsigned long *)ice_ptypes_gtpu;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_UP) {
+ src = (const unsigned long *)ice_ptypes_gtpu;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_EH) {
+ src = (const unsigned long *)ice_ptypes_gtpu;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_IP) {
+ src = (const unsigned long *)ice_ptypes_gtpu;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_L2TPV3) {
+ src = (const unsigned long *)ice_ptypes_l2tpv3;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_ESP) {
+ src = (const unsigned long *)ice_ptypes_esp;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_AH) {
+ src = (const unsigned long *)ice_ptypes_ah;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_NAT_T_ESP) {
+ src = (const unsigned long *)ice_ptypes_nat_t_esp;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ }
+
+ if (hdrs & ICE_FLOW_SEG_HDR_PFCP) {
+ if (hdrs & ICE_FLOW_SEG_HDR_PFCP_NODE)
+ src =
+ (const unsigned long *)ice_ptypes_pfcp_node;
+ else
+ src =
+ (const unsigned long *)ice_ptypes_pfcp_session;
+
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else {
+ src = (const unsigned long *)ice_ptypes_pfcp_node;
+ bitmap_andnot(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+
+ src = (const unsigned long *)ice_ptypes_pfcp_session;
+ bitmap_andnot(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
}
}
@@ -553,6 +787,33 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
case ICE_FLOW_FIELD_IDX_SCTP_DST_PORT:
prot_id = ICE_PROT_SCTP_IL;
break;
+ case ICE_FLOW_FIELD_IDX_GTPC_TEID:
+ case ICE_FLOW_FIELD_IDX_GTPU_IP_TEID:
+ case ICE_FLOW_FIELD_IDX_GTPU_UP_TEID:
+ case ICE_FLOW_FIELD_IDX_GTPU_DWN_TEID:
+ case ICE_FLOW_FIELD_IDX_GTPU_EH_TEID:
+ case ICE_FLOW_FIELD_IDX_GTPU_EH_QFI:
+ /* GTP is accessed through UDP OF protocol */
+ prot_id = ICE_PROT_UDP_OF;
+ break;
+ case ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID:
+ prot_id = ICE_PROT_PPPOE;
+ break;
+ case ICE_FLOW_FIELD_IDX_PFCP_SEID:
+ prot_id = ICE_PROT_UDP_IL_OR_S;
+ break;
+ case ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID:
+ prot_id = ICE_PROT_L2TPV3;
+ break;
+ case ICE_FLOW_FIELD_IDX_ESP_SPI:
+ prot_id = ICE_PROT_ESP_F;
+ break;
+ case ICE_FLOW_FIELD_IDX_AH_SPI:
+ prot_id = ICE_PROT_ESP_2;
+ break;
+ case ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI:
+ prot_id = ICE_PROT_UDP_IL_OR_S;
+ break;
case ICE_FLOW_FIELD_IDX_ARP_SIP:
case ICE_FLOW_FIELD_IDX_ARP_DIP:
case ICE_FLOW_FIELD_IDX_ARP_SHA:
@@ -1388,7 +1649,8 @@ ice_flow_set_rss_seg_info(struct ice_flow_seg_info *segs, u64 hash_fields,
ICE_FLOW_SET_HDRS(segs, flow_hdr);
- if (segs->hdrs & ~ICE_FLOW_RSS_SEG_HDR_VAL_MASKS)
+ if (segs->hdrs & ~ICE_FLOW_RSS_SEG_HDR_VAL_MASKS &
+ ~ICE_FLOW_RSS_HDRS_INNER_MASK)
return ICE_ERR_PARAM;
val = (u64)(segs->hdrs & ICE_FLOW_RSS_SEG_HDR_L3_MASKS);
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 9eaafd5e50e0..04690669dfd7 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -30,6 +30,80 @@
#define ICE_HASH_UDP_IPV4 (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_UDP_PORT)
#define ICE_HASH_UDP_IPV6 (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_UDP_PORT)
+#define ICE_FLOW_HASH_GTP_TEID \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPC_TEID))
+
+#define ICE_FLOW_HASH_GTP_IPV4_TEID \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_GTP_TEID)
+#define ICE_FLOW_HASH_GTP_IPV6_TEID \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_GTP_TEID)
+
+#define ICE_FLOW_HASH_GTP_U_TEID \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID))
+
+#define ICE_FLOW_HASH_GTP_U_IPV4_TEID \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_GTP_U_TEID)
+#define ICE_FLOW_HASH_GTP_U_IPV6_TEID \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_GTP_U_TEID)
+
+#define ICE_FLOW_HASH_GTP_U_EH_TEID \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_EH_TEID))
+
+#define ICE_FLOW_HASH_GTP_U_EH_QFI \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_EH_QFI))
+
+#define ICE_FLOW_HASH_GTP_U_IPV4_EH \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_GTP_U_EH_TEID | \
+ ICE_FLOW_HASH_GTP_U_EH_QFI)
+#define ICE_FLOW_HASH_GTP_U_IPV6_EH \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_GTP_U_EH_TEID | \
+ ICE_FLOW_HASH_GTP_U_EH_QFI)
+
+#define ICE_FLOW_HASH_PPPOE_SESS_ID \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID))
+
+#define ICE_FLOW_HASH_PPPOE_SESS_ID_ETH \
+ (ICE_FLOW_HASH_ETH | ICE_FLOW_HASH_PPPOE_SESS_ID)
+#define ICE_FLOW_HASH_PPPOE_TCP_ID \
+ (ICE_FLOW_HASH_TCP_PORT | ICE_FLOW_HASH_PPPOE_SESS_ID)
+#define ICE_FLOW_HASH_PPPOE_UDP_ID \
+ (ICE_FLOW_HASH_UDP_PORT | ICE_FLOW_HASH_PPPOE_SESS_ID)
+
+#define ICE_FLOW_HASH_PFCP_SEID \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_PFCP_SEID))
+#define ICE_FLOW_HASH_PFCP_IPV4_SEID \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_PFCP_SEID)
+#define ICE_FLOW_HASH_PFCP_IPV6_SEID \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_PFCP_SEID)
+
+#define ICE_FLOW_HASH_L2TPV3_SESS_ID \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID))
+#define ICE_FLOW_HASH_L2TPV3_IPV4_SESS_ID \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_L2TPV3_SESS_ID)
+#define ICE_FLOW_HASH_L2TPV3_IPV6_SESS_ID \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_L2TPV3_SESS_ID)
+
+#define ICE_FLOW_HASH_ESP_SPI \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI))
+#define ICE_FLOW_HASH_ESP_IPV4_SPI \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_ESP_SPI)
+#define ICE_FLOW_HASH_ESP_IPV6_SPI \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_ESP_SPI)
+
+#define ICE_FLOW_HASH_AH_SPI \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_AH_SPI))
+#define ICE_FLOW_HASH_AH_IPV4_SPI \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_AH_SPI)
+#define ICE_FLOW_HASH_AH_IPV6_SPI \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_AH_SPI)
+
+#define ICE_FLOW_HASH_NAT_T_ESP_SPI \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI))
+#define ICE_FLOW_HASH_NAT_T_ESP_IPV4_SPI \
+ (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_NAT_T_ESP_SPI)
+#define ICE_FLOW_HASH_NAT_T_ESP_IPV6_SPI \
+ (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_NAT_T_ESP_SPI)
+
/* Protocol header fields within a packet segment. A segment consists of one or
* more protocol headers that make up a logical group of protocol headers. Each
* logical group of protocol headers encapsulates or is encapsulated using/by
@@ -48,8 +122,37 @@ enum ice_flow_seg_hdr {
ICE_FLOW_SEG_HDR_UDP = 0x00000080,
ICE_FLOW_SEG_HDR_SCTP = 0x00000100,
ICE_FLOW_SEG_HDR_GRE = 0x00000200,
+ ICE_FLOW_SEG_HDR_GTPC = 0x00000400,
+ ICE_FLOW_SEG_HDR_GTPC_TEID = 0x00000800,
+ ICE_FLOW_SEG_HDR_GTPU_IP = 0x00001000,
+ ICE_FLOW_SEG_HDR_GTPU_EH = 0x00002000,
+ ICE_FLOW_SEG_HDR_GTPU_DWN = 0x00004000,
+ ICE_FLOW_SEG_HDR_GTPU_UP = 0x00008000,
+ ICE_FLOW_SEG_HDR_PPPOE = 0x00010000,
+ ICE_FLOW_SEG_HDR_PFCP_NODE = 0x00020000,
+ ICE_FLOW_SEG_HDR_PFCP_SESSION = 0x00040000,
+ ICE_FLOW_SEG_HDR_L2TPV3 = 0x00080000,
+ ICE_FLOW_SEG_HDR_ESP = 0x00100000,
+ ICE_FLOW_SEG_HDR_AH = 0x00200000,
+ ICE_FLOW_SEG_HDR_NAT_T_ESP = 0x00400000,
};
+/* These segements all have the same PTYPES, but are otherwise distinguished by
+ * the value of the gtp_eh_pdu and gtp_eh_pdu_link flags:
+ *
+ * gtp_eh_pdu gtp_eh_pdu_link
+ * ICE_FLOW_SEG_HDR_GTPU_IP 0 0
+ * ICE_FLOW_SEG_HDR_GTPU_EH 1 don't care
+ * ICE_FLOW_SEG_HDR_GTPU_DWN 1 0
+ * ICE_FLOW_SEG_HDR_GTPU_UP 1 1
+ */
+#define ICE_FLOW_SEG_HDR_GTPU (ICE_FLOW_SEG_HDR_GTPU_IP | \
+ ICE_FLOW_SEG_HDR_GTPU_EH | \
+ ICE_FLOW_SEG_HDR_GTPU_DWN | \
+ ICE_FLOW_SEG_HDR_GTPU_UP)
+#define ICE_FLOW_SEG_HDR_PFCP (ICE_FLOW_SEG_HDR_PFCP_NODE | \
+ ICE_FLOW_SEG_HDR_PFCP_SESSION)
+
enum ice_flow_field {
/* L2 */
ICE_FLOW_FIELD_IDX_ETH_DA,
@@ -87,7 +190,30 @@ enum ice_flow_field {
ICE_FLOW_FIELD_IDX_ICMP_CODE,
/* GRE */
ICE_FLOW_FIELD_IDX_GRE_KEYID,
- /* The total number of enums must not exceed 64 */
+ /* GTPC_TEID */
+ ICE_FLOW_FIELD_IDX_GTPC_TEID,
+ /* GTPU_IP */
+ ICE_FLOW_FIELD_IDX_GTPU_IP_TEID,
+ /* GTPU_EH */
+ ICE_FLOW_FIELD_IDX_GTPU_EH_TEID,
+ ICE_FLOW_FIELD_IDX_GTPU_EH_QFI,
+ /* GTPU_UP */
+ ICE_FLOW_FIELD_IDX_GTPU_UP_TEID,
+ /* GTPU_DWN */
+ ICE_FLOW_FIELD_IDX_GTPU_DWN_TEID,
+ /* PPPOE */
+ ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID,
+ /* PFCP */
+ ICE_FLOW_FIELD_IDX_PFCP_SEID,
+ /* L2TPV3 */
+ ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID,
+ /* ESP */
+ ICE_FLOW_FIELD_IDX_ESP_SPI,
+ /* AH */
+ ICE_FLOW_FIELD_IDX_AH_SPI,
+ /* NAT_T ESP */
+ ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI,
+ /* The total number of enums must not exceed 64 */
ICE_FLOW_FIELD_IDX_MAX
};
diff --git a/drivers/net/ethernet/intel/ice/ice_protocol_type.h b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
index fac5f15a692c..199aa5b71540 100644
--- a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
@@ -24,9 +24,13 @@ enum ice_prot_id {
ICE_PROT_UDP_OF = 52,
ICE_PROT_UDP_IL_OR_S = 53,
ICE_PROT_GRE_OF = 64,
+ ICE_PROT_ESP_F = 88,
+ ICE_PROT_ESP_2 = 89,
ICE_PROT_SCTP_IL = 96,
ICE_PROT_ICMP_IL = 98,
ICE_PROT_ICMPV6_IL = 100,
+ ICE_PROT_PPPOE = 103,
+ ICE_PROT_L2TPV3 = 104,
ICE_PROT_ARP_OF = 118,
ICE_PROT_META_ID = 255, /* when offset == metadata */
ICE_PROT_INVALID = 255 /* when offset == ICE_FV_OFFSET_INVAL */
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 04/14] ice: Add more advanced protocol support in flow filter
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 04/14] ice: Add more advanced protocol support in flow filter Qi Zhang
@ 2020-07-03 4:58 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 4:58 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 04/14] ice: Add more advanced
> protocol support in flow filter
>
> The patch add more protocol support in flow filter, these include PPPoE,
> L2TPv3, GTP, PFCP, ESP and AH.
>
> Signed-off-by: Ting Xu <ting.xu@intel.com>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_flow.c | 272
> ++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_flow.h | 128 +++++++++-
> drivers/net/ethernet/intel/ice/ice_protocol_type.h | 4 +
> 3 files changed, 398 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c
> b/drivers/net/ethernet/intel/ice/ice_flow.c
> index 0afe3c55eff9..094e1ec82cb6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.c
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.c
> @@ -96,6 +96,37 @@ struct ice_flow_field_info
> ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> /* ICE_FLOW_FIELD_IDX_GRE_KEYID */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GRE, 12,
> sizeof_field(struct gre_full_hdr, key)),
> + /* GTP */
> + /* ICE_FLOW_FIELD_IDX_GTPC_TEID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPC_TEID, 12,
> sizeof(__be32)),
> + /* ICE_FLOW_FIELD_IDX_GTPU_IP_TEID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_IP, 12,
> sizeof(__be32)),
> + /* ICE_FLOW_FIELD_IDX_GTPU_EH_TEID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12,
> sizeof(__be32)),
> + /* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */
> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22,
> sizeof(__be16), 0x3f00),
> + /* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12,
> sizeof(__be32)),
> + /* ICE_FLOW_FIELD_IDX_GTPU_DWN_TEID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_DWN, 12,
> sizeof(__be32)),
> + /* PPPOE */
> + /* ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_PPPOE, 2, sizeof(__be16)),
> + /* PFCP */
> + /* ICE_FLOW_FIELD_IDX_PFCP_SEID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_PFCP_SESSION, 12,
> sizeof(__be64)),
> + /* L2TPV3 */
> + /* ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_L2TPV3, 0,
> sizeof(__be32)),
> + /* ESP */
> + /* ICE_FLOW_FIELD_IDX_ESP_SPI */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_ESP, 0, sizeof(__be32)),
> + /* AH */
> + /* ICE_FLOW_FIELD_IDX_AH_SPI */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_AH, 4, sizeof(__be32)),
> + /* NAT_T_ESP */
> + /* ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI */
> + ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_NAT_T_ESP, 8,
> sizeof(__be32)),
> };
>
> /* Bitmaps indicating relevant packet types for a particular protocol header
> @@ -128,6 +159,8 @@ static const u32 ice_ptypes_macvlan_il[] = {
> /* Packet types for packets with an Outer/First/Single IPv4 header */ static
> const u32 ice_ptypes_ipv4_ofos[] = {
> 0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000155, 0x00000000, 0x00000000,
> + 0x00000000, 0x000FC000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -141,7 +174,7
> @@ static const u32 ice_ptypes_ipv4_ofos[] = { static const u32
> ice_ptypes_ipv4_il[] = {
> 0xE0000000, 0xB807700E, 0x80000003, 0xE01DC03B,
> 0x0000000E, 0x00000000, 0x00000000, 0x00000000,
> - 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x001FF800, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -152,6 +185,8
> @@ static const u32 ice_ptypes_ipv4_il[] = {
> /* Packet types for packets with an Outer/First/Single IPv6 header */ static
> const u32 ice_ptypes_ipv6_ofos[] = {
> 0x00000000, 0x00000000, 0x77000000, 0x10002000,
> + 0x00000000, 0x000002AA, 0x00000000, 0x00000000,
> + 0x00000000, 0x03F00000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -165,7 +200,7
> @@ static const u32 ice_ptypes_ipv6_ofos[] = { static const u32
> ice_ptypes_ipv6_il[] = {
> 0x00000000, 0x03B80770, 0x000001DC, 0x0EE00000,
> 0x00000770, 0x00000000, 0x00000000, 0x00000000,
> - 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x7FE00000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -191,7 +226,7
> @@ static const u32 ice_ptypes_arp_of[] = { static const u32
> ice_ptypes_udp_il[] = {
> 0x81000000, 0x20204040, 0x04000010, 0x80810102,
> 0x00000040, 0x00000000, 0x00000000, 0x00000000,
> - 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00410000, 0x90842000, 0x00000007,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -203,7 +238,7
> @@ static const u32 ice_ptypes_udp_il[] = { static const u32
> ice_ptypes_tcp_il[] = {
> 0x04000000, 0x80810102, 0x10000040, 0x02040408,
> 0x00000102, 0x00000000, 0x00000000, 0x00000000,
> - 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00820000, 0x21084000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -215,6 +250,7
> @@ static const u32 ice_ptypes_tcp_il[] = { static const u32
> ice_ptypes_sctp_il[] = {
> 0x08000000, 0x01020204, 0x20000081, 0x04080810,
> 0x00000204, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x01040000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -270,6
> +306,125 @@ static const u32 ice_ptypes_mac_il[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> +/* Packet types for GTPC */
> +static const u32 ice_ptypes_gtpc[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000180, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for GTPC with TEID */
> +static const u32 ice_ptypes_gtpc_tid[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000060, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +static const u32 ice_ptypes_gtpu[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x7FFFFE00, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for pppoe */
> +static const u32 ice_ptypes_pppoe[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x03ffe000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with PFCP NODE header */ static const u32
> +ice_ptypes_pfcp_node[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x80000000, 0x00000002,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with PFCP SESSION header */ static const
> +u32 ice_ptypes_pfcp_session[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000005,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for l2tpv3 */
> +static const u32 ice_ptypes_l2tpv3[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000300,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for esp */
> +static const u32 ice_ptypes_esp[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000003, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for ah */
> +static const u32 ice_ptypes_ah[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x0000000C, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with NAT_T ESP header */ static const u32
> +ice_ptypes_nat_t_esp[] = {
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000030, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> /* Manage parameters and info. used during the creation of a flow profile */
> struct ice_flow_prof_params {
> enum ice_block blk;
> @@ -286,6 +441,15 @@ struct ice_flow_prof_params {
> DECLARE_BITMAP(ptypes, ICE_FLOW_PTYPE_MAX); };
>
> +#define ICE_FLOW_RSS_HDRS_INNER_MASK \
> + (ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_GTPC | \
> + ICE_FLOW_SEG_HDR_GTPC_TEID | ICE_FLOW_SEG_HDR_GTPU | \
> + ICE_FLOW_SEG_HDR_PFCP_SESSION | ICE_FLOW_SEG_HDR_L2TPV3 |
> \
> + ICE_FLOW_SEG_HDR_ESP | ICE_FLOW_SEG_HDR_AH | \
> + ICE_FLOW_SEG_HDR_NAT_T_ESP)
> +
> +#define ICE_FLOW_SEG_HDRS_L2_MASK \
> + (ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_VLAN)
> #define ICE_FLOW_SEG_HDRS_L3_MASK \
> (ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV6 | \
> ICE_FLOW_SEG_HDR_ARP)
> @@ -420,6 +584,16 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
> ICE_FLOW_PTYPE_MAX);
> }
>
> + if (hdrs & ICE_FLOW_SEG_HDR_PPPOE) {
> + src = (const unsigned long *)ice_ptypes_pppoe;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else {
> + src = (const unsigned long *)ice_ptypes_pppoe;
> + bitmap_andnot(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + }
> +
> if (hdrs & ICE_FLOW_SEG_HDR_UDP) {
> src = (const unsigned long *)ice_ptypes_udp_il;
> bitmap_and(params->ptypes, params->ptypes, src, @@
> -445,6 +619,66 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
> bitmap_and(params->ptypes, params->ptypes,
> src, ICE_FLOW_PTYPE_MAX);
> }
> + } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC) {
> + src = (const unsigned long *)ice_ptypes_gtpc;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC_TEID) {
> + src = (const unsigned long *)ice_ptypes_gtpc_tid;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_DWN) {
> + src = (const unsigned long *)ice_ptypes_gtpu;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_UP) {
> + src = (const unsigned long *)ice_ptypes_gtpu;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_EH) {
> + src = (const unsigned long *)ice_ptypes_gtpu;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_IP) {
> + src = (const unsigned long *)ice_ptypes_gtpu;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_L2TPV3) {
> + src = (const unsigned long *)ice_ptypes_l2tpv3;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_ESP) {
> + src = (const unsigned long *)ice_ptypes_esp;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_AH) {
> + src = (const unsigned long *)ice_ptypes_ah;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_NAT_T_ESP) {
> + src = (const unsigned long *)ice_ptypes_nat_t_esp;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + }
> +
> + if (hdrs & ICE_FLOW_SEG_HDR_PFCP) {
> + if (hdrs & ICE_FLOW_SEG_HDR_PFCP_NODE)
> + src =
> + (const unsigned long *)ice_ptypes_pfcp_node;
The above 2 lines do not need to be wrapped.
> + else
> + src =
> + (const unsigned long *)ice_ptypes_pfcp_session;
Here as well, no need to wrap
> +
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else {
> + src = (const unsigned long *)ice_ptypes_pfcp_node;
> + bitmap_andnot(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> +
> + src = (const unsigned long *)ice_ptypes_pfcp_session;
> + bitmap_andnot(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> }
> }
>
> @@ -553,6 +787,33 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct
> ice_flow_prof_params *params,
> case ICE_FLOW_FIELD_IDX_SCTP_DST_PORT:
> prot_id = ICE_PROT_SCTP_IL;
> break;
> + case ICE_FLOW_FIELD_IDX_GTPC_TEID:
> + case ICE_FLOW_FIELD_IDX_GTPU_IP_TEID:
> + case ICE_FLOW_FIELD_IDX_GTPU_UP_TEID:
> + case ICE_FLOW_FIELD_IDX_GTPU_DWN_TEID:
> + case ICE_FLOW_FIELD_IDX_GTPU_EH_TEID:
> + case ICE_FLOW_FIELD_IDX_GTPU_EH_QFI:
> + /* GTP is accessed through UDP OF protocol */
> + prot_id = ICE_PROT_UDP_OF;
> + break;
> + case ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID:
> + prot_id = ICE_PROT_PPPOE;
> + break;
> + case ICE_FLOW_FIELD_IDX_PFCP_SEID:
> + prot_id = ICE_PROT_UDP_IL_OR_S;
> + break;
> + case ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID:
> + prot_id = ICE_PROT_L2TPV3;
> + break;
> + case ICE_FLOW_FIELD_IDX_ESP_SPI:
> + prot_id = ICE_PROT_ESP_F;
> + break;
> + case ICE_FLOW_FIELD_IDX_AH_SPI:
> + prot_id = ICE_PROT_ESP_2;
> + break;
> + case ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI:
> + prot_id = ICE_PROT_UDP_IL_OR_S;
> + break;
> case ICE_FLOW_FIELD_IDX_ARP_SIP:
> case ICE_FLOW_FIELD_IDX_ARP_DIP:
> case ICE_FLOW_FIELD_IDX_ARP_SHA:
> @@ -1388,7 +1649,8 @@ ice_flow_set_rss_seg_info(struct ice_flow_seg_info
> *segs, u64 hash_fields,
>
> ICE_FLOW_SET_HDRS(segs, flow_hdr);
>
> - if (segs->hdrs & ~ICE_FLOW_RSS_SEG_HDR_VAL_MASKS)
> + if (segs->hdrs & ~ICE_FLOW_RSS_SEG_HDR_VAL_MASKS &
> + ~ICE_FLOW_RSS_HDRS_INNER_MASK)
> return ICE_ERR_PARAM;
>
> val = (u64)(segs->hdrs & ICE_FLOW_RSS_SEG_HDR_L3_MASKS); diff --
> git a/drivers/net/ethernet/intel/ice/ice_flow.h
> b/drivers/net/ethernet/intel/ice/ice_flow.h
> index 9eaafd5e50e0..04690669dfd7 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> @@ -30,6 +30,80 @@
> #define ICE_HASH_UDP_IPV4 (ICE_FLOW_HASH_IPV4 |
> ICE_FLOW_HASH_UDP_PORT)
> #define ICE_HASH_UDP_IPV6 (ICE_FLOW_HASH_IPV6 |
> ICE_FLOW_HASH_UDP_PORT)
>
> +#define ICE_FLOW_HASH_GTP_TEID \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPC_TEID))
> +
> +#define ICE_FLOW_HASH_GTP_IPV4_TEID \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_GTP_TEID) #define
> +ICE_FLOW_HASH_GTP_IPV6_TEID \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_GTP_TEID)
> +
> +#define ICE_FLOW_HASH_GTP_U_TEID \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID))
> +
> +#define ICE_FLOW_HASH_GTP_U_IPV4_TEID \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_GTP_U_TEID) #define
> +ICE_FLOW_HASH_GTP_U_IPV6_TEID \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_GTP_U_TEID)
> +
> +#define ICE_FLOW_HASH_GTP_U_EH_TEID \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_EH_TEID))
> +
> +#define ICE_FLOW_HASH_GTP_U_EH_QFI \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_EH_QFI))
> +
> +#define ICE_FLOW_HASH_GTP_U_IPV4_EH \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_GTP_U_EH_TEID | \
> + ICE_FLOW_HASH_GTP_U_EH_QFI)
> +#define ICE_FLOW_HASH_GTP_U_IPV6_EH \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_GTP_U_EH_TEID | \
> + ICE_FLOW_HASH_GTP_U_EH_QFI)
> +
> +#define ICE_FLOW_HASH_PPPOE_SESS_ID \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID))
> +
> +#define ICE_FLOW_HASH_PPPOE_SESS_ID_ETH \
> + (ICE_FLOW_HASH_ETH | ICE_FLOW_HASH_PPPOE_SESS_ID) #define
> +ICE_FLOW_HASH_PPPOE_TCP_ID \
> + (ICE_FLOW_HASH_TCP_PORT | ICE_FLOW_HASH_PPPOE_SESS_ID)
> #define
> +ICE_FLOW_HASH_PPPOE_UDP_ID \
> + (ICE_FLOW_HASH_UDP_PORT | ICE_FLOW_HASH_PPPOE_SESS_ID)
> +
> +#define ICE_FLOW_HASH_PFCP_SEID \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_PFCP_SEID))
> +#define ICE_FLOW_HASH_PFCP_IPV4_SEID \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_PFCP_SEID) #define
> +ICE_FLOW_HASH_PFCP_IPV6_SEID \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_PFCP_SEID)
> +
> +#define ICE_FLOW_HASH_L2TPV3_SESS_ID \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID))
> +#define ICE_FLOW_HASH_L2TPV3_IPV4_SESS_ID \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_L2TPV3_SESS_ID) #define
> +ICE_FLOW_HASH_L2TPV3_IPV6_SESS_ID \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_L2TPV3_SESS_ID)
> +
> +#define ICE_FLOW_HASH_ESP_SPI \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI))
> +#define ICE_FLOW_HASH_ESP_IPV4_SPI \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_ESP_SPI) #define
> +ICE_FLOW_HASH_ESP_IPV6_SPI \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_ESP_SPI)
> +
> +#define ICE_FLOW_HASH_AH_SPI \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_AH_SPI))
> +#define ICE_FLOW_HASH_AH_IPV4_SPI \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_AH_SPI) #define
> +ICE_FLOW_HASH_AH_IPV6_SPI \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_AH_SPI)
> +
> +#define ICE_FLOW_HASH_NAT_T_ESP_SPI \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI))
> +#define ICE_FLOW_HASH_NAT_T_ESP_IPV4_SPI \
> + (ICE_FLOW_HASH_IPV4 | ICE_FLOW_HASH_NAT_T_ESP_SPI) #define
> +ICE_FLOW_HASH_NAT_T_ESP_IPV6_SPI \
> + (ICE_FLOW_HASH_IPV6 | ICE_FLOW_HASH_NAT_T_ESP_SPI)
> +
> /* Protocol header fields within a packet segment. A segment consists of one
> or
> * more protocol headers that make up a logical group of protocol headers.
> Each
> * logical group of protocol headers encapsulates or is encapsulated using/by
> @@ -48,8 +122,37 @@ enum ice_flow_seg_hdr {
> ICE_FLOW_SEG_HDR_UDP = 0x00000080,
> ICE_FLOW_SEG_HDR_SCTP = 0x00000100,
> ICE_FLOW_SEG_HDR_GRE = 0x00000200,
> + ICE_FLOW_SEG_HDR_GTPC = 0x00000400,
> + ICE_FLOW_SEG_HDR_GTPC_TEID = 0x00000800,
> + ICE_FLOW_SEG_HDR_GTPU_IP = 0x00001000,
> + ICE_FLOW_SEG_HDR_GTPU_EH = 0x00002000,
> + ICE_FLOW_SEG_HDR_GTPU_DWN = 0x00004000,
> + ICE_FLOW_SEG_HDR_GTPU_UP = 0x00008000,
> + ICE_FLOW_SEG_HDR_PPPOE = 0x00010000,
> + ICE_FLOW_SEG_HDR_PFCP_NODE = 0x00020000,
> + ICE_FLOW_SEG_HDR_PFCP_SESSION = 0x00040000,
> + ICE_FLOW_SEG_HDR_L2TPV3 = 0x00080000,
> + ICE_FLOW_SEG_HDR_ESP = 0x00100000,
> + ICE_FLOW_SEG_HDR_AH = 0x00200000,
> + ICE_FLOW_SEG_HDR_NAT_T_ESP = 0x00400000,
> };
>
> +/* These segements all have the same PTYPES, but are otherwise
> +distinguished by
> + * the value of the gtp_eh_pdu and gtp_eh_pdu_link flags:
> + *
> + * gtp_eh_pdu gtp_eh_pdu_link
> + * ICE_FLOW_SEG_HDR_GTPU_IP 0 0
> + * ICE_FLOW_SEG_HDR_GTPU_EH 1 don't care
> + * ICE_FLOW_SEG_HDR_GTPU_DWN 1 0
> + * ICE_FLOW_SEG_HDR_GTPU_UP 1 1
> + */
> +#define ICE_FLOW_SEG_HDR_GTPU (ICE_FLOW_SEG_HDR_GTPU_IP | \
> + ICE_FLOW_SEG_HDR_GTPU_EH | \
> + ICE_FLOW_SEG_HDR_GTPU_DWN | \
> + ICE_FLOW_SEG_HDR_GTPU_UP)
> +#define ICE_FLOW_SEG_HDR_PFCP (ICE_FLOW_SEG_HDR_PFCP_NODE | \
> + ICE_FLOW_SEG_HDR_PFCP_SESSION)
> +
> enum ice_flow_field {
> /* L2 */
> ICE_FLOW_FIELD_IDX_ETH_DA,
> @@ -87,7 +190,30 @@ enum ice_flow_field {
> ICE_FLOW_FIELD_IDX_ICMP_CODE,
> /* GRE */
> ICE_FLOW_FIELD_IDX_GRE_KEYID,
> - /* The total number of enums must not exceed 64 */
> + /* GTPC_TEID */
> + ICE_FLOW_FIELD_IDX_GTPC_TEID,
> + /* GTPU_IP */
> + ICE_FLOW_FIELD_IDX_GTPU_IP_TEID,
> + /* GTPU_EH */
> + ICE_FLOW_FIELD_IDX_GTPU_EH_TEID,
> + ICE_FLOW_FIELD_IDX_GTPU_EH_QFI,
> + /* GTPU_UP */
> + ICE_FLOW_FIELD_IDX_GTPU_UP_TEID,
> + /* GTPU_DWN */
> + ICE_FLOW_FIELD_IDX_GTPU_DWN_TEID,
> + /* PPPOE */
> + ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID,
> + /* PFCP */
> + ICE_FLOW_FIELD_IDX_PFCP_SEID,
> + /* L2TPV3 */
> + ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID,
> + /* ESP */
> + ICE_FLOW_FIELD_IDX_ESP_SPI,
> + /* AH */
> + ICE_FLOW_FIELD_IDX_AH_SPI,
> + /* NAT_T ESP */
> + ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI,
> + /* The total number of enums must not exceed 64 */
> ICE_FLOW_FIELD_IDX_MAX
> };
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> index fac5f15a692c..199aa5b71540 100644
> --- a/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_protocol_type.h
> @@ -24,9 +24,13 @@ enum ice_prot_id {
> ICE_PROT_UDP_OF = 52,
> ICE_PROT_UDP_IL_OR_S = 53,
> ICE_PROT_GRE_OF = 64,
> + ICE_PROT_ESP_F = 88,
> + ICE_PROT_ESP_2 = 89,
> ICE_PROT_SCTP_IL = 96,
> ICE_PROT_ICMP_IL = 98,
> ICE_PROT_ICMPV6_IL = 100,
> + ICE_PROT_PPPOE = 103,
> + ICE_PROT_L2TPV3 = 104,
> ICE_PROT_ARP_OF = 118,
> ICE_PROT_META_ID = 255, /* when offset == metadata */
> ICE_PROT_INVALID = 255 /* when offset == ICE_FV_OFFSET_INVAL
> */
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 05/14] ice: Support to separate GTP-U uplink and downlink
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (3 preceding siblings ...)
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 04/14] ice: Add more advanced protocol support in flow filter Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 06/14] ice: enhanced IPV4 and IPV6 flow filter Qi Zhang
` (9 subsequent siblings)
14 siblings, 0 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
To apply different inputset for GTP-U packet with or without extend
header as well as GTP-U uplink and downlink, we need to add TCAM mask
matching capability. This allows comprehending different PTYPE
attributes by examining flags from the parser. Using this method,
different profiles can be used by examining flag values from the parser.
Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 102 ++++++++++++++++++++++---
drivers/net/ethernet/intel/ice/ice_flex_pipe.h | 1 +
drivers/net/ethernet/intel/ice/ice_flex_type.h | 61 +++++++++++++++
drivers/net/ethernet/intel/ice/ice_flow.c | 88 ++++++++++++++++++++-
4 files changed, 242 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
index e2b32f67e061..f22326b6d47b 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
@@ -2553,20 +2553,22 @@ static bool ice_tcam_ent_rsrc_type(enum ice_block blk, u16 *rsrc_type)
* ice_alloc_tcam_ent - allocate hardware TCAM entry
* @hw: pointer to the HW struct
* @blk: the block to allocate the TCAM for
+ * @btm: true to allocate from bottom of table, false to allocate from top
* @tcam_idx: pointer to variable to receive the TCAM entry
*
* This function allocates a new entry in a Profile ID TCAM for a specific
* block.
*/
static enum ice_status
-ice_alloc_tcam_ent(struct ice_hw *hw, enum ice_block blk, u16 *tcam_idx)
+ice_alloc_tcam_ent(struct ice_hw *hw, enum ice_block blk, bool btm,
+ u16 *tcam_idx)
{
u16 res_type;
if (!ice_tcam_ent_rsrc_type(blk, &res_type))
return ICE_ERR_PARAM;
- return ice_alloc_hw_res(hw, res_type, 1, true, tcam_idx);
+ return ice_alloc_hw_res(hw, res_type, 1, btm, tcam_idx);
}
/**
@@ -4157,12 +4159,67 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)
return 0;
}
+/* The entries here needs to match the order of enum ice_ptype_attrib */
+static const struct ice_ptype_attrib_info ice_ptype_attributes[] = {
+ { ICE_GTP_PDU_EH, ICE_GTP_PDU_FLAG_MASK },
+ { ICE_GTP_SESSION, ICE_GTP_FLAGS_MASK },
+ { ICE_GTP_DOWNLINK, ICE_GTP_FLAGS_MASK },
+ { ICE_GTP_UPLINK, ICE_GTP_FLAGS_MASK },
+};
+
+/**
+ * ice_get_ptype_attrib_info - get ptype attribute information
+ * @type: attribute type
+ * @info: pointer to variable to the attribute information
+ */
+static void
+ice_get_ptype_attrib_info(enum ice_ptype_attrib_type type,
+ struct ice_ptype_attrib_info *info)
+{
+ *info = ice_ptype_attributes[type];
+}
+
+/**
+ * ice_add_prof_attrib - add any PTG with attributes to profile
+ * @prof: pointer to the profile to which PTG entries will be added
+ * @ptg: PTG to be added
+ * @ptype: PTYPE that needs to be looked up
+ * @attr: array of attributes that will be considered
+ * @attr_cnt: number of elements in the attribute array
+ */
+static enum ice_status
+ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, u16 ptype,
+ const struct ice_ptype_attributes *attr, u16 attr_cnt)
+{
+ bool found = false;
+ u16 i;
+
+ for (i = 0; i < attr_cnt; i++)
+ if (attr[i].ptype == ptype) {
+ found = true;
+
+ prof->ptg[prof->ptg_cnt] = ptg;
+ ice_get_ptype_attrib_info(attr[i].attrib,
+ &prof->attr[prof->ptg_cnt]);
+
+ if (++prof->ptg_cnt >= ICE_MAX_PTG_PER_PROFILE)
+ return ICE_ERR_MAX_LIMIT;
+ }
+
+ if (!found)
+ return ICE_ERR_DOES_NOT_EXIST;
+
+ return 0;
+}
+
/**
* ice_add_prof - add profile
* @hw: pointer to the HW struct
* @blk: hardware block
* @id: profile tracking ID
* @ptypes: array of bitmaps indicating ptypes (ICE_FLOW_PTYPE_MAX bits)
+ * @attr: array of attributes
+ * @attr_cnt: number of elements in attrib array
* @es: extraction sequence (length of array is determined by the block)
* @masks: mask for extraction sequence
*
@@ -4173,6 +4230,7 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)
*/
enum ice_status
ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
+ const struct ice_ptype_attributes *attr, u16 attr_cnt,
struct ice_fv_word *es, u16 *masks)
{
u32 bytes = DIV_ROUND_UP(ICE_FLOW_PTYPE_MAX, BITS_PER_BYTE);
@@ -4257,10 +4315,25 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
continue;
set_bit(ptg, ptgs_used);
- prof->ptg[prof->ptg_cnt] = ptg;
-
- if (++prof->ptg_cnt >= ICE_MAX_PTG_PER_PROFILE)
+ /* Check to see there are any attributes for
+ * this ptype, and add them if found.
+ */
+ status = ice_add_prof_attrib(prof, ptg, ptype,
+ attr, attr_cnt);
+ if (status == ICE_ERR_MAX_LIMIT)
break;
+ if (status) {
+ /* This is simple a ptype/PTG with no
+ * attribute
+ */
+ prof->ptg[prof->ptg_cnt] = ptg;
+ prof->attr[prof->ptg_cnt].flags = 0;
+ prof->attr[prof->ptg_cnt].mask = 0;
+
+ if (++prof->ptg_cnt >=
+ ICE_MAX_PTG_PER_PROFILE)
+ break;
+ }
/* nothing left in byte, then exit */
m = ~(u8)((1 << (bit + 1)) - 1);
@@ -4783,7 +4856,12 @@ ice_prof_tcam_ena_dis(struct ice_hw *hw, enum ice_block blk, bool enable,
}
/* for re-enabling, reallocate a TCAM */
- status = ice_alloc_tcam_ent(hw, blk, &tcam->tcam_idx);
+ /* for entries with empty attribute masks, allocate entry from
+ * the bottom of the tcam table; otherwise, allocate from the
+ * top of the table in order to give it higher priority
+ */
+ status = ice_alloc_tcam_ent(hw, blk, tcam->attr.mask == 0,
+ &tcam->tcam_idx);
if (status)
return status;
@@ -4793,8 +4871,8 @@ ice_prof_tcam_ena_dis(struct ice_hw *hw, enum ice_block blk, bool enable,
return ICE_ERR_NO_MEMORY;
status = ice_tcam_write_entry(hw, blk, tcam->tcam_idx, tcam->prof_id,
- tcam->ptg, vsig, 0, 0, vl_msk, dc_msk,
- nm_msk);
+ tcam->ptg, vsig, 0, tcam->attr.flags,
+ vl_msk, dc_msk, nm_msk);
if (status)
goto err_ice_prof_tcam_ena_dis;
@@ -4937,7 +5015,12 @@ ice_add_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig, u64 hdl,
goto err_ice_add_prof_id_vsig;
/* allocate the TCAM entry index */
- status = ice_alloc_tcam_ent(hw, blk, &tcam_idx);
+ /* for entries with empty attribute masks, allocate entry from
+ * the bottom of the tcam table; otherwise, allocate from the
+ * top of the table in order to give it higher priority
+ */
+ status = ice_alloc_tcam_ent(hw, blk, map->attr[i].mask == 0,
+ &tcam_idx);
if (status) {
devm_kfree(ice_hw_to_dev(hw), p);
goto err_ice_add_prof_id_vsig;
@@ -4946,6 +5029,7 @@ ice_add_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig, u64 hdl,
t->tcam[i].ptg = map->ptg[i];
t->tcam[i].prof_id = map->prof_id;
t->tcam[i].tcam_idx = tcam_idx;
+ t->tcam[i].attr = map->attr[i];
t->tcam[i].in_use = true;
p->type = ICE_TCAM_ADD;
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.h b/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
index ea3f3ef5994a..7c88af314949 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.h
@@ -28,6 +28,7 @@ bool ice_tunnel_port_in_use(struct ice_hw *hw, u16 port, u16 *index);
enum ice_status
ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
+ const struct ice_ptype_attributes *attr, u16 attr_cnt,
struct ice_fv_word *es, u16 *masks);
enum ice_status
ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_type.h b/drivers/net/ethernet/intel/ice/ice_flex_type.h
index e08526f85d46..7cfacc254ff3 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_flex_type.h
@@ -189,6 +189,64 @@ enum ice_sect {
ICE_SECT_COUNT
};
+#define ICE_MAC_IPV4_GTPU_IPV4_FRAG 331
+#define ICE_MAC_IPV4_GTPU_IPV4_PAY 332
+#define ICE_MAC_IPV4_GTPU_IPV4_UDP_PAY 333
+#define ICE_MAC_IPV4_GTPU_IPV4_TCP 334
+#define ICE_MAC_IPV4_GTPU_IPV4_ICMP 335
+#define ICE_MAC_IPV6_GTPU_IPV4_FRAG 336
+#define ICE_MAC_IPV6_GTPU_IPV4_PAY 337
+#define ICE_MAC_IPV6_GTPU_IPV4_UDP_PAY 338
+#define ICE_MAC_IPV6_GTPU_IPV4_TCP 339
+#define ICE_MAC_IPV6_GTPU_IPV4_ICMP 340
+#define ICE_MAC_IPV4_GTPU_IPV6_FRAG 341
+#define ICE_MAC_IPV4_GTPU_IPV6_PAY 342
+#define ICE_MAC_IPV4_GTPU_IPV6_UDP_PAY 343
+#define ICE_MAC_IPV4_GTPU_IPV6_TCP 344
+#define ICE_MAC_IPV4_GTPU_IPV6_ICMPV6 345
+#define ICE_MAC_IPV6_GTPU_IPV6_FRAG 346
+#define ICE_MAC_IPV6_GTPU_IPV6_PAY 347
+#define ICE_MAC_IPV6_GTPU_IPV6_UDP_PAY 348
+#define ICE_MAC_IPV6_GTPU_IPV6_TCP 349
+#define ICE_MAC_IPV6_GTPU_IPV6_ICMPV6 350
+
+/* Attributes that can modify PTYPE definitions.
+ *
+ * These values will represent special attributes for PTYPES, which will
+ * resolve into metadata packet flags definitions that can be used in the TCAM
+ * for identifying a PTYPE with specific characteristics.
+ */
+enum ice_ptype_attrib_type {
+ /* GTP PTYPES */
+ ICE_PTYPE_ATTR_GTP_PDU_EH,
+ ICE_PTYPE_ATTR_GTP_SESSION,
+ ICE_PTYPE_ATTR_GTP_DOWNLINK,
+ ICE_PTYPE_ATTR_GTP_UPLINK,
+};
+
+struct ice_ptype_attrib_info {
+ u16 flags;
+ u16 mask;
+};
+
+/* TCAM flag definitions */
+#define ICE_GTP_PDU BIT(14)
+#define ICE_GTP_PDU_LINK BIT(13)
+
+/* GTP attributes */
+#define ICE_GTP_PDU_FLAG_MASK (ICE_GTP_PDU)
+#define ICE_GTP_PDU_EH ICE_GTP_PDU
+
+#define ICE_GTP_FLAGS_MASK (ICE_GTP_PDU | ICE_GTP_PDU_LINK)
+#define ICE_GTP_SESSION 0
+#define ICE_GTP_DOWNLINK ICE_GTP_PDU
+#define ICE_GTP_UPLINK (ICE_GTP_PDU | ICE_GTP_PDU_LINK)
+
+struct ice_ptype_attributes {
+ u16 ptype;
+ enum ice_ptype_attrib_type attrib;
+};
+
/* package labels */
struct ice_label {
__le16 value;
@@ -373,12 +431,14 @@ struct ice_prof_map {
u8 prof_id;
u8 ptg_cnt;
u8 ptg[ICE_MAX_PTG_PER_PROFILE];
+ struct ice_ptype_attrib_info attr[ICE_MAX_PTG_PER_PROFILE];
};
#define ICE_INVALID_TCAM 0xFFFF
struct ice_tcam_inf {
u16 tcam_idx;
+ struct ice_ptype_attrib_info attr;
u8 ptg;
u8 prof_id;
u8 in_use;
@@ -530,6 +590,7 @@ struct ice_chs_chg {
u16 vsig;
u16 orig_vsig;
u16 tcam_idx;
+ struct ice_ptype_attrib_info attr;
};
#define ICE_FLOW_PTYPE_MAX ICE_XLT1_CNT
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index 094e1ec82cb6..ba11b9e98f85 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -330,6 +330,76 @@ static const u32 ice_ptypes_gtpc_tid[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
+/* Packet types for GTPU */
+static const struct ice_ptype_attributes ice_attr_gtpu_eh[] = {
+ { ICE_MAC_IPV4_GTPU_IPV4_FRAG, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV4_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV4_UDP_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV4_TCP, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV4_ICMP, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV4_FRAG, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV4_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV4_UDP_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV4_TCP, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV4_ICMP, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV6_FRAG, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV6_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV6_UDP_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV6_TCP, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV4_GTPU_IPV6_ICMPV6, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV6_FRAG, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV6_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV6_UDP_PAY, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV6_TCP, ICE_PTYPE_ATTR_GTP_PDU_EH },
+ { ICE_MAC_IPV6_GTPU_IPV6_ICMPV6, ICE_PTYPE_ATTR_GTP_PDU_EH },
+};
+
+static const struct ice_ptype_attributes ice_attr_gtpu_down[] = {
+ { ICE_MAC_IPV4_GTPU_IPV4_FRAG, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_UDP_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_TCP, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_ICMP, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_FRAG, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_UDP_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_TCP, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_ICMP, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_FRAG, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_UDP_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_TCP, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_ICMPV6, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_FRAG, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_UDP_PAY, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_TCP, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_ICMPV6, ICE_PTYPE_ATTR_GTP_DOWNLINK },
+};
+
+static const struct ice_ptype_attributes ice_attr_gtpu_up[] = {
+ { ICE_MAC_IPV4_GTPU_IPV4_FRAG, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_UDP_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_TCP, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV4_ICMP, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_FRAG, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_UDP_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_TCP, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV4_ICMP, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_FRAG, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_UDP_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_TCP, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV4_GTPU_IPV6_ICMPV6, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_FRAG, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_UDP_PAY, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_TCP, ICE_PTYPE_ATTR_GTP_UPLINK },
+ { ICE_MAC_IPV6_GTPU_IPV6_ICMPV6, ICE_PTYPE_ATTR_GTP_UPLINK },
+};
+
static const u32 ice_ptypes_gtpu[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
@@ -436,6 +506,9 @@ struct ice_flow_prof_params {
* This will give us the direction flags.
*/
struct ice_fv_word es[ICE_MAX_FV_WORDS];
+ /* attributes can be used to add attributes to a particular PTYPE */
+ const struct ice_ptype_attributes *attr;
+ u16 attr_cnt;
u16 mask[ICE_MAX_FV_WORDS];
DECLARE_BITMAP(ptypes, ICE_FLOW_PTYPE_MAX);
@@ -631,14 +704,26 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
src = (const unsigned long *)ice_ptypes_gtpu;
bitmap_and(params->ptypes, params->ptypes, src,
ICE_FLOW_PTYPE_MAX);
+
+ /* Attributes for GTP packet with downlink */
+ params->attr = ice_attr_gtpu_down;
+ params->attr_cnt = ARRAY_SIZE(ice_attr_gtpu_down);
} else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_UP) {
src = (const unsigned long *)ice_ptypes_gtpu;
bitmap_and(params->ptypes, params->ptypes, src,
ICE_FLOW_PTYPE_MAX);
+
+ /* Attributes for GTP packet with uplink */
+ params->attr = ice_attr_gtpu_up;
+ params->attr_cnt = ARRAY_SIZE(ice_attr_gtpu_up);
} else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_EH) {
src = (const unsigned long *)ice_ptypes_gtpu;
bitmap_and(params->ptypes, params->ptypes, src,
ICE_FLOW_PTYPE_MAX);
+
+ /* Attributes for GTP packet with Extension Header */
+ params->attr = ice_attr_gtpu_eh;
+ params->attr_cnt = ARRAY_SIZE(ice_attr_gtpu_eh);
} else if (hdrs & ICE_FLOW_SEG_HDR_GTPU_IP) {
src = (const unsigned long *)ice_ptypes_gtpu;
bitmap_and(params->ptypes, params->ptypes, src,
@@ -1203,7 +1288,8 @@ ice_flow_add_prof_sync(struct ice_hw *hw, enum ice_block blk,
/* Add a HW profile for this flow profile */
status = ice_add_prof(hw, blk, prof_id, (u8 *)params.ptypes,
- params.es, params.mask);
+ params.attr, params.attr_cnt, params.es,
+ params.mask);
if (status) {
ice_debug(hw, ICE_DBG_FLOW, "Error adding a HW flow profile\n");
goto out;
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 06/14] ice: enhanced IPV4 and IPV6 flow filter
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (4 preceding siblings ...)
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 05/14] ice: Support to separate GTP-U uplink and downlink Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-03 5:02 ` Kirsher, Jeffrey T
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF Qi Zhang
` (8 subsequent siblings)
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
Seperate IPv4 and IPv6 ptype bit mask table into 2 tables:
Without or without L4 protocols.
When a flow filter without any l4 type is specified, the
ICE_FLOW_SEG_HDR_IPV_OTHER flag can be used to describe if user
want to create a IP rule target for all IP packet or just IP
packet without l4 header.
Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flow.c | 113 ++++++++++++++++++++++++++++--
drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++
2 files changed, 113 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index ba11b9e98f85..f7eeb31f8b22 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -156,7 +156,9 @@ static const u32 ice_ptypes_macvlan_il[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
-/* Packet types for packets with an Outer/First/Single IPv4 header */
+/* Packet types for packets with an Outer/First/Single IPv4 header, does NOT
+ * include IPV4 other PTYPEs
+ */
static const u32 ice_ptypes_ipv4_ofos[] = {
0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
0x00000000, 0x00000155, 0x00000000, 0x00000000,
@@ -166,6 +168,18 @@ static const u32 ice_ptypes_ipv4_ofos[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Outer/First/Single IPv4 header, includes
+ * IPV4 other PTYPEs
+ */
+static const u32 ice_ptypes_ipv4_ofos_all[] = {
+ 0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000155, 0x00000000, 0x00000000,
+ 0x00000000, 0x000FC000, 0x83E0F800, 0x00000101,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
@@ -182,7 +196,9 @@ static const u32 ice_ptypes_ipv4_il[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
-/* Packet types for packets with an Outer/First/Single IPv6 header */
+/* Packet types for packets with an Outer/First/Single IPv6 header, does NOT
+ * include IVP6 other PTYPEs
+ */
static const u32 ice_ptypes_ipv6_ofos[] = {
0x00000000, 0x00000000, 0x77000000, 0x10002000,
0x00000000, 0x000002AA, 0x00000000, 0x00000000,
@@ -192,6 +208,18 @@ static const u32 ice_ptypes_ipv6_ofos[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Outer/First/Single IPv6 header, includes
+ * IPV6 other PTYPEs
+ */
+static const u32 ice_ptypes_ipv6_ofos_all[] = {
+ 0x00000000, 0x00000000, 0x77000000, 0x10002000,
+ 0x00000000, 0x000002AA, 0x00000000, 0x00000000,
+ 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
@@ -208,6 +236,54 @@ static const u32 ice_ptypes_ipv6_il[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
+/* Packet types for packets with an Outer/First/Single IPv4 header - no L4 */
+static const u32 ice_ipv4_ofos_no_l4[] = {
+ 0x10C00000, 0x04000800, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Innermost/Last IPv4 header - no L4 */
+static const u32 ice_ipv4_il_no_l4[] = {
+ 0x60000000, 0x18043008, 0x80000002, 0x6010c021,
+ 0x00000008, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Outer/First/Single IPv6 header - no L4 */
+static const u32 ice_ipv6_ofos_no_l4[] = {
+ 0x00000000, 0x00000000, 0x43000000, 0x10002000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
+/* Packet types for packets with an Innermost/Last IPv6 header - no L4 */
+static const u32 ice_ipv6_il_no_l4[] = {
+ 0x00000000, 0x02180430, 0x0000010c, 0x086010c0,
+ 0x00000430, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
/* Packet types for packets with an Outermost/First ARP header */
static const u32 ice_ptypes_arp_of[] = {
0x00000800, 0x00000000, 0x00000000, 0x00000000,
@@ -529,6 +605,9 @@ struct ice_flow_prof_params {
#define ICE_FLOW_SEG_HDRS_L4_MASK \
(ICE_FLOW_SEG_HDR_ICMP | ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP | \
ICE_FLOW_SEG_HDR_SCTP)
+/* mask for L4 protocols that are NOT part of IPV4/6 OTHER PTYPE groups */
+#define ICE_FLOW_SEG_HDRS_L4_MASK_NO_OTHER \
+ (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP | ICE_FLOW_SEG_HDR_SCTP)
/**
* ice_flow_val_hdrs - validates packet segments for valid protocol headers
@@ -645,11 +724,37 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
ICE_FLOW_PTYPE_MAX);
}
- if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
+ if ((hdrs & ICE_FLOW_SEG_HDR_IPV4) &&
+ (hdrs & ICE_FLOW_SEG_HDR_IPV_OTHER)) {
+ src = i ?
+ (const unsigned long *)ice_ptypes_ipv4_il :
+ (const unsigned long *)ice_ptypes_ipv4_ofos_all;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if ((hdrs & ICE_FLOW_SEG_HDR_IPV6) &&
+ (hdrs & ICE_FLOW_SEG_HDR_IPV_OTHER)) {
+ src = i ?
+ (const unsigned long *)ice_ptypes_ipv6_il :
+ (const unsigned long *)ice_ptypes_ipv6_ofos_all;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if ((hdrs & ICE_FLOW_SEG_HDR_IPV4) &&
+ !(hdrs & ICE_FLOW_SEG_HDRS_L4_MASK_NO_OTHER)) {
+ src = !i ? (const unsigned long *)ice_ipv4_ofos_no_l4 :
+ (const unsigned long *)ice_ipv4_il_no_l4;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
src = !i ? (const unsigned long *)ice_ptypes_ipv4_ofos :
(const unsigned long *)ice_ptypes_ipv4_il;
bitmap_and(params->ptypes, params->ptypes, src,
ICE_FLOW_PTYPE_MAX);
+ } else if ((hdrs & ICE_FLOW_SEG_HDR_IPV6) &&
+ !(hdrs & ICE_FLOW_SEG_HDRS_L4_MASK_NO_OTHER)) {
+ src = !i ? (const unsigned long *)ice_ipv6_ofos_no_l4 :
+ (const unsigned long *)ice_ipv6_il_no_l4;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
} else if (hdrs & ICE_FLOW_SEG_HDR_IPV6) {
src = !i ? (const unsigned long *)ice_ptypes_ipv6_ofos :
(const unsigned long *)ice_ptypes_ipv6_il;
@@ -1736,7 +1841,7 @@ ice_flow_set_rss_seg_info(struct ice_flow_seg_info *segs, u64 hash_fields,
ICE_FLOW_SET_HDRS(segs, flow_hdr);
if (segs->hdrs & ~ICE_FLOW_RSS_SEG_HDR_VAL_MASKS &
- ~ICE_FLOW_RSS_HDRS_INNER_MASK)
+ ~ICE_FLOW_RSS_HDRS_INNER_MASK & ~ICE_FLOW_SEG_HDR_IPV_OTHER)
return ICE_ERR_PARAM;
val = (u64)(segs->hdrs & ICE_FLOW_RSS_SEG_HDR_L3_MASKS);
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 04690669dfd7..68d1ec7cf8fd 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -135,6 +135,10 @@ enum ice_flow_seg_hdr {
ICE_FLOW_SEG_HDR_ESP = 0x00100000,
ICE_FLOW_SEG_HDR_AH = 0x00200000,
ICE_FLOW_SEG_HDR_NAT_T_ESP = 0x00400000,
+ /* The following is an additive bit for ICE_FLOW_SEG_HDR_IPV4 and
+ * ICE_FLOW_SEG_HDR_IPV6 which include the IPV4 other PTYPEs
+ */
+ ICE_FLOW_SEG_HDR_IPV_OTHER = 0x20000000,
};
/* These segements all have the same PTYPES, but are otherwise distinguished by
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 06/14] ice: enhanced IPV4 and IPV6 flow filter
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 06/14] ice: enhanced IPV4 and IPV6 flow filter Qi Zhang
@ 2020-07-03 5:02 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:02 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 06/14] ice: enhanced IPV4 and IPV6
> flow filter
>
> Seperate IPv4 and IPv6 ptype bit mask table into 2 tables:
> Without or without L4 protocols.
>
> When a flow filter without any l4 type is specified, the
> ICE_FLOW_SEG_HDR_IPV_OTHER flag can be used to describe if user want to
> create a IP rule target for all IP packet or just IP packet without l4 header.
>
> Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_flow.c | 113
> ++++++++++++++++++++++++++++--
> drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++
> 2 files changed, 113 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c
> b/drivers/net/ethernet/intel/ice/ice_flow.c
> index ba11b9e98f85..f7eeb31f8b22 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.c
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.c
> @@ -156,7 +156,9 @@ static const u32 ice_ptypes_macvlan_il[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> -/* Packet types for packets with an Outer/First/Single IPv4 header */
> +/* Packet types for packets with an Outer/First/Single IPv4 header,
> +does NOT
> + * include IPV4 other PTYPEs
> + */
> static const u32 ice_ptypes_ipv4_ofos[] = {
> 0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
> 0x00000000, 0x00000155, 0x00000000, 0x00000000, @@ -166,6
> +168,18 @@ static const u32 ice_ptypes_ipv4_ofos[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> +};
> +
> +/* Packet types for packets with an Outer/First/Single IPv4 header,
> +includes
> + * IPV4 other PTYPEs
> + */
> +static const u32 ice_ptypes_ipv4_ofos_all[] = {
> + 0x1DC00000, 0x04000800, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000155, 0x00000000, 0x00000000,
> + 0x00000000, 0x000FC000, 0x83E0F800, 0x00000101,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, }; @@ -182,7
> +196,9 @@ static const u32 ice_ptypes_ipv4_il[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> -/* Packet types for packets with an Outer/First/Single IPv6 header */
> +/* Packet types for packets with an Outer/First/Single IPv6 header,
> +does NOT
> + * include IVP6 other PTYPEs
> + */
> static const u32 ice_ptypes_ipv6_ofos[] = {
> 0x00000000, 0x00000000, 0x77000000, 0x10002000,
> 0x00000000, 0x000002AA, 0x00000000, 0x00000000, @@ -192,6
> +208,18 @@ static const u32 ice_ptypes_ipv6_ofos[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> +};
> +
> +/* Packet types for packets with an Outer/First/Single IPv6 header,
> +includes
> + * IPV6 other PTYPEs
> + */
> +static const u32 ice_ptypes_ipv6_ofos_all[] = {
> + 0x00000000, 0x00000000, 0x77000000, 0x10002000,
> + 0x00000000, 0x000002AA, 0x00000000, 0x00000000,
> + 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, }; @@ -208,6
> +236,54 @@ static const u32 ice_ptypes_ipv6_il[] = {
> 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
>
> +/* Packet types for packets with an Outer/First/Single IPv4 header - no
> +L4 */ static const u32 ice_ipv4_ofos_no_l4[] = {
> + 0x10C00000, 0x04000800, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with an Innermost/Last IPv4 header - no L4
> +*/ static const u32 ice_ipv4_il_no_l4[] = {
> + 0x60000000, 0x18043008, 0x80000002, 0x6010c021,
> + 0x00000008, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with an Outer/First/Single IPv6 header - no
> +L4 */ static const u32 ice_ipv6_ofos_no_l4[] = {
> + 0x00000000, 0x00000000, 0x43000000, 0x10002000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> +/* Packet types for packets with an Innermost/Last IPv6 header - no L4
> +*/ static const u32 ice_ipv6_il_no_l4[] = {
> + 0x00000000, 0x02180430, 0x0000010c, 0x086010c0,
> + 0x00000430, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> + 0x00000000, 0x00000000, 0x00000000, 0x00000000, };
> +
> /* Packet types for packets with an Outermost/First ARP header */ static
> const u32 ice_ptypes_arp_of[] = {
> 0x00000800, 0x00000000, 0x00000000, 0x00000000, @@ -529,6 +605,9
> @@ struct ice_flow_prof_params {
> #define ICE_FLOW_SEG_HDRS_L4_MASK \
> (ICE_FLOW_SEG_HDR_ICMP | ICE_FLOW_SEG_HDR_TCP |
> ICE_FLOW_SEG_HDR_UDP | \
> ICE_FLOW_SEG_HDR_SCTP)
> +/* mask for L4 protocols that are NOT part of IPV4/6 OTHER PTYPE groups
> */
> +#define ICE_FLOW_SEG_HDRS_L4_MASK_NO_OTHER \
> + (ICE_FLOW_SEG_HDR_TCP | ICE_FLOW_SEG_HDR_UDP |
> ICE_FLOW_SEG_HDR_SCTP)
>
> /**
> * ice_flow_val_hdrs - validates packet segments for valid protocol headers
> @@ -645,11 +724,37 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
> ICE_FLOW_PTYPE_MAX);
> }
>
> - if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
> + if ((hdrs & ICE_FLOW_SEG_HDR_IPV4) &&
> + (hdrs & ICE_FLOW_SEG_HDR_IPV_OTHER)) {
> + src = i ?
> + (const unsigned long *)ice_ptypes_ipv4_il :
> + (const unsigned long *)ice_ptypes_ipv4_ofos_all;
More wrapping issues in the above three lines
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if ((hdrs & ICE_FLOW_SEG_HDR_IPV6) &&
> + (hdrs & ICE_FLOW_SEG_HDR_IPV_OTHER)) {
> + src = i ?
> + (const unsigned long *)ice_ptypes_ipv6_il :
> + (const unsigned long *)ice_ptypes_ipv6_ofos_all;
Here as well
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if ((hdrs & ICE_FLOW_SEG_HDR_IPV4) &&
> + !(hdrs & ICE_FLOW_SEG_HDRS_L4_MASK_NO_OTHER))
> {
> + src = !i ? (const unsigned long *)ice_ipv4_ofos_no_l4 :
> + (const unsigned long *)ice_ipv4_il_no_l4;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> + } else if (hdrs & ICE_FLOW_SEG_HDR_IPV4) {
> src = !i ? (const unsigned long *)ice_ptypes_ipv4_ofos :
> (const unsigned long *)ice_ptypes_ipv4_il;
> bitmap_and(params->ptypes, params->ptypes, src,
> ICE_FLOW_PTYPE_MAX);
> + } else if ((hdrs & ICE_FLOW_SEG_HDR_IPV6) &&
> + !(hdrs & ICE_FLOW_SEG_HDRS_L4_MASK_NO_OTHER))
> {
> + src = !i ? (const unsigned long *)ice_ipv6_ofos_no_l4 :
> + (const unsigned long *)ice_ipv6_il_no_l4;
> + bitmap_and(params->ptypes, params->ptypes, src,
> + ICE_FLOW_PTYPE_MAX);
> } else if (hdrs & ICE_FLOW_SEG_HDR_IPV6) {
> src = !i ? (const unsigned long *)ice_ptypes_ipv6_ofos :
> (const unsigned long *)ice_ptypes_ipv6_il; @@ -
> 1736,7 +1841,7 @@ ice_flow_set_rss_seg_info(struct ice_flow_seg_info *segs,
> u64 hash_fields,
> ICE_FLOW_SET_HDRS(segs, flow_hdr);
>
> if (segs->hdrs & ~ICE_FLOW_RSS_SEG_HDR_VAL_MASKS &
> - ~ICE_FLOW_RSS_HDRS_INNER_MASK)
> + ~ICE_FLOW_RSS_HDRS_INNER_MASK &
> ~ICE_FLOW_SEG_HDR_IPV_OTHER)
> return ICE_ERR_PARAM;
>
> val = (u64)(segs->hdrs & ICE_FLOW_RSS_SEG_HDR_L3_MASKS); diff --
> git a/drivers/net/ethernet/intel/ice/ice_flow.h
> b/drivers/net/ethernet/intel/ice/ice_flow.h
> index 04690669dfd7..68d1ec7cf8fd 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> @@ -135,6 +135,10 @@ enum ice_flow_seg_hdr {
> ICE_FLOW_SEG_HDR_ESP = 0x00100000,
> ICE_FLOW_SEG_HDR_AH = 0x00200000,
> ICE_FLOW_SEG_HDR_NAT_T_ESP = 0x00400000,
> + /* The following is an additive bit for ICE_FLOW_SEG_HDR_IPV4 and
> + * ICE_FLOW_SEG_HDR_IPV6 which include the IPV4 other PTYPEs
> + */
> + ICE_FLOW_SEG_HDR_IPV_OTHER = 0x20000000,
> };
>
> /* These segements all have the same PTYPES, but are otherwise distinguished
> by
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (5 preceding siblings ...)
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 06/14] ice: enhanced IPV4 and IPV6 flow filter Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-03 5:14 ` Kirsher, Jeffrey T
2020-07-03 7:37 ` kernel test robot
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 08/14] ice: Support RSS configure removal " Qi Zhang
` (7 subsequent siblings)
14 siblings, 2 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
The virtual channel is going to be extended to support FDIR and
RSS configure from AVF. New data structures and OP codes will be
added, the patch enable the RSS part.
To support above advanced AVF feature, we need to figure out
what kind of data structure should be passed from VF to PF to describe
an FDIR rule or RSS config rule. The common part of the requirement is
we need a data structure to represent the input set selection of a rule's
hash key.
An input set selection is a group of fields be selected from one or more
network protocol layers that could be identified as a specific flow.
For example, select dst IP address from an IPv4 header combined with
dst port from the TCP header as the input set for an IPv4/TCP flow.
The patch adds a new data structure virtchnl_proto_hdrs to abstract
a network protocol headers group which is composed of layers of network
protocol header(virtchnl_proto_hdr).
A protocol header contains a 32 bits mask (field_selector) to describe
which fields are selected as input sets, as well as a header type
(enum virtchnl_proto_hdr_type). Each bit is mapped to a field in
enum virtchnl_proto_hdr_field guided by its header type.
+------------+-----------+------------------------------+
| | Proto Hdr | Header Type A |
| | +------------------------------+
| | | BIT 31 | ... | BIT 1 | BIT 0 |
| |-----------+------------------------------+
|Proto Hdrs | Proto Hdr | Header Type B |
| | +------------------------------+
| | | BIT 31 | ... | BIT 1 | BIT 0 |
| |-----------+------------------------------+
| | Proto Hdr | Header Type C |
| | +------------------------------+
| | | BIT 31 | ... | BIT 1 | BIT 0 |
| |-----------+------------------------------+
| | .... |
+-------------------------------------------------------+
All fields in enum virtchnl_proto_hdr_fields are grouped with header type
and the value of the first field of a header type is always 32 aligned.
enum proto_hdr_type {
header_type_A = 0;
header_type_B = 1;
....
}
enum proto_hdr_field {
/* header type A */
header_A_field_0 = 0,
header_A_field_1 = 1,
header_A_field_2 = 2,
header_A_field_3 = 3,
/* header type B */
header_B_field_0 = 32, // = header_type_B << 5
header_B_field_0 = 33,
header_B_field_0 = 34
header_B_field_0 = 35,
....
};
So we have:
proto_hdr_type = proto_hdr_field / 32
bit offset = proto_hdr_field % 32
To simply the protocol header's operations, couple help macros are added.
For example, to select src IP and dst port as input set for an IPv4/UDP
flow.
we have:
struct virtchnl_proto_hdr hdr[2];
VIRTCHNL_SET_PROTO_HDR_TYPE(&hdr[0], IPV4)
VIRTCHNL_ADD_PROTO_HDR_FIELD(&hdr[0], IPV4, SRC)
VIRTCHNL_SET_PROTO_HDR_TYPE(&hdr[1], UDP)
VIRTCHNL_ADD_PROTO_HDR_FIELD(&hdr[1], UDP, DST)
A protocol header also contains a byte array, this field should only
be used by an FDIR rule and should be ignored by RSS. For an FDIR rule,
the byte array is used to store the protocol header of a training
package. The byte array must be network order.
Signed-off-by: Jeff Guo <jia.guo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flow.h | 3 +
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 459 +++++++++++++++++++++++
include/linux/avf/virtchnl.h | 187 ++++++++-
3 files changed, 641 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 68d1ec7cf8fd..f3cfcfd2c296 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -8,6 +8,9 @@
#define ICE_FLOW_FLD_OFF_INVAL 0xffff
/* Generate flow hash field from flow field type(s) */
+#define ICE_FLOW_HASH_ETH \
+ (BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA) | \
+ BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA))
#define ICE_FLOW_HASH_IPV4 \
(BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) | \
BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA))
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 8022300f9c8e..ede343016f94 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -5,6 +5,246 @@
#include "ice_base.h"
#include "ice_lib.h"
#include "ice_fltr.h"
+#include "ice_flow.h"
+
+#define FIELD_SELECTOR(proto_hdr_field) \
+ (1UL << ((proto_hdr_field) & PROTO_HDR_FIELD_MASK))
+
+struct ice_vc_hdr_match_type {
+ u32 vc_hdr; /* virtchnl headers (VIRTCHNL_PROTO_HDR_XXX) */
+ u32 ice_hdr; /* ice headers (ICE_FLOW_SEG_HDR_XXX) */
+};
+
+static const struct ice_vc_hdr_match_type ice_vc_hdr_list_os[] = {
+ {VIRTCHNL_PROTO_HDR_NONE, ICE_FLOW_SEG_HDR_NONE},
+ {VIRTCHNL_PROTO_HDR_IPV4, ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER},
+ {VIRTCHNL_PROTO_HDR_IPV6, ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER},
+ {VIRTCHNL_PROTO_HDR_TCP, ICE_FLOW_SEG_HDR_TCP},
+ {VIRTCHNL_PROTO_HDR_UDP, ICE_FLOW_SEG_HDR_UDP},
+ {VIRTCHNL_PROTO_HDR_SCTP, ICE_FLOW_SEG_HDR_SCTP},
+};
+
+static const struct ice_vc_hdr_match_type ice_vc_hdr_list_comms[] = {
+ {VIRTCHNL_PROTO_HDR_NONE, ICE_FLOW_SEG_HDR_NONE},
+ {VIRTCHNL_PROTO_HDR_ETH, ICE_FLOW_SEG_HDR_ETH},
+ {VIRTCHNL_PROTO_HDR_S_VLAN, ICE_FLOW_SEG_HDR_VLAN},
+ {VIRTCHNL_PROTO_HDR_C_VLAN, ICE_FLOW_SEG_HDR_VLAN},
+ {VIRTCHNL_PROTO_HDR_IPV4, ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER},
+ {VIRTCHNL_PROTO_HDR_IPV6, ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER},
+ {VIRTCHNL_PROTO_HDR_TCP, ICE_FLOW_SEG_HDR_TCP},
+ {VIRTCHNL_PROTO_HDR_UDP, ICE_FLOW_SEG_HDR_UDP},
+ {VIRTCHNL_PROTO_HDR_SCTP, ICE_FLOW_SEG_HDR_SCTP},
+ {VIRTCHNL_PROTO_HDR_PPPOE, ICE_FLOW_SEG_HDR_PPPOE},
+ {VIRTCHNL_PROTO_HDR_GTPU_IP, ICE_FLOW_SEG_HDR_GTPU_IP},
+ {VIRTCHNL_PROTO_HDR_GTPU_EH, ICE_FLOW_SEG_HDR_GTPU_EH},
+ {VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN,
+ ICE_FLOW_SEG_HDR_GTPU_DWN},
+ {VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP,
+ ICE_FLOW_SEG_HDR_GTPU_UP},
+ {VIRTCHNL_PROTO_HDR_L2TPV3, ICE_FLOW_SEG_HDR_L2TPV3},
+ {VIRTCHNL_PROTO_HDR_ESP, ICE_FLOW_SEG_HDR_ESP},
+ {VIRTCHNL_PROTO_HDR_AH, ICE_FLOW_SEG_HDR_AH},
+ {VIRTCHNL_PROTO_HDR_PFCP, ICE_FLOW_SEG_HDR_PFCP_SESSION},
+};
+
+struct ice_vc_hash_field_match_type {
+ u32 vc_hdr; /* virtchnl headers
+ * (VIRTCHNL_PROTO_HDR_XXX)
+ */
+ u32 vc_hash_field; /* virtchnl hash fields selector
+ * FIELD_SELECTOR((VIRTCHNL_PROTO_HDR_ETH_XXX))
+ */
+ u64 ice_hash_field; /* ice hash fields
+ * (BIT_ULL(ICE_FLOW_FIELD_IDX_XXX))
+ */
+};
+
+static const struct
+ice_vc_hash_field_match_type ice_vc_hash_field_list_os[] = {
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
+ ICE_FLOW_HASH_IPV4},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ ICE_FLOW_HASH_IPV4 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
+ ICE_FLOW_HASH_IPV6},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ ICE_FLOW_HASH_IPV6 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_TCP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_SRC_PORT)},
+ {VIRTCHNL_PROTO_HDR_TCP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_DST_PORT)},
+ {VIRTCHNL_PROTO_HDR_TCP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
+ ICE_FLOW_HASH_TCP_PORT},
+ {VIRTCHNL_PROTO_HDR_UDP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_SRC_PORT)},
+ {VIRTCHNL_PROTO_HDR_UDP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_DST_PORT)},
+ {VIRTCHNL_PROTO_HDR_UDP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
+ ICE_FLOW_HASH_UDP_PORT},
+ {VIRTCHNL_PROTO_HDR_SCTP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT)},
+ {VIRTCHNL_PROTO_HDR_SCTP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_DST_PORT)},
+ {VIRTCHNL_PROTO_HDR_SCTP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
+ ICE_FLOW_HASH_SCTP_PORT},
+};
+
+static const struct
+ice_vc_hash_field_match_type ice_vc_hash_field_list_comms[] = {
+ {VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA)},
+ {VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA)},
+ {VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST),
+ ICE_FLOW_HASH_ETH},
+ {VIRTCHNL_PROTO_HDR_ETH,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_ETHERTYPE),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_TYPE)},
+ {VIRTCHNL_PROTO_HDR_S_VLAN,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_S_VLAN_ID),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_S_VLAN)},
+ {VIRTCHNL_PROTO_HDR_C_VLAN,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_C_VLAN_ID),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_C_VLAN)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
+ ICE_FLOW_HASH_IPV4},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ ICE_FLOW_HASH_IPV4 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
+ ICE_FLOW_HASH_IPV6},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA) |
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ ICE_FLOW_HASH_IPV6 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_IPV6, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
+ {VIRTCHNL_PROTO_HDR_TCP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_SRC_PORT)},
+ {VIRTCHNL_PROTO_HDR_TCP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_DST_PORT)},
+ {VIRTCHNL_PROTO_HDR_TCP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
+ ICE_FLOW_HASH_TCP_PORT},
+ {VIRTCHNL_PROTO_HDR_UDP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_SRC_PORT)},
+ {VIRTCHNL_PROTO_HDR_UDP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_DST_PORT)},
+ {VIRTCHNL_PROTO_HDR_UDP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
+ ICE_FLOW_HASH_UDP_PORT},
+ {VIRTCHNL_PROTO_HDR_SCTP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT)},
+ {VIRTCHNL_PROTO_HDR_SCTP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_DST_PORT)},
+ {VIRTCHNL_PROTO_HDR_SCTP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT) |
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
+ ICE_FLOW_HASH_SCTP_PORT},
+ {VIRTCHNL_PROTO_HDR_PPPOE,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_PPPOE_SESS_ID),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID)},
+ {VIRTCHNL_PROTO_HDR_GTPU_IP,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_GTPU_IP_TEID),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID)},
+ {VIRTCHNL_PROTO_HDR_L2TPV3,
+ FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_L2TPV3_SESS_ID),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID)},
+ {VIRTCHNL_PROTO_HDR_ESP, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ESP_SPI),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI)},
+ {VIRTCHNL_PROTO_HDR_AH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_AH_SPI),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_AH_SPI)},
+ {VIRTCHNL_PROTO_HDR_PFCP, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_PFCP_SEID),
+ BIT_ULL(ICE_FLOW_FIELD_IDX_PFCP_SEID)},
+};
/**
* ice_validate_vf_id - helper to check if VF ID is valid
@@ -2009,6 +2249,9 @@ static int ice_vc_get_vf_res_msg(struct ice_vf *vf, u8 *msg)
if (vf->driver_caps & VIRTCHNL_VF_CAP_ADV_LINK_SPEED)
vfres->vf_cap_flags |= VIRTCHNL_VF_CAP_ADV_LINK_SPEED;
+ if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF)
+ vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF;
+
/* Negotiate DCF capability. */
if (vf->driver_caps & VIRTCHNL_VF_CAP_DCF) {
if (!ice_check_dcf_allowed(vf)) {
@@ -2141,6 +2384,216 @@ static bool ice_vc_isvalid_ring_len(u16 ring_len)
}
/**
+ * ice_vc_parse_rss_cfg - parses hash fields and headers from
+ * a specific virtchnl RSS cfg
+ * @hw: pointer to the hardware
+ * @rss_cfg: pointer to the virtchnl rss cfg
+ * @addl_hdrs: pointer to the protocol header fields (ICE_FLOW_SEG_HDR_*)
+ * to configure
+ * @hash_flds: pointer to the hash bit fields (ICE_FLOW_HASH_*) to configure
+ *
+ * Return true if all the protocol header and hash fields in the rss cfg could
+ * be parsed, else return false
+ *
+ * This function parses the virtchnl rss cfg to be the intended
+ * hash fields and the intended header for RSS configuration
+ */
+static bool
+ice_vc_parse_rss_cfg(struct ice_hw *hw, struct virtchnl_rss_cfg *rss_cfg,
+ u32 *addl_hdrs, u64 *hash_flds)
+{
+ const struct ice_vc_hash_field_match_type *hf_list;
+ const struct ice_vc_hdr_match_type *hdr_list;
+ int i, hf_list_len, hdr_list_len;
+
+ if (!strncmp(hw->active_pkg_name, "ICE COMMS Package",
+ sizeof(hw->active_pkg_name))) {
+ hf_list = ice_vc_hash_field_list_comms;
+ hf_list_len = ARRAY_SIZE(ice_vc_hash_field_list_comms);
+ hdr_list = ice_vc_hdr_list_comms;
+ hdr_list_len = ARRAY_SIZE(ice_vc_hdr_list_comms);
+ } else {
+ hf_list = ice_vc_hash_field_list_os;
+ hf_list_len = ARRAY_SIZE(ice_vc_hash_field_list_os);
+ hdr_list = ice_vc_hdr_list_os;
+ hdr_list_len = ARRAY_SIZE(ice_vc_hdr_list_os);
+ }
+
+ for (i = 0; i < rss_cfg->proto_hdrs.count; i++) {
+ struct virtchnl_proto_hdr *proto_hdr =
+ &rss_cfg->proto_hdrs.proto_hdr[i];
+ bool hdr_found = false;
+ int j;
+
+ /* Find matched ice headers according to virtchnl headers. */
+ for (j = 0; j < hdr_list_len; j++) {
+ struct ice_vc_hdr_match_type hdr_map =
+ hdr_list[j];
+
+ if (proto_hdr->type == hdr_map.vc_hdr) {
+ *addl_hdrs |= hdr_map.ice_hdr;
+ hdr_found = true;
+ }
+ }
+
+ if (!hdr_found)
+ return false;
+
+ /* Find matched ice hash fields according to
+ * virtchnl hash fields.
+ */
+ for (j = 0; j < hf_list_len; j++) {
+ struct ice_vc_hash_field_match_type hf_map =
+ hf_list[j];
+
+ if (proto_hdr->type == hf_map.vc_hdr &&
+ proto_hdr->field_selector ==
+ hf_map.vc_hash_field) {
+ *hash_flds |= hf_map.ice_hash_field;
+ break;
+ }
+ }
+ }
+
+ return true;
+}
+
+/**
+ * ice_vf_adv_rss_offload_ena - determine if capabilities support advanced
+ * rss offloads
+ * @caps: VF driver negotiated capabilities
+ *
+ * Return true if VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability is set,
+ * else return false
+ */
+static bool ice_vf_adv_rss_offload_ena(u32 caps)
+{
+ return !!(caps & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF);
+}
+
+/**
+ * ice_vc_handle_rss_cfg
+ * @vf: pointer to the VF info
+ * @msg: pointer to the msg buffer
+ * @add: add a rss cfg if true, otherwise delete a rss cfg
+ *
+ * This function adds/deletes a rss cfg
+ */
+static int ice_vc_handle_rss_cfg(struct ice_vf *vf, u8 *msg, bool add)
+{
+ struct virtchnl_rss_cfg *rss_cfg = (struct virtchnl_rss_cfg *)msg;
+ enum virtchnl_status_code v_ret = VIRTCHNL_STATUS_SUCCESS;
+ u32 v_opcode = add ? VIRTCHNL_OP_ADD_RSS_CFG :
+ VIRTCHNL_OP_DEL_RSS_CFG;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ struct ice_hw *hw = &vf->pf->hw;
+ struct ice_vsi *vsi;
+
+ if (!test_bit(ICE_FLAG_RSS_ENA, vf->pf->flags)) {
+ dev_dbg(dev, "VF %d attempting to configure RSS, but RSS is not supported by the PF\n",
+ vf->vf_id);
+ v_ret = VIRTCHNL_STATUS_ERR_NOT_SUPPORTED;
+ goto error_param;
+ }
+
+ if (!ice_vf_adv_rss_offload_ena(vf->driver_caps)) {
+ dev_dbg(dev, "VF %d attempting to configure RSS, but Advanced RSS offload is not supported\n",
+ vf->vf_id);
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+
+ if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+
+ if (rss_cfg->proto_hdrs.count > VIRTCHNL_MAX_NUM_PROTO_HDRS ||
+ rss_cfg->rss_algorithm < VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC ||
+ rss_cfg->rss_algorithm > VIRTCHNL_RSS_ALG_XOR_SYMMETRIC) {
+ dev_dbg(dev, "VF %d attempting to configure RSS, but RSS configuration is not valid\n",
+ vf->vf_id);
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+
+ vsi = vf->pf->vsi[vf->lan_vsi_idx];
+ if (!vsi) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+
+ if (rss_cfg->rss_algorithm == VIRTCHNL_RSS_ALG_R_ASYMMETRIC) {
+ struct ice_vsi_ctx *ctx;
+ enum ice_status status;
+ u8 lut_type, hash_type;
+
+ lut_type = ICE_AQ_VSI_Q_OPT_RSS_LUT_VSI;
+ hash_type = add ? ICE_AQ_VSI_Q_OPT_RSS_XOR :
+ ICE_AQ_VSI_Q_OPT_RSS_TPLZ;
+
+ ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
+ if (!ctx) {
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ goto error_param;
+ }
+
+ ctx->info.q_opt_rss = ((lut_type <<
+ ICE_AQ_VSI_Q_OPT_RSS_LUT_S) &
+ ICE_AQ_VSI_Q_OPT_RSS_LUT_M) |
+ (hash_type &
+ ICE_AQ_VSI_Q_OPT_RSS_HASH_M);
+
+ /* Preserve existing queueing option setting */
+ ctx->info.q_opt_rss |= (vsi->info.q_opt_rss &
+ ICE_AQ_VSI_Q_OPT_RSS_GBL_LUT_M);
+ ctx->info.q_opt_tc = vsi->info.q_opt_tc;
+ ctx->info.q_opt_flags = vsi->info.q_opt_rss;
+
+ ctx->info.valid_sections =
+ cpu_to_le16(ICE_AQ_VSI_PROP_Q_OPT_VALID);
+
+ status = ice_update_vsi(hw, vsi->idx, ctx, NULL);
+ if (status) {
+ dev_err(dev,
+ "update VSI for RSS failed, err %s aq_err %s\n",
+ ice_stat_str(status),
+ ice_aq_str(hw->adminq.sq_last_status));
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ } else {
+ vsi->info.q_opt_rss = ctx->info.q_opt_rss;
+ }
+
+ kfree(ctx);
+ } else {
+ u32 addl_hdrs = ICE_FLOW_SEG_HDR_NONE;
+ u64 hash_flds = ICE_HASH_INVALID;
+
+ if (!ice_vc_parse_rss_cfg(hw, rss_cfg, &addl_hdrs,
+ &hash_flds)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ goto error_param;
+ }
+
+ if (add) {
+ if (ice_add_rss_cfg(hw, vsi->idx, hash_flds,
+ addl_hdrs)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ dev_err(dev,
+ "ice_add_rss_cfg failed for vsi = %d, v_ret = %d\n",
+ vsi->vsi_num, v_ret);
+ }
+ } else {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ dev_err(dev, "RSS removal not support\n");
+ }
+ }
+
+error_param:
+ return ice_vc_send_msg_to_vf(vf, v_opcode, v_ret, NULL, 0);
+}
+
+/**
* ice_vc_config_rss_key
* @vf: pointer to the VF info
* @msg: pointer to the msg buffer
@@ -4221,6 +4674,12 @@ void ice_vc_process_vf_msg(struct ice_pf *pf, struct ice_rq_event_info *event)
case VIRTCHNL_OP_DCF_GET_PKG_INFO:
err = ice_vc_dcf_query_pkg_info(vf);
break;
+ case VIRTCHNL_OP_ADD_RSS_CFG:
+ err = ice_vc_handle_rss_cfg(vf, msg, true);
+ break;
+ case VIRTCHNL_OP_DEL_RSS_CFG:
+ err = ice_vc_handle_rss_cfg(vf, msg, false);
+ break;
case VIRTCHNL_OP_UNKNOWN:
default:
dev_err(dev, "Unsupported opcode %d from VF %d\n", v_opcode,
diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
index 825cdc0e9ffe..d7e5263fd2ec 100644
--- a/include/linux/avf/virtchnl.h
+++ b/include/linux/avf/virtchnl.h
@@ -143,6 +143,8 @@ enum virtchnl_ops {
VIRTCHNL_OP_DCF_GET_VSI_MAP = 42,
VIRTCHNL_OP_DCF_GET_PKG_INFO = 43,
VIRTCHNL_OP_GET_SUPPORTED_RXDIDS = 44,
+ VIRTCHNL_OP_ADD_RSS_CFG = 45,
+ VIRTCHNL_OP_DEL_RSS_CFG = 46,
/* New major set of opcodes introduced and so leaving room for
* old misc opcodes to be added in future. Also these opcodes may only
* be used if both the PF and VF have successfully negotiated the
@@ -283,6 +285,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);
#define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000
#define VIRTCHNL_VF_OFFLOAD_ADQ 0X00800000
#define VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC 0X04000000
+#define VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF 0X08000000
#define VIRTCHNL_VF_CAP_DCF 0X40000000
/* Define below the capability flags that are not offloads */
@@ -557,6 +560,14 @@ struct virtchnl_rss_hena {
VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_rss_hena);
+/* Type of RSS algorithm */
+enum virtchnl_rss_algorithm {
+ VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC = 0,
+ VIRTCHNL_RSS_ALG_R_ASYMMETRIC = 1,
+ VIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC = 2,
+ VIRTCHNL_RSS_ALG_XOR_SYMMETRIC = 3,
+};
+
/* VIRTCHNL_OP_ENABLE_CHANNELS
* VIRTCHNL_OP_DISABLE_CHANNELS
* VF sends these messages to enable or disable channels based on
@@ -773,6 +784,170 @@ enum virtchnl_vfr_states {
VIRTCHNL_VFR_VFACTIVE,
};
+#define VIRTCHNL_MAX_NUM_PROTO_HDRS 32
+#define PROTO_HDR_SHIFT 5
+#define PROTO_HDR_FIELD_START(proto_hdr_type) \
+ (proto_hdr_type << PROTO_HDR_SHIFT)
+#define PROTO_HDR_FIELD_MASK ((1UL << PROTO_HDR_SHIFT) - 1)
+
+/* VF use these macros to configure each protocol header.
+ * Specify which protocol headers and protocol header fields base on
+ * virtchnl_proto_hdr_type and virtchnl_proto_hdr_field.
+ * @param hdr: a struct of virtchnl_proto_hdr
+ * @param hdr_type: ETH/IPV4/TCP, etc
+ * @param field: SRC/DST/TEID/SPI, etc
+ */
+#define VIRTCHNL_ADD_PROTO_HDR_FIELD(hdr, field) \
+ ((hdr)->field_selector |= BIT((field) & PROTO_HDR_FIELD_MASK))
+#define VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr, field) \
+ ((hdr)->field_selector &= ~BIT((field) & PROTO_HDR_FIELD_MASK))
+#define VIRTCHNL_TEST_PROTO_HDR_FIELD(hdr, val) \
+ ((hdr)->field_selector & BIT((val) & PROTO_HDR_FIELD_MASK))
+#define VIRTCHNL_GET_PROTO_HDR_FIELD(hdr) ((hdr)->field_selector)
+
+#define VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, hdr_type, field) \
+ (VIRTCHNL_ADD_PROTO_HDR_FIELD(hdr, \
+ VIRTCHNL_PROTO_HDR_ ## hdr_type ## _ ## field))
+#define VIRTCHNL_DEL_PROTO_HDR_FIELD_BIT(hdr, hdr_type, field) \
+ (VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr, \
+ VIRTCHNL_PROTO_HDR_ ## hdr_type ## _ ## field))
+
+#define VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, hdr_type) \
+ ((hdr)->type = VIRTCHNL_PROTO_HDR_ ## hdr_type)
+#define VIRTCHNL_GET_PROTO_HDR_TYPE(hdr) \
+ (((hdr)->type) >> PROTO_HDR_SHIFT)
+#define VIRTCHNL_TEST_PROTO_HDR_TYPE(hdr, val) \
+ ((hdr)->type == ((val) >> PROTO_HDR_SHIFT))
+#define VIRTCHNL_TEST_PROTO_HDR(hdr, val) \
+ (VIRTCHNL_TEST_PROTO_HDR_TYPE(hdr, val) && \
+ VIRTCHNL_TEST_PROTO_HDR_FIELD(hdr, val))
+
+/* Protocol header type within a packet segment. A segment consists of one or
+ * more protocol headers that make up a logical group of protocol headers. Each
+ * logical group of protocol headers encapsulates or is encapsulated using/by
+ * tunneling or encapsulation protocols for network virtualization.
+ */
+enum virtchnl_proto_hdr_type {
+ VIRTCHNL_PROTO_HDR_NONE,
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_S_VLAN,
+ VIRTCHNL_PROTO_HDR_C_VLAN,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_TCP,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_SCTP,
+ VIRTCHNL_PROTO_HDR_GTPU_IP,
+ VIRTCHNL_PROTO_HDR_GTPU_EH,
+ VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN,
+ VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP,
+ VIRTCHNL_PROTO_HDR_PPPOE,
+ VIRTCHNL_PROTO_HDR_L2TPV3,
+ VIRTCHNL_PROTO_HDR_ESP,
+ VIRTCHNL_PROTO_HDR_AH,
+ VIRTCHNL_PROTO_HDR_PFCP,
+};
+
+/* Protocol header field within a protocol header. */
+enum virtchnl_proto_hdr_field {
+ /* ETHER */
+ VIRTCHNL_PROTO_HDR_ETH_SRC =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_ETH),
+ VIRTCHNL_PROTO_HDR_ETH_DST,
+ VIRTCHNL_PROTO_HDR_ETH_ETHERTYPE,
+ /* S-VLAN */
+ VIRTCHNL_PROTO_HDR_S_VLAN_ID =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_S_VLAN),
+ /* C-VLAN */
+ VIRTCHNL_PROTO_HDR_C_VLAN_ID =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_C_VLAN),
+ /* IPV4 */
+ VIRTCHNL_PROTO_HDR_IPV4_SRC =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV4),
+ VIRTCHNL_PROTO_HDR_IPV4_DST,
+ VIRTCHNL_PROTO_HDR_IPV4_DSCP,
+ VIRTCHNL_PROTO_HDR_IPV4_TTL,
+ VIRTCHNL_PROTO_HDR_IPV4_PROT,
+ /* IPV6 */
+ VIRTCHNL_PROTO_HDR_IPV6_SRC =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV6),
+ VIRTCHNL_PROTO_HDR_IPV6_DST,
+ VIRTCHNL_PROTO_HDR_IPV6_TC,
+ VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT,
+ VIRTCHNL_PROTO_HDR_IPV6_PROT,
+ /* TCP */
+ VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_TCP),
+ VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
+ /* UDP */
+ VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_UDP),
+ VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
+ /* SCTP */
+ VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_SCTP),
+ VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
+ /* GTPU_IP */
+ VIRTCHNL_PROTO_HDR_GTPU_IP_TEID =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
+ /* GTPU_EH */
+ VIRTCHNL_PROTO_HDR_GTPU_EH_PDU =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH),
+ VIRTCHNL_PROTO_HDR_GTPU_EH_QFI,
+ /* PPPOE */
+ VIRTCHNL_PROTO_HDR_PPPOE_SESS_ID =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_PPPOE),
+ /* L2TPV3 */
+ VIRTCHNL_PROTO_HDR_L2TPV3_SESS_ID =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_L2TPV3),
+ /* ESP */
+ VIRTCHNL_PROTO_HDR_ESP_SPI =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_ESP),
+ /* AH */
+ VIRTCHNL_PROTO_HDR_AH_SPI =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_AH),
+ /* PFCP */
+ VIRTCHNL_PROTO_HDR_PFCP_S_FIELD =
+ PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_PFCP),
+ VIRTCHNL_PROTO_HDR_PFCP_SEID,
+};
+
+struct virtchnl_proto_hdr {
+ enum virtchnl_proto_hdr_type type;
+ u32 field_selector; /* a bit mask to select field for header type */
+ u8 buffer[64];
+ /**
+ * binary buffer in network order for specific header type.
+ * For example, if type = VIRTCHNL_PROTO_HDR_IPV4, a IPv4
+ * header is expected to be copied into the buffer.
+ */
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_proto_hdr);
+
+struct virtchnl_proto_hdrs {
+ u8 tunnel_level;
+ /**
+ * specify where protocol header start from.
+ * 0 - from the outer layer
+ * 1 - from the first inner layer
+ * 2 - from the second inner layer
+ * ....
+ **/
+ int count; /* the proto layers must < VIRTCHNL_MAX_NUM_PROTO_HDRS */
+ struct virtchnl_proto_hdr proto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
+
+struct virtchnl_rss_cfg {
+ struct virtchnl_proto_hdrs proto_hdrs; /* protocol headers */
+ enum virtchnl_rss_algorithm rss_algorithm; /* rss algorithm type */
+ u8 reserved[128]; /* reserve for future */
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
+
/* PF capability flags
* VIRTCHNL_CAP_STATELESS_OFFLOADS flag indicates stateless offloads
* such as TX/RX Checksum offloading and TSO for non-tunneled packets. Please
@@ -839,14 +1014,6 @@ enum virtchnl_desc_profile {
VIRTCHNL_TXQ_DESC_PROFILE_NATIVE = 1,
};
-/* Type of RSS algorithm */
-enum virtchnl_rss_algorithm {
- VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC = 0,
- VIRTCHNL_RSS_ALG_R_ASYMMETRIC = 1,
- VIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC = 2,
- VIRTCHNL_RSS_ALG_XOR_SYMMETRIC = 3,
-};
-
/* VIRTCHNL_OP_GET_CAPS
* PF sends this message to CP to negotiate capabilities by filling
* in the u64 bitmap of its desired capabilities, max_num_vfs and
@@ -1336,6 +1503,10 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,
case VIRTCHNL_OP_DCF_GET_PKG_INFO:
case VIRTCHNL_OP_GET_SUPPORTED_RXDIDS:
break;
+ case VIRTCHNL_OP_ADD_RSS_CFG:
+ case VIRTCHNL_OP_DEL_RSS_CFG:
+ valid_len = sizeof(struct virtchnl_rss_cfg);
+ break;
case VIRTCHNL_OP_GET_CAPS:
valid_len = sizeof(struct virtchnl_get_capabilities);
break;
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF Qi Zhang
@ 2020-07-03 5:14 ` Kirsher, Jeffrey T
2020-07-03 7:37 ` kernel test robot
1 sibling, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:14 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for
> AVF
>
> The virtual channel is going to be extended to support FDIR and RSS configure
> from AVF. New data structures and OP codes will be added, the patch enable
> the RSS part.
>
> To support above advanced AVF feature, we need to figure out what kind of
> data structure should be passed from VF to PF to describe an FDIR rule or RSS
> config rule. The common part of the requirement is we need a data structure to
> represent the input set selection of a rule's hash key.
>
> An input set selection is a group of fields be selected from one or more
> network protocol layers that could be identified as a specific flow.
> For example, select dst IP address from an IPv4 header combined with dst port
> from the TCP header as the input set for an IPv4/TCP flow.
>
> The patch adds a new data structure virtchnl_proto_hdrs to abstract a network
> protocol headers group which is composed of layers of network protocol
> header(virtchnl_proto_hdr).
>
> A protocol header contains a 32 bits mask (field_selector) to describe which
> fields are selected as input sets, as well as a header type (enum
> virtchnl_proto_hdr_type). Each bit is mapped to a field in enum
> virtchnl_proto_hdr_field guided by its header type.
>
> +------------+-----------+------------------------------+
> | | Proto Hdr | Header Type A |
> | | +------------------------------+
> | | | BIT 31 | ... | BIT 1 | BIT 0 |
> | |-----------+------------------------------+
> |Proto Hdrs | Proto Hdr | Header Type B |
> | | +------------------------------+
> | | | BIT 31 | ... | BIT 1 | BIT 0 |
> | |-----------+------------------------------+
> | | Proto Hdr | Header Type C |
> | | +------------------------------+
> | | | BIT 31 | ... | BIT 1 | BIT 0 |
> | |-----------+------------------------------+
> | | .... |
> +-------------------------------------------------------+
>
> All fields in enum virtchnl_proto_hdr_fields are grouped with header type and
> the value of the first field of a header type is always 32 aligned.
>
> enum proto_hdr_type {
> header_type_A = 0;
> header_type_B = 1;
> ....
> }
>
> enum proto_hdr_field {
> /* header type A */
> header_A_field_0 = 0,
> header_A_field_1 = 1,
> header_A_field_2 = 2,
> header_A_field_3 = 3,
>
> /* header type B */
> header_B_field_0 = 32, // = header_type_B << 5
> header_B_field_0 = 33,
> header_B_field_0 = 34
> header_B_field_0 = 35,
> ....
> };
>
> So we have:
> proto_hdr_type = proto_hdr_field / 32
> bit offset = proto_hdr_field % 32
>
> To simply the protocol header's operations, couple help macros are added.
> For example, to select src IP and dst port as input set for an IPv4/UDP flow.
>
> we have:
> struct virtchnl_proto_hdr hdr[2];
>
> VIRTCHNL_SET_PROTO_HDR_TYPE(&hdr[0], IPV4)
> VIRTCHNL_ADD_PROTO_HDR_FIELD(&hdr[0], IPV4, SRC)
>
> VIRTCHNL_SET_PROTO_HDR_TYPE(&hdr[1], UDP)
> VIRTCHNL_ADD_PROTO_HDR_FIELD(&hdr[1], UDP, DST)
>
> A protocol header also contains a byte array, this field should only be used by
> an FDIR rule and should be ignored by RSS. For an FDIR rule, the byte array is
> used to store the protocol header of a training package. The byte array must
> be network order.
>
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_flow.h | 3 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 459
> +++++++++++++++++++++++
> include/linux/avf/virtchnl.h | 187 ++++++++-
> 3 files changed, 641 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h
> b/drivers/net/ethernet/intel/ice/ice_flow.h
> index 68d1ec7cf8fd..f3cfcfd2c296 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> @@ -8,6 +8,9 @@
> #define ICE_FLOW_FLD_OFF_INVAL 0xffff
>
> /* Generate flow hash field from flow field type(s) */
> +#define ICE_FLOW_HASH_ETH \
> + (BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA) | \
> + BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA))
> #define ICE_FLOW_HASH_IPV4 \
> (BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) | \
> BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA))
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> index 8022300f9c8e..ede343016f94 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> @@ -5,6 +5,246 @@
> #include "ice_base.h"
> #include "ice_lib.h"
> #include "ice_fltr.h"
> +#include "ice_flow.h"
> +
> +#define FIELD_SELECTOR(proto_hdr_field) \
> + (1UL << ((proto_hdr_field) & PROTO_HDR_FIELD_MASK))
> +
> +struct ice_vc_hdr_match_type {
> + u32 vc_hdr; /* virtchnl headers (VIRTCHNL_PROTO_HDR_XXX) */
> + u32 ice_hdr; /* ice headers (ICE_FLOW_SEG_HDR_XXX) */
> +};
> +
> +static const struct ice_vc_hdr_match_type ice_vc_hdr_list_os[] = {
> + {VIRTCHNL_PROTO_HDR_NONE, ICE_FLOW_SEG_HDR_NONE},
> + {VIRTCHNL_PROTO_HDR_IPV4, ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER},
> + {VIRTCHNL_PROTO_HDR_IPV6, ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER},
> + {VIRTCHNL_PROTO_HDR_TCP, ICE_FLOW_SEG_HDR_TCP},
> + {VIRTCHNL_PROTO_HDR_UDP, ICE_FLOW_SEG_HDR_UDP},
> + {VIRTCHNL_PROTO_HDR_SCTP, ICE_FLOW_SEG_HDR_SCTP},
> +};
> +
> +static const struct ice_vc_hdr_match_type ice_vc_hdr_list_comms[] = {
> + {VIRTCHNL_PROTO_HDR_NONE, ICE_FLOW_SEG_HDR_NONE},
> + {VIRTCHNL_PROTO_HDR_ETH, ICE_FLOW_SEG_HDR_ETH},
> + {VIRTCHNL_PROTO_HDR_S_VLAN, ICE_FLOW_SEG_HDR_VLAN},
> + {VIRTCHNL_PROTO_HDR_C_VLAN, ICE_FLOW_SEG_HDR_VLAN},
> + {VIRTCHNL_PROTO_HDR_IPV4, ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER},
> + {VIRTCHNL_PROTO_HDR_IPV6, ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER},
> + {VIRTCHNL_PROTO_HDR_TCP, ICE_FLOW_SEG_HDR_TCP},
> + {VIRTCHNL_PROTO_HDR_UDP, ICE_FLOW_SEG_HDR_UDP},
> + {VIRTCHNL_PROTO_HDR_SCTP, ICE_FLOW_SEG_HDR_SCTP},
> + {VIRTCHNL_PROTO_HDR_PPPOE, ICE_FLOW_SEG_HDR_PPPOE},
> + {VIRTCHNL_PROTO_HDR_GTPU_IP,
> ICE_FLOW_SEG_HDR_GTPU_IP},
> + {VIRTCHNL_PROTO_HDR_GTPU_EH,
> ICE_FLOW_SEG_HDR_GTPU_EH},
> + {VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN,
> + ICE_FLOW_SEG_HDR_GTPU_DWN},
> + {VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP,
> + ICE_FLOW_SEG_HDR_GTPU_UP},
> + {VIRTCHNL_PROTO_HDR_L2TPV3, ICE_FLOW_SEG_HDR_L2TPV3},
> + {VIRTCHNL_PROTO_HDR_ESP, ICE_FLOW_SEG_HDR_ESP},
> + {VIRTCHNL_PROTO_HDR_AH, ICE_FLOW_SEG_HDR_AH},
> + {VIRTCHNL_PROTO_HDR_PFCP,
> ICE_FLOW_SEG_HDR_PFCP_SESSION},
> +};
> +
> +struct ice_vc_hash_field_match_type {
> + u32 vc_hdr; /* virtchnl headers
> + * (VIRTCHNL_PROTO_HDR_XXX)
> + */
> + u32 vc_hash_field; /* virtchnl hash fields selector
> + *
> FIELD_SELECTOR((VIRTCHNL_PROTO_HDR_ETH_XXX))
> + */
> + u64 ice_hash_field; /* ice hash fields
> + * (BIT_ULL(ICE_FLOW_FIELD_IDX_XXX))
> + */
> +};
> +
> +static const struct
> +ice_vc_hash_field_match_type ice_vc_hash_field_list_os[] = {
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
> + ICE_FLOW_HASH_IPV4},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + ICE_FLOW_HASH_IPV4 |
> BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
> + ICE_FLOW_HASH_IPV6},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + ICE_FLOW_HASH_IPV6 |
> BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_TCP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_SRC_PORT)},
> + {VIRTCHNL_PROTO_HDR_TCP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_DST_PORT)},
> + {VIRTCHNL_PROTO_HDR_TCP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
> + ICE_FLOW_HASH_TCP_PORT},
> + {VIRTCHNL_PROTO_HDR_UDP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_SRC_PORT)},
> + {VIRTCHNL_PROTO_HDR_UDP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_DST_PORT)},
> + {VIRTCHNL_PROTO_HDR_UDP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
> + ICE_FLOW_HASH_UDP_PORT},
> + {VIRTCHNL_PROTO_HDR_SCTP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT)},
> + {VIRTCHNL_PROTO_HDR_SCTP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_DST_PORT)},
> + {VIRTCHNL_PROTO_HDR_SCTP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
> + ICE_FLOW_HASH_SCTP_PORT},
> +};
> +
> +static const struct
> +ice_vc_hash_field_match_type ice_vc_hash_field_list_comms[] = {
> + {VIRTCHNL_PROTO_HDR_ETH,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA)},
> + {VIRTCHNL_PROTO_HDR_ETH,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA)},
> + {VIRTCHNL_PROTO_HDR_ETH,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST),
> + ICE_FLOW_HASH_ETH},
> + {VIRTCHNL_PROTO_HDR_ETH,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_ETHERTYPE),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_ETH_TYPE)},
> + {VIRTCHNL_PROTO_HDR_S_VLAN,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_S_VLAN_ID),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_S_VLAN)},
> + {VIRTCHNL_PROTO_HDR_C_VLAN,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_C_VLAN_ID),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_C_VLAN)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
> + ICE_FLOW_HASH_IPV4},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_DA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + ICE_FLOW_HASH_IPV4 |
> BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV4,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
> + ICE_FLOW_HASH_IPV6},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_SA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_DA) |
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + ICE_FLOW_HASH_IPV6 |
> BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_IPV6,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_PROT)},
> + {VIRTCHNL_PROTO_HDR_TCP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_SRC_PORT)},
> + {VIRTCHNL_PROTO_HDR_TCP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_DST_PORT)},
> + {VIRTCHNL_PROTO_HDR_TCP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_DST_PORT),
> + ICE_FLOW_HASH_TCP_PORT},
> + {VIRTCHNL_PROTO_HDR_UDP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_SRC_PORT)},
> + {VIRTCHNL_PROTO_HDR_UDP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_DST_PORT)},
> + {VIRTCHNL_PROTO_HDR_UDP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT),
> + ICE_FLOW_HASH_UDP_PORT},
> + {VIRTCHNL_PROTO_HDR_SCTP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT)},
> + {VIRTCHNL_PROTO_HDR_SCTP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_DST_PORT)},
> + {VIRTCHNL_PROTO_HDR_SCTP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT) |
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_SCTP_DST_PORT),
> + ICE_FLOW_HASH_SCTP_PORT},
> + {VIRTCHNL_PROTO_HDR_PPPOE,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_PPPOE_SESS_ID),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_PPPOE_SESS_ID)},
> + {VIRTCHNL_PROTO_HDR_GTPU_IP,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_GTPU_IP_TEID),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID)},
> + {VIRTCHNL_PROTO_HDR_L2TPV3,
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_L2TPV3_SESS_ID),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID)},
> + {VIRTCHNL_PROTO_HDR_ESP,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ESP_SPI),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI)},
> + {VIRTCHNL_PROTO_HDR_AH,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_AH_SPI),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_AH_SPI)},
> + {VIRTCHNL_PROTO_HDR_PFCP,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_PFCP_SEID),
> + BIT_ULL(ICE_FLOW_FIELD_IDX_PFCP_SEID)},
> +};
>
> /**
> * ice_validate_vf_id - helper to check if VF ID is valid @@ -2009,6 +2249,9
> @@ static int ice_vc_get_vf_res_msg(struct ice_vf *vf, u8 *msg)
> if (vf->driver_caps & VIRTCHNL_VF_CAP_ADV_LINK_SPEED)
> vfres->vf_cap_flags |= VIRTCHNL_VF_CAP_ADV_LINK_SPEED;
>
> + if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF)
> + vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF;
> +
> /* Negotiate DCF capability. */
> if (vf->driver_caps & VIRTCHNL_VF_CAP_DCF) {
> if (!ice_check_dcf_allowed(vf)) {
> @@ -2141,6 +2384,216 @@ static bool ice_vc_isvalid_ring_len(u16 ring_len) }
>
> /**
> + * ice_vc_parse_rss_cfg - parses hash fields and headers from
> + * a specific virtchnl RSS cfg
> + * @hw: pointer to the hardware
> + * @rss_cfg: pointer to the virtchnl rss cfg
> + * @addl_hdrs: pointer to the protocol header fields
> +(ICE_FLOW_SEG_HDR_*)
> + * to configure
> + * @hash_flds: pointer to the hash bit fields (ICE_FLOW_HASH_*) to
> +configure
> + *
> + * Return true if all the protocol header and hash fields in the rss
> +cfg could
> + * be parsed, else return false
> + *
> + * This function parses the virtchnl rss cfg to be the intended
> + * hash fields and the intended header for RSS configuration */ static
> +bool ice_vc_parse_rss_cfg(struct ice_hw *hw, struct virtchnl_rss_cfg
> +*rss_cfg,
> + u32 *addl_hdrs, u64 *hash_flds)
> +{
> + const struct ice_vc_hash_field_match_type *hf_list;
> + const struct ice_vc_hdr_match_type *hdr_list;
> + int i, hf_list_len, hdr_list_len;
> +
> + if (!strncmp(hw->active_pkg_name, "ICE COMMS Package",
> + sizeof(hw->active_pkg_name))) {
> + hf_list = ice_vc_hash_field_list_comms;
> + hf_list_len = ARRAY_SIZE(ice_vc_hash_field_list_comms);
> + hdr_list = ice_vc_hdr_list_comms;
> + hdr_list_len = ARRAY_SIZE(ice_vc_hdr_list_comms);
> + } else {
> + hf_list = ice_vc_hash_field_list_os;
> + hf_list_len = ARRAY_SIZE(ice_vc_hash_field_list_os);
> + hdr_list = ice_vc_hdr_list_os;
> + hdr_list_len = ARRAY_SIZE(ice_vc_hdr_list_os);
> + }
> +
> + for (i = 0; i < rss_cfg->proto_hdrs.count; i++) {
> + struct virtchnl_proto_hdr *proto_hdr =
> + &rss_cfg->proto_hdrs.proto_hdr[i];
This might all fit on one line
> + bool hdr_found = false;
> + int j;
> +
> + /* Find matched ice headers according to virtchnl headers. */
> + for (j = 0; j < hdr_list_len; j++) {
> + struct ice_vc_hdr_match_type hdr_map =
> + hdr_list[j];
This definitely can fit on one line (no wrapping needed)
> +
> + if (proto_hdr->type == hdr_map.vc_hdr) {
> + *addl_hdrs |= hdr_map.ice_hdr;
> + hdr_found = true;
> + }
> + }
> +
> + if (!hdr_found)
> + return false;
> +
> + /* Find matched ice hash fields according to
> + * virtchnl hash fields.
> + */
> + for (j = 0; j < hf_list_len; j++) {
> + struct ice_vc_hash_field_match_type hf_map =
> + hf_list[j];
Here too
> +
> + if (proto_hdr->type == hf_map.vc_hdr &&
> + proto_hdr->field_selector ==
> + hf_map.vc_hash_field) {
Overzealous wrapping here
> + *hash_flds |= hf_map.ice_hash_field;
> + break;
> + }
> + }
> + }
> +
> + return true;
> +}
> +
> +/**
> + * ice_vf_adv_rss_offload_ena - determine if capabilities support
> +advanced
> + * rss offloads
> + * @caps: VF driver negotiated capabilities
> + *
> + * Return true if VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability is set,
> + * else return false
> + */
> +static bool ice_vf_adv_rss_offload_ena(u32 caps) {
> + return !!(caps & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF); }
> +
> +/**
> + * ice_vc_handle_rss_cfg
> + * @vf: pointer to the VF info
> + * @msg: pointer to the msg buffer
> + * @add: add a rss cfg if true, otherwise delete a rss cfg
> + *
> + * This function adds/deletes a rss cfg */ static int
> +ice_vc_handle_rss_cfg(struct ice_vf *vf, u8 *msg, bool add) {
> + struct virtchnl_rss_cfg *rss_cfg = (struct virtchnl_rss_cfg *)msg;
> + enum virtchnl_status_code v_ret = VIRTCHNL_STATUS_SUCCESS;
> + u32 v_opcode = add ? VIRTCHNL_OP_ADD_RSS_CFG :
> + VIRTCHNL_OP_DEL_RSS_CFG;
RCT issues and wrapping issues
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + struct ice_hw *hw = &vf->pf->hw;
> + struct ice_vsi *vsi;
> +
> + if (!test_bit(ICE_FLAG_RSS_ENA, vf->pf->flags)) {
> + dev_dbg(dev, "VF %d attempting to configure RSS, but RSS is
> not supported by the PF\n",
> + vf->vf_id);
> + v_ret = VIRTCHNL_STATUS_ERR_NOT_SUPPORTED;
> + goto error_param;
> + }
> +
> + if (!ice_vf_adv_rss_offload_ena(vf->driver_caps)) {
> + dev_dbg(dev, "VF %d attempting to configure RSS, but Advanced
> RSS offload is not supported\n",
> + vf->vf_id);
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + goto error_param;
> + }
> +
> + if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + goto error_param;
> + }
> +
> + if (rss_cfg->proto_hdrs.count > VIRTCHNL_MAX_NUM_PROTO_HDRS ||
> + rss_cfg->rss_algorithm <
> VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC ||
> + rss_cfg->rss_algorithm > VIRTCHNL_RSS_ALG_XOR_SYMMETRIC) {
> + dev_dbg(dev, "VF %d attempting to configure RSS, but RSS
> configuration is not valid\n",
> + vf->vf_id);
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + goto error_param;
> + }
> +
> + vsi = vf->pf->vsi[vf->lan_vsi_idx];
> + if (!vsi) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + goto error_param;
> + }
> +
> + if (rss_cfg->rss_algorithm == VIRTCHNL_RSS_ALG_R_ASYMMETRIC) {
> + struct ice_vsi_ctx *ctx;
> + enum ice_status status;
> + u8 lut_type, hash_type;
> +
> + lut_type = ICE_AQ_VSI_Q_OPT_RSS_LUT_VSI;
> + hash_type = add ? ICE_AQ_VSI_Q_OPT_RSS_XOR :
> + ICE_AQ_VSI_Q_OPT_RSS_TPLZ;
> +
> + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> + if (!ctx) {
> + v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
> + goto error_param;
> + }
> +
> + ctx->info.q_opt_rss = ((lut_type <<
> + ICE_AQ_VSI_Q_OPT_RSS_LUT_S) &
> + ICE_AQ_VSI_Q_OPT_RSS_LUT_M) |
> + (hash_type &
> + ICE_AQ_VSI_Q_OPT_RSS_HASH_M);
> +
> + /* Preserve existing queueing option setting */
> + ctx->info.q_opt_rss |= (vsi->info.q_opt_rss &
> + ICE_AQ_VSI_Q_OPT_RSS_GBL_LUT_M);
> + ctx->info.q_opt_tc = vsi->info.q_opt_tc;
> + ctx->info.q_opt_flags = vsi->info.q_opt_rss;
> +
> + ctx->info.valid_sections =
> + cpu_to_le16(ICE_AQ_VSI_PROP_Q_OPT_VALID);
> +
> + status = ice_update_vsi(hw, vsi->idx, ctx, NULL);
> + if (status) {
> + dev_err(dev,
> + "update VSI for RSS failed, err %s aq_err %s\n",
> + ice_stat_str(status),
> + ice_aq_str(hw->adminq.sq_last_status));
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + } else {
> + vsi->info.q_opt_rss = ctx->info.q_opt_rss;
> + }
> +
> + kfree(ctx);
> + } else {
> + u32 addl_hdrs = ICE_FLOW_SEG_HDR_NONE;
> + u64 hash_flds = ICE_HASH_INVALID;
> +
> + if (!ice_vc_parse_rss_cfg(hw, rss_cfg, &addl_hdrs,
> + &hash_flds)) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + goto error_param;
> + }
> +
> + if (add) {
> + if (ice_add_rss_cfg(hw, vsi->idx, hash_flds,
> + addl_hdrs)) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + dev_err(dev,
> + "ice_add_rss_cfg failed for vsi = %d, v_ret
> = %d\n",
> + vsi->vsi_num, v_ret);
> + }
> + } else {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + dev_err(dev, "RSS removal not support\n");
> + }
> + }
> +
> +error_param:
> + return ice_vc_send_msg_to_vf(vf, v_opcode, v_ret, NULL, 0); }
> +
> +/**
> * ice_vc_config_rss_key
> * @vf: pointer to the VF info
> * @msg: pointer to the msg buffer
> @@ -4221,6 +4674,12 @@ void ice_vc_process_vf_msg(struct ice_pf *pf,
> struct ice_rq_event_info *event)
> case VIRTCHNL_OP_DCF_GET_PKG_INFO:
> err = ice_vc_dcf_query_pkg_info(vf);
> break;
> + case VIRTCHNL_OP_ADD_RSS_CFG:
> + err = ice_vc_handle_rss_cfg(vf, msg, true);
> + break;
> + case VIRTCHNL_OP_DEL_RSS_CFG:
> + err = ice_vc_handle_rss_cfg(vf, msg, false);
> + break;
> case VIRTCHNL_OP_UNKNOWN:
> default:
> dev_err(dev, "Unsupported opcode %d from VF %d\n",
> v_opcode, diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
> index 825cdc0e9ffe..d7e5263fd2ec 100644
> --- a/include/linux/avf/virtchnl.h
> +++ b/include/linux/avf/virtchnl.h
> @@ -143,6 +143,8 @@ enum virtchnl_ops {
> VIRTCHNL_OP_DCF_GET_VSI_MAP = 42,
> VIRTCHNL_OP_DCF_GET_PKG_INFO = 43,
> VIRTCHNL_OP_GET_SUPPORTED_RXDIDS = 44,
> + VIRTCHNL_OP_ADD_RSS_CFG = 45,
> + VIRTCHNL_OP_DEL_RSS_CFG = 46,
> /* New major set of opcodes introduced and so leaving room for
> * old misc opcodes to be added in future. Also these opcodes may only
> * be used if both the PF and VF have successfully negotiated the @@ -
> 283,6 +285,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);
> #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000
> #define VIRTCHNL_VF_OFFLOAD_ADQ 0X00800000
> #define VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC 0X04000000
> +#define VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF 0X08000000
> #define VIRTCHNL_VF_CAP_DCF 0X40000000
>
> /* Define below the capability flags that are not offloads */ @@ -557,6
> +560,14 @@ struct virtchnl_rss_hena {
>
> VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_rss_hena);
>
> +/* Type of RSS algorithm */
> +enum virtchnl_rss_algorithm {
> + VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC = 0,
> + VIRTCHNL_RSS_ALG_R_ASYMMETRIC = 1,
> + VIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC = 2,
> + VIRTCHNL_RSS_ALG_XOR_SYMMETRIC = 3,
> +};
> +
> /* VIRTCHNL_OP_ENABLE_CHANNELS
> * VIRTCHNL_OP_DISABLE_CHANNELS
> * VF sends these messages to enable or disable channels based on @@ -
> 773,6 +784,170 @@ enum virtchnl_vfr_states {
> VIRTCHNL_VFR_VFACTIVE,
> };
>
> +#define VIRTCHNL_MAX_NUM_PROTO_HDRS 32
> +#define PROTO_HDR_SHIFT 5
> +#define PROTO_HDR_FIELD_START(proto_hdr_type) \
> + (proto_hdr_type << PROTO_HDR_SHIFT)
> #define PROTO_HDR_FIELD_MASK
> +((1UL << PROTO_HDR_SHIFT) - 1)
> +
> +/* VF use these macros to configure each protocol header.
> + * Specify which protocol headers and protocol header fields base on
> + * virtchnl_proto_hdr_type and virtchnl_proto_hdr_field.
> + * @param hdr: a struct of virtchnl_proto_hdr
> + * @param hdr_type: ETH/IPV4/TCP, etc
> + * @param field: SRC/DST/TEID/SPI, etc
> + */
> +#define VIRTCHNL_ADD_PROTO_HDR_FIELD(hdr, field) \
> + ((hdr)->field_selector |= BIT((field) & PROTO_HDR_FIELD_MASK))
> #define
> +VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr, field) \
> + ((hdr)->field_selector &= ~BIT((field) & PROTO_HDR_FIELD_MASK))
> +#define VIRTCHNL_TEST_PROTO_HDR_FIELD(hdr, val) \
> + ((hdr)->field_selector & BIT((val) & PROTO_HDR_FIELD_MASK))
> +#define VIRTCHNL_GET_PROTO_HDR_FIELD(hdr) ((hdr)->field_selector)
> +
> +#define VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, hdr_type, field) \
> + (VIRTCHNL_ADD_PROTO_HDR_FIELD(hdr, \
> + VIRTCHNL_PROTO_HDR_ ## hdr_type ## _ ## field)) #define
> +VIRTCHNL_DEL_PROTO_HDR_FIELD_BIT(hdr, hdr_type, field) \
> + (VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr, \
> + VIRTCHNL_PROTO_HDR_ ## hdr_type ## _ ## field))
> +
> +#define VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, hdr_type) \
> + ((hdr)->type = VIRTCHNL_PROTO_HDR_ ## hdr_type) #define
> +VIRTCHNL_GET_PROTO_HDR_TYPE(hdr) \
> + (((hdr)->type) >> PROTO_HDR_SHIFT)
> +#define VIRTCHNL_TEST_PROTO_HDR_TYPE(hdr, val) \
> + ((hdr)->type == ((val) >> PROTO_HDR_SHIFT)) #define
> +VIRTCHNL_TEST_PROTO_HDR(hdr, val) \
> + (VIRTCHNL_TEST_PROTO_HDR_TYPE(hdr, val) && \
> + VIRTCHNL_TEST_PROTO_HDR_FIELD(hdr, val))
> +
> +/* Protocol header type within a packet segment. A segment consists of
> +one or
> + * more protocol headers that make up a logical group of protocol
> +headers. Each
> + * logical group of protocol headers encapsulates or is encapsulated
> +using/by
> + * tunneling or encapsulation protocols for network virtualization.
> + */
> +enum virtchnl_proto_hdr_type {
> + VIRTCHNL_PROTO_HDR_NONE,
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_S_VLAN,
> + VIRTCHNL_PROTO_HDR_C_VLAN,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_TCP,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_SCTP,
> + VIRTCHNL_PROTO_HDR_GTPU_IP,
> + VIRTCHNL_PROTO_HDR_GTPU_EH,
> + VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN,
> + VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP,
> + VIRTCHNL_PROTO_HDR_PPPOE,
> + VIRTCHNL_PROTO_HDR_L2TPV3,
> + VIRTCHNL_PROTO_HDR_ESP,
> + VIRTCHNL_PROTO_HDR_AH,
> + VIRTCHNL_PROTO_HDR_PFCP,
> +};
> +
> +/* Protocol header field within a protocol header. */ enum
> +virtchnl_proto_hdr_field {
> + /* ETHER */
> + VIRTCHNL_PROTO_HDR_ETH_SRC =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_ETH),
> + VIRTCHNL_PROTO_HDR_ETH_DST,
> + VIRTCHNL_PROTO_HDR_ETH_ETHERTYPE,
> + /* S-VLAN */
> + VIRTCHNL_PROTO_HDR_S_VLAN_ID =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_S_VLAN),
> + /* C-VLAN */
> + VIRTCHNL_PROTO_HDR_C_VLAN_ID =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_C_VLAN),
> + /* IPV4 */
> + VIRTCHNL_PROTO_HDR_IPV4_SRC =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV4),
> + VIRTCHNL_PROTO_HDR_IPV4_DST,
> + VIRTCHNL_PROTO_HDR_IPV4_DSCP,
> + VIRTCHNL_PROTO_HDR_IPV4_TTL,
> + VIRTCHNL_PROTO_HDR_IPV4_PROT,
> + /* IPV6 */
> + VIRTCHNL_PROTO_HDR_IPV6_SRC =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV6),
> + VIRTCHNL_PROTO_HDR_IPV6_DST,
> + VIRTCHNL_PROTO_HDR_IPV6_TC,
> + VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT,
> + VIRTCHNL_PROTO_HDR_IPV6_PROT,
> + /* TCP */
> + VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_TCP),
> + VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> + /* UDP */
> + VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_UDP),
> + VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
> + /* SCTP */
> + VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_SCTP),
> + VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> + /* GTPU_IP */
> + VIRTCHNL_PROTO_HDR_GTPU_IP_TEID =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
> + /* GTPU_EH */
> + VIRTCHNL_PROTO_HDR_GTPU_EH_PDU =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH),
> + VIRTCHNL_PROTO_HDR_GTPU_EH_QFI,
> + /* PPPOE */
> + VIRTCHNL_PROTO_HDR_PPPOE_SESS_ID =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_PPPOE),
> + /* L2TPV3 */
> + VIRTCHNL_PROTO_HDR_L2TPV3_SESS_ID =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_L2TPV3),
> + /* ESP */
> + VIRTCHNL_PROTO_HDR_ESP_SPI =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_ESP),
> + /* AH */
> + VIRTCHNL_PROTO_HDR_AH_SPI =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_AH),
> + /* PFCP */
> + VIRTCHNL_PROTO_HDR_PFCP_S_FIELD =
> + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_PFCP),
> + VIRTCHNL_PROTO_HDR_PFCP_SEID,
> +};
> +
> +struct virtchnl_proto_hdr {
> + enum virtchnl_proto_hdr_type type;
> + u32 field_selector; /* a bit mask to select field for header type */
> + u8 buffer[64];
> + /**
> + * binary buffer in network order for specific header type.
> + * For example, if type = VIRTCHNL_PROTO_HDR_IPV4, a IPv4
> + * header is expected to be copied into the buffer.
> + */
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_proto_hdr);
> +
> +struct virtchnl_proto_hdrs {
> + u8 tunnel_level;
> + /**
> + * specify where protocol header start from.
> + * 0 - from the outer layer
> + * 1 - from the first inner layer
> + * 2 - from the second inner layer
> + * ....
> + **/
> + int count; /* the proto layers must <
> VIRTCHNL_MAX_NUM_PROTO_HDRS */
> + struct virtchnl_proto_hdr
> proto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS];
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
> +
> +struct virtchnl_rss_cfg {
> + struct virtchnl_proto_hdrs proto_hdrs; /* protocol headers */
> + enum virtchnl_rss_algorithm rss_algorithm; /* rss algorithm type */
> + u8 reserved[128]; /* reserve for future */
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
> +
> /* PF capability flags
> * VIRTCHNL_CAP_STATELESS_OFFLOADS flag indicates stateless offloads
> * such as TX/RX Checksum offloading and TSO for non-tunneled packets.
> Please @@ -839,14 +1014,6 @@ enum virtchnl_desc_profile {
> VIRTCHNL_TXQ_DESC_PROFILE_NATIVE = 1,
> };
>
> -/* Type of RSS algorithm */
> -enum virtchnl_rss_algorithm {
> - VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC = 0,
> - VIRTCHNL_RSS_ALG_R_ASYMMETRIC = 1,
> - VIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC = 2,
> - VIRTCHNL_RSS_ALG_XOR_SYMMETRIC = 3,
> -};
> -
> /* VIRTCHNL_OP_GET_CAPS
> * PF sends this message to CP to negotiate capabilities by filling
> * in the u64 bitmap of its desired capabilities, max_num_vfs and @@ -1336,6
> +1503,10 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver,
> u32 v_opcode,
> case VIRTCHNL_OP_DCF_GET_PKG_INFO:
> case VIRTCHNL_OP_GET_SUPPORTED_RXDIDS:
> break;
> + case VIRTCHNL_OP_ADD_RSS_CFG:
> + case VIRTCHNL_OP_DEL_RSS_CFG:
> + valid_len = sizeof(struct virtchnl_rss_cfg);
> + break;
> case VIRTCHNL_OP_GET_CAPS:
> valid_len = sizeof(struct virtchnl_get_capabilities);
> break;
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF Qi Zhang
@ 2020-07-03 7:37 ` kernel test robot
2020-07-03 7:37 ` kernel test robot
1 sibling, 0 replies; 31+ messages in thread
From: kernel test robot @ 2020-07-03 7:37 UTC (permalink / raw)
To: intel-wired-lan
Hi Qi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on jkirsher-next-queue/dev-queue]
[cannot apply to v5.8-rc3 next-20200702]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qi-Zhang/Support-Advanced-AVF-features/20200703-070522
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: m68k-randconfig-r026-20200702 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:941:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:941:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1038:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1038:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1088:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1088:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1120:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1120:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1136:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1136:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1166:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1166:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1181:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1181:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1199:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1199:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1214:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1214:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:941:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:941:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1038:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1038:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1088:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1088:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1120:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1120:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1136:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1136:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1166:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1166:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1181:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1181:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1199:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1199:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1214:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1214:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/net/ethernet/intel/iavf/iavf.h:7,
from drivers/net/ethernet/intel/iavf/iavf_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/iavf/iavf.h:38,
from drivers/net/ethernet/intel/iavf/iavf_main.c:4:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:941:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:941:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1038:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1038:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1088:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1088:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1120:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1120:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1136:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1136:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1166:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1166:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1181:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1181:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1199:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1199:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1214:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1214:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
vim +/virtchnl_static_assert_virtchnl_proto_hdrs +941 include/linux/avf/virtchnl.h
940
> 941 VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
942
943 struct virtchnl_rss_cfg {
944 struct virtchnl_proto_hdrs proto_hdrs; /* protocol headers */
945 enum virtchnl_rss_algorithm rss_algorithm; /* rss algorithm type */
946 u8 reserved[128]; /* reserve for future */
947 };
948
> 949 VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
950
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30039 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20200703/9cafcd68/attachment-0001.bin>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF
@ 2020-07-03 7:37 ` kernel test robot
0 siblings, 0 replies; 31+ messages in thread
From: kernel test robot @ 2020-07-03 7:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 35746 bytes --]
Hi Qi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on jkirsher-next-queue/dev-queue]
[cannot apply to v5.8-rc3 next-20200702]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qi-Zhang/Support-Advanced-AVF-features/20200703-070522
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: m68k-randconfig-r026-20200702 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:941:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:941:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1038:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1038:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1088:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1088:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1120:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1120:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1136:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1136:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1166:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1166:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1181:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1181:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1199:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1199:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1214:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1214:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:941:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:941:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1038:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1038:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1088:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1088:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1120:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1120:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1136:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1136:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1166:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1166:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1181:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1181:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1199:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1199:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1214:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1214:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/net/ethernet/intel/iavf/iavf.h:7,
from drivers/net/ethernet/intel/iavf/iavf_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/iavf/iavf.h:38,
from drivers/net/ethernet/intel/iavf/iavf_main.c:4:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:941:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:941:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
941 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1038:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1038:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1038 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1088:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1088:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1088 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1120:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1120:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1120 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1136:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1136:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1136 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1166:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1166:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1166 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1181:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1181:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1181 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1199:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1199:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1199 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:184:36: warning: division by zero [-Wdiv-by-zero]
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1214:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1214:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1214 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:184:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
184 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
vim +/virtchnl_static_assert_virtchnl_proto_hdrs +941 include/linux/avf/virtchnl.h
940
> 941 VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
942
943 struct virtchnl_rss_cfg {
944 struct virtchnl_proto_hdrs proto_hdrs; /* protocol headers */
945 enum virtchnl_rss_algorithm rss_algorithm; /* rss algorithm type */
946 u8 reserved[128]; /* reserve for future */
947 };
948
> 949 VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
950
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30039 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 08/14] ice: Support RSS configure removal for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (6 preceding siblings ...)
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 07/14] ice: Enable RSS Configure for AVF Qi Zhang
@ 2020-07-02 22:57 ` Qi Zhang
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 09/14] ice: Add support for per VF ctrl VSI enabling Qi Zhang
` (6 subsequent siblings)
14 siblings, 0 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:57 UTC (permalink / raw)
To: intel-wired-lan
Add ice_add_rss_cfg's reverse operation ice_rem_rss_cfg.
It is invoked when handle VIRTCHNL_OP_DEL_RSS_CFG.
Signed-off-by: Vignesh Sridhar <vignesh.sridhar@intel.com>
Signed-off-by: Jia Guo <jia.guo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_flow.c | 90 ++++++++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_flow.h | 5 ++
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 17 ++++-
3 files changed, 110 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index f7eeb31f8b22..1bb7e98d9703 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -2138,6 +2138,96 @@ ice_add_rss_cfg(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,
return status;
}
+#ifdef CONFIG_PCI_IOV
+/**
+ * ice_rem_rss_cfg_sync - remove an existing RSS configuration
+ * @hw: pointer to the hardware structure
+ * @vsi_handle: software VSI handle
+ * @hashed_flds: Packet hash types (ICE_FLOW_HASH_*) to remove
+ * @addl_hdrs: Protocol header fields within a packet segment
+ * @segs_cnt: packet segment count
+ *
+ * Assumption: lock has already been acquired for RSS list
+ */
+static enum ice_status
+ice_rem_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,
+ u32 addl_hdrs, u8 segs_cnt)
+{
+ const enum ice_block blk = ICE_BLK_RSS;
+ struct ice_flow_seg_info *segs;
+ struct ice_flow_prof *prof;
+ enum ice_status status;
+
+ segs = kcalloc(segs_cnt, sizeof(*segs), GFP_KERNEL);
+ if (!segs)
+ return ICE_ERR_NO_MEMORY;
+
+ /* Construct the packet segment info from the hashed fields */
+ status = ice_flow_set_rss_seg_info(&segs[segs_cnt - 1], hashed_flds,
+ addl_hdrs);
+ if (status)
+ goto out;
+
+ prof = ice_flow_find_prof_conds(hw, blk, ICE_FLOW_RX, segs, segs_cnt,
+ vsi_handle,
+ ICE_FLOW_FIND_PROF_CHK_FLDS);
+ if (!prof) {
+ status = ICE_ERR_DOES_NOT_EXIST;
+ goto out;
+ }
+
+ status = ice_flow_disassoc_prof(hw, blk, prof, vsi_handle);
+ if (status)
+ goto out;
+
+ /* Remove RSS configuration from VSI context before deleting
+ * the flow profile.
+ */
+ ice_rem_rss_list(hw, vsi_handle, prof);
+
+ if (bitmap_empty(prof->vsis, ICE_MAX_VSI))
+ status = ice_flow_rem_prof(hw, blk, prof->id);
+
+out:
+ kfree(segs);
+ return status;
+}
+
+/**
+ * ice_rem_rss_cfg - remove an existing RSS config with matching hashed fields
+ * @hw: pointer to the hardware structure
+ * @vsi_handle: software VSI handle
+ * @hashed_flds: Packet hash types (ICE_FLOW_HASH_*) to remove
+ * @addl_hdrs: Protocol header fields within a packet segment
+ *
+ * This function will lookup the flow profile based on the input
+ * hash field bitmap, iterate through the profile entry list of
+ * that profile and find entry associated with input VSI to be
+ * removed. Calls are made to underlying flow apis which will in
+ * turn build or update buffers for RSS XLT1 section.
+ */
+enum ice_status
+ice_rem_rss_cfg(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,
+ u32 addl_hdrs)
+{
+ enum ice_status status;
+
+ if (hashed_flds == ICE_HASH_INVALID ||
+ !ice_is_vsi_valid(hw, vsi_handle))
+ return ICE_ERR_PARAM;
+
+ mutex_lock(&hw->rss_locks);
+ status = ice_rem_rss_cfg_sync(hw, vsi_handle, hashed_flds, addl_hdrs,
+ ICE_RSS_OUTER_HEADERS);
+ if (!status)
+ status = ice_rem_rss_cfg_sync(hw, vsi_handle, hashed_flds,
+ addl_hdrs, ICE_RSS_INNER_HEADERS);
+ mutex_unlock(&hw->rss_locks);
+
+ return status;
+}
+#endif /* CONFIG_PCI_IOV */
+
/* Mapping of AVF hash bit fields to an L3-L4 hash combination.
* As the ice_flow_avf_hdr_field represent individual bit shifts in a hash,
* convert its values to their appropriate flow L3, L4 values.
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index f3cfcfd2c296..46b9fbb3dbe7 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -408,5 +408,10 @@ enum ice_status ice_rem_vsi_rss_cfg(struct ice_hw *hw, u16 vsi_handle);
enum ice_status
ice_add_rss_cfg(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,
u32 addl_hdrs);
+#ifdef CONFIG_PCI_IOV
+enum ice_status
+ice_rem_rss_cfg(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,
+ u32 addl_hdrs);
+#endif /* CONFIG_PCI_IOV */
u64 ice_get_rss_cfg(struct ice_hw *hw, u16 vsi_handle, u32 hdrs);
#endif /* _ICE_FLOW_H_ */
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index ede343016f94..bc80440151b7 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -2584,8 +2584,21 @@ static int ice_vc_handle_rss_cfg(struct ice_vf *vf, u8 *msg, bool add)
vsi->vsi_num, v_ret);
}
} else {
- v_ret = VIRTCHNL_STATUS_ERR_PARAM;
- dev_err(dev, "RSS removal not support\n");
+ enum ice_status status;
+
+ status = ice_rem_rss_cfg(hw, vsi->idx, hash_flds,
+ addl_hdrs);
+ /* We just ignore ICE_ERR_DOES_NOT_EXIST, because
+ * if two configurations share the same profile remove
+ * one of them actually removes both, since the
+ * profile is deleted.
+ */
+ if (status && status != ICE_ERR_DOES_NOT_EXIST) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ dev_err(dev,
+ "ice_rem_rss_cfg failed for vsi = %d, v_ret = %d\n",
+ vsi->vsi_num, v_ret);
+ }
}
}
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 09/14] ice: Add support for per VF ctrl VSI enabling
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (7 preceding siblings ...)
2020-07-02 22:57 ` [Intel-wired-lan] [PATCH S48 v3 08/14] ice: Support RSS configure removal " Qi Zhang
@ 2020-07-02 22:58 ` Qi Zhang
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF Qi Zhang
` (5 subsequent siblings)
14 siblings, 0 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:58 UTC (permalink / raw)
To: intel-wired-lan
We are going to enable FDIR configure for AVF through virtual channel.
The first step is to add helper functions to support control VSI setup.
A control VSI will be allocated for a VF when AVF creates its
first FDIR rule through ice_vf_ctrl_vsi_setup().
The patch will also allocate FDIR rule space for VF's control VSI.
If a VF asks for flow director rules, then those should come entirely
from the best effort pool and not from the guaranteed pool. The patch
allow a VF VSI to have only space in the best effort rules.
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice.h | 4 +-
drivers/net/ethernet/intel/ice/ice_lib.c | 64 +++++++++++++++++++++---
drivers/net/ethernet/intel/ice/ice_main.c | 9 +++-
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 62 +++++++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 2 +
5 files changed, 130 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index 5fde85c70e2e..f3b8b694b0a0 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -68,7 +68,7 @@
#define ICE_AQ_LEN 64
#define ICE_MBXSQ_LEN 64
#define ICE_MIN_MSIX 2
-#define ICE_FDIR_MSIX 1
+#define ICE_FDIR_MSIX 2
#define ICE_NO_VSI 0xffff
#define ICE_VSI_MAP_CONTIG 0
#define ICE_VSI_MAP_SCATTER 1
@@ -79,6 +79,8 @@
#define ICE_MAX_LG_RSS_QS 256
#define ICE_RES_VALID_BIT 0x8000
#define ICE_RES_MISC_VEC_ID (ICE_RES_VALID_BIT - 1)
+/* All VF control VSIs share the same irq, so assign a unique ID for them */
+#define ICE_RES_VF_CTRL_VEC_ID (ICE_RES_MISC_VEC_ID - 1)
#define ICE_INVAL_Q_INDEX 0xffff
#define ICE_INVAL_VFID 256
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 2e3a39cea2c0..267a5e835ef0 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -332,6 +332,9 @@ int ice_vsi_clear(struct ice_vsi *vsi)
pf->vsi[vsi->idx] = NULL;
if (vsi->idx < pf->next_vsi && vsi->type != ICE_VSI_CTRL)
pf->next_vsi = vsi->idx;
+ if (vsi->idx < pf->next_vsi && vsi->type == ICE_VSI_CTRL &&
+ vsi->vf_id != ICE_INVAL_VFID)
+ pf->next_vsi = vsi->idx;
ice_vsi_free_arrays(vsi);
mutex_unlock(&pf->sw_mutex);
@@ -443,8 +446,8 @@ ice_vsi_alloc(struct ice_pf *pf, enum ice_vsi_type vsi_type, u16 vf_id)
goto unlock_pf;
}
- if (vsi->type == ICE_VSI_CTRL) {
- /* Use the last VSI slot as the index for the control VSI */
+ if (vsi->type == ICE_VSI_CTRL && vf_id == ICE_INVAL_VFID) {
+ /* Use the last VSI slot as the index for PF control VSI */
vsi->idx = pf->num_alloc_vsi - 1;
pf->ctrl_vsi_idx = vsi->idx;
pf->vsi[vsi->idx] = vsi;
@@ -457,6 +460,9 @@ ice_vsi_alloc(struct ice_pf *pf, enum ice_vsi_type vsi_type, u16 vf_id)
pf->next_vsi = ice_get_free_slot(pf->vsi, pf->num_alloc_vsi,
pf->next_vsi);
}
+
+ if (vsi->type == ICE_VSI_CTRL && vf_id != ICE_INVAL_VFID)
+ pf->vf[vf_id].ctrl_vsi_idx = vsi->idx;
goto unlock_pf;
err_rings:
@@ -495,7 +501,7 @@ static int ice_alloc_fd_res(struct ice_vsi *vsi)
if (!b_val)
return -EPERM;
- if (vsi->type != ICE_VSI_PF)
+ if (!(vsi->type == ICE_VSI_PF || vsi->type == ICE_VSI_VF))
return -EPERM;
if (!test_bit(ICE_FLAG_FD_ENA, pf->flags))
@@ -506,6 +512,13 @@ static int ice_alloc_fd_res(struct ice_vsi *vsi)
/* each VSI gets same "best_effort" quota */
vsi->num_bfltr = b_val;
+ if (vsi->type == ICE_VSI_VF) {
+ vsi->num_gfltr = 0;
+
+ /* each VSI gets same "best_effort" quota */
+ vsi->num_bfltr = b_val;
+ }
+
return 0;
}
@@ -845,7 +858,8 @@ static void ice_set_fd_vsi_ctx(struct ice_vsi_ctx *ctxt, struct ice_vsi *vsi)
u8 dflt_q_group, dflt_q_prio;
u16 dflt_q, report_q, val;
- if (vsi->type != ICE_VSI_PF && vsi->type != ICE_VSI_CTRL)
+ if (vsi->type != ICE_VSI_PF && vsi->type != ICE_VSI_CTRL &&
+ vsi->type != ICE_VSI_VF)
return;
val = ICE_AQ_VSI_PROP_FLOW_DIR_VALID;
@@ -1168,7 +1182,24 @@ static int ice_vsi_setup_vector_base(struct ice_vsi *vsi)
num_q_vectors = vsi->num_q_vectors;
/* reserve slots from OS requested IRQs */
- base = ice_get_res(pf, pf->irq_tracker, num_q_vectors, vsi->idx);
+ if (vsi->type == ICE_VSI_CTRL && vsi->vf_id != ICE_INVAL_VFID) {
+ struct ice_vf *vf;
+ int i;
+
+ ice_for_each_vf(pf, i) {
+ vf = &pf->vf[i];
+ if (i != vsi->vf_id && vf->ctrl_vsi_idx != ICE_NO_VSI) {
+ base = pf->vsi[vf->ctrl_vsi_idx]->base_vector;
+ break;
+ }
+ }
+ if (i == pf->num_alloc_vfs)
+ base = ice_get_res(pf, pf->irq_tracker, num_q_vectors,
+ ICE_RES_VF_CTRL_VEC_ID);
+ } else {
+ base = ice_get_res(pf, pf->irq_tracker, num_q_vectors,
+ vsi->idx);
+ }
if (base < 0) {
dev_err(dev, "%d MSI-X interrupts available. %s %d failed to get %d MSI-X vectors\n",
@@ -2127,7 +2158,7 @@ ice_vsi_setup(struct ice_pf *pf, struct ice_port_info *pi,
struct ice_vsi *vsi;
int ret, i;
- if (vsi_type == ICE_VSI_VF)
+ if (vsi_type == ICE_VSI_VF || vsi_type == ICE_VSI_CTRL)
vsi = ice_vsi_alloc(pf, vsi_type, vf_id);
else
vsi = ice_vsi_alloc(pf, vsi_type, ICE_INVAL_VFID);
@@ -2142,7 +2173,7 @@ ice_vsi_setup(struct ice_pf *pf, struct ice_port_info *pi,
if (vsi->type == ICE_VSI_PF)
vsi->ethtype = ETH_P_PAUSE;
- if (vsi->type == ICE_VSI_VF)
+ if (vsi->type == ICE_VSI_VF || vsi->type == ICE_VSI_CTRL)
vsi->vf_id = vf_id;
ice_alloc_fd_res(vsi);
@@ -2583,7 +2614,24 @@ int ice_vsi_release(struct ice_vsi *vsi)
* many interrupts each VF needs. SR-IOV MSIX resources are also
* cleared in the same manner.
*/
- if (vsi->type != ICE_VSI_VF) {
+ if (vsi->type == ICE_VSI_CTRL && vsi->vf_id != ICE_INVAL_VFID) {
+ struct ice_vf *vf;
+ int i;
+
+ ice_for_each_vf(pf, i) {
+ vf = &pf->vf[i];
+ if (i != vsi->vf_id && vf->ctrl_vsi_idx != ICE_NO_VSI)
+ break;
+ }
+ if (i == pf->num_alloc_vfs) {
+ /* No other VFs left that have control VSI, reclaim SW
+ * interrupts back to the common pool
+ */
+ ice_free_res(pf->irq_tracker, vsi->base_vector,
+ ICE_RES_VF_CTRL_VEC_ID);
+ pf->num_avail_sw_msix += vsi->num_q_vectors;
+ }
+ } else if (vsi->type != ICE_VSI_VF) {
/* reclaim SW interrupts back to the common pool */
ice_free_res(pf->irq_tracker, vsi->base_vector, vsi->idx);
pf->num_avail_sw_msix += vsi->num_q_vectors;
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 983b5e21b436..8afd33bdd637 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -1630,8 +1630,13 @@ static int ice_vsi_req_irq_msix(struct ice_vsi *vsi, char *basename)
/* skip this unused q_vector */
continue;
}
- err = devm_request_irq(dev, irq_num, vsi->irq_handler, 0,
- q_vector->name, q_vector);
+ if (vsi->type == ICE_VSI_CTRL && vsi->vf_id != ICE_INVAL_VFID)
+ err = devm_request_irq(dev, irq_num, vsi->irq_handler,
+ IRQF_SHARED, q_vector->name,
+ q_vector);
+ else
+ err = devm_request_irq(dev, irq_num, vsi->irq_handler,
+ 0, q_vector->name, q_vector);
if (err) {
netdev_err(vsi->netdev, "MSIX request_irq failed, error: %d\n",
err);
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index bc80440151b7..ddd6062c5b8b 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -442,6 +442,25 @@ static void ice_vf_vsi_release(struct ice_vf *vf)
}
/**
+ * ice_vf_ctrl_invalidate_vsi - invalidate ctrl_vsi_idx to remove VSI access
+ * @vf: VF that control VSI is being invalidated on
+ */
+static void ice_vf_ctrl_invalidate_vsi(struct ice_vf *vf)
+{
+ vf->ctrl_vsi_idx = ICE_NO_VSI;
+}
+
+/**
+ * ice_vf_ctrl_vsi_release - invalidate the VF's control VSI after freeing it
+ * @vf: VF that control VSI is being released on
+ */
+static void ice_vf_ctrl_vsi_release(struct ice_vf *vf)
+{
+ ice_vsi_release(vf->pf->vsi[vf->ctrl_vsi_idx]);
+ ice_vf_ctrl_invalidate_vsi(vf);
+}
+
+/**
* ice_free_vf_res - Free a VF's resources
* @vf: pointer to the VF info
*/
@@ -454,6 +473,9 @@ static void ice_free_vf_res(struct ice_vf *vf)
* accessing the VF's VSI after it's freed or invalidated.
*/
clear_bit(ICE_VF_STATE_INIT, vf->vf_states);
+ /* free VF control VSI */
+ if (vf->ctrl_vsi_idx != ICE_NO_VSI)
+ ice_vf_ctrl_vsi_release(vf);
/* free VSI and disconnect it from the parent uplink */
if (vf->lan_vsi_idx != ICE_NO_VSI) {
@@ -806,6 +828,29 @@ static struct ice_vsi *ice_vf_vsi_setup(struct ice_vf *vf)
}
/**
+ * ice_vf_ctrl_vsi_setup - Set up a VF control VSI
+ * @vf: VF to setup control VSI for
+ *
+ * Returns pointer to the successfully allocated VSI struct on success,
+ * otherwise returns NULL on failure.
+ */
+struct ice_vsi *ice_vf_ctrl_vsi_setup(struct ice_vf *vf)
+{
+ struct ice_port_info *pi = ice_vf_get_port_info(vf);
+ struct ice_pf *pf = vf->pf;
+ struct ice_vsi *vsi;
+
+ vsi = ice_vsi_setup(pf, pi, ICE_VSI_CTRL, vf->vf_id);
+
+ if (!vsi) {
+ dev_err(ice_pf_to_dev(pf), "Failed to create VF control VSI\n");
+ ice_vf_ctrl_invalidate_vsi(vf);
+ }
+
+ return vsi;
+}
+
+/**
* ice_calc_vf_first_vector_idx - Calculate MSIX vector index in the PF space
* @pf: pointer to PF structure
* @vf: pointer to VF that the first MSIX vector index is being calculated for
@@ -1467,6 +1512,12 @@ bool ice_reset_all_vfs(struct ice_pf *pf, bool is_vflr)
ice_for_each_vf(pf, v) {
vf = &pf->vf[v];
+ /* clean VF control VSI when resetting VFs since it should be
+ * setup only when iAVF creates its first FDIR rule.
+ */
+ if (vf->ctrl_vsi_idx != ICE_NO_VSI)
+ ice_vf_ctrl_invalidate_vsi(vf);
+
ice_vf_pre_vsi_rebuild(vf);
ice_vf_rebuild_vsi(vf);
ice_vf_post_vsi_rebuild(vf);
@@ -1588,6 +1639,12 @@ bool ice_reset_vf(struct ice_vf *vf, bool is_vflr)
dev_err(dev, "disabling promiscuous mode failed\n");
}
+ /* clean VF control VSI when resetting VF since it should be setup
+ * only when iAVF creates its first FDIR rule.
+ */
+ if (vf->ctrl_vsi_idx != ICE_NO_VSI)
+ ice_vf_ctrl_vsi_release(vf);
+
ice_vf_pre_vsi_rebuild(vf);
ice_vf_rebuild_vsi_with_release(vf);
ice_vf_post_vsi_rebuild(vf);
@@ -1778,6 +1835,11 @@ static void ice_set_dflt_settings_vfs(struct ice_pf *pf)
set_bit(ICE_VIRTCHNL_VF_CAP_L2, &vf->vf_caps);
vf->spoofchk = true;
vf->num_vf_qs = pf->num_qps_per_vf;
+
+ /* ctrl_vsi_idx will be set to a valid value only when iAVF
+ * creates its first fdir rule.
+ */
+ ice_vf_ctrl_invalidate_vsi(vf);
}
}
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
index 25dcdd86d663..61e7daf7861e 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
@@ -73,6 +73,7 @@ struct ice_vf {
u16 vf_id; /* VF ID in the PF space */
u16 lan_vsi_idx; /* index into PF struct */
+ u16 ctrl_vsi_idx;
/* first vector index of this VF in the PF space */
int first_vector_idx;
struct ice_sw *vf_sw_id; /* switch ID the VF VSIs connect to */
@@ -140,6 +141,7 @@ void
ice_vf_lan_overflow_event(struct ice_pf *pf, struct ice_rq_event_info *event);
void ice_print_vfs_mdd_events(struct ice_pf *pf);
void ice_print_vf_rx_mdd_event(struct ice_vf *vf);
+struct ice_vsi *ice_vf_ctrl_vsi_setup(struct ice_vf *vf);
#else /* CONFIG_PCI_IOV */
#define ice_process_vflr_event(pf) do {} while (0)
#define ice_free_vfs(pf) do {} while (0)
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (8 preceding siblings ...)
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 09/14] ice: Add support for per VF ctrl VSI enabling Qi Zhang
@ 2020-07-02 22:58 ` Qi Zhang
2020-07-03 5:29 ` Kirsher, Jeffrey T
2020-07-03 9:08 ` kernel test robot
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 11/14] ice: Add non-IP Layer2 protocol FDIR filter " Qi Zhang
` (4 subsequent siblings)
14 siblings, 2 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:58 UTC (permalink / raw)
To: intel-wired-lan
Add virtual channel support for iAVF FDIR add/validate/delete filter.
iAVF FDIR is Flow Director for intel Adaptive Virtual Function which can
direct Ethernet packets to the queues of the Network Interface Card.
Add/delete command is adding or deleting one rule for each virtual
channel message, while validate command is just verifying if this rule
is valid without any other operations.
To add or delete one rule, driver needs to config TCAM and Profile,
build training packets which contains the input set value, and send
the training packets through FDIR tx queue. In addition, driver needs to
manage the software context to avoid adding duplicated rules, deleting
non-existent rule, input set conflicts and other invalid cases.
Due to different requirement for FDIR descriptor configure between PF
and AVF, the patch also add more flexibility for the metadata setup,
these include:
1. Statistic mode.
2. FDID priority.
3. Complete Report mode.
Also two new FDIR action "passthrough" and "to queue region" are
enabled.
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Simei Su <simei.su@intel.com>
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/Makefile | 2 +-
drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 4 +
drivers/net/ethernet/intel/ice/ice_fdir.c | 18 +-
drivers/net/ethernet/intel/ice/ice_fdir.h | 10 +
drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 2 +
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 1398 ++++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h | 24 +
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 17 +-
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 6 +
include/linux/avf/virtchnl.h | 122 ++
10 files changed, 1596 insertions(+), 7 deletions(-)
create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
diff --git a/drivers/net/ethernet/intel/ice/Makefile b/drivers/net/ethernet/intel/ice/Makefile
index eb83b5fe11c3..229740c3c1e1 100644
--- a/drivers/net/ethernet/intel/ice/Makefile
+++ b/drivers/net/ethernet/intel/ice/Makefile
@@ -24,7 +24,7 @@ ice-y := ice_main.o \
ice_flow.o \
ice_devlink.o \
ice_ethtool.o
-ice-$(CONFIG_PCI_IOV) += ice_virtchnl_pf.o ice_sriov.o ice_dcf.o
+ice-$(CONFIG_PCI_IOV) += ice_virtchnl_pf.o ice_sriov.o ice_dcf.o ice_virtchnl_fdir.o
ice-$(CONFIG_DCB) += ice_dcb.o ice_dcb_nl.o ice_dcb_lib.o
ice-$(CONFIG_RFS_ACCEL) += ice_arfs.o
ice-$(CONFIG_XDP_SOCKETS) += ice_xsk.o
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
index d7430ce6af26..5655e54e8a56 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
@@ -1675,6 +1675,10 @@ int ice_add_fdir_ethtool(struct ice_vsi *vsi, struct ethtool_rxnfc *cmd)
input->flex_offset = userdata.flex_offset;
}
+ input->cnt_ena = ICE_FXD_FLTR_QW0_STAT_ENA_PKTS;
+ input->fdid_prio = ICE_FXD_FLTR_QW1_FDID_PRI_THREE;
+ input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
+
/* input struct is added to the HW filter list */
ice_fdir_update_list_entry(pf, input, fsp->location);
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
index 6834df14332f..d97d9197135d 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
@@ -374,21 +374,31 @@ ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input,
if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) {
fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES;
fdir_fltr_ctx.qindex = 0;
+ } else if (input->dest_ctl ==
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) {
+ fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;
+ fdir_fltr_ctx.qindex = 0;
} else {
+ if (input->dest_ctl ==
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP)
+ fdir_fltr_ctx.toq = input->q_region;
fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;
fdir_fltr_ctx.qindex = input->q_index;
}
- fdir_fltr_ctx.cnt_ena = ICE_FXD_FLTR_QW0_STAT_ENA_PKTS;
+ fdir_fltr_ctx.cnt_ena = input->cnt_ena;
fdir_fltr_ctx.cnt_index = input->cnt_index;
fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi);
fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE;
- fdir_fltr_ctx.toq_prio = 3;
+ if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER)
+ fdir_fltr_ctx.toq_prio = 0;
+ else
+ fdir_fltr_ctx.toq_prio = 3;
fdir_fltr_ctx.pcmd = add ? ICE_FXD_FLTR_QW1_PCMD_ADD :
ICE_FXD_FLTR_QW1_PCMD_REMOVE;
fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;
fdir_fltr_ctx.comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO;
- fdir_fltr_ctx.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
- fdir_fltr_ctx.fdid_prio = 3;
+ fdir_fltr_ctx.comp_report = input->comp_report;
+ fdir_fltr_ctx.fdid_prio = input->fdid_prio;
fdir_fltr_ctx.desc_prof = 1;
fdir_fltr_ctx.desc_prof_prio = 3;
ice_set_fd_desc_val(&fdir_fltr_ctx, fdesc);
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h b/drivers/net/ethernet/intel/ice/ice_fdir.h
index 1c587766daab..6b7d8ccd39b7 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.h
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
@@ -25,6 +25,9 @@
#define ICE_IPV6_UDP_DST_PORT_OFFSET 56
#define ICE_IPV6_SCTP_SRC_PORT_OFFSET 54
#define ICE_IPV6_SCTP_DST_PORT_OFFSET 56
+
+#define ICE_FDIR_MAX_FLTRS 16384
+
/* IP v4 has 2 flag bits that enable fragment processing: DF and MF. DF
* requests that the packet not be fragmented. MF indicates that a packet has
* been fragmented.
@@ -34,6 +37,8 @@
enum ice_fltr_prgm_desc_dest {
ICE_FLTR_PRGM_DESC_DEST_DROP_PKT,
ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX,
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP,
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER,
};
enum ice_fltr_prgm_desc_fd_status {
@@ -122,6 +127,8 @@ struct ice_fdir_fltr {
/* flex byte filter data */
__be16 flex_word;
+ /* queue region size (=2^q_region) */
+ u8 q_region;
u16 flex_offset;
u16 flex_fltr;
@@ -129,9 +136,12 @@ struct ice_fdir_fltr {
u16 q_index;
u16 dest_vsi;
u8 dest_ctl;
+ u8 cnt_ena;
u8 fltr_status;
u16 cnt_index;
u32 fltr_id;
+ u8 fdid_prio;
+ u8 comp_report;
};
/* Dummy packet filter definition structure */
diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
index 14dfbbc1b2cf..1382c498e1f0 100644
--- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
+++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
@@ -55,6 +55,7 @@ struct ice_fltr_desc {
#define ICE_FXD_FLTR_QW0_COMP_REPORT_M \
(0x3ULL << ICE_FXD_FLTR_QW0_COMP_REPORT_S)
#define ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL 0x1ULL
+#define ICE_FXD_FLTR_QW0_COMP_REPORT_SW 0x2ULL
#define ICE_FXD_FLTR_QW0_FD_SPACE_S 14
#define ICE_FXD_FLTR_QW0_FD_SPACE_M (0x3ULL << ICE_FXD_FLTR_QW0_FD_SPACE_S)
@@ -128,6 +129,7 @@ struct ice_fltr_desc {
#define ICE_FXD_FLTR_QW1_FDID_PRI_S 25
#define ICE_FXD_FLTR_QW1_FDID_PRI_M (0x7ULL << ICE_FXD_FLTR_QW1_FDID_PRI_S)
#define ICE_FXD_FLTR_QW1_FDID_PRI_ONE 0x1ULL
+#define ICE_FXD_FLTR_QW1_FDID_PRI_THREE 0x3ULL
#define ICE_FXD_FLTR_QW1_FDID_MDID_S 28
#define ICE_FXD_FLTR_QW1_FDID_MDID_M (0xFULL << ICE_FXD_FLTR_QW1_FDID_MDID_S)
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
new file mode 100644
index 000000000000..53194e26a3cf
--- /dev/null
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
@@ -0,0 +1,1398 @@
+
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2018-2020, Intel Corporation. */
+
+#include "ice.h"
+#include "ice_base.h"
+#include "ice_lib.h"
+#include "ice_flow.h"
+
+#define to_fltr_conf_from_desc(p) \
+ container_of(p, struct virtchnl_fdir_fltr_conf, input)
+
+#define ICE_FLOW_PROF_TYPE_S 0
+#define ICE_FLOW_PROF_TYPE_M (0xFFFFFFFFULL << ICE_FLOW_PROF_TYPE_S)
+#define ICE_FLOW_PROF_VSI_S 32
+#define ICE_FLOW_PROF_VSI_M (0xFFFFFFFFULL << ICE_FLOW_PROF_VSI_S)
+
+/* Flow profile ID format:
+ * [0:31] - flow type, flow + tun_offs
+ * [32:63] - VSI index
+ */
+#define ICE_FLOW_PROF_FD(vsi, flow, tun_offs) \
+ (u64)(((((flow) + (tun_offs)) & ICE_FLOW_PROF_TYPE_M)) | \
+ (((u64)(vsi) << ICE_FLOW_PROF_VSI_S) & ICE_FLOW_PROF_VSI_M))
+
+struct virtchnl_fdir_fltr_conf {
+ struct ice_fdir_fltr input;
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_tcp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_TCP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_udp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_sctp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_SCTP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_tcp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_TCP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_udp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_sctp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_SCTP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+struct virtchnl_fdir_pattern_match_item {
+ enum virtchnl_proto_hdr_type *list;
+ u64 input_set;
+ u64 *meta;
+};
+
+static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern[] = {
+ {vc_pattern_ipv4, 0, NULL},
+ {vc_pattern_ipv4_tcp, 0, NULL},
+ {vc_pattern_ipv4_udp, 0, NULL},
+ {vc_pattern_ipv4_sctp, 0, NULL},
+ {vc_pattern_ipv6, 0, NULL},
+ {vc_pattern_ipv6_tcp, 0, NULL},
+ {vc_pattern_ipv6_udp, 0, NULL},
+ {vc_pattern_ipv6_sctp, 0, NULL},
+};
+
+struct virtchnl_fdir_inset_map {
+ enum virtchnl_proto_hdr_field field;
+ enum ice_flow_field fld;
+};
+
+static const struct virtchnl_fdir_inset_map fdir_inset_map[] = {
+ {VIRTCHNL_PROTO_HDR_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
+ {VIRTCHNL_PROTO_HDR_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},
+ {VIRTCHNL_PROTO_HDR_IPV4_DSCP, ICE_FLOW_FIELD_IDX_IPV4_DSCP},
+ {VIRTCHNL_PROTO_HDR_IPV4_TTL, ICE_FLOW_FIELD_IDX_IPV4_TTL},
+ {VIRTCHNL_PROTO_HDR_IPV4_PROT, ICE_FLOW_FIELD_IDX_IPV4_PROT},
+ {VIRTCHNL_PROTO_HDR_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA},
+ {VIRTCHNL_PROTO_HDR_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA},
+ {VIRTCHNL_PROTO_HDR_IPV6_TC, ICE_FLOW_FIELD_IDX_IPV6_DSCP},
+ {VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT, ICE_FLOW_FIELD_IDX_IPV6_TTL},
+ {VIRTCHNL_PROTO_HDR_IPV6_PROT, ICE_FLOW_FIELD_IDX_IPV6_PROT},
+ {VIRTCHNL_PROTO_HDR_UDP_SRC_PORT, ICE_FLOW_FIELD_IDX_UDP_SRC_PORT},
+ {VIRTCHNL_PROTO_HDR_UDP_DST_PORT, ICE_FLOW_FIELD_IDX_UDP_DST_PORT},
+ {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT, ICE_FLOW_FIELD_IDX_TCP_SRC_PORT},
+ {VIRTCHNL_PROTO_HDR_TCP_DST_PORT, ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
+ {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT, ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
+ {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT, ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
+};
+
+/**
+ * ice_vc_fdir_param_check
+ * @vf: pointer to the VF structure
+ * @vsi_id: VF relative VSI ID
+ *
+ * Check for the valid VSI ID, PF's state and VF's state
+ *
+ * Return: 0 on success, and -EINVAL on error.
+ */
+static int
+ice_vc_fdir_param_check(struct ice_vf *vf, u16 vsi_id)
+{
+ struct ice_pf *pf = vf->pf;
+
+ if (!test_bit(ICE_FLAG_FD_ENA, pf->flags))
+ return -EINVAL;
+
+ if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states))
+ return -EINVAL;
+
+ if (!(vf->driver_caps & VIRTCHNL_VF_OFFLOAD_FDIR_PF))
+ return -EINVAL;
+
+ if (vsi_id != vf->lan_vsi_num)
+ return -EINVAL;
+
+ if (!ice_vc_isvalid_vsi_id(vf, vsi_id))
+ return -EINVAL;
+
+ if (!pf->vsi[vf->lan_vsi_idx])
+ return -EINVAL;
+
+ return 0;
+}
+
+/**
+ * ice_vf_start_ctrl_vsi
+ * @vf: pointer to the VF structure
+ *
+ * Allocate ctrl_vsi for the first time and open the ctrl_vsi port for VF
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int ice_vf_start_ctrl_vsi(struct ice_vf *vf)
+{
+ struct ice_pf *pf = vf->pf;
+ struct ice_vsi *ctrl_vsi;
+ struct device *dev;
+ int err;
+
+ dev = ice_pf_to_dev(pf);
+ if (vf->ctrl_vsi_idx != ICE_NO_VSI)
+ return -EEXIST;
+
+ ctrl_vsi = ice_vf_ctrl_vsi_setup(vf);
+ if (!ctrl_vsi) {
+ dev_dbg(dev, "Could not setup control VSI for VF %d\n",
+ vf->vf_id);
+ return -ENOMEM;
+ }
+
+ err = ice_vsi_open_ctrl(ctrl_vsi);
+ if (err) {
+ dev_dbg(dev, "Could not open control VSI for VF %d\n",
+ vf->vf_id);
+ goto err_vsi_open;
+ }
+
+ return 0;
+
+err_vsi_open:
+ ice_vsi_release(ctrl_vsi);
+ if (vf->ctrl_vsi_idx != ICE_NO_VSI) {
+ pf->vsi[vf->ctrl_vsi_idx] = NULL;
+ vf->ctrl_vsi_idx = ICE_NO_VSI;
+ }
+ return err;
+}
+
+/**
+ * ice_vc_fdir_alloc_prof - allocate profile for this filter flow type
+ * @vf: pointer to the VF structure
+ * @flow: filter flow type
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_alloc_prof(struct ice_vf *vf, enum ice_fltr_ptype flow)
+{
+ struct ice_vf_fdir *fdir = &vf->fdir;
+
+ if (!fdir->fdir_prof) {
+ fdir->fdir_prof = devm_kcalloc(ice_pf_to_dev(vf->pf),
+ ICE_FLTR_PTYPE_MAX,
+ sizeof(*fdir->fdir_prof),
+ GFP_KERNEL);
+ if (!fdir->fdir_prof)
+ return -ENOMEM;
+ }
+
+ if (!fdir->fdir_prof[flow]) {
+ fdir->fdir_prof[flow] = devm_kzalloc(ice_pf_to_dev(vf->pf),
+ sizeof(**fdir->fdir_prof),
+ GFP_KERNEL);
+ if (!fdir->fdir_prof[flow])
+ return -ENOMEM;
+ }
+
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_free_prof - free profile for this filter flow type
+ * @vf: pointer to the VF structure
+ * @flow: filter flow type
+ */
+static void
+ice_vc_fdir_free_prof(struct ice_vf *vf, enum ice_fltr_ptype flow)
+{
+ struct ice_vf_fdir *fdir = &vf->fdir;
+
+ if (!fdir->fdir_prof)
+ return;
+
+ if (!fdir->fdir_prof[flow])
+ return;
+
+ devm_kfree(ice_pf_to_dev(vf->pf), fdir->fdir_prof[flow]);
+ fdir->fdir_prof[flow] = NULL;
+}
+
+/**
+ * ice_vc_fdir_free_prof_all - free all the profile for this VF
+ * @vf: pointer to the VF structure
+ */
+static void ice_vc_fdir_free_prof_all(struct ice_vf *vf)
+{
+ struct ice_vf_fdir *fdir = &vf->fdir;
+ enum ice_fltr_ptype flow;
+
+ if (!fdir->fdir_prof)
+ return;
+
+ for (flow = ICE_FLTR_PTYPE_NONF_NONE; flow < ICE_FLTR_PTYPE_MAX; flow++)
+ ice_vc_fdir_free_prof(vf, flow);
+
+ devm_kfree(ice_pf_to_dev(vf->pf), fdir->fdir_prof);
+ fdir->fdir_prof = NULL;
+}
+
+/**
+ * ice_vc_fdir_parse_flow_fld
+ * @proto_hdr: virtual channel protocol filter header
+ * @conf: FDIR configuration for each filter
+ * @fld: field type array
+ * @fld_cnt: field counter
+ *
+ * Parse the virtual channel filter header and store them into field type array
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_parse_flow_fld(struct virtchnl_proto_hdr *proto_hdr,
+ struct virtchnl_fdir_fltr_conf *conf,
+ enum ice_flow_field *fld, int *fld_cnt)
+{
+ struct virtchnl_proto_hdr hdr;
+ u32 i;
+
+ memcpy(&hdr, proto_hdr, sizeof(hdr));
+
+ for (i = 0; (i < ARRAY_SIZE(fdir_inset_map)) &&
+ VIRTCHNL_GET_PROTO_HDR_FIELD(&hdr); i++)
+ if (VIRTCHNL_TEST_PROTO_HDR(&hdr, fdir_inset_map[i].field)) {
+ fld[*fld_cnt] = fdir_inset_map[i].fld;
+ *fld_cnt += 1;
+ if (*fld_cnt >= ICE_FLOW_FIELD_IDX_MAX)
+ return -EINVAL;
+ VIRTCHNL_DEL_PROTO_HDR_FIELD(&hdr,
+ fdir_inset_map[i].field);
+ }
+
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_set_flow_fld
+ * @vf: pointer to the VF structure
+ * @fltr: virtual channel add cmd buffer
+ * @conf: FDIR configuration for each filter
+ * @seg: array of one or more packet segments that describe the flow
+ *
+ * Parse the virtual channel add msg buffer's field vector and store them into
+ * flow's packet segment field
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_set_flow_fld(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
+ struct virtchnl_fdir_fltr_conf *conf,
+ struct ice_flow_seg_info *seg)
+{
+ struct virtchnl_fdir_rule *rule = &fltr->rule_cfg;
+ enum ice_flow_field fld[ICE_FLOW_FIELD_IDX_MAX];
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ struct virtchnl_proto_hdrs *proto;
+ int fld_cnt = 0;
+ int i;
+
+ proto = &rule->proto_hdrs;
+ for (i = 0; i < proto->count; i++) {
+ struct virtchnl_proto_hdr *hdr = &proto->proto_hdr[i];
+ int ret;
+
+ ret = ice_vc_fdir_parse_flow_fld(hdr, conf, fld, &fld_cnt);
+ if (ret)
+ return ret;
+ }
+
+ if (fld_cnt == 0) {
+ dev_dbg(dev, "Empty input set for VF %d\n", vf->vf_id);
+ return -EINVAL;
+ }
+
+ for (i = 0; i < fld_cnt; i++)
+ ice_flow_set_fld(seg, fld[i],
+ ICE_FLOW_FLD_OFF_INVAL,
+ ICE_FLOW_FLD_OFF_INVAL,
+ ICE_FLOW_FLD_OFF_INVAL, false);
+
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_set_flow_fld - config the flow's packet segment header
+ * @vf: pointer to the VF structure
+ * @conf: FDIR configuration for each filter
+ * @seg: array of one or more packet segments that describe the flow
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
+ struct virtchnl_fdir_fltr_conf *conf,
+ struct ice_flow_seg_info *seg)
+{
+ enum ice_fltr_ptype flow = conf->input.flow_type;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+
+ switch (flow) {
+ case ICE_FLTR_PTYPE_NONF_IPV4_OTHER:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_TCP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_TCP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_UDP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_SCTP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_OTHER:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_TCP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_TCP |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_UDP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_SCTP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ default:
+ dev_dbg(dev, "Invalid flow type 0x%x for VF %d failed\n",
+ flow, vf->vf_id);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_rem_prof - remove profile for this filter flow type
+ * @vf: pointer to the VF structure
+ * @flow: filter flow type
+ * @tun: 0 implies non-tunnel type filter, 1 implies tunnel type filter
+ */
+static void
+ice_vc_fdir_rem_prof(struct ice_vf *vf, enum ice_fltr_ptype flow, int tun)
+{
+ struct ice_vf_fdir *fdir = &vf->fdir;
+ struct ice_fd_hw_prof *vf_prof;
+ struct ice_pf *pf = vf->pf;
+ struct ice_vsi *vf_vsi;
+ struct device *dev;
+ struct ice_hw *hw;
+ u64 prof_id;
+ int i;
+
+ dev = ice_pf_to_dev(pf);
+ hw = &pf->hw;
+ if (!fdir->fdir_prof || !fdir->fdir_prof[flow])
+ return;
+
+ vf_prof = fdir->fdir_prof[flow];
+
+ vf_vsi = pf->vsi[vf->lan_vsi_idx];
+ if (!vf_vsi) {
+ dev_dbg(dev, "NULL vf %d vsi pointer\n", vf->vf_id);
+ return;
+ }
+
+ if (!fdir->prof_entry_cnt[flow][tun])
+ return;
+
+ prof_id = ICE_FLOW_PROF_FD(vf_vsi->vsi_num,
+ flow, tun ? ICE_FLTR_PTYPE_MAX : 0);
+
+ for (i = 0; i < fdir->prof_entry_cnt[flow][tun]; i++)
+ if (vf_prof->entry_h[i][tun]) {
+ u16 vsi_num = ice_get_hw_vsi_num(hw, vf_prof->vsi_h[i]);
+
+ ice_rem_prof_id_flow(hw, ICE_BLK_FD, vsi_num, prof_id);
+ ice_flow_rem_entry(hw, ICE_BLK_FD,
+ vf_prof->entry_h[i][tun]);
+ vf_prof->entry_h[i][tun] = 0;
+ }
+
+ ice_flow_rem_prof(hw, ICE_BLK_FD, prof_id);
+ devm_kfree(dev, vf_prof->fdir_seg[tun]);
+ vf_prof->fdir_seg[tun] = NULL;
+
+ for (i = 0; i < vf_prof->cnt; i++)
+ vf_prof->vsi_h[i] = 0;
+
+ fdir->prof_entry_cnt[flow][tun] = 0;
+}
+
+/**
+ * ice_vc_fdir_rem_prof_all - remove profile for this VF
+ * @vf: pointer to the VF structure
+ */
+static void ice_vc_fdir_rem_prof_all(struct ice_vf *vf)
+{
+ enum ice_fltr_ptype flow;
+
+ for (flow = ICE_FLTR_PTYPE_NONF_NONE;
+ flow < ICE_FLTR_PTYPE_MAX; flow++) {
+ ice_vc_fdir_rem_prof(vf, flow, 0);
+ ice_vc_fdir_rem_prof(vf, flow, 1);
+ }
+}
+
+/**
+ * ice_vc_fdir_write_flow_prof
+ * @vf: pointer to the VF structure
+ * @flow: filter flow type
+ * @seg: array of one or more packet segments that describe the flow
+ * @tun: 0 implies non-tunnel type filter, 1 implies tunnel type filter
+ *
+ * Write the flow's profile config and packet segment into the hardware
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_write_flow_prof(struct ice_vf *vf, enum ice_fltr_ptype flow,
+ struct ice_flow_seg_info *seg, int tun)
+{
+ struct ice_vf_fdir *fdir = &vf->fdir;
+ struct ice_vsi *vf_vsi, *ctrl_vsi;
+ struct ice_flow_seg_info *old_seg;
+ struct ice_flow_prof *prof = NULL;
+ struct ice_fd_hw_prof *vf_prof;
+ enum ice_status status;
+ struct device *dev;
+ struct ice_pf *pf;
+ struct ice_hw *hw;
+ u64 entry1_h = 0;
+ u64 entry2_h = 0;
+ u64 prof_id;
+ int ret;
+
+ pf = vf->pf;
+ dev = ice_pf_to_dev(pf);
+ hw = &pf->hw;
+ vf_vsi = pf->vsi[vf->lan_vsi_idx];
+ if (!vf_vsi)
+ return -EINVAL;
+
+ ctrl_vsi = pf->vsi[vf->ctrl_vsi_idx];
+ if (!ctrl_vsi)
+ return -EINVAL;
+
+ vf_prof = fdir->fdir_prof[flow];
+ old_seg = vf_prof->fdir_seg[tun];
+ if (old_seg) {
+ if (!memcmp(old_seg, seg, sizeof(*seg))) {
+ dev_dbg(dev, "Duplicated profile for VF %d!\n",
+ vf->vf_id);
+ return -EEXIST;
+ }
+
+ if (fdir->fdir_fltr_cnt[flow][tun]) {
+ ret = -EINVAL;
+ dev_dbg(dev, "Input set conflicts for VF %d\n",
+ vf->vf_id);
+ goto err_exit;
+ }
+
+ /* remove previously allocated profile */
+ ice_vc_fdir_rem_prof(vf, flow, tun);
+ }
+
+ prof_id = ICE_FLOW_PROF_FD(vf_vsi->vsi_num,
+ flow, tun ? ICE_FLTR_PTYPE_MAX : 0);
+
+ status = ice_flow_add_prof(hw, ICE_BLK_FD, ICE_FLOW_RX, prof_id, seg,
+ tun + 1, &prof);
+ ret = ice_status_to_errno(status);
+ if (ret) {
+ dev_dbg(dev, "Could not add VSI flow 0x%x for VF %d\n",
+ flow, vf->vf_id);
+ goto err_exit;
+ }
+
+ status = ice_flow_add_entry(hw, ICE_BLK_FD, prof_id, vf_vsi->idx,
+ vf_vsi->idx, ICE_FLOW_PRIO_NORMAL,
+ seg, &entry1_h);
+ ret = ice_status_to_errno(status);
+ if (ret) {
+ dev_dbg(dev, "Could not add flow 0x%x VSI entry for VF %d\n",
+ flow, vf->vf_id);
+ goto err_prof;
+ }
+
+ status = ice_flow_add_entry(hw, ICE_BLK_FD, prof_id, vf_vsi->idx,
+ ctrl_vsi->idx, ICE_FLOW_PRIO_NORMAL,
+ seg, &entry2_h);
+ ret = ice_status_to_errno(status);
+ if (ret) {
+ dev_dbg(dev,
+ "Could not add flow 0x%x Ctrl VSI entry for VF %d\n",
+ flow, vf->vf_id);
+ goto err_entry_1;
+ }
+
+ vf_prof->fdir_seg[tun] = seg;
+ vf_prof->cnt = 0;
+ fdir->prof_entry_cnt[flow][tun] = 0;
+
+ vf_prof->entry_h[vf_prof->cnt][tun] = entry1_h;
+ vf_prof->vsi_h[vf_prof->cnt] = vf_vsi->idx;
+ vf_prof->cnt++;
+ fdir->prof_entry_cnt[flow][tun]++;
+
+ vf_prof->entry_h[vf_prof->cnt][tun] = entry2_h;
+ vf_prof->vsi_h[vf_prof->cnt] = ctrl_vsi->idx;
+ vf_prof->cnt++;
+ fdir->prof_entry_cnt[flow][tun]++;
+
+ return 0;
+
+err_entry_1:
+ ice_rem_prof_id_flow(hw, ICE_BLK_FD,
+ ice_get_hw_vsi_num(hw, vf_vsi->idx), prof_id);
+ ice_flow_rem_entry(hw, ICE_BLK_FD, entry1_h);
+err_prof:
+ ice_flow_rem_prof(hw, ICE_BLK_FD, prof_id);
+err_exit:
+ return ret;
+}
+
+/**
+ * ice_vc_fdir_config_input_set
+ * @vf: pointer to the VF structure
+ * @fltr: virtual channel add cmd buffer
+ * @conf: FDIR configuration for each filter
+ * @tun: 0 implies non-tunnel type filter, 1 implies tunnel type filter
+ *
+ * Config the input set type and value for virtual channel add msg buffer
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_config_input_set(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
+ struct virtchnl_fdir_fltr_conf *conf, int tun)
+{
+ struct ice_fdir_fltr *input = &conf->input;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ struct ice_flow_seg_info *seg;
+ enum ice_fltr_ptype flow;
+ int ret;
+
+ flow = input->flow_type;
+ ret = ice_vc_fdir_alloc_prof(vf, flow);
+ if (ret) {
+ dev_dbg(dev, "Alloc flow prof for VF %d failed\n", vf->vf_id);
+ return ret;
+ }
+
+ seg = devm_kzalloc(dev, sizeof(*seg), GFP_KERNEL);
+ if (!seg)
+ return -ENOMEM;
+
+ ret = ice_vc_fdir_set_flow_fld(vf, fltr, conf, seg);
+ if (ret) {
+ dev_dbg(dev, "Set flow field for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ ret = ice_vc_fdir_set_flow_hdr(vf, conf, seg);
+ if (ret) {
+ dev_dbg(dev, "Set flow hdr for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ ret = ice_vc_fdir_write_flow_prof(vf, flow, seg, tun);
+ if (ret == -EEXIST) {
+ devm_kfree(dev, seg);
+ } else if (ret) {
+ dev_dbg(dev, "Write flow profile for VF %d failed\n",
+ vf->vf_id);
+ goto err_exit;
+ }
+
+ return 0;
+
+err_exit:
+ devm_kfree(dev, seg);
+ return ret;
+}
+
+/**
+ * ice_vc_fdir_match_pattern
+ * @fltr: virtual channel add cmd buffer
+ * @type: virtual channel protocol filter header type
+ *
+ * Matching the header type by comparing @fltr and @type's value.
+ *
+ * Return: true on success, and false on error.
+ */
+static bool
+ice_vc_fdir_match_pattern(struct virtchnl_fdir_add *fltr,
+ enum virtchnl_proto_hdr_type *type)
+{
+ struct virtchnl_proto_hdrs *proto = &fltr->rule_cfg.proto_hdrs;
+ int i = 0;
+
+ while ((i < proto->count) &&
+ (*type == proto->proto_hdr[i].type) &&
+ (*type != VIRTCHNL_PROTO_HDR_NONE)) {
+ type++;
+ i++;
+ }
+
+ return ((i == proto->count) &&
+ (*type == VIRTCHNL_PROTO_HDR_NONE));
+}
+
+/**
+ * ice_vc_fdir_get_pattern - get while list pattern
+ * @vf: pointer to the VF info
+ * @len: filter list length
+ *
+ * Return: pointer to allowed filter list
+ */
+static const struct virtchnl_fdir_pattern_match_item *
+ice_vc_fdir_get_pattern(struct ice_vf *vf, int *len)
+{
+ const struct virtchnl_fdir_pattern_match_item *item;
+ struct ice_pf *pf = vf->pf;
+ struct ice_hw *hw;
+
+ hw = &pf->hw;
+ item = vc_fdir_pattern;
+ *len = ARRAY_SIZE(vc_fdir_pattern);
+
+ return item;
+}
+
+/**
+ * ice_vc_fdir_search_pattern
+ * @vf: pointer to the VF info
+ * @fltr: virtual channel add cmd buffer
+ *
+ * Search for matched pattern from supported pattern list
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_search_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr)
+{
+ const struct virtchnl_fdir_pattern_match_item *pattern;
+ int len, i;
+
+ pattern = ice_vc_fdir_get_pattern(vf, &len);
+
+ for (i = 0; i < len; i++)
+ if (ice_vc_fdir_match_pattern(fltr, pattern[i].list))
+ return 0;
+
+ return -EINVAL;
+}
+
+/**
+ * ice_vc_fdir_parse_pattern
+ * @vf: pointer to the VF info
+ * @fltr: virtual channel add cmd buffer
+ * @conf: FDIR configuration for each filter
+ *
+ * Parse the virtual channel filter's pattern and store them into @conf
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
+ struct virtchnl_fdir_fltr_conf *conf)
+{
+ struct virtchnl_proto_hdrs *proto = &fltr->rule_cfg.proto_hdrs;
+ enum virtchnl_proto_hdr_type l3 = VIRTCHNL_PROTO_HDR_NONE;
+ enum virtchnl_proto_hdr_type l4 = VIRTCHNL_PROTO_HDR_NONE;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ struct ice_fdir_fltr *input = &conf->input;
+ int i;
+
+ if (proto->count > VIRTCHNL_MAX_NUM_PROTO_HDRS) {
+ dev_dbg(dev, "Invalid protocol count:0x%x for VF %d\n",
+ proto->count, vf->vf_id);
+ return -EINVAL;
+ }
+
+ for (i = 0; i < proto->count; i++) {
+ struct virtchnl_proto_hdr *hdr = &proto->proto_hdr[i];
+ struct sctphdr *sctph;
+ struct ipv6hdr *ip6h;
+ struct udphdr *udph;
+ struct tcphdr *tcph;
+ struct iphdr *iph;
+
+ switch (hdr->type) {
+ case VIRTCHNL_PROTO_HDR_ETH:
+ break;
+ case VIRTCHNL_PROTO_HDR_IPV4:
+ iph = (struct iphdr *)hdr->buffer;
+ l3 = VIRTCHNL_PROTO_HDR_IPV4;
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV4_OTHER;
+
+ if (hdr->field_selector) {
+ input->ip.v4.src_ip = iph->saddr;
+ input->ip.v4.dst_ip = iph->daddr;
+ input->ip.v4.tos = iph->tos;
+ input->ip.v4.proto = iph->protocol;
+ }
+ break;
+ case VIRTCHNL_PROTO_HDR_IPV6:
+ ip6h = (struct ipv6hdr *)hdr->buffer;
+ l3 = VIRTCHNL_PROTO_HDR_IPV6;
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV6_OTHER;
+
+ if (hdr->field_selector) {
+ memcpy(input->ip.v6.src_ip,
+ ip6h->saddr.in6_u.u6_addr8,
+ sizeof(ip6h->saddr));
+ memcpy(input->ip.v6.dst_ip,
+ ip6h->daddr.in6_u.u6_addr8,
+ sizeof(ip6h->daddr));
+ input->ip.v6.tc = ((u8)(ip6h->priority) << 4) |
+ (ip6h->flow_lbl[0] >> 4);
+ input->ip.v6.proto = ip6h->nexthdr;
+ }
+ break;
+ case VIRTCHNL_PROTO_HDR_TCP:
+ tcph = (struct tcphdr *)hdr->buffer;
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV4_TCP;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV6_TCP;
+
+ if (hdr->field_selector) {
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4) {
+ input->ip.v4.src_port = tcph->source;
+ input->ip.v4.dst_port = tcph->dest;
+ } else if (l3 == VIRTCHNL_PROTO_HDR_IPV6) {
+ input->ip.v6.src_port = tcph->source;
+ input->ip.v6.dst_port = tcph->dest;
+ }
+ }
+ break;
+ case VIRTCHNL_PROTO_HDR_UDP:
+ udph = (struct udphdr *)hdr->buffer;
+ l4 = VIRTCHNL_PROTO_HDR_UDP;
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV4_UDP;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV6_UDP;
+
+ if (hdr->field_selector) {
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4) {
+ input->ip.v4.src_port = udph->source;
+ input->ip.v4.dst_port = udph->dest;
+ } else if (l3 == VIRTCHNL_PROTO_HDR_IPV6) {
+ input->ip.v6.src_port = udph->source;
+ input->ip.v6.dst_port = udph->dest;
+ }
+ }
+ break;
+ case VIRTCHNL_PROTO_HDR_SCTP:
+ sctph = (struct sctphdr *)hdr->buffer;
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV4_SCTP;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV6_SCTP;
+
+ if (hdr->field_selector) {
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4) {
+ input->ip.v4.src_port = sctph->source;
+ input->ip.v4.dst_port = sctph->dest;
+ } else if (l3 == VIRTCHNL_PROTO_HDR_IPV6) {
+ input->ip.v6.src_port = sctph->source;
+ input->ip.v6.dst_port = sctph->dest;
+ }
+ }
+ break;
+ default:
+ dev_dbg(dev, "Invalid header type 0x:%x for VF %d\n",
+ hdr->type, vf->vf_id);
+ return -EINVAL;
+ }
+ }
+
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_parse_action
+ * @vf: pointer to the VF info
+ * @fltr: virtual channel add cmd buffer
+ * @conf: FDIR configuration for each filter
+ *
+ * Parse the virtual channel filter's action and store them into @conf
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_parse_action(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
+ struct virtchnl_fdir_fltr_conf *conf)
+{
+ struct virtchnl_filter_action_set *as = &fltr->rule_cfg.action_set;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ struct ice_fdir_fltr *input = &conf->input;
+ u32 dest_num = 0;
+ u32 mark_num = 0;
+ int i;
+
+ if (as->count > VIRTCHNL_MAX_NUM_ACTIONS) {
+ dev_dbg(dev, "Invalid action numbers:0x%x for VF %d\n",
+ as->count, vf->vf_id);
+ return -EINVAL;
+ }
+
+ for (i = 0; i < as->count; i++) {
+ struct virtchnl_filter_action *action = &as->actions[i];
+
+ switch (action->type) {
+ case VIRTCHNL_ACTION_PASSTHRU:
+ dest_num++;
+ input->dest_ctl =
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
+ break;
+ case VIRTCHNL_ACTION_DROP:
+ dest_num++;
+ input->dest_ctl =
+ ICE_FLTR_PRGM_DESC_DEST_DROP_PKT;
+ break;
+ case VIRTCHNL_ACTION_QUEUE:
+ dest_num++;
+ input->dest_ctl =
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX;
+ input->q_index = action->act_conf.queue.index;
+ break;
+ case VIRTCHNL_ACTION_Q_REGION:
+ dest_num++;
+ input->dest_ctl =
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP;
+ input->q_index = action->act_conf.queue.index;
+ input->q_region = action->act_conf.queue.region;
+ break;
+ case VIRTCHNL_ACTION_MARK:
+ mark_num++;
+ input->fltr_id = action->act_conf.mark_id;
+ input->fdid_prio = ICE_FXD_FLTR_QW1_FDID_PRI_THREE;
+ break;
+ default:
+ dev_dbg(dev, "Invalid action type:0x%x for VF %d\n",
+ action->type, vf->vf_id);
+ return -EINVAL;
+ }
+ }
+
+ if (dest_num == 0 || dest_num >= 2) {
+ dev_dbg(dev, "Invalid destination action for VF %d\n",
+ vf->vf_id);
+ return -EINVAL;
+ }
+
+ if (mark_num >= 2) {
+ dev_dbg(dev, "Too many mark actions for VF %d\n", vf->vf_id);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+/**
+ * ice_vc_validate_fdir_fltr - validate the virtual channel filter
+ * @vf: pointer to the VF info
+ * @fltr: virtual channel add cmd buffer
+ * @conf: FDIR configuration for each filter
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_validate_fdir_fltr(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
+ struct virtchnl_fdir_fltr_conf *conf)
+{
+ int ret;
+
+ ret = ice_vc_fdir_search_pattern(vf, fltr);
+ if (ret)
+ return ret;
+
+ ret = ice_vc_fdir_parse_pattern(vf, fltr, conf);
+ if (ret)
+ return ret;
+
+ return ice_vc_fdir_parse_action(vf, fltr, conf);
+}
+
+/**
+ * ice_vc_fdir_comp_rules - compare if two filter rules have the same value
+ * @conf_a: FDIR configuration for filter a
+ * @conf_b: FDIR configuration for filter b
+ *
+ * Return: 0 on success, and other on error.
+ */
+static bool
+ice_vc_fdir_comp_rules(struct virtchnl_fdir_fltr_conf *conf_a,
+ struct virtchnl_fdir_fltr_conf *conf_b)
+{
+ struct ice_fdir_fltr *a = &conf_a->input;
+ struct ice_fdir_fltr *b = &conf_b->input;
+
+ if (a->flow_type != b->flow_type)
+ return false;
+ if (memcmp(&a->ip, &b->ip, sizeof(a->ip)))
+ return false;
+ if (memcmp(&a->mask, &b->mask, sizeof(a->mask)))
+ return false;
+ if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
+ return false;
+ if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
+ return false;
+
+ return true;
+}
+
+/**
+ * ice_vc_fdir_is_dup_fltr
+ * @vf: pointer to the VF info
+ * @conf: FDIR configuration for each filter
+ *
+ * Check if there is duplicated rule with same @conf value
+ *
+ * Return: 0 true success, and false on error.
+ */
+static bool
+ice_vc_fdir_is_dup_fltr(struct ice_vf *vf, struct virtchnl_fdir_fltr_conf *conf)
+{
+ struct ice_fdir_fltr *desc;
+ bool ret;
+
+ list_for_each_entry(desc, &vf->fdir.fdir_rule_list, fltr_node) {
+ struct virtchnl_fdir_fltr_conf *node =
+ to_fltr_conf_from_desc(desc);
+
+ ret = ice_vc_fdir_comp_rules(node, conf);
+ if (ret)
+ return true;
+ }
+
+ return false;
+}
+
+/**
+ * ice_vc_fdir_insert_entry
+ * @vf: pointer to the VF info
+ * @conf: FDIR configuration for each filter
+ * @id: pointer to ID value allocated by driver
+ *
+ * Insert FDIR conf entry into list and allocate ID for this filter
+ *
+ * Return: 0 true success, and other on error.
+ */
+static int
+ice_vc_fdir_insert_entry(struct ice_vf *vf,
+ struct virtchnl_fdir_fltr_conf *conf, u32 *id)
+{
+ struct ice_fdir_fltr *input = &conf->input;
+ int i;
+
+ /* alloc ID corresponding with conf */
+ i = idr_alloc(&vf->fdir.fdir_rule_idr, conf, 0,
+ ICE_FDIR_MAX_FLTRS, GFP_KERNEL);
+ if (i < 0)
+ return -EINVAL;
+ *id = i;
+
+ list_add(&input->fltr_node, &vf->fdir.fdir_rule_list);
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_remove_entry - remove FDIR conf entry by ID value
+ * @vf: pointer to the VF info
+ * @conf: FDIR configuration for each filter
+ * @id: filter rule's ID
+ */
+static void
+ice_vc_fdir_remove_entry(struct ice_vf *vf,
+ struct virtchnl_fdir_fltr_conf *conf, u32 id)
+{
+ struct ice_fdir_fltr *input = &conf->input;
+
+ idr_remove(&vf->fdir.fdir_rule_idr, id);
+ list_del(&input->fltr_node);
+}
+
+/**
+ * ice_vc_fdir_lookup_entry - lookup FDIR conf entry by ID value
+ * @vf: pointer to the VF info
+ * @id: filter rule's ID
+ *
+ * Return: NULL on error, and other on success.
+ */
+static struct virtchnl_fdir_fltr_conf *
+ice_vc_fdir_lookup_entry(struct ice_vf *vf, u32 id)
+{
+ return idr_find(&vf->fdir.fdir_rule_idr, id);
+}
+
+/**
+ * ice_vc_fdir_flush_entry - remove all FDIR conf entry
+ * @vf: pointer to the VF info
+ */
+static void ice_vc_fdir_flush_entry(struct ice_vf *vf)
+{
+ struct virtchnl_fdir_fltr_conf *conf;
+ struct ice_fdir_fltr *desc, *temp;
+
+ list_for_each_entry_safe(desc, temp,
+ &vf->fdir.fdir_rule_list, fltr_node) {
+ conf = to_fltr_conf_from_desc(desc);
+ list_del(&desc->fltr_node);
+ devm_kfree(ice_pf_to_dev(vf->pf), conf);
+ }
+}
+
+/**
+ * ice_vc_fdir_write_fltr - write filter rule into hardware
+ * @vf: pointer to the VF info
+ * @conf: FDIR configuration for each filter
+ * @add: true implies add rule, false implies del rules
+ * @is_tun: false implies non-tunnel type filter, true implies tunnel filter
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int ice_vc_fdir_write_fltr(struct ice_vf *vf,
+ struct virtchnl_fdir_fltr_conf *conf,
+ bool add, bool is_tun)
+{
+ struct ice_fdir_fltr *input = &conf->input;
+ struct ice_vsi *vsi, *ctrl_vsi;
+ struct ice_fltr_desc desc;
+ enum ice_status status;
+ struct device *dev;
+ struct ice_pf *pf;
+ struct ice_hw *hw;
+ int ret;
+ u8 *pkt;
+
+ pf = vf->pf;
+ dev = ice_pf_to_dev(pf);
+ hw = &pf->hw;
+ vsi = pf->vsi[vf->lan_vsi_idx];
+ if (!vsi) {
+ dev_dbg(dev, "Invalid vsi for VF %d\n", vf->vf_id);
+ return -EINVAL;
+ }
+
+ input->dest_vsi = vsi->idx;
+ input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
+
+ ctrl_vsi = pf->vsi[vf->ctrl_vsi_idx];
+ if (!ctrl_vsi) {
+ dev_dbg(dev, "Invalid ctrl_vsi for VF %d\n", vf->vf_id);
+ return -EINVAL;
+ }
+
+ pkt = devm_kzalloc(dev, ICE_FDIR_MAX_RAW_PKT_SIZE, GFP_KERNEL);
+ if (!pkt)
+ return -ENOMEM;
+
+ ice_fdir_get_prgm_desc(hw, input, &desc, add);
+ status = ice_fdir_get_gen_prgm_pkt(hw, input, pkt, false, is_tun);
+ ret = ice_status_to_errno(status);
+ if (ret) {
+ dev_dbg(dev, "Gen training pkt for VF %d ptype %d failed\n",
+ vf->vf_id, input->flow_type);
+ goto err_free_pkt;
+ }
+
+ ret = ice_prgm_fdir_fltr(ctrl_vsi, &desc, pkt);
+ if (ret)
+ goto err_free_pkt;
+
+ return 0;
+
+err_free_pkt:
+ devm_kfree(dev, pkt);
+ return ret;
+}
+
+/**
+ * ice_vc_add_fdir_fltr - add a FDIR filter for VF by the msg buffer
+ * @vf: pointer to the VF info
+ * @msg: pointer to the msg buffer
+ *
+ * Return: 0 on success, and other on error.
+ */
+int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
+{
+ struct virtchnl_fdir_add *fltr = (struct virtchnl_fdir_add *)msg;
+ struct virtchnl_fdir_add *stat = NULL;
+ struct virtchnl_fdir_fltr_conf *conf;
+ enum virtchnl_status_code v_ret;
+ struct device *dev;
+ struct ice_pf *pf;
+ int is_tun = 0;
+ int len = 0;
+ int ret;
+
+ pf = vf->pf;
+ dev = ice_pf_to_dev(pf);
+ ret = ice_vc_fdir_param_check(vf, fltr->vsi_id);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ dev_dbg(dev, "Parameter check for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ ret = ice_vf_start_ctrl_vsi(vf);
+ if (ret && (ret != -EEXIST)) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ dev_err(dev, "Init FDIR for VF %d failed, ret:%d\n",
+ vf->vf_id, ret);
+ goto err_exit;
+ }
+
+ stat = kzalloc(sizeof(*stat), GFP_KERNEL);
+ if (!stat) {
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ dev_dbg(dev, "Alloc stat for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ conf = devm_kzalloc(dev, sizeof(*conf), GFP_KERNEL);
+ if (!conf) {
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ dev_dbg(dev, "Alloc conf for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ len = sizeof(*stat);
+ ret = ice_vc_validate_fdir_fltr(vf, fltr, conf);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_INVALID;
+ dev_dbg(dev, "Invalid FDIR filter from VF %d\n", vf->vf_id);
+ goto err_free_conf;
+ }
+
+ if (fltr->validate_only) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_SUCCESS;
+ devm_kfree(dev, conf);
+ ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER,
+ v_ret, (u8 *)stat, len);
+ goto exit;
+ }
+
+ ret = ice_vc_fdir_config_input_set(vf, fltr, conf, is_tun);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT;
+ dev_err(dev, "VF %d: FDIR input set configure failed, ret:%d\n",
+ vf->vf_id, ret);
+ goto err_free_conf;
+ }
+
+ ret = ice_vc_fdir_is_dup_fltr(vf, conf);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_EXIST;
+ dev_dbg(dev, "VF %d: duplicated FDIR rule detected\n",
+ vf->vf_id);
+ goto err_free_conf;
+ }
+
+ ret = ice_vc_fdir_insert_entry(vf, conf, &stat->flow_id);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_dbg(dev, "VF %d: insert FDIR list failed\n", vf->vf_id);
+ goto err_free_conf;
+ }
+
+ ret = ice_vc_fdir_write_fltr(vf, conf, true, is_tun);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_err(dev, "VF %d: writing FDIR rule failed, ret:%d\n",
+ vf->vf_id, ret);
+ goto err_rem_entry;
+ }
+
+ vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]++;
+
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_SUCCESS;
+exit:
+ ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER, v_ret,
+ (u8 *)stat, len);
+ kfree(stat);
+ return ret;
+
+err_rem_entry:
+ ice_vc_fdir_remove_entry(vf, conf, stat->flow_id);
+err_free_conf:
+ devm_kfree(dev, conf);
+err_exit:
+ ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER, v_ret,
+ (u8 *)stat, len);
+ kfree(stat);
+ return ret;
+}
+
+/**
+ * ice_vc_del_fdir_fltr - delete a FDIR filter for VF by the msg buffer
+ * @vf: pointer to the VF info
+ * @msg: pointer to the msg buffer
+ *
+ * Return: 0 on success, and other on error.
+ */
+int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg)
+{
+ struct virtchnl_fdir_del *fltr = (struct virtchnl_fdir_del *)msg;
+ struct virtchnl_fdir_del *stat = NULL;
+ struct virtchnl_fdir_fltr_conf *conf;
+ enum virtchnl_status_code v_ret;
+ struct device *dev;
+ struct ice_pf *pf;
+ int is_tun = 0;
+ int len = 0;
+ int ret;
+
+ pf = vf->pf;
+ dev = ice_pf_to_dev(pf);
+ ret = ice_vc_fdir_param_check(vf, fltr->vsi_id);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_ERR_PARAM;
+ dev_dbg(dev, "Parameter check for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ stat = kzalloc(sizeof(*stat), GFP_KERNEL);
+ if (!stat) {
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ dev_dbg(dev, "Alloc stat for VF %d failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ len = sizeof(*stat);
+
+ conf = ice_vc_fdir_lookup_entry(vf, fltr->flow_id);
+ if (!conf) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST;
+ dev_dbg(dev, "VF %d: FDIR invalid flow_id:0x%X\n",
+ vf->vf_id, fltr->flow_id);
+ goto err_exit;
+ }
+
+ /* Just return failure when ctrl_vsi idx is invalid */
+ if (vf->ctrl_vsi_idx == ICE_NO_VSI) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_err(dev, "Invalid FDIR ctrl_vsi for VF %d\n", vf->vf_id);
+ goto err_exit;
+ }
+
+ ret = ice_vc_fdir_write_fltr(vf, conf, false, is_tun);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_err(dev, "VF %d: writing FDIR rule failed, ret:%d\n",
+ vf->vf_id, ret);
+ goto err_exit;
+ }
+
+ ice_vc_fdir_remove_entry(vf, conf, fltr->flow_id);
+ devm_kfree(dev, conf);
+ vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]--;
+
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_SUCCESS;
+
+err_exit:
+ ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_DEL_FDIR_FILTER, v_ret,
+ (u8 *)stat, len);
+ kfree(stat);
+ return ret;
+}
+
+/**
+ * ice_vf_fdir_init - init FDIR resource for VF
+ * @vf: pointer to the VF info
+ */
+void ice_vf_fdir_init(struct ice_vf *vf)
+{
+ struct ice_vf_fdir *fdir = &vf->fdir;
+
+ idr_init(&fdir->fdir_rule_idr);
+ INIT_LIST_HEAD(&fdir->fdir_rule_list);
+}
+
+/**
+ * ice_vf_fdir_exit - destroy FDIR resource for VF
+ * @vf: pointer to the VF info
+ */
+void ice_vf_fdir_exit(struct ice_vf *vf)
+{
+ ice_vc_fdir_flush_entry(vf);
+ idr_destroy(&vf->fdir.fdir_rule_idr);
+ ice_vc_fdir_rem_prof_all(vf);
+ ice_vc_fdir_free_prof_all(vf);
+}
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
new file mode 100644
index 000000000000..676de402475e
--- /dev/null
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2018-2020, Intel Corporation. */
+
+#ifndef _ICE_VIRTCHNL_FDIR_H_
+#define _ICE_VIRTCHNL_FDIR_H_
+
+struct ice_vf;
+
+/* VF FDIR information structure */
+struct ice_vf_fdir {
+ u16 fdir_fltr_cnt[ICE_FLTR_PTYPE_MAX][ICE_FD_HW_SEG_MAX];
+ int prof_entry_cnt[ICE_FLTR_PTYPE_MAX][ICE_FD_HW_SEG_MAX];
+ struct ice_fd_hw_prof **fdir_prof;
+
+ struct idr fdir_rule_idr;
+ struct list_head fdir_rule_list;
+};
+
+int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg);
+int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg);
+void ice_vf_fdir_init(struct ice_vf *vf);
+void ice_vf_fdir_exit(struct ice_vf *vf);
+
+#endif /* _ICE_VIRTCHNL_FDIR_H_ */
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index ddd6062c5b8b..18f4442b1d25 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -473,6 +473,7 @@ static void ice_free_vf_res(struct ice_vf *vf)
* accessing the VF's VSI after it's freed or invalidated.
*/
clear_bit(ICE_VF_STATE_INIT, vf->vf_states);
+ ice_vf_fdir_exit(vf);
/* free VF control VSI */
if (vf->ctrl_vsi_idx != ICE_NO_VSI)
ice_vf_ctrl_vsi_release(vf);
@@ -1512,6 +1513,7 @@ bool ice_reset_all_vfs(struct ice_pf *pf, bool is_vflr)
ice_for_each_vf(pf, v) {
vf = &pf->vf[v];
+ ice_vf_fdir_exit(vf);
/* clean VF control VSI when resetting VFs since it should be
* setup only when iAVF creates its first FDIR rule.
*/
@@ -1639,6 +1641,7 @@ bool ice_reset_vf(struct ice_vf *vf, bool is_vflr)
dev_err(dev, "disabling promiscuous mode failed\n");
}
+ ice_vf_fdir_exit(vf);
/* clean VF control VSI when resetting VF since it should be setup
* only when iAVF creates its first FDIR rule.
*/
@@ -1840,6 +1843,7 @@ static void ice_set_dflt_settings_vfs(struct ice_pf *pf)
* creates its first fdir rule.
*/
ice_vf_ctrl_invalidate_vsi(vf);
+ ice_vf_fdir_init(vf);
}
}
@@ -2162,7 +2166,7 @@ ice_vf_lan_overflow_event(struct ice_pf *pf, struct ice_rq_event_info *event)
*
* send msg to VF
*/
-static int
+int
ice_vc_send_msg_to_vf(struct ice_vf *vf, u32 v_opcode,
enum virtchnl_status_code v_retval, u8 *msg, u16 msglen)
{
@@ -2290,6 +2294,9 @@ static int ice_vc_get_vf_res_msg(struct ice_vf *vf, u8 *msg)
if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC)
vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC;
+ if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_FDIR_PF)
+ vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_FDIR_PF;
+
if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2)
vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2;
@@ -2405,7 +2412,7 @@ static struct ice_vsi *ice_find_vsi_from_id(struct ice_pf *pf, u16 id)
*
* check for the valid VSI ID
*/
-static bool ice_vc_isvalid_vsi_id(struct ice_vf *vf, u16 vsi_id)
+bool ice_vc_isvalid_vsi_id(struct ice_vf *vf, u16 vsi_id)
{
struct ice_pf *pf = vf->pf;
struct ice_vsi *vsi;
@@ -4755,6 +4762,12 @@ void ice_vc_process_vf_msg(struct ice_pf *pf, struct ice_rq_event_info *event)
case VIRTCHNL_OP_DEL_RSS_CFG:
err = ice_vc_handle_rss_cfg(vf, msg, false);
break;
+ case VIRTCHNL_OP_ADD_FDIR_FILTER:
+ err = ice_vc_add_fdir_fltr(vf, msg);
+ break;
+ case VIRTCHNL_OP_DEL_FDIR_FILTER:
+ err = ice_vc_del_fdir_fltr(vf, msg);
+ break;
case VIRTCHNL_OP_UNKNOWN:
default:
dev_err(dev, "Unsupported opcode %d from VF %d\n", v_opcode,
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
index 61e7daf7861e..d3a00fdf1ee4 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
@@ -4,6 +4,7 @@
#ifndef _ICE_VIRTCHNL_PF_H_
#define _ICE_VIRTCHNL_PF_H_
#include "ice.h"
+#include "ice_virtchnl_fdir.h"
#include "ice_dcf.h"
/* Restrict number of MAC Addr and VLAN that non-trusted VF can programmed */
@@ -74,6 +75,7 @@ struct ice_vf {
u16 vf_id; /* VF ID in the PF space */
u16 lan_vsi_idx; /* index into PF struct */
u16 ctrl_vsi_idx;
+ struct ice_vf_fdir fdir;
/* first vector index of this VF in the PF space */
int first_vector_idx;
struct ice_sw *vf_sw_id; /* switch ID the VF VSIs connect to */
@@ -142,6 +144,10 @@ ice_vf_lan_overflow_event(struct ice_pf *pf, struct ice_rq_event_info *event);
void ice_print_vfs_mdd_events(struct ice_pf *pf);
void ice_print_vf_rx_mdd_event(struct ice_vf *vf);
struct ice_vsi *ice_vf_ctrl_vsi_setup(struct ice_vf *vf);
+int
+ice_vc_send_msg_to_vf(struct ice_vf *vf, u32 v_opcode,
+ enum virtchnl_status_code v_retval, u8 *msg, u16 msglen);
+bool ice_vc_isvalid_vsi_id(struct ice_vf *vf, u16 vsi_id);
#else /* CONFIG_PCI_IOV */
#define ice_process_vflr_event(pf) do {} while (0)
#define ice_free_vfs(pf) do {} while (0)
diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
index d7e5263fd2ec..6b8de39bc046 100644
--- a/include/linux/avf/virtchnl.h
+++ b/include/linux/avf/virtchnl.h
@@ -145,6 +145,8 @@ enum virtchnl_ops {
VIRTCHNL_OP_GET_SUPPORTED_RXDIDS = 44,
VIRTCHNL_OP_ADD_RSS_CFG = 45,
VIRTCHNL_OP_DEL_RSS_CFG = 46,
+ VIRTCHNL_OP_ADD_FDIR_FILTER = 47,
+ VIRTCHNL_OP_DEL_FDIR_FILTER = 48,
/* New major set of opcodes introduced and so leaving room for
* old misc opcodes to be added in future. Also these opcodes may only
* be used if both the PF and VF have successfully negotiated the
@@ -286,6 +288,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);
#define VIRTCHNL_VF_OFFLOAD_ADQ 0X00800000
#define VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC 0X04000000
#define VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF 0X08000000
+#define VIRTCHNL_VF_OFFLOAD_FDIR_PF 0X10000000
#define VIRTCHNL_VF_CAP_DCF 0X40000000
/* Define below the capability flags that are not offloads */
@@ -624,6 +627,11 @@ enum virtchnl_action {
/* action types */
VIRTCHNL_ACTION_DROP = 0,
VIRTCHNL_ACTION_TC_REDIRECT,
+ VIRTCHNL_ACTION_PASSTHRU,
+ VIRTCHNL_ACTION_QUEUE,
+ VIRTCHNL_ACTION_Q_REGION,
+ VIRTCHNL_ACTION_MARK,
+ VIRTCHNL_ACTION_COUNT,
};
enum virtchnl_flow_type {
@@ -948,6 +956,114 @@ struct virtchnl_rss_cfg {
VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
+/* action configuration for FDIR */
+struct virtchnl_filter_action {
+ enum virtchnl_action type;
+ union {
+ /* used for queue and qgroup action */
+ struct {
+ u16 index;
+ u8 region;
+ } queue;
+ /* used for count action */
+ struct {
+ /* share counter ID with other flow rules */
+ u8 shared;
+ u32 id; /* counter ID */
+ } count;
+ /* used for mark action */
+ u32 mark_id;
+ u8 reserve[32];
+ } act_conf;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(36, virtchnl_filter_action);
+
+#define VIRTCHNL_MAX_NUM_ACTIONS 8
+
+struct virtchnl_filter_action_set {
+ /* action number must be less then VIRTCHNL_MAX_NUM_ACTIONS */
+ int count;
+ struct virtchnl_filter_action actions[VIRTCHNL_MAX_NUM_ACTIONS];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(292, virtchnl_filter_action_set);
+
+/* pattern and action for FDIR rule */
+struct virtchnl_fdir_rule {
+ struct virtchnl_proto_hdrs proto_hdrs;
+ struct virtchnl_filter_action_set action_set;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
+
+/* Status returned to VF after VF requests FDIR commands
+ * VIRTCHNL_FDIR_SUCCESS
+ * VF FDIR related request is successfully done by PF
+ * The request can be OP_ADD/DEL.
+ *
+ * VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE
+ * OP_ADD_FDIR_FILTER request is failed due to no Hardware resource.
+ *
+ * VIRTCHNL_FDIR_FAILURE_RULE_EXIST
+ * OP_ADD_FDIR_FILTER request is failed due to the rule is already existed.
+ *
+ * VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT
+ * OP_ADD_FDIR_FILTER request is failed due to conflict with existing rule.
+ *
+ * VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST
+ * OP_DEL_FDIR_FILTER request is failed due to this rule doesn't exist.
+ *
+ * VIRTCHNL_FDIR_FAILURE_RULE_INVALID
+ * OP_ADD_FDIR_FILTER request is failed due to parameters validation
+ * or HW doesn't support.
+ *
+ * VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT
+ * OP_ADD/DEL_FDIR_FILTER request is failed due to timing out
+ * for programming.
+ */
+enum virtchnl_fdir_prgm_status {
+ VIRTCHNL_FDIR_SUCCESS = 0,
+ VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE,
+ VIRTCHNL_FDIR_FAILURE_RULE_EXIST,
+ VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT,
+ VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST,
+ VIRTCHNL_FDIR_FAILURE_RULE_INVALID,
+ VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT,
+};
+
+/* VIRTCHNL_OP_ADD_FDIR_FILTER
+ * VF sends this request to PF by filling out vsi_id,
+ * validate_only and rule_cfg. PF will return flow_id
+ * if the request is successfully done and return add_status to VF.
+ */
+struct virtchnl_fdir_add {
+ u16 vsi_id; /* INPUT */
+ /*
+ * 1 for validating a fdir rule, 0 for creating a fdir rule.
+ * Validate and create share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER.
+ */
+ u16 validate_only; /* INPUT */
+ u32 flow_id; /* OUTPUT */
+ struct virtchnl_fdir_rule rule_cfg; /* INPUT */
+ enum virtchnl_fdir_prgm_status status; /* OUTPUT */
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
+
+/* VIRTCHNL_OP_DEL_FDIR_FILTER
+ * VF sends this request to PF by filling out vsi_id
+ * and flow_id. PF will return del_status to VF.
+ */
+struct virtchnl_fdir_del {
+ u16 vsi_id; /* INPUT */
+ u16 pad;
+ u32 flow_id; /* INPUT */
+ enum virtchnl_fdir_prgm_status status; /* OUTPUT */
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_fdir_del);
+
/* PF capability flags
* VIRTCHNL_CAP_STATELESS_OFFLOADS flag indicates stateless offloads
* such as TX/RX Checksum offloading and TSO for non-tunneled packets. Please
@@ -1507,6 +1623,12 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,
case VIRTCHNL_OP_DEL_RSS_CFG:
valid_len = sizeof(struct virtchnl_rss_cfg);
break;
+ case VIRTCHNL_OP_ADD_FDIR_FILTER:
+ valid_len = sizeof(struct virtchnl_fdir_add);
+ break;
+ case VIRTCHNL_OP_DEL_FDIR_FILTER:
+ valid_len = sizeof(struct virtchnl_fdir_del);
+ break;
case VIRTCHNL_OP_GET_CAPS:
valid_len = sizeof(struct virtchnl_get_capabilities);
break;
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF Qi Zhang
@ 2020-07-03 5:29 ` Kirsher, Jeffrey T
2020-07-03 9:08 ` kernel test robot
1 sibling, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:29 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for
> AVF
>
> Add virtual channel support for iAVF FDIR add/validate/delete filter.
> iAVF FDIR is Flow Director for intel Adaptive Virtual Function which can
> direct Ethernet packets to the queues of the Network Interface Card.
> Add/delete command is adding or deleting one rule for each virtual
> channel message, while validate command is just verifying if this rule
> is valid without any other operations.
>
> To add or delete one rule, driver needs to config TCAM and Profile,
> build training packets which contains the input set value, and send
> the training packets through FDIR tx queue. In addition, driver needs to
> manage the software context to avoid adding duplicated rules, deleting
> non-existent rule, input set conflicts and other invalid cases.
>
> Due to different requirement for FDIR descriptor configure between PF
> and AVF, the patch also add more flexibility for the metadata setup,
> these include:
> 1. Statistic mode.
> 2. FDID priority.
> 3. Complete Report mode.
> Also two new FDIR action "passthrough" and "to queue region" are
> enabled.
>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> Signed-off-by: Simei Su <simei.su@intel.com>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
This patch is too big, it needs to be broken up into at least 2 patches, that will help with future reviews.
> ---
> drivers/net/ethernet/intel/ice/Makefile | 2 +-
> drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 4 +
> drivers/net/ethernet/intel/ice/ice_fdir.c | 18 +-
> drivers/net/ethernet/intel/ice/ice_fdir.h | 10 +
> drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 2 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 1398
> ++++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h | 24 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 17 +-
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 6 +
> include/linux/avf/virtchnl.h | 122 ++
> 10 files changed, 1596 insertions(+), 7 deletions(-)
> create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
>
> diff --git a/drivers/net/ethernet/intel/ice/Makefile
> b/drivers/net/ethernet/intel/ice/Makefile
> index eb83b5fe11c3..229740c3c1e1 100644
> --- a/drivers/net/ethernet/intel/ice/Makefile
> +++ b/drivers/net/ethernet/intel/ice/Makefile
> @@ -24,7 +24,7 @@ ice-y := ice_main.o \
> ice_flow.o \
> ice_devlink.o \
> ice_ethtool.o
> -ice-$(CONFIG_PCI_IOV) += ice_virtchnl_pf.o ice_sriov.o ice_dcf.o
> +ice-$(CONFIG_PCI_IOV) += ice_virtchnl_pf.o ice_sriov.o ice_dcf.o
> ice_virtchnl_fdir.o
> ice-$(CONFIG_DCB) += ice_dcb.o ice_dcb_nl.o ice_dcb_lib.o
> ice-$(CONFIG_RFS_ACCEL) += ice_arfs.o
> ice-$(CONFIG_XDP_SOCKETS) += ice_xsk.o
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> index d7430ce6af26..5655e54e8a56 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> @@ -1675,6 +1675,10 @@ int ice_add_fdir_ethtool(struct ice_vsi *vsi, struct
> ethtool_rxnfc *cmd)
> input->flex_offset = userdata.flex_offset;
> }
>
> + input->cnt_ena = ICE_FXD_FLTR_QW0_STAT_ENA_PKTS;
> + input->fdid_prio = ICE_FXD_FLTR_QW1_FDID_PRI_THREE;
> + input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
> +
> /* input struct is added to the HW filter list */
> ice_fdir_update_list_entry(pf, input, fsp->location);
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 6834df14332f..d97d9197135d 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -374,21 +374,31 @@ ice_fdir_get_prgm_desc(struct ice_hw *hw, struct
> ice_fdir_fltr *input,
> if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) {
> fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES;
> fdir_fltr_ctx.qindex = 0;
> + } else if (input->dest_ctl ==
> + ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) {
> + fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;
> + fdir_fltr_ctx.qindex = 0;
> } else {
> + if (input->dest_ctl ==
> + ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP)
> + fdir_fltr_ctx.toq = input->q_region;
> fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;
> fdir_fltr_ctx.qindex = input->q_index;
> }
> - fdir_fltr_ctx.cnt_ena = ICE_FXD_FLTR_QW0_STAT_ENA_PKTS;
> + fdir_fltr_ctx.cnt_ena = input->cnt_ena;
> fdir_fltr_ctx.cnt_index = input->cnt_index;
> fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi);
> fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE;
> - fdir_fltr_ctx.toq_prio = 3;
> + if (input->dest_ctl ==
> ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER)
> + fdir_fltr_ctx.toq_prio = 0;
> + else
> + fdir_fltr_ctx.toq_prio = 3;
> fdir_fltr_ctx.pcmd = add ? ICE_FXD_FLTR_QW1_PCMD_ADD :
> ICE_FXD_FLTR_QW1_PCMD_REMOVE;
> fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;
> fdir_fltr_ctx.comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO;
> - fdir_fltr_ctx.comp_report =
> ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
> - fdir_fltr_ctx.fdid_prio = 3;
> + fdir_fltr_ctx.comp_report = input->comp_report;
> + fdir_fltr_ctx.fdid_prio = input->fdid_prio;
> fdir_fltr_ctx.desc_prof = 1;
> fdir_fltr_ctx.desc_prof_prio = 3;
> ice_set_fd_desc_val(&fdir_fltr_ctx, fdesc);
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h
> b/drivers/net/ethernet/intel/ice/ice_fdir.h
> index 1c587766daab..6b7d8ccd39b7 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.h
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
> @@ -25,6 +25,9 @@
> #define ICE_IPV6_UDP_DST_PORT_OFFSET 56
> #define ICE_IPV6_SCTP_SRC_PORT_OFFSET 54
> #define ICE_IPV6_SCTP_DST_PORT_OFFSET 56
> +
> +#define ICE_FDIR_MAX_FLTRS 16384
> +
> /* IP v4 has 2 flag bits that enable fragment processing: DF and MF. DF
> * requests that the packet not be fragmented. MF indicates that a packet has
> * been fragmented.
> @@ -34,6 +37,8 @@
> enum ice_fltr_prgm_desc_dest {
> ICE_FLTR_PRGM_DESC_DEST_DROP_PKT,
> ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX,
> + ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP,
> + ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER,
> };
>
> enum ice_fltr_prgm_desc_fd_status {
> @@ -122,6 +127,8 @@ struct ice_fdir_fltr {
>
> /* flex byte filter data */
> __be16 flex_word;
> + /* queue region size (=2^q_region) */
> + u8 q_region;
> u16 flex_offset;
> u16 flex_fltr;
>
> @@ -129,9 +136,12 @@ struct ice_fdir_fltr {
> u16 q_index;
> u16 dest_vsi;
> u8 dest_ctl;
> + u8 cnt_ena;
> u8 fltr_status;
> u16 cnt_index;
> u32 fltr_id;
> + u8 fdid_prio;
> + u8 comp_report;
> };
>
> /* Dummy packet filter definition structure */
> diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> index 14dfbbc1b2cf..1382c498e1f0 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> +++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> @@ -55,6 +55,7 @@ struct ice_fltr_desc {
> #define ICE_FXD_FLTR_QW0_COMP_REPORT_M \
> (0x3ULL <<
> ICE_FXD_FLTR_QW0_COMP_REPORT_S)
> #define ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL 0x1ULL
> +#define ICE_FXD_FLTR_QW0_COMP_REPORT_SW 0x2ULL
>
> #define ICE_FXD_FLTR_QW0_FD_SPACE_S 14
> #define ICE_FXD_FLTR_QW0_FD_SPACE_M (0x3ULL <<
> ICE_FXD_FLTR_QW0_FD_SPACE_S)
> @@ -128,6 +129,7 @@ struct ice_fltr_desc {
> #define ICE_FXD_FLTR_QW1_FDID_PRI_S 25
> #define ICE_FXD_FLTR_QW1_FDID_PRI_M (0x7ULL <<
> ICE_FXD_FLTR_QW1_FDID_PRI_S)
> #define ICE_FXD_FLTR_QW1_FDID_PRI_ONE 0x1ULL
> +#define ICE_FXD_FLTR_QW1_FDID_PRI_THREE 0x3ULL
>
> #define ICE_FXD_FLTR_QW1_FDID_MDID_S 28
> #define ICE_FXD_FLTR_QW1_FDID_MDID_M (0xFULL <<
> ICE_FXD_FLTR_QW1_FDID_MDID_S)
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> new file mode 100644
> index 000000000000..53194e26a3cf
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> @@ -0,0 +1,1398 @@
> +
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (C) 2018-2020, Intel Corporation. */
> +
> +#include "ice.h"
> +#include "ice_base.h"
> +#include "ice_lib.h"
> +#include "ice_flow.h"
> +
> +#define to_fltr_conf_from_desc(p) \
> + container_of(p, struct virtchnl_fdir_fltr_conf, input)
> +
> +#define ICE_FLOW_PROF_TYPE_S 0
> +#define ICE_FLOW_PROF_TYPE_M (0xFFFFFFFFULL <<
> ICE_FLOW_PROF_TYPE_S)
> +#define ICE_FLOW_PROF_VSI_S 32
> +#define ICE_FLOW_PROF_VSI_M (0xFFFFFFFFULL <<
> ICE_FLOW_PROF_VSI_S)
> +
> +/* Flow profile ID format:
> + * [0:31] - flow type, flow + tun_offs
> + * [32:63] - VSI index
> + */
> +#define ICE_FLOW_PROF_FD(vsi, flow, tun_offs) \
> + (u64)(((((flow) + (tun_offs)) & ICE_FLOW_PROF_TYPE_M)) | \
> + (((u64)(vsi) << ICE_FLOW_PROF_VSI_S) &
> ICE_FLOW_PROF_VSI_M))
> +
> +struct virtchnl_fdir_fltr_conf {
> + struct ice_fdir_fltr input;
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_tcp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_TCP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_udp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_sctp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_SCTP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_tcp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_TCP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_udp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_sctp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_SCTP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +struct virtchnl_fdir_pattern_match_item {
> + enum virtchnl_proto_hdr_type *list;
> + u64 input_set;
> + u64 *meta;
> +};
> +
> +static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern[] = {
> + {vc_pattern_ipv4, 0, NULL},
> + {vc_pattern_ipv4_tcp, 0, NULL},
> + {vc_pattern_ipv4_udp, 0, NULL},
> + {vc_pattern_ipv4_sctp, 0, NULL},
> + {vc_pattern_ipv6, 0, NULL},
> + {vc_pattern_ipv6_tcp, 0, NULL},
> + {vc_pattern_ipv6_udp, 0, NULL},
> + {vc_pattern_ipv6_sctp, 0, NULL},
> +};
> +
> +struct virtchnl_fdir_inset_map {
> + enum virtchnl_proto_hdr_field field;
> + enum ice_flow_field fld;
> +};
> +
> +static const struct virtchnl_fdir_inset_map fdir_inset_map[] = {
> + {VIRTCHNL_PROTO_HDR_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
> + {VIRTCHNL_PROTO_HDR_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},
> + {VIRTCHNL_PROTO_HDR_IPV4_DSCP,
> ICE_FLOW_FIELD_IDX_IPV4_DSCP},
> + {VIRTCHNL_PROTO_HDR_IPV4_TTL,
> ICE_FLOW_FIELD_IDX_IPV4_TTL},
> + {VIRTCHNL_PROTO_HDR_IPV4_PROT,
> ICE_FLOW_FIELD_IDX_IPV4_PROT},
> + {VIRTCHNL_PROTO_HDR_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA},
> + {VIRTCHNL_PROTO_HDR_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA},
> + {VIRTCHNL_PROTO_HDR_IPV6_TC,
> ICE_FLOW_FIELD_IDX_IPV6_DSCP},
> + {VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT,
> ICE_FLOW_FIELD_IDX_IPV6_TTL},
> + {VIRTCHNL_PROTO_HDR_IPV6_PROT,
> ICE_FLOW_FIELD_IDX_IPV6_PROT},
> + {VIRTCHNL_PROTO_HDR_UDP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_UDP_SRC_PORT},
> + {VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
> ICE_FLOW_FIELD_IDX_UDP_DST_PORT},
> + {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_TCP_SRC_PORT},
> + {VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
> + {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
> + {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
> +};
> +
> +/**
> + * ice_vc_fdir_param_check
> + * @vf: pointer to the VF structure
> + * @vsi_id: VF relative VSI ID
> + *
> + * Check for the valid VSI ID, PF's state and VF's state
> + *
> + * Return: 0 on success, and -EINVAL on error.
> + */
> +static int
> +ice_vc_fdir_param_check(struct ice_vf *vf, u16 vsi_id)
> +{
> + struct ice_pf *pf = vf->pf;
> +
> + if (!test_bit(ICE_FLAG_FD_ENA, pf->flags))
> + return -EINVAL;
> +
> + if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states))
> + return -EINVAL;
> +
> + if (!(vf->driver_caps & VIRTCHNL_VF_OFFLOAD_FDIR_PF))
> + return -EINVAL;
> +
> + if (vsi_id != vf->lan_vsi_num)
> + return -EINVAL;
> +
> + if (!ice_vc_isvalid_vsi_id(vf, vsi_id))
> + return -EINVAL;
> +
> + if (!pf->vsi[vf->lan_vsi_idx])
> + return -EINVAL;
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vf_start_ctrl_vsi
> + * @vf: pointer to the VF structure
> + *
> + * Allocate ctrl_vsi for the first time and open the ctrl_vsi port for VF
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int ice_vf_start_ctrl_vsi(struct ice_vf *vf)
> +{
> + struct ice_pf *pf = vf->pf;
> + struct ice_vsi *ctrl_vsi;
> + struct device *dev;
> + int err;
> +
> + dev = ice_pf_to_dev(pf);
> + if (vf->ctrl_vsi_idx != ICE_NO_VSI)
> + return -EEXIST;
> +
> + ctrl_vsi = ice_vf_ctrl_vsi_setup(vf);
> + if (!ctrl_vsi) {
> + dev_dbg(dev, "Could not setup control VSI for VF %d\n",
> + vf->vf_id);
> + return -ENOMEM;
> + }
> +
> + err = ice_vsi_open_ctrl(ctrl_vsi);
> + if (err) {
> + dev_dbg(dev, "Could not open control VSI for VF %d\n",
> + vf->vf_id);
> + goto err_vsi_open;
> + }
> +
> + return 0;
> +
> +err_vsi_open:
> + ice_vsi_release(ctrl_vsi);
> + if (vf->ctrl_vsi_idx != ICE_NO_VSI) {
> + pf->vsi[vf->ctrl_vsi_idx] = NULL;
> + vf->ctrl_vsi_idx = ICE_NO_VSI;
> + }
> + return err;
> +}
> +
> +/**
> + * ice_vc_fdir_alloc_prof - allocate profile for this filter flow type
> + * @vf: pointer to the VF structure
> + * @flow: filter flow type
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_alloc_prof(struct ice_vf *vf, enum ice_fltr_ptype flow)
> +{
> + struct ice_vf_fdir *fdir = &vf->fdir;
> +
> + if (!fdir->fdir_prof) {
> + fdir->fdir_prof = devm_kcalloc(ice_pf_to_dev(vf->pf),
> + ICE_FLTR_PTYPE_MAX,
> + sizeof(*fdir->fdir_prof),
> + GFP_KERNEL);
> + if (!fdir->fdir_prof)
> + return -ENOMEM;
> + }
> +
> + if (!fdir->fdir_prof[flow]) {
> + fdir->fdir_prof[flow] = devm_kzalloc(ice_pf_to_dev(vf->pf),
> + sizeof(**fdir->fdir_prof),
> + GFP_KERNEL);
> + if (!fdir->fdir_prof[flow])
> + return -ENOMEM;
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_free_prof - free profile for this filter flow type
> + * @vf: pointer to the VF structure
> + * @flow: filter flow type
> + */
> +static void
> +ice_vc_fdir_free_prof(struct ice_vf *vf, enum ice_fltr_ptype flow)
> +{
> + struct ice_vf_fdir *fdir = &vf->fdir;
> +
> + if (!fdir->fdir_prof)
> + return;
> +
> + if (!fdir->fdir_prof[flow])
> + return;
> +
> + devm_kfree(ice_pf_to_dev(vf->pf), fdir->fdir_prof[flow]);
> + fdir->fdir_prof[flow] = NULL;
> +}
> +
> +/**
> + * ice_vc_fdir_free_prof_all - free all the profile for this VF
> + * @vf: pointer to the VF structure
> + */
> +static void ice_vc_fdir_free_prof_all(struct ice_vf *vf)
> +{
> + struct ice_vf_fdir *fdir = &vf->fdir;
> + enum ice_fltr_ptype flow;
> +
> + if (!fdir->fdir_prof)
> + return;
> +
> + for (flow = ICE_FLTR_PTYPE_NONF_NONE; flow <
> ICE_FLTR_PTYPE_MAX; flow++)
> + ice_vc_fdir_free_prof(vf, flow);
> +
> + devm_kfree(ice_pf_to_dev(vf->pf), fdir->fdir_prof);
> + fdir->fdir_prof = NULL;
> +}
> +
> +/**
> + * ice_vc_fdir_parse_flow_fld
> + * @proto_hdr: virtual channel protocol filter header
> + * @conf: FDIR configuration for each filter
> + * @fld: field type array
> + * @fld_cnt: field counter
> + *
> + * Parse the virtual channel filter header and store them into field type array
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_parse_flow_fld(struct virtchnl_proto_hdr *proto_hdr,
> + struct virtchnl_fdir_fltr_conf *conf,
> + enum ice_flow_field *fld, int *fld_cnt)
> +{
> + struct virtchnl_proto_hdr hdr;
> + u32 i;
> +
> + memcpy(&hdr, proto_hdr, sizeof(hdr));
> +
> + for (i = 0; (i < ARRAY_SIZE(fdir_inset_map)) &&
> + VIRTCHNL_GET_PROTO_HDR_FIELD(&hdr); i++)
> + if (VIRTCHNL_TEST_PROTO_HDR(&hdr, fdir_inset_map[i].field)) {
> + fld[*fld_cnt] = fdir_inset_map[i].fld;
> + *fld_cnt += 1;
> + if (*fld_cnt >= ICE_FLOW_FIELD_IDX_MAX)
> + return -EINVAL;
> + VIRTCHNL_DEL_PROTO_HDR_FIELD(&hdr,
> + fdir_inset_map[i].field);
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_set_flow_fld
> + * @vf: pointer to the VF structure
> + * @fltr: virtual channel add cmd buffer
> + * @conf: FDIR configuration for each filter
> + * @seg: array of one or more packet segments that describe the flow
> + *
> + * Parse the virtual channel add msg buffer's field vector and store them into
> + * flow's packet segment field
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_set_flow_fld(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
> + struct virtchnl_fdir_fltr_conf *conf,
> + struct ice_flow_seg_info *seg)
> +{
> + struct virtchnl_fdir_rule *rule = &fltr->rule_cfg;
> + enum ice_flow_field fld[ICE_FLOW_FIELD_IDX_MAX];
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + struct virtchnl_proto_hdrs *proto;
> + int fld_cnt = 0;
> + int i;
> +
> + proto = &rule->proto_hdrs;
> + for (i = 0; i < proto->count; i++) {
> + struct virtchnl_proto_hdr *hdr = &proto->proto_hdr[i];
> + int ret;
> +
> + ret = ice_vc_fdir_parse_flow_fld(hdr, conf, fld, &fld_cnt);
> + if (ret)
> + return ret;
> + }
> +
> + if (fld_cnt == 0) {
> + dev_dbg(dev, "Empty input set for VF %d\n", vf->vf_id);
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < fld_cnt; i++)
> + ice_flow_set_fld(seg, fld[i],
> + ICE_FLOW_FLD_OFF_INVAL,
> + ICE_FLOW_FLD_OFF_INVAL,
> + ICE_FLOW_FLD_OFF_INVAL, false);
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_set_flow_fld - config the flow's packet segment header
> + * @vf: pointer to the VF structure
> + * @conf: FDIR configuration for each filter
> + * @seg: array of one or more packet segments that describe the flow
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> + struct virtchnl_fdir_fltr_conf *conf,
> + struct ice_flow_seg_info *seg)
> +{
> + enum ice_fltr_ptype flow = conf->input.flow_type;
> + struct device *dev = ice_pf_to_dev(vf->pf);
> +
> + switch (flow) {
> + case ICE_FLTR_PTYPE_NONF_IPV4_OTHER:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_TCP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_TCP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_UDP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_SCTP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_OTHER:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_TCP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_TCP |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_UDP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_SCTP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + default:
> + dev_dbg(dev, "Invalid flow type 0x%x for VF %d failed\n",
> + flow, vf->vf_id);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_rem_prof - remove profile for this filter flow type
> + * @vf: pointer to the VF structure
> + * @flow: filter flow type
> + * @tun: 0 implies non-tunnel type filter, 1 implies tunnel type filter
> + */
> +static void
> +ice_vc_fdir_rem_prof(struct ice_vf *vf, enum ice_fltr_ptype flow, int tun)
> +{
> + struct ice_vf_fdir *fdir = &vf->fdir;
> + struct ice_fd_hw_prof *vf_prof;
> + struct ice_pf *pf = vf->pf;
> + struct ice_vsi *vf_vsi;
> + struct device *dev;
> + struct ice_hw *hw;
> + u64 prof_id;
> + int i;
> +
> + dev = ice_pf_to_dev(pf);
> + hw = &pf->hw;
> + if (!fdir->fdir_prof || !fdir->fdir_prof[flow])
> + return;
> +
> + vf_prof = fdir->fdir_prof[flow];
> +
> + vf_vsi = pf->vsi[vf->lan_vsi_idx];
> + if (!vf_vsi) {
> + dev_dbg(dev, "NULL vf %d vsi pointer\n", vf->vf_id);
> + return;
> + }
> +
> + if (!fdir->prof_entry_cnt[flow][tun])
> + return;
> +
> + prof_id = ICE_FLOW_PROF_FD(vf_vsi->vsi_num,
> + flow, tun ? ICE_FLTR_PTYPE_MAX : 0);
> +
> + for (i = 0; i < fdir->prof_entry_cnt[flow][tun]; i++)
> + if (vf_prof->entry_h[i][tun]) {
> + u16 vsi_num = ice_get_hw_vsi_num(hw, vf_prof-
> >vsi_h[i]);
> +
> + ice_rem_prof_id_flow(hw, ICE_BLK_FD, vsi_num,
> prof_id);
> + ice_flow_rem_entry(hw, ICE_BLK_FD,
> + vf_prof->entry_h[i][tun]);
> + vf_prof->entry_h[i][tun] = 0;
> + }
> +
> + ice_flow_rem_prof(hw, ICE_BLK_FD, prof_id);
> + devm_kfree(dev, vf_prof->fdir_seg[tun]);
> + vf_prof->fdir_seg[tun] = NULL;
> +
> + for (i = 0; i < vf_prof->cnt; i++)
> + vf_prof->vsi_h[i] = 0;
> +
> + fdir->prof_entry_cnt[flow][tun] = 0;
> +}
> +
> +/**
> + * ice_vc_fdir_rem_prof_all - remove profile for this VF
> + * @vf: pointer to the VF structure
> + */
> +static void ice_vc_fdir_rem_prof_all(struct ice_vf *vf)
> +{
> + enum ice_fltr_ptype flow;
> +
> + for (flow = ICE_FLTR_PTYPE_NONF_NONE;
> + flow < ICE_FLTR_PTYPE_MAX; flow++) {
> + ice_vc_fdir_rem_prof(vf, flow, 0);
> + ice_vc_fdir_rem_prof(vf, flow, 1);
> + }
> +}
> +
> +/**
> + * ice_vc_fdir_write_flow_prof
> + * @vf: pointer to the VF structure
> + * @flow: filter flow type
> + * @seg: array of one or more packet segments that describe the flow
> + * @tun: 0 implies non-tunnel type filter, 1 implies tunnel type filter
> + *
> + * Write the flow's profile config and packet segment into the hardware
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_write_flow_prof(struct ice_vf *vf, enum ice_fltr_ptype flow,
> + struct ice_flow_seg_info *seg, int tun)
> +{
> + struct ice_vf_fdir *fdir = &vf->fdir;
> + struct ice_vsi *vf_vsi, *ctrl_vsi;
> + struct ice_flow_seg_info *old_seg;
> + struct ice_flow_prof *prof = NULL;
> + struct ice_fd_hw_prof *vf_prof;
> + enum ice_status status;
> + struct device *dev;
> + struct ice_pf *pf;
> + struct ice_hw *hw;
> + u64 entry1_h = 0;
> + u64 entry2_h = 0;
> + u64 prof_id;
> + int ret;
> +
> + pf = vf->pf;
> + dev = ice_pf_to_dev(pf);
> + hw = &pf->hw;
> + vf_vsi = pf->vsi[vf->lan_vsi_idx];
> + if (!vf_vsi)
> + return -EINVAL;
> +
> + ctrl_vsi = pf->vsi[vf->ctrl_vsi_idx];
> + if (!ctrl_vsi)
> + return -EINVAL;
> +
> + vf_prof = fdir->fdir_prof[flow];
> + old_seg = vf_prof->fdir_seg[tun];
> + if (old_seg) {
> + if (!memcmp(old_seg, seg, sizeof(*seg))) {
> + dev_dbg(dev, "Duplicated profile for VF %d!\n",
> + vf->vf_id);
> + return -EEXIST;
> + }
> +
> + if (fdir->fdir_fltr_cnt[flow][tun]) {
> + ret = -EINVAL;
> + dev_dbg(dev, "Input set conflicts for VF %d\n",
> + vf->vf_id);
> + goto err_exit;
> + }
> +
> + /* remove previously allocated profile */
> + ice_vc_fdir_rem_prof(vf, flow, tun);
> + }
> +
> + prof_id = ICE_FLOW_PROF_FD(vf_vsi->vsi_num,
> + flow, tun ? ICE_FLTR_PTYPE_MAX : 0);
> +
> + status = ice_flow_add_prof(hw, ICE_BLK_FD, ICE_FLOW_RX, prof_id,
> seg,
> + tun + 1, &prof);
> + ret = ice_status_to_errno(status);
> + if (ret) {
> + dev_dbg(dev, "Could not add VSI flow 0x%x for VF %d\n",
> + flow, vf->vf_id);
> + goto err_exit;
> + }
> +
> + status = ice_flow_add_entry(hw, ICE_BLK_FD, prof_id, vf_vsi->idx,
> + vf_vsi->idx, ICE_FLOW_PRIO_NORMAL,
> + seg, &entry1_h);
> + ret = ice_status_to_errno(status);
> + if (ret) {
> + dev_dbg(dev, "Could not add flow 0x%x VSI entry for VF %d\n",
> + flow, vf->vf_id);
> + goto err_prof;
> + }
> +
> + status = ice_flow_add_entry(hw, ICE_BLK_FD, prof_id, vf_vsi->idx,
> + ctrl_vsi->idx, ICE_FLOW_PRIO_NORMAL,
> + seg, &entry2_h);
> + ret = ice_status_to_errno(status);
> + if (ret) {
> + dev_dbg(dev,
> + "Could not add flow 0x%x Ctrl VSI entry for VF %d\n",
> + flow, vf->vf_id);
> + goto err_entry_1;
> + }
> +
> + vf_prof->fdir_seg[tun] = seg;
> + vf_prof->cnt = 0;
> + fdir->prof_entry_cnt[flow][tun] = 0;
> +
> + vf_prof->entry_h[vf_prof->cnt][tun] = entry1_h;
> + vf_prof->vsi_h[vf_prof->cnt] = vf_vsi->idx;
> + vf_prof->cnt++;
> + fdir->prof_entry_cnt[flow][tun]++;
> +
> + vf_prof->entry_h[vf_prof->cnt][tun] = entry2_h;
> + vf_prof->vsi_h[vf_prof->cnt] = ctrl_vsi->idx;
> + vf_prof->cnt++;
> + fdir->prof_entry_cnt[flow][tun]++;
> +
> + return 0;
> +
> +err_entry_1:
> + ice_rem_prof_id_flow(hw, ICE_BLK_FD,
> + ice_get_hw_vsi_num(hw, vf_vsi->idx), prof_id);
> + ice_flow_rem_entry(hw, ICE_BLK_FD, entry1_h);
> +err_prof:
> + ice_flow_rem_prof(hw, ICE_BLK_FD, prof_id);
> +err_exit:
> + return ret;
> +}
> +
> +/**
> + * ice_vc_fdir_config_input_set
> + * @vf: pointer to the VF structure
> + * @fltr: virtual channel add cmd buffer
> + * @conf: FDIR configuration for each filter
> + * @tun: 0 implies non-tunnel type filter, 1 implies tunnel type filter
> + *
> + * Config the input set type and value for virtual channel add msg buffer
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_config_input_set(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
> + struct virtchnl_fdir_fltr_conf *conf, int tun)
> +{
> + struct ice_fdir_fltr *input = &conf->input;
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + struct ice_flow_seg_info *seg;
> + enum ice_fltr_ptype flow;
> + int ret;
> +
> + flow = input->flow_type;
> + ret = ice_vc_fdir_alloc_prof(vf, flow);
> + if (ret) {
> + dev_dbg(dev, "Alloc flow prof for VF %d failed\n", vf->vf_id);
> + return ret;
> + }
> +
> + seg = devm_kzalloc(dev, sizeof(*seg), GFP_KERNEL);
> + if (!seg)
> + return -ENOMEM;
> +
> + ret = ice_vc_fdir_set_flow_fld(vf, fltr, conf, seg);
> + if (ret) {
> + dev_dbg(dev, "Set flow field for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + ret = ice_vc_fdir_set_flow_hdr(vf, conf, seg);
> + if (ret) {
> + dev_dbg(dev, "Set flow hdr for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + ret = ice_vc_fdir_write_flow_prof(vf, flow, seg, tun);
> + if (ret == -EEXIST) {
> + devm_kfree(dev, seg);
> + } else if (ret) {
> + dev_dbg(dev, "Write flow profile for VF %d failed\n",
> + vf->vf_id);
> + goto err_exit;
> + }
> +
> + return 0;
> +
> +err_exit:
> + devm_kfree(dev, seg);
> + return ret;
> +}
> +
> +/**
> + * ice_vc_fdir_match_pattern
> + * @fltr: virtual channel add cmd buffer
> + * @type: virtual channel protocol filter header type
> + *
> + * Matching the header type by comparing @fltr and @type's value.
> + *
> + * Return: true on success, and false on error.
> + */
> +static bool
> +ice_vc_fdir_match_pattern(struct virtchnl_fdir_add *fltr,
> + enum virtchnl_proto_hdr_type *type)
> +{
> + struct virtchnl_proto_hdrs *proto = &fltr->rule_cfg.proto_hdrs;
> + int i = 0;
> +
> + while ((i < proto->count) &&
> + (*type == proto->proto_hdr[i].type) &&
> + (*type != VIRTCHNL_PROTO_HDR_NONE)) {
> + type++;
> + i++;
> + }
> +
> + return ((i == proto->count) &&
> + (*type == VIRTCHNL_PROTO_HDR_NONE));
> +}
> +
> +/**
> + * ice_vc_fdir_get_pattern - get while list pattern
> + * @vf: pointer to the VF info
> + * @len: filter list length
> + *
> + * Return: pointer to allowed filter list
> + */
> +static const struct virtchnl_fdir_pattern_match_item *
> +ice_vc_fdir_get_pattern(struct ice_vf *vf, int *len)
> +{
> + const struct virtchnl_fdir_pattern_match_item *item;
> + struct ice_pf *pf = vf->pf;
> + struct ice_hw *hw;
> +
> + hw = &pf->hw;
> + item = vc_fdir_pattern;
> + *len = ARRAY_SIZE(vc_fdir_pattern);
> +
> + return item;
> +}
> +
> +/**
> + * ice_vc_fdir_search_pattern
> + * @vf: pointer to the VF info
> + * @fltr: virtual channel add cmd buffer
> + *
> + * Search for matched pattern from supported pattern list
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_search_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr)
> +{
> + const struct virtchnl_fdir_pattern_match_item *pattern;
> + int len, i;
> +
> + pattern = ice_vc_fdir_get_pattern(vf, &len);
> +
> + for (i = 0; i < len; i++)
> + if (ice_vc_fdir_match_pattern(fltr, pattern[i].list))
> + return 0;
> +
> + return -EINVAL;
> +}
> +
> +/**
> + * ice_vc_fdir_parse_pattern
> + * @vf: pointer to the VF info
> + * @fltr: virtual channel add cmd buffer
> + * @conf: FDIR configuration for each filter
> + *
> + * Parse the virtual channel filter's pattern and store them into @conf
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
> + struct virtchnl_fdir_fltr_conf *conf)
> +{
> + struct virtchnl_proto_hdrs *proto = &fltr->rule_cfg.proto_hdrs;
> + enum virtchnl_proto_hdr_type l3 = VIRTCHNL_PROTO_HDR_NONE;
> + enum virtchnl_proto_hdr_type l4 = VIRTCHNL_PROTO_HDR_NONE;
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + struct ice_fdir_fltr *input = &conf->input;
> + int i;
> +
> + if (proto->count > VIRTCHNL_MAX_NUM_PROTO_HDRS) {
> + dev_dbg(dev, "Invalid protocol count:0x%x for VF %d\n",
> + proto->count, vf->vf_id);
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < proto->count; i++) {
> + struct virtchnl_proto_hdr *hdr = &proto->proto_hdr[i];
> + struct sctphdr *sctph;
> + struct ipv6hdr *ip6h;
> + struct udphdr *udph;
> + struct tcphdr *tcph;
> + struct iphdr *iph;
> +
> + switch (hdr->type) {
> + case VIRTCHNL_PROTO_HDR_ETH:
> + break;
> + case VIRTCHNL_PROTO_HDR_IPV4:
> + iph = (struct iphdr *)hdr->buffer;
> + l3 = VIRTCHNL_PROTO_HDR_IPV4;
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV4_OTHER;
> +
> + if (hdr->field_selector) {
> + input->ip.v4.src_ip = iph->saddr;
> + input->ip.v4.dst_ip = iph->daddr;
> + input->ip.v4.tos = iph->tos;
> + input->ip.v4.proto = iph->protocol;
> + }
> + break;
> + case VIRTCHNL_PROTO_HDR_IPV6:
> + ip6h = (struct ipv6hdr *)hdr->buffer;
> + l3 = VIRTCHNL_PROTO_HDR_IPV6;
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV6_OTHER;
> +
> + if (hdr->field_selector) {
> + memcpy(input->ip.v6.src_ip,
> + ip6h->saddr.in6_u.u6_addr8,
> + sizeof(ip6h->saddr));
> + memcpy(input->ip.v6.dst_ip,
> + ip6h->daddr.in6_u.u6_addr8,
> + sizeof(ip6h->daddr));
> + input->ip.v6.tc = ((u8)(ip6h->priority) << 4) |
> + (ip6h->flow_lbl[0] >> 4);
> + input->ip.v6.proto = ip6h->nexthdr;
> + }
> + break;
> + case VIRTCHNL_PROTO_HDR_TCP:
> + tcph = (struct tcphdr *)hdr->buffer;
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV4_TCP;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV6_TCP;
> +
> + if (hdr->field_selector) {
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4) {
> + input->ip.v4.src_port = tcph->source;
> + input->ip.v4.dst_port = tcph->dest;
> + } else if (l3 == VIRTCHNL_PROTO_HDR_IPV6) {
> + input->ip.v6.src_port = tcph->source;
> + input->ip.v6.dst_port = tcph->dest;
> + }
> + }
> + break;
> + case VIRTCHNL_PROTO_HDR_UDP:
> + udph = (struct udphdr *)hdr->buffer;
> + l4 = VIRTCHNL_PROTO_HDR_UDP;
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV4_UDP;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV6_UDP;
> +
> + if (hdr->field_selector) {
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4) {
> + input->ip.v4.src_port = udph->source;
> + input->ip.v4.dst_port = udph->dest;
> + } else if (l3 == VIRTCHNL_PROTO_HDR_IPV6) {
> + input->ip.v6.src_port = udph->source;
> + input->ip.v6.dst_port = udph->dest;
> + }
> + }
> + break;
> + case VIRTCHNL_PROTO_HDR_SCTP:
> + sctph = (struct sctphdr *)hdr->buffer;
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV4_SCTP;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV6_SCTP;
> +
> + if (hdr->field_selector) {
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4) {
> + input->ip.v4.src_port = sctph->source;
> + input->ip.v4.dst_port = sctph->dest;
> + } else if (l3 == VIRTCHNL_PROTO_HDR_IPV6) {
> + input->ip.v6.src_port = sctph->source;
> + input->ip.v6.dst_port = sctph->dest;
> + }
> + }
> + break;
> + default:
> + dev_dbg(dev, "Invalid header type 0x:%x for VF %d\n",
> + hdr->type, vf->vf_id);
> + return -EINVAL;
> + }
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_parse_action
> + * @vf: pointer to the VF info
> + * @fltr: virtual channel add cmd buffer
> + * @conf: FDIR configuration for each filter
> + *
> + * Parse the virtual channel filter's action and store them into @conf
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_parse_action(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
> + struct virtchnl_fdir_fltr_conf *conf)
> +{
> + struct virtchnl_filter_action_set *as = &fltr->rule_cfg.action_set;
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + struct ice_fdir_fltr *input = &conf->input;
> + u32 dest_num = 0;
> + u32 mark_num = 0;
> + int i;
> +
> + if (as->count > VIRTCHNL_MAX_NUM_ACTIONS) {
> + dev_dbg(dev, "Invalid action numbers:0x%x for VF %d\n",
> + as->count, vf->vf_id);
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < as->count; i++) {
> + struct virtchnl_filter_action *action = &as->actions[i];
> +
> + switch (action->type) {
> + case VIRTCHNL_ACTION_PASSTHRU:
> + dest_num++;
> + input->dest_ctl =
> +
> ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
> + break;
> + case VIRTCHNL_ACTION_DROP:
> + dest_num++;
> + input->dest_ctl =
> + ICE_FLTR_PRGM_DESC_DEST_DROP_PKT;
No need to wrap
> + break;
> + case VIRTCHNL_ACTION_QUEUE:
> + dest_num++;
> + input->dest_ctl =
> +
> ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX;
Same here
> + input->q_index = action->act_conf.queue.index;
> + break;
> + case VIRTCHNL_ACTION_Q_REGION:
> + dest_num++;
> + input->dest_ctl =
> +
> ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP;
And here as well
> + input->q_index = action->act_conf.queue.index;
> + input->q_region = action->act_conf.queue.region;
> + break;
> + case VIRTCHNL_ACTION_MARK:
> + mark_num++;
> + input->fltr_id = action->act_conf.mark_id;
> + input->fdid_prio =
> ICE_FXD_FLTR_QW1_FDID_PRI_THREE;
> + break;
> + default:
> + dev_dbg(dev, "Invalid action type:0x%x for VF %d\n",
> + action->type, vf->vf_id);
> + return -EINVAL;
> + }
> + }
> +
> + if (dest_num == 0 || dest_num >= 2) {
> + dev_dbg(dev, "Invalid destination action for VF %d\n",
> + vf->vf_id);
> + return -EINVAL;
> + }
> +
> + if (mark_num >= 2) {
> + dev_dbg(dev, "Too many mark actions for VF %d\n", vf->vf_id);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_validate_fdir_fltr - validate the virtual channel filter
> + * @vf: pointer to the VF info
> + * @fltr: virtual channel add cmd buffer
> + * @conf: FDIR configuration for each filter
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_validate_fdir_fltr(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
> + struct virtchnl_fdir_fltr_conf *conf)
> +{
> + int ret;
> +
> + ret = ice_vc_fdir_search_pattern(vf, fltr);
> + if (ret)
> + return ret;
> +
> + ret = ice_vc_fdir_parse_pattern(vf, fltr, conf);
> + if (ret)
> + return ret;
> +
> + return ice_vc_fdir_parse_action(vf, fltr, conf);
> +}
> +
> +/**
> + * ice_vc_fdir_comp_rules - compare if two filter rules have the same value
> + * @conf_a: FDIR configuration for filter a
> + * @conf_b: FDIR configuration for filter b
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static bool
> +ice_vc_fdir_comp_rules(struct virtchnl_fdir_fltr_conf *conf_a,
> + struct virtchnl_fdir_fltr_conf *conf_b)
> +{
> + struct ice_fdir_fltr *a = &conf_a->input;
> + struct ice_fdir_fltr *b = &conf_b->input;
> +
> + if (a->flow_type != b->flow_type)
> + return false;
> + if (memcmp(&a->ip, &b->ip, sizeof(a->ip)))
> + return false;
> + if (memcmp(&a->mask, &b->mask, sizeof(a->mask)))
> + return false;
> + if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
> + return false;
> + if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
> + return false;
> +
> + return true;
> +}
> +
> +/**
> + * ice_vc_fdir_is_dup_fltr
> + * @vf: pointer to the VF info
> + * @conf: FDIR configuration for each filter
> + *
> + * Check if there is duplicated rule with same @conf value
> + *
> + * Return: 0 true success, and false on error.
> + */
> +static bool
> +ice_vc_fdir_is_dup_fltr(struct ice_vf *vf, struct virtchnl_fdir_fltr_conf *conf)
> +{
> + struct ice_fdir_fltr *desc;
> + bool ret;
> +
> + list_for_each_entry(desc, &vf->fdir.fdir_rule_list, fltr_node) {
> + struct virtchnl_fdir_fltr_conf *node =
> + to_fltr_conf_from_desc(desc);
> +
> + ret = ice_vc_fdir_comp_rules(node, conf);
> + if (ret)
> + return true;
> + }
> +
> + return false;
> +}
> +
> +/**
> + * ice_vc_fdir_insert_entry
> + * @vf: pointer to the VF info
> + * @conf: FDIR configuration for each filter
> + * @id: pointer to ID value allocated by driver
> + *
> + * Insert FDIR conf entry into list and allocate ID for this filter
> + *
> + * Return: 0 true success, and other on error.
> + */
> +static int
> +ice_vc_fdir_insert_entry(struct ice_vf *vf,
> + struct virtchnl_fdir_fltr_conf *conf, u32 *id)
> +{
> + struct ice_fdir_fltr *input = &conf->input;
> + int i;
> +
> + /* alloc ID corresponding with conf */
> + i = idr_alloc(&vf->fdir.fdir_rule_idr, conf, 0,
> + ICE_FDIR_MAX_FLTRS, GFP_KERNEL);
> + if (i < 0)
> + return -EINVAL;
> + *id = i;
> +
> + list_add(&input->fltr_node, &vf->fdir.fdir_rule_list);
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_remove_entry - remove FDIR conf entry by ID value
> + * @vf: pointer to the VF info
> + * @conf: FDIR configuration for each filter
> + * @id: filter rule's ID
> + */
> +static void
> +ice_vc_fdir_remove_entry(struct ice_vf *vf,
> + struct virtchnl_fdir_fltr_conf *conf, u32 id)
> +{
> + struct ice_fdir_fltr *input = &conf->input;
> +
> + idr_remove(&vf->fdir.fdir_rule_idr, id);
> + list_del(&input->fltr_node);
> +}
> +
> +/**
> + * ice_vc_fdir_lookup_entry - lookup FDIR conf entry by ID value
> + * @vf: pointer to the VF info
> + * @id: filter rule's ID
> + *
> + * Return: NULL on error, and other on success.
> + */
> +static struct virtchnl_fdir_fltr_conf *
> +ice_vc_fdir_lookup_entry(struct ice_vf *vf, u32 id)
> +{
> + return idr_find(&vf->fdir.fdir_rule_idr, id);
> +}
> +
> +/**
> + * ice_vc_fdir_flush_entry - remove all FDIR conf entry
> + * @vf: pointer to the VF info
> + */
> +static void ice_vc_fdir_flush_entry(struct ice_vf *vf)
> +{
> + struct virtchnl_fdir_fltr_conf *conf;
> + struct ice_fdir_fltr *desc, *temp;
> +
> + list_for_each_entry_safe(desc, temp,
> + &vf->fdir.fdir_rule_list, fltr_node) {
> + conf = to_fltr_conf_from_desc(desc);
> + list_del(&desc->fltr_node);
> + devm_kfree(ice_pf_to_dev(vf->pf), conf);
> + }
> +}
> +
> +/**
> + * ice_vc_fdir_write_fltr - write filter rule into hardware
> + * @vf: pointer to the VF info
> + * @conf: FDIR configuration for each filter
> + * @add: true implies add rule, false implies del rules
> + * @is_tun: false implies non-tunnel type filter, true implies tunnel filter
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int ice_vc_fdir_write_fltr(struct ice_vf *vf,
> + struct virtchnl_fdir_fltr_conf *conf,
> + bool add, bool is_tun)
> +{
> + struct ice_fdir_fltr *input = &conf->input;
> + struct ice_vsi *vsi, *ctrl_vsi;
> + struct ice_fltr_desc desc;
> + enum ice_status status;
> + struct device *dev;
> + struct ice_pf *pf;
> + struct ice_hw *hw;
> + int ret;
> + u8 *pkt;
> +
> + pf = vf->pf;
> + dev = ice_pf_to_dev(pf);
> + hw = &pf->hw;
> + vsi = pf->vsi[vf->lan_vsi_idx];
> + if (!vsi) {
> + dev_dbg(dev, "Invalid vsi for VF %d\n", vf->vf_id);
> + return -EINVAL;
> + }
> +
> + input->dest_vsi = vsi->idx;
> + input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
> +
> + ctrl_vsi = pf->vsi[vf->ctrl_vsi_idx];
> + if (!ctrl_vsi) {
> + dev_dbg(dev, "Invalid ctrl_vsi for VF %d\n", vf->vf_id);
> + return -EINVAL;
> + }
> +
> + pkt = devm_kzalloc(dev, ICE_FDIR_MAX_RAW_PKT_SIZE,
> GFP_KERNEL);
> + if (!pkt)
> + return -ENOMEM;
> +
> + ice_fdir_get_prgm_desc(hw, input, &desc, add);
> + status = ice_fdir_get_gen_prgm_pkt(hw, input, pkt, false, is_tun);
> + ret = ice_status_to_errno(status);
> + if (ret) {
> + dev_dbg(dev, "Gen training pkt for VF %d ptype %d failed\n",
> + vf->vf_id, input->flow_type);
> + goto err_free_pkt;
> + }
> +
> + ret = ice_prgm_fdir_fltr(ctrl_vsi, &desc, pkt);
> + if (ret)
> + goto err_free_pkt;
> +
> + return 0;
> +
> +err_free_pkt:
> + devm_kfree(dev, pkt);
> + return ret;
> +}
> +
> +/**
> + * ice_vc_add_fdir_fltr - add a FDIR filter for VF by the msg buffer
> + * @vf: pointer to the VF info
> + * @msg: pointer to the msg buffer
> + *
> + * Return: 0 on success, and other on error.
> + */
> +int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
> +{
> + struct virtchnl_fdir_add *fltr = (struct virtchnl_fdir_add *)msg;
> + struct virtchnl_fdir_add *stat = NULL;
> + struct virtchnl_fdir_fltr_conf *conf;
> + enum virtchnl_status_code v_ret;
> + struct device *dev;
> + struct ice_pf *pf;
> + int is_tun = 0;
> + int len = 0;
> + int ret;
> +
> + pf = vf->pf;
> + dev = ice_pf_to_dev(pf);
> + ret = ice_vc_fdir_param_check(vf, fltr->vsi_id);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + dev_dbg(dev, "Parameter check for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + ret = ice_vf_start_ctrl_vsi(vf);
> + if (ret && (ret != -EEXIST)) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + dev_err(dev, "Init FDIR for VF %d failed, ret:%d\n",
> + vf->vf_id, ret);
> + goto err_exit;
> + }
> +
> + stat = kzalloc(sizeof(*stat), GFP_KERNEL);
> + if (!stat) {
> + v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
> + dev_dbg(dev, "Alloc stat for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + conf = devm_kzalloc(dev, sizeof(*conf), GFP_KERNEL);
> + if (!conf) {
> + v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
> + dev_dbg(dev, "Alloc conf for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + len = sizeof(*stat);
> + ret = ice_vc_validate_fdir_fltr(vf, fltr, conf);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_INVALID;
> + dev_dbg(dev, "Invalid FDIR filter from VF %d\n", vf->vf_id);
> + goto err_free_conf;
> + }
> +
> + if (fltr->validate_only) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_SUCCESS;
> + devm_kfree(dev, conf);
> + ret = ice_vc_send_msg_to_vf(vf,
> VIRTCHNL_OP_ADD_FDIR_FILTER,
> + v_ret, (u8 *)stat, len);
> + goto exit;
> + }
> +
> + ret = ice_vc_fdir_config_input_set(vf, fltr, conf, is_tun);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT;
> + dev_err(dev, "VF %d: FDIR input set configure failed, ret:%d\n",
> + vf->vf_id, ret);
> + goto err_free_conf;
> + }
> +
> + ret = ice_vc_fdir_is_dup_fltr(vf, conf);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_EXIST;
> + dev_dbg(dev, "VF %d: duplicated FDIR rule detected\n",
> + vf->vf_id);
> + goto err_free_conf;
> + }
> +
> + ret = ice_vc_fdir_insert_entry(vf, conf, &stat->flow_id);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_dbg(dev, "VF %d: insert FDIR list failed\n", vf->vf_id);
> + goto err_free_conf;
> + }
> +
> + ret = ice_vc_fdir_write_fltr(vf, conf, true, is_tun);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_err(dev, "VF %d: writing FDIR rule failed, ret:%d\n",
> + vf->vf_id, ret);
> + goto err_rem_entry;
> + }
> +
> + vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]++;
> +
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_SUCCESS;
> +exit:
> + ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER,
> v_ret,
> + (u8 *)stat, len);
> + kfree(stat);
> + return ret;
> +
> +err_rem_entry:
> + ice_vc_fdir_remove_entry(vf, conf, stat->flow_id);
> +err_free_conf:
> + devm_kfree(dev, conf);
> +err_exit:
> + ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER,
> v_ret,
> + (u8 *)stat, len);
> + kfree(stat);
> + return ret;
> +}
> +
> +/**
> + * ice_vc_del_fdir_fltr - delete a FDIR filter for VF by the msg buffer
> + * @vf: pointer to the VF info
> + * @msg: pointer to the msg buffer
> + *
> + * Return: 0 on success, and other on error.
> + */
> +int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg)
> +{
> + struct virtchnl_fdir_del *fltr = (struct virtchnl_fdir_del *)msg;
> + struct virtchnl_fdir_del *stat = NULL;
> + struct virtchnl_fdir_fltr_conf *conf;
> + enum virtchnl_status_code v_ret;
> + struct device *dev;
> + struct ice_pf *pf;
> + int is_tun = 0;
> + int len = 0;
> + int ret;
> +
> + pf = vf->pf;
> + dev = ice_pf_to_dev(pf);
> + ret = ice_vc_fdir_param_check(vf, fltr->vsi_id);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_ERR_PARAM;
> + dev_dbg(dev, "Parameter check for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + stat = kzalloc(sizeof(*stat), GFP_KERNEL);
> + if (!stat) {
> + v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
> + dev_dbg(dev, "Alloc stat for VF %d failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + len = sizeof(*stat);
> +
> + conf = ice_vc_fdir_lookup_entry(vf, fltr->flow_id);
> + if (!conf) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST;
> + dev_dbg(dev, "VF %d: FDIR invalid flow_id:0x%X\n",
> + vf->vf_id, fltr->flow_id);
> + goto err_exit;
> + }
> +
> + /* Just return failure when ctrl_vsi idx is invalid */
> + if (vf->ctrl_vsi_idx == ICE_NO_VSI) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_err(dev, "Invalid FDIR ctrl_vsi for VF %d\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> + ret = ice_vc_fdir_write_fltr(vf, conf, false, is_tun);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_err(dev, "VF %d: writing FDIR rule failed, ret:%d\n",
> + vf->vf_id, ret);
> + goto err_exit;
> + }
> +
> + ice_vc_fdir_remove_entry(vf, conf, fltr->flow_id);
> + devm_kfree(dev, conf);
> + vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]--;
> +
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_SUCCESS;
> +
> +err_exit:
> + ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_DEL_FDIR_FILTER,
> v_ret,
> + (u8 *)stat, len);
> + kfree(stat);
> + return ret;
> +}
> +
> +/**
> + * ice_vf_fdir_init - init FDIR resource for VF
> + * @vf: pointer to the VF info
> + */
> +void ice_vf_fdir_init(struct ice_vf *vf)
> +{
> + struct ice_vf_fdir *fdir = &vf->fdir;
> +
> + idr_init(&fdir->fdir_rule_idr);
> + INIT_LIST_HEAD(&fdir->fdir_rule_list);
> +}
> +
> +/**
> + * ice_vf_fdir_exit - destroy FDIR resource for VF
> + * @vf: pointer to the VF info
> + */
> +void ice_vf_fdir_exit(struct ice_vf *vf)
> +{
> + ice_vc_fdir_flush_entry(vf);
> + idr_destroy(&vf->fdir.fdir_rule_idr);
> + ice_vc_fdir_rem_prof_all(vf);
> + ice_vc_fdir_free_prof_all(vf);
> +}
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> new file mode 100644
> index 000000000000..676de402475e
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> @@ -0,0 +1,24 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (C) 2018-2020, Intel Corporation. */
> +
> +#ifndef _ICE_VIRTCHNL_FDIR_H_
> +#define _ICE_VIRTCHNL_FDIR_H_
> +
> +struct ice_vf;
> +
> +/* VF FDIR information structure */
> +struct ice_vf_fdir {
> + u16 fdir_fltr_cnt[ICE_FLTR_PTYPE_MAX][ICE_FD_HW_SEG_MAX];
> + int prof_entry_cnt[ICE_FLTR_PTYPE_MAX][ICE_FD_HW_SEG_MAX];
> + struct ice_fd_hw_prof **fdir_prof;
> +
> + struct idr fdir_rule_idr;
> + struct list_head fdir_rule_list;
> +};
> +
> +int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg);
> +int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg);
> +void ice_vf_fdir_init(struct ice_vf *vf);
> +void ice_vf_fdir_exit(struct ice_vf *vf);
> +
> +#endif /* _ICE_VIRTCHNL_FDIR_H_ */
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> index ddd6062c5b8b..18f4442b1d25 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> @@ -473,6 +473,7 @@ static void ice_free_vf_res(struct ice_vf *vf)
> * accessing the VF's VSI after it's freed or invalidated.
> */
> clear_bit(ICE_VF_STATE_INIT, vf->vf_states);
> + ice_vf_fdir_exit(vf);
> /* free VF control VSI */
> if (vf->ctrl_vsi_idx != ICE_NO_VSI)
> ice_vf_ctrl_vsi_release(vf);
> @@ -1512,6 +1513,7 @@ bool ice_reset_all_vfs(struct ice_pf *pf, bool is_vflr)
> ice_for_each_vf(pf, v) {
> vf = &pf->vf[v];
>
> + ice_vf_fdir_exit(vf);
> /* clean VF control VSI when resetting VFs since it should be
> * setup only when iAVF creates its first FDIR rule.
> */
> @@ -1639,6 +1641,7 @@ bool ice_reset_vf(struct ice_vf *vf, bool is_vflr)
> dev_err(dev, "disabling promiscuous mode failed\n");
> }
>
> + ice_vf_fdir_exit(vf);
> /* clean VF control VSI when resetting VF since it should be setup
> * only when iAVF creates its first FDIR rule.
> */
> @@ -1840,6 +1843,7 @@ static void ice_set_dflt_settings_vfs(struct ice_pf
> *pf)
> * creates its first fdir rule.
> */
> ice_vf_ctrl_invalidate_vsi(vf);
> + ice_vf_fdir_init(vf);
> }
> }
>
> @@ -2162,7 +2166,7 @@ ice_vf_lan_overflow_event(struct ice_pf *pf, struct
> ice_rq_event_info *event)
> *
> * send msg to VF
> */
> -static int
> +int
> ice_vc_send_msg_to_vf(struct ice_vf *vf, u32 v_opcode,
> enum virtchnl_status_code v_retval, u8 *msg, u16 msglen)
> {
> @@ -2290,6 +2294,9 @@ static int ice_vc_get_vf_res_msg(struct ice_vf *vf, u8
> *msg)
> if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC)
> vfres->vf_cap_flags |=
> VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC;
>
> + if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_FDIR_PF)
> + vfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_FDIR_PF;
> +
> if (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2)
> vfres->vf_cap_flags |=
> VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2;
>
> @@ -2405,7 +2412,7 @@ static struct ice_vsi *ice_find_vsi_from_id(struct
> ice_pf *pf, u16 id)
> *
> * check for the valid VSI ID
> */
> -static bool ice_vc_isvalid_vsi_id(struct ice_vf *vf, u16 vsi_id)
> +bool ice_vc_isvalid_vsi_id(struct ice_vf *vf, u16 vsi_id)
> {
> struct ice_pf *pf = vf->pf;
> struct ice_vsi *vsi;
> @@ -4755,6 +4762,12 @@ void ice_vc_process_vf_msg(struct ice_pf *pf,
> struct ice_rq_event_info *event)
> case VIRTCHNL_OP_DEL_RSS_CFG:
> err = ice_vc_handle_rss_cfg(vf, msg, false);
> break;
> + case VIRTCHNL_OP_ADD_FDIR_FILTER:
> + err = ice_vc_add_fdir_fltr(vf, msg);
> + break;
> + case VIRTCHNL_OP_DEL_FDIR_FILTER:
> + err = ice_vc_del_fdir_fltr(vf, msg);
> + break;
> case VIRTCHNL_OP_UNKNOWN:
> default:
> dev_err(dev, "Unsupported opcode %d from VF %d\n",
> v_opcode,
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
> index 61e7daf7861e..d3a00fdf1ee4 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h
> @@ -4,6 +4,7 @@
> #ifndef _ICE_VIRTCHNL_PF_H_
> #define _ICE_VIRTCHNL_PF_H_
> #include "ice.h"
> +#include "ice_virtchnl_fdir.h"
> #include "ice_dcf.h"
>
> /* Restrict number of MAC Addr and VLAN that non-trusted VF can
> programmed */
> @@ -74,6 +75,7 @@ struct ice_vf {
> u16 vf_id; /* VF ID in the PF space */
> u16 lan_vsi_idx; /* index into PF struct */
> u16 ctrl_vsi_idx;
> + struct ice_vf_fdir fdir;
> /* first vector index of this VF in the PF space */
> int first_vector_idx;
> struct ice_sw *vf_sw_id; /* switch ID the VF VSIs connect to */
> @@ -142,6 +144,10 @@ ice_vf_lan_overflow_event(struct ice_pf *pf, struct
> ice_rq_event_info *event);
> void ice_print_vfs_mdd_events(struct ice_pf *pf);
> void ice_print_vf_rx_mdd_event(struct ice_vf *vf);
> struct ice_vsi *ice_vf_ctrl_vsi_setup(struct ice_vf *vf);
> +int
> +ice_vc_send_msg_to_vf(struct ice_vf *vf, u32 v_opcode,
> + enum virtchnl_status_code v_retval, u8 *msg, u16 msglen);
> +bool ice_vc_isvalid_vsi_id(struct ice_vf *vf, u16 vsi_id);
> #else /* CONFIG_PCI_IOV */
> #define ice_process_vflr_event(pf) do {} while (0)
> #define ice_free_vfs(pf) do {} while (0)
> diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
> index d7e5263fd2ec..6b8de39bc046 100644
> --- a/include/linux/avf/virtchnl.h
> +++ b/include/linux/avf/virtchnl.h
> @@ -145,6 +145,8 @@ enum virtchnl_ops {
> VIRTCHNL_OP_GET_SUPPORTED_RXDIDS = 44,
> VIRTCHNL_OP_ADD_RSS_CFG = 45,
> VIRTCHNL_OP_DEL_RSS_CFG = 46,
> + VIRTCHNL_OP_ADD_FDIR_FILTER = 47,
> + VIRTCHNL_OP_DEL_FDIR_FILTER = 48,
> /* New major set of opcodes introduced and so leaving room for
> * old misc opcodes to be added in future. Also these opcodes may only
> * be used if both the PF and VF have successfully negotiated the
> @@ -286,6 +288,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16,
> virtchnl_vsi_resource);
> #define VIRTCHNL_VF_OFFLOAD_ADQ 0X00800000
> #define VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC 0X04000000
> #define VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF 0X08000000
> +#define VIRTCHNL_VF_OFFLOAD_FDIR_PF 0X10000000
> #define VIRTCHNL_VF_CAP_DCF 0X40000000
>
> /* Define below the capability flags that are not offloads */
> @@ -624,6 +627,11 @@ enum virtchnl_action {
> /* action types */
> VIRTCHNL_ACTION_DROP = 0,
> VIRTCHNL_ACTION_TC_REDIRECT,
> + VIRTCHNL_ACTION_PASSTHRU,
> + VIRTCHNL_ACTION_QUEUE,
> + VIRTCHNL_ACTION_Q_REGION,
> + VIRTCHNL_ACTION_MARK,
> + VIRTCHNL_ACTION_COUNT,
> };
>
> enum virtchnl_flow_type {
> @@ -948,6 +956,114 @@ struct virtchnl_rss_cfg {
>
> VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
>
> +/* action configuration for FDIR */
> +struct virtchnl_filter_action {
> + enum virtchnl_action type;
> + union {
> + /* used for queue and qgroup action */
> + struct {
> + u16 index;
> + u8 region;
> + } queue;
> + /* used for count action */
> + struct {
> + /* share counter ID with other flow rules */
> + u8 shared;
> + u32 id; /* counter ID */
> + } count;
> + /* used for mark action */
> + u32 mark_id;
> + u8 reserve[32];
> + } act_conf;
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(36, virtchnl_filter_action);
> +
> +#define VIRTCHNL_MAX_NUM_ACTIONS 8
> +
> +struct virtchnl_filter_action_set {
> + /* action number must be less then VIRTCHNL_MAX_NUM_ACTIONS */
> + int count;
> + struct virtchnl_filter_action actions[VIRTCHNL_MAX_NUM_ACTIONS];
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(292, virtchnl_filter_action_set);
> +
> +/* pattern and action for FDIR rule */
> +struct virtchnl_fdir_rule {
> + struct virtchnl_proto_hdrs proto_hdrs;
> + struct virtchnl_filter_action_set action_set;
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
> +
> +/* Status returned to VF after VF requests FDIR commands
> + * VIRTCHNL_FDIR_SUCCESS
> + * VF FDIR related request is successfully done by PF
> + * The request can be OP_ADD/DEL.
> + *
> + * VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE
> + * OP_ADD_FDIR_FILTER request is failed due to no Hardware resource.
> + *
> + * VIRTCHNL_FDIR_FAILURE_RULE_EXIST
> + * OP_ADD_FDIR_FILTER request is failed due to the rule is already existed.
> + *
> + * VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT
> + * OP_ADD_FDIR_FILTER request is failed due to conflict with existing rule.
> + *
> + * VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST
> + * OP_DEL_FDIR_FILTER request is failed due to this rule doesn't exist.
> + *
> + * VIRTCHNL_FDIR_FAILURE_RULE_INVALID
> + * OP_ADD_FDIR_FILTER request is failed due to parameters validation
> + * or HW doesn't support.
> + *
> + * VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT
> + * OP_ADD/DEL_FDIR_FILTER request is failed due to timing out
> + * for programming.
> + */
> +enum virtchnl_fdir_prgm_status {
> + VIRTCHNL_FDIR_SUCCESS = 0,
> + VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE,
> + VIRTCHNL_FDIR_FAILURE_RULE_EXIST,
> + VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT,
> + VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST,
> + VIRTCHNL_FDIR_FAILURE_RULE_INVALID,
> + VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT,
> +};
> +
> +/* VIRTCHNL_OP_ADD_FDIR_FILTER
> + * VF sends this request to PF by filling out vsi_id,
> + * validate_only and rule_cfg. PF will return flow_id
> + * if the request is successfully done and return add_status to VF.
> + */
> +struct virtchnl_fdir_add {
> + u16 vsi_id; /* INPUT */
> + /*
> + * 1 for validating a fdir rule, 0 for creating a fdir rule.
> + * Validate and create share one ops:
> VIRTCHNL_OP_ADD_FDIR_FILTER.
> + */
> + u16 validate_only; /* INPUT */
> + u32 flow_id; /* OUTPUT */
> + struct virtchnl_fdir_rule rule_cfg; /* INPUT */
> + enum virtchnl_fdir_prgm_status status; /* OUTPUT */
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
> +
> +/* VIRTCHNL_OP_DEL_FDIR_FILTER
> + * VF sends this request to PF by filling out vsi_id
> + * and flow_id. PF will return del_status to VF.
> + */
> +struct virtchnl_fdir_del {
> + u16 vsi_id; /* INPUT */
> + u16 pad;
> + u32 flow_id; /* INPUT */
> + enum virtchnl_fdir_prgm_status status; /* OUTPUT */
> +};
> +
> +VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_fdir_del);
> +
> /* PF capability flags
> * VIRTCHNL_CAP_STATELESS_OFFLOADS flag indicates stateless offloads
> * such as TX/RX Checksum offloading and TSO for non-tunneled packets.
> Please
> @@ -1507,6 +1623,12 @@ virtchnl_vc_validate_vf_msg(struct
> virtchnl_version_info *ver, u32 v_opcode,
> case VIRTCHNL_OP_DEL_RSS_CFG:
> valid_len = sizeof(struct virtchnl_rss_cfg);
> break;
> + case VIRTCHNL_OP_ADD_FDIR_FILTER:
> + valid_len = sizeof(struct virtchnl_fdir_add);
> + break;
> + case VIRTCHNL_OP_DEL_FDIR_FILTER:
> + valid_len = sizeof(struct virtchnl_fdir_del);
> + break;
> case VIRTCHNL_OP_GET_CAPS:
> valid_len = sizeof(struct virtchnl_get_capabilities);
> break;
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF Qi Zhang
@ 2020-07-03 9:08 ` kernel test robot
2020-07-03 9:08 ` kernel test robot
1 sibling, 0 replies; 31+ messages in thread
From: kernel test robot @ 2020-07-03 9:08 UTC (permalink / raw)
To: intel-wired-lan
Hi Qi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on jkirsher-next-queue/dev-queue]
[cannot apply to v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qi-Zhang/Support-Advanced-AVF-features/20200703-070522
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: m68k-randconfig-r026-20200702 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:957:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:957:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:998:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:998:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_rule' is not an integer constant
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1052:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:1052:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_add' is not an integer constant
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1154:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1154:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1204:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1204:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1236:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1236:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1252:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1252:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1282:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1282:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1297:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1297:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1315:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1315:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1330:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1330:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:957:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:957:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:998:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:998:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_rule' is not an integer constant
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1052:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:1052:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_add' is not an integer constant
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1154:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1154:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1204:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1204:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1236:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1236:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1252:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1252:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1282:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1282:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1297:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1297:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1315:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1315:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1330:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1330:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
..
vim +/virtchnl_static_assert_virtchnl_fdir_rule +998 include/linux/avf/virtchnl.h
997
> 998 VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
999
1000 /* Status returned to VF after VF requests FDIR commands
1001 * VIRTCHNL_FDIR_SUCCESS
1002 * VF FDIR related request is successfully done by PF
1003 * The request can be OP_ADD/DEL.
1004 *
1005 * VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE
1006 * OP_ADD_FDIR_FILTER request is failed due to no Hardware resource.
1007 *
1008 * VIRTCHNL_FDIR_FAILURE_RULE_EXIST
1009 * OP_ADD_FDIR_FILTER request is failed due to the rule is already existed.
1010 *
1011 * VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT
1012 * OP_ADD_FDIR_FILTER request is failed due to conflict with existing rule.
1013 *
1014 * VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST
1015 * OP_DEL_FDIR_FILTER request is failed due to this rule doesn't exist.
1016 *
1017 * VIRTCHNL_FDIR_FAILURE_RULE_INVALID
1018 * OP_ADD_FDIR_FILTER request is failed due to parameters validation
1019 * or HW doesn't support.
1020 *
1021 * VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT
1022 * OP_ADD/DEL_FDIR_FILTER request is failed due to timing out
1023 * for programming.
1024 */
1025 enum virtchnl_fdir_prgm_status {
1026 VIRTCHNL_FDIR_SUCCESS = 0,
1027 VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE,
1028 VIRTCHNL_FDIR_FAILURE_RULE_EXIST,
1029 VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT,
1030 VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST,
1031 VIRTCHNL_FDIR_FAILURE_RULE_INVALID,
1032 VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT,
1033 };
1034
1035 /* VIRTCHNL_OP_ADD_FDIR_FILTER
1036 * VF sends this request to PF by filling out vsi_id,
1037 * validate_only and rule_cfg. PF will return flow_id
1038 * if the request is successfully done and return add_status to VF.
1039 */
1040 struct virtchnl_fdir_add {
1041 u16 vsi_id; /* INPUT */
1042 /*
1043 * 1 for validating a fdir rule, 0 for creating a fdir rule.
1044 * Validate and create share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER.
1045 */
1046 u16 validate_only; /* INPUT */
1047 u32 flow_id; /* OUTPUT */
1048 struct virtchnl_fdir_rule rule_cfg; /* INPUT */
1049 enum virtchnl_fdir_prgm_status status; /* OUTPUT */
1050 };
1051
> 1052 VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
1053
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30039 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20200703/c30d98d4/attachment-0001.bin>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF
@ 2020-07-03 9:08 ` kernel test robot
0 siblings, 0 replies; 31+ messages in thread
From: kernel test robot @ 2020-07-03 9:08 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 30092 bytes --]
Hi Qi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on jkirsher-next-queue/dev-queue]
[cannot apply to v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qi-Zhang/Support-Advanced-AVF-features/20200703-070522
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: m68k-randconfig-r026-20200702 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:957:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:957:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:998:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:998:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_rule' is not an integer constant
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1052:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:1052:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_add' is not an integer constant
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1154:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1154:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1204:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1204:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1236:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1236:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1252:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1252:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1282:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1282:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1297:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1297:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1315:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1315:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1330:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1330:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/ethernet/intel/i40e/i40e_main.c:4:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE'
144 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/net/ethernet/intel/i40e/i40e_prototype.h:9,
from drivers/net/ethernet/intel/i40e/i40e.h:40,
from drivers/net/ethernet/intel/i40e/i40e_main.c:11:
include/linux/avf/virtchnl.h: At top level:
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:949:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:949:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_proto_hdrs' is not an integer constant
949 | VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:957:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:957:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_rss_cfg' is not an integer constant
957 | VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);
| ^~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:998:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:998:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_rule' is not an integer constant
998 | VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
| ^~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1052:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/avf/virtchnl.h:1052:33: error: enumerator value for 'virtchnl_static_assert_virtchnl_fdir_add' is not an integer constant
1052 | VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
| ^~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1154:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1154:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_get_capabilities' is not an integer constant
1154 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_get_capabilities);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1204:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1204:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_create_vport' is not an integer constant
1204 | VIRTCHNL_CHECK_STRUCT_LEN(56, virtchnl_create_vport);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1236:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1236:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_txq_info_v2' is not an integer constant
1236 | VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_txq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1252:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1252:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_tx_queues' is not an integer constant
1252 | VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_config_tx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1282:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1282:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_rxq_info_v2' is not an integer constant
1282 | VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_rxq_info_v2);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1297:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1297:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_config_rx_queues' is not an integer constant
1297 | VIRTCHNL_CHECK_STRUCT_LEN(80, virtchnl_config_rx_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1315:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1315:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_add_queues' is not an integer constant
1315 | VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_add_queues);
| ^~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:186:36: warning: division by zero [-Wdiv-by-zero]
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
| ^
include/linux/avf/virtchnl.h:1330:1: note: in expansion of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:1330:31: error: enumerator value for 'virtchnl_static_assert_virtchnl_del_ena_dis_queues' is not an integer constant
1330 | VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/avf/virtchnl.h:186:53: note: in definition of macro 'VIRTCHNL_CHECK_STRUCT_LEN'
186 | { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
..
vim +/virtchnl_static_assert_virtchnl_fdir_rule +998 include/linux/avf/virtchnl.h
997
> 998 VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
999
1000 /* Status returned to VF after VF requests FDIR commands
1001 * VIRTCHNL_FDIR_SUCCESS
1002 * VF FDIR related request is successfully done by PF
1003 * The request can be OP_ADD/DEL.
1004 *
1005 * VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE
1006 * OP_ADD_FDIR_FILTER request is failed due to no Hardware resource.
1007 *
1008 * VIRTCHNL_FDIR_FAILURE_RULE_EXIST
1009 * OP_ADD_FDIR_FILTER request is failed due to the rule is already existed.
1010 *
1011 * VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT
1012 * OP_ADD_FDIR_FILTER request is failed due to conflict with existing rule.
1013 *
1014 * VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST
1015 * OP_DEL_FDIR_FILTER request is failed due to this rule doesn't exist.
1016 *
1017 * VIRTCHNL_FDIR_FAILURE_RULE_INVALID
1018 * OP_ADD_FDIR_FILTER request is failed due to parameters validation
1019 * or HW doesn't support.
1020 *
1021 * VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT
1022 * OP_ADD/DEL_FDIR_FILTER request is failed due to timing out
1023 * for programming.
1024 */
1025 enum virtchnl_fdir_prgm_status {
1026 VIRTCHNL_FDIR_SUCCESS = 0,
1027 VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE,
1028 VIRTCHNL_FDIR_FAILURE_RULE_EXIST,
1029 VIRTCHNL_FDIR_FAILURE_RULE_CONFLICT,
1030 VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST,
1031 VIRTCHNL_FDIR_FAILURE_RULE_INVALID,
1032 VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT,
1033 };
1034
1035 /* VIRTCHNL_OP_ADD_FDIR_FILTER
1036 * VF sends this request to PF by filling out vsi_id,
1037 * validate_only and rule_cfg. PF will return flow_id
1038 * if the request is successfully done and return add_status to VF.
1039 */
1040 struct virtchnl_fdir_add {
1041 u16 vsi_id; /* INPUT */
1042 /*
1043 * 1 for validating a fdir rule, 0 for creating a fdir rule.
1044 * Validate and create share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER.
1045 */
1046 u16 validate_only; /* INPUT */
1047 u32 flow_id; /* OUTPUT */
1048 struct virtchnl_fdir_rule rule_cfg; /* INPUT */
1049 enum virtchnl_fdir_prgm_status status; /* OUTPUT */
1050 };
1051
> 1052 VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_fdir_add);
1053
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30039 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 11/14] ice: Add non-IP Layer2 protocol FDIR filter for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (9 preceding siblings ...)
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 10/14] ice: Support FDIR configure for AVF Qi Zhang
@ 2020-07-02 22:58 ` Qi Zhang
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU " Qi Zhang
` (3 subsequent siblings)
14 siblings, 0 replies; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:58 UTC (permalink / raw)
To: intel-wired-lan
Add new filter type that allow forward non-IP Ethernet packets base on its
ethertype. The filter is only enabled when COMMS DDP package is loaded.
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_fdir.c | 11 +++++++
drivers/net/ethernet/intel/ice/ice_fdir.h | 1 +
drivers/net/ethernet/intel/ice/ice_flow.c | 17 +++++++++-
drivers/net/ethernet/intel/ice/ice_flow.h | 1 +
drivers/net/ethernet/intel/ice/ice_type.h | 1 +
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 38 ++++++++++++++++++++--
6 files changed, 65 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
index d97d9197135d..6055a13488b6 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
@@ -40,6 +40,12 @@ static const u8 ice_fdir_ipv4_pkt[] = {
0x00, 0x00
};
+static const u8 ice_fdir_non_ip_l2_pkt[] = {
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+};
+
static const u8 ice_fdir_tcpv6_pkt[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x86, 0xDD, 0x60, 0x00,
@@ -239,6 +245,11 @@ static const struct ice_fdir_base_pkt ice_fdir_pkt[] = {
sizeof(ice_fdir_ip4_tun_pkt), ice_fdir_ip4_tun_pkt,
},
{
+ ICE_FLTR_PTYPE_NON_IP_L2,
+ sizeof(ice_fdir_non_ip_l2_pkt), ice_fdir_non_ip_l2_pkt,
+ sizeof(ice_fdir_non_ip_l2_pkt), ice_fdir_non_ip_l2_pkt,
+ },
+ {
ICE_FLTR_PTYPE_NONF_IPV6_TCP,
sizeof(ice_fdir_tcpv6_pkt), ice_fdir_tcpv6_pkt,
sizeof(ice_fdir_tcp6_tun_pkt), ice_fdir_tcp6_tun_pkt,
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h b/drivers/net/ethernet/intel/ice/ice_fdir.h
index 6b7d8ccd39b7..a46449f23720 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.h
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
@@ -108,6 +108,7 @@ struct ice_fdir_v6 {
struct ice_fdir_extra {
u8 dst_mac[ETH_ALEN]; /* dest MAC address */
+ __be16 ether_type; /* for NON_IP_L2 */
u32 usr_def[2]; /* user data */
__be16 vlan_type; /* VLAN ethertype */
__be16 vlan_tag; /* VLAN tag info */
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethernet/intel/ice/ice_flow.c
index 1bb7e98d9703..9277b3ae02ee 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.c
+++ b/drivers/net/ethernet/intel/ice/ice_flow.c
@@ -571,6 +571,17 @@ static const u32 ice_ptypes_nat_t_esp[] = {
0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
+static const u32 ice_ptypes_mac_non_ip_ofos[] = {
+ 0x00000846, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00400000, 0x03FFF000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
+};
+
/* Manage parameters and info. used during the creation of a flow profile */
struct ice_flow_prof_params {
enum ice_block blk;
@@ -762,7 +773,11 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
ICE_FLOW_PTYPE_MAX);
}
- if (hdrs & ICE_FLOW_SEG_HDR_PPPOE) {
+ if (hdrs & ICE_FLOW_SEG_HDR_ETH_NON_IP) {
+ src = (const unsigned long *)ice_ptypes_mac_non_ip_ofos;
+ bitmap_and(params->ptypes, params->ptypes, src,
+ ICE_FLOW_PTYPE_MAX);
+ } else if (hdrs & ICE_FLOW_SEG_HDR_PPPOE) {
src = (const unsigned long *)ice_ptypes_pppoe;
bitmap_and(params->ptypes, params->ptypes, src,
ICE_FLOW_PTYPE_MAX);
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 46b9fbb3dbe7..26c42fada9f9 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -138,6 +138,7 @@ enum ice_flow_seg_hdr {
ICE_FLOW_SEG_HDR_ESP = 0x00100000,
ICE_FLOW_SEG_HDR_AH = 0x00200000,
ICE_FLOW_SEG_HDR_NAT_T_ESP = 0x00400000,
+ ICE_FLOW_SEG_HDR_ETH_NON_IP = 0x00800000,
/* The following is an additive bit for ICE_FLOW_SEG_HDR_IPV4 and
* ICE_FLOW_SEG_HDR_IPV6 which include the IPV4 other PTYPEs
*/
diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index c2eff68d5469..f58824834342 100644
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -170,6 +170,7 @@ enum ice_fltr_ptype {
ICE_FLTR_PTYPE_NONF_IPV4_TCP,
ICE_FLTR_PTYPE_NONF_IPV4_SCTP,
ICE_FLTR_PTYPE_NONF_IPV4_OTHER,
+ ICE_FLTR_PTYPE_NON_IP_L2,
ICE_FLTR_PTYPE_FRAG_IPV4,
ICE_FLTR_PTYPE_NONF_IPV6_UDP,
ICE_FLTR_PTYPE_NONF_IPV6_TCP,
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
index 53194e26a3cf..62937b86a212 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
@@ -27,6 +27,11 @@ struct virtchnl_fdir_fltr_conf {
struct ice_fdir_fltr input;
};
+static enum virtchnl_proto_hdr_type vc_pattern_ether[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
static enum virtchnl_proto_hdr_type vc_pattern_ipv4[] = {
VIRTCHNL_PROTO_HDR_ETH,
VIRTCHNL_PROTO_HDR_IPV4,
@@ -87,7 +92,7 @@ struct virtchnl_fdir_pattern_match_item {
u64 *meta;
};
-static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern[] = {
+static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern_os[] = {
{vc_pattern_ipv4, 0, NULL},
{vc_pattern_ipv4_tcp, 0, NULL},
{vc_pattern_ipv4_udp, 0, NULL},
@@ -98,6 +103,18 @@ static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern[] = {
{vc_pattern_ipv6_sctp, 0, NULL},
};
+static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern_comms[] = {
+ {vc_pattern_ipv4, 0, NULL},
+ {vc_pattern_ipv4_tcp, 0, NULL},
+ {vc_pattern_ipv4_udp, 0, NULL},
+ {vc_pattern_ipv4_sctp, 0, NULL},
+ {vc_pattern_ipv6, 0, NULL},
+ {vc_pattern_ipv6_tcp, 0, NULL},
+ {vc_pattern_ipv6_udp, 0, NULL},
+ {vc_pattern_ipv6_sctp, 0, NULL},
+ {vc_pattern_ether, 0, NULL},
+};
+
struct virtchnl_fdir_inset_map {
enum virtchnl_proto_hdr_field field;
enum ice_flow_field fld;
@@ -372,6 +389,9 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
struct device *dev = ice_pf_to_dev(vf->pf);
switch (flow) {
+ case ICE_FLTR_PTYPE_NON_IP_L2:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ETH_NON_IP);
+ break;
case ICE_FLTR_PTYPE_NONF_IPV4_OTHER:
ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 |
ICE_FLOW_SEG_HDR_IPV_OTHER);
@@ -712,8 +732,14 @@ ice_vc_fdir_get_pattern(struct ice_vf *vf, int *len)
struct ice_hw *hw;
hw = &pf->hw;
- item = vc_fdir_pattern;
- *len = ARRAY_SIZE(vc_fdir_pattern);
+ if (!strncmp(hw->active_pkg_name, "ICE COMMS Package",
+ sizeof(hw->active_pkg_name))) {
+ item = vc_fdir_pattern_comms;
+ *len = ARRAY_SIZE(vc_fdir_pattern_comms);
+ } else {
+ item = vc_fdir_pattern_os;
+ *len = ARRAY_SIZE(vc_fdir_pattern_os);
+ }
return item;
}
@@ -775,10 +801,16 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
struct ipv6hdr *ip6h;
struct udphdr *udph;
struct tcphdr *tcph;
+ struct ethhdr *eth;
struct iphdr *iph;
switch (hdr->type) {
case VIRTCHNL_PROTO_HDR_ETH:
+ eth = (struct ethhdr *)hdr->buffer;
+ input->flow_type = ICE_FLTR_PTYPE_NON_IP_L2;
+
+ if (hdr->field_selector)
+ input->ext_data.ether_type = eth->h_proto;
break;
case VIRTCHNL_PROTO_HDR_IPV4:
iph = (struct iphdr *)hdr->buffer;
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU FDIR filter for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (10 preceding siblings ...)
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 11/14] ice: Add non-IP Layer2 protocol FDIR filter " Qi Zhang
@ 2020-07-02 22:58 ` Qi Zhang
2020-07-03 5:35 ` Kirsher, Jeffrey T
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 13/14] ice: Add more FDIR filter type " Qi Zhang
` (2 subsequent siblings)
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:58 UTC (permalink / raw)
To: intel-wired-lan
Add new FDIR filter type to forward GTPU packets by matching TEID or QFI.
The filter is only enabled when COMMS DDP package is downloaded.
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_fdir.h | 21 ++++++
drivers/net/ethernet/intel/ice/ice_type.h | 4 ++
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 78 ++++++++++++++++++++++
3 files changed, 103 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h b/drivers/net/ethernet/intel/ice/ice_fdir.h
index a46449f23720..9943c2b0f474 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.h
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
@@ -106,6 +106,24 @@ struct ice_fdir_v6 {
u8 proto;
};
+struct ice_fdir_udp_gtp {
+ u8 flags;
+ u8 msg_type;
+ __be16 rsrvd_len;
+ __be32 teid;
+ __be16 rsrvd_seq_nbr;
+ u8 rsrvd_n_pdu_nbr;
+ u8 rsrvd_next_ext_type;
+ u8 rsvrd_ext_len;
+ u8 pdu_type:4,
+ spare:4;
+ u8 ppp:1,
+ rqi:1,
+ qfi:6;
+ u32 rsvrd;
+ u8 next_ext;
+};
+
struct ice_fdir_extra {
u8 dst_mac[ETH_ALEN]; /* dest MAC address */
__be16 ether_type; /* for NON_IP_L2 */
@@ -123,6 +141,9 @@ struct ice_fdir_fltr {
struct ice_fdir_v6 v6;
} ip, mask;
+ struct ice_fdir_udp_gtp gtpu_data;
+ struct ice_fdir_udp_gtp gtpu_mask;
+
struct ice_fdir_extra ext_data;
struct ice_fdir_extra ext_mask;
diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index f58824834342..0df159a1619a 100644
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -170,6 +170,10 @@ enum ice_fltr_ptype {
ICE_FLTR_PTYPE_NONF_IPV4_TCP,
ICE_FLTR_PTYPE_NONF_IPV4_SCTP,
ICE_FLTR_PTYPE_NONF_IPV4_OTHER,
+ ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP,
+ ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP,
+ ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP,
+ ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER,
ICE_FLTR_PTYPE_NON_IP_L2,
ICE_FLTR_PTYPE_FRAG_IPV4,
ICE_FLTR_PTYPE_NONF_IPV6_UDP,
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
index 62937b86a212..325ba70b0635 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
@@ -23,8 +23,19 @@
(u64)(((((flow) + (tun_offs)) & ICE_FLOW_PROF_TYPE_M)) | \
(((u64)(vsi) << ICE_FLOW_PROF_VSI_S) & ICE_FLOW_PROF_VSI_M))
+#define GTPU_TEID_OFFSET 4
+#define GTPU_EH_QFI_OFFSET 1
+#define GTPU_EH_QFI_MASK 0x3F
+
+enum ice_fdir_tunnel_type {
+ ICE_FDIR_TUNNEL_TYPE_NONE = 0,
+ ICE_FDIR_TUNNEL_TYPE_GTPU,
+ ICE_FDIR_TUNNEL_TYPE_GTPU_EH,
+};
+
struct virtchnl_fdir_fltr_conf {
struct ice_fdir_fltr input;
+ enum ice_fdir_tunnel_type ttype;
};
static enum virtchnl_proto_hdr_type vc_pattern_ether[] = {
@@ -86,6 +97,23 @@ static enum virtchnl_proto_hdr_type vc_pattern_ipv6_sctp[] = {
VIRTCHNL_PROTO_HDR_NONE,
};
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_GTPU_IP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu_eh[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_GTPU_IP,
+ VIRTCHNL_PROTO_HDR_GTPU_EH,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
struct virtchnl_fdir_pattern_match_item {
enum virtchnl_proto_hdr_type *list;
u64 input_set;
@@ -113,6 +141,8 @@ static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern_comms[] = {
{vc_pattern_ipv6_udp, 0, NULL},
{vc_pattern_ipv6_sctp, 0, NULL},
{vc_pattern_ether, 0, NULL},
+ {vc_pattern_ipv4_gtpu, 0, NULL},
+ {vc_pattern_ipv4_gtpu_eh, 0, NULL},
};
struct virtchnl_fdir_inset_map {
@@ -137,6 +167,8 @@ static const struct virtchnl_fdir_inset_map fdir_inset_map[] = {
{VIRTCHNL_PROTO_HDR_TCP_DST_PORT, ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
{VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT, ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
{VIRTCHNL_PROTO_HDR_SCTP_DST_PORT, ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
+ {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID, ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},
+ {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI, ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},
};
/**
@@ -386,6 +418,7 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
struct ice_flow_seg_info *seg)
{
enum ice_fltr_ptype flow = conf->input.flow_type;
+ enum ice_fdir_tunnel_type ttype = conf->ttype;
struct device *dev = ice_pf_to_dev(vf->pf);
switch (flow) {
@@ -406,6 +439,25 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
ICE_FLOW_SEG_HDR_IPV4 |
ICE_FLOW_SEG_HDR_IPV_OTHER);
break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP:
+ case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP:
+ case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP:
+ case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER:
+ if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU) {
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_IP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ } else if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU_EH) {
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
+ ICE_FLOW_SEG_HDR_GTPU_IP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ } else {
+ dev_dbg(dev, "Invalid tunnel type 0x%x for VF %d\n",
+ flow, vf->vf_id);
+ return -EINVAL;
+ }
+ break;
case ICE_FLTR_PTYPE_NONF_IPV4_SCTP:
ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
ICE_FLOW_SEG_HDR_IPV4 |
@@ -803,6 +855,7 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
struct tcphdr *tcph;
struct ethhdr *eth;
struct iphdr *iph;
+ u8 *rawh;
switch (hdr->type) {
case VIRTCHNL_PROTO_HDR_ETH:
@@ -895,6 +948,25 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
}
}
break;
+ case VIRTCHNL_PROTO_HDR_GTPU_IP:
+ rawh = (u8 *)hdr->buffer;
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER;
+
+ if (hdr->field_selector)
+ input->gtpu_data.teid =
+ *(__be32 *)(&rawh[GTPU_TEID_OFFSET]);
+ conf->ttype = ICE_FDIR_TUNNEL_TYPE_GTPU;
+ break;
+ case VIRTCHNL_PROTO_HDR_GTPU_EH:
+ rawh = (u8 *)hdr->buffer;
+
+ if (hdr->field_selector)
+ input->gtpu_data.qfi =
+ rawh[GTPU_EH_QFI_OFFSET] &
+ GTPU_EH_QFI_MASK;
+ conf->ttype = ICE_FDIR_TUNNEL_TYPE_GTPU_EH;
+ break;
default:
dev_dbg(dev, "Invalid header type 0x:%x for VF %d\n",
hdr->type, vf->vf_id);
@@ -1024,12 +1096,18 @@ ice_vc_fdir_comp_rules(struct virtchnl_fdir_fltr_conf *conf_a,
struct ice_fdir_fltr *a = &conf_a->input;
struct ice_fdir_fltr *b = &conf_b->input;
+ if (conf_a->ttype != conf_b->ttype)
+ return false;
if (a->flow_type != b->flow_type)
return false;
if (memcmp(&a->ip, &b->ip, sizeof(a->ip)))
return false;
if (memcmp(&a->mask, &b->mask, sizeof(a->mask)))
return false;
+ if (memcmp(&a->gtpu_data, &b->gtpu_data, sizeof(a->gtpu_data)))
+ return false;
+ if (memcmp(&a->gtpu_mask, &b->gtpu_mask, sizeof(a->gtpu_mask)))
+ return false;
if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
return false;
if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU FDIR filter for AVF
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU " Qi Zhang
@ 2020-07-03 5:35 ` Kirsher, Jeffrey T
2020-07-04 1:48 ` Zhang, Qi Z
0 siblings, 1 reply; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:35 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU FDIR filter for
> AVF
>
> Add new FDIR filter type to forward GTPU packets by matching TEID or QFI.
> The filter is only enabled when COMMS DDP package is downloaded.
>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_fdir.h | 21 ++++++
> drivers/net/ethernet/intel/ice/ice_type.h | 4 ++
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 78
> ++++++++++++++++++++++
> 3 files changed, 103 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h
> b/drivers/net/ethernet/intel/ice/ice_fdir.h
> index a46449f23720..9943c2b0f474 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.h
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
> @@ -106,6 +106,24 @@ struct ice_fdir_v6 {
> u8 proto;
> };
>
> +struct ice_fdir_udp_gtp {
> + u8 flags;
> + u8 msg_type;
> + __be16 rsrvd_len;
> + __be32 teid;
> + __be16 rsrvd_seq_nbr;
> + u8 rsrvd_n_pdu_nbr;
> + u8 rsrvd_next_ext_type;
> + u8 rsvrd_ext_len;
> + u8 pdu_type:4,
> + spare:4;
> + u8 ppp:1,
> + rqi:1,
> + qfi:6;
> + u32 rsvrd;
> + u8 next_ext;
> +};
> +
> struct ice_fdir_extra {
> u8 dst_mac[ETH_ALEN]; /* dest MAC address */
> __be16 ether_type; /* for NON_IP_L2 */
> @@ -123,6 +141,9 @@ struct ice_fdir_fltr {
> struct ice_fdir_v6 v6;
> } ip, mask;
>
> + struct ice_fdir_udp_gtp gtpu_data;
> + struct ice_fdir_udp_gtp gtpu_mask;
> +
> struct ice_fdir_extra ext_data;
> struct ice_fdir_extra ext_mask;
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_type.h
> b/drivers/net/ethernet/intel/ice/ice_type.h
> index f58824834342..0df159a1619a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_type.h
> @@ -170,6 +170,10 @@ enum ice_fltr_ptype {
> ICE_FLTR_PTYPE_NONF_IPV4_TCP,
> ICE_FLTR_PTYPE_NONF_IPV4_SCTP,
> ICE_FLTR_PTYPE_NONF_IPV4_OTHER,
> + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP,
> + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP,
> + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP,
> + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER,
> ICE_FLTR_PTYPE_NON_IP_L2,
> ICE_FLTR_PTYPE_FRAG_IPV4,
> ICE_FLTR_PTYPE_NONF_IPV6_UDP,
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> index 62937b86a212..325ba70b0635 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> @@ -23,8 +23,19 @@
> (u64)(((((flow) + (tun_offs)) & ICE_FLOW_PROF_TYPE_M)) | \
> (((u64)(vsi) << ICE_FLOW_PROF_VSI_S) &
> ICE_FLOW_PROF_VSI_M))
>
> +#define GTPU_TEID_OFFSET 4
> +#define GTPU_EH_QFI_OFFSET 1
> +#define GTPU_EH_QFI_MASK 0x3F
> +
> +enum ice_fdir_tunnel_type {
> + ICE_FDIR_TUNNEL_TYPE_NONE = 0,
> + ICE_FDIR_TUNNEL_TYPE_GTPU,
> + ICE_FDIR_TUNNEL_TYPE_GTPU_EH,
> +};
> +
> struct virtchnl_fdir_fltr_conf {
> struct ice_fdir_fltr input;
> + enum ice_fdir_tunnel_type ttype;
> };
>
> static enum virtchnl_proto_hdr_type vc_pattern_ether[] = { @@ -86,6 +97,23
> @@ static enum virtchnl_proto_hdr_type vc_pattern_ipv6_sctp[] = {
> VIRTCHNL_PROTO_HDR_NONE,
> };
>
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_GTPU_IP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu_eh[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_GTPU_IP,
> + VIRTCHNL_PROTO_HDR_GTPU_EH,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> struct virtchnl_fdir_pattern_match_item {
> enum virtchnl_proto_hdr_type *list;
> u64 input_set;
> @@ -113,6 +141,8 @@ static const struct virtchnl_fdir_pattern_match_item
> vc_fdir_pattern_comms[] = {
> {vc_pattern_ipv6_udp, 0, NULL},
> {vc_pattern_ipv6_sctp, 0, NULL},
> {vc_pattern_ether, 0, NULL},
> + {vc_pattern_ipv4_gtpu, 0, NULL},
> + {vc_pattern_ipv4_gtpu_eh, 0, NULL},
> };
>
> struct virtchnl_fdir_inset_map {
> @@ -137,6 +167,8 @@ static const struct virtchnl_fdir_inset_map
> fdir_inset_map[] = {
> {VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
> {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
> {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
> + {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID,
> ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},
> + {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI,
> ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},
> };
>
> /**
> @@ -386,6 +418,7 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> struct ice_flow_seg_info *seg)
> {
> enum ice_fltr_ptype flow = conf->input.flow_type;
> + enum ice_fdir_tunnel_type ttype = conf->ttype;
> struct device *dev = ice_pf_to_dev(vf->pf);
>
> switch (flow) {
> @@ -406,6 +439,25 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> ICE_FLOW_SEG_HDR_IPV4 |
> ICE_FLOW_SEG_HDR_IPV_OTHER);
> break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP:
> + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP:
> + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP:
> + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER:
> + if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU) {
> + ICE_FLOW_SET_HDRS(seg,
> ICE_FLOW_SEG_HDR_GTPU_IP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + } else if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU_EH) {
> + ICE_FLOW_SET_HDRS(seg,
> ICE_FLOW_SEG_HDR_GTPU_EH |
> + ICE_FLOW_SEG_HDR_GTPU_IP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + } else {
> + dev_dbg(dev, "Invalid tunnel type 0x%x for VF %d\n",
> + flow, vf->vf_id);
> + return -EINVAL;
> + }
> + break;
> case ICE_FLTR_PTYPE_NONF_IPV4_SCTP:
> ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
> ICE_FLOW_SEG_HDR_IPV4 |
> @@ -803,6 +855,7 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct
> virtchnl_fdir_add *fltr,
> struct tcphdr *tcph;
> struct ethhdr *eth;
> struct iphdr *iph;
> + u8 *rawh;
>
> switch (hdr->type) {
> case VIRTCHNL_PROTO_HDR_ETH:
> @@ -895,6 +948,25 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct
> virtchnl_fdir_add *fltr,
> }
> }
> break;
> + case VIRTCHNL_PROTO_HDR_GTPU_IP:
> + rawh = (u8 *)hdr->buffer;
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER;
No need to wrap, also why does this define have IPV4 twice in the name? That is redundant. These define names are getting WAY out of control and can the length of the defines can be reduced in length.
> +
> + if (hdr->field_selector)
> + input->gtpu_data.teid =
> + *(__be32 *)(&rawh[GTPU_TEID_OFFSET]);
No need to wrap
> + conf->ttype = ICE_FDIR_TUNNEL_TYPE_GTPU;
> + break;
> + case VIRTCHNL_PROTO_HDR_GTPU_EH:
> + rawh = (u8 *)hdr->buffer;
> +
> + if (hdr->field_selector)
> + input->gtpu_data.qfi =
> + rawh[GTPU_EH_QFI_OFFSET] &
> + GTPU_EH_QFI_MASK;
This wrapping could be improved, i.e. 2 lines, maybe less and there is alignment issues.
> + conf->ttype = ICE_FDIR_TUNNEL_TYPE_GTPU_EH;
> + break;
> default:
> dev_dbg(dev, "Invalid header type 0x:%x for VF %d\n",
> hdr->type, vf->vf_id);
> @@ -1024,12 +1096,18 @@ ice_vc_fdir_comp_rules(struct
> virtchnl_fdir_fltr_conf *conf_a,
> struct ice_fdir_fltr *a = &conf_a->input;
> struct ice_fdir_fltr *b = &conf_b->input;
>
> + if (conf_a->ttype != conf_b->ttype)
> + return false;
> if (a->flow_type != b->flow_type)
> return false;
> if (memcmp(&a->ip, &b->ip, sizeof(a->ip)))
> return false;
> if (memcmp(&a->mask, &b->mask, sizeof(a->mask)))
> return false;
> + if (memcmp(&a->gtpu_data, &b->gtpu_data, sizeof(a->gtpu_data)))
> + return false;
> + if (memcmp(&a->gtpu_mask, &b->gtpu_mask, sizeof(a->gtpu_mask)))
> + return false;
> if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
> return false;
> if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU FDIR filter for AVF
2020-07-03 5:35 ` Kirsher, Jeffrey T
@ 2020-07-04 1:48 ` Zhang, Qi Z
0 siblings, 0 replies; 31+ messages in thread
From: Zhang, Qi Z @ 2020-07-04 1:48 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Sent: Friday, July 3, 2020 1:36 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU FDIR filter
> for AVF
>
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> > Of Qi Zhang
> > Sent: Thursday, July 2, 2020 15:58
> > To: intel-wired-lan at lists.osuosl.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Subject: [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU FDIR
> > filter for AVF
> >
> > Add new FDIR filter type to forward GTPU packets by matching TEID or QFI.
> > The filter is only enabled when COMMS DDP package is downloaded.
> >
> > Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_fdir.h | 21 ++++++
> > drivers/net/ethernet/intel/ice/ice_type.h | 4 ++
> > drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 78
> > ++++++++++++++++++++++
> > 3 files changed, 103 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h
> > b/drivers/net/ethernet/intel/ice/ice_fdir.h
> > index a46449f23720..9943c2b0f474 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_fdir.h
> > +++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
> > @@ -106,6 +106,24 @@ struct ice_fdir_v6 {
> > u8 proto;
> > };
> >
> > +struct ice_fdir_udp_gtp {
> > + u8 flags;
> > + u8 msg_type;
> > + __be16 rsrvd_len;
> > + __be32 teid;
> > + __be16 rsrvd_seq_nbr;
> > + u8 rsrvd_n_pdu_nbr;
> > + u8 rsrvd_next_ext_type;
> > + u8 rsvrd_ext_len;
> > + u8 pdu_type:4,
> > + spare:4;
> > + u8 ppp:1,
> > + rqi:1,
> > + qfi:6;
> > + u32 rsvrd;
> > + u8 next_ext;
> > +};
> > +
> > struct ice_fdir_extra {
> > u8 dst_mac[ETH_ALEN]; /* dest MAC address */
> > __be16 ether_type; /* for NON_IP_L2 */
> > @@ -123,6 +141,9 @@ struct ice_fdir_fltr {
> > struct ice_fdir_v6 v6;
> > } ip, mask;
> >
> > + struct ice_fdir_udp_gtp gtpu_data;
> > + struct ice_fdir_udp_gtp gtpu_mask;
> > +
> > struct ice_fdir_extra ext_data;
> > struct ice_fdir_extra ext_mask;
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_type.h
> > b/drivers/net/ethernet/intel/ice/ice_type.h
> > index f58824834342..0df159a1619a 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_type.h
> > +++ b/drivers/net/ethernet/intel/ice/ice_type.h
> > @@ -170,6 +170,10 @@ enum ice_fltr_ptype {
> > ICE_FLTR_PTYPE_NONF_IPV4_TCP,
> > ICE_FLTR_PTYPE_NONF_IPV4_SCTP,
> > ICE_FLTR_PTYPE_NONF_IPV4_OTHER,
> > + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP,
> > + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP,
> > + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP,
> > + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER,
> > ICE_FLTR_PTYPE_NON_IP_L2,
> > ICE_FLTR_PTYPE_FRAG_IPV4,
> > ICE_FLTR_PTYPE_NONF_IPV6_UDP,
> > diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> > b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> > index 62937b86a212..325ba70b0635 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> > @@ -23,8 +23,19 @@
> > (u64)(((((flow) + (tun_offs)) & ICE_FLOW_PROF_TYPE_M)) | \
> > (((u64)(vsi) << ICE_FLOW_PROF_VSI_S) &
> > ICE_FLOW_PROF_VSI_M))
> >
> > +#define GTPU_TEID_OFFSET 4
> > +#define GTPU_EH_QFI_OFFSET 1
> > +#define GTPU_EH_QFI_MASK 0x3F
> > +
> > +enum ice_fdir_tunnel_type {
> > + ICE_FDIR_TUNNEL_TYPE_NONE = 0,
> > + ICE_FDIR_TUNNEL_TYPE_GTPU,
> > + ICE_FDIR_TUNNEL_TYPE_GTPU_EH,
> > +};
> > +
> > struct virtchnl_fdir_fltr_conf {
> > struct ice_fdir_fltr input;
> > + enum ice_fdir_tunnel_type ttype;
> > };
> >
> > static enum virtchnl_proto_hdr_type vc_pattern_ether[] = { @@ -86,6
> > +97,23 @@ static enum virtchnl_proto_hdr_type vc_pattern_ipv6_sctp[]
> = {
> > VIRTCHNL_PROTO_HDR_NONE,
> > };
> >
> > +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu[] = {
> > + VIRTCHNL_PROTO_HDR_ETH,
> > + VIRTCHNL_PROTO_HDR_IPV4,
> > + VIRTCHNL_PROTO_HDR_UDP,
> > + VIRTCHNL_PROTO_HDR_GTPU_IP,
> > + VIRTCHNL_PROTO_HDR_NONE,
> > +};
> > +
> > +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu_eh[] = {
> > + VIRTCHNL_PROTO_HDR_ETH,
> > + VIRTCHNL_PROTO_HDR_IPV4,
> > + VIRTCHNL_PROTO_HDR_UDP,
> > + VIRTCHNL_PROTO_HDR_GTPU_IP,
> > + VIRTCHNL_PROTO_HDR_GTPU_EH,
> > + VIRTCHNL_PROTO_HDR_NONE,
> > +};
> > +
> > struct virtchnl_fdir_pattern_match_item {
> > enum virtchnl_proto_hdr_type *list;
> > u64 input_set;
> > @@ -113,6 +141,8 @@ static const struct
> > virtchnl_fdir_pattern_match_item vc_fdir_pattern_comms[] = {
> > {vc_pattern_ipv6_udp, 0, NULL},
> > {vc_pattern_ipv6_sctp, 0, NULL},
> > {vc_pattern_ether, 0, NULL},
> > + {vc_pattern_ipv4_gtpu, 0, NULL},
> > + {vc_pattern_ipv4_gtpu_eh, 0, NULL},
> > };
> >
> > struct virtchnl_fdir_inset_map {
> > @@ -137,6 +167,8 @@ static const struct virtchnl_fdir_inset_map
> > fdir_inset_map[] = {
> > {VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> > ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
> > {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT,
> > ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
> > {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> > ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
> > + {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID,
> > ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},
> > + {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI,
> > ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},
> > };
> >
> > /**
> > @@ -386,6 +418,7 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> > struct ice_flow_seg_info *seg)
> > {
> > enum ice_fltr_ptype flow = conf->input.flow_type;
> > + enum ice_fdir_tunnel_type ttype = conf->ttype;
> > struct device *dev = ice_pf_to_dev(vf->pf);
> >
> > switch (flow) {
> > @@ -406,6 +439,25 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> > ICE_FLOW_SEG_HDR_IPV4 |
> > ICE_FLOW_SEG_HDR_IPV_OTHER);
> > break;
> > + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP:
> > + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP:
> > + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP:
> > + case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER:
> > + if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU) {
> > + ICE_FLOW_SET_HDRS(seg,
> > ICE_FLOW_SEG_HDR_GTPU_IP |
> > + ICE_FLOW_SEG_HDR_IPV4 |
> > + ICE_FLOW_SEG_HDR_IPV_OTHER);
> > + } else if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU_EH) {
> > + ICE_FLOW_SET_HDRS(seg,
> > ICE_FLOW_SEG_HDR_GTPU_EH |
> > + ICE_FLOW_SEG_HDR_GTPU_IP |
> > + ICE_FLOW_SEG_HDR_IPV4 |
> > + ICE_FLOW_SEG_HDR_IPV_OTHER);
> > + } else {
> > + dev_dbg(dev, "Invalid tunnel type 0x%x for VF %d\n",
> > + flow, vf->vf_id);
> > + return -EINVAL;
> > + }
> > + break;
> > case ICE_FLTR_PTYPE_NONF_IPV4_SCTP:
> > ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
> > ICE_FLOW_SEG_HDR_IPV4 |
> > @@ -803,6 +855,7 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf,
> > struct virtchnl_fdir_add *fltr,
> > struct tcphdr *tcph;
> > struct ethhdr *eth;
> > struct iphdr *iph;
> > + u8 *rawh;
> >
> > switch (hdr->type) {
> > case VIRTCHNL_PROTO_HDR_ETH:
> > @@ -895,6 +948,25 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf,
> > struct virtchnl_fdir_add *fltr,
> > }
> > }
> > break;
> > + case VIRTCHNL_PROTO_HDR_GTPU_IP:
> > + rawh = (u8 *)hdr->buffer;
> > + input->flow_type =
> > + ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER;
>
> No need to wrap, also why does this define have IPV4 twice in the name?
> That is redundant. These define names are getting WAY out of control and
> can the length of the defines can be reduced in length.
gtpu has inner and outer IP header, currently we only support IPV4, but IPv6 could be added in future
So there are 4 combination
IPV4_GTPU_IPV4
IPV4_GTPU_IPV6
IPV6_GTPU_IPV4
IPV6_GTPU_IPV6
Regards
Qi
>
> > +
> > + if (hdr->field_selector)
> > + input->gtpu_data.teid =
> > + *(__be32 *)(&rawh[GTPU_TEID_OFFSET]);
>
> No need to wrap
>
> > + conf->ttype = ICE_FDIR_TUNNEL_TYPE_GTPU;
> > + break;
> > + case VIRTCHNL_PROTO_HDR_GTPU_EH:
> > + rawh = (u8 *)hdr->buffer;
> > +
> > + if (hdr->field_selector)
> > + input->gtpu_data.qfi =
> > + rawh[GTPU_EH_QFI_OFFSET] &
> > + GTPU_EH_QFI_MASK;
>
> This wrapping could be improved, i.e. 2 lines, maybe less and there is
> alignment issues.
>
> > + conf->ttype = ICE_FDIR_TUNNEL_TYPE_GTPU_EH;
> > + break;
> > default:
> > dev_dbg(dev, "Invalid header type 0x:%x for VF %d\n",
> > hdr->type, vf->vf_id);
> > @@ -1024,12 +1096,18 @@ ice_vc_fdir_comp_rules(struct
> > virtchnl_fdir_fltr_conf *conf_a,
> > struct ice_fdir_fltr *a = &conf_a->input;
> > struct ice_fdir_fltr *b = &conf_b->input;
> >
> > + if (conf_a->ttype != conf_b->ttype)
> > + return false;
> > if (a->flow_type != b->flow_type)
> > return false;
> > if (memcmp(&a->ip, &b->ip, sizeof(a->ip)))
> > return false;
> > if (memcmp(&a->mask, &b->mask, sizeof(a->mask)))
> > return false;
> > + if (memcmp(&a->gtpu_data, &b->gtpu_data, sizeof(a->gtpu_data)))
> > + return false;
> > + if (memcmp(&a->gtpu_mask, &b->gtpu_mask, sizeof(a->gtpu_mask)))
> > + return false;
> > if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
> > return false;
> > if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
> > --
> > 2.13.6
> >
> > _______________________________________________
> > Intel-wired-lan mailing list
> > Intel-wired-lan at osuosl.org
> > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 13/14] ice: Add more FDIR filter type for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (11 preceding siblings ...)
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 12/14] ice: Add GTPU " Qi Zhang
@ 2020-07-02 22:58 ` Qi Zhang
2020-07-03 5:43 ` Kirsher, Jeffrey T
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 14/14] ice: Check FDIR program status " Qi Zhang
2020-07-03 5:55 ` [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Kirsher, Jeffrey T
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:58 UTC (permalink / raw)
To: intel-wired-lan
FDIR for AVF can forward
- L2TPV3 packets by matching session id.
- IPSEC ESP packets by matching security parameter index.
- IPSEC AH packets by matching security parameter index.
- NAT_T ESP packets by matching security parameter index.
- Any PFCP session packets(s field is 1).
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice_fdir.h | 7 +
drivers/net/ethernet/intel/ice/ice_type.h | 13 +
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 313 +++++++++++++++++++--
3 files changed, 315 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h b/drivers/net/ethernet/intel/ice/ice_fdir.h
index 9943c2b0f474..320f19cd748f 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.h
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
@@ -124,6 +124,10 @@ struct ice_fdir_udp_gtp {
u8 next_ext;
};
+struct ice_fdir_l2tpv3 {
+ __be32 session_id;
+};
+
struct ice_fdir_extra {
u8 dst_mac[ETH_ALEN]; /* dest MAC address */
__be16 ether_type; /* for NON_IP_L2 */
@@ -144,6 +148,9 @@ struct ice_fdir_fltr {
struct ice_fdir_udp_gtp gtpu_data;
struct ice_fdir_udp_gtp gtpu_mask;
+ struct ice_fdir_l2tpv3 l2tpv3_data;
+ struct ice_fdir_l2tpv3 l2tpv3_mask;
+
struct ice_fdir_extra ext_data;
struct ice_fdir_extra ext_mask;
diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index 0df159a1619a..1aaa06c01a55 100644
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -174,6 +174,19 @@ enum ice_fltr_ptype {
ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP,
ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP,
ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER,
+ ICE_FLTR_PTYPE_NONF_IPV6_GTPU_IPV6_OTHER,
+ ICE_FLTR_PTYPE_NONF_IPV4_L2TPV3,
+ ICE_FLTR_PTYPE_NONF_IPV6_L2TPV3,
+ ICE_FLTR_PTYPE_NONF_IPV4_ESP,
+ ICE_FLTR_PTYPE_NONF_IPV6_ESP,
+ ICE_FLTR_PTYPE_NONF_IPV4_AH,
+ ICE_FLTR_PTYPE_NONF_IPV6_AH,
+ ICE_FLTR_PTYPE_NONF_IPV4_NAT_T_ESP,
+ ICE_FLTR_PTYPE_NONF_IPV6_NAT_T_ESP,
+ ICE_FLTR_PTYPE_NONF_IPV4_PFCP_NODE,
+ ICE_FLTR_PTYPE_NONF_IPV4_PFCP_SESSION,
+ ICE_FLTR_PTYPE_NONF_IPV6_PFCP_NODE,
+ ICE_FLTR_PTYPE_NONF_IPV6_PFCP_SESSION,
ICE_FLTR_PTYPE_NON_IP_L2,
ICE_FLTR_PTYPE_FRAG_IPV4,
ICE_FLTR_PTYPE_NONF_IPV6_UDP,
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
index 325ba70b0635..f66b04a0a62f 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
@@ -26,6 +26,14 @@
#define GTPU_TEID_OFFSET 4
#define GTPU_EH_QFI_OFFSET 1
#define GTPU_EH_QFI_MASK 0x3F
+#define PFCP_S_OFFSET 0
+#define PFCP_S_MASK 0x1
+#define PFCP_PORT_NR 8805
+
+#define FDIR_INSET_FLAG_ESP_S 0
+#define FDIR_INSET_FLAG_ESP_M BIT_ULL(FDIR_INSET_FLAG_ESP_S)
+#define FDIR_INSET_FLAG_ESP_UDP BIT_ULL(FDIR_INSET_FLAG_ESP_S)
+#define FDIR_INSET_FLAG_ESP_IPSEC (0ULL << FDIR_INSET_FLAG_ESP_S)
enum ice_fdir_tunnel_type {
ICE_FDIR_TUNNEL_TYPE_NONE = 0,
@@ -36,6 +44,7 @@ enum ice_fdir_tunnel_type {
struct virtchnl_fdir_fltr_conf {
struct ice_fdir_fltr input;
enum ice_fdir_tunnel_type ttype;
+ u64 inset_flag;
};
static enum virtchnl_proto_hdr_type vc_pattern_ether[] = {
@@ -114,6 +123,80 @@ static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu_eh[] = {
VIRTCHNL_PROTO_HDR_NONE,
};
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_l2tpv3[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_L2TPV3,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_l2tpv3[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_L2TPV3,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_esp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_ESP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_esp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_ESP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_ah[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_AH,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_ah[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_AH,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_nat_t_esp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_ESP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_nat_t_esp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_ESP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv4_pfcp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV4,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_PFCP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
+static enum virtchnl_proto_hdr_type vc_pattern_ipv6_pfcp[] = {
+ VIRTCHNL_PROTO_HDR_ETH,
+ VIRTCHNL_PROTO_HDR_IPV6,
+ VIRTCHNL_PROTO_HDR_UDP,
+ VIRTCHNL_PROTO_HDR_PFCP,
+ VIRTCHNL_PROTO_HDR_NONE,
+};
+
struct virtchnl_fdir_pattern_match_item {
enum virtchnl_proto_hdr_type *list;
u64 input_set;
@@ -143,32 +226,74 @@ static const struct virtchnl_fdir_pattern_match_item vc_fdir_pattern_comms[] = {
{vc_pattern_ether, 0, NULL},
{vc_pattern_ipv4_gtpu, 0, NULL},
{vc_pattern_ipv4_gtpu_eh, 0, NULL},
+ {vc_pattern_ipv4_l2tpv3, 0, NULL},
+ {vc_pattern_ipv6_l2tpv3, 0, NULL},
+ {vc_pattern_ipv4_esp, 0, NULL},
+ {vc_pattern_ipv6_esp, 0, NULL},
+ {vc_pattern_ipv4_ah, 0, NULL},
+ {vc_pattern_ipv6_ah, 0, NULL},
+ {vc_pattern_ipv4_nat_t_esp, 0, NULL},
+ {vc_pattern_ipv6_nat_t_esp, 0, NULL},
+ {vc_pattern_ipv4_pfcp, 0, NULL},
+ {vc_pattern_ipv6_pfcp, 0, NULL},
};
struct virtchnl_fdir_inset_map {
enum virtchnl_proto_hdr_field field;
enum ice_flow_field fld;
+ u64 flag;
+ u64 mask;
};
static const struct virtchnl_fdir_inset_map fdir_inset_map[] = {
- {VIRTCHNL_PROTO_HDR_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
- {VIRTCHNL_PROTO_HDR_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},
- {VIRTCHNL_PROTO_HDR_IPV4_DSCP, ICE_FLOW_FIELD_IDX_IPV4_DSCP},
- {VIRTCHNL_PROTO_HDR_IPV4_TTL, ICE_FLOW_FIELD_IDX_IPV4_TTL},
- {VIRTCHNL_PROTO_HDR_IPV4_PROT, ICE_FLOW_FIELD_IDX_IPV4_PROT},
- {VIRTCHNL_PROTO_HDR_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA},
- {VIRTCHNL_PROTO_HDR_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA},
- {VIRTCHNL_PROTO_HDR_IPV6_TC, ICE_FLOW_FIELD_IDX_IPV6_DSCP},
- {VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT, ICE_FLOW_FIELD_IDX_IPV6_TTL},
- {VIRTCHNL_PROTO_HDR_IPV6_PROT, ICE_FLOW_FIELD_IDX_IPV6_PROT},
- {VIRTCHNL_PROTO_HDR_UDP_SRC_PORT, ICE_FLOW_FIELD_IDX_UDP_SRC_PORT},
- {VIRTCHNL_PROTO_HDR_UDP_DST_PORT, ICE_FLOW_FIELD_IDX_UDP_DST_PORT},
- {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT, ICE_FLOW_FIELD_IDX_TCP_SRC_PORT},
- {VIRTCHNL_PROTO_HDR_TCP_DST_PORT, ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
- {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT, ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
- {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT, ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
- {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID, ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},
- {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI, ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},
+ {VIRTCHNL_PROTO_HDR_ETH_ETHERTYPE, ICE_FLOW_FIELD_IDX_ETH_TYPE,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV4_DSCP, ICE_FLOW_FIELD_IDX_IPV4_DSCP,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV4_TTL, ICE_FLOW_FIELD_IDX_IPV4_TTL,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV4_PROT, ICE_FLOW_FIELD_IDX_IPV4_PROT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV6_TC, ICE_FLOW_FIELD_IDX_IPV6_DSCP,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT, ICE_FLOW_FIELD_IDX_IPV6_TTL,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_IPV6_PROT, ICE_FLOW_FIELD_IDX_IPV6_PROT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_UDP_SRC_PORT, ICE_FLOW_FIELD_IDX_UDP_SRC_PORT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_UDP_DST_PORT, ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT, ICE_FLOW_FIELD_IDX_TCP_SRC_PORT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_TCP_DST_PORT, ICE_FLOW_FIELD_IDX_TCP_DST_PORT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT, ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT, ICE_FLOW_FIELD_IDX_SCTP_DST_PORT,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID, ICE_FLOW_FIELD_IDX_GTPU_IP_TEID,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI, ICE_FLOW_FIELD_IDX_GTPU_EH_QFI,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_ESP_SPI, ICE_FLOW_FIELD_IDX_ESP_SPI,
+ FDIR_INSET_FLAG_ESP_IPSEC, FDIR_INSET_FLAG_ESP_M},
+ {VIRTCHNL_PROTO_HDR_ESP_SPI, ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI,
+ FDIR_INSET_FLAG_ESP_UDP, FDIR_INSET_FLAG_ESP_M},
+ {VIRTCHNL_PROTO_HDR_AH_SPI, ICE_FLOW_FIELD_IDX_AH_SPI,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_L2TPV3_SESS_ID, ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID,
+ 0, 0},
+ {VIRTCHNL_PROTO_HDR_PFCP_S_FIELD, ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
+ 0, 0},
};
/**
@@ -345,6 +470,11 @@ ice_vc_fdir_parse_flow_fld(struct virtchnl_proto_hdr *proto_hdr,
for (i = 0; (i < ARRAY_SIZE(fdir_inset_map)) &&
VIRTCHNL_GET_PROTO_HDR_FIELD(&hdr); i++)
if (VIRTCHNL_TEST_PROTO_HDR(&hdr, fdir_inset_map[i].field)) {
+ if (fdir_inset_map[i].mask &&
+ ((fdir_inset_map[i].mask & conf->inset_flag)
+ != fdir_inset_map[i].flag))
+ continue;
+
fld[*fld_cnt] = fdir_inset_map[i].fld;
*fld_cnt += 1;
if (*fld_cnt >= ICE_FLOW_FIELD_IDX_MAX)
@@ -425,6 +555,36 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
case ICE_FLTR_PTYPE_NON_IP_L2:
ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ETH_NON_IP);
break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_L2TPV3:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_L2TPV3 |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_ESP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ESP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_AH:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_AH |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_NAT_T_ESP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_NAT_T_ESP |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_PFCP_NODE:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_NODE |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV4_PFCP_SESSION:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_SESSION |
+ ICE_FLOW_SEG_HDR_IPV4 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
case ICE_FLTR_PTYPE_NONF_IPV4_OTHER:
ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 |
ICE_FLOW_SEG_HDR_IPV_OTHER);
@@ -463,6 +623,36 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
ICE_FLOW_SEG_HDR_IPV4 |
ICE_FLOW_SEG_HDR_IPV_OTHER);
break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_L2TPV3:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_L2TPV3 |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_ESP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ESP |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_AH:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_AH |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_NAT_T_ESP:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_NAT_T_ESP |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_PFCP_NODE:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_NODE |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
+ case ICE_FLTR_PTYPE_NONF_IPV6_PFCP_SESSION:
+ ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_SESSION |
+ ICE_FLOW_SEG_HDR_IPV6 |
+ ICE_FLOW_SEG_HDR_IPV_OTHER);
+ break;
case ICE_FLTR_PTYPE_NONF_IPV6_OTHER:
ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 |
ICE_FLOW_SEG_HDR_IPV_OTHER);
@@ -849,12 +1039,15 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
for (i = 0; i < proto->count; i++) {
struct virtchnl_proto_hdr *hdr = &proto->proto_hdr[i];
+ struct ip_esp_hdr *esph;
+ struct ip_auth_hdr *ah;
struct sctphdr *sctph;
struct ipv6hdr *ip6h;
struct udphdr *udph;
struct tcphdr *tcph;
struct ethhdr *eth;
struct iphdr *iph;
+ u8 s_field;
u8 *rawh;
switch (hdr->type) {
@@ -948,6 +1141,86 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct virtchnl_fdir_add *fltr,
}
}
break;
+ case VIRTCHNL_PROTO_HDR_L2TPV3:
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV4_L2TPV3;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV6_L2TPV3;
+
+ if (hdr->field_selector)
+ input->l2tpv3_data.session_id =
+ *((__be32 *)hdr->buffer);
+ break;
+ case VIRTCHNL_PROTO_HDR_ESP:
+ esph = (struct ip_esp_hdr *)hdr->buffer;
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4 &&
+ l4 == VIRTCHNL_PROTO_HDR_UDP)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV4_NAT_T_ESP;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 &&
+ l4 == VIRTCHNL_PROTO_HDR_UDP)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV6_NAT_T_ESP;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV4 &&
+ l4 == VIRTCHNL_PROTO_HDR_NONE)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV4_ESP;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 &&
+ l4 == VIRTCHNL_PROTO_HDR_NONE)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV6_ESP;
+
+ if (l4 == VIRTCHNL_PROTO_HDR_UDP)
+ conf->inset_flag |= FDIR_INSET_FLAG_ESP_UDP;
+ else
+ conf->inset_flag |= FDIR_INSET_FLAG_ESP_IPSEC;
+
+ if (hdr->field_selector) {
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->ip.v4.sec_parm_idx = esph->spi;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->ip.v6.sec_parm_idx = esph->spi;
+ }
+ break;
+ case VIRTCHNL_PROTO_HDR_AH:
+ ah = (struct ip_auth_hdr *)hdr->buffer;
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV4_AH;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->flow_type = ICE_FLTR_PTYPE_NONF_IPV6_AH;
+
+ if (hdr->field_selector) {
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->ip.v4.sec_parm_idx = ah->spi;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->ip.v6.sec_parm_idx = ah->spi;
+ }
+ break;
+ case VIRTCHNL_PROTO_HDR_PFCP:
+ rawh = (u8 *)hdr->buffer;
+ s_field = (rawh[0] >> PFCP_S_OFFSET) & PFCP_S_MASK;
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4 && s_field == 0)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV4_PFCP_NODE;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV4 && s_field == 1)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV4_PFCP_SESSION;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 && s_field == 0)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV6_PFCP_NODE;
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 && s_field == 1)
+ input->flow_type =
+ ICE_FLTR_PTYPE_NONF_IPV6_PFCP_SESSION;
+
+ if (hdr->field_selector) {
+ if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
+ input->ip.v4.dst_port =
+ cpu_to_be16(PFCP_PORT_NR);
+ else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
+ input->ip.v6.dst_port =
+ cpu_to_be16(PFCP_PORT_NR);
+ }
+ break;
case VIRTCHNL_PROTO_HDR_GTPU_IP:
rawh = (u8 *)hdr->buffer;
input->flow_type =
@@ -1108,6 +1381,10 @@ ice_vc_fdir_comp_rules(struct virtchnl_fdir_fltr_conf *conf_a,
return false;
if (memcmp(&a->gtpu_mask, &b->gtpu_mask, sizeof(a->gtpu_mask)))
return false;
+ if (memcmp(&a->l2tpv3_data, &b->l2tpv3_data, sizeof(a->l2tpv3_data)))
+ return false;
+ if (memcmp(&a->l2tpv3_mask, &b->l2tpv3_mask, sizeof(a->l2tpv3_mask)))
+ return false;
if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
return false;
if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 13/14] ice: Add more FDIR filter type for AVF
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 13/14] ice: Add more FDIR filter type " Qi Zhang
@ 2020-07-03 5:43 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:43 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 13/14] ice: Add more FDIR filter type
> for AVF
>
> FDIR for AVF can forward
> - L2TPV3 packets by matching session id.
> - IPSEC ESP packets by matching security parameter index.
> - IPSEC AH packets by matching security parameter index.
> - NAT_T ESP packets by matching security parameter index.
> - Any PFCP session packets(s field is 1).
>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_fdir.h | 7 +
> drivers/net/ethernet/intel/ice/ice_type.h | 13 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 313
> +++++++++++++++++++--
> 3 files changed, 315 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.h
> b/drivers/net/ethernet/intel/ice/ice_fdir.h
> index 9943c2b0f474..320f19cd748f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.h
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.h
> @@ -124,6 +124,10 @@ struct ice_fdir_udp_gtp {
> u8 next_ext;
> };
>
> +struct ice_fdir_l2tpv3 {
> + __be32 session_id;
> +};
> +
> struct ice_fdir_extra {
> u8 dst_mac[ETH_ALEN]; /* dest MAC address */
> __be16 ether_type; /* for NON_IP_L2 */
> @@ -144,6 +148,9 @@ struct ice_fdir_fltr {
> struct ice_fdir_udp_gtp gtpu_data;
> struct ice_fdir_udp_gtp gtpu_mask;
>
> + struct ice_fdir_l2tpv3 l2tpv3_data;
> + struct ice_fdir_l2tpv3 l2tpv3_mask;
> +
> struct ice_fdir_extra ext_data;
> struct ice_fdir_extra ext_mask;
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_type.h
> b/drivers/net/ethernet/intel/ice/ice_type.h
> index 0df159a1619a..1aaa06c01a55 100644
> --- a/drivers/net/ethernet/intel/ice/ice_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_type.h
> @@ -174,6 +174,19 @@ enum ice_fltr_ptype {
> ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP,
> ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP,
> ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER,
> + ICE_FLTR_PTYPE_NONF_IPV6_GTPU_IPV6_OTHER,
> + ICE_FLTR_PTYPE_NONF_IPV4_L2TPV3,
> + ICE_FLTR_PTYPE_NONF_IPV6_L2TPV3,
> + ICE_FLTR_PTYPE_NONF_IPV4_ESP,
> + ICE_FLTR_PTYPE_NONF_IPV6_ESP,
> + ICE_FLTR_PTYPE_NONF_IPV4_AH,
> + ICE_FLTR_PTYPE_NONF_IPV6_AH,
> + ICE_FLTR_PTYPE_NONF_IPV4_NAT_T_ESP,
> + ICE_FLTR_PTYPE_NONF_IPV6_NAT_T_ESP,
> + ICE_FLTR_PTYPE_NONF_IPV4_PFCP_NODE,
> + ICE_FLTR_PTYPE_NONF_IPV4_PFCP_SESSION,
> + ICE_FLTR_PTYPE_NONF_IPV6_PFCP_NODE,
> + ICE_FLTR_PTYPE_NONF_IPV6_PFCP_SESSION,
> ICE_FLTR_PTYPE_NON_IP_L2,
> ICE_FLTR_PTYPE_FRAG_IPV4,
> ICE_FLTR_PTYPE_NONF_IPV6_UDP,
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> index 325ba70b0635..f66b04a0a62f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> @@ -26,6 +26,14 @@
> #define GTPU_TEID_OFFSET 4
> #define GTPU_EH_QFI_OFFSET 1
> #define GTPU_EH_QFI_MASK 0x3F
> +#define PFCP_S_OFFSET 0
> +#define PFCP_S_MASK 0x1
> +#define PFCP_PORT_NR 8805
> +
> +#define FDIR_INSET_FLAG_ESP_S 0
> +#define FDIR_INSET_FLAG_ESP_M BIT_ULL(FDIR_INSET_FLAG_ESP_S)
> #define
> +FDIR_INSET_FLAG_ESP_UDP BIT_ULL(FDIR_INSET_FLAG_ESP_S) #define
> +FDIR_INSET_FLAG_ESP_IPSEC (0ULL << FDIR_INSET_FLAG_ESP_S)
>
> enum ice_fdir_tunnel_type {
> ICE_FDIR_TUNNEL_TYPE_NONE = 0,
> @@ -36,6 +44,7 @@ enum ice_fdir_tunnel_type { struct virtchnl_fdir_fltr_conf
> {
> struct ice_fdir_fltr input;
> enum ice_fdir_tunnel_type ttype;
> + u64 inset_flag;
> };
>
> static enum virtchnl_proto_hdr_type vc_pattern_ether[] = { @@ -114,6
> +123,80 @@ static enum virtchnl_proto_hdr_type vc_pattern_ipv4_gtpu_eh[] =
> {
> VIRTCHNL_PROTO_HDR_NONE,
> };
>
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_l2tpv3[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_L2TPV3,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_l2tpv3[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_L2TPV3,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_esp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_ESP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_esp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_ESP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_ah[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_AH,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_ah[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_AH,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_nat_t_esp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_ESP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_nat_t_esp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_ESP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv4_pfcp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV4,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_PFCP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> +static enum virtchnl_proto_hdr_type vc_pattern_ipv6_pfcp[] = {
> + VIRTCHNL_PROTO_HDR_ETH,
> + VIRTCHNL_PROTO_HDR_IPV6,
> + VIRTCHNL_PROTO_HDR_UDP,
> + VIRTCHNL_PROTO_HDR_PFCP,
> + VIRTCHNL_PROTO_HDR_NONE,
> +};
> +
> struct virtchnl_fdir_pattern_match_item {
> enum virtchnl_proto_hdr_type *list;
> u64 input_set;
> @@ -143,32 +226,74 @@ static const struct virtchnl_fdir_pattern_match_item
> vc_fdir_pattern_comms[] = {
> {vc_pattern_ether, 0, NULL},
> {vc_pattern_ipv4_gtpu, 0, NULL},
> {vc_pattern_ipv4_gtpu_eh, 0, NULL},
> + {vc_pattern_ipv4_l2tpv3, 0, NULL},
> + {vc_pattern_ipv6_l2tpv3, 0, NULL},
> + {vc_pattern_ipv4_esp, 0, NULL},
> + {vc_pattern_ipv6_esp, 0, NULL},
> + {vc_pattern_ipv4_ah, 0, NULL},
> + {vc_pattern_ipv6_ah, 0, NULL},
> + {vc_pattern_ipv4_nat_t_esp, 0, NULL},
> + {vc_pattern_ipv6_nat_t_esp, 0, NULL},
> + {vc_pattern_ipv4_pfcp, 0, NULL},
> + {vc_pattern_ipv6_pfcp, 0, NULL},
> };
>
> struct virtchnl_fdir_inset_map {
> enum virtchnl_proto_hdr_field field;
> enum ice_flow_field fld;
> + u64 flag;
> + u64 mask;
> };
>
> static const struct virtchnl_fdir_inset_map fdir_inset_map[] = {
> - {VIRTCHNL_PROTO_HDR_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
> - {VIRTCHNL_PROTO_HDR_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},
> - {VIRTCHNL_PROTO_HDR_IPV4_DSCP,
> ICE_FLOW_FIELD_IDX_IPV4_DSCP},
> - {VIRTCHNL_PROTO_HDR_IPV4_TTL,
> ICE_FLOW_FIELD_IDX_IPV4_TTL},
> - {VIRTCHNL_PROTO_HDR_IPV4_PROT,
> ICE_FLOW_FIELD_IDX_IPV4_PROT},
> - {VIRTCHNL_PROTO_HDR_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA},
> - {VIRTCHNL_PROTO_HDR_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA},
> - {VIRTCHNL_PROTO_HDR_IPV6_TC,
> ICE_FLOW_FIELD_IDX_IPV6_DSCP},
> - {VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT,
> ICE_FLOW_FIELD_IDX_IPV6_TTL},
> - {VIRTCHNL_PROTO_HDR_IPV6_PROT,
> ICE_FLOW_FIELD_IDX_IPV6_PROT},
> - {VIRTCHNL_PROTO_HDR_UDP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_UDP_SRC_PORT},
> - {VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
> ICE_FLOW_FIELD_IDX_UDP_DST_PORT},
> - {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_TCP_SRC_PORT},
> - {VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> ICE_FLOW_FIELD_IDX_TCP_DST_PORT},
> - {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
> - {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
> - {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID,
> ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},
> - {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI,
> ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},
> + {VIRTCHNL_PROTO_HDR_ETH_ETHERTYPE,
> ICE_FLOW_FIELD_IDX_ETH_TYPE,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV4_DSCP,
> ICE_FLOW_FIELD_IDX_IPV4_DSCP,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV4_TTL, ICE_FLOW_FIELD_IDX_IPV4_TTL,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV4_PROT,
> ICE_FLOW_FIELD_IDX_IPV4_PROT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV6_TC, ICE_FLOW_FIELD_IDX_IPV6_DSCP,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV6_HOP_LIMIT,
> ICE_FLOW_FIELD_IDX_IPV6_TTL,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_IPV6_PROT,
> ICE_FLOW_FIELD_IDX_IPV6_PROT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_UDP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_UDP_SRC_PORT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
> ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_TCP_SRC_PORT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> ICE_FLOW_FIELD_IDX_TCP_DST_PORT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> ICE_FLOW_FIELD_IDX_SCTP_DST_PORT,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_GTPU_IP_TEID,
> ICE_FLOW_FIELD_IDX_GTPU_IP_TEID,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_GTPU_EH_QFI,
> ICE_FLOW_FIELD_IDX_GTPU_EH_QFI,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_ESP_SPI, ICE_FLOW_FIELD_IDX_ESP_SPI,
> + FDIR_INSET_FLAG_ESP_IPSEC, FDIR_INSET_FLAG_ESP_M},
> + {VIRTCHNL_PROTO_HDR_ESP_SPI,
> ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI,
> + FDIR_INSET_FLAG_ESP_UDP, FDIR_INSET_FLAG_ESP_M},
> + {VIRTCHNL_PROTO_HDR_AH_SPI, ICE_FLOW_FIELD_IDX_AH_SPI,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_L2TPV3_SESS_ID,
> ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID,
> + 0, 0},
> + {VIRTCHNL_PROTO_HDR_PFCP_S_FIELD,
> ICE_FLOW_FIELD_IDX_UDP_DST_PORT,
> + 0, 0},
> };
Ugh, none of the above wrapped lines need to be wrapped
>
> /**
> @@ -345,6 +470,11 @@ ice_vc_fdir_parse_flow_fld(struct virtchnl_proto_hdr
> *proto_hdr,
> for (i = 0; (i < ARRAY_SIZE(fdir_inset_map)) &&
> VIRTCHNL_GET_PROTO_HDR_FIELD(&hdr); i++)
> if (VIRTCHNL_TEST_PROTO_HDR(&hdr, fdir_inset_map[i].field)) {
> + if (fdir_inset_map[i].mask &&
> + ((fdir_inset_map[i].mask & conf->inset_flag)
> + != fdir_inset_map[i].flag))
> + continue;
> +
> fld[*fld_cnt] = fdir_inset_map[i].fld;
> *fld_cnt += 1;
> if (*fld_cnt >= ICE_FLOW_FIELD_IDX_MAX) @@ -425,6
> +555,36 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> case ICE_FLTR_PTYPE_NON_IP_L2:
> ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ETH_NON_IP);
> break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_L2TPV3:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_L2TPV3 |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_ESP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ESP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_AH:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_AH |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_NAT_T_ESP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_NAT_T_ESP |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_PFCP_NODE:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_NODE |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV4_PFCP_SESSION:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_SESSION
> |
> + ICE_FLOW_SEG_HDR_IPV4 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> case ICE_FLTR_PTYPE_NONF_IPV4_OTHER:
> ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 |
> ICE_FLOW_SEG_HDR_IPV_OTHER);
> @@ -463,6 +623,36 @@ ice_vc_fdir_set_flow_hdr(struct ice_vf *vf,
> ICE_FLOW_SEG_HDR_IPV4 |
> ICE_FLOW_SEG_HDR_IPV_OTHER);
> break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_L2TPV3:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_L2TPV3 |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_ESP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_ESP |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_AH:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_AH |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_NAT_T_ESP:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_NAT_T_ESP |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_PFCP_NODE:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_NODE |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> + case ICE_FLTR_PTYPE_NONF_IPV6_PFCP_SESSION:
> + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_PFCP_SESSION
> |
> + ICE_FLOW_SEG_HDR_IPV6 |
> + ICE_FLOW_SEG_HDR_IPV_OTHER);
> + break;
> case ICE_FLTR_PTYPE_NONF_IPV6_OTHER:
> ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 |
> ICE_FLOW_SEG_HDR_IPV_OTHER);
> @@ -849,12 +1039,15 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct
> virtchnl_fdir_add *fltr,
>
> for (i = 0; i < proto->count; i++) {
> struct virtchnl_proto_hdr *hdr = &proto->proto_hdr[i];
> + struct ip_esp_hdr *esph;
> + struct ip_auth_hdr *ah;
> struct sctphdr *sctph;
> struct ipv6hdr *ip6h;
> struct udphdr *udph;
> struct tcphdr *tcph;
> struct ethhdr *eth;
> struct iphdr *iph;
> + u8 s_field;
> u8 *rawh;
>
> switch (hdr->type) {
> @@ -948,6 +1141,86 @@ ice_vc_fdir_parse_pattern(struct ice_vf *vf, struct
> virtchnl_fdir_add *fltr,
> }
> }
> break;
> + case VIRTCHNL_PROTO_HDR_L2TPV3:
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV4_L2TPV3;
No wrapping please
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV6_L2TPV3;
Here as well
> +
> + if (hdr->field_selector)
> + input->l2tpv3_data.session_id =
> + *((__be32 *)hdr->buffer);
And here
> + break;
> + case VIRTCHNL_PROTO_HDR_ESP:
> + esph = (struct ip_esp_hdr *)hdr->buffer;
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4 &&
> + l4 == VIRTCHNL_PROTO_HDR_UDP)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV4_NAT_T_ESP;
And here
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 &&
> + l4 == VIRTCHNL_PROTO_HDR_UDP)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV6_NAT_T_ESP;
And here
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV4 &&
> + l4 == VIRTCHNL_PROTO_HDR_NONE)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV4_ESP;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 &&
> + l4 == VIRTCHNL_PROTO_HDR_NONE)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV6_ESP;
> +
> + if (l4 == VIRTCHNL_PROTO_HDR_UDP)
> + conf->inset_flag |= FDIR_INSET_FLAG_ESP_UDP;
> + else
> + conf->inset_flag |= FDIR_INSET_FLAG_ESP_IPSEC;
> +
> + if (hdr->field_selector) {
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->ip.v4.sec_parm_idx = esph->spi;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->ip.v6.sec_parm_idx = esph->spi;
> + }
> + break;
> + case VIRTCHNL_PROTO_HDR_AH:
> + ah = (struct ip_auth_hdr *)hdr->buffer;
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV4_AH;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->flow_type =
> ICE_FLTR_PTYPE_NONF_IPV6_AH;
> +
> + if (hdr->field_selector) {
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->ip.v4.sec_parm_idx = ah->spi;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->ip.v6.sec_parm_idx = ah->spi;
> + }
> + break;
> + case VIRTCHNL_PROTO_HDR_PFCP:
> + rawh = (u8 *)hdr->buffer;
> + s_field = (rawh[0] >> PFCP_S_OFFSET) & PFCP_S_MASK;
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4 && s_field == 0)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV4_PFCP_NODE;
And here
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV4 && s_field
> == 1)
> + input->flow_type =
> +
> ICE_FLTR_PTYPE_NONF_IPV4_PFCP_SESSION;
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 && s_field
> == 0)
> + input->flow_type =
> + ICE_FLTR_PTYPE_NONF_IPV6_PFCP_NODE;
And here
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6 && s_field
> == 1)
> + input->flow_type =
> +
> ICE_FLTR_PTYPE_NONF_IPV6_PFCP_SESSION;
And here
> +
> + if (hdr->field_selector) {
> + if (l3 == VIRTCHNL_PROTO_HDR_IPV4)
> + input->ip.v4.dst_port =
> + cpu_to_be16(PFCP_PORT_NR);
And here
> + else if (l3 == VIRTCHNL_PROTO_HDR_IPV6)
> + input->ip.v6.dst_port =
> + cpu_to_be16(PFCP_PORT_NR);
And here
> + }
> + break;
> case VIRTCHNL_PROTO_HDR_GTPU_IP:
> rawh = (u8 *)hdr->buffer;
> input->flow_type =
> @@ -1108,6 +1381,10 @@ ice_vc_fdir_comp_rules(struct virtchnl_fdir_fltr_conf
> *conf_a,
> return false;
> if (memcmp(&a->gtpu_mask, &b->gtpu_mask, sizeof(a->gtpu_mask)))
> return false;
> + if (memcmp(&a->l2tpv3_data, &b->l2tpv3_data, sizeof(a-
> >l2tpv3_data)))
> + return false;
> + if (memcmp(&a->l2tpv3_mask, &b->l2tpv3_mask, sizeof(a-
> >l2tpv3_mask)))
> + return false;
> if (memcmp(&a->ext_data, &b->ext_data, sizeof(a->ext_data)))
> return false;
> if (memcmp(&a->ext_mask, &b->ext_mask, sizeof(a->ext_mask)))
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 14/14] ice: Check FDIR program status for AVF
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (12 preceding siblings ...)
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 13/14] ice: Add more FDIR filter type " Qi Zhang
@ 2020-07-02 22:58 ` Qi Zhang
2020-07-03 5:48 ` Kirsher, Jeffrey T
2020-07-03 5:55 ` [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Kirsher, Jeffrey T
14 siblings, 1 reply; 31+ messages in thread
From: Qi Zhang @ 2020-07-02 22:58 UTC (permalink / raw)
To: intel-wired-lan
Enables returning FDIR completion status by checking the
ctrl_vsi rx queue descriptor value.
To enable returning FDIR completion status from ctrl_vsi rx queue,
COMP_Queue and COMP_Report of FDIR filter programming descriptor
needs to be properly configed. After program request sent to ctrl_vsi
tx queue, ctrl_vsi rx queue interrupt will be triggered and
completion status will be retrurned.
Driver will first issue request in ice_vc_fdir_add_fltr(), then
pass FDIR context to the background task in interrupt service routine
ice_vc_fdir_irq_handler() and finally deal with them in
ice_flush_fdir_ctx(). ice_flush_fdir_ctx() will check the descriptor's
value, fdir context, and then send back virtual channel message to VF
by calling ice_vc_add_fdir_fltr_post(). An additional timer will be
setup in case of hardware interrupt timeout.
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ethernet/intel/ice/ice.h | 1 +
drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 3 +
drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 20 +
drivers/net/ethernet/intel/ice/ice_main.c | 2 +
drivers/net/ethernet/intel/ice/ice_txrx.c | 5 +
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 494 ++++++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h | 27 +-
7 files changed, 536 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index f3b8b694b0a0..84f75041520f 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -224,6 +224,7 @@ enum ice_state {
__ICE_OICR_INTR_DIS, /* Global OICR interrupt disabled */
__ICE_MDD_VF_PRINT_PENDING, /* set when MDD event handle */
__ICE_VF_RESETS_DISABLED, /* disable resets during ice_remove */
+ __ICE_FD_VF_FLUSH_CTX, /* set at FD Rx IRQ or timeout */
__ICE_STATE_NBITS /* must be last */
};
diff --git a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
index 07a9b70c2751..a9163471dbc0 100644
--- a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
+++ b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
@@ -384,6 +384,9 @@
#define VSIQF_FD_CNT(_VSI) (0x00464000 + ((_VSI) * 4))
#define VSIQF_FD_CNT_FD_GCNT_S 0
#define VSIQF_FD_CNT_FD_GCNT_M ICE_M(0x3FFF, 0)
+#define VSIQF_FD_CNT_FD_BCNT_S 16
+#define VSIQF_FD_CNT_FD_BCNT_M ICE_M(0x3FFF, 16)
+#define VSIQF_FD_SIZE(_VSI) (0x00462000 + ((_VSI) * 4))
#define VSIQF_HKEY_MAX_INDEX 12
#define VSIQF_HLUT_MAX_INDEX 15
#define VFINT_DYN_CTLN(_i) (0x00003800 + ((_i) * 4))
diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
index 1382c498e1f0..eee4726a393c 100644
--- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
+++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
@@ -140,6 +140,26 @@ struct ice_fltr_desc {
(0xFFFFFFFFULL << ICE_FXD_FLTR_QW1_FDID_S)
#define ICE_FXD_FLTR_QW1_FDID_ZERO 0x0ULL
+/* definition for FD filter programming status descriptor WB format */
+#define ICE_FXD_FLTR_WB_QW1_DD_S 0
+#define ICE_FXD_FLTR_WB_QW1_DD_M (0x1ULL << ICE_FXD_FLTR_WB_QW1_DD_S)
+#define ICE_FXD_FLTR_WB_QW1_DD_YES 0x1ULL
+
+#define ICE_FXD_FLTR_WB_QW1_PROG_ID_S 1
+#define ICE_FXD_FLTR_WB_QW1_PROG_ID_M \
+ (0x3ULL << ICE_FXD_FLTR_WB_QW1_PROG_ID_S)
+#define ICE_FXD_FLTR_WB_QW1_PROG_ADD 0x0ULL
+#define ICE_FXD_FLTR_WB_QW1_PROG_DEL 0x1ULL
+
+#define ICE_FXD_FLTR_WB_QW1_FAIL_S 4
+#define ICE_FXD_FLTR_WB_QW1_FAIL_M (0x1ULL << ICE_FXD_FLTR_WB_QW1_FAIL_S)
+#define ICE_FXD_FLTR_WB_QW1_FAIL_YES 0x1ULL
+
+#define ICE_FXD_FLTR_WB_QW1_FAIL_PROF_S 5
+#define ICE_FXD_FLTR_WB_QW1_FAIL_PROF_M \
+ (0x1ULL << ICE_FXD_FLTR_WB_QW1_FAIL_PROF_S)
+#define ICE_FXD_FLTR_WB_QW1_FAIL_PROF_YES 0x1ULL
+
struct ice_rx_ptype_decoded {
u32 ptype:10;
u32 known:1;
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 8afd33bdd637..c0b5f7f83d67 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -1481,6 +1481,7 @@ static void ice_service_task(struct work_struct *work)
ice_process_vflr_event(pf);
ice_clean_mailboxq_subtask(pf);
ice_sync_arfs_fltrs(pf);
+ ice_flush_fdir_ctx(pf);
/* Clear __ICE_SERVICE_SCHED flag to allow scheduling next event */
ice_service_task_complete(pf);
@@ -1492,6 +1493,7 @@ static void ice_service_task(struct work_struct *work)
test_bit(__ICE_MDD_EVENT_PENDING, pf->state) ||
test_bit(__ICE_VFLR_EVENT_PENDING, pf->state) ||
test_bit(__ICE_MAILBOXQ_EVENT_PENDING, pf->state) ||
+ test_bit(__ICE_FD_VF_FLUSH_CTX, pf->state) ||
test_bit(__ICE_ADMINQ_EVENT_PENDING, pf->state))
mod_timer(&pf->serv_tmr, jiffies);
}
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
index abdb137c8bb7..0aaed92f807f 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
@@ -1128,6 +1128,11 @@ int ice_clean_rx_irq(struct ice_ring *rx_ring, int budget)
dma_rmb();
if (rx_desc->wb.rxdid == FDIR_DESC_RXDID || !rx_ring->netdev) {
+ struct ice_vsi *ctrl_vsi = rx_ring->vsi;
+
+ if (rx_desc->wb.rxdid == FDIR_DESC_RXDID &&
+ ctrl_vsi->vf_id != ICE_INVAL_VFID)
+ ice_vc_fdir_irq_handler(ctrl_vsi, rx_desc);
ice_put_rx_buf(rx_ring, NULL);
cleaned_count++;
continue;
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
index f66b04a0a62f..3e8503130b92 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
@@ -45,6 +45,7 @@ struct virtchnl_fdir_fltr_conf {
struct ice_fdir_fltr input;
enum ice_fdir_tunnel_type ttype;
u64 inset_flag;
+ u32 flow_id;
};
static enum virtchnl_proto_hdr_type vc_pattern_ether[] = {
@@ -1527,7 +1528,7 @@ static int ice_vc_fdir_write_fltr(struct ice_vf *vf,
}
input->dest_vsi = vsi->idx;
- input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
+ input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;
ctrl_vsi = pf->vsi[vf->ctrl_vsi_idx];
if (!ctrl_vsi) {
@@ -1560,6 +1561,455 @@ static int ice_vc_fdir_write_fltr(struct ice_vf *vf,
}
/**
+ * ice_vf_fdir_timer - FDIR program waiting timer interrupt handler
+ * @t: pointer to timer_list
+ */
+static void ice_vf_fdir_timer(struct timer_list *t)
+{
+ struct ice_vf_fdir_ctx *ctx_irq = from_timer(ctx_irq, t, rx_tmr);
+ struct ice_vf_fdir_ctx *ctx_done;
+ struct ice_vf_fdir *fdir;
+ unsigned long flags;
+ struct ice_vf *vf;
+ struct ice_pf *pf;
+
+ fdir = container_of(ctx_irq, struct ice_vf_fdir, ctx_irq);
+ vf = container_of(fdir, struct ice_vf, fdir);
+ ctx_done = &fdir->ctx_done;
+ pf = vf->pf;
+ spin_lock_irqsave(&fdir->ctx_lock, flags);
+ if (!(ctx_irq->flags & ICE_VF_FDIR_CTX_VALID)) {
+ spin_unlock_irqrestore(&fdir->ctx_lock, flags);
+ WARN_ON_ONCE(1);
+ return;
+ }
+
+ ctx_irq->flags &= ~ICE_VF_FDIR_CTX_VALID;
+
+ ctx_done->flags |= ICE_VF_FDIR_CTX_VALID;
+ ctx_done->conf = ctx_irq->conf;
+ ctx_done->stat = ICE_FDIR_CTX_TIMEOUT;
+ ctx_done->v_opcode = ctx_irq->v_opcode;
+ spin_unlock_irqrestore(&fdir->ctx_lock, flags);
+
+ set_bit(__ICE_FD_VF_FLUSH_CTX, pf->state);
+ ice_service_task_schedule(pf);
+}
+
+/**
+ * ice_vc_fdir_irq_handler - ctrl_vsi Rx queue interrupt handler
+ * @ctrl_vsi: pointer to a VF's CTRL VSI
+ * @rx_desc: pointer to FDIR Rx queue descriptor
+ */
+void
+ice_vc_fdir_irq_handler(struct ice_vsi *ctrl_vsi,
+ union ice_32b_rx_flex_desc *rx_desc)
+{
+ struct ice_pf *pf = ctrl_vsi->back;
+ struct ice_vf_fdir_ctx *ctx_done;
+ struct ice_vf_fdir_ctx *ctx_irq;
+ struct ice_vf_fdir *fdir;
+ unsigned long flags;
+ struct device *dev;
+ struct ice_vf *vf;
+ int ret;
+
+ vf = &pf->vf[ctrl_vsi->vf_id];
+
+ fdir = &vf->fdir;
+ ctx_done = &fdir->ctx_done;
+ ctx_irq = &fdir->ctx_irq;
+ dev = ice_pf_to_dev(pf);
+ spin_lock_irqsave(&fdir->ctx_lock, flags);
+ if (!(ctx_irq->flags & ICE_VF_FDIR_CTX_VALID)) {
+ spin_unlock_irqrestore(&fdir->ctx_lock, flags);
+ WARN_ON_ONCE(1);
+ return;
+ }
+
+ ctx_irq->flags &= ~ICE_VF_FDIR_CTX_VALID;
+
+ ctx_done->flags |= ICE_VF_FDIR_CTX_VALID;
+ ctx_done->conf = ctx_irq->conf;
+ ctx_done->stat = ICE_FDIR_CTX_IRQ;
+ ctx_done->v_opcode = ctx_irq->v_opcode;
+ memcpy(&ctx_done->rx_desc, rx_desc, sizeof(*rx_desc));
+ spin_unlock_irqrestore(&fdir->ctx_lock, flags);
+
+ ret = del_timer(&ctx_irq->rx_tmr);
+ if (!ret)
+ dev_err(dev, "VF %d: Unexpected inactive timer!\n", vf->vf_id);
+
+ set_bit(__ICE_FD_VF_FLUSH_CTX, pf->state);
+ ice_service_task_schedule(pf);
+}
+
+/**
+ * ice_vf_fdir_dump_info - dump FDIR information for diagnosis
+ * @vf: pointer to the VF info
+ */
+static void ice_vf_fdir_dump_info(struct ice_vf *vf)
+{
+ struct ice_vsi *vf_vsi;
+ u32 fd_size, fd_cnt;
+ struct device *dev;
+ struct ice_pf *pf;
+ struct ice_hw *hw;
+ u16 vsi_num;
+
+ pf = vf->pf;
+ hw = &pf->hw;
+ dev = ice_pf_to_dev(pf);
+ vf_vsi = pf->vsi[vf->lan_vsi_idx];
+ vsi_num = ice_get_hw_vsi_num(hw, vf_vsi->idx);
+
+ fd_size = rd32(hw, VSIQF_FD_SIZE(vsi_num));
+ fd_cnt = rd32(hw, VSIQF_FD_CNT(vsi_num));
+ dev_dbg(dev, "VF %d: space allocated: guar:0x%x, be:0x%x, space consumed: guar:0x%x, be:0x%x",
+ vf->vf_id,
+ (fd_size & VSIQF_FD_CNT_FD_GCNT_M) >> VSIQF_FD_CNT_FD_GCNT_S,
+ (fd_size & VSIQF_FD_CNT_FD_BCNT_M) >> VSIQF_FD_CNT_FD_BCNT_S,
+ (fd_cnt & VSIQF_FD_CNT_FD_GCNT_M) >> VSIQF_FD_CNT_FD_GCNT_S,
+ (fd_cnt & VSIQF_FD_CNT_FD_BCNT_M) >> VSIQF_FD_CNT_FD_BCNT_S);
+}
+
+/**
+ * ice_vf_verify_rx_desc - verify received FDIR programming status descriptor
+ * @vf: pointer to the VF info
+ * @ctx: FDIR context info for post processing
+ * @status: virtchnl FDIR program status
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vf_verify_rx_desc(struct ice_vf *vf, struct ice_vf_fdir_ctx *ctx,
+ enum virtchnl_fdir_prgm_status *status)
+{
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ u32 stat_err, error, prog_id;
+ int ret;
+
+ stat_err = le16_to_cpu(ctx->rx_desc.wb.status_error0);
+ if (((stat_err & ICE_FXD_FLTR_WB_QW1_DD_M) >>
+ ICE_FXD_FLTR_WB_QW1_DD_S) != ICE_FXD_FLTR_WB_QW1_DD_YES) {
+ *status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_err(dev, "VF %d: Desc Done not set\n", vf->vf_id);
+ ret = -EINVAL;
+ goto err_exit;
+ }
+
+ prog_id = (stat_err & ICE_FXD_FLTR_WB_QW1_PROG_ID_M) >>
+ ICE_FXD_FLTR_WB_QW1_PROG_ID_S;
+ if (prog_id == ICE_FXD_FLTR_WB_QW1_PROG_ADD &&
+ ctx->v_opcode != VIRTCHNL_OP_ADD_FDIR_FILTER) {
+ dev_err(dev, "VF %d: Desc show add, but ctx not",
+ vf->vf_id);
+ *status = VIRTCHNL_FDIR_FAILURE_RULE_INVALID;
+ ret = -EINVAL;
+ goto err_exit;
+ }
+
+ if (prog_id == ICE_FXD_FLTR_WB_QW1_PROG_DEL &&
+ ctx->v_opcode != VIRTCHNL_OP_DEL_FDIR_FILTER) {
+ dev_err(dev, "VF %d: Desc show del, but ctx not",
+ vf->vf_id);
+ *status = VIRTCHNL_FDIR_FAILURE_RULE_INVALID;
+ ret = -EINVAL;
+ goto err_exit;
+ }
+
+ error = (stat_err & ICE_FXD_FLTR_WB_QW1_FAIL_M) >>
+ ICE_FXD_FLTR_WB_QW1_FAIL_S;
+ if (error == ICE_FXD_FLTR_WB_QW1_FAIL_YES) {
+ if (prog_id == ICE_FXD_FLTR_WB_QW1_PROG_ADD) {
+ dev_err(dev, "VF %d, Failed to add FDIR rule due to no space in the table",
+ vf->vf_id);
+ *status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ } else {
+ dev_err(dev, "VF %d, Failed to remove FDIR rule, attempt to remove non-existent entry",
+ vf->vf_id);
+ *status = VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST;
+ }
+ ret = -EINVAL;
+ goto err_exit;
+ }
+
+ error = (stat_err & ICE_FXD_FLTR_WB_QW1_FAIL_PROF_M) >>
+ ICE_FXD_FLTR_WB_QW1_FAIL_PROF_S;
+ if (error == ICE_FXD_FLTR_WB_QW1_FAIL_PROF_YES) {
+ dev_err(dev, "VF %d: Profile matching error", vf->vf_id);
+ *status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ ret = -EINVAL;
+ goto err_exit;
+ }
+
+ *status = VIRTCHNL_FDIR_SUCCESS;
+
+ return 0;
+
+err_exit:
+ ice_vf_fdir_dump_info(vf);
+ return ret;
+}
+
+/**
+ * ice_vc_add_fdir_fltr_post
+ * @vf: pointer to the VF structure
+ * @ctx: FDIR context info for post processing
+ * @status: virtchnl FDIR program status
+ * @success: true implies success, false implies failure
+ *
+ * Post process for flow director add command. If success, then do post process
+ * and send back success msg by virtchnl. Otherwise, do context reversion and
+ * send back failure msg by virtchnl.
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_add_fdir_fltr_post(struct ice_vf *vf, struct ice_vf_fdir_ctx *ctx,
+ enum virtchnl_fdir_prgm_status status,
+ bool success)
+{
+ struct virtchnl_fdir_fltr_conf *conf = ctx->conf;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ enum virtchnl_status_code v_ret;
+ struct virtchnl_fdir_add *resp;
+ int ret, len, is_tun;
+
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ len = sizeof(*resp);
+ resp = kzalloc(len, GFP_KERNEL);
+ if (!resp) {
+ len = 0;
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ dev_dbg(dev, "VF %d: Alloc resp buf fail", vf->vf_id);
+ goto err_exit;
+ }
+
+ if (!success)
+ goto err_exit;
+
+ is_tun = 0;
+ resp->status = status;
+ resp->flow_id = conf->flow_id;
+ vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]++;
+
+ ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
+ (u8 *)resp, len);
+ kfree(resp);
+
+ dev_dbg(dev, "VF %d: flow_id:0x%X, FDIR %s success!\n",
+ vf->vf_id, conf->flow_id,
+ (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER) ?
+ "add" : "del");
+ return ret;
+
+err_exit:
+ if (resp)
+ resp->status = status;
+ ice_vc_fdir_remove_entry(vf, conf, conf->flow_id);
+ devm_kfree(dev, conf);
+
+ ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
+ (u8 *)resp, len);
+ kfree(resp);
+ return ret;
+}
+
+/**
+ * ice_vc_del_fdir_fltr_post
+ * @vf: pointer to the VF structure
+ * @ctx: FDIR context info for post processing
+ * @status: virtchnl FDIR program status
+ * @success: true implies success, false implies failure
+ *
+ * Post process for flow director del command. If success, then do post process
+ * and send back success msg by virtchnl. Otherwise, do context reversion and
+ * send back failure msg by virtchnl.
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_del_fdir_fltr_post(struct ice_vf *vf, struct ice_vf_fdir_ctx *ctx,
+ enum virtchnl_fdir_prgm_status status,
+ bool success)
+{
+ struct virtchnl_fdir_fltr_conf *conf = ctx->conf;
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ enum virtchnl_status_code v_ret;
+ struct virtchnl_fdir_del *resp;
+ int ret, len, is_tun;
+
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ len = sizeof(*resp);
+ resp = kzalloc(len, GFP_KERNEL);
+ if (!resp) {
+ len = 0;
+ v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
+ dev_dbg(dev, "VF %d: Alloc resp buf fail", vf->vf_id);
+ goto err_exit;
+ }
+
+ if (!success)
+ goto err_exit;
+
+ is_tun = 0;
+ resp->status = status;
+ ice_vc_fdir_remove_entry(vf, conf, conf->flow_id);
+ vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]--;
+
+ ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
+ (u8 *)resp, len);
+ kfree(resp);
+
+ dev_dbg(dev, "VF %d: flow_id:0x%X, FDIR %s success!\n",
+ vf->vf_id, conf->flow_id,
+ (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER) ?
+ "add" : "del");
+ devm_kfree(dev, conf);
+ return ret;
+
+err_exit:
+ if (resp)
+ resp->status = status;
+ if (success)
+ devm_kfree(dev, conf);
+
+ ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
+ (u8 *)resp, len);
+ kfree(resp);
+ return ret;
+}
+
+/**
+ * ice_flush_fdir_ctx
+ * @pf: pointer to the PF structure
+ *
+ * Flush all the pending event on ctx_done list and process them.
+ */
+void ice_flush_fdir_ctx(struct ice_pf *pf)
+{
+ int i;
+
+ if (!test_and_clear_bit(__ICE_FD_VF_FLUSH_CTX, pf->state))
+ return;
+
+ ice_for_each_vf(pf, i) {
+ struct device *dev = ice_pf_to_dev(pf);
+ enum virtchnl_fdir_prgm_status status;
+ struct ice_vf *vf = &pf->vf[i];
+ struct ice_vf_fdir_ctx *ctx;
+ unsigned long flags;
+ int ret;
+
+ if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states))
+ continue;
+
+ if (vf->ctrl_vsi_idx == ICE_NO_VSI)
+ continue;
+
+ ctx = &vf->fdir.ctx_done;
+ spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
+ if (!(ctx->flags & ICE_VF_FDIR_CTX_VALID)) {
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+ continue;
+ }
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+
+ WARN_ON(ctx->stat == ICE_FDIR_CTX_READY);
+ if (ctx->stat == ICE_FDIR_CTX_TIMEOUT) {
+ status = VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT;
+ dev_err(dev, "VF %d: ctrl_vsi irq timeout\n",
+ vf->vf_id);
+ goto err_exit;
+ }
+
+ ret = ice_vf_verify_rx_desc(vf, ctx, &status);
+ if (ret)
+ goto err_exit;
+
+ if (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER)
+ ice_vc_add_fdir_fltr_post(vf, ctx, status, true);
+ else if (ctx->v_opcode == VIRTCHNL_OP_DEL_FDIR_FILTER)
+ ice_vc_del_fdir_fltr_post(vf, ctx, status, true);
+ else
+ dev_err(dev, "VF %d: Unsupported opcode\n", vf->vf_id);
+
+ spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
+ ctx->flags &= ~ICE_VF_FDIR_CTX_VALID;
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+ continue;
+err_exit:
+ if (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER)
+ ice_vc_add_fdir_fltr_post(vf, ctx, status, false);
+ else if (ctx->v_opcode == VIRTCHNL_OP_DEL_FDIR_FILTER)
+ ice_vc_del_fdir_fltr_post(vf, ctx, status, false);
+ else
+ dev_err(dev, "VF %d: Unsupported opcode\n", vf->vf_id);
+
+ spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
+ ctx->flags &= ~ICE_VF_FDIR_CTX_VALID;
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+ }
+}
+
+/**
+ * ice_vc_fdir_set_irq_ctx - set FDIR context info for later irq handler
+ * @vf: pointer to the VF structure
+ * @conf: FDIR configuration for each filter
+ * @v_opcode: virtual channel operation code
+ *
+ * Return: 0 on success, and other on error.
+ */
+static int
+ice_vc_fdir_set_irq_ctx(struct ice_vf *vf, struct virtchnl_fdir_fltr_conf *conf,
+ enum virtchnl_ops v_opcode)
+{
+ struct device *dev = ice_pf_to_dev(vf->pf);
+ struct ice_vf_fdir_ctx *ctx;
+ unsigned long flags;
+
+ ctx = &vf->fdir.ctx_irq;
+ spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
+ if ((vf->fdir.ctx_irq.flags & ICE_VF_FDIR_CTX_VALID) ||
+ (vf->fdir.ctx_done.flags & ICE_VF_FDIR_CTX_VALID)) {
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+ dev_dbg(dev, "VF %d: Last request is still in progress\n",
+ vf->vf_id);
+ return -EBUSY;
+ }
+ ctx->flags |= ICE_VF_FDIR_CTX_VALID;
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+
+ ctx->conf = conf;
+ ctx->v_opcode = v_opcode;
+ ctx->stat = ICE_FDIR_CTX_READY;
+ timer_setup(&ctx->rx_tmr, ice_vf_fdir_timer, 0);
+
+ mod_timer(&ctx->rx_tmr,
+ round_jiffies(msecs_to_jiffies(10) + jiffies));
+
+ return 0;
+}
+
+/**
+ * ice_vc_fdir_clear_irq_ctx - clear FDIR context info for irq handler
+ * @vf: pointer to the VF structure
+ *
+ * Return: 0 on success, and other on error.
+ */
+static void ice_vc_fdir_clear_irq_ctx(struct ice_vf *vf)
+{
+ struct ice_vf_fdir_ctx *ctx = &vf->fdir.ctx_irq;
+ unsigned long flags;
+
+ del_timer(&ctx->rx_tmr);
+ spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
+ ctx->flags &= ~ICE_VF_FDIR_CTX_VALID;
+ spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
+}
+
+/**
* ice_vc_add_fdir_fltr - add a FDIR filter for VF by the msg buffer
* @vf: pointer to the VF info
* @msg: pointer to the msg buffer
@@ -1645,7 +2095,7 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
goto err_free_conf;
}
- ret = ice_vc_fdir_insert_entry(vf, conf, &stat->flow_id);
+ ret = ice_vc_fdir_insert_entry(vf, conf, &conf->flow_id);
if (ret) {
v_ret = VIRTCHNL_STATUS_SUCCESS;
stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
@@ -1653,6 +2103,14 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
goto err_free_conf;
}
+ ret = ice_vc_fdir_set_irq_ctx(vf, conf, VIRTCHNL_OP_ADD_FDIR_FILTER);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_dbg(dev, "VF %d: set FDIR context failed\n", vf->vf_id);
+ goto err_free_conf;
+ }
+
ret = ice_vc_fdir_write_fltr(vf, conf, true, is_tun);
if (ret) {
v_ret = VIRTCHNL_STATUS_SUCCESS;
@@ -1662,18 +2120,13 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
goto err_rem_entry;
}
- vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]++;
-
- v_ret = VIRTCHNL_STATUS_SUCCESS;
- stat->status = VIRTCHNL_FDIR_SUCCESS;
exit:
- ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER, v_ret,
- (u8 *)stat, len);
kfree(stat);
return ret;
err_rem_entry:
- ice_vc_fdir_remove_entry(vf, conf, stat->flow_id);
+ ice_vc_fdir_clear_irq_ctx(vf);
+ ice_vc_fdir_remove_entry(vf, conf, conf->flow_id);
err_free_conf:
devm_kfree(dev, conf);
err_exit:
@@ -1737,22 +2190,29 @@ int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg)
goto err_exit;
}
+ ret = ice_vc_fdir_set_irq_ctx(vf, conf, VIRTCHNL_OP_DEL_FDIR_FILTER);
+ if (ret) {
+ v_ret = VIRTCHNL_STATUS_SUCCESS;
+ stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
+ dev_dbg(dev, "VF %d: set FDIR context failed\n", vf->vf_id);
+ goto err_exit;
+ }
+
ret = ice_vc_fdir_write_fltr(vf, conf, false, is_tun);
if (ret) {
v_ret = VIRTCHNL_STATUS_SUCCESS;
stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
dev_err(dev, "VF %d: writing FDIR rule failed, ret:%d\n",
vf->vf_id, ret);
- goto err_exit;
+ goto err_del_tmr;
}
- ice_vc_fdir_remove_entry(vf, conf, fltr->flow_id);
- devm_kfree(dev, conf);
- vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]--;
+ kfree(stat);
- v_ret = VIRTCHNL_STATUS_SUCCESS;
- stat->status = VIRTCHNL_FDIR_SUCCESS;
+ return ret;
+err_del_tmr:
+ ice_vc_fdir_clear_irq_ctx(vf);
err_exit:
ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_DEL_FDIR_FILTER, v_ret,
(u8 *)stat, len);
@@ -1770,6 +2230,10 @@ void ice_vf_fdir_init(struct ice_vf *vf)
idr_init(&fdir->fdir_rule_idr);
INIT_LIST_HEAD(&fdir->fdir_rule_list);
+
+ spin_lock_init(&fdir->ctx_lock);
+ fdir->ctx_irq.flags = 0;
+ fdir->ctx_done.flags = 0;
}
/**
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
index 676de402475e..53b78e866381 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
@@ -5,6 +5,24 @@
#define _ICE_VIRTCHNL_FDIR_H_
struct ice_vf;
+struct ice_pf;
+
+enum ice_fdir_ctx_stat {
+ ICE_FDIR_CTX_READY,
+ ICE_FDIR_CTX_IRQ,
+ ICE_FDIR_CTX_TIMEOUT,
+};
+
+struct ice_vf_fdir_ctx {
+ struct timer_list rx_tmr;
+ enum virtchnl_ops v_opcode;
+ enum ice_fdir_ctx_stat stat;
+ union ice_32b_rx_flex_desc rx_desc;
+#define ICE_VF_FDIR_CTX_VALID BIT(0)
+ u32 flags;
+
+ void *conf;
+};
/* VF FDIR information structure */
struct ice_vf_fdir {
@@ -14,11 +32,18 @@ struct ice_vf_fdir {
struct idr fdir_rule_idr;
struct list_head fdir_rule_list;
+
+ spinlock_t ctx_lock; /* protects FDIR context info */
+ struct ice_vf_fdir_ctx ctx_irq;
+ struct ice_vf_fdir_ctx ctx_done;
};
int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg);
int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg);
void ice_vf_fdir_init(struct ice_vf *vf);
void ice_vf_fdir_exit(struct ice_vf *vf);
-
+void
+ice_vc_fdir_irq_handler(struct ice_vsi *ctrl_vsi,
+ union ice_32b_rx_flex_desc *rx_desc);
+void ice_flush_fdir_ctx(struct ice_pf *pf);
#endif /* _ICE_VIRTCHNL_FDIR_H_ */
--
2.13.6
^ permalink raw reply related [flat|nested] 31+ messages in thread* [Intel-wired-lan] [PATCH S48 v3 14/14] ice: Check FDIR program status for AVF
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 14/14] ice: Check FDIR program status " Qi Zhang
@ 2020-07-03 5:48 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:48 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 14/14] ice: Check FDIR program
> status for AVF
>
> Enables returning FDIR completion status by checking the ctrl_vsi rx queue
> descriptor value.
>
> To enable returning FDIR completion status from ctrl_vsi rx queue,
> COMP_Queue and COMP_Report of FDIR filter programming descriptor needs to
> be properly configed. After program request sent to ctrl_vsi tx queue, ctrl_vsi rx
> queue interrupt will be triggered and completion status will be retrurned.
>
> Driver will first issue request in ice_vc_fdir_add_fltr(), then pass FDIR context to
> the background task in interrupt service routine
> ice_vc_fdir_irq_handler() and finally deal with them in ice_flush_fdir_ctx().
> ice_flush_fdir_ctx() will check the descriptor's value, fdir context, and then send
> back virtual channel message to VF by calling ice_vc_add_fdir_fltr_post(). An
> additional timer will be setup in case of hardware interrupt timeout.
>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 1 +
> drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 3 +
> drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 20 +
> drivers/net/ethernet/intel/ice/ice_main.c | 2 +
> drivers/net/ethernet/intel/ice/ice_txrx.c | 5 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 494
> ++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h | 27 +-
> 7 files changed, 536 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice.h
> b/drivers/net/ethernet/intel/ice/ice.h
> index f3b8b694b0a0..84f75041520f 100644
> --- a/drivers/net/ethernet/intel/ice/ice.h
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -224,6 +224,7 @@ enum ice_state {
> __ICE_OICR_INTR_DIS, /* Global OICR interrupt disabled */
> __ICE_MDD_VF_PRINT_PENDING, /* set when MDD event handle */
> __ICE_VF_RESETS_DISABLED, /* disable resets during ice_remove
> */
> + __ICE_FD_VF_FLUSH_CTX, /* set at FD Rx IRQ or timeout */
> __ICE_STATE_NBITS /* must be last */
> };
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> index 07a9b70c2751..a9163471dbc0 100644
> --- a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> +++ b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h
> @@ -384,6 +384,9 @@
> #define VSIQF_FD_CNT(_VSI) (0x00464000 + ((_VSI) * 4))
> #define VSIQF_FD_CNT_FD_GCNT_S 0
> #define VSIQF_FD_CNT_FD_GCNT_M ICE_M(0x3FFF, 0)
> +#define VSIQF_FD_CNT_FD_BCNT_S 16
> +#define VSIQF_FD_CNT_FD_BCNT_M ICE_M(0x3FFF, 16)
> +#define VSIQF_FD_SIZE(_VSI) (0x00462000 + ((_VSI) * 4))
The above defines used spaces and NOT tabs to align the values, please use tabs.
> #define VSIQF_HKEY_MAX_INDEX 12
> #define VSIQF_HLUT_MAX_INDEX 15
> #define VFINT_DYN_CTLN(_i) (0x00003800 + ((_i) * 4))
> diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> index 1382c498e1f0..eee4726a393c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> +++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h
> @@ -140,6 +140,26 @@ struct ice_fltr_desc {
> (0xFFFFFFFFULL << ICE_FXD_FLTR_QW1_FDID_S)
> #define ICE_FXD_FLTR_QW1_FDID_ZERO 0x0ULL
>
> +/* definition for FD filter programming status descriptor WB format */
> +#define ICE_FXD_FLTR_WB_QW1_DD_S 0
> +#define ICE_FXD_FLTR_WB_QW1_DD_M (0x1ULL <<
> ICE_FXD_FLTR_WB_QW1_DD_S)
> +#define ICE_FXD_FLTR_WB_QW1_DD_YES 0x1ULL
> +
> +#define ICE_FXD_FLTR_WB_QW1_PROG_ID_S 1
> +#define ICE_FXD_FLTR_WB_QW1_PROG_ID_M \
> + (0x3ULL <<
> ICE_FXD_FLTR_WB_QW1_PROG_ID_S)
> +#define ICE_FXD_FLTR_WB_QW1_PROG_ADD 0x0ULL
> +#define ICE_FXD_FLTR_WB_QW1_PROG_DEL 0x1ULL
> +
> +#define ICE_FXD_FLTR_WB_QW1_FAIL_S 4
> +#define ICE_FXD_FLTR_WB_QW1_FAIL_M (0x1ULL <<
> ICE_FXD_FLTR_WB_QW1_FAIL_S)
> +#define ICE_FXD_FLTR_WB_QW1_FAIL_YES 0x1ULL
> +
> +#define ICE_FXD_FLTR_WB_QW1_FAIL_PROF_S 5
> +#define ICE_FXD_FLTR_WB_QW1_FAIL_PROF_M \
> + (0x1ULL <<
> ICE_FXD_FLTR_WB_QW1_FAIL_PROF_S)
> +#define ICE_FXD_FLTR_WB_QW1_FAIL_PROF_YES 0x1ULL
> +
> struct ice_rx_ptype_decoded {
> u32 ptype:10;
> u32 known:1;
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index 8afd33bdd637..c0b5f7f83d67 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -1481,6 +1481,7 @@ static void ice_service_task(struct work_struct
> *work)
> ice_process_vflr_event(pf);
> ice_clean_mailboxq_subtask(pf);
> ice_sync_arfs_fltrs(pf);
> + ice_flush_fdir_ctx(pf);
> /* Clear __ICE_SERVICE_SCHED flag to allow scheduling next event */
> ice_service_task_complete(pf);
>
> @@ -1492,6 +1493,7 @@ static void ice_service_task(struct work_struct
> *work)
> test_bit(__ICE_MDD_EVENT_PENDING, pf->state) ||
> test_bit(__ICE_VFLR_EVENT_PENDING, pf->state) ||
> test_bit(__ICE_MAILBOXQ_EVENT_PENDING, pf->state) ||
> + test_bit(__ICE_FD_VF_FLUSH_CTX, pf->state) ||
> test_bit(__ICE_ADMINQ_EVENT_PENDING, pf->state))
> mod_timer(&pf->serv_tmr, jiffies);
> }
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c
> b/drivers/net/ethernet/intel/ice/ice_txrx.c
> index abdb137c8bb7..0aaed92f807f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
> @@ -1128,6 +1128,11 @@ int ice_clean_rx_irq(struct ice_ring *rx_ring, int
> budget)
> dma_rmb();
>
> if (rx_desc->wb.rxdid == FDIR_DESC_RXDID || !rx_ring->netdev)
> {
> + struct ice_vsi *ctrl_vsi = rx_ring->vsi;
> +
> + if (rx_desc->wb.rxdid == FDIR_DESC_RXDID &&
> + ctrl_vsi->vf_id != ICE_INVAL_VFID)
> + ice_vc_fdir_irq_handler(ctrl_vsi, rx_desc);
> ice_put_rx_buf(rx_ring, NULL);
> cleaned_count++;
> continue;
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> index f66b04a0a62f..3e8503130b92 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> @@ -45,6 +45,7 @@ struct virtchnl_fdir_fltr_conf {
> struct ice_fdir_fltr input;
> enum ice_fdir_tunnel_type ttype;
> u64 inset_flag;
> + u32 flow_id;
> };
>
> static enum virtchnl_proto_hdr_type vc_pattern_ether[] = { @@ -1527,7
> +1528,7 @@ static int ice_vc_fdir_write_fltr(struct ice_vf *vf,
> }
>
> input->dest_vsi = vsi->idx;
> - input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
> + input->comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;
>
> ctrl_vsi = pf->vsi[vf->ctrl_vsi_idx];
> if (!ctrl_vsi) {
> @@ -1560,6 +1561,455 @@ static int ice_vc_fdir_write_fltr(struct ice_vf *vf, }
>
> /**
> + * ice_vf_fdir_timer - FDIR program waiting timer interrupt handler
> + * @t: pointer to timer_list
> + */
> +static void ice_vf_fdir_timer(struct timer_list *t) {
> + struct ice_vf_fdir_ctx *ctx_irq = from_timer(ctx_irq, t, rx_tmr);
> + struct ice_vf_fdir_ctx *ctx_done;
> + struct ice_vf_fdir *fdir;
> + unsigned long flags;
> + struct ice_vf *vf;
> + struct ice_pf *pf;
> +
> + fdir = container_of(ctx_irq, struct ice_vf_fdir, ctx_irq);
> + vf = container_of(fdir, struct ice_vf, fdir);
> + ctx_done = &fdir->ctx_done;
> + pf = vf->pf;
> + spin_lock_irqsave(&fdir->ctx_lock, flags);
> + if (!(ctx_irq->flags & ICE_VF_FDIR_CTX_VALID)) {
> + spin_unlock_irqrestore(&fdir->ctx_lock, flags);
> + WARN_ON_ONCE(1);
> + return;
> + }
> +
> + ctx_irq->flags &= ~ICE_VF_FDIR_CTX_VALID;
> +
> + ctx_done->flags |= ICE_VF_FDIR_CTX_VALID;
> + ctx_done->conf = ctx_irq->conf;
> + ctx_done->stat = ICE_FDIR_CTX_TIMEOUT;
> + ctx_done->v_opcode = ctx_irq->v_opcode;
> + spin_unlock_irqrestore(&fdir->ctx_lock, flags);
> +
> + set_bit(__ICE_FD_VF_FLUSH_CTX, pf->state);
> + ice_service_task_schedule(pf);
> +}
> +
> +/**
> + * ice_vc_fdir_irq_handler - ctrl_vsi Rx queue interrupt handler
> + * @ctrl_vsi: pointer to a VF's CTRL VSI
> + * @rx_desc: pointer to FDIR Rx queue descriptor */ void
> +ice_vc_fdir_irq_handler(struct ice_vsi *ctrl_vsi,
> + union ice_32b_rx_flex_desc *rx_desc) {
> + struct ice_pf *pf = ctrl_vsi->back;
> + struct ice_vf_fdir_ctx *ctx_done;
> + struct ice_vf_fdir_ctx *ctx_irq;
> + struct ice_vf_fdir *fdir;
> + unsigned long flags;
> + struct device *dev;
> + struct ice_vf *vf;
> + int ret;
> +
> + vf = &pf->vf[ctrl_vsi->vf_id];
> +
> + fdir = &vf->fdir;
> + ctx_done = &fdir->ctx_done;
> + ctx_irq = &fdir->ctx_irq;
> + dev = ice_pf_to_dev(pf);
> + spin_lock_irqsave(&fdir->ctx_lock, flags);
> + if (!(ctx_irq->flags & ICE_VF_FDIR_CTX_VALID)) {
> + spin_unlock_irqrestore(&fdir->ctx_lock, flags);
> + WARN_ON_ONCE(1);
> + return;
> + }
> +
> + ctx_irq->flags &= ~ICE_VF_FDIR_CTX_VALID;
> +
> + ctx_done->flags |= ICE_VF_FDIR_CTX_VALID;
> + ctx_done->conf = ctx_irq->conf;
> + ctx_done->stat = ICE_FDIR_CTX_IRQ;
> + ctx_done->v_opcode = ctx_irq->v_opcode;
> + memcpy(&ctx_done->rx_desc, rx_desc, sizeof(*rx_desc));
> + spin_unlock_irqrestore(&fdir->ctx_lock, flags);
> +
> + ret = del_timer(&ctx_irq->rx_tmr);
> + if (!ret)
> + dev_err(dev, "VF %d: Unexpected inactive timer!\n", vf->vf_id);
> +
> + set_bit(__ICE_FD_VF_FLUSH_CTX, pf->state);
> + ice_service_task_schedule(pf);
> +}
> +
> +/**
> + * ice_vf_fdir_dump_info - dump FDIR information for diagnosis
> + * @vf: pointer to the VF info
> + */
> +static void ice_vf_fdir_dump_info(struct ice_vf *vf) {
> + struct ice_vsi *vf_vsi;
> + u32 fd_size, fd_cnt;
> + struct device *dev;
> + struct ice_pf *pf;
> + struct ice_hw *hw;
> + u16 vsi_num;
> +
> + pf = vf->pf;
> + hw = &pf->hw;
> + dev = ice_pf_to_dev(pf);
> + vf_vsi = pf->vsi[vf->lan_vsi_idx];
> + vsi_num = ice_get_hw_vsi_num(hw, vf_vsi->idx);
> +
> + fd_size = rd32(hw, VSIQF_FD_SIZE(vsi_num));
> + fd_cnt = rd32(hw, VSIQF_FD_CNT(vsi_num));
> + dev_dbg(dev, "VF %d: space allocated: guar:0x%x, be:0x%x, space
> consumed: guar:0x%x, be:0x%x",
> + vf->vf_id,
> + (fd_size & VSIQF_FD_CNT_FD_GCNT_M) >>
> VSIQF_FD_CNT_FD_GCNT_S,
> + (fd_size & VSIQF_FD_CNT_FD_BCNT_M) >>
> VSIQF_FD_CNT_FD_BCNT_S,
> + (fd_cnt & VSIQF_FD_CNT_FD_GCNT_M) >>
> VSIQF_FD_CNT_FD_GCNT_S,
> + (fd_cnt & VSIQF_FD_CNT_FD_BCNT_M) >>
> VSIQF_FD_CNT_FD_BCNT_S); }
> +
> +/**
> + * ice_vf_verify_rx_desc - verify received FDIR programming status
> +descriptor
> + * @vf: pointer to the VF info
> + * @ctx: FDIR context info for post processing
> + * @status: virtchnl FDIR program status
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vf_verify_rx_desc(struct ice_vf *vf, struct ice_vf_fdir_ctx *ctx,
> + enum virtchnl_fdir_prgm_status *status) {
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + u32 stat_err, error, prog_id;
> + int ret;
> +
> + stat_err = le16_to_cpu(ctx->rx_desc.wb.status_error0);
> + if (((stat_err & ICE_FXD_FLTR_WB_QW1_DD_M) >>
> + ICE_FXD_FLTR_WB_QW1_DD_S) !=
> ICE_FXD_FLTR_WB_QW1_DD_YES) {
> + *status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_err(dev, "VF %d: Desc Done not set\n", vf->vf_id);
> + ret = -EINVAL;
> + goto err_exit;
> + }
> +
> + prog_id = (stat_err & ICE_FXD_FLTR_WB_QW1_PROG_ID_M) >>
> + ICE_FXD_FLTR_WB_QW1_PROG_ID_S;
> + if (prog_id == ICE_FXD_FLTR_WB_QW1_PROG_ADD &&
> + ctx->v_opcode != VIRTCHNL_OP_ADD_FDIR_FILTER) {
> + dev_err(dev, "VF %d: Desc show add, but ctx not",
> + vf->vf_id);
> + *status = VIRTCHNL_FDIR_FAILURE_RULE_INVALID;
> + ret = -EINVAL;
> + goto err_exit;
> + }
> +
> + if (prog_id == ICE_FXD_FLTR_WB_QW1_PROG_DEL &&
> + ctx->v_opcode != VIRTCHNL_OP_DEL_FDIR_FILTER) {
> + dev_err(dev, "VF %d: Desc show del, but ctx not",
> + vf->vf_id);
> + *status = VIRTCHNL_FDIR_FAILURE_RULE_INVALID;
> + ret = -EINVAL;
> + goto err_exit;
> + }
> +
> + error = (stat_err & ICE_FXD_FLTR_WB_QW1_FAIL_M) >>
> + ICE_FXD_FLTR_WB_QW1_FAIL_S;
> + if (error == ICE_FXD_FLTR_WB_QW1_FAIL_YES) {
> + if (prog_id == ICE_FXD_FLTR_WB_QW1_PROG_ADD) {
> + dev_err(dev, "VF %d, Failed to add FDIR rule due to no
> space in the table",
> + vf->vf_id);
> + *status =
> VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + } else {
> + dev_err(dev, "VF %d, Failed to remove FDIR rule,
> attempt to remove non-existent entry",
> + vf->vf_id);
> + *status = VIRTCHNL_FDIR_FAILURE_RULE_NONEXIST;
> + }
> + ret = -EINVAL;
> + goto err_exit;
> + }
> +
> + error = (stat_err & ICE_FXD_FLTR_WB_QW1_FAIL_PROF_M) >>
> + ICE_FXD_FLTR_WB_QW1_FAIL_PROF_S;
> + if (error == ICE_FXD_FLTR_WB_QW1_FAIL_PROF_YES) {
> + dev_err(dev, "VF %d: Profile matching error", vf->vf_id);
> + *status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + ret = -EINVAL;
> + goto err_exit;
> + }
> +
> + *status = VIRTCHNL_FDIR_SUCCESS;
> +
> + return 0;
> +
> +err_exit:
> + ice_vf_fdir_dump_info(vf);
> + return ret;
> +}
> +
> +/**
> + * ice_vc_add_fdir_fltr_post
> + * @vf: pointer to the VF structure
> + * @ctx: FDIR context info for post processing
> + * @status: virtchnl FDIR program status
> + * @success: true implies success, false implies failure
> + *
> + * Post process for flow director add command. If success, then do post
> +process
> + * and send back success msg by virtchnl. Otherwise, do context
> +reversion and
> + * send back failure msg by virtchnl.
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_add_fdir_fltr_post(struct ice_vf *vf, struct ice_vf_fdir_ctx *ctx,
> + enum virtchnl_fdir_prgm_status status,
> + bool success)
> +{
> + struct virtchnl_fdir_fltr_conf *conf = ctx->conf;
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + enum virtchnl_status_code v_ret;
> + struct virtchnl_fdir_add *resp;
> + int ret, len, is_tun;
> +
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + len = sizeof(*resp);
> + resp = kzalloc(len, GFP_KERNEL);
> + if (!resp) {
> + len = 0;
> + v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
> + dev_dbg(dev, "VF %d: Alloc resp buf fail", vf->vf_id);
> + goto err_exit;
> + }
> +
> + if (!success)
> + goto err_exit;
> +
> + is_tun = 0;
> + resp->status = status;
> + resp->flow_id = conf->flow_id;
> + vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]++;
> +
> + ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
> + (u8 *)resp, len);
> + kfree(resp);
> +
> + dev_dbg(dev, "VF %d: flow_id:0x%X, FDIR %s success!\n",
> + vf->vf_id, conf->flow_id,
> + (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER) ?
> + "add" : "del");
> + return ret;
> +
> +err_exit:
> + if (resp)
> + resp->status = status;
> + ice_vc_fdir_remove_entry(vf, conf, conf->flow_id);
> + devm_kfree(dev, conf);
> +
> + ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
> + (u8 *)resp, len);
> + kfree(resp);
> + return ret;
> +}
> +
> +/**
> + * ice_vc_del_fdir_fltr_post
> + * @vf: pointer to the VF structure
> + * @ctx: FDIR context info for post processing
> + * @status: virtchnl FDIR program status
> + * @success: true implies success, false implies failure
> + *
> + * Post process for flow director del command. If success, then do post
> +process
> + * and send back success msg by virtchnl. Otherwise, do context
> +reversion and
> + * send back failure msg by virtchnl.
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_del_fdir_fltr_post(struct ice_vf *vf, struct ice_vf_fdir_ctx *ctx,
> + enum virtchnl_fdir_prgm_status status,
> + bool success)
> +{
> + struct virtchnl_fdir_fltr_conf *conf = ctx->conf;
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + enum virtchnl_status_code v_ret;
> + struct virtchnl_fdir_del *resp;
> + int ret, len, is_tun;
> +
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + len = sizeof(*resp);
> + resp = kzalloc(len, GFP_KERNEL);
> + if (!resp) {
> + len = 0;
> + v_ret = VIRTCHNL_STATUS_ERR_NO_MEMORY;
> + dev_dbg(dev, "VF %d: Alloc resp buf fail", vf->vf_id);
> + goto err_exit;
> + }
> +
> + if (!success)
> + goto err_exit;
> +
> + is_tun = 0;
> + resp->status = status;
> + ice_vc_fdir_remove_entry(vf, conf, conf->flow_id);
> + vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]--;
> +
> + ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
> + (u8 *)resp, len);
> + kfree(resp);
> +
> + dev_dbg(dev, "VF %d: flow_id:0x%X, FDIR %s success!\n",
> + vf->vf_id, conf->flow_id,
> + (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER) ?
> + "add" : "del");
> + devm_kfree(dev, conf);
> + return ret;
> +
> +err_exit:
> + if (resp)
> + resp->status = status;
> + if (success)
> + devm_kfree(dev, conf);
> +
> + ret = ice_vc_send_msg_to_vf(vf, ctx->v_opcode, v_ret,
> + (u8 *)resp, len);
> + kfree(resp);
> + return ret;
> +}
> +
> +/**
> + * ice_flush_fdir_ctx
> + * @pf: pointer to the PF structure
> + *
> + * Flush all the pending event on ctx_done list and process them.
> + */
> +void ice_flush_fdir_ctx(struct ice_pf *pf) {
> + int i;
> +
> + if (!test_and_clear_bit(__ICE_FD_VF_FLUSH_CTX, pf->state))
> + return;
> +
> + ice_for_each_vf(pf, i) {
> + struct device *dev = ice_pf_to_dev(pf);
> + enum virtchnl_fdir_prgm_status status;
> + struct ice_vf *vf = &pf->vf[i];
> + struct ice_vf_fdir_ctx *ctx;
> + unsigned long flags;
> + int ret;
> +
> + if (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states))
> + continue;
> +
> + if (vf->ctrl_vsi_idx == ICE_NO_VSI)
> + continue;
> +
> + ctx = &vf->fdir.ctx_done;
> + spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
> + if (!(ctx->flags & ICE_VF_FDIR_CTX_VALID)) {
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
> + continue;
> + }
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
> +
> + WARN_ON(ctx->stat == ICE_FDIR_CTX_READY);
> + if (ctx->stat == ICE_FDIR_CTX_TIMEOUT) {
> + status = VIRTCHNL_FDIR_FAILURE_RULE_TIMEOUT;
> + dev_err(dev, "VF %d: ctrl_vsi irq timeout\n",
> + vf->vf_id);
> + goto err_exit;
> + }
> +
> + ret = ice_vf_verify_rx_desc(vf, ctx, &status);
> + if (ret)
> + goto err_exit;
> +
> + if (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER)
> + ice_vc_add_fdir_fltr_post(vf, ctx, status, true);
> + else if (ctx->v_opcode == VIRTCHNL_OP_DEL_FDIR_FILTER)
> + ice_vc_del_fdir_fltr_post(vf, ctx, status, true);
> + else
> + dev_err(dev, "VF %d: Unsupported opcode\n", vf-
> >vf_id);
> +
> + spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
> + ctx->flags &= ~ICE_VF_FDIR_CTX_VALID;
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
> + continue;
> +err_exit:
> + if (ctx->v_opcode == VIRTCHNL_OP_ADD_FDIR_FILTER)
> + ice_vc_add_fdir_fltr_post(vf, ctx, status, false);
> + else if (ctx->v_opcode == VIRTCHNL_OP_DEL_FDIR_FILTER)
> + ice_vc_del_fdir_fltr_post(vf, ctx, status, false);
> + else
> + dev_err(dev, "VF %d: Unsupported opcode\n", vf-
> >vf_id);
> +
> + spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
> + ctx->flags &= ~ICE_VF_FDIR_CTX_VALID;
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
> + }
> +}
> +
> +/**
> + * ice_vc_fdir_set_irq_ctx - set FDIR context info for later irq
> +handler
> + * @vf: pointer to the VF structure
> + * @conf: FDIR configuration for each filter
> + * @v_opcode: virtual channel operation code
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static int
> +ice_vc_fdir_set_irq_ctx(struct ice_vf *vf, struct virtchnl_fdir_fltr_conf *conf,
> + enum virtchnl_ops v_opcode)
> +{
> + struct device *dev = ice_pf_to_dev(vf->pf);
> + struct ice_vf_fdir_ctx *ctx;
> + unsigned long flags;
> +
> + ctx = &vf->fdir.ctx_irq;
> + spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
> + if ((vf->fdir.ctx_irq.flags & ICE_VF_FDIR_CTX_VALID) ||
> + (vf->fdir.ctx_done.flags & ICE_VF_FDIR_CTX_VALID)) {
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
> + dev_dbg(dev, "VF %d: Last request is still in progress\n",
> + vf->vf_id);
> + return -EBUSY;
> + }
> + ctx->flags |= ICE_VF_FDIR_CTX_VALID;
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags);
> +
> + ctx->conf = conf;
> + ctx->v_opcode = v_opcode;
> + ctx->stat = ICE_FDIR_CTX_READY;
> + timer_setup(&ctx->rx_tmr, ice_vf_fdir_timer, 0);
> +
> + mod_timer(&ctx->rx_tmr,
> + round_jiffies(msecs_to_jiffies(10) + jiffies));
> +
> + return 0;
> +}
> +
> +/**
> + * ice_vc_fdir_clear_irq_ctx - clear FDIR context info for irq handler
> + * @vf: pointer to the VF structure
> + *
> + * Return: 0 on success, and other on error.
> + */
> +static void ice_vc_fdir_clear_irq_ctx(struct ice_vf *vf) {
> + struct ice_vf_fdir_ctx *ctx = &vf->fdir.ctx_irq;
> + unsigned long flags;
> +
> + del_timer(&ctx->rx_tmr);
> + spin_lock_irqsave(&vf->fdir.ctx_lock, flags);
> + ctx->flags &= ~ICE_VF_FDIR_CTX_VALID;
> + spin_unlock_irqrestore(&vf->fdir.ctx_lock, flags); }
> +
> +/**
> * ice_vc_add_fdir_fltr - add a FDIR filter for VF by the msg buffer
> * @vf: pointer to the VF info
> * @msg: pointer to the msg buffer
> @@ -1645,7 +2095,7 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
> goto err_free_conf;
> }
>
> - ret = ice_vc_fdir_insert_entry(vf, conf, &stat->flow_id);
> + ret = ice_vc_fdir_insert_entry(vf, conf, &conf->flow_id);
> if (ret) {
> v_ret = VIRTCHNL_STATUS_SUCCESS;
> stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> @@ -1653,6 +2103,14 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
> goto err_free_conf;
> }
>
> + ret = ice_vc_fdir_set_irq_ctx(vf, conf,
> VIRTCHNL_OP_ADD_FDIR_FILTER);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_dbg(dev, "VF %d: set FDIR context failed\n", vf->vf_id);
> + goto err_free_conf;
> + }
> +
> ret = ice_vc_fdir_write_fltr(vf, conf, true, is_tun);
> if (ret) {
> v_ret = VIRTCHNL_STATUS_SUCCESS;
> @@ -1662,18 +2120,13 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)
> goto err_rem_entry;
> }
>
> - vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]++;
> -
> - v_ret = VIRTCHNL_STATUS_SUCCESS;
> - stat->status = VIRTCHNL_FDIR_SUCCESS;
> exit:
> - ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_ADD_FDIR_FILTER,
> v_ret,
> - (u8 *)stat, len);
> kfree(stat);
> return ret;
>
> err_rem_entry:
> - ice_vc_fdir_remove_entry(vf, conf, stat->flow_id);
> + ice_vc_fdir_clear_irq_ctx(vf);
> + ice_vc_fdir_remove_entry(vf, conf, conf->flow_id);
> err_free_conf:
> devm_kfree(dev, conf);
> err_exit:
> @@ -1737,22 +2190,29 @@ int ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg)
> goto err_exit;
> }
>
> + ret = ice_vc_fdir_set_irq_ctx(vf, conf,
> VIRTCHNL_OP_DEL_FDIR_FILTER);
> + if (ret) {
> + v_ret = VIRTCHNL_STATUS_SUCCESS;
> + stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> + dev_dbg(dev, "VF %d: set FDIR context failed\n", vf->vf_id);
> + goto err_exit;
> + }
> +
> ret = ice_vc_fdir_write_fltr(vf, conf, false, is_tun);
> if (ret) {
> v_ret = VIRTCHNL_STATUS_SUCCESS;
> stat->status = VIRTCHNL_FDIR_FAILURE_RULE_NORESOURCE;
> dev_err(dev, "VF %d: writing FDIR rule failed, ret:%d\n",
> vf->vf_id, ret);
> - goto err_exit;
> + goto err_del_tmr;
> }
>
> - ice_vc_fdir_remove_entry(vf, conf, fltr->flow_id);
> - devm_kfree(dev, conf);
> - vf->fdir.fdir_fltr_cnt[conf->input.flow_type][is_tun]--;
> + kfree(stat);
>
> - v_ret = VIRTCHNL_STATUS_SUCCESS;
> - stat->status = VIRTCHNL_FDIR_SUCCESS;
> + return ret;
>
> +err_del_tmr:
> + ice_vc_fdir_clear_irq_ctx(vf);
> err_exit:
> ret = ice_vc_send_msg_to_vf(vf, VIRTCHNL_OP_DEL_FDIR_FILTER,
> v_ret,
> (u8 *)stat, len);
> @@ -1770,6 +2230,10 @@ void ice_vf_fdir_init(struct ice_vf *vf)
>
> idr_init(&fdir->fdir_rule_idr);
> INIT_LIST_HEAD(&fdir->fdir_rule_list);
> +
> + spin_lock_init(&fdir->ctx_lock);
> + fdir->ctx_irq.flags = 0;
> + fdir->ctx_done.flags = 0;
> }
>
> /**
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> index 676de402475e..53b78e866381 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
> @@ -5,6 +5,24 @@
> #define _ICE_VIRTCHNL_FDIR_H_
>
> struct ice_vf;
> +struct ice_pf;
> +
> +enum ice_fdir_ctx_stat {
> + ICE_FDIR_CTX_READY,
> + ICE_FDIR_CTX_IRQ,
> + ICE_FDIR_CTX_TIMEOUT,
> +};
> +
> +struct ice_vf_fdir_ctx {
> + struct timer_list rx_tmr;
> + enum virtchnl_ops v_opcode;
> + enum ice_fdir_ctx_stat stat;
> + union ice_32b_rx_flex_desc rx_desc;
> +#define ICE_VF_FDIR_CTX_VALID BIT(0)
> + u32 flags;
> +
> + void *conf;
> +};
>
> /* VF FDIR information structure */
> struct ice_vf_fdir {
> @@ -14,11 +32,18 @@ struct ice_vf_fdir {
>
> struct idr fdir_rule_idr;
> struct list_head fdir_rule_list;
> +
> + spinlock_t ctx_lock; /* protects FDIR context info */
> + struct ice_vf_fdir_ctx ctx_irq;
> + struct ice_vf_fdir_ctx ctx_done;
> };
>
> int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg); int
> ice_vc_del_fdir_fltr(struct ice_vf *vf, u8 *msg); void ice_vf_fdir_init(struct
> ice_vf *vf); void ice_vf_fdir_exit(struct ice_vf *vf);
> -
> +void
> +ice_vc_fdir_irq_handler(struct ice_vsi *ctrl_vsi,
> + union ice_32b_rx_flex_desc *rx_desc); void
> ice_flush_fdir_ctx(struct
> +ice_pf *pf);
> #endif /* _ICE_VIRTCHNL_FDIR_H_ */
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread
* [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features
2020-07-02 22:57 [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features Qi Zhang
` (13 preceding siblings ...)
2020-07-02 22:58 ` [Intel-wired-lan] [PATCH S48 v3 14/14] ice: Check FDIR program status " Qi Zhang
@ 2020-07-03 5:55 ` Kirsher, Jeffrey T
14 siblings, 0 replies; 31+ messages in thread
From: Kirsher, Jeffrey T @ 2020-07-03 5:55 UTC (permalink / raw)
To: intel-wired-lan
I was able to do a preliminary review, there were definitely wrapping issues, which I commented on. I also found some code was indented with spaces and tabs. I also found that some defines names were grossly too long and had redundant info in the name. Most of the patches were reasonable size and easy to review EXCEPT for patch 10, which needs to be broken up.
TODO:
- A more in depth review of the actual code and what is being done
- Review of all defines to ensure the actual name makes sense (reduce in size/length where possible)
- Run checkpatch.pl on these patches
- And of course, the typical upstream testing/review
- Break up patch 10 into 2 or 3 patches to ease future review
I have done what I can, I am now "officially" on sabbatical... See you in September
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Qi
> Zhang
> Sent: Thursday, July 2, 2020 15:58
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [Intel-wired-lan] [PATCH S48 v3 00/14] Support Advanced AVF features
>
> The patchset add the backend code for below new advanced AVF features:
> 1. Flexible Description selection to offload metadata 2. FDIR filter rule adding /
> deleting.
> 3. Per flow configurable inputset RSS
> besides support regular l3/l4 5 tuple inputset for FDIR and RSS, the patchset
> added more protocol support which include GTP-U, L2TPv3, PFCF, ESP, AH...
>
> v3:
> - fix couple coding style issue and typo
> - use devm alloc/free for cross function memory
> - squash patch 11/16 , 12/16 into 10/16.
>
> v2:
> - fix typo in commit log.
>
> Qi Zhang (14):
> ice: Enable flexible descriptor RXDID querying and configuration
> ice: Add more basic protocol support for flow filter
> ice: Support non word aligned input set field
> ice: Add more advanced protocol support in flow filter
> ice: Support to separate GTP-U uplink and downlink
> ice: enhanced IPV4 and IPV6 flow filter
> ice: Enable RSS Configure for AVF
> ice: Support RSS configure removal for AVF
> ice: Add support for per VF ctrl VSI enabling
> ice: Support FDIR configure for AVF
> ice: Add non-IP Layer2 protocol FDIR filter for AVF
> ice: Add GTPU FDIR filter for AVF
> ice: Add more FDIR filter type for AVF
> ice: Check FDIR program status for AVF
>
> drivers/net/ethernet/intel/ice/Makefile | 2 +-
> drivers/net/ethernet/intel/ice/ice.h | 6 +-
> drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 4 +
> drivers/net/ethernet/intel/ice/ice_fdir.c | 29 +-
> drivers/net/ethernet/intel/ice/ice_fdir.h | 39 +
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 524 ++++-
> drivers/net/ethernet/intel/ice/ice_flex_pipe.h | 3 +-
> drivers/net/ethernet/intel/ice/ice_flex_type.h | 78 +
> drivers/net/ethernet/intel/ice/ice_flow.c | 890 +++++++-
> drivers/net/ethernet/intel/ice/ice_flow.h | 168 +-
> drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 22 +
> drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 22 +
> drivers/net/ethernet/intel/ice/ice_lib.c | 64 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 11 +-
> drivers/net/ethernet/intel/ice/ice_protocol_type.h | 10 +
> drivers/net/ethernet/intel/ice/ice_txrx.c | 5 +
> drivers/net/ethernet/intel/ice/ice_type.h | 18 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 2249
> ++++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h | 49 +
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 660 +++++-
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 11 +
> include/linux/avf/virtchnl.h | 324 ++-
> 22 files changed, 5104 insertions(+), 84 deletions(-) create mode 100644
> drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.h
>
> --
> 2.13.6
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 31+ messages in thread