* [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:01 ` Wan Jiabing
0 siblings, 0 replies; 20+ messages in thread
From: Wan Jiabing @ 2022-05-10 8:01 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Matthias Brugger,
AngeloGioacchino Del Regno, Rex-BC Chen, Andrew-sh.Cheng,
Jia-Wei Chang, linux-pm, linux-kernel, linux-arm-kernel,
linux-mediatek
Cc: Wan Jiabing
Fix following coccichek error:
./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
mutex_lock is acquired but not released before return.
Use 'goto out' to help releasing the mutex_lock.
Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 75bf21ddf61f..4c6d53c99d79 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
if (pre_vproc < 0) {
dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
- return pre_vproc;
+ ret = pre_vproc;
+ goto out;
}
freq_hz = freq_table[index].frequency * 1000;
@@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
if (IS_ERR(opp)) {
dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
policy->cpu, freq_hz);
- return PTR_ERR(opp);
+ ret = PTR_ERR(opp);
+ goto out;
}
vproc = dev_pm_opp_get_voltage(opp);
dev_pm_opp_put(opp);
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:01 ` Wan Jiabing
0 siblings, 0 replies; 20+ messages in thread
From: Wan Jiabing @ 2022-05-10 8:01 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Matthias Brugger,
AngeloGioacchino Del Regno, Rex-BC Chen, Andrew-sh.Cheng,
Jia-Wei Chang, linux-pm, linux-kernel, linux-arm-kernel,
linux-mediatek
Cc: Wan Jiabing
Fix following coccichek error:
./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
mutex_lock is acquired but not released before return.
Use 'goto out' to help releasing the mutex_lock.
Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 75bf21ddf61f..4c6d53c99d79 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
if (pre_vproc < 0) {
dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
- return pre_vproc;
+ ret = pre_vproc;
+ goto out;
}
freq_hz = freq_table[index].frequency * 1000;
@@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
if (IS_ERR(opp)) {
dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
policy->cpu, freq_hz);
- return PTR_ERR(opp);
+ ret = PTR_ERR(opp);
+ goto out;
}
vproc = dev_pm_opp_get_voltage(opp);
dev_pm_opp_put(opp);
--
2.35.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:01 ` Wan Jiabing
0 siblings, 0 replies; 20+ messages in thread
From: Wan Jiabing @ 2022-05-10 8:01 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Matthias Brugger,
AngeloGioacchino Del Regno, Rex-BC Chen, Andrew-sh.Cheng,
Jia-Wei Chang, linux-pm, linux-kernel, linux-arm-kernel,
linux-mediatek
Cc: Wan Jiabing
Fix following coccichek error:
./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
mutex_lock is acquired but not released before return.
Use 'goto out' to help releasing the mutex_lock.
Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 75bf21ddf61f..4c6d53c99d79 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
if (pre_vproc < 0) {
dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
- return pre_vproc;
+ ret = pre_vproc;
+ goto out;
}
freq_hz = freq_table[index].frequency * 1000;
@@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
if (IS_ERR(opp)) {
dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
policy->cpu, freq_hz);
- return PTR_ERR(opp);
+ ret = PTR_ERR(opp);
+ goto out;
}
vproc = dev_pm_opp_get_voltage(opp);
dev_pm_opp_put(opp);
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
2022-05-10 8:01 ` Wan Jiabing
@ 2022-05-10 8:09 ` Rex-BC Chen
-1 siblings, 0 replies; 20+ messages in thread
From: Rex-BC Chen @ 2022-05-10 8:09 UTC (permalink / raw)
To: Wan Jiabing, Rafael J. Wysocki, Viresh Kumar, Matthias Brugger,
AngeloGioacchino Del Regno, Andrew-sh.Cheng, Jia-Wei Chang,
linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek
On Tue, 2022-05-10 at 16:01 +0800, Wan Jiabing wrote:
> Fix following coccichek error:
> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>
> mutex_lock is acquired but not released before return.
> Use 'goto out' to help releasing the mutex_lock.
>
> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification
> support")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c
> b/drivers/cpufreq/mediatek-cpufreq.c
> index 75bf21ddf61f..4c6d53c99d79 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct
> cpufreq_policy *policy,
>
> if (pre_vproc < 0) {
> dev_err(cpu_dev, "invalid Vproc value: %d\n",
> pre_vproc);
> - return pre_vproc;
> + ret = pre_vproc;
> + goto out;
> }
>
> freq_hz = freq_table[index].frequency * 1000;
> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct
> cpufreq_policy *policy,
> if (IS_ERR(opp)) {
> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
> policy->cpu, freq_hz);
> - return PTR_ERR(opp);
> + ret = PTR_ERR(opp);
> + goto out;
> }
> vproc = dev_pm_opp_get_voltage(opp);
> dev_pm_opp_put(opp);
Hello Wan,
Thanks for checking this issue.
I did not notice this issue when I am asked to move the mutex lock here
in my patch.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:09 ` Rex-BC Chen
0 siblings, 0 replies; 20+ messages in thread
From: Rex-BC Chen @ 2022-05-10 8:09 UTC (permalink / raw)
To: Wan Jiabing, Rafael J. Wysocki, Viresh Kumar, Matthias Brugger,
AngeloGioacchino Del Regno, Andrew-sh.Cheng, Jia-Wei Chang,
linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek
On Tue, 2022-05-10 at 16:01 +0800, Wan Jiabing wrote:
> Fix following coccichek error:
> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>
> mutex_lock is acquired but not released before return.
> Use 'goto out' to help releasing the mutex_lock.
>
> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification
> support")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c
> b/drivers/cpufreq/mediatek-cpufreq.c
> index 75bf21ddf61f..4c6d53c99d79 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct
> cpufreq_policy *policy,
>
> if (pre_vproc < 0) {
> dev_err(cpu_dev, "invalid Vproc value: %d\n",
> pre_vproc);
> - return pre_vproc;
> + ret = pre_vproc;
> + goto out;
> }
>
> freq_hz = freq_table[index].frequency * 1000;
> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct
> cpufreq_policy *policy,
> if (IS_ERR(opp)) {
> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
> policy->cpu, freq_hz);
> - return PTR_ERR(opp);
> + ret = PTR_ERR(opp);
> + goto out;
> }
> vproc = dev_pm_opp_get_voltage(opp);
> dev_pm_opp_put(opp);
Hello Wan,
Thanks for checking this issue.
I did not notice this issue when I am asked to move the mutex lock here
in my patch.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
2022-05-10 8:01 ` Wan Jiabing
(?)
@ 2022-05-10 8:12 ` Viresh Kumar
-1 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 8:12 UTC (permalink / raw)
To: Wan Jiabing
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:01, Wan Jiabing wrote:
> Fix following coccichek error:
> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>
> mutex_lock is acquired but not released before return.
> Use 'goto out' to help releasing the mutex_lock.
>
> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
cupful ??
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 75bf21ddf61f..4c6d53c99d79 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>
> if (pre_vproc < 0) {
> dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
> - return pre_vproc;
> + ret = pre_vproc;
> + goto out;
> }
>
> freq_hz = freq_table[index].frequency * 1000;
> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
> if (IS_ERR(opp)) {
> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
> policy->cpu, freq_hz);
> - return PTR_ERR(opp);
> + ret = PTR_ERR(opp);
> + goto out;
> }
> vproc = dev_pm_opp_get_voltage(opp);
> dev_pm_opp_put(opp);
> --
> 2.35.1
--
viresh
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:12 ` Viresh Kumar
0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 8:12 UTC (permalink / raw)
To: Wan Jiabing
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:01, Wan Jiabing wrote:
> Fix following coccichek error:
> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>
> mutex_lock is acquired but not released before return.
> Use 'goto out' to help releasing the mutex_lock.
>
> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
cupful ??
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 75bf21ddf61f..4c6d53c99d79 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>
> if (pre_vproc < 0) {
> dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
> - return pre_vproc;
> + ret = pre_vproc;
> + goto out;
> }
>
> freq_hz = freq_table[index].frequency * 1000;
> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
> if (IS_ERR(opp)) {
> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
> policy->cpu, freq_hz);
> - return PTR_ERR(opp);
> + ret = PTR_ERR(opp);
> + goto out;
> }
> vproc = dev_pm_opp_get_voltage(opp);
> dev_pm_opp_put(opp);
> --
> 2.35.1
--
viresh
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:12 ` Viresh Kumar
0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 8:12 UTC (permalink / raw)
To: Wan Jiabing
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:01, Wan Jiabing wrote:
> Fix following coccichek error:
> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>
> mutex_lock is acquired but not released before return.
> Use 'goto out' to help releasing the mutex_lock.
>
> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
cupful ??
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 75bf21ddf61f..4c6d53c99d79 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>
> if (pre_vproc < 0) {
> dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
> - return pre_vproc;
> + ret = pre_vproc;
> + goto out;
> }
>
> freq_hz = freq_table[index].frequency * 1000;
> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
> if (IS_ERR(opp)) {
> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
> policy->cpu, freq_hz);
> - return PTR_ERR(opp);
> + ret = PTR_ERR(opp);
> + goto out;
> }
> vproc = dev_pm_opp_get_voltage(opp);
> dev_pm_opp_put(opp);
> --
> 2.35.1
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
2022-05-10 8:12 ` Viresh Kumar
(?)
@ 2022-05-10 8:26 ` Jiabing Wan
-1 siblings, 0 replies; 20+ messages in thread
From: Jiabing Wan @ 2022-05-10 8:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
Hi, Viresh Kumar
On 2022/5/10 16:12, Viresh Kumar wrote:
> On 10-05-22, 16:01, Wan Jiabing wrote:
>> Fix following coccichek error:
>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>
>> mutex_lock is acquired but not released before return.
>> Use 'goto out' to help releasing the mutex_lock.
>>
>> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> cupful ??
Sorry for the typo...
By the way, is this patch correct?
I am not sure whether it should return with the mutex_lock.
But IMO, it should release the lock before return.
If correct, I'll fix this typo in v2.
Thanks,
Wan Jiabing
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
>> index 75bf21ddf61f..4c6d53c99d79 100644
>> --- a/drivers/cpufreq/mediatek-cpufreq.c
>> +++ b/drivers/cpufreq/mediatek-cpufreq.c
>> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>>
>> if (pre_vproc < 0) {
>> dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
>> - return pre_vproc;
>> + ret = pre_vproc;
>> + goto out;
>> }
>>
>> freq_hz = freq_table[index].frequency * 1000;
>> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>> if (IS_ERR(opp)) {
>> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
>> policy->cpu, freq_hz);
>> - return PTR_ERR(opp);
>> + ret = PTR_ERR(opp);
>> + goto out;
>> }
>> vproc = dev_pm_opp_get_voltage(opp);
>> dev_pm_opp_put(opp);
>> --
>> 2.35.1
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:26 ` Jiabing Wan
0 siblings, 0 replies; 20+ messages in thread
From: Jiabing Wan @ 2022-05-10 8:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
Hi, Viresh Kumar
On 2022/5/10 16:12, Viresh Kumar wrote:
> On 10-05-22, 16:01, Wan Jiabing wrote:
>> Fix following coccichek error:
>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>
>> mutex_lock is acquired but not released before return.
>> Use 'goto out' to help releasing the mutex_lock.
>>
>> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> cupful ??
Sorry for the typo...
By the way, is this patch correct?
I am not sure whether it should return with the mutex_lock.
But IMO, it should release the lock before return.
If correct, I'll fix this typo in v2.
Thanks,
Wan Jiabing
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
>> index 75bf21ddf61f..4c6d53c99d79 100644
>> --- a/drivers/cpufreq/mediatek-cpufreq.c
>> +++ b/drivers/cpufreq/mediatek-cpufreq.c
>> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>>
>> if (pre_vproc < 0) {
>> dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
>> - return pre_vproc;
>> + ret = pre_vproc;
>> + goto out;
>> }
>>
>> freq_hz = freq_table[index].frequency * 1000;
>> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>> if (IS_ERR(opp)) {
>> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
>> policy->cpu, freq_hz);
>> - return PTR_ERR(opp);
>> + ret = PTR_ERR(opp);
>> + goto out;
>> }
>> vproc = dev_pm_opp_get_voltage(opp);
>> dev_pm_opp_put(opp);
>> --
>> 2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:26 ` Jiabing Wan
0 siblings, 0 replies; 20+ messages in thread
From: Jiabing Wan @ 2022-05-10 8:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
Hi, Viresh Kumar
On 2022/5/10 16:12, Viresh Kumar wrote:
> On 10-05-22, 16:01, Wan Jiabing wrote:
>> Fix following coccichek error:
>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>
>> mutex_lock is acquired but not released before return.
>> Use 'goto out' to help releasing the mutex_lock.
>>
>> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> cupful ??
Sorry for the typo...
By the way, is this patch correct?
I am not sure whether it should return with the mutex_lock.
But IMO, it should release the lock before return.
If correct, I'll fix this typo in v2.
Thanks,
Wan Jiabing
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> drivers/cpufreq/mediatek-cpufreq.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
>> index 75bf21ddf61f..4c6d53c99d79 100644
>> --- a/drivers/cpufreq/mediatek-cpufreq.c
>> +++ b/drivers/cpufreq/mediatek-cpufreq.c
>> @@ -196,7 +196,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>>
>> if (pre_vproc < 0) {
>> dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
>> - return pre_vproc;
>> + ret = pre_vproc;
>> + goto out;
>> }
>>
>> freq_hz = freq_table[index].frequency * 1000;
>> @@ -205,7 +206,8 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
>> if (IS_ERR(opp)) {
>> dev_err(cpu_dev, "cpu%d: failed to find OPP for %ld\n",
>> policy->cpu, freq_hz);
>> - return PTR_ERR(opp);
>> + ret = PTR_ERR(opp);
>> + goto out;
>> }
>> vproc = dev_pm_opp_get_voltage(opp);
>> dev_pm_opp_put(opp);
>> --
>> 2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
2022-05-10 8:26 ` Jiabing Wan
(?)
@ 2022-05-10 8:50 ` Viresh Kumar
-1 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 8:50 UTC (permalink / raw)
To: Jiabing Wan
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:26, Jiabing Wan wrote:
> Hi, Viresh Kumar
>
> On 2022/5/10 16:12, Viresh Kumar wrote:
> > On 10-05-22, 16:01, Wan Jiabing wrote:
> > > Fix following coccichek error:
> > > ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> > > ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
> > >
> > > mutex_lock is acquired but not released before return.
> > > Use 'goto out' to help releasing the mutex_lock.
> > >
> > > Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> > cupful ??
>
> Sorry for the typo...
Did you write this line by hand or generate it with Git ? There shouldn't be a
typo here.
> By the way, is this patch correct?
>
> I am not sure whether it should return with the mutex_lock.
> But IMO, it should release the lock before return.
Yes, we need to release the lock.
--
viresh
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:50 ` Viresh Kumar
0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 8:50 UTC (permalink / raw)
To: Jiabing Wan
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:26, Jiabing Wan wrote:
> Hi, Viresh Kumar
>
> On 2022/5/10 16:12, Viresh Kumar wrote:
> > On 10-05-22, 16:01, Wan Jiabing wrote:
> > > Fix following coccichek error:
> > > ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> > > ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
> > >
> > > mutex_lock is acquired but not released before return.
> > > Use 'goto out' to help releasing the mutex_lock.
> > >
> > > Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> > cupful ??
>
> Sorry for the typo...
Did you write this line by hand or generate it with Git ? There shouldn't be a
typo here.
> By the way, is this patch correct?
>
> I am not sure whether it should return with the mutex_lock.
> But IMO, it should release the lock before return.
Yes, we need to release the lock.
--
viresh
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:50 ` Viresh Kumar
0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 8:50 UTC (permalink / raw)
To: Jiabing Wan
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:26, Jiabing Wan wrote:
> Hi, Viresh Kumar
>
> On 2022/5/10 16:12, Viresh Kumar wrote:
> > On 10-05-22, 16:01, Wan Jiabing wrote:
> > > Fix following coccichek error:
> > > ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> > > ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
> > >
> > > mutex_lock is acquired but not released before return.
> > > Use 'goto out' to help releasing the mutex_lock.
> > >
> > > Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> > cupful ??
>
> Sorry for the typo...
Did you write this line by hand or generate it with Git ? There shouldn't be a
typo here.
> By the way, is this patch correct?
>
> I am not sure whether it should return with the mutex_lock.
> But IMO, it should release the lock before return.
Yes, we need to release the lock.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
2022-05-10 8:50 ` Viresh Kumar
(?)
@ 2022-05-10 8:58 ` Jiabing Wan
-1 siblings, 0 replies; 20+ messages in thread
From: Jiabing Wan @ 2022-05-10 8:58 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 2022/5/10 16:50, Viresh Kumar wrote:
> On 10-05-22, 16:26, Jiabing Wan wrote:
>> Hi, Viresh Kumar
>>
>> On 2022/5/10 16:12, Viresh Kumar wrote:
>>> On 10-05-22, 16:01, Wan Jiabing wrote:
>>>> Fix following coccichek error:
>>>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>>>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>>>
>>>> mutex_lock is acquired but not released before return.
>>>> Use 'goto out' to help releasing the mutex_lock.
>>>>
>>>> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
>>> cupful ??
>> Sorry for the typo...
> Did you write this line by hand or generate it with Git ? There shouldn't be a
> typo here.
Yes, I write this line by hand.
There must be something wrong when copying the subject line.
Maybe I should find some tools in git to avoid it in the future.
>> By the way, is this patch correct?
>>
>> I am not sure whether it should return with the mutex_lock.
>> But IMO, it should release the lock before return.
> Yes, we need to release the lock.
OK, I'll fix it in v2.
Thanks,
Wan Jiabing
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:58 ` Jiabing Wan
0 siblings, 0 replies; 20+ messages in thread
From: Jiabing Wan @ 2022-05-10 8:58 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 2022/5/10 16:50, Viresh Kumar wrote:
> On 10-05-22, 16:26, Jiabing Wan wrote:
>> Hi, Viresh Kumar
>>
>> On 2022/5/10 16:12, Viresh Kumar wrote:
>>> On 10-05-22, 16:01, Wan Jiabing wrote:
>>>> Fix following coccichek error:
>>>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>>>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>>>
>>>> mutex_lock is acquired but not released before return.
>>>> Use 'goto out' to help releasing the mutex_lock.
>>>>
>>>> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
>>> cupful ??
>> Sorry for the typo...
> Did you write this line by hand or generate it with Git ? There shouldn't be a
> typo here.
Yes, I write this line by hand.
There must be something wrong when copying the subject line.
Maybe I should find some tools in git to avoid it in the future.
>> By the way, is this patch correct?
>>
>> I am not sure whether it should return with the mutex_lock.
>> But IMO, it should release the lock before return.
> Yes, we need to release the lock.
OK, I'll fix it in v2.
Thanks,
Wan Jiabing
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 8:58 ` Jiabing Wan
0 siblings, 0 replies; 20+ messages in thread
From: Jiabing Wan @ 2022-05-10 8:58 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 2022/5/10 16:50, Viresh Kumar wrote:
> On 10-05-22, 16:26, Jiabing Wan wrote:
>> Hi, Viresh Kumar
>>
>> On 2022/5/10 16:12, Viresh Kumar wrote:
>>> On 10-05-22, 16:01, Wan Jiabing wrote:
>>>> Fix following coccichek error:
>>>> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
>>>> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
>>>>
>>>> mutex_lock is acquired but not released before return.
>>>> Use 'goto out' to help releasing the mutex_lock.
>>>>
>>>> Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
>>> cupful ??
>> Sorry for the typo...
> Did you write this line by hand or generate it with Git ? There shouldn't be a
> typo here.
Yes, I write this line by hand.
There must be something wrong when copying the subject line.
Maybe I should find some tools in git to avoid it in the future.
>> By the way, is this patch correct?
>>
>> I am not sure whether it should return with the mutex_lock.
>> But IMO, it should release the lock before return.
> Yes, we need to release the lock.
OK, I'll fix it in v2.
Thanks,
Wan Jiabing
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
2022-05-10 8:58 ` Jiabing Wan
(?)
@ 2022-05-10 9:09 ` Viresh Kumar
-1 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 9:09 UTC (permalink / raw)
To: Jiabing Wan
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:58, Jiabing Wan wrote:
> Yes, I write this line by hand.
> There must be something wrong when copying the subject line.
>
> Maybe I should find some tools in git to avoid it in the future.
Add this to ~/.gitconfig
[pretty]
fixes = Fixes: %h (\"%s\")
And then just do:
$ git log --pretty=fixes c210063b40ac
It shall give you:
Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support")
Fixes: 6a17b3876bc8 ("cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking()")
Fixes: ead858bd128d ("cpufreq: mediatek: Move voltage limits to platform data")
Fixes: f126fbadce92 ("cpufreq: mediatek: Unregister platform device on exit")
Fixes: a3b8d1b12c6b ("cpufreq: mediatek: Fix NULL pointer dereference in mediatek-cpufreq")
Fixes: ffa7bdf7f344 ("cpufreq: mediatek: Make sram regulator optional")
and other patches as we did git log.
OR
Else you could do something like this to just see one commit:
$ git show -s --pretty=oneline --pretty=fixes c210063b40ac
--
viresh
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 9:09 ` Viresh Kumar
0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 9:09 UTC (permalink / raw)
To: Jiabing Wan
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:58, Jiabing Wan wrote:
> Yes, I write this line by hand.
> There must be something wrong when copying the subject line.
>
> Maybe I should find some tools in git to avoid it in the future.
Add this to ~/.gitconfig
[pretty]
fixes = Fixes: %h (\"%s\")
And then just do:
$ git log --pretty=fixes c210063b40ac
It shall give you:
Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support")
Fixes: 6a17b3876bc8 ("cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking()")
Fixes: ead858bd128d ("cpufreq: mediatek: Move voltage limits to platform data")
Fixes: f126fbadce92 ("cpufreq: mediatek: Unregister platform device on exit")
Fixes: a3b8d1b12c6b ("cpufreq: mediatek: Fix NULL pointer dereference in mediatek-cpufreq")
Fixes: ffa7bdf7f344 ("cpufreq: mediatek: Make sram regulator optional")
and other patches as we did git log.
OR
Else you could do something like this to just see one commit:
$ git show -s --pretty=oneline --pretty=fixes c210063b40ac
--
viresh
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target
@ 2022-05-10 9:09 ` Viresh Kumar
0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2022-05-10 9:09 UTC (permalink / raw)
To: Jiabing Wan
Cc: Rafael J. Wysocki, Matthias Brugger, AngeloGioacchino Del Regno,
Rex-BC Chen, Andrew-sh.Cheng, Jia-Wei Chang, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On 10-05-22, 16:58, Jiabing Wan wrote:
> Yes, I write this line by hand.
> There must be something wrong when copying the subject line.
>
> Maybe I should find some tools in git to avoid it in the future.
Add this to ~/.gitconfig
[pretty]
fixes = Fixes: %h (\"%s\")
And then just do:
$ git log --pretty=fixes c210063b40ac
It shall give you:
Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support")
Fixes: 6a17b3876bc8 ("cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking()")
Fixes: ead858bd128d ("cpufreq: mediatek: Move voltage limits to platform data")
Fixes: f126fbadce92 ("cpufreq: mediatek: Unregister platform device on exit")
Fixes: a3b8d1b12c6b ("cpufreq: mediatek: Fix NULL pointer dereference in mediatek-cpufreq")
Fixes: ffa7bdf7f344 ("cpufreq: mediatek: Make sram regulator optional")
and other patches as we did git log.
OR
Else you could do something like this to just see one commit:
$ git show -s --pretty=oneline --pretty=fixes c210063b40ac
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2022-05-10 9:11 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 8:01 [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target Wan Jiabing
2022-05-10 8:01 ` Wan Jiabing
2022-05-10 8:01 ` Wan Jiabing
2022-05-10 8:09 ` Rex-BC Chen
2022-05-10 8:09 ` Rex-BC Chen
2022-05-10 8:12 ` Viresh Kumar
2022-05-10 8:12 ` Viresh Kumar
2022-05-10 8:12 ` Viresh Kumar
2022-05-10 8:26 ` Jiabing Wan
2022-05-10 8:26 ` Jiabing Wan
2022-05-10 8:26 ` Jiabing Wan
2022-05-10 8:50 ` Viresh Kumar
2022-05-10 8:50 ` Viresh Kumar
2022-05-10 8:50 ` Viresh Kumar
2022-05-10 8:58 ` Jiabing Wan
2022-05-10 8:58 ` Jiabing Wan
2022-05-10 8:58 ` Jiabing Wan
2022-05-10 9:09 ` Viresh Kumar
2022-05-10 9:09 ` Viresh Kumar
2022-05-10 9:09 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.