* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
@ 2020-02-01 8:47 Bernd Kuhls
2020-02-01 8:47 ` [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2 Bernd Kuhls
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Bernd Kuhls @ 2020-02-01 8:47 UTC (permalink / raw)
To: buildroot
nspr 4.25 added support for Xtensa architecture:
https://groups.google.com/forum/#!topic/mozilla.dev.tech.nspr/lK7toqtJ96E
Removed BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT because it was only needed for
xtensa.
Added sha1 hash provided by upstream.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/ecryptfs-utils/Config.in | 2 --
package/libnspr/Config.in | 8 --------
package/libnspr/libnspr.hash | 6 ++++--
package/libnspr/libnspr.mk | 2 +-
package/libnss/Config.in | 2 --
package/spidermonkey/Config.in | 1 -
6 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/package/ecryptfs-utils/Config.in b/package/ecryptfs-utils/Config.in
index 0c39f48d08..08210f05eb 100644
--- a/package/ecryptfs-utils/Config.in
+++ b/package/ecryptfs-utils/Config.in
@@ -3,7 +3,6 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
depends on BR2_USE_WCHAR # gettext
depends on BR2_USE_MMU # keyutils
depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr
depends on !BR2_MIPS_NABI32 # libnss
depends on !BR2_STATIC_LIBS # libnss, keyutils
select BR2_PACKAGE_KEYUTILS
@@ -29,7 +28,6 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
http://ecryptfs.org
comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynamic library"
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
BR2_STATIC_LIBS
diff --git a/package/libnspr/Config.in b/package/libnspr/Config.in
index 57fcbdf6be..de8dd0a06b 100644
--- a/package/libnspr/Config.in
+++ b/package/libnspr/Config.in
@@ -1,9 +1,3 @@
-config BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
- def_bool y
- depends on !BR2_xtensa
-
-if BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
-
config BR2_PACKAGE_LIBNSPR
bool "libnspr"
depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -18,5 +12,3 @@ config BR2_PACKAGE_LIBNSPR
comment "libnspr needs a toolchain w/ threads, dynamic library"
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-
-endif
diff --git a/package/libnspr/libnspr.hash b/package/libnspr/libnspr.hash
index 0ec475f480..8deaa2d986 100644
--- a/package/libnspr/libnspr.hash
+++ b/package/libnspr/libnspr.hash
@@ -1,4 +1,6 @@
-# From https://ftp.mozilla.org/pub/nspr/releases/v4.20/src/SHA256SUMS
-sha256 90a59a0df6a11528749647fe18401cc7e03881e3e63c309f8c520ce06dd413d0 nspr-4.24.tar.gz
+# From https://ftp.mozilla.org/pub/nspr/releases/v4.25/src/SHA1SUMS
+sha1 fe02a9056ce867677401b3d6372cdb62f7c7aad4 nspr-4.25.tar.gz
+# From https://ftp.mozilla.org/pub/nspr/releases/v4.25/src/SHA256SUMS
+sha256 0bc309be21f91da4474c56df90415101c7f0c7c7cab2943cd943cd7896985256 nspr-4.25.tar.gz
# Locally calculated
sha256 fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85 nspr/LICENSE
diff --git a/package/libnspr/libnspr.mk b/package/libnspr/libnspr.mk
index 42b4350d90..857052d8c7 100644
--- a/package/libnspr/libnspr.mk
+++ b/package/libnspr/libnspr.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBNSPR_VERSION = 4.24
+LIBNSPR_VERSION = 4.25
LIBNSPR_SOURCE = nspr-$(LIBNSPR_VERSION).tar.gz
LIBNSPR_SITE = https://ftp.mozilla.org/pub/mozilla.org/nspr/releases/v$(LIBNSPR_VERSION)/src
LIBNSPR_SUBDIR = nspr
diff --git a/package/libnss/Config.in b/package/libnss/Config.in
index 2dd0197236..feedcd4029 100644
--- a/package/libnss/Config.in
+++ b/package/libnss/Config.in
@@ -1,7 +1,6 @@
config BR2_PACKAGE_LIBNSS
bool "libnss"
depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
depends on !BR2_STATIC_LIBS
select BR2_PACKAGE_LIBNSPR
select BR2_PACKAGE_SQLITE
@@ -28,5 +27,4 @@ config BR2_PACKAGE_LIBNSS_ARCH
endif
comment "libnss needs a toolchain w/ threads, dynamic library"
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
diff --git a/package/spidermonkey/Config.in b/package/spidermonkey/Config.in
index 5f12110626..150b941c94 100644
--- a/package/spidermonkey/Config.in
+++ b/package/spidermonkey/Config.in
@@ -8,7 +8,6 @@ config BR2_PACKAGE_SPIDERMONKEY_ARCH_SUPPORTS
default y if BR2_riscv
default y if BR2_sh4 || BR2_sh4a
default y if BR2_sparc || BR2_sparc64
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
config BR2_PACKAGE_SPIDERMONKEY_JIT_ARCH_SUPPORTS
bool
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2
2020-02-01 8:47 [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Bernd Kuhls
@ 2020-02-01 8:47 ` Bernd Kuhls
2020-02-01 12:30 ` Giulio Benetti
2020-02-01 9:24 ` [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Thomas Petazzoni
2020-02-01 12:35 ` Giulio Benetti
2 siblings, 1 reply; 10+ messages in thread
From: Bernd Kuhls @ 2020-02-01 8:47 UTC (permalink / raw)
To: buildroot
Release notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.49.2_release_notes
Added sha1 hash provided by upstream.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libnss/libnss.hash | 6 ++++--
package/libnss/libnss.mk | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/package/libnss/libnss.hash b/package/libnss/libnss.hash
index 01098df99a..569ab71c06 100644
--- a/package/libnss/libnss.hash
+++ b/package/libnss/libnss.hash
@@ -1,4 +1,6 @@
-# From https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_48_RTM/src/SHA256SUMS
-sha256 d9aa42e49e02bb0dc0a2f164604cfc718e11a2a06ddb266cd676376ac21b026e nss-3.49.1.tar.gz
+# From https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_49_2_RTM/src/SHA1SUMS
+sha1 08858e0fe80f0bed02e9c7e190e6bb9c2a505b8b nss-3.49.2.tar.gz
+# From https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_49_2_RTM/src/SHA256SUMS
+sha256 faa7502c3ce9240d4be2aa88f63d88cf7d1cc512060e63ef21a7813c236160b2 nss-3.49.2.tar.gz
# Locally calculated
sha256 a20c1a32d1f8102432360b42e932869f7c11c7cdbacf9cac554c422132af47f4 nss/COPYING
diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
index d7d3cda86b..11b57d8142 100644
--- a/package/libnss/libnss.mk
+++ b/package/libnss/libnss.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBNSS_VERSION = 3.49.1
+LIBNSS_VERSION = 3.49.2
LIBNSS_SOURCE = nss-$(LIBNSS_VERSION).tar.gz
LIBNSS_SITE = https://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/NSS_$(subst .,_,$(LIBNSS_VERSION))_RTM/src
LIBNSS_DISTDIR = dist
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-01 8:47 [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Bernd Kuhls
2020-02-01 8:47 ` [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2 Bernd Kuhls
@ 2020-02-01 9:24 ` Thomas Petazzoni
2020-02-04 8:25 ` Arnout Vandecappelle
2020-02-01 12:35 ` Giulio Benetti
2 siblings, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2020-02-01 9:24 UTC (permalink / raw)
To: buildroot
On Sat, 1 Feb 2020 09:47:57 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> nspr 4.25 added support for Xtensa architecture:
> https://groups.google.com/forum/#!topic/mozilla.dev.tech.nspr/lK7toqtJ96E
>
> Removed BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT because it was only needed for
> xtensa.
>
> Added sha1 hash provided by upstream.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
I don't feel very strongly about it, but I'm wondering if it doesn't
make sense to keep BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT. There is some
architecture-specific code in libnpsr, so every time we add a new CPU
architecture, we would have to poentially re-add this hidden option.
More specifically, I have been working on using Buildroot for a new CPU
architecture (not yet upstream, but will be submitted in the future),
and it was quite nice to have this BR2_PACKAGE_LIBNPSR_ARCH_SUPPORT to
disable libnpsr on this CPU architecture for the moment.
But again, I don't feel very strongly, it can very well be re-added
later if need be.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2
2020-02-01 8:47 ` [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2 Bernd Kuhls
@ 2020-02-01 12:30 ` Giulio Benetti
0 siblings, 0 replies; 10+ messages in thread
From: Giulio Benetti @ 2020-02-01 12:30 UTC (permalink / raw)
To: buildroot
Hi Bernd,
there is already a patch pending for this:
https://patchwork.ozlabs.org/patch/1229021/
Best regards
--
Giulio Benetti
Benetti Engineering sas
On 2/1/20 9:47 AM, Bernd Kuhls wrote:
> Release notes:
> https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.49.2_release_notes
>
> Added sha1 hash provided by upstream.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libnss/libnss.hash | 6 ++++--
> package/libnss/libnss.mk | 2 +-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/libnss/libnss.hash b/package/libnss/libnss.hash
> index 01098df99a..569ab71c06 100644
> --- a/package/libnss/libnss.hash
> +++ b/package/libnss/libnss.hash
> @@ -1,4 +1,6 @@
> -# From https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_48_RTM/src/SHA256SUMS
> -sha256 d9aa42e49e02bb0dc0a2f164604cfc718e11a2a06ddb266cd676376ac21b026e nss-3.49.1.tar.gz
> +# From https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_49_2_RTM/src/SHA1SUMS
> +sha1 08858e0fe80f0bed02e9c7e190e6bb9c2a505b8b nss-3.49.2.tar.gz
> +# From https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_49_2_RTM/src/SHA256SUMS
> +sha256 faa7502c3ce9240d4be2aa88f63d88cf7d1cc512060e63ef21a7813c236160b2 nss-3.49.2.tar.gz
> # Locally calculated
> sha256 a20c1a32d1f8102432360b42e932869f7c11c7cdbacf9cac554c422132af47f4 nss/COPYING
> diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
> index d7d3cda86b..11b57d8142 100644
> --- a/package/libnss/libnss.mk
> +++ b/package/libnss/libnss.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -LIBNSS_VERSION = 3.49.1
> +LIBNSS_VERSION = 3.49.2
> LIBNSS_SOURCE = nss-$(LIBNSS_VERSION).tar.gz
> LIBNSS_SITE = https://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/NSS_$(subst .,_,$(LIBNSS_VERSION))_RTM/src
> LIBNSS_DISTDIR = dist
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-01 8:47 [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Bernd Kuhls
2020-02-01 8:47 ` [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2 Bernd Kuhls
2020-02-01 9:24 ` [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Thomas Petazzoni
@ 2020-02-01 12:35 ` Giulio Benetti
2020-02-01 13:21 ` Bernd Kuhls
2 siblings, 1 reply; 10+ messages in thread
From: Giulio Benetti @ 2020-02-01 12:35 UTC (permalink / raw)
To: buildroot
Hi Bernd,
there was already a patch for removing BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT:
https://patchwork.ozlabs.org/patch/1215742/
Dumb question:
Did you check patchwork for libnspr and libnss before starting to work
removing the filters?:
Archived: No
State: Action Required
otherwise we're going to work twice!
Kind regards
--
Giulio Benetti
Benetti Engineering sas
On 2/1/20 9:47 AM, Bernd Kuhls wrote:
> nspr 4.25 added support for Xtensa architecture:
> https://groups.google.com/forum/#!topic/mozilla.dev.tech.nspr/lK7toqtJ96E
>
> Removed BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT because it was only needed for
> xtensa.
>
> Added sha1 hash provided by upstream.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/ecryptfs-utils/Config.in | 2 --
> package/libnspr/Config.in | 8 --------
> package/libnspr/libnspr.hash | 6 ++++--
> package/libnspr/libnspr.mk | 2 +-
> package/libnss/Config.in | 2 --
> package/spidermonkey/Config.in | 1 -
> 6 files changed, 5 insertions(+), 16 deletions(-)
>
> diff --git a/package/ecryptfs-utils/Config.in b/package/ecryptfs-utils/Config.in
> index 0c39f48d08..08210f05eb 100644
> --- a/package/ecryptfs-utils/Config.in
> +++ b/package/ecryptfs-utils/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
> depends on BR2_USE_WCHAR # gettext
> depends on BR2_USE_MMU # keyutils
> depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr
> - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr
> depends on !BR2_MIPS_NABI32 # libnss
> depends on !BR2_STATIC_LIBS # libnss, keyutils
> select BR2_PACKAGE_KEYUTILS
> @@ -29,7 +28,6 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
> http://ecryptfs.org
>
> comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynamic library"
> - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
> depends on BR2_USE_MMU
> depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
> BR2_STATIC_LIBS
> diff --git a/package/libnspr/Config.in b/package/libnspr/Config.in
> index 57fcbdf6be..de8dd0a06b 100644
> --- a/package/libnspr/Config.in
> +++ b/package/libnspr/Config.in
> @@ -1,9 +1,3 @@
> -config BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
> - def_bool y
> - depends on !BR2_xtensa
> -
> -if BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
> -
> config BR2_PACKAGE_LIBNSPR
> bool "libnspr"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> @@ -18,5 +12,3 @@ config BR2_PACKAGE_LIBNSPR
>
> comment "libnspr needs a toolchain w/ threads, dynamic library"
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> -
> -endif
> diff --git a/package/libnspr/libnspr.hash b/package/libnspr/libnspr.hash
> index 0ec475f480..8deaa2d986 100644
> --- a/package/libnspr/libnspr.hash
> +++ b/package/libnspr/libnspr.hash
> @@ -1,4 +1,6 @@
> -# From https://ftp.mozilla.org/pub/nspr/releases/v4.20/src/SHA256SUMS
> -sha256 90a59a0df6a11528749647fe18401cc7e03881e3e63c309f8c520ce06dd413d0 nspr-4.24.tar.gz
> +# From https://ftp.mozilla.org/pub/nspr/releases/v4.25/src/SHA1SUMS
> +sha1 fe02a9056ce867677401b3d6372cdb62f7c7aad4 nspr-4.25.tar.gz
> +# From https://ftp.mozilla.org/pub/nspr/releases/v4.25/src/SHA256SUMS
> +sha256 0bc309be21f91da4474c56df90415101c7f0c7c7cab2943cd943cd7896985256 nspr-4.25.tar.gz
> # Locally calculated
> sha256 fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85 nspr/LICENSE
> diff --git a/package/libnspr/libnspr.mk b/package/libnspr/libnspr.mk
> index 42b4350d90..857052d8c7 100644
> --- a/package/libnspr/libnspr.mk
> +++ b/package/libnspr/libnspr.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -LIBNSPR_VERSION = 4.24
> +LIBNSPR_VERSION = 4.25
> LIBNSPR_SOURCE = nspr-$(LIBNSPR_VERSION).tar.gz
> LIBNSPR_SITE = https://ftp.mozilla.org/pub/mozilla.org/nspr/releases/v$(LIBNSPR_VERSION)/src
> LIBNSPR_SUBDIR = nspr
> diff --git a/package/libnss/Config.in b/package/libnss/Config.in
> index 2dd0197236..feedcd4029 100644
> --- a/package/libnss/Config.in
> +++ b/package/libnss/Config.in
> @@ -1,7 +1,6 @@
> config BR2_PACKAGE_LIBNSS
> bool "libnss"
> depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
> - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
> depends on !BR2_STATIC_LIBS
> select BR2_PACKAGE_LIBNSPR
> select BR2_PACKAGE_SQLITE
> @@ -28,5 +27,4 @@ config BR2_PACKAGE_LIBNSS_ARCH
> endif
>
> comment "libnss needs a toolchain w/ threads, dynamic library"
> - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> diff --git a/package/spidermonkey/Config.in b/package/spidermonkey/Config.in
> index 5f12110626..150b941c94 100644
> --- a/package/spidermonkey/Config.in
> +++ b/package/spidermonkey/Config.in
> @@ -8,7 +8,6 @@ config BR2_PACKAGE_SPIDERMONKEY_ARCH_SUPPORTS
> default y if BR2_riscv
> default y if BR2_sh4 || BR2_sh4a
> default y if BR2_sparc || BR2_sparc64
> - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
>
> config BR2_PACKAGE_SPIDERMONKEY_JIT_ARCH_SUPPORTS
> bool
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-01 12:35 ` Giulio Benetti
@ 2020-02-01 13:21 ` Bernd Kuhls
2020-02-01 13:24 ` Giulio Benetti
0 siblings, 1 reply; 10+ messages in thread
From: Bernd Kuhls @ 2020-02-01 13:21 UTC (permalink / raw)
To: buildroot
Am Sat, 01 Feb 2020 13:35:34 +0100 schrieb Giulio Benetti:
> Dumb question:
> Did you check patchwork for libnspr and libnss before starting to work
Hi Guilio,
no, I did not, marked my patches as rejected, sorry for the noise.
Regards, Bernd
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-01 13:21 ` Bernd Kuhls
@ 2020-02-01 13:24 ` Giulio Benetti
0 siblings, 0 replies; 10+ messages in thread
From: Giulio Benetti @ 2020-02-01 13:24 UTC (permalink / raw)
To: buildroot
On 2/1/20 2:21 PM, Bernd Kuhls wrote:
> Am Sat, 01 Feb 2020 13:35:34 +0100 schrieb Giulio Benetti:
>
>> Dumb question:
>> Did you check patchwork for libnspr and libnss before starting to work
>
> Hi Guilio,
>
> no, I did not, marked my patches as rejected, sorry for the noise.
no problem!
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Giulio Benetti
Benetti Engineering sas
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-01 9:24 ` [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Thomas Petazzoni
@ 2020-02-04 8:25 ` Arnout Vandecappelle
2020-02-04 8:33 ` Thomas Petazzoni
0 siblings, 1 reply; 10+ messages in thread
From: Arnout Vandecappelle @ 2020-02-04 8:25 UTC (permalink / raw)
To: buildroot
On 01/02/2020 10:24, Thomas Petazzoni wrote:
> On Sat, 1 Feb 2020 09:47:57 +0100
> Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
>> nspr 4.25 added support for Xtensa architecture:
>> https://groups.google.com/forum/#!topic/mozilla.dev.tech.nspr/lK7toqtJ96E
>>
>> Removed BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT because it was only needed for
>> xtensa.
>>
>> Added sha1 hash provided by upstream.
>>
>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>
> I don't feel very strongly about it, but I'm wondering if it doesn't
> make sense to keep BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT. There is some
> architecture-specific code in libnpsr, so every time we add a new CPU
> architecture, we would have to poentially re-add this hidden option.
For what it's worth, I agree with doing that. We don't want to end up in the
libffi situation...
Regards,
Arnout
>
> More specifically, I have been working on using Buildroot for a new CPU
> architecture (not yet upstream, but will be submitted in the future),
> and it was quite nice to have this BR2_PACKAGE_LIBNPSR_ARCH_SUPPORT to
> disable libnpsr on this CPU architecture for the moment.
>
> But again, I don't feel very strongly, it can very well be re-added
> later if need be.
>
> Best regards,
>
> Thomas
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-04 8:25 ` Arnout Vandecappelle
@ 2020-02-04 8:33 ` Thomas Petazzoni
2020-02-04 9:52 ` Giulio Benetti
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2020-02-04 8:33 UTC (permalink / raw)
To: buildroot
On Tue, 4 Feb 2020 09:25:46 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:
> > I don't feel very strongly about it, but I'm wondering if it doesn't
> > make sense to keep BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT. There is some
> > architecture-specific code in libnpsr, so every time we add a new CPU
> > architecture, we would have to poentially re-add this hidden option.
>
> For what it's worth, I agree with doing that. We don't want to end up in the
> libffi situation...
Agreed. Though I don't think libnspr will ever be in the situation of
libffi, with zillions of reverse dependencies.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
2020-02-04 8:33 ` Thomas Petazzoni
@ 2020-02-04 9:52 ` Giulio Benetti
0 siblings, 0 replies; 10+ messages in thread
From: Giulio Benetti @ 2020-02-04 9:52 UTC (permalink / raw)
To: buildroot
Hi Arnout, Thomas,
On 2/4/20 9:33 AM, Thomas Petazzoni wrote:
> On Tue, 4 Feb 2020 09:25:46 +0100
> Arnout Vandecappelle <arnout@mind.be> wrote:
>
>>> I don't feel very strongly about it, but I'm wondering if it doesn't
>>> make sense to keep BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT. There is some
>>> architecture-specific code in libnpsr, so every time we add a new CPU
>>> architecture, we would have to poentially re-add this hidden option.
>>
>> For what it's worth, I agree with doing that. We don't want to end up in the
>> libffi situation...
>
> Agreed. Though I don't think libnspr will ever be in the situation of
> libffi, with zillions of reverse dependencies.
I've sent a v2 for this patch after rebasing:
https://patchwork.ozlabs.org/patch/1233202/
Usually adding an architecture to nspr is about adding only type sizes.
This has been for Microblaze, Nds2, Nios2 and Xtensa, so probably it
will be the same for this new architecture to be supported.
Best regards
--
Giulio Benetti
Benetti Engineering sas
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-04 9:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-01 8:47 [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Bernd Kuhls
2020-02-01 8:47 ` [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2 Bernd Kuhls
2020-02-01 12:30 ` Giulio Benetti
2020-02-01 9:24 ` [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Thomas Petazzoni
2020-02-04 8:25 ` Arnout Vandecappelle
2020-02-04 8:33 ` Thomas Petazzoni
2020-02-04 9:52 ` Giulio Benetti
2020-02-01 12:35 ` Giulio Benetti
2020-02-01 13:21 ` Bernd Kuhls
2020-02-01 13:24 ` Giulio Benetti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.