All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	qemu-ppc@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Corey Minyard" <minyard@acm.org>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Max Reitz" <mreitz@redhat.com>,
	qemu-trivial@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-block@nongnu.org, "Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 05/10] hw/isa: Add the ISA_IRQ_FDC_DEFAULT definition
Date: Mon, 12 Oct 2020 10:17:55 -0400	[thread overview]
Message-ID: <61ddbe67-612d-0a19-a04a-d0dcd083b373@redhat.com> (raw)
In-Reply-To: <20201011193229.3210774-6-f4bug@amsat.org>

On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote:
> The floppy disk controller uses IRQ #6 by default. Add this
> default definition to the IsaIrqNumber enum.
> 
> Avoid magic values in the code, replace them by the
> newly introduced definition.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Acked-by: John Snow <jsnow@redhat.com>



  reply	other threads:[~2020-10-12 14:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 19:32 [PATCH 00/10] hw/isa: Introduce definitions for default IRQ values Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 01/10] hw/isa: Introduce IsaIrqNumber enum Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 02/10] hw/isa: Add the ISA_IRQ_KBD_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 03/10] hw/isa: Add the ISA_IRQ_SER_DEFAULT definition Philippe Mathieu-Daudé
2020-10-13  7:14   ` Gerd Hoffmann
2020-10-11 19:32 ` [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 20:28   ` Stefan Berger
2020-10-11 21:07     ` Philippe Mathieu-Daudé
2020-10-13  7:20   ` Gerd Hoffmann
2020-10-13  8:26     ` Philippe Mathieu-Daudé
2020-10-13 14:23       ` Stefan Berger
2020-10-11 19:32 ` [PATCH 05/10] hw/isa: Add the ISA_IRQ_FDC_DEFAULT definition Philippe Mathieu-Daudé
2020-10-12 14:17   ` John Snow [this message]
2020-10-11 19:32 ` [PATCH 06/10] hw/isa: Add the ISA_IRQ_PAR_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 07/10] hw/isa: Add the ISA_IRQ_RTC_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 08/10] hw/isa: Add the ISA_IRQ_NET_DEFAULT definition Philippe Mathieu-Daudé
2020-10-13  7:23   ` Gerd Hoffmann
2020-10-13  8:27     ` Philippe Mathieu-Daudé
2020-10-13 14:20     ` Stefan Berger
2020-10-11 19:32 ` [PATCH 09/10] hw/isa: Add the ISA_IRQ_MOU_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 10/10] hw/isa: Add the ISA_IRQ_IDE_DEFAULT definition Philippe Mathieu-Daudé
2020-10-12 14:16   ` John Snow
2020-10-13  7:25   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61ddbe67-612d-0a19-a04a-d0dcd083b373@redhat.com \
    --to=jsnow@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=minyard@acm.org \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.