From: Daniel Thompson <daniel.thompson@linaro.org> To: Matthias Kaehlcke <mka@chromium.org>, Thierry Reding <thierry.reding@gmail.com>, Lee Jones <lee.jones@linaro.org>, Jingoo Han <jingoohan1@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Douglas Anderson <dianders@chromium.org>, Brian Norris <briannorris@chromium.org>, Pavel Machek <pavel@ucw.cz>, Jacek Anaszewski <jacek.anaszewski@gmail.com> Subject: Re: [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves Date: Fri, 21 Jun 2019 13:55:50 +0100 [thread overview] Message-ID: <61ed137c-31bb-c695-4174-0484fe667d6c@linaro.org> (raw) In-Reply-To: <20190613194326.180889-4-mka@chromium.org> On 13/06/2019 20:43, Matthias Kaehlcke wrote: > For backlight curves calculated with the CIE 1931 algorithm set > the brightness scale type property accordingly. This makes the > scale type available to userspace via the 'scale' sysfs attribute. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> I'd like to keep discussion on patch 2 open a bit longer (it's not part of the thread below patch 2 but Pavel had concerns about the sysfs interface) so this ack won't really push things forward but FWIW: Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > drivers/video/backlight/pwm_bl.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index fb45f866b923..f067fe7aa35d 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -553,6 +553,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > goto err_alloc; > } > > + memset(&props, 0, sizeof(struct backlight_properties)); > + > if (data->levels) { > /* > * For the DT case, only when brightness levels is defined > @@ -591,6 +593,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->levels = data->levels; > } > + > + props.scale = BACKLIGHT_SCALE_CIE1931; > } else { > /* > * That only happens for the non-DT case, where platform data > @@ -601,7 +605,6 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->lth_brightness = data->lth_brightness * (state.period / pb->scale); > > - memset(&props, 0, sizeof(struct backlight_properties)); > props.type = BACKLIGHT_RAW; > props.max_brightness = data->max_brightness; > bl = backlight_device_register(dev_name(&pdev->dev), &pdev->dev, pb, >
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org> To: Matthias Kaehlcke <mka@chromium.org>, Thierry Reding <thierry.reding@gmail.com>, Lee Jones <lee.jones@linaro.org>, Jingoo Han <jingoohan1@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Douglas Anderson <dianders@chromium.org>, Brian Norris <briannorris@chromium.org>, Pavel Machek <pavel@ucw.cz>, Jacek Anaszewski <jacek.anaszewski@gmail.com> Subject: Re: [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves Date: Fri, 21 Jun 2019 12:55:50 +0000 [thread overview] Message-ID: <61ed137c-31bb-c695-4174-0484fe667d6c@linaro.org> (raw) In-Reply-To: <20190613194326.180889-4-mka@chromium.org> On 13/06/2019 20:43, Matthias Kaehlcke wrote: > For backlight curves calculated with the CIE 1931 algorithm set > the brightness scale type property accordingly. This makes the > scale type available to userspace via the 'scale' sysfs attribute. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> I'd like to keep discussion on patch 2 open a bit longer (it's not part of the thread below patch 2 but Pavel had concerns about the sysfs interface) so this ack won't really push things forward but FWIW: Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > drivers/video/backlight/pwm_bl.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index fb45f866b923..f067fe7aa35d 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -553,6 +553,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > goto err_alloc; > } > > + memset(&props, 0, sizeof(struct backlight_properties)); > + > if (data->levels) { > /* > * For the DT case, only when brightness levels is defined > @@ -591,6 +593,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->levels = data->levels; > } > + > + props.scale = BACKLIGHT_SCALE_CIE1931; > } else { > /* > * That only happens for the non-DT case, where platform data > @@ -601,7 +605,6 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->lth_brightness = data->lth_brightness * (state.period / pb->scale); > > - memset(&props, 0, sizeof(struct backlight_properties)); > props.type = BACKLIGHT_RAW; > props.max_brightness = data->max_brightness; > bl = backlight_device_register(dev_name(&pdev->dev), &pdev->dev, pb, >
next prev parent reply other threads:[~2019-06-21 12:55 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-13 19:43 [PATCH 0/4] backlight: Expose brightness curve type through sysfs Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-13 19:43 ` [PATCH 1/4] MAINTAINERS: Add entry for stable backlight sysfs ABI documentation Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-19 11:05 ` Daniel Thompson 2019-06-19 11:05 ` Daniel Thompson 2019-06-19 11:05 ` Daniel Thompson 2019-06-13 19:43 ` [PATCH 2/4] backlight: Expose brightness curve type through sysfs Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-13 21:56 ` Matthias Kaehlcke 2019-06-13 21:56 ` Matthias Kaehlcke 2019-06-13 19:43 ` [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-19 9:17 ` Enric Balletbo i Serra 2019-06-19 9:17 ` Enric Balletbo i Serra 2019-06-21 12:55 ` Daniel Thompson [this message] 2019-06-21 12:55 ` Daniel Thompson 2019-06-27 9:24 ` Lee Jones 2019-06-27 9:24 ` Lee Jones 2019-06-27 9:24 ` Lee Jones 2019-06-27 15:49 ` Daniel Thompson 2019-06-27 15:49 ` Daniel Thompson 2019-06-27 15:49 ` Daniel Thompson 2019-06-13 19:43 ` [PATCH 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT Matthias Kaehlcke 2019-06-13 19:43 ` Matthias Kaehlcke 2019-06-21 13:10 ` Daniel Thompson 2019-06-21 13:10 ` Daniel Thompson 2019-06-24 18:54 ` Matthias Kaehlcke 2019-06-24 18:54 ` Matthias Kaehlcke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=61ed137c-31bb-c695-4174-0484fe667d6c@linaro.org \ --to=daniel.thompson@linaro.org \ --cc=b.zolnierkie@samsung.com \ --cc=briannorris@chromium.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=enric.balletbo@collabora.com \ --cc=jacek.anaszewski@gmail.com \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=mka@chromium.org \ --cc=pavel@ucw.cz \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.