All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Huang Jianan <huangjianan@oppo.com>, <linux-erofs@lists.ozlabs.org>
Cc: <linux-kernel@vger.kernel.org>, <guoweichao@oppo.com>,
	<zhangshiming@oppo.com>
Subject: Re: [PATCH 2/2] erofs: use sync decompression for atomic contexts only
Date: Wed, 17 Mar 2021 14:45:52 +0800	[thread overview]
Message-ID: <62153424-198c-807e-cced-33dd90279174@huawei.com> (raw)
In-Reply-To: <20210317035448.13921-3-huangjianan@oppo.com>

On 2021/3/17 11:54, Huang Jianan via Linux-erofs wrote:
> Sync decompression was introduced to get rid of additional kworker
> scheduling overhead. But there is no such overhead in non-atomic
> contexts. Therefore, it should be better to turn off sync decompression
> to avoid the current thread waiting in z_erofs_runqueue.
> 
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
> Reviewed-by: Gao Xiang <hsiangkao@redhat.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: Huang Jianan <huangjianan@oppo.com>, <linux-erofs@lists.ozlabs.org>
Cc: zhangshiming@oppo.com, guoweichao@oppo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] erofs: use sync decompression for atomic contexts only
Date: Wed, 17 Mar 2021 14:45:52 +0800	[thread overview]
Message-ID: <62153424-198c-807e-cced-33dd90279174@huawei.com> (raw)
In-Reply-To: <20210317035448.13921-3-huangjianan@oppo.com>

On 2021/3/17 11:54, Huang Jianan via Linux-erofs wrote:
> Sync decompression was introduced to get rid of additional kworker
> scheduling overhead. But there is no such overhead in non-atomic
> contexts. Therefore, it should be better to turn off sync decompression
> to avoid the current thread waiting in z_erofs_runqueue.
> 
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
> Reviewed-by: Gao Xiang <hsiangkao@redhat.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

  reply	other threads:[~2021-03-17  6:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  3:54 [PATCH 0/2] erofs: decompress in endio if possible Huang Jianan
2021-03-17  3:54 ` Huang Jianan via Linux-erofs
2021-03-17  3:54 ` [PATCH 1/2] erofs: use workqueue decompression for atomic contexts only Huang Jianan
2021-03-17  3:54   ` Huang Jianan via Linux-erofs
2021-03-17  6:44   ` Chao Yu
2021-03-17  6:44     ` Chao Yu
2021-03-17  3:54 ` [PATCH 2/2] erofs: use sync " Huang Jianan
2021-03-17  3:54   ` Huang Jianan via Linux-erofs
2021-03-17  6:45   ` Chao Yu [this message]
2021-03-17  6:45     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62153424-198c-807e-cced-33dd90279174@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=guoweichao@oppo.com \
    --cc=huangjianan@oppo.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhangshiming@oppo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.