From: Hans de Goede <hdegoede@redhat.com>
To: Tony Lindgren <tony@atomide.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: PM regression with LED changes in next-20161109
Date: Thu, 10 Nov 2016 09:34:52 +0100 [thread overview]
Message-ID: <621758ce-dd3f-41ad-d9b8-b8e34538700e@redhat.com> (raw)
In-Reply-To: <20161109192301.GS26979@atomide.com>
Hi,
On 09-11-16 20:23, Tony Lindgren wrote:
> Hi,
>
> Looks like commit 883d32ce3385 ("leds: core: Add support for poll()ing
> the sysfs brightness attr for changes.") breaks runtime PM for me.
>
> On my omap dm3730 based test system, idle power consumption is over 70
> times higher now with this patch! It goes from about 6mW for the core
> system to over 440mW during idle meaning there's some busy timer now
> active.
Do you have any blinking LEDs or LED triggers defined on the system ?
> Reverting this patch fixes the issue. Any ideas?
All I can think of is something calling led_set_brightness quite often,
the patch in question makes led_set_brightness somewhat more expensive,
but it should not cause such a big difference unless something is
really calling led_set_brightness quite often maybe something is calling
it with the same value all the time ?
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: PM regression with LED changes in next-20161109
Date: Thu, 10 Nov 2016 09:34:52 +0100 [thread overview]
Message-ID: <621758ce-dd3f-41ad-d9b8-b8e34538700e@redhat.com> (raw)
In-Reply-To: <20161109192301.GS26979@atomide.com>
Hi,
On 09-11-16 20:23, Tony Lindgren wrote:
> Hi,
>
> Looks like commit 883d32ce3385 ("leds: core: Add support for poll()ing
> the sysfs brightness attr for changes.") breaks runtime PM for me.
>
> On my omap dm3730 based test system, idle power consumption is over 70
> times higher now with this patch! It goes from about 6mW for the core
> system to over 440mW during idle meaning there's some busy timer now
> active.
Do you have any blinking LEDs or LED triggers defined on the system ?
> Reverting this patch fixes the issue. Any ideas?
All I can think of is something calling led_set_brightness quite often,
the patch in question makes led_set_brightness somewhat more expensive,
but it should not cause such a big difference unless something is
really calling led_set_brightness quite often maybe something is calling
it with the same value all the time ?
Regards,
Hans
next prev parent reply other threads:[~2016-11-10 8:34 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:23 PM regression with LED changes in next-20161109 Tony Lindgren
2016-11-09 19:23 ` Tony Lindgren
2016-11-09 20:45 ` Jacek Anaszewski
2016-11-09 20:45 ` Jacek Anaszewski
2016-11-10 8:49 ` Hans de Goede
2016-11-10 8:49 ` Hans de Goede
2016-11-10 12:56 ` Jacek Anaszewski
2016-11-10 12:56 ` Jacek Anaszewski
2016-11-10 13:04 ` Hans de Goede
2016-11-10 13:04 ` Hans de Goede
2016-11-10 13:55 ` Jacek Anaszewski
2016-11-10 13:55 ` Jacek Anaszewski
2016-11-10 16:36 ` Pavel Machek
2016-11-10 16:36 ` Pavel Machek
2016-11-10 16:29 ` Pavel Machek
2016-11-10 16:29 ` Pavel Machek
2016-11-10 16:44 ` Hans de Goede
2016-11-10 16:44 ` Hans de Goede
2016-11-10 20:48 ` Pavel Machek
2016-11-10 20:48 ` Pavel Machek
2016-11-11 8:25 ` Hans de Goede
2016-11-11 8:25 ` Hans de Goede
2016-11-10 17:55 ` Tony Lindgren
2016-11-10 17:55 ` Tony Lindgren
2016-11-10 20:29 ` Pavel Machek
2016-11-10 20:29 ` Pavel Machek
2016-11-10 21:34 ` Jacek Anaszewski
2016-11-10 21:34 ` Jacek Anaszewski
2016-11-11 12:01 ` Pavel Machek
2016-11-11 12:01 ` Pavel Machek
2016-11-11 17:03 ` Jacek Anaszewski
2016-11-11 17:03 ` Jacek Anaszewski
2016-11-11 19:28 ` Hans de Goede
2016-11-11 19:28 ` Hans de Goede
2016-11-11 22:12 ` Pavel Machek
2016-11-11 22:12 ` Pavel Machek
2016-11-12 8:03 ` Hans de Goede
2016-11-12 8:03 ` Hans de Goede
2016-11-13 9:10 ` Three different LED brightnesses (was Re: PM regression with LED changes in next-20161109) Pavel Machek
2016-11-13 9:10 ` Pavel Machek
2016-11-13 9:44 ` Hans de Goede
2016-11-13 9:44 ` Hans de Goede
2016-11-13 20:45 ` Pavel Machek
2016-11-13 20:45 ` Pavel Machek
2016-11-12 10:24 ` PM regression with LED changes in next-20161109 Jacek Anaszewski
2016-11-12 10:24 ` Jacek Anaszewski
2016-11-12 10:33 ` Hans de Goede
2016-11-12 10:33 ` Hans de Goede
2016-11-12 10:33 ` Hans de Goede
2016-11-12 19:14 ` Jacek Anaszewski
2016-11-12 19:14 ` Jacek Anaszewski
2016-11-12 21:14 ` Hans de Goede
2016-11-12 21:14 ` Hans de Goede
2016-11-13 11:44 ` Jacek Anaszewski
2016-11-13 11:44 ` Jacek Anaszewski
2016-11-13 13:52 ` Hans de Goede
2016-11-13 13:52 ` Hans de Goede
2016-11-14 9:12 ` Jacek Anaszewski
2016-11-14 9:12 ` Jacek Anaszewski
2016-11-14 9:12 ` Jacek Anaszewski
2016-11-14 12:51 ` Hans de Goede
2016-11-14 12:51 ` Hans de Goede
2016-11-15 10:01 ` Jacek Anaszewski
2016-11-15 10:01 ` Jacek Anaszewski
2016-11-15 10:09 ` Hans de Goede
2016-11-15 10:09 ` Hans de Goede
2016-11-15 10:31 ` LEDs that change brightness "itself" -- that's a trigger. " Pavel Machek
2016-11-15 10:31 ` Pavel Machek
2016-11-15 10:58 ` Jacek Anaszewski
2016-11-15 10:58 ` Jacek Anaszewski
2016-11-15 11:11 ` Pavel Machek
2016-11-15 11:11 ` Pavel Machek
2016-11-15 11:21 ` Hans de Goede
2016-11-15 11:21 ` Hans de Goede
2016-11-15 11:48 ` Pavel Machek
2016-11-15 11:48 ` Pavel Machek
2016-11-15 12:06 ` Hans de Goede
2016-11-15 12:06 ` Hans de Goede
2016-11-15 12:11 ` Pavel Machek
2016-11-15 12:11 ` Pavel Machek
2016-11-15 13:28 ` Jacek Anaszewski
2016-11-15 13:28 ` Jacek Anaszewski
2016-11-15 13:48 ` Hans de Goede
2016-11-15 13:48 ` Hans de Goede
2016-11-15 14:04 ` Jacek Anaszewski
2016-11-15 14:04 ` Jacek Anaszewski
2016-11-15 14:30 ` Hans de Goede
2016-11-15 14:30 ` Hans de Goede
2016-11-15 14:41 ` Jacek Anaszewski
2016-11-15 14:41 ` Jacek Anaszewski
2016-11-17 22:12 ` Hans de Goede
2016-11-17 22:12 ` Hans de Goede
2016-11-15 11:17 ` Hans de Goede
2016-11-15 11:17 ` Hans de Goede
2016-11-14 8:31 ` Pavel Machek
2016-11-14 8:31 ` Pavel Machek
2016-11-11 22:06 ` Pavel Machek
2016-11-11 22:06 ` Pavel Machek
2016-11-10 8:34 ` Hans de Goede [this message]
2016-11-10 8:34 ` Hans de Goede
2016-11-10 15:11 ` Tony Lindgren
2016-11-10 15:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621758ce-dd3f-41ad-d9b8-b8e34538700e@redhat.com \
--to=hdegoede@redhat.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.