From: Ray Jui <ray.jui@broadcom.com> To: Guenter Roeck <linux@roeck-us.net> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Frank Rowand <frowand.list@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Robin Murphy <robin.murphy@arm.com>, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v3 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 Date: Thu, 24 May 2018 09:42:20 -0700 [thread overview] Message-ID: <621dc488-2d8d-003b-9bd1-4de59e8d178b@broadcom.com> (raw) In-Reply-To: <20180524161628.GA28425@roeck-us.net> On 5/24/2018 9:16 AM, Guenter Roeck wrote: > On Wed, May 23, 2018 at 05:15:20PM -0700, Ray Jui wrote: >> Update the SP805 binding document to add optional 'timeout-sec' >> devicetree property >> >> Signed-off-by: Ray Jui <ray.jui@broadcom.com> >> --- >> Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> index 0fa3629..1debea3 100644 >> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> @@ -19,6 +19,8 @@ Required properties: >> >> Optional properties: >> - interrupts: Should specify WDT interrupt number >> +- timeout-sec: Should specify default WDT timeout in seconds. If unset, the >> + default timeout in the driver is 30 seconds > > "... the default timeout is determined by the driver" might be better. > If you want to mandate a default here (not sure if that is a good idea), > I would suggest to use something like "should be 30 seconds". > Okay. This can be changed to: - timeout-sec: Should specify default WDT timeout in seconds. If unset, the default timeout is determined by the driver. Please advise how to proceed with this patch series. Should I make the above modification and send out v4? Thanks, Ray > Guenter > >> >> Example: >> watchdog@66090000 { >> -- >> 2.1.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ray.jui@broadcom.com (Ray Jui) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 Date: Thu, 24 May 2018 09:42:20 -0700 [thread overview] Message-ID: <621dc488-2d8d-003b-9bd1-4de59e8d178b@broadcom.com> (raw) In-Reply-To: <20180524161628.GA28425@roeck-us.net> On 5/24/2018 9:16 AM, Guenter Roeck wrote: > On Wed, May 23, 2018 at 05:15:20PM -0700, Ray Jui wrote: >> Update the SP805 binding document to add optional 'timeout-sec' >> devicetree property >> >> Signed-off-by: Ray Jui <ray.jui@broadcom.com> >> --- >> Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> index 0fa3629..1debea3 100644 >> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> @@ -19,6 +19,8 @@ Required properties: >> >> Optional properties: >> - interrupts: Should specify WDT interrupt number >> +- timeout-sec: Should specify default WDT timeout in seconds. If unset, the >> + default timeout in the driver is 30 seconds > > "... the default timeout is determined by the driver" might be better. > If you want to mandate a default here (not sure if that is a good idea), > I would suggest to use something like "should be 30 seconds". > Okay. This can be changed to: - timeout-sec: Should specify default WDT timeout in seconds. If unset, the default timeout is determined by the driver. Please advise how to proceed with this patch series. Should I make the above modification and send out v4? Thanks, Ray > Guenter > >> >> Example: >> watchdog at 66090000 { >> -- >> 2.1.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-24 16:42 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-24 0:15 [PATCH v3 0/6] Enhance support for the SP805 WDT Ray Jui 2018-05-24 0:15 ` Ray Jui 2018-05-24 0:15 ` [PATCH v3 1/6] Documentation: DT: Consolidate SP805 binding docs Ray Jui 2018-05-24 0:15 ` Ray Jui 2018-05-24 0:15 ` [PATCH v3 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 Ray Jui 2018-05-24 0:15 ` Ray Jui 2018-05-24 16:16 ` Guenter Roeck 2018-05-24 16:16 ` Guenter Roeck 2018-05-24 16:42 ` Ray Jui [this message] 2018-05-24 16:42 ` Ray Jui 2018-05-24 17:12 ` Guenter Roeck 2018-05-24 17:12 ` Guenter Roeck 2018-05-24 0:15 ` [PATCH v3 3/6] watchdog: sp805: add 'timeout-sec' DT property support Ray Jui 2018-05-24 0:15 ` Ray Jui 2018-05-24 0:15 ` [PATCH v3 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate Ray Jui 2018-05-24 0:15 ` Ray Jui 2018-05-24 16:19 ` Guenter Roeck 2018-05-24 16:19 ` Guenter Roeck 2018-05-24 16:36 ` Ray Jui 2018-05-24 16:36 ` Ray Jui 2018-05-24 17:11 ` Guenter Roeck 2018-05-24 17:11 ` Guenter Roeck 2018-05-24 0:15 ` [PATCH v3 5/6] arm64: dt: set initial SR watchdog timeout to 60 seconds Ray Jui 2018-05-24 0:15 ` Ray Jui 2018-05-24 0:15 ` [PATCH v3 6/6] arm64: defconfig: add CONFIG_ARM_SP805_WATCHDOG Ray Jui 2018-05-24 0:15 ` Ray Jui
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=621dc488-2d8d-003b-9bd1-4de59e8d178b@broadcom.com \ --to=ray.jui@broadcom.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=will.deacon@arm.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.