Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Andreas Müller]

On Sat, Jan 22, 2022 at 8:29 PM Markus Volk <f_l_k@t-online.de> wrote:
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  .../recipes-connectivity/geary/geary_40.0.bb  | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 meta-gnome/recipes-connectivity/geary/geary_40.0.bb
>
This is on my TODO for so long - did not find the time. Thanks!

Andreas

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Andreas Müller]

I forgot: Please add it to packagegroup-gnome-apps in a follow-up

Cheers

Andreas

On Sat, Jan 22, 2022 at 10:14 PM Andreas Müller via
lists.openembedded.org
<schnitzeltony=gmail.com@lists.openembedded.org> wrote:
>
> On Sat, Jan 22, 2022 at 8:29 PM Markus Volk <f_l_k@t-online.de> wrote:
> >
> > Signed-off-by: Markus Volk <f_l_k@t-online.de>
> > ---
> >  .../recipes-connectivity/geary/geary_40.0.bb  | 54 +++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> >  create mode 100644 meta-gnome/recipes-connectivity/geary/geary_40.0.bb
> >
> This is on my TODO for so long - did not find the time. Thanks!
>
> Andreas
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95006): https://lists.openembedded.org/g/openembedded-devel/message/95006
> Mute This Topic: https://lists.openembedded.org/mt/88611343/3617609
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [schnitzeltony@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Markus Volk]

Hi Andreas,

i sent a patch to add it to gnome apps packagegroup.

Cheers

Markus

Am 22.01.22 um 22:19 schrieb Andreas Müller:
> I forgot: Please add it to packagegroup-gnome-apps in a follow-up
>
> Cheers
>
> Andreas
>
> On Sat, Jan 22, 2022 at 10:14 PM Andreas Müller via
> lists.openembedded.org
> <schnitzeltony=gmail.com@lists.openembedded.org> wrote:
>> On Sat, Jan 22, 2022 at 8:29 PM Markus Volk <f_l_k@t-online.de> wrote:
>>> Signed-off-by: Markus Volk <f_l_k@t-online.de>
>>> ---
>>>   .../recipes-connectivity/geary/geary_40.0.bb  | 54 +++++++++++++++++++
>>>   1 file changed, 54 insertions(+)
>>>   create mode 100644 meta-gnome/recipes-connectivity/geary/geary_40.0.bb
>>>
>> This is on my TODO for so long - did not find the time. Thanks!
>>
>> Andreas
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#95006): https://lists.openembedded.org/g/openembedded-devel/message/95006
>> Mute This Topic: https://lists.openembedded.org/mt/88611343/3617609
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [schnitzeltony@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Jan Lübbe]

Hi Markus,

On Thu, 2022-01-20 at 21:26 +0100, Markus Volk wrote:

...
> +inherit meson pkgconfig mime-xdg gtk-icon-cache gobject-introspection vala
> +
> +SRC_URI = " \
> +	git://github.com/GNOME/geary.git;nobranch=1;protocol=https \
> +"
> +
> +S = "${WORKDIR}/git"
> +SRCREV = "gnome-${PV}"

perhaps I'm missing something, but shouldn't this be a git commit hash?

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Markus Volk]

Hi Jan,

it is also allowed to use tags here.

SRCREV= "gnome-40.0" fetches the same code as

SRCREV ="e561775c1580a9f60a726355b2b897bfc9cb3382"

Am 25.01.22 um 13:25 schrieb Jan Luebbe:
> Hi Markus,
>
> On Thu, 2022-01-20 at 21:26 +0100, Markus Volk wrote:
>
> ...
>> +inherit meson pkgconfig mime-xdg gtk-icon-cache gobject-introspection vala
>> +
>> +SRC_URI = " \
>> +	git://github.com/GNOME/geary.git;nobranch=1;protocol=https \
>> +"
>> +
>> +S = "${WORKDIR}/git"
>> +SRCREV = "gnome-${PV}"
> perhaps I'm missing something, but shouldn't this be a git commit hash?
>
> Regards,
> Jan
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95056): https://lists.openembedded.org/g/openembedded-devel/message/95056
> Mute This Topic: https://lists.openembedded.org/mt/88611343/3618223
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [f_l_k@t-online.de]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Jan Lübbe]

Hi Markus,

On Tue, 2022-01-25 at 14:28 +0100, Markus Volk wrote:
> Hi Jan,
> 
> it is also allowed to use tags here.
> 
> SRCREV= "gnome-40.0" fetches the same code as
> 
> SRCREV = "e561775c1580a9f60a726355b2b897bfc9cb3382"

That's only true as long as nobody modifies that tag in the upstream repository
and isn't cryptographically secure. As far as I can see, no existing recipe in
meta-oe or oe-core uses a tag as SRCREV.

Additionally, https://docs.yoctoproject.org/singleindex.html#term-SRCREV warns:
"Note that if you want to build a fixed revision and you want to avoid
performing a query on the remote repository every time BitBake parses your
recipe, you should specify a SRCREV that is a full revision identifier and not
just a tag."

Regards,
Jan

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Markus Volk]

Thats right. I did it like this because it would be then  only be needed 
to change the PV in the recipe name to get the SRCREV updated on a 
version update (of course assumed that the tag name wasn't modified).

> Additionally, https://docs.yoctoproject.org/singleindex.html#term-SRCREV warns:
> "Note that if you want to build a fixed revision and you want to avoid
> performing a query on the remote repository every time BitBake parses your
> recipe, you should specify a SRCREV that is a full revision identifier and not
> just a tag."

Thats quite an argument. I'll send a patch for it

Am 25.01.22 um 17:45 schrieb Jan Luebbe:
> Hi Markus,
>
> On Tue, 2022-01-25 at 14:28 +0100, Markus Volk wrote:
>> Hi Jan,
>>
>> it is also allowed to use tags here.
>>
>> SRCREV= "gnome-40.0" fetches the same code as
>>
>> SRCREV = "e561775c1580a9f60a726355b2b897bfc9cb3382"
> That's only true as long as nobody modifies that tag in the upstream repository
> and isn't cryptographically secure. As far as I can see, no existing recipe in
> meta-oe or oe-core uses a tag as SRCREV.
>
>
> Regards,
> Jan
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95072): https://lists.openembedded.org/g/openembedded-devel/message/95072
> Mute This Topic: https://lists.openembedded.org/mt/88611343/3618223
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [f_l_k@t-online.de]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [oe] [meta-gnome][PATCH 1/2] geary: initial add recipe

[Markus Volk]

sent a patch to fix this

Am 25.01.22 um 18:28 schrieb Khem Raj:
>
>
> On 1/25/22 9:00 AM, Markus Volk wrote:
>> Thats right. I did it like this because it would be then  only be 
>> needed to change the PV in the recipe name to get the SRCREV updated 
>> on a version update (of course assumed that the tag name wasn't 
>> modified).
>>
>>> Additionally, 
>>> https://docs.yoctoproject.org/singleindex.html#term-SRCREV warns:
>>> "Note that if you want to build a fixed revision and you want to avoid
>>> performing a query on the remote repository every time BitBake 
>>> parses your
>>> recipe, you should specify a SRCREV that is a full revision 
>>> identifier and not
>>> just a tag."
>>
>> Thats quite an argument. I'll send a patch for it
>
> using tags is not going to work when network is disabled, so please 
> use a proper SHA1
>
>>
>> Am 25.01.22 um 17:45 schrieb Jan Luebbe:
>>> Hi Markus,
>>>
>>> On Tue, 2022-01-25 at 14:28 +0100, Markus Volk wrote:
>>>> Hi Jan,
>>>>
>>>> it is also allowed to use tags here.
>>>>
>>>> SRCREV= "gnome-40.0" fetches the same code as
>>>>
>>>> SRCREV = "e561775c1580a9f60a726355b2b897bfc9cb3382"
>>> That's only true as long as nobody modifies that tag in the upstream 
>>> repository
>>> and isn't cryptographically secure. As far as I can see, no existing 
>>> recipe in
>>> meta-oe or oe-core uses a tag as SRCREV.
>>>
>>>
>>> Regards,
>>> Jan
>>>
>>>
>>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#95074): 
>> https://lists.openembedded.org/g/openembedded-devel/message/95074
>> Mute This Topic: https://lists.openembedded.org/mt/88611343/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: 
>> https://lists.openembedded.org/g/openembedded-devel/unsub 
>> [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>