* [LTP] [PATCH v2 1/1] quotactl: Check for missing quota_v2 module
@ 2022-03-15 9:49 Petr Vorel
2022-03-15 9:55 ` xuyang2018.jy
2022-03-15 13:44 ` Martin Doucha
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2022-03-15 9:49 UTC (permalink / raw)
To: ltp; +Cc: Martin Doucha
openSUSE JeOS allowed installation without quota_v2 (they were in
kernel-default, but by default kernel-default-base with smaller subset
of kernel modules is installed).
Therefore check for the module for all tests which require CONFIG_QFMT_V2
config and remove now redundant CONFIG_QFMT_V2 check.
Fixes: https://bugzilla.opensuse.org/show_bug.cgi?id=1196585
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
* remove CONFIG_QFMT_V2 check
testcases/kernel/syscalls/quotactl/quotactl01.c | 4 ++--
testcases/kernel/syscalls/quotactl/quotactl04.c | 4 ++--
testcases/kernel/syscalls/quotactl/quotactl06.c | 4 ++--
testcases/kernel/syscalls/quotactl/quotactl08.c | 4 ++--
testcases/kernel/syscalls/quotactl/quotactl09.c | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/testcases/kernel/syscalls/quotactl/quotactl01.c b/testcases/kernel/syscalls/quotactl/quotactl01.c
index 561e5030fe..63f6e9181c 100644
--- a/testcases/kernel/syscalls/quotactl/quotactl01.c
+++ b/testcases/kernel/syscalls/quotactl/quotactl01.c
@@ -213,8 +213,8 @@ static void verify_quota(unsigned int n)
static struct tst_test test = {
.needs_root = 1,
- .needs_kconfigs = (const char *[]) {
- "CONFIG_QFMT_V2",
+ .needs_drivers = (const char *const []) {
+ "quota_v2",
NULL
},
.test = verify_quota,
diff --git a/testcases/kernel/syscalls/quotactl/quotactl04.c b/testcases/kernel/syscalls/quotactl/quotactl04.c
index 55da282705..fdd1c9b502 100644
--- a/testcases/kernel/syscalls/quotactl/quotactl04.c
+++ b/testcases/kernel/syscalls/quotactl/quotactl04.c
@@ -162,8 +162,8 @@ static void verify_quota(unsigned int n)
static struct tst_test test = {
.needs_root = 1,
- .needs_kconfigs = (const char *[]) {
- "CONFIG_QFMT_V2",
+ .needs_drivers = (const char *const []) {
+ "quota_v2",
NULL
},
.min_kver = "4.10", /* commit 689c958cbe6b (ext4: add project quota support) */
diff --git a/testcases/kernel/syscalls/quotactl/quotactl06.c b/testcases/kernel/syscalls/quotactl/quotactl06.c
index 87715237f5..feb475022d 100644
--- a/testcases/kernel/syscalls/quotactl/quotactl06.c
+++ b/testcases/kernel/syscalls/quotactl/quotactl06.c
@@ -216,8 +216,8 @@ static void cleanup(void)
static struct tst_test test = {
.setup = setup,
.cleanup = cleanup,
- .needs_kconfigs = (const char *[]) {
- "CONFIG_QFMT_V2",
+ .needs_drivers = (const char *const []) {
+ "quota_v2",
NULL
},
.tcnt = ARRAY_SIZE(tcases),
diff --git a/testcases/kernel/syscalls/quotactl/quotactl08.c b/testcases/kernel/syscalls/quotactl/quotactl08.c
index 3793867f23..da1d62a32f 100644
--- a/testcases/kernel/syscalls/quotactl/quotactl08.c
+++ b/testcases/kernel/syscalls/quotactl/quotactl08.c
@@ -208,8 +208,8 @@ static void verify_quota(unsigned int n)
static struct tst_test test = {
.needs_root = 1,
- .needs_kconfigs = (const char *[]) {
- "CONFIG_QFMT_V2",
+ .needs_drivers = (const char *const []) {
+ "quota_v2",
NULL
},
.test = verify_quota,
diff --git a/testcases/kernel/syscalls/quotactl/quotactl09.c b/testcases/kernel/syscalls/quotactl/quotactl09.c
index 8b959909ca..9a03bff5f4 100644
--- a/testcases/kernel/syscalls/quotactl/quotactl09.c
+++ b/testcases/kernel/syscalls/quotactl/quotactl09.c
@@ -170,8 +170,8 @@ static void cleanup(void)
static struct tst_test test = {
.setup = setup,
.cleanup = cleanup,
- .needs_kconfigs = (const char *[]) {
- "CONFIG_QFMT_V2",
+ .needs_drivers = (const char *const []) {
+ "quota_v2",
NULL
},
.tcnt = ARRAY_SIZE(tcases),
--
2.35.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH v2 1/1] quotactl: Check for missing quota_v2 module
2022-03-15 9:49 [LTP] [PATCH v2 1/1] quotactl: Check for missing quota_v2 module Petr Vorel
@ 2022-03-15 9:55 ` xuyang2018.jy
2022-03-15 13:44 ` Martin Doucha
1 sibling, 0 replies; 4+ messages in thread
From: xuyang2018.jy @ 2022-03-15 9:55 UTC (permalink / raw)
To: Petr Vorel; +Cc: Martin Doucha, ltp
Hi Petr
Looks good to me,
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Best Regards
Yang Xu
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v2 1/1] quotactl: Check for missing quota_v2 module
2022-03-15 9:49 [LTP] [PATCH v2 1/1] quotactl: Check for missing quota_v2 module Petr Vorel
2022-03-15 9:55 ` xuyang2018.jy
@ 2022-03-15 13:44 ` Martin Doucha
2022-03-15 15:29 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Martin Doucha @ 2022-03-15 13:44 UTC (permalink / raw)
To: Petr Vorel, ltp
Hi,
I've verified that this patch fixes the missing module issues on SLE
kernel-default-base.
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
On 15. 03. 22 10:49, Petr Vorel wrote:
> openSUSE JeOS allowed installation without quota_v2 (they were in
> kernel-default, but by default kernel-default-base with smaller subset
> of kernel modules is installed).
>
> Therefore check for the module for all tests which require CONFIG_QFMT_V2
> config and remove now redundant CONFIG_QFMT_V2 check.
>
> Fixes: https://bugzilla.opensuse.org/show_bug.cgi?id=1196585
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Changes v1->v2:
> * remove CONFIG_QFMT_V2 check
>
> testcases/kernel/syscalls/quotactl/quotactl01.c | 4 ++--
> testcases/kernel/syscalls/quotactl/quotactl04.c | 4 ++--
> testcases/kernel/syscalls/quotactl/quotactl06.c | 4 ++--
> testcases/kernel/syscalls/quotactl/quotactl08.c | 4 ++--
> testcases/kernel/syscalls/quotactl/quotactl09.c | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl01.c b/testcases/kernel/syscalls/quotactl/quotactl01.c
> index 561e5030fe..63f6e9181c 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl01.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl01.c
> @@ -213,8 +213,8 @@ static void verify_quota(unsigned int n)
>
> static struct tst_test test = {
> .needs_root = 1,
> - .needs_kconfigs = (const char *[]) {
> - "CONFIG_QFMT_V2",
> + .needs_drivers = (const char *const []) {
> + "quota_v2",
> NULL
> },
> .test = verify_quota,
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl04.c b/testcases/kernel/syscalls/quotactl/quotactl04.c
> index 55da282705..fdd1c9b502 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl04.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl04.c
> @@ -162,8 +162,8 @@ static void verify_quota(unsigned int n)
>
> static struct tst_test test = {
> .needs_root = 1,
> - .needs_kconfigs = (const char *[]) {
> - "CONFIG_QFMT_V2",
> + .needs_drivers = (const char *const []) {
> + "quota_v2",
> NULL
> },
> .min_kver = "4.10", /* commit 689c958cbe6b (ext4: add project quota support) */
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl06.c b/testcases/kernel/syscalls/quotactl/quotactl06.c
> index 87715237f5..feb475022d 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl06.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl06.c
> @@ -216,8 +216,8 @@ static void cleanup(void)
> static struct tst_test test = {
> .setup = setup,
> .cleanup = cleanup,
> - .needs_kconfigs = (const char *[]) {
> - "CONFIG_QFMT_V2",
> + .needs_drivers = (const char *const []) {
> + "quota_v2",
> NULL
> },
> .tcnt = ARRAY_SIZE(tcases),
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl08.c b/testcases/kernel/syscalls/quotactl/quotactl08.c
> index 3793867f23..da1d62a32f 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl08.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl08.c
> @@ -208,8 +208,8 @@ static void verify_quota(unsigned int n)
>
> static struct tst_test test = {
> .needs_root = 1,
> - .needs_kconfigs = (const char *[]) {
> - "CONFIG_QFMT_V2",
> + .needs_drivers = (const char *const []) {
> + "quota_v2",
> NULL
> },
> .test = verify_quota,
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl09.c b/testcases/kernel/syscalls/quotactl/quotactl09.c
> index 8b959909ca..9a03bff5f4 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl09.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl09.c
> @@ -170,8 +170,8 @@ static void cleanup(void)
> static struct tst_test test = {
> .setup = setup,
> .cleanup = cleanup,
> - .needs_kconfigs = (const char *[]) {
> - "CONFIG_QFMT_V2",
> + .needs_drivers = (const char *const []) {
> + "quota_v2",
> NULL
> },
> .tcnt = ARRAY_SIZE(tcases),
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-15 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 9:49 [LTP] [PATCH v2 1/1] quotactl: Check for missing quota_v2 module Petr Vorel
2022-03-15 9:55 ` xuyang2018.jy
2022-03-15 13:44 ` Martin Doucha
2022-03-15 15:29 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.