* [RFC BlueZ] adapter: Introduce BTD_ADAPTER_DBG
@ 2022-03-23 20:52 Luiz Augusto von Dentz
2022-03-23 22:31 ` [RFC,BlueZ] " bluez.test.bot
0 siblings, 1 reply; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2022-03-23 20:52 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This introduces BTD_ADAPTER_DBG which includes the controller index
when using DBG_IDX, in addition to it also add similar macro for
devices in the form of BTD_DEVICE_DBG which resolves the adapter and
before calling BTD_ADAPTER_DBG.
---
src/adapter.h | 4 ++++
src/device.h | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/src/adapter.h b/src/adapter.h
index 35deb1d11..515be3210 100644
--- a/src/adapter.h
+++ b/src/adapter.h
@@ -23,6 +23,10 @@
/* Invalid SSP passkey value used to indicate negative replies */
#define INVALID_PASSKEY 0xffffffff
+#define BTD_ADAPTER_DBG(adapter, fmt, arg...) \
+ DBG_IDX(btd_adapter_get_index(adapter), "%s:%s() " fmt, __FILE__, \
+ __func__ , ## arg)
+
struct btd_adapter;
struct btd_device;
struct queue;
diff --git a/src/device.h b/src/device.h
index 071576d6b..4d40d1d22 100644
--- a/src/device.h
+++ b/src/device.h
@@ -11,6 +11,10 @@
#define DEVICE_INTERFACE "org.bluez.Device1"
+#define BTD_DEVICE_DBG(device, fmt, arg...) \
+ BTD_ADAPTER_DBG(device_get_adapter(device), "%s:%s() " fmt, __FILE__, \
+ __func__ , ## arg)
+
struct btd_device;
struct btd_device *device_create(struct btd_adapter *adapter,
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [RFC,BlueZ] adapter: Introduce BTD_ADAPTER_DBG
2022-03-23 20:52 [RFC BlueZ] adapter: Introduce BTD_ADAPTER_DBG Luiz Augusto von Dentz
@ 2022-03-23 22:31 ` bluez.test.bot
0 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2022-03-23 22:31 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 2037 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=625859
---Test result---
Test Summary:
CheckPatch FAIL 0.69 seconds
GitLint PASS 0.46 seconds
Prep - Setup ELL PASS 49.83 seconds
Build - Prep PASS 0.62 seconds
Build - Configure PASS 9.65 seconds
Build - Make PASS 1651.60 seconds
Make Check PASS 13.21 seconds
Make Check w/Valgrind PASS 525.62 seconds
Make Distcheck PASS 270.47 seconds
Build w/ext ELL - Configure PASS 9.85 seconds
Build w/ext ELL - Make PASS 1716.04 seconds
Incremental Build with patchesPASS 0.00 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[RFC,BlueZ] adapter: Introduce BTD_ADAPTER_DBG
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#99: FILE: src/adapter.h:28:
+ __func__ , ## arg)
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#114: FILE: src/device.h:16:
+ __func__ , ## arg)
^
/github/workspace/src/12790144.patch total: 2 errors, 0 warnings, 20 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12790144.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC BlueZ] adapter: Introduce BTD_ADAPTER_DBG
@ 2022-03-23 22:39 Luiz Augusto von Dentz
2022-03-24 2:49 ` [RFC,BlueZ] " bluez.test.bot
2022-03-24 19:50 ` [RFC BlueZ] " patchwork-bot+bluetooth
0 siblings, 2 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2022-03-23 22:39 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This introduces BTD_ADAPTER_DBG which includes the controller index
when using DBG_IDX, in addition to it also add similar macro for
devices in the form of BTD_DEVICE_DBG which resolves the adapter and
before calling BTD_ADAPTER_DBG.
---
src/adapter.h | 4 ++++
src/device.h | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/src/adapter.h b/src/adapter.h
index 35deb1d11..515be3210 100644
--- a/src/adapter.h
+++ b/src/adapter.h
@@ -23,6 +23,10 @@
/* Invalid SSP passkey value used to indicate negative replies */
#define INVALID_PASSKEY 0xffffffff
+#define BTD_ADAPTER_DBG(adapter, fmt, arg...) \
+ DBG_IDX(btd_adapter_get_index(adapter), "%s:%s() " fmt, __FILE__, \
+ __func__ , ## arg)
+
struct btd_adapter;
struct btd_device;
struct queue;
diff --git a/src/device.h b/src/device.h
index 071576d6b..4d40d1d22 100644
--- a/src/device.h
+++ b/src/device.h
@@ -11,6 +11,10 @@
#define DEVICE_INTERFACE "org.bluez.Device1"
+#define BTD_DEVICE_DBG(device, fmt, arg...) \
+ BTD_ADAPTER_DBG(device_get_adapter(device), "%s:%s() " fmt, __FILE__, \
+ __func__ , ## arg)
+
struct btd_device;
struct btd_device *device_create(struct btd_adapter *adapter,
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [RFC,BlueZ] adapter: Introduce BTD_ADAPTER_DBG
2022-03-23 22:39 [RFC BlueZ] " Luiz Augusto von Dentz
@ 2022-03-24 2:49 ` bluez.test.bot
2022-03-24 19:50 ` [RFC BlueZ] " patchwork-bot+bluetooth
1 sibling, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2022-03-24 2:49 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 2813 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=625872
---Test result---
Test Summary:
CheckPatch FAIL 12.99 seconds
GitLint PASS 8.66 seconds
Prep - Setup ELL PASS 40.22 seconds
Build - Prep PASS 0.68 seconds
Build - Configure PASS 8.17 seconds
Build - Make PASS 1211.61 seconds
Make Check PASS 10.97 seconds
Make Check w/Valgrind PASS 417.60 seconds
Make Distcheck PASS 222.33 seconds
Build w/ext ELL - Configure PASS 8.66 seconds
Build w/ext ELL - Make PASS 1243.22 seconds
Incremental Build with patchesPASS 11501.91 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[RFC,BlueZ] adapter: Introduce BTD_ADAPTER_DBG
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#99: FILE: src/adapter.h:28:
+ __func__ , ## arg)
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#114: FILE: src/device.h:16:
+ __func__ , ## arg)
^
/github/workspace/src/12790172.patch total: 2 errors, 0 warnings, 20 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12790172.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,v4,3/9] mgmt: Introduce mgmt_set_verbose
WARNING:REPEATED_WORD: Possible repeated word: 'the'
#83:
the the likes hexdump of packets, by default it is disabled since in
/github/workspace/src/12790175.patch total: 0 errors, 1 warnings, 61 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12790175.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC BlueZ] adapter: Introduce BTD_ADAPTER_DBG
2022-03-23 22:39 [RFC BlueZ] " Luiz Augusto von Dentz
2022-03-24 2:49 ` [RFC,BlueZ] " bluez.test.bot
@ 2022-03-24 19:50 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+bluetooth @ 2022-03-24 19:50 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hello:
This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Wed, 23 Mar 2022 15:39:54 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> This introduces BTD_ADAPTER_DBG which includes the controller index
> when using DBG_IDX, in addition to it also add similar macro for
> devices in the form of BTD_DEVICE_DBG which resolves the adapter and
> before calling BTD_ADAPTER_DBG.
>
> [...]
Here is the summary with links:
- [RFC,BlueZ] adapter: Introduce BTD_ADAPTER_DBG
(no matching commit)
- [BlueZ,v4,2/9] mgmt: Add DBG macro
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f9cb7c802f27
- [BlueZ,v4,3/9] mgmt: Introduce mgmt_set_verbose
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b7c807269f1f
- [BlueZ,v4,4/9] adapter: Don't use DBG in mgmt_debug
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=62c6037ea02b
- [BlueZ,v4,5/9] att: Log file and function names
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8039d42687fd
- [BlueZ,v4,6/9] gatt-client: Add DBG macro
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e0870ce5e1fe
- [BlueZ,v4,7/9] gatt-server: Add DBG macro
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=55c25d91e4d6
- [BlueZ,v4,8/9] att: Rename att_debug and att_verbose to DBG and VERBOSE
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e1b808c128fa
- [BlueZ,v4,9/9] device: Don't use DBG in gatt_debug
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=71cec503c8da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-24 19:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 20:52 [RFC BlueZ] adapter: Introduce BTD_ADAPTER_DBG Luiz Augusto von Dentz
2022-03-23 22:31 ` [RFC,BlueZ] " bluez.test.bot
2022-03-23 22:39 [RFC BlueZ] " Luiz Augusto von Dentz
2022-03-24 2:49 ` [RFC,BlueZ] " bluez.test.bot
2022-03-24 19:50 ` [RFC BlueZ] " patchwork-bot+bluetooth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.