All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	Jate Sujjavanich <jatedev@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 2/2] iputils: Use STAGING_DIR_NATIVE for setcap detection
Date: Thu, 18 Feb 2021 21:44:06 +0000	[thread overview]
Message-ID: <623d1b0df8dec2247f9d0c41ca8372cfb0af59e8.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj9W4N0VeTi2WOQYG0c_XzwYX0EwEXD-GVkoUz_ciaoUCw@mail.gmail.com>

On Thu, 2021-02-18 at 20:58 +0100, Alexander Kanavin wrote:
> On Thu, 18 Feb 2021 at 20:22, Jate Sujjavanich <jatedev@gmail.com> wrote:
> > +-setcap = find_program('setcap', '/usr/sbin/setcap', '/sbin/setcap', required : false)
> > ++stagingdirnative = get_option('stagingdirnative')
> > ++setcap = find_program(stagingdirnative + '/usr/sbin/setcap', stagingdirnative + '/sbin/setcap', required
> > : false)
> > 
> 
> Just remove the hardcoded paths from find_program altogether (see meson manual), and it will take the binary
> from PATH env var, which is exactly how native sysroots are supposed to work.

I'm guessing upstream does this so you can build as a normal user who
doesn't have sbin in PATH and still use setcap during "make install".

We need something upstream might accept. I suspect what we need here 
is a way to specify a specific path to the util and then fall back on 
the current approach if the feature is enabled but no path provided. 
Please do ensure that it won't look in the host's directories unless 
its enabled though.

Cheers,

Richard


  reply	other threads:[~2021-02-18 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 19:21 [PATCH v2 1/2] Revert "iputils: Fix build determinism" Jate Sujjavanich
2021-02-18 19:21 ` [PATCH v2 2/2] iputils: Use STAGING_DIR_NATIVE for setcap detection Jate Sujjavanich
2021-02-18 19:58   ` Alexander Kanavin
2021-02-18 21:44     ` Richard Purdie [this message]
2021-02-19 11:26       ` [OE-core] " Jose Quaresma
2021-02-19 11:34         ` Richard Purdie
2021-02-19 17:37           ` Jate Sujjavanich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=623d1b0df8dec2247f9d0c41ca8372cfb0af59e8.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=jatedev@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.