All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jate Sujjavanich" <jatedev@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Jose Quaresma <quaresma.jose@gmail.com>,
	Alexander Kanavin <alex.kanavin@gmail.com>,
	 OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2 2/2] iputils: Use STAGING_DIR_NATIVE for setcap detection
Date: Fri, 19 Feb 2021 12:37:21 -0500	[thread overview]
Message-ID: <CAPphmgbB5Us5sWaqZj7vOvrMyy=bABREa4=KsQP4E6Rq1oodqg@mail.gmail.com> (raw)
In-Reply-To: <617da916aa05ce7cb4c8c0d6367ea02bf1d1ffec.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

I think we need the revert patch, the libcap-native DEPENDS, and then some
logic to exclude the hard-coded paths to setcap if we are cross-compiling.
This seems more mesonic and may be submittable upstream. Your hypothesis
that they hard code the setcap paths for non-root users makes sense,
Richard.

Per Alex, oe-core does exclude the build machine from PATH in the cross
environment. I was going by the PATH in the target devshell which adds the
build machine's paths.

Version 3 of the patchset is forthcoming.

- Jate

On Fri, Feb 19, 2021 at 6:34 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2021-02-19 at 11:26 +0000, Jose Quaresma wrote:
> > The only change needed on the recipe are:
> >
> > -PACKAGECONFIG[libcap] = "-DUSE_CAP=true, -DUSE_CAP=false, libcap"
> > +PACKAGECONFIG[libcap] = "-DUSE_CAP=true, -DUSE_CAP=false, libcap
> libcap-native"
> >
> > The patch 0001-Add-support-for-setcap-in-STAGING_DIR_NATIVE.patch is not
> need because
> > with the addition of the libcap-native the meson find_program will find
> the setcap binary on the native
> > sysroot and will use it.
>
> Ok, we can take that change.
>
> I'm assuming you still want/need the revert (patch 1/2) as well
> though?
>
> That does give us a problem since on systems where libcap
> isn't in PACKAGECONFIG, the binaries will be non-deterministic
> again.
>
> Cheers,
>
> Richard
>
>
>

[-- Attachment #2: Type: text/html, Size: 1917 bytes --]

      reply	other threads:[~2021-02-19 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 19:21 [PATCH v2 1/2] Revert "iputils: Fix build determinism" Jate Sujjavanich
2021-02-18 19:21 ` [PATCH v2 2/2] iputils: Use STAGING_DIR_NATIVE for setcap detection Jate Sujjavanich
2021-02-18 19:58   ` Alexander Kanavin
2021-02-18 21:44     ` Richard Purdie
2021-02-19 11:26       ` [OE-core] " Jose Quaresma
2021-02-19 11:34         ` Richard Purdie
2021-02-19 17:37           ` Jate Sujjavanich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPphmgbB5Us5sWaqZj7vOvrMyy=bABREa4=KsQP4E6Rq1oodqg@mail.gmail.com' \
    --to=jatedev@gmail.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quaresma.jose@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.