* [PATCH v2 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
@ 2022-05-24 5:56 Ahmad Fatoum
2022-05-24 5:56 ` [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2022-05-24 5:56 UTC (permalink / raw)
Cc: kernel, Krzysztof Kozlowski, Linus Walleij, Ahmad Fatoum,
linux-kernel, linux-bluetooth, David S. Miller, Jakub Kicinski,
Paolo Abeni, netdev, Rob Herring, Krzysztof Kozlowski,
devicetree
The BCM4349B1, aka CYW/BCM89359, is a WiFi+BT chip and its Bluetooth
portion can be controlled over serial.
Extend the binding with its DT compatible.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
- reword commit message to make it clear that BCM4349B1 and
BCM89359 are the same chip
- remove reference to BT being 5.0. Datasheet says 4.1.
- Collect Acked-by/Reviewed-by
---
To: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
To: devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org
---
Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index 5aac094fd217..58ecafc1b7f9 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -23,6 +23,7 @@ properties:
- brcm,bcm4345c5
- brcm,bcm43540-bt
- brcm,bcm4335a0
+ - brcm,bcm4349-bt
shutdown-gpios:
maxItems: 1
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant
2022-05-24 5:56 [PATCH v2 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
@ 2022-05-24 5:56 ` Ahmad Fatoum
2022-05-24 8:08 ` Linus Walleij
2022-05-24 7:10 ` [v2,1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding bluez.test.bot
2022-06-05 4:50 ` [PATCH v2 1/2] " patchwork-bot+bluetooth
2 siblings, 1 reply; 5+ messages in thread
From: Ahmad Fatoum @ 2022-05-24 5:56 UTC (permalink / raw)
Cc: kernel, Ahmad Fatoum, Rob Herring, Krzysztof Kozlowski,
linux-kernel, linux-bluetooth, David S. Miller, Jakub Kicinski,
Paolo Abeni, Linus Walleij, devicetree, netdev, Marcel Holtmann,
Johan Hedberg, Luiz Augusto von Dentz
The BCM4349B1, aka CYW/BCM89359, is a WiFi+BT chip and its Bluetooth
portion can be controlled over serial.
Two subversions are added for the chip, because ROM firmware reports
002.002.013 (at least for the chips I have here), while depending on
patchram firmware revision, either 002.002.013 or 002.002.014 is
reported.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
- No changes
---
To: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org
---
drivers/bluetooth/btbcm.c | 2 ++
drivers/bluetooth/hci_bcm.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index d9ceca7a7935..a18f289d7346 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -453,6 +453,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
{ 0x6606, "BCM4345C5" }, /* 003.006.006 */
{ 0x230f, "BCM4356A2" }, /* 001.003.015 */
{ 0x220e, "BCM20702A1" }, /* 001.002.014 */
+ { 0x420d, "BCM4349B1" }, /* 002.002.013 */
+ { 0x420e, "BCM4349B1" }, /* 002.002.014 */
{ 0x4217, "BCM4329B1" }, /* 002.002.023 */
{ 0x6106, "BCM4359C0" }, /* 003.001.006 */
{ 0x4106, "BCM4335A0" }, /* 002.001.006 */
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 785f445dd60d..d0a6f9ff4e08 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1544,6 +1544,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm43430a0-bt" },
{ .compatible = "brcm,bcm43430a1-bt" },
{ .compatible = "brcm,bcm43438-bt", .data = &bcm43438_device_data },
+ { .compatible = "brcm,bcm4349-bt", .data = &bcm43438_device_data },
{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
{ .compatible = "brcm,bcm4335a0" },
{ },
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [v2,1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-24 5:56 [PATCH v2 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
2022-05-24 5:56 ` [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
@ 2022-05-24 7:10 ` bluez.test.bot
2022-06-05 4:50 ` [PATCH v2 1/2] " patchwork-bot+bluetooth
2 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2022-05-24 7:10 UTC (permalink / raw)
To: linux-bluetooth, a.fatoum
[-- Attachment #1: Type: text/plain, Size: 2549 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=644532
---Test result---
Test Summary:
CheckPatch FAIL 3.26 seconds
GitLint PASS 1.86 seconds
SubjectPrefix FAIL 0.83 seconds
BuildKernel PASS 28.14 seconds
BuildKernel32 PASS 27.09 seconds
Incremental Build with patchesPASS 42.68 seconds
TestRunner: Setup PASS 446.89 seconds
TestRunner: l2cap-tester PASS 17.84 seconds
TestRunner: bnep-tester PASS 6.07 seconds
TestRunner: mgmt-tester PASS 102.67 seconds
TestRunner: rfcomm-tester PASS 9.64 seconds
TestRunner: sco-tester PASS 9.38 seconds
TestRunner: smp-tester PASS 9.55 seconds
TestRunner: userchan-tester PASS 6.30 seconds
Details
##############################
Test: CheckPatch - FAIL - 3.26 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
[v2,1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding\WARNING:BAD_SIGN_OFF: Duplicate signature
#94:
Cc: linux-kernel@vger.kernel.org
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12859675.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[v2,2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant\WARNING:BAD_SIGN_OFF: Duplicate signature
#95:
Cc: linux-kernel@vger.kernel.org
total: 0 errors, 1 warnings, 15 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12859676.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: SubjectPrefix - FAIL - 0.83 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant
2022-05-24 5:56 ` [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
@ 2022-05-24 8:08 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2022-05-24 8:08 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: kernel, Rob Herring, Krzysztof Kozlowski, linux-kernel,
linux-bluetooth, David S. Miller, Jakub Kicinski, Paolo Abeni,
devicetree, netdev, Marcel Holtmann, Johan Hedberg,
Luiz Augusto von Dentz
On Tue, May 24, 2022 at 7:56 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> The BCM4349B1, aka CYW/BCM89359, is a WiFi+BT chip and its Bluetooth
> portion can be controlled over serial.
>
> Two subversions are added for the chip, because ROM firmware reports
> 002.002.013 (at least for the chips I have here), while depending on
> patchram firmware revision, either 002.002.013 or 002.002.014 is
> reported.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
> - No changes
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-24 5:56 [PATCH v2 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
2022-05-24 5:56 ` [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
2022-05-24 7:10 ` [v2,1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding bluez.test.bot
@ 2022-06-05 4:50 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+bluetooth @ 2022-06-05 4:50 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: kernel, krzysztof.kozlowski, linus.walleij, linux-kernel,
linux-bluetooth, davem, kuba, pabeni, netdev, robh+dt,
krzysztof.kozlowski+dt, devicetree
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:
On Tue, 24 May 2022 07:56:40 +0200 you wrote:
> The BCM4349B1, aka CYW/BCM89359, is a WiFi+BT chip and its Bluetooth
> portion can be controlled over serial.
> Extend the binding with its DT compatible.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> [...]
Here is the summary with links:
- [v2,1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
https://git.kernel.org/bluetooth/bluetooth-next/c/534fdae369a8
- [v2,2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant
https://git.kernel.org/bluetooth/bluetooth-next/c/a589ee43644c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-05 4:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 5:56 [PATCH v2 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
2022-05-24 5:56 ` [PATCH v2 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
2022-05-24 8:08 ` Linus Walleij
2022-05-24 7:10 ` [v2,1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding bluez.test.bot
2022-06-05 4:50 ` [PATCH v2 1/2] " patchwork-bot+bluetooth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.