* [PATCH] Bluetooth:btrtl:Fix typo in comment
@ 2022-07-19 15:41 shaomin Deng
2022-07-19 16:10 ` bluez.test.bot
2022-07-19 19:28 ` [PATCH] " Paul Menzel
0 siblings, 2 replies; 4+ messages in thread
From: shaomin Deng @ 2022-07-19 15:41 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz, linux-bluetooth; +Cc: shaomin Deng
Delete the repeated word "that" in comments.
Signed-off-by: shaomin Deng <dengshaomin@cdjrlc.com>
---
drivers/bluetooth/btrtl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 47c28fd8f006..fb52313a1d45 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -330,7 +330,7 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
/* Loop from the end of the firmware parsing instructions, until
* we find an instruction that identifies the "project ID" for the
* hardware supported by this firwmare file.
- * Once we have that, we double-check that that project_id is suitable
+ * Once we have that, we double-check that project_id is suitable
* for the hardware we are working with.
*/
while (fwptr >= btrtl_dev->fw_data + (sizeof(*epatch_info) + 3)) {
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: Bluetooth:btrtl:Fix typo in comment
2022-07-19 15:41 [PATCH] Bluetooth:btrtl:Fix typo in comment shaomin Deng
@ 2022-07-19 16:10 ` bluez.test.bot
2022-07-19 19:28 ` [PATCH] " Paul Menzel
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2022-07-19 16:10 UTC (permalink / raw)
To: linux-bluetooth, dengshaomin
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=661165
---Test result---
Test Summary:
CheckPatch PASS 1.13 seconds
GitLint PASS 0.54 seconds
SubjectPrefix FAIL 0.40 seconds
BuildKernel PASS 33.58 seconds
BuildKernel32 PASS 28.97 seconds
Incremental Build with patchesPASS 41.56 seconds
TestRunner: Setup PASS 497.27 seconds
TestRunner: l2cap-tester PASS 16.71 seconds
TestRunner: bnep-tester PASS 5.57 seconds
TestRunner: mgmt-tester PASS 96.20 seconds
TestRunner: rfcomm-tester PASS 8.98 seconds
TestRunner: sco-tester PASS 8.72 seconds
TestRunner: smp-tester PASS 8.80 seconds
TestRunner: userchan-tester PASS 5.75 seconds
Details
##############################
Test: SubjectPrefix - FAIL - 0.40 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth:btrtl:Fix typo in comment
2022-07-19 15:41 [PATCH] Bluetooth:btrtl:Fix typo in comment shaomin Deng
2022-07-19 16:10 ` bluez.test.bot
@ 2022-07-19 19:28 ` Paul Menzel
1 sibling, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2022-07-19 19:28 UTC (permalink / raw)
To: Shaomin Deng; +Cc: marcel, johan.hedberg, luiz.dentz, linux-bluetooth
Dear Shaomin,
Am 19.07.22 um 17:41 schrieb shaomin Deng:
> Delete the repeated word "that" in comments.
Maybe start your first name with a capital letter?
git config --global user.name "Shaomin Deng"
In the commit message summary, please add a space after the colons, and
maybe use:
Bluetooth: btrtl: Remove duplicate *that* in comment
>
> Signed-off-by: shaomin Deng <dengshaomin@cdjrlc.com>
> ---
> drivers/bluetooth/btrtl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 47c28fd8f006..fb52313a1d45 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -330,7 +330,7 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
> /* Loop from the end of the firmware parsing instructions, until
> * we find an instruction that identifies the "project ID" for the
> * hardware supported by this firwmare file.
firmware
It’d be great if you fixed that in a separate commit.
> - * Once we have that, we double-check that that project_id is suitable
> + * Once we have that, we double-check that project_id is suitable
It’s a lot of “that”, but it’s actually correct.
> * for the hardware we are working with.
> */
> while (fwptr >= btrtl_dev->fw_data + (sizeof(*epatch_info) + 3)) {
Kind regards,
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: Bluetooth: btrtl: Fix typo in comment
2022-07-20 14:10 [PATCH] Bluetooth: btrtl: Fix " shaomin Deng
@ 2022-07-20 15:02 ` bluez.test.bot
0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2022-07-20 15:02 UTC (permalink / raw)
To: linux-bluetooth, dengshaomin
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=661489
---Test result---
Test Summary:
CheckPatch PASS 2.00 seconds
GitLint PASS 1.00 seconds
SubjectPrefix PASS 0.83 seconds
BuildKernel PASS 35.16 seconds
BuildKernel32 PASS 31.07 seconds
Incremental Build with patchesPASS 45.10 seconds
TestRunner: Setup PASS 537.85 seconds
TestRunner: l2cap-tester PASS 17.60 seconds
TestRunner: bnep-tester PASS 6.18 seconds
TestRunner: mgmt-tester PASS 100.57 seconds
TestRunner: rfcomm-tester PASS 9.60 seconds
TestRunner: sco-tester PASS 9.30 seconds
TestRunner: smp-tester PASS 9.31 seconds
TestRunner: userchan-tester PASS 6.26 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-20 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 15:41 [PATCH] Bluetooth:btrtl:Fix typo in comment shaomin Deng
2022-07-19 16:10 ` bluez.test.bot
2022-07-19 19:28 ` [PATCH] " Paul Menzel
2022-07-20 14:10 [PATCH] Bluetooth: btrtl: Fix " shaomin Deng
2022-07-20 15:02 ` bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.