From: David Laight <David.Laight@ACULAB.COM>
To: 'Alexey Gladkov' <legion@altlinux.ru>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "kbuild@lists.01.org" <kbuild@lists.01.org>,
Alexey Gladkov <legion@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux.dev>,
"lkp@intel.com" <lkp@intel.com>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"Eric W . Biederman" <ebiederm@xmission.com>
Subject: RE: [PATCH v1 2/2] ucounts: Move rlimit max values from ucounts max
Date: Fri, 3 Dec 2021 14:19:56 +0000 [thread overview]
Message-ID: <62f96ccd41f14b3ab504184951513a90@AcuMS.aculab.com> (raw)
In-Reply-To: <20211203135453.ld2jblkd3xtlbgrv@example.org>
From: Alexey Gladkov
> Sent: 03 December 2021 13:55
...
> > 25f9c0817c535a Eric W. Biederman 2016-08-08 108 for (i = 0; i < UCOUNT_COUNTS; i++) {
> > 25f9c0817c535a Eric W. Biederman 2016-08-08 @109 tbl[i].data = &ns->ucount_max[i];
> >
> > The patch changes the size of ->ucount_max[] to MAX_PER_NAMESPACE_UCOUNTS
> > but this loop still goes up to UCOUNT_COUNTS.
> >
> >
>
> Thanks! But a few days ago I already post a new version of this changeset
> with fix:
>
> https://lore.kernel.org/containers/24c87e225c7950bf2ea1ff4b4a8f237348808241.1638218242.git.legion@kernel.org/
Use ARRAY_SIZE() so that it 'just doesn't go wrong'.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 2/2] ucounts: Move rlimit max values from ucounts max
Date: Fri, 03 Dec 2021 14:19:56 +0000 [thread overview]
Message-ID: <62f96ccd41f14b3ab504184951513a90@AcuMS.aculab.com> (raw)
In-Reply-To: <20211203135453.ld2jblkd3xtlbgrv@example.org>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
From: Alexey Gladkov
> Sent: 03 December 2021 13:55
...
> > 25f9c0817c535a Eric W. Biederman 2016-08-08 108 for (i = 0; i < UCOUNT_COUNTS; i++) {
> > 25f9c0817c535a Eric W. Biederman 2016-08-08 @109 tbl[i].data = &ns->ucount_max[i];
> >
> > The patch changes the size of ->ucount_max[] to MAX_PER_NAMESPACE_UCOUNTS
> > but this loop still goes up to UCOUNT_COUNTS.
> >
> >
>
> Thanks! But a few days ago I already post a new version of this changeset
> with fix:
>
> https://lore.kernel.org/containers/24c87e225c7950bf2ea1ff4b4a8f237348808241.1638218242.git.legion(a)kernel.org/
Use ARRAY_SIZE() so that it 'just doesn't go wrong'.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-12-03 14:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 14:37 [PATCH v1 0/2] ucounts: Fix rlimit max values check Alexey Gladkov
2021-11-26 14:37 ` [PATCH v1 1/2] " Alexey Gladkov
2021-11-26 14:37 ` [PATCH v1 2/2] ucounts: Move rlimit max values from ucounts max Alexey Gladkov
2021-11-27 16:42 ` kernel test robot
2021-12-03 13:33 ` Dan Carpenter
2021-12-03 13:33 ` Dan Carpenter
2021-12-03 13:54 ` Alexey Gladkov
2021-12-03 13:54 ` Alexey Gladkov
2021-12-03 14:19 ` David Laight [this message]
2021-12-03 14:19 ` David Laight
2021-12-03 13:57 ` Alexey Gladkov
2021-12-03 13:57 ` Alexey Gladkov
2021-11-29 7:47 ` [ucounts] dc7e5f9d41: UBSAN:array-index-out-of-bounds_in_kernel/ucount.c kernel test robot
2021-11-29 7:47 ` kernel test robot
2021-11-29 20:37 ` [PATCH v2 0/2] ucounts: Fix rlimit max values check Alexey Gladkov
2021-11-29 20:37 ` Alexey Gladkov
2021-11-29 20:37 ` [PATCH v2 1/2] " Alexey Gladkov
2021-11-29 20:37 ` Alexey Gladkov
2021-11-29 20:37 ` [PATCH v2 2/2] ucounts: Move rlimit max values from ucounts max Alexey Gladkov
2021-11-29 20:37 ` Alexey Gladkov
2021-12-13 15:50 ` Eric W. Biederman
2021-12-13 15:50 ` Eric W. Biederman
2021-12-17 14:48 ` [PATCH v3] ucounts: Split rlimit and ucount values and max values Alexey Gladkov
2021-12-17 14:48 ` Alexey Gladkov
2021-12-19 19:54 ` Eric W. Biederman
2021-12-19 19:54 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62f96ccd41f14b3ab504184951513a90@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=containers@lists.linux.dev \
--cc=dan.carpenter@oracle.com \
--cc=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=legion@altlinux.ru \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.