All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Yi Wang <wang.yi59@zte.com.cn>,
	Liao Pingfang <liao.pingfang@zte.com.cn>,
	linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	Wang Liang <wang.liang82@zte.com.cn>,
	Xue Zhihong <xue.zhihong@zte.com.cn>
Subject: Re: [PATCH] block: Fix reference count leak in blk_integrity_add
Date: Sat, 25 Jul 2020 13:35:54 +0200	[thread overview]
Message-ID: <6301315e-1613-0970-ce9b-019d18458819@web.de> (raw)

> kobject_init_and_add() takes reference even when it fails. If this
> function returns an error, kobject_put() must be called to properly
> clean up the memory associated with the object.

* An imperative wording can be preferred for the change description,
  can't it?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Yi Wang <wang.yi59@zte.com.cn>,
	Liao Pingfang <liao.pingfang@zte.com.cn>,
	linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	Wang Liang <wang.liang82@zte.com.cn>,
	Xue Zhihong <xue.zhihong@zte.com.cn>
Subject: Re: [PATCH] block: Fix reference count leak in blk_integrity_add
Date: Sat, 25 Jul 2020 11:35:54 +0000	[thread overview]
Message-ID: <6301315e-1613-0970-ce9b-019d18458819@web.de> (raw)

> kobject_init_and_add() takes reference even when it fails. If this
> function returns an error, kobject_put() must be called to properly
> clean up the memory associated with the object.

* An imperative wording can be preferred for the change description,
  can't it?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

             reply	other threads:[~2020-07-25 11:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 11:35 Markus Elfring [this message]
2020-07-25 11:35 ` [PATCH] block: Fix reference count leak in blk_integrity_add Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-07-25  0:17 Yi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6301315e-1613-0970-ce9b-019d18458819@web.de \
    --to=markus.elfring@web.de \
    --cc=axboe@kernel.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=liao.pingfang@zte.com.cn \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wang.liang82@zte.com.cn \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.