From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 14/15] PM / Domains: Remove default_stop_ok() API
Date: Thu, 04 Sep 2014 19:49:29 +0000 [thread overview]
Message-ID: <6302495.FUvz9FPcau@vostro.rjw.lan> (raw)
In-Reply-To: <CAMuHMdUEfAdpUgEtOQfdG1gbZjVo3bfAAmhm0-miFGbQ8ckHgA@mail.gmail.com>
On Wednesday, September 03, 2014 03:15:59 PM Geert Uytterhoeven wrote:
> Hi Ulf,
>
> On Wed, Sep 3, 2014 at 12:52 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > --- a/drivers/base/power/domain_governor.c
> > +++ b/drivers/base/power/domain_governor.c
>
> > @@ -229,10 +229,7 @@ static bool always_on_power_down_ok(struct dev_pm_domain *domain)
> >
> > #else /* !CONFIG_PM_RUNTIME */
> >
> > -bool default_stop_ok(struct device *dev)
> > -{
> > - return false;
> > -}
> > +static inline bool default_stop_ok(struct device *dev) { return false; }
>
> The "inline" doesn't make much sense here.
But then it doesn't hurt either I suppose?
Anyway, Ulf, are you going to update this patch?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Linux PM list <linux-pm@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Kevin Hilman <khilman@linaro.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-sh list <linux-sh@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mark Brown <broonie@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 14/15] PM / Domains: Remove default_stop_ok() API
Date: Thu, 04 Sep 2014 21:49:29 +0200 [thread overview]
Message-ID: <6302495.FUvz9FPcau@vostro.rjw.lan> (raw)
In-Reply-To: <CAMuHMdUEfAdpUgEtOQfdG1gbZjVo3bfAAmhm0-miFGbQ8ckHgA@mail.gmail.com>
On Wednesday, September 03, 2014 03:15:59 PM Geert Uytterhoeven wrote:
> Hi Ulf,
>
> On Wed, Sep 3, 2014 at 12:52 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > --- a/drivers/base/power/domain_governor.c
> > +++ b/drivers/base/power/domain_governor.c
>
> > @@ -229,10 +229,7 @@ static bool always_on_power_down_ok(struct dev_pm_domain *domain)
> >
> > #else /* !CONFIG_PM_RUNTIME */
> >
> > -bool default_stop_ok(struct device *dev)
> > -{
> > - return false;
> > -}
> > +static inline bool default_stop_ok(struct device *dev) { return false; }
>
> The "inline" doesn't make much sense here.
But then it doesn't hurt either I suppose?
Anyway, Ulf, are you going to update this patch?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
WARNING: multiple messages have this Message-ID (diff)
From: rjw@rjwysocki.net (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/15] PM / Domains: Remove default_stop_ok() API
Date: Thu, 04 Sep 2014 21:49:29 +0200 [thread overview]
Message-ID: <6302495.FUvz9FPcau@vostro.rjw.lan> (raw)
In-Reply-To: <CAMuHMdUEfAdpUgEtOQfdG1gbZjVo3bfAAmhm0-miFGbQ8ckHgA@mail.gmail.com>
On Wednesday, September 03, 2014 03:15:59 PM Geert Uytterhoeven wrote:
> Hi Ulf,
>
> On Wed, Sep 3, 2014 at 12:52 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > --- a/drivers/base/power/domain_governor.c
> > +++ b/drivers/base/power/domain_governor.c
>
> > @@ -229,10 +229,7 @@ static bool always_on_power_down_ok(struct dev_pm_domain *domain)
> >
> > #else /* !CONFIG_PM_RUNTIME */
> >
> > -bool default_stop_ok(struct device *dev)
> > -{
> > - return false;
> > -}
> > +static inline bool default_stop_ok(struct device *dev) { return false; }
>
> The "inline" doesn't make much sense here.
But then it doesn't hurt either I suppose?
Anyway, Ulf, are you going to update this patch?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-09-04 19:49 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 10:52 [PATCH 00/15] PM / Domains: Cleanups and remove superfluous APIs Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 01/15] PM / Domains: Remove the pm_genpd_add|remove_callbacks APIs Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 02/15] PM / Domains: Ignore callbacks for subsys generic_pm_domain_data Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 03/15] PM / Domains: Remove system PM callbacks from gpd_dev_ops Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 04/15] ARM: shmobile: Drop dev_irq_safe from r8a7779 genpd config Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 05/15] ARM: shmobile: Drop dev_irq_safe from R-mobile " Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 06/15] PM / Domains: Remove dev_irq_safe from " Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 07/15] PM / Domains: Remove redundant check for CONFIG_PM Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 08/15] PM / Domains: Remove pm_genpd_syscore_switch() API Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 09/15] PM / Domains: Remove genpd_queue_power_off_work() API Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 10/15] PM / Domains: Add late_initcall to disable unused PM domains Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 11/15] ARM: exynos: Leave disabling of unused PM domains to genpd Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 12/15] ARM: s3c64xx: " Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 13/15] drivers: sh: " Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-04 0:33 ` Simon Horman
2014-09-04 0:33 ` Simon Horman
2014-09-04 0:33 ` Simon Horman
2014-09-05 8:23 ` Ulf Hansson
2014-09-05 8:23 ` Ulf Hansson
2014-09-05 8:23 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 14/15] PM / Domains: Remove default_stop_ok() API Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 13:15 ` Geert Uytterhoeven
2014-09-03 13:15 ` Geert Uytterhoeven
2014-09-03 13:15 ` Geert Uytterhoeven
2014-09-04 19:49 ` Rafael J. Wysocki [this message]
2014-09-04 19:49 ` Rafael J. Wysocki
2014-09-04 19:49 ` Rafael J. Wysocki
2014-09-05 8:16 ` Ulf Hansson
2014-09-05 8:16 ` Ulf Hansson
2014-09-05 8:16 ` Ulf Hansson
2014-09-03 10:52 ` [PATCH 15/15] PM / Domains: Keep declaration of dev_power_governors together Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 10:52 ` Ulf Hansson
2014-09-03 11:10 ` [PATCH 00/15] PM / Domains: Cleanups and remove superfluous APIs Arnd Bergmann
2014-09-03 11:10 ` Arnd Bergmann
2014-09-03 11:10 ` Arnd Bergmann
2014-09-04 8:40 ` Geert Uytterhoeven
2014-09-04 8:40 ` Geert Uytterhoeven
2014-09-05 15:35 ` Kevin Hilman
2014-09-05 15:35 ` Kevin Hilman
2014-09-05 15:35 ` Kevin Hilman
2014-09-08 22:47 ` Rafael J. Wysocki
2014-09-08 23:07 ` Rafael J. Wysocki
2014-09-08 23:07 ` Rafael J. Wysocki
2014-09-09 15:05 ` Kevin Hilman
2014-09-09 15:05 ` Kevin Hilman
2014-09-09 15:05 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6302495.FUvz9FPcau@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.