[iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git pending
head:   c25913d2c08cddcc688ae58c63f34cf8ee937e73
commit: fa89bebffc49412cc7024057efe5f02d15864c09 [2/37] iwlwifi: mei: add the driver to allow cooperation with CSME
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=fa89bebffc49412cc7024057efe5f02d15864c09
        git remote add iwlwifi-next https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git
        git fetch --no-tags iwlwifi-next pending
        git checkout fa89bebffc49412cc7024057efe5f02d15864c09
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/net/wireless/intel/iwlwifi/mei/main.c:21:
>> drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory
      14 | #include "mei/sap.h"
         |          ^~~~~~~~~~~
   compilation terminated.


vim +14 drivers/net/wireless/intel/iwlwifi/mei/trace.h

    13	
  > 14	#include "mei/sap.h"
    15	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 64724 bytes --]

Re: [iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[Coelho, Luciano]

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]

On Sun, 2021-06-20 at 09:08 +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git pending
> head:   c25913d2c08cddcc688ae58c63f34cf8ee937e73
> commit: fa89bebffc49412cc7024057efe5f02d15864c09 [2/37] iwlwifi: mei: add the driver to allow cooperation with CSME
> config: i386-allyesconfig (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=fa89bebffc49412cc7024057efe5f02d15864c09
>         git remote add iwlwifi-next https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git
>         git fetch --no-tags iwlwifi-next pending
>         git checkout fa89bebffc49412cc7024057efe5f02d15864c09
>         # save the attached .config to linux build tree
>         make W=1 ARCH=i386 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/net/wireless/intel/iwlwifi/mei/main.c:21:
> > > drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory
>       14 | #include "mei/sap.h"
>          |          ^~~~~~~~~~~
>    compilation terminated.
> 
> 
> vim +14 drivers/net/wireless/intel/iwlwifi/mei/trace.h
> 
>     13	
>   > 14	#include "mei/sap.h"
>     15	

Hi,

I'm a bit confused by this.  This same patch has already been in this
branch on different iterations and we never got this problem.

I also just tried to reproduce it on my machine with the commands
stated above, but compilation succeeds without problems.

Could this be a random issue with the bot?

--
Cheers,
Luca.

Re: [iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[Rong Chen]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]



On 6/21/21 2:54 PM, Coelho, Luciano wrote:
> On Sun, 2021-06-20 at 09:08 +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git pending
>> head:   c25913d2c08cddcc688ae58c63f34cf8ee937e73
>> commit: fa89bebffc49412cc7024057efe5f02d15864c09 [2/37] iwlwifi: mei: add the driver to allow cooperation with CSME
>> config: i386-allyesconfig (attached as .config)
>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>> reproduce (this is a W=1 build):
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=fa89bebffc49412cc7024057efe5f02d15864c09
>>          git remote add iwlwifi-next https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git
>>          git fetch --no-tags iwlwifi-next pending
>>          git checkout fa89bebffc49412cc7024057efe5f02d15864c09
>>          # save the attached .config to linux build tree
>>          make W=1 ARCH=i386
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     In file included from drivers/net/wireless/intel/iwlwifi/mei/main.c:21:
>>>> drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory
>>        14 | #include "mei/sap.h"
>>           |          ^~~~~~~~~~~
>>     compilation terminated.
>>
>>
>> vim +14 drivers/net/wireless/intel/iwlwifi/mei/trace.h
>>
>>      13	
>>    > 14	#include "mei/sap.h"
>>      15	
> Hi,
>
> I'm a bit confused by this.  This same patch has already been in this
> branch on different iterations and we never got this problem.
>
> I also just tried to reproduce it on my machine with the commands
> stated above, but compilation succeeds without problems.
>
> Could this be a random issue with the bot?

Hi Luca,

The reproduce step is not inaccurate and misleading, I can reproduce it 
with out-of-tree builds.

Best Regards,
Rong Chen

Re: [iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[Rong Chen]

[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]



On 6/22/21 8:17 AM, Rong Chen wrote:
>
>
> On 6/21/21 2:54 PM, Coelho, Luciano wrote:
>> On Sun, 2021-06-20 at 09:08 +0800, kernel test robot wrote:
>>> tree: 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git 
>>> pending
>>> head:   c25913d2c08cddcc688ae58c63f34cf8ee937e73
>>> commit: fa89bebffc49412cc7024057efe5f02d15864c09 [2/37] iwlwifi: 
>>> mei: add the driver to allow cooperation with CSME
>>> config: i386-allyesconfig (attached as .config)
>>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>>> reproduce (this is a W=1 build):
>>>          # 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=fa89bebffc49412cc7024057efe5f02d15864c09
>>>          git remote add iwlwifi-next 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git 
>>>
>>>          git fetch --no-tags iwlwifi-next pending
>>>          git checkout fa89bebffc49412cc7024057efe5f02d15864c09
>>>          # save the attached .config to linux build tree
>>>          make W=1 ARCH=i386
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>     In file included from 
>>> drivers/net/wireless/intel/iwlwifi/mei/main.c:21:
>>>>> drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: 
>>>>> mei/sap.h: No such file or directory
>>>        14 | #include "mei/sap.h"
>>>           |          ^~~~~~~~~~~
>>>     compilation terminated.
>>>
>>>
>>> vim +14 drivers/net/wireless/intel/iwlwifi/mei/trace.h
>>>
>>>      13
>>>    > 14    #include "mei/sap.h"
>>>      15
>> Hi,
>>
>> I'm a bit confused by this.  This same patch has already been in this
>> branch on different iterations and we never got this problem.
>>
>> I also just tried to reproduce it on my machine with the commands
>> stated above, but compilation succeeds without problems.
>>
>> Could this be a random issue with the bot?
>
> Hi Luca,
>
> The reproduce step is not inaccurate and misleading, I can reproduce 
> it with out-of-tree builds.

Sorry, 'not' is redundant, the reproduce step is wrong.

>
> Best Regards,
> Rong Chen

Re: [iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[Grumbach, Emmanuel]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

>>
> >> Could this be a random issue with the bot?
> >
> > Hi Luca,
> >
> > The reproduce step is not inaccurate and misleading, I can reproduce
> > it with out-of-tree builds.
> 
> Sorry, 'not' is redundant, the reproduce step is wrong.
> 
> >
Reproduce step is wrong?
In an case, sap.h is there. So really, I can't understand how this error can happen.

Re: [iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[Rong Chen]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]



On 6/22/21 11:35 AM, Grumbach, Emmanuel wrote:
>>>> Could this be a random issue with the bot?
>>> Hi Luca,
>>>
>>> The reproduce step is not inaccurate and misleading, I can reproduce
>>> it with out-of-tree builds.
>> Sorry, 'not' is redundant, the reproduce step is wrong.
>>
> Reproduce step is wrong?
> In an case, sap.h is there. So really, I can't understand how this error can happen.

Hi Grumbach,

It can be reproduced with out-of-tree builds:

    make ARCH=i386 -C source O=$(pwd) --keep-going

and I tried to add $(srctree), the problem can be fixed.

--- a/drivers/net/wireless/intel/iwlwifi/mei/Makefile
+++ b/drivers/net/wireless/intel/iwlwifi/mei/Makefile
@@ -3,6 +3,6 @@ obj-$(CONFIG_IWLMEI)    += iwlmei.o
  iwlmei-y += main.o
  iwlmei-y += net.o
  iwlmei-$(CONFIG_IWLWIFI_DEVICE_TRACING) += trace.o
-CFLAGS_trace.o := -I$(src)
+CFLAGS_trace.o := -I$(srctree)/$(src)

-ccflags-y += -I$(src)/../
+ccflags-y += -I$(srctree)/$(src)/../

Best Regards,
Rong Chen

Re: [iwlwifi-next:pending 2/37] drivers/net/wireless/intel/iwlwifi/mei/trace.h:14:10: fatal error: mei/sap.h: No such file or directory

[Grumbach, Emmanuel]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

> 
> On 6/22/21 11:35 AM, Grumbach, Emmanuel wrote:
> >>>> Could this be a random issue with the bot?
> >>> Hi Luca,
> >>>
> >>> The reproduce step is not inaccurate and misleading, I can reproduce
> >>> it with out-of-tree builds.
> >> Sorry, 'not' is redundant, the reproduce step is wrong.
> >>
> > Reproduce step is wrong?
> > In an case, sap.h is there. So really, I can't understand how this error can
> happen.
> 
> Hi Grumbach,
> 
> It can be reproduced with out-of-tree builds:
> 
>     make ARCH=i386 -C source O=$(pwd) --keep-going
> 
> and I tried to add $(srctree), the problem can be fixed.
> 
> --- a/drivers/net/wireless/intel/iwlwifi/mei/Makefile
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/Makefile
> @@ -3,6 +3,6 @@ obj-$(CONFIG_IWLMEI)    += iwlmei.o
>   iwlmei-y += main.o
>   iwlmei-y += net.o
>   iwlmei-$(CONFIG_IWLWIFI_DEVICE_TRACING) += trace.o -CFLAGS_trace.o
> := -I$(src)
> +CFLAGS_trace.o := -I$(srctree)/$(src)
> 
> -ccflags-y += -I$(src)/../
> +ccflags-y += -I$(srctree)/$(src)/../

Hmm... interesting, not sure I understand the difference between srctree and src
Looks like the kernel is more using srctree though..