All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] tools: bpftool: Remove unused struct
@ 2022-09-28  9:04 Yuan Can
  2022-09-28  9:04 ` [PATCH 1/2] tools: bpftool: Remove unused struct btf_attach_point Yuan Can
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Yuan Can @ 2022-09-28  9:04 UTC (permalink / raw)
  To: quentin, ast, daniel, andrii, martin.lau, song, yhs,
	john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf
  Cc: yuancan

This series contains two cleanup patches, remove unused struct.

Yuan Can (2):
  tools: bpftool: Remove unused struct btf_attach_point
  tools: bpftool: Remove unused struct event_ring_info

 tools/bpf/bpftool/btf.c           | 5 -----
 tools/bpf/bpftool/map_perf_ring.c | 7 -------
 2 files changed, 12 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/2] tools: bpftool: Remove unused struct btf_attach_point
  2022-09-28  9:04 [PATCH 0/2] tools: bpftool: Remove unused struct Yuan Can
@ 2022-09-28  9:04 ` Yuan Can
  2022-09-28  9:04 ` [PATCH 2/2] tools: bpftool: Remove unused struct event_ring_info Yuan Can
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Yuan Can @ 2022-09-28  9:04 UTC (permalink / raw)
  To: quentin, ast, daniel, andrii, martin.lau, song, yhs,
	john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf
  Cc: yuancan

After commit 2828d0d75b73("bpftool: Switch to libbpf's hashmap for programs/maps
in BTF listing"), struct btf_attach_point is not used any more and can be
removed as well.

Signed-off-by: Yuan Can <yuancan@huawei.com>
---
 tools/bpf/bpftool/btf.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
index 0744bd1150be..64411fe49a66 100644
--- a/tools/bpf/bpftool/btf.c
+++ b/tools/bpf/bpftool/btf.c
@@ -43,11 +43,6 @@ static const char * const btf_kind_str[NR_BTF_KINDS] = {
 	[BTF_KIND_ENUM64]	= "ENUM64",
 };
 
-struct btf_attach_point {
-	__u32 obj_id;
-	__u32 btf_id;
-};
-
 static const char *btf_int_enc_str(__u8 encoding)
 {
 	switch (encoding) {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] tools: bpftool: Remove unused struct event_ring_info
  2022-09-28  9:04 [PATCH 0/2] tools: bpftool: Remove unused struct Yuan Can
  2022-09-28  9:04 ` [PATCH 1/2] tools: bpftool: Remove unused struct btf_attach_point Yuan Can
@ 2022-09-28  9:04 ` Yuan Can
  2022-09-28  9:30 ` [PATCH 0/2] tools: bpftool: Remove unused struct Quentin Monnet
  2022-09-30 21:10 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 6+ messages in thread
From: Yuan Can @ 2022-09-28  9:04 UTC (permalink / raw)
  To: quentin, ast, daniel, andrii, martin.lau, song, yhs,
	john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf
  Cc: yuancan

After commit 9b190f185d2f("tools/bpftool: switch map event_pipe to libbpf's
perf_buffer"), struct event_ring_info is not used any more and can be removed
as well.

Signed-off-by: Yuan Can <yuancan@huawei.com>
---
 tools/bpf/bpftool/map_perf_ring.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tools/bpf/bpftool/map_perf_ring.c b/tools/bpf/bpftool/map_perf_ring.c
index 6b0c410152de..1583281d1327 100644
--- a/tools/bpf/bpftool/map_perf_ring.c
+++ b/tools/bpf/bpftool/map_perf_ring.c
@@ -29,13 +29,6 @@
 
 static volatile bool stop;
 
-struct event_ring_info {
-	int fd;
-	int key;
-	unsigned int cpu;
-	void *mem;
-};
-
 struct perf_event_sample {
 	struct perf_event_header header;
 	__u64 time;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] tools: bpftool: Remove unused struct
  2022-09-28  9:04 [PATCH 0/2] tools: bpftool: Remove unused struct Yuan Can
  2022-09-28  9:04 ` [PATCH 1/2] tools: bpftool: Remove unused struct btf_attach_point Yuan Can
  2022-09-28  9:04 ` [PATCH 2/2] tools: bpftool: Remove unused struct event_ring_info Yuan Can
@ 2022-09-28  9:30 ` Quentin Monnet
  2022-09-30  1:56   ` John Fastabend
  2022-09-30 21:10 ` patchwork-bot+netdevbpf
  3 siblings, 1 reply; 6+ messages in thread
From: Quentin Monnet @ 2022-09-28  9:30 UTC (permalink / raw)
  To: Yuan Can, ast, daniel, andrii, martin.lau, song, yhs,
	john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf

Wed Sep 28 2022 10:04:38 GMT+0100 (British Summer Time) ~ Yuan Can
<yuancan@huawei.com>
> This series contains two cleanup patches, remove unused struct.
> 
> Yuan Can (2):
>   tools: bpftool: Remove unused struct btf_attach_point
>   tools: bpftool: Remove unused struct event_ring_info
> 
>  tools/bpf/bpftool/btf.c           | 5 -----
>  tools/bpf/bpftool/map_perf_ring.c | 7 -------
>  2 files changed, 12 deletions(-)
> 

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thanks for the clean-up.
Quentin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] tools: bpftool: Remove unused struct
  2022-09-28  9:30 ` [PATCH 0/2] tools: bpftool: Remove unused struct Quentin Monnet
@ 2022-09-30  1:56   ` John Fastabend
  0 siblings, 0 replies; 6+ messages in thread
From: John Fastabend @ 2022-09-30  1:56 UTC (permalink / raw)
  To: Quentin Monnet, Yuan Can, ast, daniel, andrii, martin.lau, song,
	yhs, john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf

Quentin Monnet wrote:
> Wed Sep 28 2022 10:04:38 GMT+0100 (British Summer Time) ~ Yuan Can
> <yuancan@huawei.com>
> > This series contains two cleanup patches, remove unused struct.
> > 
> > Yuan Can (2):
> >   tools: bpftool: Remove unused struct btf_attach_point
> >   tools: bpftool: Remove unused struct event_ring_info
> > 
> >  tools/bpf/bpftool/btf.c           | 5 -----
> >  tools/bpf/bpftool/map_perf_ring.c | 7 -------
> >  2 files changed, 12 deletions(-)
> > 
> 
> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
> 
> Thanks for the clean-up.
> Quentin

lgtm

Acked-by: John Fastabend <john.fastabend@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] tools: bpftool: Remove unused struct
  2022-09-28  9:04 [PATCH 0/2] tools: bpftool: Remove unused struct Yuan Can
                   ` (2 preceding siblings ...)
  2022-09-28  9:30 ` [PATCH 0/2] tools: bpftool: Remove unused struct Quentin Monnet
@ 2022-09-30 21:10 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-30 21:10 UTC (permalink / raw)
  To: Yuan Can
  Cc: quentin, ast, daniel, andrii, martin.lau, song, yhs,
	john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf

Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Wed, 28 Sep 2022 09:04:38 +0000 you wrote:
> This series contains two cleanup patches, remove unused struct.
> 
> Yuan Can (2):
>   tools: bpftool: Remove unused struct btf_attach_point
>   tools: bpftool: Remove unused struct event_ring_info
> 
>  tools/bpf/bpftool/btf.c           | 5 -----
>  tools/bpf/bpftool/map_perf_ring.c | 7 -------
>  2 files changed, 12 deletions(-)

Here is the summary with links:
  - [1/2] tools: bpftool: Remove unused struct btf_attach_point
    https://git.kernel.org/bpf/bpf-next/c/d863f42930db
  - [2/2] tools: bpftool: Remove unused struct event_ring_info
    https://git.kernel.org/bpf/bpf-next/c/f95a479797dc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-30 21:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28  9:04 [PATCH 0/2] tools: bpftool: Remove unused struct Yuan Can
2022-09-28  9:04 ` [PATCH 1/2] tools: bpftool: Remove unused struct btf_attach_point Yuan Can
2022-09-28  9:04 ` [PATCH 2/2] tools: bpftool: Remove unused struct event_ring_info Yuan Can
2022-09-28  9:30 ` [PATCH 0/2] tools: bpftool: Remove unused struct Quentin Monnet
2022-09-30  1:56   ` John Fastabend
2022-09-30 21:10 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.