All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries
@ 2016-11-15  0:11 Alex Thorlton
  2016-11-15  0:11 ` [PATCH] " Alex Thorlton
                   ` (6 more replies)
  0 siblings, 7 replies; 60+ messages in thread
From: Alex Thorlton @ 2016-11-15  0:11 UTC (permalink / raw)
  To: linux-kernel
  Cc: Alex Thorlton, Russ Anderson, David Vrabel, Juergen Gross,
	Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, xen-devel

Hey everyone,

We're having problems with large systems hitting a BUG in
xen_memory_setup, due to extra e820 entries created in the
XENMEM_machine_memory_map callback.  The change in the patch gets things
working, but Boris and I wanted to get opinions on whether or not this
is the appropriate/entire solution, which is why I've sent it as an RFC
for now.

Boris pointed out to me that E820_X_MAX is only large when CONFIG_EFI=y,
which is a detail worth discussig.  He proposed possibly adding
CONFIG_XEN to the conditions under which we set E820_X_MAX to a larger
value than E820MAX, since the Xen e820 table isn't bound by the
zero-page memory limitations.

I do *slightly* question the use of E820_X_MAX here, only from a
cosmetic prospective, as I believe this macro is intended to describe
the maximum size of the extended e820 table, which, AFAIK, is not used
by the Xen HV.  That being said, there isn't exactly a "more
appropriate" macro/variable to use, so this may not really be an issue.

Any input on the patch, or the questions I've raised above is greatly
appreciated!

- Alex

Alex Thorlton (1):
  xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

 arch/x86/xen/setup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
1.8.5.6

^ permalink raw reply	[flat|nested] 60+ messages in thread
* [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries
@ 2016-11-15  0:11 Alex Thorlton
  0 siblings, 0 replies; 60+ messages in thread
From: Alex Thorlton @ 2016-11-15  0:11 UTC (permalink / raw)
  To: linux-kernel
  Cc: Russ Anderson, Juergen Gross, x86, Ingo Molnar, David Vrabel,
	H. Peter Anvin, xen-devel, Alex Thorlton, Thomas Gleixner

Hey everyone,

We're having problems with large systems hitting a BUG in
xen_memory_setup, due to extra e820 entries created in the
XENMEM_machine_memory_map callback.  The change in the patch gets things
working, but Boris and I wanted to get opinions on whether or not this
is the appropriate/entire solution, which is why I've sent it as an RFC
for now.

Boris pointed out to me that E820_X_MAX is only large when CONFIG_EFI=y,
which is a detail worth discussig.  He proposed possibly adding
CONFIG_XEN to the conditions under which we set E820_X_MAX to a larger
value than E820MAX, since the Xen e820 table isn't bound by the
zero-page memory limitations.

I do *slightly* question the use of E820_X_MAX here, only from a
cosmetic prospective, as I believe this macro is intended to describe
the maximum size of the extended e820 table, which, AFAIK, is not used
by the Xen HV.  That being said, there isn't exactly a "more
appropriate" macro/variable to use, so this may not really be an issue.

Any input on the patch, or the questions I've raised above is greatly
appreciated!

- Alex

Alex Thorlton (1):
  xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

 arch/x86/xen/setup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
1.8.5.6


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 60+ messages in thread

end of thread, other threads:[~2016-12-09 10:12 UTC | newest]

Thread overview: 60+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-15  0:11 [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Alex Thorlton
2016-11-15  0:11 ` [PATCH] " Alex Thorlton
2016-11-15  6:30   ` Ingo Molnar
2016-11-16 17:16     ` Alex Thorlton
2016-11-16  6:09   ` Juergen Gross
2016-11-16 17:16     ` Alex Thorlton
2016-11-15  6:33 ` [RFC PATCH] " Juergen Gross
2016-11-15  7:15   ` Jan Beulich
2016-11-15  7:15   ` Jan Beulich
     [not found]   ` <582AC427020000780011EA7E@suse.com>
2016-11-15  7:36     ` Juergen Gross
2016-11-15  7:36     ` Juergen Gross
2016-11-15  8:01       ` Jan Beulich
2016-11-15  8:01       ` Jan Beulich
     [not found]       ` <582ACEDE020000780011EAC9@suse.com>
2016-11-15  8:42         ` Juergen Gross
2016-11-15  9:45           ` Jan Beulich
2016-11-15  9:45           ` Jan Beulich
     [not found]           ` <582AE72D020000780011EBB2@suse.com>
2016-11-15  9:55             ` Juergen Gross
2016-11-15  9:55             ` Juergen Gross
2016-11-15 10:44               ` Jan Beulich
2016-11-15 10:44               ` Jan Beulich
     [not found]               ` <582AF51F020000780011ECB4@suse.com>
2016-11-15 11:07                 ` Juergen Gross
2016-11-15 11:12                   ` Jan Beulich
2016-11-15 11:12                   ` Jan Beulich
2016-11-15 11:07                 ` Juergen Gross
2016-11-15 15:22               ` Alex Thorlton
2016-11-16  6:06                 ` Juergen Gross
2016-11-16  6:06                 ` Juergen Gross
2016-11-15 15:22               ` Alex Thorlton
2016-11-15  8:42         ` Juergen Gross
2016-11-16 16:42     ` Juergen Gross
2016-11-16 16:53       ` Alex Thorlton
2016-11-18  0:04         ` Alex Thorlton
2016-11-15  6:33 ` Juergen Gross
2016-11-30  3:24 ` [RFC PATCH v2] " Alex Thorlton
2016-11-30  3:24   ` [PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX Alex Thorlton
2016-11-30  3:24     ` Alex Thorlton
2016-11-30  6:21     ` Ingo Molnar
2016-11-30  6:21     ` Ingo Molnar
2016-12-01 18:37       ` Alex Thorlton
2016-12-01 18:37       ` Alex Thorlton
2016-11-30  3:24   ` [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Alex Thorlton
2016-11-30  3:24   ` Alex Thorlton
2016-11-30  5:18     ` Juergen Gross
2016-11-30  5:18     ` Juergen Gross
2016-11-30  3:24 ` [RFC PATCH v2] " Alex Thorlton
2016-12-05 17:49 ` [RFC PATCH v3] " Alex Thorlton
2016-12-05 17:49   ` [PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX Alex Thorlton
2016-12-05 17:49   ` Alex Thorlton
2016-12-09 10:12     ` Juergen Gross
2016-12-09 10:12     ` Juergen Gross
2016-12-05 17:49   ` [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Alex Thorlton
2016-12-09 10:12     ` Juergen Gross
2016-12-09 10:12     ` Juergen Gross
2016-12-05 17:49   ` Alex Thorlton
2016-12-08  5:50   ` [RFC PATCH v3] " Juergen Gross
2016-12-09  3:46     ` Ingo Molnar
2016-12-09  3:46     ` Ingo Molnar
2016-12-08  5:50   ` Juergen Gross
2016-12-05 17:49 ` Alex Thorlton
2016-11-15  0:11 [RFC PATCH] " Alex Thorlton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.