From: Keerthy <j-keerthy@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <w-kwok2@ti.com>, <m-karicheri2@ti.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stephen@networkplumber.org>,
<m-scherban@ti.com>
Subject: Re: [PATCH] net: netcp: correct netcp_get_stats function signature
Date: Wed, 11 Jan 2017 08:58:33 +0530 [thread overview]
Message-ID: <63403509-0dc6-42f3-4b77-897645d0cc71@ti.com> (raw)
In-Reply-To: <20170110.115213.1856085394233309828.davem@davemloft.net>
On Tuesday 10 January 2017 10:22 PM, David Miller wrote:
> From: Keerthy <j-keerthy@ti.com>
> Date: Tue, 10 Jan 2017 16:56:25 +0530
>
>> @@ -1909,7 +1909,7 @@ static int netcp_setup_tc(struct net_device *dev, u32 handle, __be16 proto,
>> return 0;
>> }
>>
>> -static struct rtnl_link_stats64 *
>> +void
>> netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)
>
> Please do not remove the static qualifier.
Sure. I will add that back.
>
prev parent reply other threads:[~2017-01-11 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 11:26 [PATCH] net: netcp: correct netcp_get_stats function signature Keerthy
2017-01-10 16:52 ` David Miller
2017-01-11 3:28 ` Keerthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63403509-0dc6-42f3-4b77-897645d0cc71@ti.com \
--to=j-keerthy@ti.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-scherban@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.