* [PATCH] clocksource: atmel-st: remove useless 'status'
@ 2020-04-14 12:02 ` Jason Yan
0 siblings, 0 replies; 7+ messages in thread
From: Jason Yan @ 2020-04-14 12:02 UTC (permalink / raw)
To: daniel.lezcano, tglx, nicolas.ferre, alexandre.belloni,
ludovic.desroches, linux-kernel, linux-arm-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
"status". Return "0" on line 166
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/clocksource/timer-atmel-st.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index ab0aabfae5f0..73e8aee445da 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -139,7 +139,6 @@ static int
clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
{
u32 alm;
- int status = 0;
unsigned int val;
BUG_ON(delta < 2);
@@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
alm += delta;
regmap_write(regmap_st, AT91_ST_RTAR, alm);
- return status;
+ return 0;
}
static struct clock_event_device clkevt = {
--
2.21.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] clocksource: atmel-st: remove useless 'status'
2020-04-14 12:02 ` Jason Yan
@ 2020-04-15 7:37 ` Alexandre Belloni
-1 siblings, 0 replies; 7+ messages in thread
From: Alexandre Belloni @ 2020-04-15 7:37 UTC (permalink / raw)
To: Jason Yan
Cc: daniel.lezcano, tglx, nicolas.ferre, ludovic.desroches,
linux-kernel, linux-arm-kernel
On 14/04/2020 20:02:38+0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
> "status". Return "0" on line 166
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/clocksource/timer-atmel-st.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> index ab0aabfae5f0..73e8aee445da 100644
> --- a/drivers/clocksource/timer-atmel-st.c
> +++ b/drivers/clocksource/timer-atmel-st.c
> @@ -139,7 +139,6 @@ static int
> clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> {
> u32 alm;
> - int status = 0;
> unsigned int val;
>
> BUG_ON(delta < 2);
> @@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> alm += delta;
> regmap_write(regmap_st, AT91_ST_RTAR, alm);
>
> - return status;
> + return 0;
> }
>
> static struct clock_event_device clkevt = {
> --
> 2.21.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] clocksource: atmel-st: remove useless 'status'
@ 2020-04-15 7:37 ` Alexandre Belloni
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Belloni @ 2020-04-15 7:37 UTC (permalink / raw)
To: Jason Yan
Cc: daniel.lezcano, linux-kernel, ludovic.desroches, tglx, linux-arm-kernel
On 14/04/2020 20:02:38+0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
> "status". Return "0" on line 166
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/clocksource/timer-atmel-st.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> index ab0aabfae5f0..73e8aee445da 100644
> --- a/drivers/clocksource/timer-atmel-st.c
> +++ b/drivers/clocksource/timer-atmel-st.c
> @@ -139,7 +139,6 @@ static int
> clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> {
> u32 alm;
> - int status = 0;
> unsigned int val;
>
> BUG_ON(delta < 2);
> @@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> alm += delta;
> regmap_write(regmap_st, AT91_ST_RTAR, alm);
>
> - return status;
> + return 0;
> }
>
> static struct clock_event_device clkevt = {
> --
> 2.21.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clocksource: atmel-st: remove useless 'status'
2020-04-14 12:02 ` Jason Yan
@ 2020-04-15 8:57 ` Daniel Lezcano
-1 siblings, 0 replies; 7+ messages in thread
From: Daniel Lezcano @ 2020-04-15 8:57 UTC (permalink / raw)
To: Jason Yan, tglx, nicolas.ferre, alexandre.belloni,
ludovic.desroches, linux-kernel, linux-arm-kernel
On 14/04/2020 14:02, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
> "status". Return "0" on line 166
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip: timers/core] clocksource/drivers/atmel-st: Remove useless 'status'
2020-04-14 12:02 ` Jason Yan
` (2 preceding siblings ...)
(?)
@ 2020-06-01 13:11 ` tip-bot2 for Jason Yan
-1 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Jason Yan @ 2020-06-01 13:11 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Jason Yan, Alexandre Belloni, Daniel Lezcano, x86, LKML
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 8c42c0f72d7c4f295646d3eba73f62e5579b1732
Gitweb: https://git.kernel.org/tip/8c42c0f72d7c4f295646d3eba73f62e5579b1732
Author: Jason Yan <yanaijie@huawei.com>
AuthorDate: Tue, 14 Apr 2020 20:02:38 +08:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Wed, 15 Apr 2020 10:57:15 +02:00
clocksource/drivers/atmel-st: Remove useless 'status'
Fix the following coccicheck warning:
drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
"status". Return "0" on line 166
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200414120238.35704-1-yanaijie@huawei.com
---
drivers/clocksource/timer-atmel-st.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index ab0aabf..73e8aee 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -139,7 +139,6 @@ static int
clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
{
u32 alm;
- int status = 0;
unsigned int val;
BUG_ON(delta < 2);
@@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
alm += delta;
regmap_write(regmap_st, AT91_ST_RTAR, alm);
- return status;
+ return 0;
}
static struct clock_event_device clkevt = {
^ permalink raw reply related [flat|nested] 7+ messages in thread