[PATCH v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[PATCH v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[Zijun Hu]

From: Zijun Hu <zijuhu@qti.qualcomm.com>

A CSR BT dongle fails to be enabled bcz it is not detected as fake
rightly, fixed by correcting fake detection condition.

below btmon error log says HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL is not set.

< HCI Command: Set Event Filter (0x03|0x0005) plen 1        #23 [hci0]
        Type: Clear All Filters (0x00)
> HCI Event: Command Complete (0x0e) plen 4                 #24 [hci0]
      Set Event Filter (0x03|0x0005) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

the quirk is not set bcz current fake detection does not mark the dongle
as fake with below version info.

< HCI Command: Read Local Version In.. (0x04|0x0001) plen 0  #1 [hci0]
> HCI Event: Command Complete (0x0e) plen 12                 #2 [hci0]
      Read Local Version Information (0x04|0x0001) ncmd 1
        Status: Success (0x00)
        HCI version: Bluetooth 4.0 (0x06) - Revision 12576 (0x3120)
        LMP version: Bluetooth 4.0 (0x06) - Subversion 8891 (0x22bb)
        Manufacturer: Cambridge Silicon Radio (10)

Link: https://bugzilla.kernel.org/show_bug.cgi?id=60824
Signed-off-by: Zijun Hu <zijuhu@qti.qualcomm.com>
---
 drivers/bluetooth/btusb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 420be2ee2acf..727469d073f9 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2155,7 +2155,7 @@ static int btusb_setup_csr(struct hci_dev *hdev)
 		is_fake = true;
 
 	else if (le16_to_cpu(rp->lmp_subver) <= 0x22bb &&
-		 le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_4_0)
+		 le16_to_cpu(rp->hci_ver) >= BLUETOOTH_VER_4_0)
 		is_fake = true;
 
 	/* Other clones which beat all the above checks */
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[Paul Menzel]

Dear Zijun,


Thank you for the patch.


Am 27.10.22 um 13:06 schrieb Zijun Hu:
> From: Zijun Hu <zijuhu@qti.qualcomm.com>

I‘d be more specific in the summary/title. Maybe:

Correct quirk check to include BT 4.0

> A CSR BT dongle fails to be enabled bcz it is not detected as fake

I’d write *because*.

> rightly, fixed by correcting fake detection condition.
> 
> below btmon error log says HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL is not set.
> 
> < HCI Command: Set Event Filter (0x03|0x0005) plen 1        #23 [hci0]
>          Type: Clear All Filters (0x00)
>> HCI Event: Command Complete (0x0e) plen 4                 #24 [hci0]
>        Set Event Filter (0x03|0x0005) ncmd 1
>          Status: Invalid HCI Command Parameters (0x12)
> 
> the quirk is not set bcz current fake detection does not mark the dongle
> as fake with below version info.
> 
> < HCI Command: Read Local Version In.. (0x04|0x0001) plen 0  #1 [hci0]
>> HCI Event: Command Complete (0x0e) plen 12                 #2 [hci0]
>        Read Local Version Information (0x04|0x0001) ncmd 1
>          Status: Success (0x00)
>          HCI version: Bluetooth 4.0 (0x06) - Revision 12576 (0x3120)
>          LMP version: Bluetooth 4.0 (0x06) - Subversion 8891 (0x22bb)
>          Manufacturer: Cambridge Silicon Radio (10)
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=60824
> Signed-off-by: Zijun Hu <zijuhu@qti.qualcomm.com>

Please add a Fixes: tag.


Kind regards,

Paul


> ---
>   drivers/bluetooth/btusb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 420be2ee2acf..727469d073f9 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2155,7 +2155,7 @@ static int btusb_setup_csr(struct hci_dev *hdev)
>   		is_fake = true;
>   
>   	else if (le16_to_cpu(rp->lmp_subver) <= 0x22bb &&
> -		 le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_4_0)
> +		 le16_to_cpu(rp->hci_ver) >= BLUETOOTH_VER_4_0)
>   		is_fake = true;
>   
>   	/* Other clones which beat all the above checks */

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      1.31 seconds
GitLint                       PASS      0.79 seconds
SubjectPrefix                 PASS      0.60 seconds
BuildKernel                   PASS      40.13 seconds
BuildKernel32                 PASS      36.08 seconds
Incremental Build with patchesPASS      54.02 seconds
TestRunner: Setup             PASS      608.14 seconds
TestRunner: l2cap-tester      PASS      19.54 seconds
TestRunner: iso-tester        PASS      19.79 seconds
TestRunner: bnep-tester       PASS      7.61 seconds
TestRunner: mgmt-tester       PASS      119.94 seconds
TestRunner: rfcomm-tester     PASS      11.91 seconds
TestRunner: sco-tester        PASS      11.06 seconds
TestRunner: ioctl-tester      PASS      12.73 seconds
TestRunner: mesh-tester       PASS      9.40 seconds
TestRunner: smp-tester        PASS      11.09 seconds
TestRunner: userchan-tester   PASS      7.88 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[quic_zijuhu]

On 10/27/2022 7:18 PM, Paul Menzel wrote:
> Dear Zijun,
> 
> 
> Thank you for the patch.
> 
> 
> Am 27.10.22 um 13:06 schrieb Zijun Hu:
>> From: Zijun Hu <zijuhu@qti.qualcomm.com>
> 
> I‘d be more specific in the summary/title. Maybe:
> 
> Correct quirk check to include BT 4.0
> 
>> A CSR BT dongle fails to be enabled bcz it is not detected as fake
> 
> I’d write *because*.
> 
>> rightly, fixed by correcting fake detection condition.
>>
>> below btmon error log says HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL is not set.
>>
>> < HCI Command: Set Event Filter (0x03|0x0005) plen 1        #23 [hci0]
>>          Type: Clear All Filters (0x00)
>>> HCI Event: Command Complete (0x0e) plen 4                 #24 [hci0]
>>        Set Event Filter (0x03|0x0005) ncmd 1
>>          Status: Invalid HCI Command Parameters (0x12)
>>
>> the quirk is not set bcz current fake detection does not mark the dongle
>> as fake with below version info.
>>
>> < HCI Command: Read Local Version In.. (0x04|0x0001) plen 0  #1 [hci0]
>>> HCI Event: Command Complete (0x0e) plen 12                 #2 [hci0]
>>        Read Local Version Information (0x04|0x0001) ncmd 1
>>          Status: Success (0x00)
>>          HCI version: Bluetooth 4.0 (0x06) - Revision 12576 (0x3120)
>>          LMP version: Bluetooth 4.0 (0x06) - Subversion 8891 (0x22bb)
>>          Manufacturer: Cambridge Silicon Radio (10)
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=60824
>> Signed-off-by: Zijun Hu <zijuhu@qti.qualcomm.com>
> 
> Please add a Fixes: tag.
> 
> 
> Kind regards,
> 
> Paul
> 
> 
>> ---
>>   drivers/bluetooth/btusb.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index 420be2ee2acf..727469d073f9 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -2155,7 +2155,7 @@ static int btusb_setup_csr(struct hci_dev *hdev)
>>           is_fake = true;
>>         else if (le16_to_cpu(rp->lmp_subver) <= 0x22bb &&
>> -         le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_4_0)
>> +         le16_to_cpu(rp->hci_ver) >= BLUETOOTH_VER_4_0)
>>           is_fake = true;
>>         /* Other clones which beat all the above checks */

thank you Paul for your code review.
i am sorry, please Ignore this wrong fix.
the enable failure should be  caused that below fix is not be picked up
https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=b3cf94c8b6b2f1a2b94825a025db291da2b151fd

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.63 seconds
GitLint                       PASS      0.26 seconds
SubjectPrefix                 PASS      0.06 seconds
BuildKernel                   PASS      47.39 seconds
BuildKernel32                 PASS      42.48 seconds
TestRunnerSetup               PASS      593.56 seconds
TestRunner_l2cap-tester       PASS      20.08 seconds
TestRunner_iso-tester         PASS      21.41 seconds
TestRunner_bnep-tester        PASS      7.16 seconds
TestRunner_mgmt-tester        PASS      139.48 seconds
TestRunner_rfcomm-tester      PASS      12.68 seconds
TestRunner_sco-tester         PASS      11.51 seconds
TestRunner_ioctl-tester       PASS      13.49 seconds
TestRunner_mesh-tester        PASS      9.49 seconds
TestRunner_smp-tester         PASS      11.08 seconds
TestRunner_userchan-tester    PASS      7.75 seconds
IncrementalBuild              PASS      44.37 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.56 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      33.29 seconds
BuildKernel32                 PASS      29.65 seconds
TestRunnerSetup               PASS      417.65 seconds
TestRunner_l2cap-tester       PASS      15.67 seconds
TestRunner_iso-tester         PASS      15.12 seconds
TestRunner_bnep-tester        PASS      5.26 seconds
TestRunner_mgmt-tester        PASS      103.06 seconds
TestRunner_rfcomm-tester      PASS      9.04 seconds
TestRunner_sco-tester         PASS      8.54 seconds
TestRunner_ioctl-tester       PASS      9.76 seconds
TestRunner_mesh-tester        PASS      6.63 seconds
TestRunner_smp-tester         PASS      8.40 seconds
TestRunner_userchan-tester    PASS      5.53 seconds
IncrementalBuild              PASS      31.08 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.70 seconds
GitLint                       PASS      0.38 seconds
SubjectPrefix                 PASS      0.14 seconds
BuildKernel                   PASS      33.35 seconds
BuildKernel32                 PASS      29.35 seconds
TestRunnerSetup               PASS      415.53 seconds
TestRunner_l2cap-tester       PASS      15.67 seconds
TestRunner_iso-tester         PASS      14.97 seconds
TestRunner_bnep-tester        PASS      5.26 seconds
TestRunner_mgmt-tester        PASS      103.28 seconds
TestRunner_rfcomm-tester      PASS      9.08 seconds
TestRunner_sco-tester         PASS      8.54 seconds
TestRunner_ioctl-tester       PASS      9.86 seconds
TestRunner_mesh-tester        PASS      6.68 seconds
TestRunner_smp-tester         PASS      8.41 seconds
TestRunner_userchan-tester    PASS      5.63 seconds
IncrementalBuild              PASS      30.54 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.52 seconds
GitLint                       PASS      0.24 seconds
SubjectPrefix                 PASS      0.06 seconds
BuildKernel                   PASS      41.17 seconds
BuildKernel32                 PASS      36.66 seconds
TestRunnerSetup               PASS      532.13 seconds
TestRunner_l2cap-tester       PASS      20.37 seconds
TestRunner_iso-tester         PASS      19.55 seconds
TestRunner_bnep-tester        PASS      6.75 seconds
TestRunner_mgmt-tester        PASS      132.05 seconds
TestRunner_rfcomm-tester      PASS      12.00 seconds
TestRunner_sco-tester         PASS      11.15 seconds
TestRunner_ioctl-tester       PASS      12.98 seconds
TestRunner_mesh-tester        PASS      8.62 seconds
TestRunner_smp-tester         PASS      10.42 seconds
TestRunner_userchan-tester    PASS      7.27 seconds
IncrementalBuild              PASS      40.24 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.56 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      33.07 seconds
BuildKernel32                 PASS      30.09 seconds
TestRunnerSetup               PASS      416.44 seconds
TestRunner_l2cap-tester       PASS      16.06 seconds
TestRunner_iso-tester         PASS      15.46 seconds
TestRunner_bnep-tester        PASS      5.48 seconds
TestRunner_mgmt-tester        PASS      104.89 seconds
TestRunner_rfcomm-tester      PASS      9.30 seconds
TestRunner_sco-tester         PASS      8.79 seconds
TestRunner_ioctl-tester       PASS      10.05 seconds
TestRunner_mesh-tester        PASS      6.91 seconds
TestRunner_smp-tester         PASS      8.58 seconds
TestRunner_userchan-tester    PASS      5.74 seconds
IncrementalBuild              PASS      30.76 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.72 seconds
GitLint                       PASS      0.38 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      40.46 seconds
BuildKernel32                 PASS      36.13 seconds
TestRunnerSetup               PASS      499.62 seconds
TestRunner_l2cap-tester       PASS      17.88 seconds
TestRunner_iso-tester         PASS      18.09 seconds
TestRunner_bnep-tester        PASS      6.41 seconds
TestRunner_mgmt-tester        PASS      120.42 seconds
TestRunner_rfcomm-tester      PASS      11.05 seconds
TestRunner_sco-tester         PASS      10.12 seconds
TestRunner_ioctl-tester       PASS      11.56 seconds
TestRunner_mesh-tester        PASS      7.97 seconds
TestRunner_smp-tester         PASS      9.74 seconds
TestRunner_userchan-tester    PASS      6.82 seconds
IncrementalBuild              PASS      38.24 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.64 seconds
GitLint                       PASS      0.31 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      40.94 seconds
BuildKernel32                 PASS      36.59 seconds
TestRunnerSetup               PASS      500.41 seconds
TestRunner_l2cap-tester       PASS      17.81 seconds
TestRunner_iso-tester         PASS      17.90 seconds
TestRunner_bnep-tester        PASS      6.42 seconds
TestRunner_mgmt-tester        PASS      124.83 seconds
TestRunner_rfcomm-tester      PASS      10.79 seconds
TestRunner_sco-tester         PASS      10.14 seconds
TestRunner_ioctl-tester       PASS      11.75 seconds
TestRunner_mesh-tester        PASS      8.10 seconds
TestRunner_smp-tester         PASS      9.92 seconds
TestRunner_userchan-tester    PASS      6.70 seconds
IncrementalBuild              PASS      36.98 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       PASS      0.35 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      34.10 seconds
BuildKernel32                 PASS      30.01 seconds
TestRunnerSetup               PASS      425.14 seconds
TestRunner_l2cap-tester       PASS      15.70 seconds
TestRunner_iso-tester         PASS      14.97 seconds
TestRunner_bnep-tester        PASS      5.32 seconds
TestRunner_mgmt-tester        PASS      104.21 seconds
TestRunner_rfcomm-tester      PASS      9.08 seconds
TestRunner_sco-tester         PASS      8.54 seconds
TestRunner_ioctl-tester       PASS      9.76 seconds
TestRunner_mesh-tester        PASS      6.68 seconds
TestRunner_smp-tester         PASS      8.44 seconds
TestRunner_userchan-tester    PASS      5.57 seconds
IncrementalBuild              PASS      31.21 seconds



---
Regards,
Linux Bluetooth

RE: [v1] Bluetooth: btusb: Fix enable failure for a CSR BT dongle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689388

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       PASS      0.35 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      33.96 seconds
BuildKernel32                 PASS      30.77 seconds
TestRunnerSetup               PASS      424.89 seconds
TestRunner_l2cap-tester       PASS      16.10 seconds
TestRunner_iso-tester         PASS      15.93 seconds
TestRunner_bnep-tester        PASS      5.56 seconds
TestRunner_mgmt-tester        PASS      107.17 seconds
TestRunner_rfcomm-tester      PASS      9.45 seconds
TestRunner_sco-tester         PASS      8.91 seconds
TestRunner_ioctl-tester       PASS      10.31 seconds
TestRunner_mesh-tester        PASS      7.06 seconds
TestRunner_smp-tester         PASS      8.76 seconds
TestRunner_userchan-tester    PASS      5.85 seconds
IncrementalBuild              PASS      31.77 seconds



---
Regards,
Linux Bluetooth