All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
@ 2015-01-22  3:15 ` Mark Yao
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Yao @ 2015-01-22  3:15 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Clark, Philipp Zabel,
	Daniel Kurtz, dri-devel, linux-kernel, linux-rockchip
  Cc: Mark Yao

Vop set wrong vsync/hsync polarity, it may cause some
display problem. known problem is that caused HDMI hdcp
authenticate failed, caused pixel offset with hdmi display.
the polarity description at RK3288 TRM doc:
  dsp_vsync_pol
    VSYNC polarity
      1'b0 : negative
      1'b1 : positive
      dsp_hsync_pol
    HSYNC polarity
      1'b0 : negative
      1'b1 : positive

Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 9a5c571..2b145ba5 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc,
 	VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode);
 
 	val = 0x8;
-	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0;
-	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0;
+	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
+	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
 	VOP_CTRL_SET(vop, pin_pol, val);
 
 	VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len);
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
@ 2015-01-22  3:15 ` Mark Yao
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Yao @ 2015-01-22  3:15 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Clark, Philipp Zabel,
	Daniel Kurtz, dri-devel, linux-kernel, linux-rockchip
  Cc: Mark Yao

Vop set wrong vsync/hsync polarity, it may cause some
display problem. known problem is that caused HDMI hdcp
authenticate failed, caused pixel offset with hdmi display.
the polarity description at RK3288 TRM doc:
  dsp_vsync_pol
    VSYNC polarity
      1'b0 : negative
      1'b1 : positive
      dsp_hsync_pol
    HSYNC polarity
      1'b0 : negative
      1'b1 : positive

Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 9a5c571..2b145ba5 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc,
 	VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode);
 
 	val = 0x8;
-	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0;
-	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0;
+	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
+	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
 	VOP_CTRL_SET(vop, pin_pol, val);
 
 	VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len);
-- 
1.7.9.5


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
  2015-01-22  3:15 ` Mark Yao
@ 2015-01-22  3:33   ` Daniel Kurtz
  -1 siblings, 0 replies; 7+ messages in thread
From: Daniel Kurtz @ 2015-01-22  3:33 UTC (permalink / raw)
  To: Mark Yao
  Cc: David Airlie, Daniel Vetter, Rob Clark, Philipp Zabel, dri-devel,
	linux-kernel, open list:ARM/Rockchip SoC...

On Thu, Jan 22, 2015 at 11:15 AM, Mark Yao <mark.yao@rock-chips.com> wrote:
> Vop set wrong vsync/hsync polarity, it may cause some
> display problem. known problem is that caused HDMI hdcp
> authenticate failed, caused pixel offset with hdmi display.
> the polarity description at RK3288 TRM doc:
>   dsp_vsync_pol
>     VSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
>       dsp_hsync_pol
>     HSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>

Looks good!

Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

> ---
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 9a5c571..2b145ba5 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc,
>         VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode);
>
>         val = 0x8;
> -       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0;
> -       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0;
> +       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
> +       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
>         VOP_CTRL_SET(vop, pin_pol, val);
>
>         VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len);
> --
> 1.7.9.5
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
@ 2015-01-22  3:33   ` Daniel Kurtz
  0 siblings, 0 replies; 7+ messages in thread
From: Daniel Kurtz @ 2015-01-22  3:33 UTC (permalink / raw)
  To: Mark Yao; +Cc: linux-kernel, dri-devel, open list:ARM/Rockchip SoC...

On Thu, Jan 22, 2015 at 11:15 AM, Mark Yao <mark.yao@rock-chips.com> wrote:
> Vop set wrong vsync/hsync polarity, it may cause some
> display problem. known problem is that caused HDMI hdcp
> authenticate failed, caused pixel offset with hdmi display.
> the polarity description at RK3288 TRM doc:
>   dsp_vsync_pol
>     VSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
>       dsp_hsync_pol
>     HSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>

Looks good!

Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

> ---
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 9a5c571..2b145ba5 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc,
>         VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode);
>
>         val = 0x8;
> -       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0;
> -       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0;
> +       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
> +       val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
>         VOP_CTRL_SET(vop, pin_pol, val);
>
>         VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len);
> --
> 1.7.9.5
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
  2015-01-22  3:15 ` Mark Yao
  (?)
  (?)
@ 2015-01-22  3:48 ` Caesar Wang
  -1 siblings, 0 replies; 7+ messages in thread
From: Caesar Wang @ 2015-01-22  3:48 UTC (permalink / raw)
  To: Mark Yao, David Airlie, Daniel Vetter, Rob Clark, Philipp Zabel,
	Daniel Kurtz, dri-devel, linux-kernel, linux-rockchip

Mark,

在 2015年01月22日 11:15, Mark Yao 写道:
> Vop set wrong vsync/hsync polarity, it may cause some
> display problem. known problem is that caused HDMI hdcp
> authenticate failed, caused pixel offset with hdmi display.
> the polarity description at RK3288 TRM doc:
>    dsp_vsync_pol
>      VSYNC polarity
>        1'b0 : negative
>        1'b1 : positive
>        dsp_hsync_pol
>      HSYNC polarity
>        1'b0 : negative
>        1'b1 : positive
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 9a5c571..2b145ba5 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc,
>   	VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode);
>   
>   	val = 0x8;
> -	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0;
> -	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0;
> +	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
> +	val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
Tested-by: Caesar Wang <wxt@rock-chips.com>
>   	VOP_CTRL_SET(vop, pin_pol, val);
>   
>   	VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len);



^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
  2015-01-22  3:15 ` Mark Yao
@ 2015-01-24 15:13   ` Heiko Stübner
  -1 siblings, 0 replies; 7+ messages in thread
From: Heiko Stübner @ 2015-01-24 15:13 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Yao, David Airlie, Daniel Vetter, Rob Clark, Philipp Zabel,
	Daniel Kurtz, linux-kernel, linux-rockchip

Am Donnerstag, 22. Januar 2015, 11:15:02 schrieb Mark Yao:
> Vop set wrong vsync/hsync polarity, it may cause some
> display problem. known problem is that caused HDMI hdcp
> authenticate failed, caused pixel offset with hdmi display.
> the polarity description at RK3288 TRM doc:
>   dsp_vsync_pol
>     VSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
>       dsp_hsync_pol
>     HSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
> 
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---

on a rk3288-firefly board with a sda7123 vga connector
Tested-by: Heiko Stuebner <heiko@sntech.de>


Heiko

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity
@ 2015-01-24 15:13   ` Heiko Stübner
  0 siblings, 0 replies; 7+ messages in thread
From: Heiko Stübner @ 2015-01-24 15:13 UTC (permalink / raw)
  To: dri-devel; +Cc: linux-kernel, linux-rockchip, Mark Yao

Am Donnerstag, 22. Januar 2015, 11:15:02 schrieb Mark Yao:
> Vop set wrong vsync/hsync polarity, it may cause some
> display problem. known problem is that caused HDMI hdcp
> authenticate failed, caused pixel offset with hdmi display.
> the polarity description at RK3288 TRM doc:
>   dsp_vsync_pol
>     VSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
>       dsp_hsync_pol
>     HSYNC polarity
>       1'b0 : negative
>       1'b1 : positive
> 
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---

on a rk3288-firefly board with a sda7123 vga connector
Tested-by: Heiko Stuebner <heiko@sntech.de>


Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-24 15:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-22  3:15 [PATCH] drm/rockchip: vop: fix vop vsync/hsync polarity Mark Yao
2015-01-22  3:15 ` Mark Yao
2015-01-22  3:33 ` Daniel Kurtz
2015-01-22  3:33   ` Daniel Kurtz
2015-01-22  3:48 ` Caesar Wang
2015-01-24 15:13 ` Heiko Stübner
2015-01-24 15:13   ` Heiko Stübner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.