* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
@ 2018-01-10 7:02 Goldschmidt Simon
2018-01-10 8:48 ` Lokesh Vutla
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Goldschmidt Simon @ 2018-01-10 7:02 UTC (permalink / raw)
To: u-boot
Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
that the dtb is stripped in embedded mode, too.
This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called
from scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl
at the downside of having it duplicated in two makefiles.
---
scripts/Makefile.spl | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index 64390e5785..72e74f14c3 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
@bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
+# Pass the original device tree file through fdtgrep twice. The first pass
+# removes any unwanted nodes (i.e. those which don't have the
+# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
+# pass removes various unused properties from the remaining nodes.
+# The output is typically a much smaller device tree file.
+ifeq ($(CONFIG_TPL_BUILD),y)
+fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
+else
+fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
+endif
+quiet_cmd_fdtgrep = FDTGREP $@
+ cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
+ -n /chosen -n /config -O dtb | \
+ $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
+ $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
+
$(obj)/$(SPL_BIN).dtb: dts/dt-spl.dtb FORCE
$(call if_changed,copy)
--
2.12.2.windows.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-10 7:02 [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED Goldschmidt Simon
@ 2018-01-10 8:48 ` Lokesh Vutla
2018-02-13 6:56 ` [U-Boot] [PATCH v2] " Simon Goldschmidt
2018-02-14 5:44 ` [U-Boot] [PATCH v3] " Simon Goldschmidt
2 siblings, 0 replies; 12+ messages in thread
From: Lokesh Vutla @ 2018-01-10 8:48 UTC (permalink / raw)
To: u-boot
On Wednesday 10 January 2018 12:32 PM, Goldschmidt Simon wrote:
> Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
> moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
> that the dtb is stripped in embedded mode, too.
>
> This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called
> from scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
> To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl
> at the downside of having it duplicated in two makefiles.
Missing Signed-off-by? Also a Reported-by credits would be nice :)
> ---
> scripts/Makefile.spl | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> index 64390e5785..72e74f14c3 100644
> --- a/scripts/Makefile.spl
> +++ b/scripts/Makefile.spl
> @@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
> @bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
> dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
>
> +# Pass the original device tree file through fdtgrep twice. The first pass
> +# removes any unwanted nodes (i.e. those which don't have the
> +# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
> +# pass removes various unused properties from the remaining nodes.
> +# The output is typically a much smaller device tree file.
> +ifeq ($(CONFIG_TPL_BUILD),y)
> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
> +else
> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
> +endif
> +quiet_cmd_fdtgrep = FDTGREP $@
> + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> + -n /chosen -n /config -O dtb | \
> + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
> + $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
> +
hmm..we are duplicating code here. Why can't dtb build for
CONFIG_OF_EMBED be moved to scripts/Makefile.spl?
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH v2] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-10 7:02 [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED Goldschmidt Simon
2018-01-10 8:48 ` Lokesh Vutla
@ 2018-02-13 6:56 ` Simon Goldschmidt
2018-02-13 8:40 ` Lokesh Vutla
2018-02-14 5:44 ` [U-Boot] [PATCH v3] " Simon Goldschmidt
2 siblings, 1 reply; 12+ messages in thread
From: Simon Goldschmidt @ 2018-02-13 6:56 UTC (permalink / raw)
To: u-boot
With commit 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through
fdtgrep"), CONFIG_SPL_MULTI_DTB_FIT has been broken because
cmd_fdtgrep was now unknown in scripts/Makefile.spl after moving
it to dts/Makefile. This bug has been introduced with v2018.01.
This patch moves cmd_fdtgrep from dts/Makefile to scripts/Makefile.lib
and includes scripts/Makefile.lib in scripts/Makefile.spl.
Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep")
Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
---
Changes in v2:
- move definition of cmd_fdtgrep to scripts/Makefile.lib instead of
duplicating it
dts/Makefile | 16 ----------------
scripts/Makefile.lib | 18 ++++++++++++++++++
scripts/Makefile.spl | 2 ++
3 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/dts/Makefile b/dts/Makefile
index c9b2a89441..779c9ec5c3 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -22,22 +22,6 @@ DTB := $(ARCH_PATH)/$(DEVICE_TREE).dtb
dtb_depends += $(DTB:.dtb=.dts)
endif
-# Pass the original device tree file through fdtgrep twice. The first pass
-# removes any unwanted nodes (i.e. those which don't have the
-# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
-# pass removes various unused properties from the remaining nodes.
-# The output is typically a much smaller device tree file.
-ifeq ($(CONFIG_TPL_BUILD),y)
-fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
-else
-fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
-endif
-quiet_cmd_fdtgrep = FDTGREP $@
- cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
- -n /chosen -n /config -O dtb | \
- $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
- $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
-
$(obj)/dt-spl.dtb: $(DTB) $(objtree)/tools/fdtgrep FORCE
$(call if_changed,fdtgrep)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 8f19b2db56..8f21653136 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -522,3 +522,21 @@ MKIMAGEOUTPUT ?= /dev/null
quiet_cmd_mkimage = MKIMAGE $@
cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \
$(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT))
+
+# fdtgrep
+# ---------------------------------------------------------------------------
+# Pass the original device tree file through fdtgrep twice. The first pass
+# removes any unwanted nodes (i.e. those which don't have the
+# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
+# pass removes various unused properties from the remaining nodes.
+# The output is typically a much smaller device tree file.
+ifeq ($(CONFIG_TPL_BUILD),y)
+fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
+else
+fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
+endif
+quiet_cmd_fdtgrep = FDTGREP $@
+ cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
+ -n /chosen -n /config -O dtb | \
+ $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
+ $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index 64390e5785..0af7cfe50c 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -50,6 +50,8 @@ endif
include $(srctree)/config.mk
include $(srctree)/arch/$(ARCH)/Makefile
+include scripts/Makefile.lib
+
# Enable garbage collection of un-used sections for SPL
KBUILD_CFLAGS += -ffunction-sections -fdata-sections
LDFLAGS_FINAL += --gc-sections
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH v2] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-02-13 6:56 ` [U-Boot] [PATCH v2] " Simon Goldschmidt
@ 2018-02-13 8:40 ` Lokesh Vutla
0 siblings, 0 replies; 12+ messages in thread
From: Lokesh Vutla @ 2018-02-13 8:40 UTC (permalink / raw)
To: u-boot
On Tuesday 13 February 2018 12:26 PM, Simon Goldschmidt wrote:
> With commit 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through
> fdtgrep"), CONFIG_SPL_MULTI_DTB_FIT has been broken because
> cmd_fdtgrep was now unknown in scripts/Makefile.spl after moving
> it to dts/Makefile. This bug has been introduced with v2018.01.
>
> This patch moves cmd_fdtgrep from dts/Makefile to scripts/Makefile.lib
> and includes scripts/Makefile.lib in scripts/Makefile.spl.
>
> Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep")
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
> ---
> Changes in v2:
> - move definition of cmd_fdtgrep to scripts/Makefile.lib instead of
> duplicating it
>
> dts/Makefile | 16 ----------------
> scripts/Makefile.lib | 18 ++++++++++++++++++
> scripts/Makefile.spl | 2 ++
> 3 files changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/dts/Makefile b/dts/Makefile
> index c9b2a89441..779c9ec5c3 100644
> --- a/dts/Makefile
> +++ b/dts/Makefile
> @@ -22,22 +22,6 @@ DTB := $(ARCH_PATH)/$(DEVICE_TREE).dtb
> dtb_depends += $(DTB:.dtb=.dts)
> endif
>
> -# Pass the original device tree file through fdtgrep twice. The first pass
> -# removes any unwanted nodes (i.e. those which don't have the
> -# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
> -# pass removes various unused properties from the remaining nodes.
> -# The output is typically a much smaller device tree file.
> -ifeq ($(CONFIG_TPL_BUILD),y)
> -fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
> -else
> -fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
> -endif
> -quiet_cmd_fdtgrep = FDTGREP $@
> - cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> - -n /chosen -n /config -O dtb | \
> - $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
> - $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
> -
> $(obj)/dt-spl.dtb: $(DTB) $(objtree)/tools/fdtgrep FORCE
> $(call if_changed,fdtgrep)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 8f19b2db56..8f21653136 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -522,3 +522,21 @@ MKIMAGEOUTPUT ?= /dev/null
> quiet_cmd_mkimage = MKIMAGE $@
> cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \
> $(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT))
> +
> +# fdtgrep
> +# ---------------------------------------------------------------------------
> +# Pass the original device tree file through fdtgrep twice. The first pass
> +# removes any unwanted nodes (i.e. those which don't have the
> +# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
> +# pass removes various unused properties from the remaining nodes.
> +# The output is typically a much smaller device tree file.
> +ifeq ($(CONFIG_TPL_BUILD),y)
> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
> +else
> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
> +endif
> +quiet_cmd_fdtgrep = FDTGREP $@
> + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> + -n /chosen -n /config -O dtb | \
> + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
> + $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> index 64390e5785..0af7cfe50c 100644
> --- a/scripts/Makefile.spl
> +++ b/scripts/Makefile.spl
> @@ -50,6 +50,8 @@ endif
> include $(srctree)/config.mk
> include $(srctree)/arch/$(ARCH)/Makefile
>
> +include scripts/Makefile.lib
you might want to append $(srctree)/ to scripts. Rest looks good to me.
Thanks and regards,
Lokesh
> +
> # Enable garbage collection of un-used sections for SPL
> KBUILD_CFLAGS += -ffunction-sections -fdata-sections
> LDFLAGS_FINAL += --gc-sections
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH v3] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-10 7:02 [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED Goldschmidt Simon
2018-01-10 8:48 ` Lokesh Vutla
2018-02-13 6:56 ` [U-Boot] [PATCH v2] " Simon Goldschmidt
@ 2018-02-14 5:44 ` Simon Goldschmidt
2018-02-14 6:36 ` Lokesh Vutla
2018-02-15 12:20 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 2 replies; 12+ messages in thread
From: Simon Goldschmidt @ 2018-02-14 5:44 UTC (permalink / raw)
To: u-boot
With commit 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through
fdtgrep"), CONFIG_SPL_MULTI_DTB_FIT has been broken because
cmd_fdtgrep was now unknown in scripts/Makefile.spl after moving
it to dts/Makefile. This bug has been introduced with v2018.01.
This patch moves cmd_fdtgrep from dts/Makefile to scripts/Makefile.lib
and includes scripts/Makefile.lib in scripts/Makefile.spl.
Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep")
Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
---
Changes in v3:
- append $(srctree)/ to scripts in Makefile.spl
Changes in v2:
- move definition of cmd_fdtgrep to scripts/Makefile.lib instead of
duplicating it
dts/Makefile | 16 ----------------
scripts/Makefile.lib | 18 ++++++++++++++++++
scripts/Makefile.spl | 2 ++
3 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/dts/Makefile b/dts/Makefile
index c9b2a89441..779c9ec5c3 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -22,22 +22,6 @@ DTB := $(ARCH_PATH)/$(DEVICE_TREE).dtb
dtb_depends += $(DTB:.dtb=.dts)
endif
-# Pass the original device tree file through fdtgrep twice. The first pass
-# removes any unwanted nodes (i.e. those which don't have the
-# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
-# pass removes various unused properties from the remaining nodes.
-# The output is typically a much smaller device tree file.
-ifeq ($(CONFIG_TPL_BUILD),y)
-fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
-else
-fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
-endif
-quiet_cmd_fdtgrep = FDTGREP $@
- cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
- -n /chosen -n /config -O dtb | \
- $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
- $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
-
$(obj)/dt-spl.dtb: $(DTB) $(objtree)/tools/fdtgrep FORCE
$(call if_changed,fdtgrep)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 8f19b2db56..8f21653136 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -522,3 +522,21 @@ MKIMAGEOUTPUT ?= /dev/null
quiet_cmd_mkimage = MKIMAGE $@
cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \
$(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT))
+
+# fdtgrep
+# ---------------------------------------------------------------------------
+# Pass the original device tree file through fdtgrep twice. The first pass
+# removes any unwanted nodes (i.e. those which don't have the
+# 'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The second
+# pass removes various unused properties from the remaining nodes.
+# The output is typically a much smaller device tree file.
+ifeq ($(CONFIG_TPL_BUILD),y)
+fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl
+else
+fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl
+endif
+quiet_cmd_fdtgrep = FDTGREP $@
+ cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
+ -n /chosen -n /config -O dtb | \
+ $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
+ $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index 64390e5785..0af7cfe50c 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -50,6 +50,8 @@ endif
include $(srctree)/config.mk
include $(srctree)/arch/$(ARCH)/Makefile
+include $(srctree)/scripts/Makefile.lib
+
# Enable garbage collection of un-used sections for SPL
KBUILD_CFLAGS += -ffunction-sections -fdata-sections
LDFLAGS_FINAL += --gc-sections
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH v3] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-02-14 5:44 ` [U-Boot] [PATCH v3] " Simon Goldschmidt
@ 2018-02-14 6:36 ` Lokesh Vutla
2018-02-15 12:20 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 12+ messages in thread
From: Lokesh Vutla @ 2018-02-14 6:36 UTC (permalink / raw)
To: u-boot
On Wednesday 14 February 2018 11:14 AM, Simon Goldschmidt wrote:
> With commit 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through
> fdtgrep"), CONFIG_SPL_MULTI_DTB_FIT has been broken because
> cmd_fdtgrep was now unknown in scripts/Makefile.spl after moving
> it to dts/Makefile. This bug has been introduced with v2018.01.
>
> This patch moves cmd_fdtgrep from dts/Makefile to scripts/Makefile.lib
> and includes scripts/Makefile.lib in scripts/Makefile.spl.
>
> Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep")
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v3] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-02-14 5:44 ` [U-Boot] [PATCH v3] " Simon Goldschmidt
2018-02-14 6:36 ` Lokesh Vutla
@ 2018-02-15 12:20 ` Tom Rini
1 sibling, 0 replies; 12+ messages in thread
From: Tom Rini @ 2018-02-15 12:20 UTC (permalink / raw)
To: u-boot
On Wed, Feb 14, 2018 at 06:44:36AM +0100, Simon Goldschmidt wrote:
> With commit 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through
> fdtgrep"), CONFIG_SPL_MULTI_DTB_FIT has been broken because
> cmd_fdtgrep was now unknown in scripts/Makefile.spl after moving
> it to dts/Makefile. This bug has been introduced with v2018.01.
>
> This patch moves cmd_fdtgrep from dts/Makefile to scripts/Makefile.lib
> and includes scripts/Makefile.lib in scripts/Makefile.spl.
>
> Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep")
> Reported-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180215/002b2d06/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-11 16:20 ` Tom Rini
@ 2018-01-15 6:57 ` Simon Goldschmidt
0 siblings, 0 replies; 12+ messages in thread
From: Simon Goldschmidt @ 2018-01-15 6:57 UTC (permalink / raw)
To: u-boot
On 11.01.2018 17:20, Tom Rini wrote:
> On Thu, Jan 11, 2018 at 07:55:03AM -0800, Simon Glass wrote:
>> Hi Lokesh,
>>
>> On 11 January 2018 at 00:33, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>>>
>>>
>>> On Wednesday 10 January 2018 07:40 PM, Goldschmidt Simon wrote:
>>>> On Wed, 10/01/18 09:48, Lokesh Vutla wrote:
>>>>> On Wednesday 10 January 2018 12:32 PM, Goldschmidt Simon wrote:
>>>>>> Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
>>>>>> moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
>>>>>> that the dtb is stripped in embedded mode, too.
>>>>>>
>>>>>> This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called from
>>>>>> scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
>>>>>> To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl at
>>>>>> the downside of having it duplicated in two makefiles.
>>>>> Missing Signed-off-by? Also a Reported-by credits would be nice :)
>>>> Right. I'll add that in a next version, sorry.
>>>>
>>>>>> ---
>>>>>> scripts/Makefile.spl | 16 ++++++++++++++++
>>>>>> 1 file changed, 16 insertions(+)
>>>>>>
>>>>>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index
>>>>>> 64390e5785..72e74f14c3 100644
>>>>>> --- a/scripts/Makefile.spl
>>>>>> +++ b/scripts/Makefile.spl
>>>>>> @@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
>>>>>> @bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size
>>>>> = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
>>>>>> dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
>>>>>>
>>>>>> +# Pass the original device tree file through fdtgrep twice. The first
>>>>>> +pass # removes any unwanted nodes (i.e. those which don't have the #
>>>>>> +'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The
>>>>>> +second # pass removes various unused properties from the remaining nodes.
>>>>>> +# The output is typically a much smaller device tree file.
>>>>>> +ifeq ($(CONFIG_TPL_BUILD),y)
>>>>>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl else
>>>>>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl endif
>>>>>> +quiet_cmd_fdtgrep = FDTGREP $@
>>>>>> + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
>>>>>> + -n /chosen -n /config -O dtb | \
>>>>>> + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
>>>>>> + $(addprefix -P ,$(subst
>>>>> $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
>>>>>> +
>>>>> hmm..we are duplicating code here. Why can't dtb build for
>>>>> CONFIG_OF_EMBED be moved to scripts/Makefile.spl?
>>>> I don't like the code duplication either. Back in November, I tried
>>>> to create the fdtgrep'ed ftd from Makefile.spl but failed. Seems I'm
>>>> not a pro in makefiles... Of course I'd appreciate it if you'd find
>>>> a solution for that!
>>> Simon, Tom,
>>> Any suggestions? Should we shift entire spl-dtb support to dts/Makefile?
>> We do try to keep logic out of the Makefiles in source-file subdirs,
>> reserving it for the main Makefile and those in scripts/.But
>> dts/Makefile is a bit of a special case, since there are no source
>> files there. I don't have a strong opinion either way.
> Welp, lets try shifting it then and see if things look cleaner overall
> then, thanks!
Hmm, I don't know where that would end. I like the idea of keeping
spl-dtb support in dts/Makefile.
Would it make sense to move the definition of fdtgrep to a common place
instead? Do we have one?
Simon
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-11 15:55 ` Simon Glass
@ 2018-01-11 16:20 ` Tom Rini
2018-01-15 6:57 ` Simon Goldschmidt
0 siblings, 1 reply; 12+ messages in thread
From: Tom Rini @ 2018-01-11 16:20 UTC (permalink / raw)
To: u-boot
On Thu, Jan 11, 2018 at 07:55:03AM -0800, Simon Glass wrote:
> Hi Lokesh,
>
> On 11 January 2018 at 00:33, Lokesh Vutla <lokeshvutla@ti.com> wrote:
> >
> >
> >
> > On Wednesday 10 January 2018 07:40 PM, Goldschmidt Simon wrote:
> > > On Wed, 10/01/18 09:48, Lokesh Vutla wrote:
> > >> On Wednesday 10 January 2018 12:32 PM, Goldschmidt Simon wrote:
> > >>> Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
> > >>> moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
> > >>> that the dtb is stripped in embedded mode, too.
> > >>>
> > >>> This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called from
> > >>> scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
> > >>> To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl at
> > >>> the downside of having it duplicated in two makefiles.
> > >>
> > >> Missing Signed-off-by? Also a Reported-by credits would be nice :)
> > >
> > > Right. I'll add that in a next version, sorry.
> > >
> > >>
> > >>> ---
> > >>> scripts/Makefile.spl | 16 ++++++++++++++++
> > >>> 1 file changed, 16 insertions(+)
> > >>>
> > >>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index
> > >>> 64390e5785..72e74f14c3 100644
> > >>> --- a/scripts/Makefile.spl
> > >>> +++ b/scripts/Makefile.spl
> > >>> @@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
> > >>> @bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size
> > >> = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
> > >>> dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
> > >>>
> > >>> +# Pass the original device tree file through fdtgrep twice. The first
> > >>> +pass # removes any unwanted nodes (i.e. those which don't have the #
> > >>> +'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The
> > >>> +second # pass removes various unused properties from the remaining nodes.
> > >>> +# The output is typically a much smaller device tree file.
> > >>> +ifeq ($(CONFIG_TPL_BUILD),y)
> > >>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl else
> > >>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl endif
> > >>> +quiet_cmd_fdtgrep = FDTGREP $@
> > >>> + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> > >>> + -n /chosen -n /config -O dtb | \
> > >>> + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
> > >>> + $(addprefix -P ,$(subst
> > >> $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
> > >>> +
> > >>
> > >> hmm..we are duplicating code here. Why can't dtb build for
> > >> CONFIG_OF_EMBED be moved to scripts/Makefile.spl?
> > >
> > > I don't like the code duplication either. Back in November, I tried
> > > to create the fdtgrep'ed ftd from Makefile.spl but failed. Seems I'm
> > > not a pro in makefiles... Of course I'd appreciate it if you'd find
> > > a solution for that!
> >
> > Simon, Tom,
> > Any suggestions? Should we shift entire spl-dtb support to dts/Makefile?
>
> We do try to keep logic out of the Makefiles in source-file subdirs,
> reserving it for the main Makefile and those in scripts/.But
> dts/Makefile is a bit of a special case, since there are no source
> files there. I don't have a strong opinion either way.
Welp, lets try shifting it then and see if things look cleaner overall
then, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180111/eb416d88/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-11 8:33 ` Lokesh Vutla
@ 2018-01-11 15:55 ` Simon Glass
2018-01-11 16:20 ` Tom Rini
0 siblings, 1 reply; 12+ messages in thread
From: Simon Glass @ 2018-01-11 15:55 UTC (permalink / raw)
To: u-boot
Hi Lokesh,
On 11 January 2018 at 00:33, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>
>
>
> On Wednesday 10 January 2018 07:40 PM, Goldschmidt Simon wrote:
> > On Wed, 10/01/18 09:48, Lokesh Vutla wrote:
> >> On Wednesday 10 January 2018 12:32 PM, Goldschmidt Simon wrote:
> >>> Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
> >>> moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
> >>> that the dtb is stripped in embedded mode, too.
> >>>
> >>> This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called from
> >>> scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
> >>> To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl at
> >>> the downside of having it duplicated in two makefiles.
> >>
> >> Missing Signed-off-by? Also a Reported-by credits would be nice :)
> >
> > Right. I'll add that in a next version, sorry.
> >
> >>
> >>> ---
> >>> scripts/Makefile.spl | 16 ++++++++++++++++
> >>> 1 file changed, 16 insertions(+)
> >>>
> >>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index
> >>> 64390e5785..72e74f14c3 100644
> >>> --- a/scripts/Makefile.spl
> >>> +++ b/scripts/Makefile.spl
> >>> @@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
> >>> @bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size
> >> = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
> >>> dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
> >>>
> >>> +# Pass the original device tree file through fdtgrep twice. The first
> >>> +pass # removes any unwanted nodes (i.e. those which don't have the #
> >>> +'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The
> >>> +second # pass removes various unused properties from the remaining nodes.
> >>> +# The output is typically a much smaller device tree file.
> >>> +ifeq ($(CONFIG_TPL_BUILD),y)
> >>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl else
> >>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl endif
> >>> +quiet_cmd_fdtgrep = FDTGREP $@
> >>> + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> >>> + -n /chosen -n /config -O dtb | \
> >>> + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
> >>> + $(addprefix -P ,$(subst
> >> $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
> >>> +
> >>
> >> hmm..we are duplicating code here. Why can't dtb build for
> >> CONFIG_OF_EMBED be moved to scripts/Makefile.spl?
> >
> > I don't like the code duplication either. Back in November, I tried
> > to create the fdtgrep'ed ftd from Makefile.spl but failed. Seems I'm
> > not a pro in makefiles... Of course I'd appreciate it if you'd find
> > a solution for that!
>
> Simon, Tom,
> Any suggestions? Should we shift entire spl-dtb support to dts/Makefile?
We do try to keep logic out of the Makefiles in source-file subdirs,
reserving it for the main Makefile and those in scripts/.But
dts/Makefile is a bit of a special case, since there are no source
files there. I don't have a strong opinion either way.
>
> Thanks and regards,
> Lokesh
>
> >
> > Regards,
> > Simon
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
2018-01-10 14:10 [U-Boot] [PATCH] " Goldschmidt Simon
@ 2018-01-11 8:33 ` Lokesh Vutla
2018-01-11 15:55 ` Simon Glass
0 siblings, 1 reply; 12+ messages in thread
From: Lokesh Vutla @ 2018-01-11 8:33 UTC (permalink / raw)
To: u-boot
On Wednesday 10 January 2018 07:40 PM, Goldschmidt Simon wrote:
> On Wed, 10/01/18 09:48, Lokesh Vutla wrote:
>> On Wednesday 10 January 2018 12:32 PM, Goldschmidt Simon wrote:
>>> Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
>>> moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
>>> that the dtb is stripped in embedded mode, too.
>>>
>>> This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called from
>>> scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
>>> To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl at
>>> the downside of having it duplicated in two makefiles.
>>
>> Missing Signed-off-by? Also a Reported-by credits would be nice :)
>
> Right. I'll add that in a next version, sorry.
>
>>
>>> ---
>>> scripts/Makefile.spl | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index
>>> 64390e5785..72e74f14c3 100644
>>> --- a/scripts/Makefile.spl
>>> +++ b/scripts/Makefile.spl
>>> @@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
>>> @bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size
>> = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
>>> dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
>>>
>>> +# Pass the original device tree file through fdtgrep twice. The first
>>> +pass # removes any unwanted nodes (i.e. those which don't have the #
>>> +'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The
>>> +second # pass removes various unused properties from the remaining nodes.
>>> +# The output is typically a much smaller device tree file.
>>> +ifeq ($(CONFIG_TPL_BUILD),y)
>>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl else
>>> +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl endif
>>> +quiet_cmd_fdtgrep = FDTGREP $@
>>> + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
>>> + -n /chosen -n /config -O dtb | \
>>> + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
>>> + $(addprefix -P ,$(subst
>> $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
>>> +
>>
>> hmm..we are duplicating code here. Why can't dtb build for
>> CONFIG_OF_EMBED be moved to scripts/Makefile.spl?
>
> I don't like the code duplication either. Back in November, I tried
> to create the fdtgrep'ed ftd from Makefile.spl but failed. Seems I'm
> not a pro in makefiles... Of course I'd appreciate it if you'd find
> a solution for that!
Simon, Tom,
Any suggestions? Should we shift entire spl-dtb support to dts/Makefile?
Thanks and regards,
Lokesh
>
> Regards,
> Simon
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED
@ 2018-01-10 14:10 Goldschmidt Simon
2018-01-11 8:33 ` Lokesh Vutla
0 siblings, 1 reply; 12+ messages in thread
From: Goldschmidt Simon @ 2018-01-10 14:10 UTC (permalink / raw)
To: u-boot
On Wed, 10/01/18 09:48, Lokesh Vutla wrote:
> On Wednesday 10 January 2018 12:32 PM, Goldschmidt Simon wrote:
> > Commit 9bd76b80 "spl: make CONFIG_OF_EMBED pass dts through fdtgrep"
> > moved the fdtgrep code from scripts/Makefile.spl to dts/Makefile so
> > that the dtb is stripped in embedded mode, too.
> >
> > This broke CONFIG_SPL_MULTI_DTB_FIT where fdtgrep is still called from
> > scripts/Makefile.spl to strip all dtbs in CONFIG_SPL_OF_LIST.
> > To fix that, cmd_fdtgrep is brought back into scripts/Makefile.spl at
> > the downside of having it duplicated in two makefiles.
>
> Missing Signed-off-by? Also a Reported-by credits would be nice :)
Right. I'll add that in a next version, sorry.
>
> > ---
> > scripts/Makefile.spl | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index
> > 64390e5785..72e74f14c3 100644
> > --- a/scripts/Makefile.spl
> > +++ b/scripts/Makefile.spl
> > @@ -239,6 +239,22 @@ $(obj)/$(SPL_BIN)-pad.bin: $(obj)/$(SPL_BIN)
> > @bss_size_str=$(shell $(NM) $< | awk 'BEGIN {size = 0} /__bss_size/ {size
> = $$1} END {print "ibase=16; " toupper(size)}' | bc); \
> > dd if=/dev/zero of=$@ bs=1 count=$${bss_size_str} 2>/dev/null;
> >
> > +# Pass the original device tree file through fdtgrep twice. The first
> > +pass # removes any unwanted nodes (i.e. those which don't have the #
> > +'u-boot,dm-pre-reloc' property and thus are not needed by SPL. The
> > +second # pass removes various unused properties from the remaining nodes.
> > +# The output is typically a much smaller device tree file.
> > +ifeq ($(CONFIG_TPL_BUILD),y)
> > +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-tpl else
> > +fdtgrep_props := -b u-boot,dm-pre-reloc -b u-boot,dm-spl endif
> > +quiet_cmd_fdtgrep = FDTGREP $@
> > + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> > + -n /chosen -n /config -O dtb | \
> > + $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
> > + $(addprefix -P ,$(subst
> $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))
> > +
>
> hmm..we are duplicating code here. Why can't dtb build for
> CONFIG_OF_EMBED be moved to scripts/Makefile.spl?
I don't like the code duplication either. Back in November, I tried
to create the fdtgrep'ed ftd from Makefile.spl but failed. Seems I'm
not a pro in makefiles... Of course I'd appreciate it if you'd find
a solution for that!
Regards,
Simon
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-02-15 12:20 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 7:02 [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED Goldschmidt Simon
2018-01-10 8:48 ` Lokesh Vutla
2018-02-13 6:56 ` [U-Boot] [PATCH v2] " Simon Goldschmidt
2018-02-13 8:40 ` Lokesh Vutla
2018-02-14 5:44 ` [U-Boot] [PATCH v3] " Simon Goldschmidt
2018-02-14 6:36 ` Lokesh Vutla
2018-02-15 12:20 ` [U-Boot] [U-Boot, " Tom Rini
2018-01-10 14:10 [U-Boot] [PATCH] " Goldschmidt Simon
2018-01-11 8:33 ` Lokesh Vutla
2018-01-11 15:55 ` Simon Glass
2018-01-11 16:20 ` Tom Rini
2018-01-15 6:57 ` Simon Goldschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.